This is an automated email from the ASF dual-hosted git repository. dongjoon pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/spark.git
The following commit(s) were added to refs/heads/master by this push: new 4d7b1ba986bc [SPARK-46748][CORE] Remove `*slave*.sh` scripts 4d7b1ba986bc is described below commit 4d7b1ba986bcbee91cce43084b043cff3da7d67c Author: Dongjoon Hyun <dh...@apple.com> AuthorDate: Wed Jan 17 18:26:32 2024 -0800 [SPARK-46748][CORE] Remove `*slave*.sh` scripts ### What changes were proposed in this pull request? As a part of SPARK-45869 (Revisit and Improve Spark Standalone Cluster), this PR aims to remove `*slave*` scripts from `sbin` directory for Apache Spark 4.0.0 codebase and binary distributions. ``` spark-3.5.0-bin-hadoop3:$ ls -al sbin/*slave* -rwxr-xr-x 1 dongjoon staff 981 Sep 8 19:08 sbin/decommission-slave.sh -rwxr-xr-x 1 dongjoon staff 957 Sep 8 19:08 sbin/slaves.sh -rwxr-xr-x 1 dongjoon staff 967 Sep 8 19:08 sbin/start-slave.sh -rwxr-xr-x 1 dongjoon staff 969 Sep 8 19:08 sbin/start-slaves.sh -rwxr-xr-x 1 dongjoon staff 965 Sep 8 19:08 sbin/stop-slave.sh -rwxr-xr-x 1 dongjoon staff 967 Sep 8 19:08 sbin/stop-slaves.sh ``` ### Why are the changes needed? `*slave*.sh` scripts are deprecated at Apache Spark 3.1.0 (March, 2021) via SPARK-32004 (July 2020). ### Does this PR introduce _any_ user-facing change? Yes, but - these are only wrapper scripts for legacy environments and were removed from all documents. - the new alternative corresponding scripts have been documented instead and used for last 3 years. - we can simplify the `sbin` directory of binary distributions for a better UX. - Apache Spark 4.0.0 is a good and the last chance to clean up these. ### How was this patch tested? Pass the CI and manual review. ### Was this patch authored or co-authored using generative AI tooling? No. Closes #44773 from dongjoon-hyun/SPARK-46748. Authored-by: Dongjoon Hyun <dh...@apple.com> Signed-off-by: Dongjoon Hyun <dh...@apple.com> --- sbin/decommission-slave.sh | 23 ----------------------- sbin/slaves.sh | 23 ----------------------- sbin/start-slave.sh | 23 ----------------------- sbin/start-slaves.sh | 23 ----------------------- sbin/stop-slave.sh | 23 ----------------------- sbin/stop-slaves.sh | 23 ----------------------- 6 files changed, 138 deletions(-) diff --git a/sbin/decommission-slave.sh b/sbin/decommission-slave.sh deleted file mode 100755 index 858bede1d287..000000000000 --- a/sbin/decommission-slave.sh +++ /dev/null @@ -1,23 +0,0 @@ -#!/usr/bin/env bash - -# -# Licensed to the Apache Software Foundation (ASF) under one or more -# contributor license agreements. See the NOTICE file distributed with -# this work for additional information regarding copyright ownership. -# The ASF licenses this file to You under the Apache License, Version 2.0 -# (the "License"); you may not use this file except in compliance with -# the License. You may obtain a copy of the License at -# -# http://www.apache.org/licenses/LICENSE-2.0 -# -# Unless required by applicable law or agreed to in writing, software -# distributed under the License is distributed on an "AS IS" BASIS, -# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. -# See the License for the specific language governing permissions and -# limitations under the License. -# - -DIR="$( cd "$( dirname "${BASH_SOURCE[0]}" )" >/dev/null 2>&1 && pwd )" - ->&2 echo "This script is deprecated, use decommission-worker.sh" -"${DIR}/decommission-worker.sh" "$@" diff --git a/sbin/slaves.sh b/sbin/slaves.sh deleted file mode 100755 index b92007ecdfad..000000000000 --- a/sbin/slaves.sh +++ /dev/null @@ -1,23 +0,0 @@ -#!/usr/bin/env bash - -# -# Licensed to the Apache Software Foundation (ASF) under one or more -# contributor license agreements. See the NOTICE file distributed with -# this work for additional information regarding copyright ownership. -# The ASF licenses this file to You under the Apache License, Version 2.0 -# (the "License"); you may not use this file except in compliance with -# the License. You may obtain a copy of the License at -# -# http://www.apache.org/licenses/LICENSE-2.0 -# -# Unless required by applicable law or agreed to in writing, software -# distributed under the License is distributed on an "AS IS" BASIS, -# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. -# See the License for the specific language governing permissions and -# limitations under the License. -# - -DIR="$( cd "$( dirname "${BASH_SOURCE[0]}" )" >/dev/null 2>&1 && pwd )" - ->&2 echo "This script is deprecated, use workers.sh" -"${DIR}/workers.sh" "$@" diff --git a/sbin/start-slave.sh b/sbin/start-slave.sh deleted file mode 100755 index 68682532f02e..000000000000 --- a/sbin/start-slave.sh +++ /dev/null @@ -1,23 +0,0 @@ -#!/usr/bin/env bash - -# -# Licensed to the Apache Software Foundation (ASF) under one or more -# contributor license agreements. See the NOTICE file distributed with -# this work for additional information regarding copyright ownership. -# The ASF licenses this file to You under the Apache License, Version 2.0 -# (the "License"); you may not use this file except in compliance with -# the License. You may obtain a copy of the License at -# -# http://www.apache.org/licenses/LICENSE-2.0 -# -# Unless required by applicable law or agreed to in writing, software -# distributed under the License is distributed on an "AS IS" BASIS, -# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. -# See the License for the specific language governing permissions and -# limitations under the License. -# - -DIR="$( cd "$( dirname "${BASH_SOURCE[0]}" )" >/dev/null 2>&1 && pwd )" - ->&2 echo "This script is deprecated, use start-worker.sh" -"${DIR}/start-worker.sh" "$@" diff --git a/sbin/start-slaves.sh b/sbin/start-slaves.sh deleted file mode 100755 index 9b113d9f2e0f..000000000000 --- a/sbin/start-slaves.sh +++ /dev/null @@ -1,23 +0,0 @@ -#!/usr/bin/env bash - -# -# Licensed to the Apache Software Foundation (ASF) under one or more -# contributor license agreements. See the NOTICE file distributed with -# this work for additional information regarding copyright ownership. -# The ASF licenses this file to You under the Apache License, Version 2.0 -# (the "License"); you may not use this file except in compliance with -# the License. You may obtain a copy of the License at -# -# http://www.apache.org/licenses/LICENSE-2.0 -# -# Unless required by applicable law or agreed to in writing, software -# distributed under the License is distributed on an "AS IS" BASIS, -# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. -# See the License for the specific language governing permissions and -# limitations under the License. -# - -DIR="$( cd "$( dirname "${BASH_SOURCE[0]}" )" >/dev/null 2>&1 && pwd )" - ->&2 echo "This script is deprecated, use start-workers.sh" -"${DIR}/start-workers.sh" "$@" diff --git a/sbin/stop-slave.sh b/sbin/stop-slave.sh deleted file mode 100755 index 71ed29987d4a..000000000000 --- a/sbin/stop-slave.sh +++ /dev/null @@ -1,23 +0,0 @@ -#!/usr/bin/env bash - -# -# Licensed to the Apache Software Foundation (ASF) under one or more -# contributor license agreements. See the NOTICE file distributed with -# this work for additional information regarding copyright ownership. -# The ASF licenses this file to You under the Apache License, Version 2.0 -# (the "License"); you may not use this file except in compliance with -# the License. You may obtain a copy of the License at -# -# http://www.apache.org/licenses/LICENSE-2.0 -# -# Unless required by applicable law or agreed to in writing, software -# distributed under the License is distributed on an "AS IS" BASIS, -# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. -# See the License for the specific language governing permissions and -# limitations under the License. -# - -DIR="$( cd "$( dirname "${BASH_SOURCE[0]}" )" >/dev/null 2>&1 && pwd )" - ->&2 echo "This script is deprecated, use stop-worker.sh" -"${DIR}/stop-worker.sh" "$@" diff --git a/sbin/stop-slaves.sh b/sbin/stop-slaves.sh deleted file mode 100755 index c0aca6868efe..000000000000 --- a/sbin/stop-slaves.sh +++ /dev/null @@ -1,23 +0,0 @@ -#!/usr/bin/env bash - -# -# Licensed to the Apache Software Foundation (ASF) under one or more -# contributor license agreements. See the NOTICE file distributed with -# this work for additional information regarding copyright ownership. -# The ASF licenses this file to You under the Apache License, Version 2.0 -# (the "License"); you may not use this file except in compliance with -# the License. You may obtain a copy of the License at -# -# http://www.apache.org/licenses/LICENSE-2.0 -# -# Unless required by applicable law or agreed to in writing, software -# distributed under the License is distributed on an "AS IS" BASIS, -# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. -# See the License for the specific language governing permissions and -# limitations under the License. -# - -DIR="$( cd "$( dirname "${BASH_SOURCE[0]}" )" >/dev/null 2>&1 && pwd )" - ->&2 echo "This script is deprecated, use stop-workers.sh" -"${DIR}/stop-workers.sh" "$@" --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@spark.apache.org For additional commands, e-mail: commits-h...@spark.apache.org