This is an automated email from the ASF dual-hosted git repository.
dongjoon pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/spark.git
The following commit(s) were added to refs/heads/master by this push:
new 56fe185c78a2 [SPARK-48163][CONNECT][TESTS] Disable
`SparkConnectServiceSuite.SPARK-43923: commands send events -
get_resources_command`
56fe185c78a2 is described below
commit 56fe185c78a249cf88b1d7e5d1e67444e1b224db
Author: Dongjoon Hyun <dh...@apple.com>
AuthorDate: Mon May 6 21:39:52 2024 -0700
[SPARK-48163][CONNECT][TESTS] Disable
`SparkConnectServiceSuite.SPARK-43923: commands send events -
get_resources_command`
### What changes were proposed in this pull request?
This PR aims to disable a flaky test,
`SparkConnectServiceSuite.SPARK-43923: commands send events -
get_resources_command`, temporarily.
To re-enable this, SPARK-48164 is created as a blocker issue for 4.0.0.
### Why are the changes needed?
This test case was added at `Apache Spark 3.5.0`, but it has been flaky and
causes many re-tries in our GitHub Action CI environment.
- https://github.com/apache/spark/pull/42454
- https://github.com/apache/spark/actions/runs/8979348499/job/24661200052
```
[info] - SPARK-43923: commands send events ((get_resources_command {
[info] }
[info] ,None)) *** FAILED *** (35 milliseconds)
[info] VerifyEvents.this.listener.executeHolder.isDefined was false
(SparkConnectServiceSuite.scala:873)
```
This PR aims to stabilize CI first and to focus this flaky issue as a
blocker level before going on `Spark Connect GA` in SPARK-48164 before Apache
Spark 4.0.0.
### Does this PR introduce _any_ user-facing change?
No.
### How was this patch tested?
Pass the CIs.
### Was this patch authored or co-authored using generative AI tooling?
No.
Closes #46425 from dongjoon-hyun/SPARK-48163.
Authored-by: Dongjoon Hyun <dh...@apple.com>
Signed-off-by: Dongjoon Hyun <dh...@apple.com>
---
.../apache/spark/sql/connect/planner/SparkConnectServiceSuite.scala | 3 +++
1 file changed, 3 insertions(+)
diff --git
a/connector/connect/server/src/test/scala/org/apache/spark/sql/connect/planner/SparkConnectServiceSuite.scala
b/connector/connect/server/src/test/scala/org/apache/spark/sql/connect/planner/SparkConnectServiceSuite.scala
index af18fca9dd21..59d9750c0fbf 100644
---
a/connector/connect/server/src/test/scala/org/apache/spark/sql/connect/planner/SparkConnectServiceSuite.scala
+++
b/connector/connect/server/src/test/scala/org/apache/spark/sql/connect/planner/SparkConnectServiceSuite.scala
@@ -418,11 +418,14 @@ class SparkConnectServiceSuite
.setInput(
proto.Relation.newBuilder().setSql(proto.SQL.newBuilder().setQuery("select
1")))),
None),
+ // TODO(SPARK-48164) Reenable `commands send events -
get_resources_command`
+ /*
(
proto.Command
.newBuilder()
.setGetResourcesCommand(proto.GetResourcesCommand.newBuilder()),
None),
+ */
(
proto.Command
.newBuilder()
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@spark.apache.org
For additional commands, e-mail: commits-h...@spark.apache.org
