[GitHub] [spark-website] viirya commented on a change in pull request #289: Release 3.0.1

2020-09-08 Thread GitBox 


viirya commented on a change in pull request #289:
URL: https://github.com/apache/spark-website/pull/289#discussion_r485342723



##
File path: site/developer-tools.html
##
@@ -505,8 +505,8 @@ Solving a binary incompatibility
 
 For the problem described above, we might add the following:
 
-// [SPARK-zz][CORE] Fix an issue
-ProblemFilters.exclude[DirectMissingMethodProblem]("org.apache.spark.SomeClass.this")
+// [SPARK-zz][CORE] Fix an issue
+ProblemFilters.exclude[DirectMissingMethodProblem]("org.apache.spark.SomeClass.this")

Review comment:
   I tried it locally. Just run `jekyll build` can reproduce these changes.





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: commits-unsubscr...@spark.apache.org
For additional commands, e-mail: commits-h...@spark.apache.org

[GitHub] [spark-website] viirya commented on a change in pull request #289: Release 3.0.1

2020-09-08 Thread GitBox 


viirya commented on a change in pull request #289:
URL: https://github.com/apache/spark-website/pull/289#discussion_r485312315



##
File path: site/developer-tools.html
##
@@ -505,8 +505,8 @@ Solving a binary incompatibility
 
 For the problem described above, we might add the following:
 
-// [SPARK-zz][CORE] Fix an issue
-ProblemFilters.exclude[DirectMissingMethodProblem]("org.apache.spark.SomeClass.this")
+// [SPARK-zz][CORE] Fix an issue
+ProblemFilters.exclude[DirectMissingMethodProblem]("org.apache.spark.SomeClass.this")

Review comment:
   oh ok. then it should be fine, i don't see change in developer-tools 
related to this, maybe related to jekyll.





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: commits-unsubscr...@spark.apache.org
For additional commands, e-mail: commits-h...@spark.apache.org

[GitHub] [spark-website] viirya commented on a change in pull request #289: Release 3.0.1

2020-09-08 Thread GitBox 


viirya commented on a change in pull request #289:
URL: https://github.com/apache/spark-website/pull/289#discussion_r485302593



##
File path: site/developer-tools.html
##
@@ -505,8 +505,8 @@ Solving a binary incompatibility
 
 For the problem described above, we might add the following:
 
-// [SPARK-zz][CORE] Fix an issue
-ProblemFilters.exclude[DirectMissingMethodProblem]("org.apache.spark.SomeClass.this")
+// [SPARK-zz][CORE] Fix an issue
+ProblemFilters.exclude[DirectMissingMethodProblem]("org.apache.spark.SomeClass.this")

Review comment:
   btw, do we have `class="py"`? I don't see `py` in the css in current 
site, or I missed it.





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: commits-unsubscr...@spark.apache.org
For additional commands, e-mail: commits-h...@spark.apache.org

[GitHub] [spark-website] viirya commented on a change in pull request #289: Release 3.0.1

2020-09-08 Thread GitBox 


viirya commented on a change in pull request #289:
URL: https://github.com/apache/spark-website/pull/289#discussion_r485301988



##
File path: site/developer-tools.html
##
@@ -505,8 +505,8 @@ Solving a binary incompatibility
 
 For the problem described above, we might add the following:
 
-// [SPARK-zz][CORE] Fix an issue
-ProblemFilters.exclude[DirectMissingMethodProblem]("org.apache.spark.SomeClass.this")
+// [SPARK-zz][CORE] Fix an issue
+ProblemFilters.exclude[DirectMissingMethodProblem]("org.apache.spark.SomeClass.this")

Review comment:
   why `nc` -> `nv`?





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: commits-unsubscr...@spark.apache.org
For additional commands, e-mail: commits-h...@spark.apache.org