This is an automated email from the ASF dual-hosted git repository.
gurwls223 pushed a commit to branch branch-2.4
in repository https://gitbox.apache.org/repos/asf/spark.git
The following commit(s) were added to refs/heads/branch-2.4 by this push:
new 6c61321 [SPARK-28582][PYTHON] Fix flaky test
DaemonTests.do_termination_test which fail on Python 3.7
6c61321 is described below
commit 6c613210cd1075f771376e7ecc6dfb08bd620716
Author: WeichenXu <weichen...@databricks.com>
AuthorDate: Sat Aug 3 10:31:15 2019 +0900
[SPARK-28582][PYTHON] Fix flaky test DaemonTests.do_termination_test which
fail on Python 3.7
This PR picks up https://github.com/apache/spark/pull/25315 back after
removing `Popen.wait` usage which exists in Python 3 only. I saw the last test
results wrongly and thought it was passed.
Fix flaky test DaemonTests.do_termination_test which fail on Python 3.7. I
add a sleep after the test connection to daemon.
Run test
```
python/run-tests --python-executables=python3.7 --testname
"pyspark.tests.test_daemon DaemonTests"
```
**Before**
Fail on test "test_termination_sigterm". And we can see daemon process do
not exit.
**After**
Test passed
Closes #25343 from HyukjinKwon/SPARK-28582.
Authored-by: WeichenXu <weichen...@databricks.com>
Signed-off-by: HyukjinKwon <gurwls...@apache.org>
(cherry picked from commit b3394db1930b3c9f55438cb27bb2c584bf041f8e)
Signed-off-by: HyukjinKwon <gurwls...@apache.org>
---
python/pyspark/tests.py | 3 +++
1 file changed, 3 insertions(+)
diff --git a/python/pyspark/tests.py b/python/pyspark/tests.py
index a2d825b..26c9126 100644
--- a/python/pyspark/tests.py
+++ b/python/pyspark/tests.py
@@ -1939,6 +1939,9 @@ class DaemonTests(unittest.TestCase):
# daemon should accept connections
self.assertTrue(self.connect(port))
+ # wait worker process spawned from daemon exit.
+ time.sleep(1)
+
# request shutdown
terminator(daemon)
time.sleep(1)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@spark.apache.org
For additional commands, e-mail: commits-h...@spark.apache.org
