This is an automated email from the ASF dual-hosted git repository.

dongjoon pushed a commit to branch branch-2.4
in repository https://gitbox.apache.org/repos/asf/spark.git


The following commit(s) were added to refs/heads/branch-2.4 by this push:
     new 7a8af18  [SPARK-33631][DOCS][TEST] Clean up 
spark.core.connection.ack.wait.timeout from configuration.md
7a8af18 is described below

commit 7a8af183a7f277e3d5f75eb5d27db46ccb9ecd93
Author: yangjie01 <yangji...@baidu.com>
AuthorDate: Wed Dec 2 12:58:41 2020 -0800

    [SPARK-33631][DOCS][TEST] Clean up spark.core.connection.ack.wait.timeout 
from configuration.md
    
    SPARK-9767  remove `ConnectionManager` and related files, the configuration 
`spark.core.connection.ack.wait.timeout` previously used by `ConnectionManager` 
is no longer used by other Spark code, but it still exists in the 
`configuration.md`.
    
    So this pr cleans up the useless configuration item 
spark.core.connection.ack.wait.timeout` from `configuration.md`.
    
    Clean up useless configuration from `configuration.md`.
    
    No
    
    Pass the Jenkins or GitHub Action
    
    Closes #30569 from LuciferYang/SPARK-33631.
    
    Authored-by: yangjie01 <yangji...@baidu.com>
    Signed-off-by: Dongjoon Hyun <dongj...@apache.org>
    (cherry picked from commit 92bfbcb2e372e8fecfe65bc582c779d9df4036bb)
    Signed-off-by: Dongjoon Hyun <dongj...@apache.org>
---
 .../apache/spark/storage/BlockManagerReplicationSuite.scala    |  2 --
 docs/configuration.md                                          | 10 ----------
 2 files changed, 12 deletions(-)

diff --git 
a/core/src/test/scala/org/apache/spark/storage/BlockManagerReplicationSuite.scala
 
b/core/src/test/scala/org/apache/spark/storage/BlockManagerReplicationSuite.scala
index 3962bdc..bfff101 100644
--- 
a/core/src/test/scala/org/apache/spark/storage/BlockManagerReplicationSuite.scala
+++ 
b/core/src/test/scala/org/apache/spark/storage/BlockManagerReplicationSuite.scala
@@ -93,8 +93,6 @@ trait BlockManagerReplicationBehavior extends SparkFunSuite
     conf.set("spark.storage.unrollFraction", "0.4")
     conf.set("spark.storage.unrollMemoryThreshold", "512")
 
-    // to make a replication attempt to inactive store fail fast
-    conf.set("spark.core.connection.ack.wait.timeout", "1s")
     // to make cached peers refresh frequently
     conf.set("spark.storage.cachedPeersTtl", "10")
 
diff --git a/docs/configuration.md b/docs/configuration.md
index 6bb1bda..a6aef5d 100644
--- a/docs/configuration.md
+++ b/docs/configuration.md
@@ -1473,7 +1473,6 @@ Apart from these, the following properties are also 
available, and may be useful
   <td>120s</td>
   <td>
     Default timeout for all network interactions. This config will be used in 
place of
-    <code>spark.core.connection.ack.wait.timeout</code>,
     <code>spark.storage.blockManagerSlaveTimeoutMs</code>,
     <code>spark.shuffle.io.connectionTimeout</code>, 
<code>spark.rpc.askTimeout</code> or
     <code>spark.rpc.lookupTimeout</code> if they are not configured.
@@ -1519,15 +1518,6 @@ Apart from these, the following properties are also 
available, and may be useful
     Duration for an RPC remote endpoint lookup operation to wait before timing 
out.
   </td>
 </tr>
-<tr>
-  <td><code>spark.core.connection.ack.wait.timeout</code></td>
-  <td><code>spark.network.timeout</code></td>
-  <td>
-    How long for the connection to wait for ack to occur before timing
-    out and giving up. To avoid unwilling timeout caused by long pause like GC,
-    you can set larger value.
-  </td>
-</tr>
 </table>
 
 ### Scheduling


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@spark.apache.org
For additional commands, e-mail: commits-h...@spark.apache.org

Reply via email to