[spark] branch branch-2.4 updated: [SPARK-34834][NETWORK] Fix a potential Netty memory leak in TransportResponseHandler

[srowen]

This is an automated email from the ASF dual-hosted git repository.

srowen pushed a commit to branch branch-2.4
in repository https://gitbox.apache.org/repos/asf/spark.git


The following commit(s) were added to refs/heads/branch-2.4 by this push:
     new d4b9719  [SPARK-34834][NETWORK] Fix a potential Netty memory leak in 
TransportResponseHandler
d4b9719 is described below

commit d4b9719a85ae2c9aa842ef9ed36db890815d5688
Author: weixiuli <weixi...@jd.com>
AuthorDate: Wed Apr 14 11:44:48 2021 -0500

    [SPARK-34834][NETWORK] Fix a potential Netty memory leak in 
TransportResponseHandler
    
    ### What changes were proposed in this pull request?
    There is a potential Netty memory leak in TransportResponseHandler.
    
    ### Why are the changes needed?
    Fix a potential Netty memory leak in TransportResponseHandler.
    
    ### Does this PR introduce _any_ user-facing change?
    NO
    
    ### How was this patch tested?
    NO
    
    Closes #31942 from weixiuli/SPARK-34834.
    
    Authored-by: weixiuli <weixi...@jd.com>
    Signed-off-by: Sean Owen <sro...@gmail.com>
    (cherry picked from commit bf9f3b884fcd6bd3428898581d4b5dca9bae6538)
    Signed-off-by: Sean Owen <sro...@gmail.com>
---
 .../java/org/apache/spark/network/client/TransportResponseHandler.java   | 1 +
 1 file changed, 1 insertion(+)

diff --git 
a/common/network-common/src/main/java/org/apache/spark/network/client/TransportResponseHandler.java
 
b/common/network-common/src/main/java/org/apache/spark/network/client/TransportResponseHandler.java
index 596b0ea..3863731 100644
--- 
a/common/network-common/src/main/java/org/apache/spark/network/client/TransportResponseHandler.java
+++ 
b/common/network-common/src/main/java/org/apache/spark/network/client/TransportResponseHandler.java
@@ -188,6 +188,7 @@ public class TransportResponseHandler extends 
MessageHandler<ResponseMessage> {
       if (listener == null) {
         logger.warn("Ignoring response for RPC {} from {} ({} bytes) since it 
is not outstanding",
           resp.requestId, getRemoteAddress(channel), resp.body().size());
+        resp.body().release();
       } else {
         outstandingRpcs.remove(resp.requestId);
         try {

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@spark.apache.org
For additional commands, e-mail: commits-h...@spark.apache.org