This is an automated email from the ASF dual-hosted git repository. dongjoon pushed a commit to branch branch-3.3 in repository https://gitbox.apache.org/repos/asf/spark.git
The following commit(s) were added to refs/heads/branch-3.3 by this push: new 5e68c98bff9 [SPARK-41385][K8S] Replace deprecated `.newInstance()` in K8s module 5e68c98bff9 is described below commit 5e68c98bff9d66c15ec71745b6fb91f938580094 Author: Dongjoon Hyun <dh...@apple.com> AuthorDate: Sun Dec 4 22:26:35 2022 -0800 [SPARK-41385][K8S] Replace deprecated `.newInstance()` in K8s module ### What changes were proposed in this pull request? This PR aims to replace the deprecated `Class.newInstance` with `Class.getConstructor.newInstance`. ### Why are the changes needed? SPARK-25984 removed these instances at Spark 3.0.0. SPARK-37145 introduced newly two instances at Spark 3.3.0. ``` $ git grep classForName | grep newInstance | grep -v getConstructor resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/submit/KubernetesDriverBuilder.scala: val feature = Utils.classForName[Any](className).newInstance() resource-managers/kubernetes/core/src/main/scala/org/apache/spark/scheduler/cluster/k8s/KubernetesExecutorBuilder.scala: val feature = Utils.classForName[Any](className).newInstance() ``` ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Pass the CIs. Closes #38909 from dongjoon-hyun/SPARK-41385. Authored-by: Dongjoon Hyun <dh...@apple.com> Signed-off-by: Dongjoon Hyun <dongj...@apache.org> (cherry picked from commit 94829065f677221938d00f77e60a07bcccecf9d4) Signed-off-by: Dongjoon Hyun <dongj...@apache.org> --- .../org/apache/spark/deploy/k8s/submit/KubernetesDriverBuilder.scala | 2 +- .../apache/spark/scheduler/cluster/k8s/KubernetesExecutorBuilder.scala | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/submit/KubernetesDriverBuilder.scala b/resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/submit/KubernetesDriverBuilder.scala index e89e52f1af2..3b69754b9cd 100644 --- a/resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/submit/KubernetesDriverBuilder.scala +++ b/resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/submit/KubernetesDriverBuilder.scala @@ -40,7 +40,7 @@ private[spark] class KubernetesDriverBuilder { val userFeatures = conf.get(Config.KUBERNETES_DRIVER_POD_FEATURE_STEPS) .map { className => - val feature = Utils.classForName[Any](className).newInstance() + val feature = Utils.classForName[Any](className).getConstructor().newInstance() val initializedFeature = feature match { // Since 3.3, allow user to implement feature with KubernetesDriverConf case d: KubernetesDriverCustomFeatureConfigStep => diff --git a/resource-managers/kubernetes/core/src/main/scala/org/apache/spark/scheduler/cluster/k8s/KubernetesExecutorBuilder.scala b/resource-managers/kubernetes/core/src/main/scala/org/apache/spark/scheduler/cluster/k8s/KubernetesExecutorBuilder.scala index 1f6d72cb7ee..67aad00f985 100644 --- a/resource-managers/kubernetes/core/src/main/scala/org/apache/spark/scheduler/cluster/k8s/KubernetesExecutorBuilder.scala +++ b/resource-managers/kubernetes/core/src/main/scala/org/apache/spark/scheduler/cluster/k8s/KubernetesExecutorBuilder.scala @@ -43,7 +43,7 @@ private[spark] class KubernetesExecutorBuilder { val userFeatures = conf.get(Config.KUBERNETES_EXECUTOR_POD_FEATURE_STEPS) .map { className => - val feature = Utils.classForName[Any](className).newInstance() + val feature = Utils.classForName[Any](className).getConstructor().newInstance() val initializedFeature = feature match { // Since 3.3, allow user to implement feature with KubernetesExecutorConf case e: KubernetesExecutorCustomFeatureConfigStep => --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@spark.apache.org For additional commands, e-mail: commits-h...@spark.apache.org