This is an automated email from the ASF dual-hosted git repository.
gurwls223 pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/spark.git
The following commit(s) were added to refs/heads/master by this push:
new e4a968d [MINOR][CORE] Remove import scala.collection.Set in
TaskSchedulerImpl
e4a968d is described below
commit e4a968d82947a68d2daedc8e5fb9adf57cf9bd5b
Author: Wenchen Fan <wenc...@databricks.com>
AuthorDate: Thu Mar 28 21:12:18 2019 +0900
[MINOR][CORE] Remove import scala.collection.Set in TaskSchedulerImpl
## What changes were proposed in this pull request?
I was playing with the scheduler and found this weird thing. In
`TaskSchedulerImpl` we import `scala.collection.Set` without any reason. This
is bad in practice, as it silently changes the actual class when we simply type
`Set`, which by default should point to the immutable set.
This change only affects one method: `getExecutorsAliveOnHost`. I checked
all the caller side and none of them need a general `Set` type.
## How was this patch tested?
N/A
Closes #24231 from cloud-fan/minor.
Authored-by: Wenchen Fan <wenc...@databricks.com>
Signed-off-by: Hyukjin Kwon <gurwls...@apache.org>
---
.../main/scala/org/apache/spark/scheduler/TaskSchedulerImpl.scala | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git
a/core/src/main/scala/org/apache/spark/scheduler/TaskSchedulerImpl.scala
b/core/src/main/scala/org/apache/spark/scheduler/TaskSchedulerImpl.scala
index db0fbfe..1ef3566 100644
--- a/core/src/main/scala/org/apache/spark/scheduler/TaskSchedulerImpl.scala
+++ b/core/src/main/scala/org/apache/spark/scheduler/TaskSchedulerImpl.scala
@@ -22,7 +22,6 @@ import java.util.{Locale, Timer, TimerTask}
import java.util.concurrent.{ConcurrentHashMap, TimeUnit}
import java.util.concurrent.atomic.AtomicLong
-import scala.collection.Set
import scala.collection.mutable.{ArrayBuffer, BitSet, HashMap, HashSet}
import scala.util.Random
@@ -829,8 +828,8 @@ private[spark] class TaskSchedulerImpl(
* Get a snapshot of the currently blacklisted nodes for the entire
application. This is
* thread-safe -- it can be called without a lock on the TaskScheduler.
*/
- def nodeBlacklist(): scala.collection.immutable.Set[String] = {
-
blacklistTrackerOpt.map(_.nodeBlacklist()).getOrElse(scala.collection.immutable.Set())
+ def nodeBlacklist(): Set[String] = {
+ blacklistTrackerOpt.map(_.nodeBlacklist()).getOrElse(Set.empty)
}
// By default, rack is unknown
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@spark.apache.org
For additional commands, e-mail: commits-h...@spark.apache.org
