This is an automated email from the ASF dual-hosted git repository.

gurwls223 pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/spark.git


The following commit(s) were added to refs/heads/master by this push:
     new a02bf2bb17e [SPARK-41846][CONNECT][PYTHON] Enable doctests for window 
functions
a02bf2bb17e is described below

commit a02bf2bb17e049eaa7aa26561876560c26396bbd
Author: Ruifeng Zheng <ruife...@apache.org>
AuthorDate: Thu Jan 5 08:50:09 2023 +0900

    [SPARK-41846][CONNECT][PYTHON] Enable doctests for window functions
    
    ### What changes were proposed in this pull request?
     Enable doctests for window functions
    
    ### Why are the changes needed?
    for test coverage
    
    ### Does this PR introduce _any_ user-facing change?
    No
    
    ### How was this patch tested?
    enabled tests
    
    Closes #39392 from zhengruifeng/connect_fix_41846.
    
    Authored-by: Ruifeng Zheng <ruife...@apache.org>
    Signed-off-by: Hyukjin Kwon <gurwls...@apache.org>
---
 python/pyspark/sql/connect/functions.py | 6 ------
 1 file changed, 6 deletions(-)

diff --git a/python/pyspark/sql/connect/functions.py 
b/python/pyspark/sql/connect/functions.py
index 05ba52aa377..77c7db2d808 100644
--- a/python/pyspark/sql/connect/functions.py
+++ b/python/pyspark/sql/connect/functions.py
@@ -2418,12 +2418,6 @@ def _test() -> None:
         # TODO(SPARK-41845): Fix count bug
         del pyspark.sql.connect.functions.count.__doc__
 
-        # TODO(SPARK-41846): window functions : unresolved columns
-        del pyspark.sql.connect.functions.rank.__doc__
-        del pyspark.sql.connect.functions.cume_dist.__doc__
-        del pyspark.sql.connect.functions.dense_rank.__doc__
-        del pyspark.sql.connect.functions.percent_rank.__doc__
-
         # TODO(SPARK-41847): mapfield,structlist invalid type
         del pyspark.sql.connect.functions.element_at.__doc__
         del pyspark.sql.connect.functions.explode.__doc__


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@spark.apache.org
For additional commands, e-mail: commits-h...@spark.apache.org

Reply via email to