Re: [PR] Fix version dropdown issue in version 3.5.1 of pyspark document [spark-website]
panbingkun commented on PR #507: URL: https://github.com/apache/spark-website/pull/507#issuecomment-2041706595 > Also, will the json file be updated automatically, or is release manager expected to manually add the entry? If it's latter, we'll need to update the release process page in Spark website. Currently, it needs to be manually updated. Let me update the release process page in Spark website, and then I will think of a way to automate it. 😄 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@spark.apache.org For additional commands, e-mail: commits-h...@spark.apache.org
Re: [PR] Fix version dropdown issue in version 3.5.1 of pyspark document [spark-website]
panbingkun commented on PR #507: URL: https://github.com/apache/spark-website/pull/507#issuecomment-2041704111 > Sorry to visit this too lately. Definitely we need to fix the version in 3.5.1. It'd be awesome if you could submit a PR for the fix. Thanks! Sure, let me do it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@spark.apache.org For additional commands, e-mail: commits-h...@spark.apache.org
Re: [PR] Fix version dropdown issue in version 3.5.1 of pyspark document [spark-website]
HeartSaVioR commented on PR #507: URL: https://github.com/apache/spark-website/pull/507#issuecomment-2041698402 Also, will the json file be updated automatically, or is release manager expected to manually add the entry? If it's latter, we'll need to update the release process page in Spark website. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@spark.apache.org For additional commands, e-mail: commits-h...@spark.apache.org
Re: [PR] Fix version dropdown issue in version 3.5.1 of pyspark document [spark-website]
HeartSaVioR commented on PR #507: URL: https://github.com/apache/spark-website/pull/507#issuecomment-2041626496 @panbingkun Sorry to visit this too lately. Definitely we need to fix the version in 3.5.1. It'd be awesome if you could submit a PR for the fix. Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@spark.apache.org For additional commands, e-mail: commits-h...@spark.apache.org
Re: [PR] Fix version dropdown issue in version 3.5.1 of pyspark document [spark-website]
panbingkun commented on PR #507: URL: https://github.com/apache/spark-website/pull/507#issuecomment-1984987418 @HeartSaVioR https://github.com/apache/spark-website/assets/15246973/28953649-6df0-4c34-86b2-b1c2f23f2e76";> Not related to this PR, in addition, I found a `flaw` in our `online 3.5.1 pyspark documentation`, which is also likely caused by the `unset` the local environment variable `RELEASE_VERSION `. If it needs to be fixed, I am also very happy to use tools to `fix` it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@spark.apache.org For additional commands, e-mail: commits-h...@spark.apache.org
Re: [PR] Fix version dropdown issue in version 3.5.1 of pyspark document [spark-website]
panbingkun commented on PR #507: URL: https://github.com/apache/spark-website/pull/507#issuecomment-1984980538 @HeartSaVioR In addition, I have submitted a PR regarding `Use the same versions.json in the dropdown of different versions of PySpark documents`: https://github.com/apache/spark/pull/45400 In order to ensure the `correctness` of the dropdown data, we should `merge` this PR before the next version release. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@spark.apache.org For additional commands, e-mail: commits-h...@spark.apache.org
Re: [PR] Fix version dropdown issue in version 3.5.1 of pyspark document [spark-website]
panbingkun commented on PR #507: URL: https://github.com/apache/spark-website/pull/507#issuecomment-1984977858 The verification steps are as follows: - export RELEASE_VERSION=3.5.2 - git checkout branch-3.5 - git tag v3.5.2 - cd python/docs - make clean html - Check the content of the generated html file, such as: https://github.com/apache/spark-website/assets/15246973/f3c28842-791c-4947-be38-ac6366f36bd8";> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@spark.apache.org For additional commands, e-mail: commits-h...@spark.apache.org
Re: [PR] Fix version dropdown issue in version 3.5.1 of pyspark document [spark-website]
panbingkun commented on PR #507: URL: https://github.com/apache/spark-website/pull/507#issuecomment-1984890327 > @panbingkun Nice, thanks for the work! Followup question. > > The version showing as master is confusing. when the version has constructed and which information it will refer to? I built the doc with v3.5.1 tag and the version is shown as master. > > Could you please give a try with tagging 3.5.2 from branch-3.5 in your fork repository and build the doc to confirm it won't show up as `master`? Sure, let me check! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@spark.apache.org For additional commands, e-mail: commits-h...@spark.apache.org
Re: [PR] Fix version dropdown issue in version 3.5.1 of pyspark document [spark-website]
HeartSaVioR commented on PR #507: URL: https://github.com/apache/spark-website/pull/507#issuecomment-1982481712 @panbingkun Nice, thanks for the work! Followup question. The version showing as master is confusing. when the version has constructed and which information it will refer to? I built the doc with v3.5.1 tag and the version is shown as master. Could you please give a try with tagging 3.5.2 from branch-3.5 in your fork repository and build the doc to confirm it won't show up as `master`? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@spark.apache.org For additional commands, e-mail: commits-h...@spark.apache.org
Re: [PR] Fix version dropdown issue in version 3.5.1 of pyspark document [spark-website]
panbingkun commented on PR #507: URL: https://github.com/apache/spark-website/pull/507#issuecomment-1980027108 At present, it has been restored to its `correct state`. https://spark.apache.org/docs/3.5.1/api/python/index.html https://github.com/apache/spark-website/assets/15246973/87769ff5-0753-4db4-b12d-9cc0c7c88ffb";> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@spark.apache.org For additional commands, e-mail: commits-h...@spark.apache.org
Re: [PR] Fix version dropdown issue in version 3.5.1 of pyspark document [spark-website]
HyukjinKwon closed pull request #507: Fix version dropdown issue in version 3.5.1 of pyspark document URL: https://github.com/apache/spark-website/pull/507 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@spark.apache.org For additional commands, e-mail: commits-h...@spark.apache.org
Re: [PR] Fix version dropdown issue in version 3.5.1 of pyspark document [spark-website]
HyukjinKwon commented on PR #507: URL: https://github.com/apache/spark-website/pull/507#issuecomment-1980007119 Merged to asf-site. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@spark.apache.org For additional commands, e-mail: commits-h...@spark.apache.org
Re: [PR] Fix version dropdown issue in version 3.5.1 of pyspark document [spark-website]
panbingkun commented on PR #507: URL: https://github.com/apache/spark-website/pull/507#issuecomment-1979960632 > Let me check the reason for the `build` failure and wait a moment. Done. The issue of `build failure` has been resolved. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@spark.apache.org For additional commands, e-mail: commits-h...@spark.apache.org
Re: [PR] Fix version dropdown issue in version 3.5.1 of pyspark document [spark-website]
panbingkun commented on PR #507: URL: https://github.com/apache/spark-website/pull/507#issuecomment-1979957859 Double-check as follows: https://github.com/apache/spark-website/assets/15246973/b662e7bc-fe17-49d1-8a2e-64efba19185a";> https://github.com/apache/spark-website/assets/15246973/31b35a92-5c80-43b4-8221-49611bbb0654";> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@spark.apache.org For additional commands, e-mail: commits-h...@spark.apache.org
Re: [PR] Fix version dropdown issue in version 3.5.1 of pyspark document [spark-website]
panbingkun commented on PR #507: URL: https://github.com/apache/spark-website/pull/507#issuecomment-1979859196 Let me check the reason for the `build` failure and wait a moment. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@spark.apache.org For additional commands, e-mail: commits-h...@spark.apache.org
