spark git commit: [SPARK-11732] Removes some MiMa false positives

2015-11-17 Thread srowen 
Repository: spark
Updated Branches:
  refs/heads/branch-1.6 5047e675e -> b468f8171


[SPARK-11732] Removes some MiMa false positives

This adds an extra filter for private or protected classes. We only filter for 
package private right now.

Author: Timothy Hunter 

Closes #9697 from thunterdb/spark-11732.

(cherry picked from commit fa603e08de641df16d066302be5d5f92a60a923e)
Signed-off-by: Sean Owen 


Project: http://git-wip-us.apache.org/repos/asf/spark/repo
Commit: http://git-wip-us.apache.org/repos/asf/spark/commit/b468f817
Tree: http://git-wip-us.apache.org/repos/asf/spark/tree/b468f817
Diff: http://git-wip-us.apache.org/repos/asf/spark/diff/b468f817

Branch: refs/heads/branch-1.6
Commit: b468f8171c8e1dc4a13b9cb66065593e12267a34
Parents: 5047e67
Author: Timothy Hunter 
Authored: Tue Nov 17 20:51:20 2015 +
Committer: Sean Owen 
Committed: Tue Nov 17 20:51:31 2015 +

--
 project/MimaExcludes.scala| 7 +--
 .../scala/org/apache/spark/tools/GenerateMIMAIgnore.scala | 4 +++-
 2 files changed, 4 insertions(+), 7 deletions(-)
--


http://git-wip-us.apache.org/repos/asf/spark/blob/b468f817/project/MimaExcludes.scala
--
diff --git a/project/MimaExcludes.scala b/project/MimaExcludes.scala
index 8159518..8b3bc96 100644
--- a/project/MimaExcludes.scala
+++ b/project/MimaExcludes.scala
@@ -54,12 +54,7 @@ object MimaExcludes {
   MimaBuild.excludeSparkClass("streaming.flume.FlumeTestUtils") ++
   MimaBuild.excludeSparkClass("streaming.flume.PollingFlumeTestUtils") ++
   Seq(
-ProblemFilters.exclude[MissingMethodProblem](
-  "org.apache.spark.ml.classification.LogisticCostFun.this"),
-ProblemFilters.exclude[MissingMethodProblem](
-  "org.apache.spark.ml.classification.LogisticAggregator.add"),
-ProblemFilters.exclude[MissingMethodProblem](
-  "org.apache.spark.ml.classification.LogisticAggregator.count"),
+// MiMa does not deal properly with sealed traits
 ProblemFilters.exclude[MissingMethodProblem](
   
"org.apache.spark.ml.classification.LogisticRegressionSummary.featuresCol")
   ) ++ Seq(

http://git-wip-us.apache.org/repos/asf/spark/blob/b468f817/tools/src/main/scala/org/apache/spark/tools/GenerateMIMAIgnore.scala
--
diff --git 
a/tools/src/main/scala/org/apache/spark/tools/GenerateMIMAIgnore.scala 
b/tools/src/main/scala/org/apache/spark/tools/GenerateMIMAIgnore.scala
index a0524ca..5155daa 100644
--- a/tools/src/main/scala/org/apache/spark/tools/GenerateMIMAIgnore.scala
+++ b/tools/src/main/scala/org/apache/spark/tools/GenerateMIMAIgnore.scala
@@ -72,7 +72,9 @@ object GenerateMIMAIgnore {
 val classSymbol = mirror.classSymbol(Class.forName(className, false, 
classLoader))
 val moduleSymbol = mirror.staticModule(className)
 val directlyPrivateSpark =
-  isPackagePrivate(classSymbol) || isPackagePrivateModule(moduleSymbol)
+  isPackagePrivate(classSymbol) ||
+  isPackagePrivateModule(moduleSymbol) ||
+  classSymbol.isPrivate
 val developerApi = isDeveloperApi(classSymbol) || 
isDeveloperApi(moduleSymbol)
 val experimental = isExperimental(classSymbol) || 
isExperimental(moduleSymbol)
 /* Inner classes defined within a private[spark] class or object are 
effectively


-
To unsubscribe, e-mail: commits-unsubscr...@spark.apache.org
For additional commands, e-mail: commits-h...@spark.apache.org

spark git commit: [SPARK-11732] Removes some MiMa false positives

2015-11-17 Thread srowen 
Repository: spark
Updated Branches:
  refs/heads/master 5aca6ad00 -> fa603e08d


[SPARK-11732] Removes some MiMa false positives

This adds an extra filter for private or protected classes. We only filter for 
package private right now.

Author: Timothy Hunter 

Closes #9697 from thunterdb/spark-11732.


Project: http://git-wip-us.apache.org/repos/asf/spark/repo
Commit: http://git-wip-us.apache.org/repos/asf/spark/commit/fa603e08
Tree: http://git-wip-us.apache.org/repos/asf/spark/tree/fa603e08
Diff: http://git-wip-us.apache.org/repos/asf/spark/diff/fa603e08

Branch: refs/heads/master
Commit: fa603e08de641df16d066302be5d5f92a60a923e
Parents: 5aca6ad
Author: Timothy Hunter 
Authored: Tue Nov 17 20:51:20 2015 +
Committer: Sean Owen 
Committed: Tue Nov 17 20:51:20 2015 +

--
 project/MimaExcludes.scala| 7 +--
 .../scala/org/apache/spark/tools/GenerateMIMAIgnore.scala | 4 +++-
 2 files changed, 4 insertions(+), 7 deletions(-)
--


http://git-wip-us.apache.org/repos/asf/spark/blob/fa603e08/project/MimaExcludes.scala
--
diff --git a/project/MimaExcludes.scala b/project/MimaExcludes.scala
index 8159518..8b3bc96 100644
--- a/project/MimaExcludes.scala
+++ b/project/MimaExcludes.scala
@@ -54,12 +54,7 @@ object MimaExcludes {
   MimaBuild.excludeSparkClass("streaming.flume.FlumeTestUtils") ++
   MimaBuild.excludeSparkClass("streaming.flume.PollingFlumeTestUtils") ++
   Seq(
-ProblemFilters.exclude[MissingMethodProblem](
-  "org.apache.spark.ml.classification.LogisticCostFun.this"),
-ProblemFilters.exclude[MissingMethodProblem](
-  "org.apache.spark.ml.classification.LogisticAggregator.add"),
-ProblemFilters.exclude[MissingMethodProblem](
-  "org.apache.spark.ml.classification.LogisticAggregator.count"),
+// MiMa does not deal properly with sealed traits
 ProblemFilters.exclude[MissingMethodProblem](
   
"org.apache.spark.ml.classification.LogisticRegressionSummary.featuresCol")
   ) ++ Seq(

http://git-wip-us.apache.org/repos/asf/spark/blob/fa603e08/tools/src/main/scala/org/apache/spark/tools/GenerateMIMAIgnore.scala
--
diff --git 
a/tools/src/main/scala/org/apache/spark/tools/GenerateMIMAIgnore.scala 
b/tools/src/main/scala/org/apache/spark/tools/GenerateMIMAIgnore.scala
index a0524ca..5155daa 100644
--- a/tools/src/main/scala/org/apache/spark/tools/GenerateMIMAIgnore.scala
+++ b/tools/src/main/scala/org/apache/spark/tools/GenerateMIMAIgnore.scala
@@ -72,7 +72,9 @@ object GenerateMIMAIgnore {
 val classSymbol = mirror.classSymbol(Class.forName(className, false, 
classLoader))
 val moduleSymbol = mirror.staticModule(className)
 val directlyPrivateSpark =
-  isPackagePrivate(classSymbol) || isPackagePrivateModule(moduleSymbol)
+  isPackagePrivate(classSymbol) ||
+  isPackagePrivateModule(moduleSymbol) ||
+  classSymbol.isPrivate
 val developerApi = isDeveloperApi(classSymbol) || 
isDeveloperApi(moduleSymbol)
 val experimental = isExperimental(classSymbol) || 
isExperimental(moduleSymbol)
 /* Inner classes defined within a private[spark] class or object are 
effectively


-
To unsubscribe, e-mail: commits-unsubscr...@spark.apache.org
For additional commands, e-mail: commits-h...@spark.apache.org