spark git commit: [SPARK-22496][SQL] thrift server adds operation logs
Repository: spark Updated Branches: refs/heads/master 59daf91b7 -> 0ea2d8c12 [SPARK-22496][SQL] thrift server adds operation logs ## What changes were proposed in this pull request? since hive 2.0+ upgrades log4j to log4j2ï¼a lot of [changes](https://issues.apache.org/jira/browse/HIVE-11304) are made working on it. as spark is not to ready to update its inner hive version(1.2.1) , so I manage to make little changes. the function registerCurrentOperationLog is moved from SQLOperstion to its parent class ExecuteStatementOperation so spark can use it. ## How was this patch tested? manual test Closes #19721 from ChenjunZou/operation-log. Author: zouchenjunCloses #19961 from ChenjunZou/spark-22496. Project: http://git-wip-us.apache.org/repos/asf/spark/repo Commit: http://git-wip-us.apache.org/repos/asf/spark/commit/0ea2d8c1 Tree: http://git-wip-us.apache.org/repos/asf/spark/tree/0ea2d8c1 Diff: http://git-wip-us.apache.org/repos/asf/spark/diff/0ea2d8c1 Branch: refs/heads/master Commit: 0ea2d8c12e49e30df6bbfa57d74134b25f96a196 Parents: 59daf91 Author: zouchenjun Authored: Thu Dec 14 15:37:26 2017 -0800 Committer: gatorsmile Committed: Thu Dec 14 15:37:26 2017 -0800 -- .../cli/operation/ExecuteStatementOperation.java | 13 + .../hive/service/cli/operation/SQLOperation.java | 12 .../thriftserver/SparkExecuteStatementOperation.scala | 1 + 3 files changed, 14 insertions(+), 12 deletions(-) -- http://git-wip-us.apache.org/repos/asf/spark/blob/0ea2d8c1/sql/hive-thriftserver/src/main/java/org/apache/hive/service/cli/operation/ExecuteStatementOperation.java -- diff --git a/sql/hive-thriftserver/src/main/java/org/apache/hive/service/cli/operation/ExecuteStatementOperation.java b/sql/hive-thriftserver/src/main/java/org/apache/hive/service/cli/operation/ExecuteStatementOperation.java index 3f2de10..6740d3b 100644 --- a/sql/hive-thriftserver/src/main/java/org/apache/hive/service/cli/operation/ExecuteStatementOperation.java +++ b/sql/hive-thriftserver/src/main/java/org/apache/hive/service/cli/operation/ExecuteStatementOperation.java @@ -23,6 +23,7 @@ import java.util.Map; import org.apache.hadoop.hive.ql.processors.CommandProcessor; import org.apache.hadoop.hive.ql.processors.CommandProcessorFactory; +import org.apache.hadoop.hive.ql.session.OperationLog; import org.apache.hive.service.cli.HiveSQLException; import org.apache.hive.service.cli.OperationType; import org.apache.hive.service.cli.session.HiveSession; @@ -67,4 +68,16 @@ public abstract class ExecuteStatementOperation extends Operation { this.confOverlay = confOverlay; } } + + protected void registerCurrentOperationLog() { +if (isOperationLogEnabled) { + if (operationLog == null) { +LOG.warn("Failed to get current OperationLog object of Operation: " + + getHandle().getHandleIdentifier()); +isOperationLogEnabled = false; +return; + } + OperationLog.setCurrentOperationLog(operationLog); +} + } } http://git-wip-us.apache.org/repos/asf/spark/blob/0ea2d8c1/sql/hive-thriftserver/src/main/java/org/apache/hive/service/cli/operation/SQLOperation.java -- diff --git a/sql/hive-thriftserver/src/main/java/org/apache/hive/service/cli/operation/SQLOperation.java b/sql/hive-thriftserver/src/main/java/org/apache/hive/service/cli/operation/SQLOperation.java index 5014ced..fd9108e 100644 --- a/sql/hive-thriftserver/src/main/java/org/apache/hive/service/cli/operation/SQLOperation.java +++ b/sql/hive-thriftserver/src/main/java/org/apache/hive/service/cli/operation/SQLOperation.java @@ -274,18 +274,6 @@ public class SQLOperation extends ExecuteStatementOperation { } } - private void registerCurrentOperationLog() { -if (isOperationLogEnabled) { - if (operationLog == null) { -LOG.warn("Failed to get current OperationLog object of Operation: " + -getHandle().getHandleIdentifier()); -isOperationLogEnabled = false; -return; - } - OperationLog.setCurrentOperationLog(operationLog); -} - } - private void cleanup(OperationState state) throws HiveSQLException { setState(state); if (shouldRunAsync()) { http://git-wip-us.apache.org/repos/asf/spark/blob/0ea2d8c1/sql/hive-thriftserver/src/main/scala/org/apache/spark/sql/hive/thriftserver/SparkExecuteStatementOperation.scala -- diff --git a/sql/hive-thriftserver/src/main/scala/org/apache/spark/sql/hive/thriftserver/SparkExecuteStatementOperation.scala
spark git commit: [SPARK-22496][SQL] thrift server adds operation logs
Repository: spark Updated Branches: refs/heads/master ab1b6ee73 -> 4289ac9d8 [SPARK-22496][SQL] thrift server adds operation logs ## What changes were proposed in this pull request? since hive 2.0+ upgrades log4j to log4j2ï¼a lot of [changes](https://issues.apache.org/jira/browse/HIVE-11304) are made working on it. as spark is not to ready to update its inner hive version(1.2.1) , so I manage to make little changes. the function registerCurrentOperationLog is moved from SQLOperstion to its parent class ExecuteStatementOperation so spark can use it. ## How was this patch tested? manual test Author: zouchenjunCloses #19721 from ChenjunZou/operation-log. Project: http://git-wip-us.apache.org/repos/asf/spark/repo Commit: http://git-wip-us.apache.org/repos/asf/spark/commit/4289ac9d Tree: http://git-wip-us.apache.org/repos/asf/spark/tree/4289ac9d Diff: http://git-wip-us.apache.org/repos/asf/spark/diff/4289ac9d Branch: refs/heads/master Commit: 4289ac9d8dbbc45fc2ee6d0250a2113107bf08d0 Parents: ab1b6ee Author: zouchenjun Authored: Sun Dec 10 20:36:14 2017 -0800 Committer: gatorsmile Committed: Sun Dec 10 20:36:14 2017 -0800 -- .../cli/operation/ExecuteStatementOperation.java | 13 + .../hive/service/cli/operation/SQLOperation.java | 12 .../thriftserver/SparkExecuteStatementOperation.scala | 1 + 3 files changed, 14 insertions(+), 12 deletions(-) -- http://git-wip-us.apache.org/repos/asf/spark/blob/4289ac9d/sql/hive-thriftserver/src/main/java/org/apache/hive/service/cli/operation/ExecuteStatementOperation.java -- diff --git a/sql/hive-thriftserver/src/main/java/org/apache/hive/service/cli/operation/ExecuteStatementOperation.java b/sql/hive-thriftserver/src/main/java/org/apache/hive/service/cli/operation/ExecuteStatementOperation.java index 3f2de10..dc7de3c 100644 --- a/sql/hive-thriftserver/src/main/java/org/apache/hive/service/cli/operation/ExecuteStatementOperation.java +++ b/sql/hive-thriftserver/src/main/java/org/apache/hive/service/cli/operation/ExecuteStatementOperation.java @@ -23,6 +23,7 @@ import java.util.Map; import org.apache.hadoop.hive.ql.processors.CommandProcessor; import org.apache.hadoop.hive.ql.processors.CommandProcessorFactory; +import org.apache.hadoop.hive.ql.session.OperationLog; import org.apache.hive.service.cli.HiveSQLException; import org.apache.hive.service.cli.OperationType; import org.apache.hive.service.cli.session.HiveSession; @@ -67,4 +68,16 @@ public abstract class ExecuteStatementOperation extends Operation { this.confOverlay = confOverlay; } } + + protected void registerCurrentOperationLog() { +if (isOperationLogEnabled) { + if (operationLog == null) { +LOG.warn("Failed to get current OperationLog object of Operation: " + +getHandle().getHandleIdentifier()); +isOperationLogEnabled = false; +return; + } + OperationLog.setCurrentOperationLog(operationLog); +} + } } http://git-wip-us.apache.org/repos/asf/spark/blob/4289ac9d/sql/hive-thriftserver/src/main/java/org/apache/hive/service/cli/operation/SQLOperation.java -- diff --git a/sql/hive-thriftserver/src/main/java/org/apache/hive/service/cli/operation/SQLOperation.java b/sql/hive-thriftserver/src/main/java/org/apache/hive/service/cli/operation/SQLOperation.java index 5014ced..fd9108e 100644 --- a/sql/hive-thriftserver/src/main/java/org/apache/hive/service/cli/operation/SQLOperation.java +++ b/sql/hive-thriftserver/src/main/java/org/apache/hive/service/cli/operation/SQLOperation.java @@ -274,18 +274,6 @@ public class SQLOperation extends ExecuteStatementOperation { } } - private void registerCurrentOperationLog() { -if (isOperationLogEnabled) { - if (operationLog == null) { -LOG.warn("Failed to get current OperationLog object of Operation: " + -getHandle().getHandleIdentifier()); -isOperationLogEnabled = false; -return; - } - OperationLog.setCurrentOperationLog(operationLog); -} - } - private void cleanup(OperationState state) throws HiveSQLException { setState(state); if (shouldRunAsync()) { http://git-wip-us.apache.org/repos/asf/spark/blob/4289ac9d/sql/hive-thriftserver/src/main/scala/org/apache/spark/sql/hive/thriftserver/SparkExecuteStatementOperation.scala -- diff --git a/sql/hive-thriftserver/src/main/scala/org/apache/spark/sql/hive/thriftserver/SparkExecuteStatementOperation.scala