spark git commit: [SPARK-9534] [BUILD] Enable javac lint for scalac parity; fix a lot of build warnings, 1.5.0 edition
Repository: spark
Updated Branches:
refs/heads/branch-1.5 29f2d5a06 -> 5ae675360
[SPARK-9534] [BUILD] Enable javac lint for scalac parity; fix a lot of build
warnings, 1.5.0 edition
Enable most javac lint warnings; fix a lot of build warnings. In a few cases,
touch up surrounding code in the process.
I'll explain several of the changes inline in comments.
Author: Sean Owen
Closes #7862 from srowen/SPARK-9534 and squashes the following commits:
ea51618 [Sean Owen] Enable most javac lint warnings; fix a lot of build
warnings. In a few cases, touch up surrounding code in the process.
(cherry picked from commit 76d74090d60f74412bd45487e8db6aff2e8343a2)
Signed-off-by: Sean Owen
Project: http://git-wip-us.apache.org/repos/asf/spark/repo
Commit: http://git-wip-us.apache.org/repos/asf/spark/commit/5ae67536
Tree: http://git-wip-us.apache.org/repos/asf/spark/tree/5ae67536
Diff: http://git-wip-us.apache.org/repos/asf/spark/diff/5ae67536
Branch: refs/heads/branch-1.5
Commit: 5ae675360d883483e509788b8867c1c98b4820fd
Parents: 29f2d5a
Author: Sean Owen
Authored: Tue Aug 4 12:02:26 2015 +0100
Committer: Sean Owen
Committed: Tue Aug 4 12:02:45 2015 +0100
--
.../java/JavaSparkContextVarargsWorkaround.java | 19 +++---
.../spark/storage/TachyonBlockManager.scala | 9 ++-
.../deploy/master/PersistenceEngineSuite.scala | 13 ++--
.../mesos/MesosSchedulerUtilsSuite.scala| 3 +
.../spark/examples/ml/JavaOneVsRestExample.java | 1 +
.../streaming/JavaStatefulNetworkWordCount.java | 4 +-
.../kafka/JavaDirectKafkaStreamSuite.java | 2 +-
.../evaluation/JavaRankingMetricsSuite.java | 14 ++---
.../ml/classification/NaiveBayesSuite.scala | 4 +-
.../network/protocol/ChunkFetchFailure.java | 5 ++
.../network/protocol/ChunkFetchRequest.java | 5 ++
.../network/protocol/ChunkFetchSuccess.java | 5 ++
.../spark/network/protocol/RpcFailure.java | 5 ++
.../spark/network/protocol/RpcRequest.java | 5 ++
.../spark/network/protocol/RpcResponse.java | 5 ++
.../apache/spark/network/TestManagedBuffer.java | 5 ++
.../spark/network/sasl/SparkSaslSuite.java | 16 ++---
.../ExternalShuffleBlockHandlerSuite.java | 6 +-
.../shuffle/RetryingBlockFetcherSuite.java | 47 ---
pom.xml | 4 ++
.../apache/spark/sql/JavaDataFrameSuite.java| 1 +
.../spark/sql/sources/TableScanSuite.scala | 16 +++--
.../sql/hive/client/IsolatedClientLoader.scala | 2 +-
.../spark/sql/hive/execution/commands.scala | 2 +-
.../spark/sql/hive/JavaDataFrameSuite.java | 2 +-
.../sql/hive/execution/SQLQuerySuite.scala | 4 +-
.../streaming/scheduler/JobScheduler.scala | 4 +-
.../spark/streaming/JavaWriteAheadLogSuite.java | 62 ++--
.../spark/streaming/UISeleniumSuite.scala | 4 +-
29 files changed, 167 insertions(+), 107 deletions(-)
--
http://git-wip-us.apache.org/repos/asf/spark/blob/5ae67536/core/src/main/java/org/apache/spark/api/java/JavaSparkContextVarargsWorkaround.java
--
diff --git
a/core/src/main/java/org/apache/spark/api/java/JavaSparkContextVarargsWorkaround.java
b/core/src/main/java/org/apache/spark/api/java/JavaSparkContextVarargsWorkaround.java
index 2090efd..d4c42b3 100644
---
a/core/src/main/java/org/apache/spark/api/java/JavaSparkContextVarargsWorkaround.java
+++
b/core/src/main/java/org/apache/spark/api/java/JavaSparkContextVarargsWorkaround.java
@@ -23,11 +23,13 @@ import java.util.List;
// See
//
http://scala-programming-language.1934581.n4.nabble.com/Workaround-for-implementing-java-varargs-in-2-7-2-final-tp1944767p1944772.html
abstract class JavaSparkContextVarargsWorkaround {
- public JavaRDD union(JavaRDD... rdds) {
+
+ @SafeVarargs
+ public final JavaRDD union(JavaRDD... rdds) {
if (rdds.length == 0) {
throw new IllegalArgumentException("Union called on empty list");
}
-ArrayList> rest = new ArrayList>(rdds.length - 1);
+List> rest = new ArrayList<>(rdds.length - 1);
for (int i = 1; i < rdds.length; i++) {
rest.add(rdds[i]);
}
@@ -38,18 +40,19 @@ abstract class JavaSparkContextVarargsWorkaround {
if (rdds.length == 0) {
throw new IllegalArgumentException("Union called on empty list");
}
-ArrayList rest = new ArrayList(rdds.length -
1);
+List rest = new ArrayList<>(rdds.length - 1);
for (int i = 1; i < rdds.length; i++) {
rest.add(rdds[i]);
}
return union(rdds[0], rest);
}
- public JavaPairRDD union(JavaPairRDD... rdds) {
+ @SafeVarargs
+ public final JavaPairRDD union(JavaPairRDD... rdds) {
if (rdds.length == 0) {
throw new IllegalArgumentException("Union called on empty list");
}
-ArrayList> rest = n
spark git commit: [SPARK-9534] [BUILD] Enable javac lint for scalac parity; fix a lot of build warnings, 1.5.0 edition
Repository: spark
Updated Branches:
refs/heads/master 9e952ecbc -> 76d74090d
[SPARK-9534] [BUILD] Enable javac lint for scalac parity; fix a lot of build
warnings, 1.5.0 edition
Enable most javac lint warnings; fix a lot of build warnings. In a few cases,
touch up surrounding code in the process.
I'll explain several of the changes inline in comments.
Author: Sean Owen
Closes #7862 from srowen/SPARK-9534 and squashes the following commits:
ea51618 [Sean Owen] Enable most javac lint warnings; fix a lot of build
warnings. In a few cases, touch up surrounding code in the process.
Project: http://git-wip-us.apache.org/repos/asf/spark/repo
Commit: http://git-wip-us.apache.org/repos/asf/spark/commit/76d74090
Tree: http://git-wip-us.apache.org/repos/asf/spark/tree/76d74090
Diff: http://git-wip-us.apache.org/repos/asf/spark/diff/76d74090
Branch: refs/heads/master
Commit: 76d74090d60f74412bd45487e8db6aff2e8343a2
Parents: 9e952ec
Author: Sean Owen
Authored: Tue Aug 4 12:02:26 2015 +0100
Committer: Sean Owen
Committed: Tue Aug 4 12:02:26 2015 +0100
--
.../java/JavaSparkContextVarargsWorkaround.java | 19 +++---
.../spark/storage/TachyonBlockManager.scala | 9 ++-
.../deploy/master/PersistenceEngineSuite.scala | 13 ++--
.../mesos/MesosSchedulerUtilsSuite.scala| 3 +
.../spark/examples/ml/JavaOneVsRestExample.java | 1 +
.../streaming/JavaStatefulNetworkWordCount.java | 4 +-
.../kafka/JavaDirectKafkaStreamSuite.java | 2 +-
.../evaluation/JavaRankingMetricsSuite.java | 14 ++---
.../ml/classification/NaiveBayesSuite.scala | 4 +-
.../network/protocol/ChunkFetchFailure.java | 5 ++
.../network/protocol/ChunkFetchRequest.java | 5 ++
.../network/protocol/ChunkFetchSuccess.java | 5 ++
.../spark/network/protocol/RpcFailure.java | 5 ++
.../spark/network/protocol/RpcRequest.java | 5 ++
.../spark/network/protocol/RpcResponse.java | 5 ++
.../apache/spark/network/TestManagedBuffer.java | 5 ++
.../spark/network/sasl/SparkSaslSuite.java | 16 ++---
.../ExternalShuffleBlockHandlerSuite.java | 6 +-
.../shuffle/RetryingBlockFetcherSuite.java | 47 ---
pom.xml | 4 ++
.../apache/spark/sql/JavaDataFrameSuite.java| 1 +
.../spark/sql/sources/TableScanSuite.scala | 16 +++--
.../sql/hive/client/IsolatedClientLoader.scala | 2 +-
.../spark/sql/hive/execution/commands.scala | 2 +-
.../spark/sql/hive/JavaDataFrameSuite.java | 2 +-
.../sql/hive/execution/SQLQuerySuite.scala | 4 +-
.../streaming/scheduler/JobScheduler.scala | 4 +-
.../spark/streaming/JavaWriteAheadLogSuite.java | 62 ++--
.../spark/streaming/UISeleniumSuite.scala | 4 +-
29 files changed, 167 insertions(+), 107 deletions(-)
--
http://git-wip-us.apache.org/repos/asf/spark/blob/76d74090/core/src/main/java/org/apache/spark/api/java/JavaSparkContextVarargsWorkaround.java
--
diff --git
a/core/src/main/java/org/apache/spark/api/java/JavaSparkContextVarargsWorkaround.java
b/core/src/main/java/org/apache/spark/api/java/JavaSparkContextVarargsWorkaround.java
index 2090efd..d4c42b3 100644
---
a/core/src/main/java/org/apache/spark/api/java/JavaSparkContextVarargsWorkaround.java
+++
b/core/src/main/java/org/apache/spark/api/java/JavaSparkContextVarargsWorkaround.java
@@ -23,11 +23,13 @@ import java.util.List;
// See
//
http://scala-programming-language.1934581.n4.nabble.com/Workaround-for-implementing-java-varargs-in-2-7-2-final-tp1944767p1944772.html
abstract class JavaSparkContextVarargsWorkaround {
- public JavaRDD union(JavaRDD... rdds) {
+
+ @SafeVarargs
+ public final JavaRDD union(JavaRDD... rdds) {
if (rdds.length == 0) {
throw new IllegalArgumentException("Union called on empty list");
}
-ArrayList> rest = new ArrayList>(rdds.length - 1);
+List> rest = new ArrayList<>(rdds.length - 1);
for (int i = 1; i < rdds.length; i++) {
rest.add(rdds[i]);
}
@@ -38,18 +40,19 @@ abstract class JavaSparkContextVarargsWorkaround {
if (rdds.length == 0) {
throw new IllegalArgumentException("Union called on empty list");
}
-ArrayList rest = new ArrayList(rdds.length -
1);
+List rest = new ArrayList<>(rdds.length - 1);
for (int i = 1; i < rdds.length; i++) {
rest.add(rdds[i]);
}
return union(rdds[0], rest);
}
- public JavaPairRDD union(JavaPairRDD... rdds) {
+ @SafeVarargs
+ public final JavaPairRDD union(JavaPairRDD... rdds) {
if (rdds.length == 0) {
throw new IllegalArgumentException("Union called on empty list");
}
-ArrayList> rest = new ArrayList>(rdds.length - 1);
+List> rest = new ArrayList<>(rdds.length - 1);
for (int i = 1;
