Re: svn commit: r1104408 - /subversion/trunk/subversion/tests/cmdline/prop_tests.py
For the record, proplist has been broken for a while. :)
This test verifies that we fetch the right thing for a given node. My
recent changes only changed which nodes the information is fetched on.
In other words, I'm not really looking at this right now.
-Hyrum
On Tue, May 17, 2011 at 5:02 PM, wrote:
> Author: rhuijben
> Date: Tue May 17 17:02:08 2011
> New Revision: 1104408
>
> URL: http://svn.apache.org/viewvc?rev=1104408&view=rev
> Log:
> Add a simple property test to show that proplist is completely broken now.
>
> Adding an ACTUAL record makes it impossible to proplist the base values.
>
> * subversion/tests/cmdline/prop_tests.py
> (pristine_props_listed): Add new XFail test.
> (test_list): Ass pristine_props_listed.
>
> Modified:
> subversion/trunk/subversion/tests/cmdline/prop_tests.py
>
> Modified: subversion/trunk/subversion/tests/cmdline/prop_tests.py
> URL:
> http://svn.apache.org/viewvc/subversion/trunk/subversion/tests/cmdline/prop_tests.py?rev=1104408&r1=1104407&r2=1104408&view=diff
> ==
> --- subversion/trunk/subversion/tests/cmdline/prop_tests.py (original)
> +++ subversion/trunk/subversion/tests/cmdline/prop_tests.py Tue May 17
> 17:02:08 2011
> @@ -2431,6 +2431,28 @@ def file_matching_dir_prop_reject(sbox):
> expected_status,
> None, None, None, None, None, True)
>
> +@XFail()
> +def pristine_props_listed(sbox):
> + "check if pristine properties are visible"
> +
> + sbox.build()
> + wc_dir = sbox.wc_dir
> +
> + sbox.simple_propset('prop', 'val', 'A')
> + sbox.simple_commit()
> +
> + expected_output = ["Properties on '" + sbox.ospath('A') + "':\n", "
> prop\n"]
> +
> + # Now we see the pristine properties
> + svntest.actions.run_and_verify_svn(None, expected_output, [],
> + 'proplist', '-R', wc_dir, '-r', 'BASE')
> +
> + sbox.simple_propset('prop', 'needs-fix', 'A')
> +
> + # And now we see no property at all
> + svntest.actions.run_and_verify_svn(None, expected_output, [],
> + 'proplist', '-R', wc_dir, '-r', 'BASE')
> +
>
> # Run the tests
>
> @@ -2472,6 +2494,7 @@ test_list = [ None,
> atomic_over_ra,
> propget_redirection,
> file_matching_dir_prop_reject,
> + pristine_props_listed,
> ]
>
> if __name__ == '__main__':
>
>
>
svn commit: r1104408 - /subversion/trunk/subversion/tests/cmdline/prop_tests.py
Author: rhuijben
Date: Tue May 17 17:02:08 2011
New Revision: 1104408
URL: http://svn.apache.org/viewvc?rev=1104408&view=rev
Log:
Add a simple property test to show that proplist is completely broken now.
Adding an ACTUAL record makes it impossible to proplist the base values.
* subversion/tests/cmdline/prop_tests.py
(pristine_props_listed): Add new XFail test.
(test_list): Ass pristine_props_listed.
Modified:
subversion/trunk/subversion/tests/cmdline/prop_tests.py
Modified: subversion/trunk/subversion/tests/cmdline/prop_tests.py
URL:
http://svn.apache.org/viewvc/subversion/trunk/subversion/tests/cmdline/prop_tests.py?rev=1104408&r1=1104407&r2=1104408&view=diff
==
--- subversion/trunk/subversion/tests/cmdline/prop_tests.py (original)
+++ subversion/trunk/subversion/tests/cmdline/prop_tests.py Tue May 17 17:02:08
2011
@@ -2431,6 +2431,28 @@ def file_matching_dir_prop_reject(sbox):
expected_status,
None, None, None, None, None, True)
+@XFail()
+def pristine_props_listed(sbox):
+ "check if pristine properties are visible"
+
+ sbox.build()
+ wc_dir = sbox.wc_dir
+
+ sbox.simple_propset('prop', 'val', 'A')
+ sbox.simple_commit()
+
+ expected_output = ["Properties on '" + sbox.ospath('A') + "':\n", " prop\n"]
+
+ # Now we see the pristine properties
+ svntest.actions.run_and_verify_svn(None, expected_output, [],
+ 'proplist', '-R', wc_dir, '-r', 'BASE')
+
+ sbox.simple_propset('prop', 'needs-fix', 'A')
+
+ # And now we see no property at all
+ svntest.actions.run_and_verify_svn(None, expected_output, [],
+ 'proplist', '-R', wc_dir, '-r', 'BASE')
+
# Run the tests
@@ -2472,6 +2494,7 @@ test_list = [ None,
atomic_over_ra,
propget_redirection,
file_matching_dir_prop_reject,
+ pristine_props_listed,
]
if __name__ == '__main__':
