How does this impact backward compat? If somebody was including just
'svn_wc.h' and expecting to get the contents of svn_version.h, their
code will now not compile, yes? This is demonstrated by our own build
breakage after r1132965.
(You mention a similar cleanup happened early in 1.7 development. I
apologize if I'm digging up old laundry.)
-Hyrum
On Tue, Jun 7, 2011 at 7:09 AM, wrote:
> Author: rhuijben
> Date: Tue Jun 7 12:09:37 2011
> New Revision: 1132966
>
> URL: http://svn.apache.org/viewvc?rev=1132966&view=rev
> Log:
> Remove #include "svn_version.h" from a number of public header files, to
> reduce
> build time in third party build environments and when switching between
> branches.
>
> This file modifies in some build scenarios because it contains the version
> number and version description texts.
>
> This change is similar to another recursive header include cleanup performed
> early in Subversion 1.7 development.
>
> * subversion/include/svn_auth.h
> * subversion/include/svn_client.h
> * subversion/include/svn_delta.h
> * subversion/include/svn_diff.h
> * subversion/include/svn_repos.h
> * subversion/include/svn_wc.h
> (includes): Remove svn_version.h
>
> * subversion/libsvn_ra_svn/client.c
> * subversion/svn/main.c
> * subversion/svnlook/main.c
> * subversion/svnsync/main.c
> * subversion/svnversion/main.c
> * tools/dev/svnraisetreeconflict/main.c
> (includes): Add svn_version.h
>
> Modified:
> subversion/trunk/subversion/include/svn_auth.h
> subversion/trunk/subversion/include/svn_client.h
> subversion/trunk/subversion/include/svn_delta.h
> subversion/trunk/subversion/include/svn_diff.h
> subversion/trunk/subversion/include/svn_repos.h
> subversion/trunk/subversion/include/svn_wc.h
> subversion/trunk/subversion/libsvn_ra_svn/client.c
> subversion/trunk/subversion/svn/main.c
> subversion/trunk/subversion/svnlook/main.c
> subversion/trunk/subversion/svnsync/main.c
> subversion/trunk/subversion/svnversion/main.c
> subversion/trunk/tools/dev/svnraisetreeconflict/main.c
>
> Modified: subversion/trunk/subversion/include/svn_auth.h
> URL:
> http://svn.apache.org/viewvc/subversion/trunk/subversion/include/svn_auth.h?rev=1132966&r1=1132965&r2=1132966&view=diff
> ==
> --- subversion/trunk/subversion/include/svn_auth.h (original)
> +++ subversion/trunk/subversion/include/svn_auth.h Tue Jun 7 12:09:37 2011
> @@ -34,7 +34,6 @@
>
> #include "svn_types.h"
> #include "svn_config.h"
> -#include "svn_version.h"
>
> #ifdef __cplusplus
> extern "C" {
>
> Modified: subversion/trunk/subversion/include/svn_client.h
> URL:
> http://svn.apache.org/viewvc/subversion/trunk/subversion/include/svn_client.h?rev=1132966&r1=1132965&r2=1132966&view=diff
> ==
> --- subversion/trunk/subversion/include/svn_client.h (original)
> +++ subversion/trunk/subversion/include/svn_client.h Tue Jun 7 12:09:37 2011
> @@ -43,7 +43,6 @@
> #include "svn_string.h"
> #include "svn_wc.h"
> #include "svn_opt.h"
> -#include "svn_version.h"
> #include "svn_ra.h"
> #include "svn_diff.h"
> #include "svn_auth.h"
>
> Modified: subversion/trunk/subversion/include/svn_delta.h
> URL:
> http://svn.apache.org/viewvc/subversion/trunk/subversion/include/svn_delta.h?rev=1132966&r1=1132965&r2=1132966&view=diff
> ==
> --- subversion/trunk/subversion/include/svn_delta.h (original)
> +++ subversion/trunk/subversion/include/svn_delta.h Tue Jun 7 12:09:37 2011
> @@ -40,7 +40,6 @@
> #include "svn_types.h"
> #include "svn_string.h"
> #include "svn_io.h"
> -#include "svn_version.h"
> #include "svn_checksum.h"
>
> #ifdef __cplusplus
>
> Modified: subversion/trunk/subversion/include/svn_diff.h
> URL:
> http://svn.apache.org/viewvc/subversion/trunk/subversion/include/svn_diff.h?rev=1132966&r1=1132965&r2=1132966&view=diff
> ==
> --- subversion/trunk/subversion/include/svn_diff.h (original)
> +++ subversion/trunk/subversion/include/svn_diff.h Tue Jun 7 12:09:37 2011
> @@ -54,7 +54,6 @@
>
> #include "svn_types.h"
> #include "svn_io.h" /* for svn_stream_t */
> -#include "svn_version.h"
> #include "svn_string.h"
>
> #ifdef __cplusplus
>
> Modified: subversion/trunk/subversion/include/svn_repos.h
> URL:
> http://svn.apache.org/viewvc/subversion/trunk/subversion/include/svn_repos.h?rev=1132966&r1=1132965&r2=1132966&view=diff
> ==
> --- subversion/trunk/subversion/include/svn_repos.h (original)
> +++ subversion/trunk/subversion/include/svn_repos.h Tue Jun 7 12:09:37 2011
> @@ -37,7 +37,6 @@
> #include "svn_delta.h"
> #include "svn_fs.h"
> #include "svn_io.h"
> -#include "svn_version.h"
> #include "svn_mergeinfo.h"
>
>
>
>
