Re: svn commit: r1896877 - /subversion/trunk/subversion/svnadmin/svnadmin.c

[Stefan Sperling]

On Tue, Jan 11, 2022 at 12:22:38AM -0500, Nathan Hartman wrote:
> On Mon, Jan 10, 2022 at 6:44 AM  wrote:
> >
> > Author: stsp
> > Date: Mon Jan 10 11:44:46 2022
> > New Revision: 1896877
> >
> > URL: http://svn.apache.org/viewvc?rev=1896877&view=rev
> > Log:
> > Fix misleading -r option documentation for some svnadmin subcommands.
> >
> > The commands delrevprop, lstxns, rev-size, and setrevprop accept only
> > a single revision number. However, the -r option help text implied
> > that a revision range was accepted. Correct the -r option help text
> > of aforementioned commands.
> 
> The log message contains an error: the corrected commands are:
> delrevprop, rev-size, setlog, setrevprop
> 
> The help text of 'svnadmin lstxns' is correct and is unchanged.
> 
> Cheers,
> Nathan
> 

Thank you for pointing this out! Fixed now by replacing all occurrences
of lstxns with setlog.

Re: svn commit: r1896877 - /subversion/trunk/subversion/svnadmin/svnadmin.c

[Nathan Hartman]

On Mon, Jan 10, 2022 at 6:44 AM  wrote:
>
> Author: stsp
> Date: Mon Jan 10 11:44:46 2022
> New Revision: 1896877
>
> URL: http://svn.apache.org/viewvc?rev=1896877&view=rev
> Log:
> Fix misleading -r option documentation for some svnadmin subcommands.
>
> The commands delrevprop, lstxns, rev-size, and setrevprop accept only
> a single revision number. However, the -r option help text implied
> that a revision range was accepted. Correct the -r option help text
> of aforementioned commands.

The log message contains an error: the corrected commands are:
delrevprop, rev-size, setlog, setrevprop

The help text of 'svnadmin lstxns' is correct and is unchanged.

Cheers,
Nathan

svn commit: r1896877 - /subversion/trunk/subversion/svnadmin/svnadmin.c

[stsp]

Author: stsp
Date: Mon Jan 10 11:44:46 2022
New Revision: 1896877

URL: http://svn.apache.org/viewvc?rev=1896877&view=rev
Log:
Fix misleading -r option documentation for some svnadmin subcommands.

The commands delrevprop, lstxns, rev-size, and setrevprop accept only
a single revision number. However, the -r option help text implied
that a revision range was accepted. Correct the -r option help text
of aforementioned commands.

The old text was:
  -r [--revision] ARG  : specify revision number ARG (or X:Y range)
The new text omits the reference to a revision range:
  -r [--revision] ARG  : specify revision number ARG

* subversion/svnadmin/svnadmin.c
  (cmd_table): Override -r option description for the devrevprop, lsxtns,
  rev-size, and setrevprop commands.

Modified:
subversion/trunk/subversion/svnadmin/svnadmin.c

Modified: subversion/trunk/subversion/svnadmin/svnadmin.c
URL: 
http://svn.apache.org/viewvc/subversion/trunk/subversion/svnadmin/svnadmin.c?rev=1896877&r1=1896876&r2=1896877&view=diff
==
--- subversion/trunk/subversion/svnadmin/svnadmin.c (original)
+++ subversion/trunk/subversion/svnadmin/svnadmin.c Mon Jan 10 11:44:46 2022
@@ -352,7 +352,8 @@ static const svn_opt_subcommand_desc3_t
 "2. Delete the property NAME on transaction TXN.\n"
)},
{'r', 't', svnadmin__use_pre_revprop_change_hook,
-svnadmin__use_post_revprop_change_hook} },
+svnadmin__use_post_revprop_change_hook},
+   { {'r', "specify revision number ARG"} } },
 
   {"deltify", subcommand_deltify, {0}, {N_(
 "usage: svnadmin deltify [-r LOWER[:UPPER]] REPOS_PATH\n"
@@ -541,7 +542,8 @@ static const svn_opt_subcommand_desc3_t
 "The size includes revision properties and excludes FSFS indexes.\n"
)},
{'r', 'q', 'M'},
-   { {'q', "print only the size and a newline"} } },
+   { {'r', "specify revision number ARG"},
+ {'q', "print only the size and a newline"} }, },
 
   {"rmlocks", subcommand_rmlocks, {0}, {N_(
 "usage: svnadmin rmlocks REPOS_PATH LOCKED_PATH...\n"
@@ -570,7 +572,8 @@ static const svn_opt_subcommand_desc3_t
 "NOTE: Revision properties are not versioned, so this command will\n"
 "overwrite the previous log message.\n"
)},
-   {'r', svnadmin__bypass_hooks} },
+   {'r', svnadmin__bypass_hooks},
+   { {'r', "specify revision number ARG"} }, }, 
 
   {"setrevprop", subcommand_setrevprop, {0}, {N_(
 "usage: 1. svnadmin setrevprop REPOS_PATH -r REVISION NAME FILE\n"
@@ -588,7 +591,8 @@ static const svn_opt_subcommand_desc3_t
 "2. Set the property NAME on transaction TXN to the contents of FILE.\n"
)},
{'r', 't', svnadmin__use_pre_revprop_change_hook,
-svnadmin__use_post_revprop_change_hook} },
+svnadmin__use_post_revprop_change_hook},
+   { {'r', "specify revision number ARG"} }, }, 
 
   {"setuuid", subcommand_setuuid, {0}, {N_(
 "usage: svnadmin setuuid REPOS_PATH [NEW_UUID]\n"