[incubator-superset] branch master updated: fix: fetch datasets list after dataset created successfully (#10290)
This is an automated email from the ASF dual-hosted git repository.
tai pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-superset.git
The following commit(s) were added to refs/heads/master by this push:
new 9d75740 fix: fetch datasets list after dataset created successfully
(#10290)
9d75740 is described below
commit 9d757403be58cba16386f4a55e4c7194abc6881c
Author: Lily Kuang
AuthorDate: Sat Jul 11 20:57:54 2020 -0700
fix: fetch datasets list after dataset created successfully (#10290)
---
superset-frontend/src/components/Menu/SubMenu.tsx | 111 +++--
.../src/views/datasetList/DatasetList.tsx | 6 +-
.../src/views/datasetList/DatasetModal.tsx | 24 +++--
3 files changed, 75 insertions(+), 66 deletions(-)
diff --git a/superset-frontend/src/components/Menu/SubMenu.tsx
b/superset-frontend/src/components/Menu/SubMenu.tsx
index f565af0..5b45ae1 100644
--- a/superset-frontend/src/components/Menu/SubMenu.tsx
+++ b/superset-frontend/src/components/Menu/SubMenu.tsx
@@ -16,7 +16,7 @@
* specific language governing permissions and limitations
* under the License.
*/
-import React from 'react';
+import React, { useState } from 'react';
import styled from '@superset-ui/style';
import DatasetModal from 'src/views/datasetList/DatasetModal';
import { Button, Nav, Navbar, MenuItem } from 'react-bootstrap';
@@ -64,71 +64,72 @@ const StyledHeader = styled.header`
`;
interface SubMenuProps {
- createButton?: { name: string; url: string | null };
canCreate?: boolean;
- name: string;
childs?: Array<{ label: string; name: string; url: string }>;
+ createButton?: { name: string; url: string | null };
+ fetchData?: () => void;
+ name: string;
}
-interface SubMenuState {
- selectedMenu: string;
- isModalOpen: boolean;
-}
-
-class SubMenu extends React.PureComponent {
- state: SubMenuState = {
-selectedMenu:
- this.props.childs && this.props.childs[0]
-? this.props.childs[0].label
-: '',
-isModalOpen: false,
- };
+const SubMenu = ({
+ canCreate,
+ childs,
+ createButton,
+ fetchData,
+ name,
+}: SubMenuProps) => {
+ const [isModalOpen, setIsModalOpen] = useState(false);
+ const [selectedMenu, setSelectedMenu] = useState(
+childs?.[0]?.label,
+ );
- onOpen = () => {
-this.setState({ isModalOpen: true });
+ const onOpen = () => {
+setIsModalOpen(true);
};
- onClose = () => {
-this.setState({ isModalOpen: false });
+ const onClose = () => {
+setIsModalOpen(false);
};
- handleClick = (item: string) => () => {
-this.setState({ selectedMenu: item });
+ const handleClick = (item: string) => () => {
+setSelectedMenu(item);
};
- render() {
-return (
-
-
-
-{this.props.name}
-
-
-
-{this.props.childs &&
- this.props.childs.map(child => (
-
- {child.label}
-
- ))}
+ return (
+
+
+
+ {name}
+
+
+
+ {childs &&
+childs.map(child => (
+
+{child.label}
+
+))}
+
+{canCreate && createButton && (
+
+
+ {createButton.name}
+
- {this.props.canCreate && this.props.createButton && (
-
-
- {this.props.createButton.name}
-
-
- )}
-
-
-);
- }
-}
+)}
+
+
+ );
+};
export default SubMenu;
diff --git a/superset-frontend/src/views/datasetList/DatasetList.tsx
b/superset-frontend/src/views/datasetList/DatasetList.tsx
index cc6fe46..e6c6248 100644
--- a/superset-frontend/src/views/datasetList/DatasetList.tsx
+++ b/superset-frontend/src/views/datasetList/DatasetList.tsx
@@ -519,7 +519,11 @@ const DatasetList: FunctionComponent = ({
return (
<>
-
+ lastFetchDataConfig && fetchData(lastFetchDataConfig)}
+ />
void;
addSuccessToast: (msg: string) => void;
+ fetchData?: () => void;
onHide: () => void;
show: boolean;
}
@@ -47,13 +48,14 @@ const TableSelectorContainer = styled.div`
const DatasetModal: FunctionComponent = ({
addDangerToast,
addSuccessToast,
+ fetchData,
onHide,
show,
}) => {
- const [datasourceId, setDatasourceId] = useState(null);
- const [disableSave, setDisableSave] = useState(true);
const [currentSchema, setSchema] = useState('');
const [currentTableName, setTableName] = useState('');
+ const [datasourceId, setDatasourceId] = useState(null);
+ const [disableSave, setDisableSave] = useState(true);
const onChange = ({
dbId,
@@ -71,17 +73,19 @@ const DatasetModal: FunctionComponent =
({
};
const onSave = () => {
-const data = {
- database: datasourceId,
-
[incubator-superset] branch master updated: chore: improve release documentation (#10292)
This is an automated email from the ASF dual-hosted git repository. villebro pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-superset.git The following commit(s) were added to refs/heads/master by this push: new 1f5eec1 chore: improve release documentation (#10292) 1f5eec1 is described below commit 1f5eec1c4a4df29de802da0f583345443243b2bb Author: Ville Brofeldt <33317356+ville...@users.noreply.github.com> AuthorDate: Sat Jul 11 19:00:02 2020 +0300 chore: improve release documentation (#10292) * fix: releasing readme.md * fix: improvements to release documentation --- RELEASING/README.md | 42 --- RELEASING/email_templates/vote_pmc.j2 | 3 +++ RELEASING/set_release_env.sh | 2 +- UPDATING.md | 2 ++ 4 files changed, 30 insertions(+), 19 deletions(-) diff --git a/RELEASING/README.md b/RELEASING/README.md index c6ea71d..b48d527 100644 --- a/RELEASING/README.md +++ b/RELEASING/README.md @@ -63,44 +63,50 @@ final release. Therefore, it's a good idea to do the following every time you work on a new phase of the release process to make sure you aren't releasing the wrong files/using wrong names. There's a script to help you set correctly all the necessary environment variables. Change your current directory to `superset/RELEASING` +and execute the `set_release_env.sh` script with the relevant parameters: ```bash # usage (BASH): . set_release_env.sh # usage (ZSH): source set_release_env.sh # -# example: source set_relese_env.sh 0.36.0rc3 m...@apache.org +# example: source set_release_env.sh 0.37.0rc1 m...@apache.org ``` -The script will output the exported variables. Here's example for 0.36.0rc3: +The script will output the exported variables. Here's example for 0.37.0rc1: ``` ---- Set Release env variables -SUPERSET_VERSION=0.36.0 -SUPERSET_RC=3 -SUPERSET_GITHUB_BRANCH=0.36 +SUPERSET_VERSION=0.37.0 +SUPERSET_RC=1 +SUPERSET_GITHUB_BRANCH=0.37 SUPERSET_PGP_FULLNAME=m...@apache.org -SUPERSET_VERSION_RC=0.36.0rc3 -SUPERSET_RELEASE=apache-superset-incubating-0.36.0 -SUPERSET_RELEASE_RC=apache-superset-incubating-0.36.0rc3 -SUPERSET_RELEASE_TARBALL=apache-superset-incubating-0.36.0-source.tar.gz - SUPERSET_RELEASE_RC_TARBALL=apache-superset-incubating-0.36.0rc3-source.tar.gz -SUPERSET_TMP_ASF_SITE_PATH=/tmp/incubator-superset-site-0.36.0 ---- +SUPERSET_VERSION_RC=0.37.0rc1 +SUPERSET_RELEASE=apache-superset-incubating-0.37.0 +SUPERSET_RELEASE_RC=apache-superset-incubating-0.37.0rc1 +SUPERSET_RELEASE_TARBALL=apache-superset-incubating-0.37.0-source.tar.gz + SUPERSET_RELEASE_RC_TARBALL=apache-superset-incubating-0.37.0rc1-source.tar.gz +SUPERSET_TMP_ASF_SITE_PATH=/tmp/incubator-superset-site-0.37.0 ``` ## Crafting a source release When crafting a new minor or major release we create -a branch named with the release MAJOR.MINOR version (on this example 0.35). +a branch named with the release MAJOR.MINOR version (on this example 0.37). This new branch will hold all PATCH and release candidates that belong to the MAJOR.MINOR version. The MAJOR.MINOR branch is normally a "cut" from a specific point in time from the master branch. -Then (if needed) apply all cherries that will make the PATCH +Then (if needed) apply all cherries that will make the PATCH. -Next update the `CHANGELOG.md` with all the changes that are included in the release. Make sure you have -set your GITHUB_TOKEN environment variable. +```bash +git checkout -b $SUPERSET_GITHUB_BRANCH +git push upstream $SUPERSET_GITHUB_BRANCH +``` + +Next, update the `CHANGELOG.md` with all the changes that are included in the release. +Make sure the branch has been pushed to `upstream` to ensure the changelog generator +can pick up changes since the previous release (otherwise `github-changes` will raise +an `Error: Not Found` exception). ```bash # will overwrites the local CHANGELOG.md, somehow you need to merge it in @@ -293,7 +299,7 @@ with the changes on `CHANGELOG.md` and `UPDATING.md`. ### Publishing a Convenience Release to PyPI Using the final release tarball, unpack it and run `./pypi_push.sh`. -This script will build the Javascript bundle and echo the twine command +This script will build the Javascript bundle and echo the twine command allowing you to publish to PyPI. You may need to ask a fellow committer to grant you access to it if you don't have access already. Make sure to create an account first if you don't have one, and reference your username diff --git a/RELEASING/email_templates/vote_pmc.j2 b/RELEASING/email_templates/vote_pmc.j2 index 9be4856..008dfad 100644 --- a/RELEASING/email_templates/vote_pmc.j2 +++ b/RELEASING/email_templates/vote_pmc.j2 @@ -34,6 +34,9 @@
[incubator-superset] branch 0.37 updated: fix: add updating headers for 0.36.0 and 0.37.0
This is an automated email from the ASF dual-hosted git repository. villebro pushed a commit to branch 0.37 in repository https://gitbox.apache.org/repos/asf/incubator-superset.git The following commit(s) were added to refs/heads/0.37 by this push: new 5693580 fix: add updating headers for 0.36.0 and 0.37.0 5693580 is described below commit 5693580daeddc42879d2a2e4f8af5e473301d181 Author: Ville Brofeldt AuthorDate: Sat Jul 11 12:14:39 2020 +0300 fix: add updating headers for 0.36.0 and 0.37.0 --- UPDATING.md | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/UPDATING.md b/UPDATING.md index 4d669d0..3755694 100644 --- a/UPDATING.md +++ b/UPDATING.md @@ -21,7 +21,7 @@ under the License. This file documents any backwards-incompatible changes in Superset and assists people when migrating to a new version. -## Next +## 0.37.0 * [9964](https://github.com/apache/incubator-superset/pull/9964): Breaking change on Flask-AppBuilder 3. If you're using OAuth, find out what needs to be changed [here](https://github.com/dpgaspar/Flask-AppBuilder/blob/master/README.rst#change-log). @@ -44,6 +44,8 @@ assists people when migrating to a new version. * [9572](https://github.com/apache/incubator-superset/pull/9572): a change which by default means that the Jinja `current_user_id`, `current_username`, and `url_param` context calls no longer need to be wrapped via `cache_key_wrapper` in order to be included in the cache key. The `cache_key_wrapper` function should only be required for Jinja add-ons. +## 0.36.0 + * [8867](https://github.com/apache/incubator-superset/pull/8867): a change which adds the `tmp_schema_name` column to the `query` table which requires locking the table. Given the `query` table is heavily used performance may be degraded during the migration. Scheduled downtime may be advised. * [9238](https://github.com/apache/incubator-superset/pull/9238): the config option `TIME_GRAIN_FUNCTIONS` has been renamed to `TIME_GRAIN_EXPRESSIONS` to better reflect the content of the dictionary.
svn commit: r40428 - in /dev/incubator/superset/0.37.0rc1: ./ apache-superset-incubating-0.37.0rc1-source.tar.gz apache-superset-incubating-0.37.0rc1-source.tar.gz.asc apache-superset-incubating-0.37.
Author: villebro Date: Sat Jul 11 08:40:25 2020 New Revision: 40428 Log: Release 0.37.0rc1 Added: dev/incubator/superset/0.37.0rc1/ dev/incubator/superset/0.37.0rc1/apache-superset-incubating-0.37.0rc1-source.tar.gz (with props) dev/incubator/superset/0.37.0rc1/apache-superset-incubating-0.37.0rc1-source.tar.gz.asc dev/incubator/superset/0.37.0rc1/apache-superset-incubating-0.37.0rc1-source.tar.gz.sha512 Added: dev/incubator/superset/0.37.0rc1/apache-superset-incubating-0.37.0rc1-source.tar.gz == Binary file - no diff available. Propchange: dev/incubator/superset/0.37.0rc1/apache-superset-incubating-0.37.0rc1-source.tar.gz -- svn:mime-type = application/octet-stream Added: dev/incubator/superset/0.37.0rc1/apache-superset-incubating-0.37.0rc1-source.tar.gz.asc == --- dev/incubator/superset/0.37.0rc1/apache-superset-incubating-0.37.0rc1-source.tar.gz.asc (added) +++ dev/incubator/superset/0.37.0rc1/apache-superset-incubating-0.37.0rc1-source.tar.gz.asc Sat Jul 11 08:40:25 2020 @@ -0,0 +1,11 @@ +-BEGIN PGP SIGNATURE- + +iQFIBAABCAAyFiEE91al5Odv7Ftw0dAOPG1R6/JstFEFAl8JdhMUHHZpbGxlYnJv +QGFwYWNoZS5vcmcACgkQPG1R6/JstFExbgf/S3zRWRVvclNxN1TnYhZENsgIcBrI +ANhNJYzR1cUM4OKdjvKGfkW8xrqgB9nPXWrDTrVb9fRS5Uscoh0KwFOu15ryezYr +yOLdoqo5QORb7H7nKNmoR9nMYtCV4j/WgXrSnS2AGo1cugw2nVs9XvGxPQfF1CZz +WzpJ/5qK912TlAgtx/wLkaC+wkYSsA3uxLD7VXuXhETGJ9uy7Q+rG2D7Lm1Yriu3 +gZ67dYhw9Ddpz0ZpSN7nWm9MfV6sqb1WNwvTn5xlWx1WhC0UqnOC4jOAQQPx5r8Y +L1ZRkUjnmJzgzt27VgGrVcVaHYuxFZMP+yMxSRKGpFHlHn0mewCRVPVm3A== +=fQ/x +-END PGP SIGNATURE- Added: dev/incubator/superset/0.37.0rc1/apache-superset-incubating-0.37.0rc1-source.tar.gz.sha512 == --- dev/incubator/superset/0.37.0rc1/apache-superset-incubating-0.37.0rc1-source.tar.gz.sha512 (added) +++ dev/incubator/superset/0.37.0rc1/apache-superset-incubating-0.37.0rc1-source.tar.gz.sha512 Sat Jul 11 08:40:25 2020 @@ -0,0 +1,3 @@ +/Users/ville/svn/superset_dev/0.37.0rc1/apache-superset-incubating-0.37.0rc1-source.tar.gz: +B6ED353F F8AD8A35 0061394C 82D76037 63A43576 76B9CC39 93ACDF24 F0CE5534 1C6CFA0F + BA99E304 6C76E240 B0AE1875 7E0AE104 E14C102F DEFAED0F C3FC080F
[incubator-superset] branch 0.37 created (now 06fd1b5)
This is an automated email from the ASF dual-hosted git repository. villebro pushed a change to branch 0.37 in repository https://gitbox.apache.org/repos/asf/incubator-superset.git. at 06fd1b5 logo gets the vertically-centered flexbox treatment in jinja template (#10281) No new revisions were added by this update.
