syncope git commit: Finished Findbugs sweep apart from core

2016-12-12 Thread coheigea 
Repository: syncope
Updated Branches:
  refs/heads/2_0_X 778cb32ca -> b738c07b9


Finished Findbugs sweep apart from core


Project: http://git-wip-us.apache.org/repos/asf/syncope/repo
Commit: http://git-wip-us.apache.org/repos/asf/syncope/commit/b738c07b
Tree: http://git-wip-us.apache.org/repos/asf/syncope/tree/b738c07b
Diff: http://git-wip-us.apache.org/repos/asf/syncope/diff/b738c07b

Branch: refs/heads/2_0_X
Commit: b738c07b9d7e1a3c89300dbd0b557a8525f45e4b
Parents: 778cb32
Author: Colm O hEigeartaigh 
Authored: Mon Dec 12 11:17:19 2016 +
Committer: Colm O hEigeartaigh 
Committed: Mon Dec 12 11:17:54 2016 +

--
 .../buildtools/ApacheDSStartStopListener.java   |  6 +-
 .../fit/buildtools/cxf/ProvisioningImpl.java| 11 +++
 .../core/reference/DoubleValueLogicActions.java |  4 +-
 .../ide/eclipse/plugin/views/SyncopeView.java   |  4 +-
 .../installer/files/ConsoleProperties.java  |  4 +-
 .../installer/files/EnduserProperties.java  |  4 +-
 .../installer/files/MasterProperties.java   | 90 ++--
 .../syncope/installer/utilities/HttpUtils.java  |  2 +-
 8 files changed, 68 insertions(+), 57 deletions(-)
--


http://git-wip-us.apache.org/repos/asf/syncope/blob/b738c07b/fit/build-tools/src/main/java/org/apache/syncope/fit/buildtools/ApacheDSStartStopListener.java
--
diff --git 
a/fit/build-tools/src/main/java/org/apache/syncope/fit/buildtools/ApacheDSStartStopListener.java
 
b/fit/build-tools/src/main/java/org/apache/syncope/fit/buildtools/ApacheDSStartStopListener.java
index 50049c8..7fae668 100644
--- 
a/fit/build-tools/src/main/java/org/apache/syncope/fit/buildtools/ApacheDSStartStopListener.java
+++ 
b/fit/build-tools/src/main/java/org/apache/syncope/fit/buildtools/ApacheDSStartStopListener.java
@@ -77,7 +77,7 @@ public class ApacheDSStartStopListener implements 
ServletContextListener {
 private Partition addPartition(final String partitionId, final String 
partitionDn, final DnFactory dnFactory)
 throws Exception {
 
-// Create a new partition with the given partition id 
+// Create a new partition with the given partition id
 JdbmPartition partition = new 
JdbmPartition(service.getSchemaManager(), dnFactory);
 partition.setId(partitionId);
 partition.setPartitionPath(new 
File(service.getInstanceLayout().getPartitionsDirectory(), 
partitionId).toURI());
@@ -173,7 +173,7 @@ public class ApacheDSStartStopListener implements 
ServletContextListener {
 // then the system partition
 // this is a MANDATORY partition
 // DO NOT add this via addPartition() method, trunk code complains 
about duplicate partition
-// while initializing 
+// while initializing
 JdbmPartition systemPartition = new 
JdbmPartition(service.getSchemaManager(), service.getDnFactory());
 systemPartition.setId("system");
 systemPartition.setPartitionPath(
@@ -229,7 +229,7 @@ public class ApacheDSStartStopListener implements 
ServletContextListener {
 initDirectoryService(sce.getServletContext(), workDir, 
loadDefaultContent);
 
 server = new LdapServer();
-server.setTransports(new TcpTransport(Integer.valueOf(
+server.setTransports(new TcpTransport(Integer.parseInt(
 
WebApplicationContextUtils.getWebApplicationContext(sce.getServletContext()).
 getBean("testds.port", String.class;
 server.setDirectoryService(service);

http://git-wip-us.apache.org/repos/asf/syncope/blob/b738c07b/fit/build-tools/src/main/java/org/apache/syncope/fit/buildtools/cxf/ProvisioningImpl.java
--
diff --git 
a/fit/build-tools/src/main/java/org/apache/syncope/fit/buildtools/cxf/ProvisioningImpl.java
 
b/fit/build-tools/src/main/java/org/apache/syncope/fit/buildtools/cxf/ProvisioningImpl.java
index e384734..6eefe5c 100644
--- 
a/fit/build-tools/src/main/java/org/apache/syncope/fit/buildtools/cxf/ProvisioningImpl.java
+++ 
b/fit/build-tools/src/main/java/org/apache/syncope/fit/buildtools/cxf/ProvisioningImpl.java
@@ -73,6 +73,8 @@ public class ProvisioningImpl implements Provisioning {
 
 statement.executeUpdate();
 
+statement.close();
+
 return accountid;
 } catch (SQLException e) {
 throw new ProvisioningException("Delete operation failed", e);
@@ -164,6 +166,7 @@ public class ProvisioningImpl implements Provisioning {
 LOG.debug("Execute query: " + query);
 
 statement.executeUpdate();
+statement.close();
 }
 
 return accountid;
@@ -225,6 +228,8 @@ public class

syncope git commit: Finished Findbugs sweep apart from core

2016-12-12 Thread coheigea 
Repository: syncope
Updated Branches:
  refs/heads/master 367bf6160 -> e9fa33703


Finished Findbugs sweep apart from core


Project: http://git-wip-us.apache.org/repos/asf/syncope/repo
Commit: http://git-wip-us.apache.org/repos/asf/syncope/commit/e9fa3370
Tree: http://git-wip-us.apache.org/repos/asf/syncope/tree/e9fa3370
Diff: http://git-wip-us.apache.org/repos/asf/syncope/diff/e9fa3370

Branch: refs/heads/master
Commit: e9fa33703e97f738db468380eff8dd8f43d29c67
Parents: 367bf61
Author: Colm O hEigeartaigh 
Authored: Mon Dec 12 11:17:19 2016 +
Committer: Colm O hEigeartaigh 
Committed: Mon Dec 12 11:17:19 2016 +

--
 .../buildtools/ApacheDSStartStopListener.java   |  6 +-
 .../fit/buildtools/cxf/ProvisioningImpl.java| 11 +++
 .../core/reference/DoubleValueLogicActions.java |  4 +-
 .../ide/eclipse/plugin/views/SyncopeView.java   |  4 +-
 .../installer/files/ConsoleProperties.java  |  4 +-
 .../installer/files/EnduserProperties.java  |  4 +-
 .../installer/files/MasterProperties.java   | 90 ++--
 .../syncope/installer/utilities/HttpUtils.java  |  2 +-
 8 files changed, 68 insertions(+), 57 deletions(-)
--


http://git-wip-us.apache.org/repos/asf/syncope/blob/e9fa3370/fit/build-tools/src/main/java/org/apache/syncope/fit/buildtools/ApacheDSStartStopListener.java
--
diff --git 
a/fit/build-tools/src/main/java/org/apache/syncope/fit/buildtools/ApacheDSStartStopListener.java
 
b/fit/build-tools/src/main/java/org/apache/syncope/fit/buildtools/ApacheDSStartStopListener.java
index 50049c8..7fae668 100644
--- 
a/fit/build-tools/src/main/java/org/apache/syncope/fit/buildtools/ApacheDSStartStopListener.java
+++ 
b/fit/build-tools/src/main/java/org/apache/syncope/fit/buildtools/ApacheDSStartStopListener.java
@@ -77,7 +77,7 @@ public class ApacheDSStartStopListener implements 
ServletContextListener {
 private Partition addPartition(final String partitionId, final String 
partitionDn, final DnFactory dnFactory)
 throws Exception {
 
-// Create a new partition with the given partition id 
+// Create a new partition with the given partition id
 JdbmPartition partition = new 
JdbmPartition(service.getSchemaManager(), dnFactory);
 partition.setId(partitionId);
 partition.setPartitionPath(new 
File(service.getInstanceLayout().getPartitionsDirectory(), 
partitionId).toURI());
@@ -173,7 +173,7 @@ public class ApacheDSStartStopListener implements 
ServletContextListener {
 // then the system partition
 // this is a MANDATORY partition
 // DO NOT add this via addPartition() method, trunk code complains 
about duplicate partition
-// while initializing 
+// while initializing
 JdbmPartition systemPartition = new 
JdbmPartition(service.getSchemaManager(), service.getDnFactory());
 systemPartition.setId("system");
 systemPartition.setPartitionPath(
@@ -229,7 +229,7 @@ public class ApacheDSStartStopListener implements 
ServletContextListener {
 initDirectoryService(sce.getServletContext(), workDir, 
loadDefaultContent);
 
 server = new LdapServer();
-server.setTransports(new TcpTransport(Integer.valueOf(
+server.setTransports(new TcpTransport(Integer.parseInt(
 
WebApplicationContextUtils.getWebApplicationContext(sce.getServletContext()).
 getBean("testds.port", String.class;
 server.setDirectoryService(service);

http://git-wip-us.apache.org/repos/asf/syncope/blob/e9fa3370/fit/build-tools/src/main/java/org/apache/syncope/fit/buildtools/cxf/ProvisioningImpl.java
--
diff --git 
a/fit/build-tools/src/main/java/org/apache/syncope/fit/buildtools/cxf/ProvisioningImpl.java
 
b/fit/build-tools/src/main/java/org/apache/syncope/fit/buildtools/cxf/ProvisioningImpl.java
index e384734..6eefe5c 100644
--- 
a/fit/build-tools/src/main/java/org/apache/syncope/fit/buildtools/cxf/ProvisioningImpl.java
+++ 
b/fit/build-tools/src/main/java/org/apache/syncope/fit/buildtools/cxf/ProvisioningImpl.java
@@ -73,6 +73,8 @@ public class ProvisioningImpl implements Provisioning {
 
 statement.executeUpdate();
 
+statement.close();
+
 return accountid;
 } catch (SQLException e) {
 throw new ProvisioningException("Delete operation failed", e);
@@ -164,6 +166,7 @@ public class ProvisioningImpl implements Provisioning {
 LOG.debug("Execute query: " + query);
 
 statement.executeUpdate();
+statement.close();
 }
 
 return accountid;
@@ -225,6 +228,8 @@ public class