[jira] Commented: (TAP5-486) Switch Tapestry's built-in JavaScript support from Prototype to jQuery

2009-02-18 Thread luna Guo (JIRA)

[ 
https://issues.apache.org/jira/browse/TAP5-486?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12674864#action_12674864
 ] 

luna Guo commented on TAP5-486:
---

jQuery has thousands of plugins that i can use them easily without much 
javascript experience.I can't leave it .Even i've written some code using 
prototype,i have to include jQuery for using a lot of UI components.There's 
hundreds kb of javascript for a page.
I think the javascript lib tapestry include must be small and a lot of UI can 
be find.I like jQuery's "Write Less, Do More".
To use a small one,and never change it to another again.We don't want to 
lean/use so many javascript frameworks.

> Switch Tapestry's built-in JavaScript support from Prototype to jQuery
> --
>
> Key: TAP5-486
> URL: https://issues.apache.org/jira/browse/TAP5-486
> Project: Tapestry 5
>  Issue Type: Improvement
>  Components: tapestry-core
>Affects Versions: 5.1.0.0
>Reporter: Howard M. Lewis Ship
>
> Like rats deserting a sinking ship ...
> This is not a definitive requirement; I've created this issue to promote 
> discussion.
> It's quite likely that a move like this could be accomplished quite smoothly 
> for users who are meerly consumers of JavaScript components; authors of 
> JavaScript components would have to make some changes.
> Possibly we should code the jQuery stack from the get-go to NOT use the $() 
> method, but instead use j$(). That extra character to type could make all the 
> difference is allowing a smooth upgrade, where jQuery becomes the default, 
> but prototype/scriptaculous can still be used.
> Possibly a new annotation, @PrototypeSupport for components to ensure that 
> the Prototype libraries are available for compatibility?

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Created: (TAP5-526) VerifyError when a subclass uses @PageActivationContext but extends from a super-class that also uses @PageActivationContext

2009-02-18 Thread Howard M. Lewis Ship (JIRA)
VerifyError when a subclass uses @PageActivationContext but extends from a 
super-class that also uses @PageActivationContext


 Key: TAP5-526
 URL: https://issues.apache.org/jira/browse/TAP5-526
 Project: Tapestry 5
  Issue Type: Bug
  Components: tapestry-core
Affects Versions: 5.1.0.0
Reporter: Howard M. Lewis Ship


java.lang.VerifyError
class com.formos.tapestry.svnadmin.pages.RejectProject overrides final method .


* java.lang.ClassLoader.defineClass1(Native Method)
* java.lang.ClassLoader.defineClass(ClassLoader.java:675)
* java.lang.ClassLoader.defineClass(ClassLoader.java:520)
* javassist.Loader.findClass(Loader.java:379)
* 
org.apache.tapestry5.internal.services.ComponentInstantiatorSourceImpl$PackageAwareLoader.findClass(ComponentInstantiatorSourceImpl.java:94)
* javassist.Loader.loadClass(Loader.java:311)
* java.lang.ClassLoader.loadClass(ClassLoader.java:251)
* 
org.apache.tapestry5.internal.services.ComponentInstantiatorSourceImpl.findClass(ComponentInstantiatorSourceImpl.java:296)
* 
org.apache.tapestry5.internal.services.ComponentInstantiatorSourceImpl.getInstantiator(ComponentInstantiatorSourceImpl.java:276)
* 
$ComponentInstantiatorSource_11f8bfd139e.getInstantiator($ComponentInstantiatorSource_11f8bfd139e.java)
* 
org.apache.tapestry5.internal.pageload.PageLoaderImpl.createAssembler(PageLoaderImpl.java:205)
* 
org.apache.tapestry5.internal.pageload.PageLoaderImpl.getAssembler(PageLoaderImpl.java:195)
* 
org.apache.tapestry5.internal.pageload.PageLoaderImpl.loadPage(PageLoaderImpl.java:169)
 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Closed: (TAP5-523) Submit component should be able to render an input field of type image

2009-02-18 Thread Igor Drobiazko (JIRA)

 [ 
https://issues.apache.org/jira/browse/TAP5-523?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Igor Drobiazko closed TAP5-523.
---

   Resolution: Fixed
Fix Version/s: 5.1.0.0

> Submit component should be able to render an input field of type image
> --
>
> Key: TAP5-523
> URL: https://issues.apache.org/jira/browse/TAP5-523
> Project: Tapestry 5
>  Issue Type: Improvement
>Affects Versions: 5.0.15
>Reporter: Igor Drobiazko
>Assignee: Igor Drobiazko
> Fix For: 5.1.0.0
>
>
> The Submit component has two major deficiencies:
> 1) You cannot use an image submit (  )
> 2) You cannot pass any context into the button's "selected" event handler.
> Issue 1 currently requires you to create your own submit button type, though 
> this is simple if you don't mind copy/pasting the current Submit class and 
> changing one line.
> Issue 2 is a much bigger problem.  If you have a submit button in a loop and 
> need to know (for example) which item was current in the loop when it was 
> rendered, you have to set "defer" to false, then record the context 
> information in your onSelected handler.  You often can't perform a useful 
> action directly in your deferred onSelected handler because you shouldn't 
> change the structure of your bound data in the middle of a form submit, or 
> because you should not perform your action until you're assured the form has 
> validated.
> So, you now have to record the context that you need to perform the action, 
> PLUS the action that needs to be performed, and then perform it all inside of 
> your onSuccess handler!  Frankly, this seems so inelegant as to have been an 
> oversight.
> On the Tapestry Wiki, at 
> http://wiki.apache.org/tapestry/Tapestry5SubmitContextComponent there is a 
> basic implementation, though it has several weaknesses:
> 1) It was written for 5.0.4 and doesn't compile without changing a few minor 
> things, nor does it support RenderDisabled.
> 2) It only supports a single context parameter and it makes no effort to 
> properly encode it when rendered to the client.
> So, based on the concept used on the wiki code (namely, using a  
> field to store the context) I made a few small modifications to the Tapestry 
> 5.0.11 Submit.java class that I will attach to this issue.
> I grant ownership of the attached code to the Apache Software Foundation.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Created: (TAP5-525) The Component Report should provide the Tapestry version the particular parameter was introduced in

2009-02-18 Thread Igor Drobiazko (JIRA)
The Component Report should provide the Tapestry version the particular 
parameter was introduced in
---

 Key: TAP5-525
 URL: https://issues.apache.org/jira/browse/TAP5-525
 Project: Tapestry 5
  Issue Type: Improvement
  Components: tapestry-component-report
Affects Versions: 5.0.18
Reporter: Igor Drobiazko
Priority: Minor


Add a new column 'since' into the Component Parameters table that contains the 
value of the javadoc tag @since of the particular field, if provided.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



svn commit: r745692 - in /tapestry/tapestry5/trunk/tapestry-core/src: main/java/org/apache/tapestry5/corelib/components/ test/java/org/apache/tapestry5/integration/app2/pages/ test/java/org/apache/tap

2009-02-18 Thread drobiazko
Author: drobiazko
Date: Wed Feb 18 23:38:05 2009
New Revision: 745692

URL: http://svn.apache.org/viewvc?rev=745692&view=rev
Log:
TAP5-523: Submit component should be able to render an input field of type image

Modified:

tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/corelib/components/Submit.java

tapestry/tapestry5/trunk/tapestry-core/src/test/java/org/apache/tapestry5/integration/app2/pages/TestPageForSubmit.java

tapestry/tapestry5/trunk/tapestry-core/src/test/java/org/apache/tapestry5/integration/pagelevel/SubmitTest.java

tapestry/tapestry5/trunk/tapestry-core/src/test/resources/org/apache/tapestry5/integration/app2/pages/TestPageForSubmit.tml

Modified: 
tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/corelib/components/Submit.java
URL: 
http://svn.apache.org/viewvc/tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/corelib/components/Submit.java?rev=745692&r1=745691&r2=745692&view=diff
==
--- 
tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/corelib/components/Submit.java
 (original)
+++ 
tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/corelib/components/Submit.java
 Wed Feb 18 23:38:05 2009
@@ -62,6 +62,14 @@
  */
 @Parameter
 private Object[] context;
+
+/**
+ * If provided, the component renders an input tag with type "image". 
Otherwise "submit".
+ * 
+ * @since 5.1.0.0
+ */
+@Parameter(defaultPrefix = BindingConstants.ASSET)
+private Asset image;
 
 
 @Environmental
@@ -115,9 +123,13 @@
 
 // Save the element, to see if an id is later requested.
 
-element = writer.element("input", "type", "submit", "name", name);
+String type = image==null?"submit":"image";
+
+element = writer.element("input", "type", type, "name", name);
 
 if (disabled) writer.attributes("disabled", "disabled");
+
+if(image!=null) writer.attributes("src", image.toClientURL());
 
 formSupport.store(this, new ProcessSubmission(name));
 

Modified: 
tapestry/tapestry5/trunk/tapestry-core/src/test/java/org/apache/tapestry5/integration/app2/pages/TestPageForSubmit.java
URL: 
http://svn.apache.org/viewvc/tapestry/tapestry5/trunk/tapestry-core/src/test/java/org/apache/tapestry5/integration/app2/pages/TestPageForSubmit.java?rev=745692&r1=745691&r2=745692&view=diff
==
--- 
tapestry/tapestry5/trunk/tapestry-core/src/test/java/org/apache/tapestry5/integration/app2/pages/TestPageForSubmit.java
 (original)
+++ 
tapestry/tapestry5/trunk/tapestry-core/src/test/java/org/apache/tapestry5/integration/app2/pages/TestPageForSubmit.java
 Wed Feb 18 23:38:05 2009
@@ -14,11 +14,15 @@
 
 package org.apache.tapestry5.integration.app2.pages;
 
+import org.apache.tapestry5.Asset;
 import org.apache.tapestry5.annotations.Component;
+import org.apache.tapestry5.annotations.Path;
 import org.apache.tapestry5.annotations.Persist;
+import org.apache.tapestry5.annotations.Property;
 import org.apache.tapestry5.corelib.components.Form;
 import org.apache.tapestry5.corelib.components.Submit;
 import org.apache.tapestry5.corelib.components.TextField;
+import org.apache.tapestry5.ioc.annotations.Inject;
 
 public class TestPageForSubmit
 {
@@ -45,6 +49,11 @@
 @SuppressWarnings("unused")
 @Component(parameters = "value=value")
 private TextField t2;
+
+@Property
+@Inject
+@Path("${tapestry.spacer-image}")
+private Asset spacerImage;
 
 @Persist
 private String value;

Modified: 
tapestry/tapestry5/trunk/tapestry-core/src/test/java/org/apache/tapestry5/integration/pagelevel/SubmitTest.java
URL: 
http://svn.apache.org/viewvc/tapestry/tapestry5/trunk/tapestry-core/src/test/java/org/apache/tapestry5/integration/pagelevel/SubmitTest.java?rev=745692&r1=745691&r2=745692&view=diff
==
--- 
tapestry/tapestry5/trunk/tapestry-core/src/test/java/org/apache/tapestry5/integration/pagelevel/SubmitTest.java
 (original)
+++ 
tapestry/tapestry5/trunk/tapestry-core/src/test/java/org/apache/tapestry5/integration/pagelevel/SubmitTest.java
 Wed Feb 18 23:38:05 2009
@@ -17,6 +17,7 @@
 import org.apache.tapestry5.dom.Document;
 import org.apache.tapestry5.dom.Element;
 import org.apache.tapestry5.ioc.internal.util.CollectionFactory;
+import org.apache.tapestry5.ioc.services.SymbolSource;
 import org.apache.tapestry5.test.PageTester;
 import org.testng.Assert;
 import org.testng.annotations.AfterMethod;
@@ -37,6 +38,8 @@
 public void submit_form()
 {
 Element submitButton = doc.getElementById("capitalize1");
+assertEquals("submit", submitButton.getAttribute("type"));
+
 fieldValues.put("t1", "hello");
 doc = tester.clickSubm

svn commit: r745681 - /tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/corelib/components/Submit.java

2009-02-18 Thread drobiazko
Author: drobiazko
Date: Wed Feb 18 22:47:05 2009
New Revision: 745681

URL: http://svn.apache.org/viewvc?rev=745681&view=rev
Log:
Fixing the documentation

Modified:

tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/corelib/components/Submit.java

Modified: 
tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/corelib/components/Submit.java
URL: 
http://svn.apache.org/viewvc/tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/corelib/components/Submit.java?rev=745681&r1=745680&r2=745681&view=diff
==
--- 
tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/corelib/components/Submit.java
 (original)
+++ 
tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/corelib/components/Submit.java
 Wed Feb 18 22:47:05 2009
@@ -54,9 +54,11 @@
 private boolean disabled;
 
 /**
- * The context for the link (optional parameter). This list of values will 
be converted into strings and included in
- * the URI. The strings will be coerced back to whatever their values are 
and made available to event handler
- * methods.
+ * The list of values that will be converted into strings when the form is 
submitted. 
+ * The strings will be coerced back to whatever their values are and made 
available to event 
+ * handler method of this component. 
+ * 
+ * @since 5.1.0.0
  */
 @Parameter
 private Object[] context;




[jira] Created: (TAP5-524) Parameters exposed from embedded components not included in Component Reference

2009-02-18 Thread Yunhua Sang (JIRA)
Parameters exposed from embedded components not included in Component Reference
---

 Key: TAP5-524
 URL: https://issues.apache.org/jira/browse/TAP5-524
 Project: Tapestry 5
  Issue Type: Bug
  Components: tapestry-component-report
Affects Versions: 5.1.0.0
Reporter: Yunhua Sang


Parameters exposed from embedded component by using the new introduced 
"publishParameters" in annotation @Component are not shown on Component 
Reference document. For instance, Grid should have parameters 
"rowIndex,rowClass,volatile,encoder,lean" etc listed on its reference page, but 
they are missing currently, those parameter are published from a contained 
GridRows component. 

Current Grid reference: 
http://tapestry.formos.com/nightly/tapestry5/tapestry-core/ref/org/apache/tapestry5/corelib/components/Grid.html
 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Closed: (TAP5-194) Handler method of Submit component should accept a context

2009-02-18 Thread Igor Drobiazko (JIRA)

 [ 
https://issues.apache.org/jira/browse/TAP5-194?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Igor Drobiazko closed TAP5-194.
---

   Resolution: Fixed
Fix Version/s: 5.1.0.0

> Handler method of Submit component should accept a context
> --
>
> Key: TAP5-194
> URL: https://issues.apache.org/jira/browse/TAP5-194
> Project: Tapestry 5
>  Issue Type: Improvement
>Affects Versions: 5.0.15
>Reporter: Cherry Development
>Assignee: Igor Drobiazko
> Fix For: 5.1.0.0
>
> Attachments: SubmitContext.java
>
>
> The Submit component has two major deficiencies:
> 1) You cannot use an image submit (  )
> 2) You cannot pass any context into the button's "selected" event handler.
> Issue 1 currently requires you to create your own submit button type, though 
> this is simple if you don't mind copy/pasting the current Submit class and 
> changing one line.
> Issue 2 is a much bigger problem.  If you have a submit button in a loop and 
> need to know (for example) which item was current in the loop when it was 
> rendered, you have to set "defer" to false, then record the context 
> information in your onSelected handler.  You often can't perform a useful 
> action directly in your deferred onSelected handler because you shouldn't 
> change the structure of your bound data in the middle of a form submit, or 
> because you should not perform your action until you're assured the form has 
> validated.
> So, you now have to record the context that you need to perform the action, 
> PLUS the action that needs to be performed, and then perform it all inside of 
> your onSuccess handler!  Frankly, this seems so inelegant as to have been an 
> oversight.
> On the Tapestry Wiki, at 
> http://wiki.apache.org/tapestry/Tapestry5SubmitContextComponent there is a 
> basic implementation, though it has several weaknesses:
> 1) It was written for 5.0.4 and doesn't compile without changing a few minor 
> things, nor does it support RenderDisabled.
> 2) It only supports a single context parameter and it makes no effort to 
> properly encode it when rendered to the client.
> So, based on the concept used on the wiki code (namely, using a  
> field to store the context) I made a few small modifications to the Tapestry 
> 5.0.11 Submit.java class that I will attach to this issue.
> I grant ownership of the attached code to the Apache Software Foundation.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



svn commit: r745627 - in /tapestry/tapestry5/trunk/tapestry-core/src: main/java/org/apache/tapestry5/corelib/components/ test/java/org/apache/tapestry5/integration/ test/java/org/apache/tapestry5/inte

2009-02-18 Thread drobiazko
Author: drobiazko
Date: Wed Feb 18 19:45:03 2009
New Revision: 745627

URL: http://svn.apache.org/viewvc?rev=745627&view=rev
Log:
TAP5-194: Handler method of Submit component should accept a context

Added:

tapestry/tapestry5/trunk/tapestry-core/src/test/java/org/apache/tapestry5/integration/app1/pages/SubmitWithContext.java

tapestry/tapestry5/trunk/tapestry-core/src/test/resources/org/apache/tapestry5/integration/app1/pages/SubmitWithContext.tml
Modified:

tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/corelib/components/Submit.java

tapestry/tapestry5/trunk/tapestry-core/src/test/java/org/apache/tapestry5/integration/IntegrationTests.java

tapestry/tapestry5/trunk/tapestry-core/src/test/java/org/apache/tapestry5/integration/app1/pages/Index.java

Modified: 
tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/corelib/components/Submit.java
URL: 
http://svn.apache.org/viewvc/tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/corelib/components/Submit.java?rev=745627&r1=745626&r2=745627&view=diff
==
--- 
tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/corelib/components/Submit.java
 (original)
+++ 
tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/corelib/components/Submit.java
 Wed Feb 18 19:45:03 2009
@@ -52,6 +52,14 @@
  */
 @Parameter("false")
 private boolean disabled;
+
+/**
+ * The context for the link (optional parameter). This list of values will 
be converted into strings and included in
+ * the URI. The strings will be coerced back to whatever their values are 
and made available to event handler
+ * methods.
+ */
+@Parameter
+private Object[] context;
 
 
 @Environmental
@@ -131,7 +139,7 @@
 {
 public void run()
 {
-resources.triggerEvent(event, null, null);
+resources.triggerEvent(event, context, null);
 }
 };
 

Modified: 
tapestry/tapestry5/trunk/tapestry-core/src/test/java/org/apache/tapestry5/integration/IntegrationTests.java
URL: 
http://svn.apache.org/viewvc/tapestry/tapestry5/trunk/tapestry-core/src/test/java/org/apache/tapestry5/integration/IntegrationTests.java?rev=745627&r1=745626&r2=745627&view=diff
==
--- 
tapestry/tapestry5/trunk/tapestry-core/src/test/java/org/apache/tapestry5/integration/IntegrationTests.java
 (original)
+++ 
tapestry/tapestry5/trunk/tapestry-core/src/test/java/org/apache/tapestry5/integration/IntegrationTests.java
 Wed Feb 18 19:45:03 2009
@@ -1992,6 +1992,16 @@
 
 assertText("sum", "0.0");
 }
+
+@Test
+public void submit_with_context()
+{
+start("Submit With Context");
+
+clickAndWait(SUBMIT);
+
+assertTextPresent("Result: 10.14159");
+}
 
 /**
  * TAPESTRY-2196

Modified: 
tapestry/tapestry5/trunk/tapestry-core/src/test/java/org/apache/tapestry5/integration/app1/pages/Index.java
URL: 
http://svn.apache.org/viewvc/tapestry/tapestry5/trunk/tapestry-core/src/test/java/org/apache/tapestry5/integration/app1/pages/Index.java?rev=745627&r1=745626&r2=745627&view=diff
==
--- 
tapestry/tapestry5/trunk/tapestry-core/src/test/java/org/apache/tapestry5/integration/app1/pages/Index.java
 (original)
+++ 
tapestry/tapestry5/trunk/tapestry-core/src/test/java/org/apache/tapestry5/integration/app1/pages/Index.java
 Wed Feb 18 19:45:03 2009
@@ -317,7 +317,10 @@
  "Access to informal parameters names and values"),
 
 new Item("FormFieldOutsideForm", "Form Field Outside Form",
- "Nice exception message for common problem of form fields 
outside forms")
+ "Nice exception message for common problem of form fields 
outside forms"),
+
+new Item("SubmitWithContext", "Submit With Context",
+  "Providing a context for Submit component")
 );
 
 static

Added: 
tapestry/tapestry5/trunk/tapestry-core/src/test/java/org/apache/tapestry5/integration/app1/pages/SubmitWithContext.java
URL: 
http://svn.apache.org/viewvc/tapestry/tapestry5/trunk/tapestry-core/src/test/java/org/apache/tapestry5/integration/app1/pages/SubmitWithContext.java?rev=745627&view=auto
==
--- 
tapestry/tapestry5/trunk/tapestry-core/src/test/java/org/apache/tapestry5/integration/app1/pages/SubmitWithContext.java
 (added)
+++ 
tapestry/tapestry5/trunk/tapestry-core/src/test/java/org/apache/tapestry5/integration/app1/pages/SubmitWithContext.java
 Wed Feb 18 19:45:03 2009
@@ -0,0 +1,35 @@
+// Copyright 2009 The Apache Software Foundation
+//
+// Licensed under the Apache 

[jira] Updated: (TAP5-194) Handler method of Submit component should accept a context

2009-02-18 Thread Igor Drobiazko (JIRA)

 [ 
https://issues.apache.org/jira/browse/TAP5-194?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Igor Drobiazko updated TAP5-194:


Summary: Handler method of Submit component should accept a context  (was: 
Submit Button missing context and image support)

> Handler method of Submit component should accept a context
> --
>
> Key: TAP5-194
> URL: https://issues.apache.org/jira/browse/TAP5-194
> Project: Tapestry 5
>  Issue Type: Improvement
>Affects Versions: 5.0.15
>Reporter: Cherry Development
>Assignee: Igor Drobiazko
> Attachments: SubmitContext.java
>
>
> The Submit component has two major deficiencies:
> 1) You cannot use an image submit (  )
> 2) You cannot pass any context into the button's "selected" event handler.
> Issue 1 currently requires you to create your own submit button type, though 
> this is simple if you don't mind copy/pasting the current Submit class and 
> changing one line.
> Issue 2 is a much bigger problem.  If you have a submit button in a loop and 
> need to know (for example) which item was current in the loop when it was 
> rendered, you have to set "defer" to false, then record the context 
> information in your onSelected handler.  You often can't perform a useful 
> action directly in your deferred onSelected handler because you shouldn't 
> change the structure of your bound data in the middle of a form submit, or 
> because you should not perform your action until you're assured the form has 
> validated.
> So, you now have to record the context that you need to perform the action, 
> PLUS the action that needs to be performed, and then perform it all inside of 
> your onSuccess handler!  Frankly, this seems so inelegant as to have been an 
> oversight.
> On the Tapestry Wiki, at 
> http://wiki.apache.org/tapestry/Tapestry5SubmitContextComponent there is a 
> basic implementation, though it has several weaknesses:
> 1) It was written for 5.0.4 and doesn't compile without changing a few minor 
> things, nor does it support RenderDisabled.
> 2) It only supports a single context parameter and it makes no effort to 
> properly encode it when rendered to the client.
> So, based on the concept used on the wiki code (namely, using a  
> field to store the context) I made a few small modifications to the Tapestry 
> 5.0.11 Submit.java class that I will attach to this issue.
> I grant ownership of the attached code to the Apache Software Foundation.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Created: (TAP5-523) Submit component should be able to render an input field of type image

2009-02-18 Thread Igor Drobiazko (JIRA)
Submit component should be able to render an input field of type image
--

 Key: TAP5-523
 URL: https://issues.apache.org/jira/browse/TAP5-523
 Project: Tapestry 5
  Issue Type: Improvement
Affects Versions: 5.0.15
Reporter: Igor Drobiazko
Assignee: Igor Drobiazko


The Submit component has two major deficiencies:
1) You cannot use an image submit (  )
2) You cannot pass any context into the button's "selected" event handler.

Issue 1 currently requires you to create your own submit button type, though 
this is simple if you don't mind copy/pasting the current Submit class and 
changing one line.

Issue 2 is a much bigger problem.  If you have a submit button in a loop and 
need to know (for example) which item was current in the loop when it was 
rendered, you have to set "defer" to false, then record the context information 
in your onSelected handler.  You often can't perform a useful action directly 
in your deferred onSelected handler because you shouldn't change the structure 
of your bound data in the middle of a form submit, or because you should not 
perform your action until you're assured the form has validated.
So, you now have to record the context that you need to perform the action, 
PLUS the action that needs to be performed, and then perform it all inside of 
your onSuccess handler!  Frankly, this seems so inelegant as to have been an 
oversight.

On the Tapestry Wiki, at 
http://wiki.apache.org/tapestry/Tapestry5SubmitContextComponent there is a 
basic implementation, though it has several weaknesses:
1) It was written for 5.0.4 and doesn't compile without changing a few minor 
things, nor does it support RenderDisabled.
2) It only supports a single context parameter and it makes no effort to 
properly encode it when rendered to the client.

So, based on the concept used on the wiki code (namely, using a  field 
to store the context) I made a few small modifications to the Tapestry 5.0.11 
Submit.java class that I will attach to this issue.

I grant ownership of the attached code to the Apache Software Foundation.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



svn commit: r745612 - /tapestry/tapestry5/trunk/pom.xml

2009-02-18 Thread robertdzeigler
Author: robertdzeigler
Date: Wed Feb 18 19:01:54 2009
New Revision: 745612

URL: http://svn.apache.org/viewvc?rev=745612&view=rev
Log:
Fix whitespacing (tabs should have been expanded to spaces) and missing close 
tag of developer in pom.xml for addition of developer Robert Zeigler.

Modified:
tapestry/tapestry5/trunk/pom.xml

Modified: tapestry/tapestry5/trunk/pom.xml
URL: 
http://svn.apache.org/viewvc/tapestry/tapestry5/trunk/pom.xml?rev=745612&r1=745611&r2=745612&view=diff
==
--- tapestry/tapestry5/trunk/pom.xml (original)
+++ tapestry/tapestry5/trunk/pom.xml Wed Feb 18 19:01:54 2009
@@ -88,14 +88,15 @@
 
 +1
 
-   
-   robertdzeigler
-   Robert Zeigler
-   robertdzeig...@apache.org
-   
-   Developer
-   
-   -6
+
+robertdzeigler
+Robert Zeigler
+robertdzeig...@apache.org
+
+Developer
+
+-6
+
 
 
 




svn commit: r745611 - /tapestry/tapestry5/trunk/pom.xml

2009-02-18 Thread robertdzeigler
Author: robertdzeigler
Date: Wed Feb 18 18:58:44 2009
New Revision: 745611

URL: http://svn.apache.org/viewvc?rev=745611&view=rev
Log:
Add Robert Zeigler as a T5 developer.

Modified:
tapestry/tapestry5/trunk/pom.xml

Modified: tapestry/tapestry5/trunk/pom.xml
URL: 
http://svn.apache.org/viewvc/tapestry/tapestry5/trunk/pom.xml?rev=745611&r1=745610&r2=745611&view=diff
==
--- tapestry/tapestry5/trunk/pom.xml (original)
+++ tapestry/tapestry5/trunk/pom.xml Wed Feb 18 18:58:44 2009
@@ -88,6 +88,14 @@
 
 +1
 
+   
+   robertdzeigler
+   Robert Zeigler
+   robertdzeig...@apache.org
+   
+   Developer
+   
+   -6
 
 
 




[jira] Closed: (TAP5-492) Unable to deploy Tapestry 5 Web application in Weblogic 9.2

2009-02-18 Thread Howard M. Lewis Ship (JIRA)

 [ 
https://issues.apache.org/jira/browse/TAP5-492?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Howard M. Lewis Ship closed TAP5-492.
-

Resolution: Invalid

> Unable to deploy Tapestry 5 Web application in Weblogic 9.2
> ---
>
> Key: TAP5-492
> URL: https://issues.apache.org/jira/browse/TAP5-492
> Project: Tapestry 5
>  Issue Type: Question
>Affects Versions: 5.0.18
>Reporter: Sukrish
>
> Hello, When I try to deploy my Tapestry 5 application in Weblogic 9.2, I get 
> the following error
> ---
> An error occurred during activation of changes, please see the log for 
> details.  
>   [HTTP:101064][WebAppModule(myapp:eClaimsWW)] Error parsing descriptor in 
> Web appplication "C:\Tap5\my-app\target\eClaimsWW" 
> weblogic.application.ModuleException: Unmarshaller failed at 
> weblogic.servlet.internal.WebAppModule.loadDescriptor(WebAppModule.java:781) 
> at weblogic.servlet.internal.WebAppModule.prepare(WebAppModule.java:272) at 
> weblogic.application.internal.flow.ScopedModuleDriver.prepare(ScopedModuleDriver.java:176)
>  at 
> weblogic.application.internal.flow.ModuleListenerInvoker.prepare(ModuleListenerInvoker.java:93)
>  at 
> weblogic.application.internal.flow.DeploymentCallbackFlow$1.next(DeploymentCallbackFlow.java:360)
>  at 
> weblogic.application.utils.StateMachineDriver.nextState(StateMachineDriver.java:26)
>  at 
> weblogic.application.internal.flow.DeploymentCallbackFlow.prepare(DeploymentCallbackFlow.java:56)
>  at 
> weblogic.application.internal.flow.DeploymentCallbackFlow.prepare(DeploymentCallbackFlow.java:46)
>  at 
> weblogic.application.internal.BaseDeployment$1.next(BaseDeployment.java:615) 
> at 
> weblogic.application.utils.StateMachineDriver.nextState(StateMachineDriver.java:26)
>  at 
> weblogic.application.internal.BaseDeployment.prepare(BaseDeployment.java:191) 
> at 
> weblogic.application.internal.DeploymentStateChecker.prepare(DeploymentStateChecker.java:147)
>  at 
> weblogic.deploy.internal.targetserver.AppContainerInvoker.prepare(AppContainerInvoker.java:61)
>  at 
> weblogic.deploy.internal.targetserver.operations.ActivateOperation.createAndPrepareContainer(ActivateOperation.java:189)
>  at 
> weblogic.deploy.internal.targetserver.operations.ActivateOperation.doPrepare(ActivateOperation.java:87)
>  at 
> weblogic.deploy.internal.targetserver.operations.AbstractOperation.prepare(AbstractOperation.java:217)
>  at 
> weblogic.deploy.internal.targetserver.DeploymentManager.handleDeploymentPrepare(DeploymentManager.java:718)
>  at 
> weblogic.deploy.internal.targetserver.DeploymentManager.prepareDeploymentList(DeploymentManager.java:1185)
>  at 
> weblogic.deploy.internal.targetserver.DeploymentManager.handlePrepare(DeploymentManager.java:247)
>  at 
> weblogic.deploy.internal.targetserver.DeploymentServiceDispatcher.prepare(DeploymentServiceDispatcher.java:157)
>  at 
> weblogic.deploy.service.internal.targetserver.DeploymentReceiverCallbackDeliverer.doPrepareCallback(DeploymentReceiverCallbackDeliverer.java:157)
>  at 
> weblogic.deploy.service.internal.targetserver.DeploymentReceiverCallbackDeliverer.access$000(DeploymentReceiverCallbackDeliverer.java:12)
>  at 
> weblogic.deploy.service.internal.targetserver.DeploymentReceiverCallbackDeliverer$1.run(DeploymentReceiverCallbackDeliverer.java:45)
>  at 
> weblogic.work.ServerWorkManagerImpl$WorkAdapterImpl.run(ServerWorkManagerImpl.java:518)
>  at weblogic.work.ExecuteThread.execute(ExecuteThread.java:209) at 
> weblogic.work.ExecuteThread.run(ExecuteThread.java:181) Caused by: 
> weblogic.descriptor.BeanAlreadyExistsException: Bean already exists: 
> "weblogic.j2ee.descriptor.filterbeani...@6908ff(/Filters[app])" at 
> weblogic.descriptor.internal.ReferenceManager.registerBean(ReferenceManager.java:207)
>  at 
> weblogic.j2ee.descriptor.WebAppBeanImpl.setFilters(WebAppBeanImpl.java:703) 
> at 
> jrockit.reflect.VirtualNativeMethodInvoker.invoke(Ljava.lang.Object;[Ljava.lang.Object;)Ljava.lang.Object;(Unknown
>  Source) at 
> java.lang.reflect.Method.invoke(Ljava.lang.Object;[Ljava.lang.Object;I)Ljava.lang.Object;(Unknown
>  Source) at 
> com.bea.staxb.runtime.internal.util.ReflectionUtils.invokeMethod(ReflectionUtils.java:48)
>  at 
> com.bea.staxb.runtime.internal.RuntimeBindingType$BeanRuntimeProperty.setValue(RuntimeBindingType.java:483)
>  at 
> com.bea.staxb.runtime.internal.AttributeRuntimeBindingType$QNameRuntimeProperty.fillCollection(AttributeRuntimeBindingType.java:385)
>  at 
> com.bea.staxb.runtime.internal.MultiIntermediary.getFinalValue(MultiIntermediary.java:52)
>  at 
> com.bea.staxb.runtime.internal.AttributeRuntimeBindingType.getFinalObjectFromIntermediary(AttributeRuntimeBindingType.java:145)
>  at 
> com.bea.staxb.runtime.internal.UnmarshalResult.unmarshalBindingType(UnmarshalResult.java:185)
>  at 
> com.be

[jira] Reopened: (TAP5-492) Unable to deploy Tapestry 5 Web application in Weblogic 9.2

2009-02-18 Thread Howard M. Lewis Ship (JIRA)

 [ 
https://issues.apache.org/jira/browse/TAP5-492?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Howard M. Lewis Ship reopened TAP5-492:
---


> Unable to deploy Tapestry 5 Web application in Weblogic 9.2
> ---
>
> Key: TAP5-492
> URL: https://issues.apache.org/jira/browse/TAP5-492
> Project: Tapestry 5
>  Issue Type: Question
>Affects Versions: 5.0.18
>Reporter: Sukrish
>
> Hello, When I try to deploy my Tapestry 5 application in Weblogic 9.2, I get 
> the following error
> ---
> An error occurred during activation of changes, please see the log for 
> details.  
>   [HTTP:101064][WebAppModule(myapp:eClaimsWW)] Error parsing descriptor in 
> Web appplication "C:\Tap5\my-app\target\eClaimsWW" 
> weblogic.application.ModuleException: Unmarshaller failed at 
> weblogic.servlet.internal.WebAppModule.loadDescriptor(WebAppModule.java:781) 
> at weblogic.servlet.internal.WebAppModule.prepare(WebAppModule.java:272) at 
> weblogic.application.internal.flow.ScopedModuleDriver.prepare(ScopedModuleDriver.java:176)
>  at 
> weblogic.application.internal.flow.ModuleListenerInvoker.prepare(ModuleListenerInvoker.java:93)
>  at 
> weblogic.application.internal.flow.DeploymentCallbackFlow$1.next(DeploymentCallbackFlow.java:360)
>  at 
> weblogic.application.utils.StateMachineDriver.nextState(StateMachineDriver.java:26)
>  at 
> weblogic.application.internal.flow.DeploymentCallbackFlow.prepare(DeploymentCallbackFlow.java:56)
>  at 
> weblogic.application.internal.flow.DeploymentCallbackFlow.prepare(DeploymentCallbackFlow.java:46)
>  at 
> weblogic.application.internal.BaseDeployment$1.next(BaseDeployment.java:615) 
> at 
> weblogic.application.utils.StateMachineDriver.nextState(StateMachineDriver.java:26)
>  at 
> weblogic.application.internal.BaseDeployment.prepare(BaseDeployment.java:191) 
> at 
> weblogic.application.internal.DeploymentStateChecker.prepare(DeploymentStateChecker.java:147)
>  at 
> weblogic.deploy.internal.targetserver.AppContainerInvoker.prepare(AppContainerInvoker.java:61)
>  at 
> weblogic.deploy.internal.targetserver.operations.ActivateOperation.createAndPrepareContainer(ActivateOperation.java:189)
>  at 
> weblogic.deploy.internal.targetserver.operations.ActivateOperation.doPrepare(ActivateOperation.java:87)
>  at 
> weblogic.deploy.internal.targetserver.operations.AbstractOperation.prepare(AbstractOperation.java:217)
>  at 
> weblogic.deploy.internal.targetserver.DeploymentManager.handleDeploymentPrepare(DeploymentManager.java:718)
>  at 
> weblogic.deploy.internal.targetserver.DeploymentManager.prepareDeploymentList(DeploymentManager.java:1185)
>  at 
> weblogic.deploy.internal.targetserver.DeploymentManager.handlePrepare(DeploymentManager.java:247)
>  at 
> weblogic.deploy.internal.targetserver.DeploymentServiceDispatcher.prepare(DeploymentServiceDispatcher.java:157)
>  at 
> weblogic.deploy.service.internal.targetserver.DeploymentReceiverCallbackDeliverer.doPrepareCallback(DeploymentReceiverCallbackDeliverer.java:157)
>  at 
> weblogic.deploy.service.internal.targetserver.DeploymentReceiverCallbackDeliverer.access$000(DeploymentReceiverCallbackDeliverer.java:12)
>  at 
> weblogic.deploy.service.internal.targetserver.DeploymentReceiverCallbackDeliverer$1.run(DeploymentReceiverCallbackDeliverer.java:45)
>  at 
> weblogic.work.ServerWorkManagerImpl$WorkAdapterImpl.run(ServerWorkManagerImpl.java:518)
>  at weblogic.work.ExecuteThread.execute(ExecuteThread.java:209) at 
> weblogic.work.ExecuteThread.run(ExecuteThread.java:181) Caused by: 
> weblogic.descriptor.BeanAlreadyExistsException: Bean already exists: 
> "weblogic.j2ee.descriptor.filterbeani...@6908ff(/Filters[app])" at 
> weblogic.descriptor.internal.ReferenceManager.registerBean(ReferenceManager.java:207)
>  at 
> weblogic.j2ee.descriptor.WebAppBeanImpl.setFilters(WebAppBeanImpl.java:703) 
> at 
> jrockit.reflect.VirtualNativeMethodInvoker.invoke(Ljava.lang.Object;[Ljava.lang.Object;)Ljava.lang.Object;(Unknown
>  Source) at 
> java.lang.reflect.Method.invoke(Ljava.lang.Object;[Ljava.lang.Object;I)Ljava.lang.Object;(Unknown
>  Source) at 
> com.bea.staxb.runtime.internal.util.ReflectionUtils.invokeMethod(ReflectionUtils.java:48)
>  at 
> com.bea.staxb.runtime.internal.RuntimeBindingType$BeanRuntimeProperty.setValue(RuntimeBindingType.java:483)
>  at 
> com.bea.staxb.runtime.internal.AttributeRuntimeBindingType$QNameRuntimeProperty.fillCollection(AttributeRuntimeBindingType.java:385)
>  at 
> com.bea.staxb.runtime.internal.MultiIntermediary.getFinalValue(MultiIntermediary.java:52)
>  at 
> com.bea.staxb.runtime.internal.AttributeRuntimeBindingType.getFinalObjectFromIntermediary(AttributeRuntimeBindingType.java:145)
>  at 
> com.bea.staxb.runtime.internal.UnmarshalResult.unmarshalBindingType(UnmarshalResult.java:185)
>  at 
> com.bea.staxb.runtime.inte