[jira] Updated: (TAP5-663) Error with passing false in property expressions
[
https://issues.apache.org/jira/browse/TAP5-663?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andy Blower updated TAP5-663:
-
Affects Version/s: 5.1.0.4
Error with passing false in property expressions
Key: TAP5-663
URL: https://issues.apache.org/jira/browse/TAP5-663
Project: Tapestry 5
Issue Type: Bug
Components: tapestry-core
Affects Versions: 5.1.0.3, 5.1.0.4
Reporter: Andy Blower
Priority: Minor
I just tried out the new T5.1 property expressions for the first time and got
an error. I'm trying to replace this:
${linkTitle}
public String getLinkTitle() {
return getTitle(false);
}
With this:
${getTitle(false)}
Which I should be able to do according to the Grammar as far as I can see,
since but I get this error when I try it:
Caused by:
org.apache.tapestry5.internal.services.PropertyExpressionException: Node
false (within expression 'getTitle(false)') was type FALSE, but was expected
to be (one of) DECIMAL, DEREF, IDENTIFIER, INTEGER, INVOKE, LIST, SAFEDEREF,
STRING.
at
org.apache.tapestry5.internal.services.PropertyConduitSourceImpl$PropertyConduitBuilder.unexpectedNodeType(PropertyConduitSourceImpl.java:925)
at
org.apache.tapestry5.internal.services.PropertyConduitSourceImpl$PropertyConduitBuilder.subexpression(PropertyConduitSourceImpl.java:637)
at
org.apache.tapestry5.internal.services.PropertyConduitSourceImpl$PropertyConduitBuilder.createMethodInvocation(PropertyConduitSourceImpl.java:756)
at
org.apache.tapestry5.internal.services.PropertyConduitSourceImpl$PropertyConduitBuilder.createMethodInvocation(PropertyConduitSourceImpl.java:730)
at
org.apache.tapestry5.internal.services.PropertyConduitSourceImpl$PropertyConduitBuilder.createGetter(PropertyConduitSourceImpl.java:711)
at
org.apache.tapestry5.internal.services.PropertyConduitSourceImpl$PropertyConduitBuilder.createGetterAndSetter(PropertyConduitSourceImpl.java:436)
at
org.apache.tapestry5.internal.services.PropertyConduitSourceImpl$PropertyConduitBuilder.createAccessors(PropertyConduitSourceImpl.java:419)
at
org.apache.tapestry5.internal.services.PropertyConduitSourceImpl$PropertyConduitBuilder.createInstance(PropertyConduitSourceImpl.java:272)
at
org.apache.tapestry5.internal.services.PropertyConduitSourceImpl.build(PropertyConduitSourceImpl.java:1206)
at
org.apache.tapestry5.internal.services.PropertyConduitSourceImpl.create(PropertyConduitSourceImpl.java:1081)
at
$PropertyConduitSource_120d3f0182d.create($PropertyConduitSource_120d3f0182d.java)
at
org.apache.tapestry5.internal.bindings.PropBindingFactory.newBinding(PropBindingFactory.java:49)
at
$BindingFactory_120d3f0182e.newBinding($BindingFactory_120d3f0182e.java)
at
$BindingFactory_120d3f01826.newBinding($BindingFactory_120d3f01826.java)
at
org.apache.tapestry5.internal.services.BindingSourceImpl.newBinding(BindingSourceImpl.java:81)
... 107 more
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Created: (TAP5-665) IE 6 on a tapestry SSL page complains about non-secure items (caused by blackbird js-logging component)
IE 6 on a tapestry SSL page complains about non-secure items (caused by
blackbird js-logging component)
---
Key: TAP5-665
URL: https://issues.apache.org/jira/browse/TAP5-665
Project: Tapestry 5
Issue Type: Bug
Components: tapestry-core
Affects Versions: 5.1.0.4, 5.1.0.3
Reporter: Felix Gonschorek
Priority: Minor
What steps will reproduce the problem?
1. Use Internetexplorer 6
2. Use a fixed CSS page layout without body background-image
3. Upload your webapp to an SSL secured Webspace
What is the expected output? What do you see instead?
I expect the site to load without problems. Instead, on every pageload i
get a warning, that the SSL-secured site contains insecure items.
I figured out, that blackbird is causing this behaviour. If i remove the
blackbird code in the /assets/virtual/XX==.js file, everything is okay. I
assume, that this lines of code ar causing the message:
snip
function backgroundImage()
{
//(IE6 only) change BODY tag's background to resolve
// {position:fixed} support
var bodyTag = $(document.body);
if (bodyTag.currentStyle IE6_POSITION_FIXED)
{
if (bodyTag.currentStyle.backgroundImage == 'none')
{
bodyTag.style.backgroundImage = 'url(about:blank)';
}
if (bodyTag.currentStyle.backgroundAttachment == 'scroll')
{
bodyTag.style.backgroundAttachment = 'fixed';
}
}
}
/snip
I believe, that the background Image 'about:blank' is treated as non-secured
content.
I could fix this, with using a space gif in my css layout as body
background-image
I filed a bug at the googlecode blackbird project site:
http://code.google.com/p/blackbirdjs/issues/detail?id=20
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (TAP5-665) IE 6 on a tapestry SSL page complains about non-secure items (caused by blackbird js-logging component)
[
https://issues.apache.org/jira/browse/TAP5-665?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Felix Gonschorek updated TAP5-665:
--
Attachment: ssl-warning.jpeg
IE 6 on a tapestry SSL page complains about non-secure items (caused by
blackbird js-logging component)
---
Key: TAP5-665
URL: https://issues.apache.org/jira/browse/TAP5-665
Project: Tapestry 5
Issue Type: Bug
Components: tapestry-core
Affects Versions: 5.1.0.3, 5.1.0.4
Reporter: Felix Gonschorek
Priority: Minor
Attachments: ssl-warning.jpeg
What steps will reproduce the problem?
1. Use Internetexplorer 6
2. Use a fixed CSS page layout without body background-image
3. Upload your webapp to an SSL secured Webspace
What is the expected output? What do you see instead?
I expect the site to load without problems. Instead, on every pageload i
get a warning, that the SSL-secured site contains insecure items.
I figured out, that blackbird is causing this behaviour. If i remove the
blackbird code in the /assets/virtual/XX==.js file, everything is okay. I
assume, that this lines of code ar causing the message:
snip
function backgroundImage()
{
//(IE6 only) change BODY tag's background to resolve
// {position:fixed} support
var bodyTag = $(document.body);
if (bodyTag.currentStyle IE6_POSITION_FIXED)
{
if (bodyTag.currentStyle.backgroundImage == 'none')
{
bodyTag.style.backgroundImage = 'url(about:blank)';
}
if (bodyTag.currentStyle.backgroundAttachment == 'scroll')
{
bodyTag.style.backgroundAttachment = 'fixed';
}
}
}
/snip
I believe, that the background Image 'about:blank' is treated as non-secured
content.
I could fix this, with using a space gif in my css layout as body
background-image
I filed a bug at the googlecode blackbird project site:
http://code.google.com/p/blackbirdjs/issues/detail?id=20
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (TAP5-573) NullPointerException during AJAX form submit
[ https://issues.apache.org/jira/browse/TAP5-573?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12703127#action_12703127 ] Alfie Kirkpatrick commented on TAP5-573: I am also seeing this error when returning a block from an event handler but only when my block contains nested elements. If it contains plain text it works fine. NullPointerException during AJAX form submit Key: TAP5-573 URL: https://issues.apache.org/jira/browse/TAP5-573 Project: Tapestry 5 Issue Type: Bug Components: tapestry-core Affects Versions: 5.1.0.1 Reporter: Thiago H. de Paula Figueiredo Assignee: Howard M. Lewis Ship Priority: Critical Fix For: 5.1.0.2 To reproduce this bug: * Checkout the Ars Machina Example Project from SVN: https://ars-machina.svn.sourceforge.net/svnroot/ars-machina/example/branches/1.1 * Run its Main class (default package) * Click in the login link * Login as manager (login) manager (password) * Click in the project listings link * Click in one of the edition links (the second icon) * Click the submit button. Relevant part of the stack trace: java.lang.NullPointerException at org.apache.tapestry5.dom.Element.createNamespaceURIToPrefix(Element.java:676) at org.apache.tapestry5.dom.Element.toMarkup(Element.java:333) at org.apache.tapestry5.dom.Element.writeChildMarkup(Element.java:870) at org.apache.tapestry5.dom.Element.toMarkup(Element.java:386) at org.apache.tapestry5.dom.Element.writeChildMarkup(Element.java:870) at org.apache.tapestry5.dom.Element.toMarkup(Element.java:386) at org.apache.tapestry5.dom.Element.writeChildMarkup(Element.java:870) at org.apache.tapestry5.dom.Element.getChildMarkup(Element.java:883) at org.apache.tapestry5.internal.services.PageRenderQueueImpl.renderPartial(PageRenderQueueImpl.java:163) -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Assigned: (TAP5-665) IE 6 on a tapestry SSL page complains about non-secure items (caused by blackbird js-logging component)
[
https://issues.apache.org/jira/browse/TAP5-665?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Howard M. Lewis Ship reassigned TAP5-665:
-
Assignee: Howard M. Lewis Ship
IE 6 on a tapestry SSL page complains about non-secure items (caused by
blackbird js-logging component)
---
Key: TAP5-665
URL: https://issues.apache.org/jira/browse/TAP5-665
Project: Tapestry 5
Issue Type: Bug
Components: tapestry-core
Affects Versions: 5.1.0.3, 5.1.0.4
Reporter: Felix Gonschorek
Assignee: Howard M. Lewis Ship
Priority: Minor
Attachments: ssl-warning.jpeg
What steps will reproduce the problem?
1. Use Internetexplorer 6
2. Use a fixed CSS page layout without body background-image
3. Upload your webapp to an SSL secured Webspace
What is the expected output? What do you see instead?
I expect the site to load without problems. Instead, on every pageload i
get a warning, that the SSL-secured site contains insecure items.
I figured out, that blackbird is causing this behaviour. If i remove the
blackbird code in the /assets/virtual/XX==.js file, everything is okay. I
assume, that this lines of code ar causing the message:
snip
function backgroundImage()
{
//(IE6 only) change BODY tag's background to resolve
// {position:fixed} support
var bodyTag = $(document.body);
if (bodyTag.currentStyle IE6_POSITION_FIXED)
{
if (bodyTag.currentStyle.backgroundImage == 'none')
{
bodyTag.style.backgroundImage = 'url(about:blank)';
}
if (bodyTag.currentStyle.backgroundAttachment == 'scroll')
{
bodyTag.style.backgroundAttachment = 'fixed';
}
}
}
/snip
I believe, that the background Image 'about:blank' is treated as non-secured
content.
I could fix this, with using a space gif in my css layout as body
background-image
I filed a bug at the googlecode blackbird project site:
http://code.google.com/p/blackbirdjs/issues/detail?id=20
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
svn commit: r769037 - in /tapestry/tapestry5/trunk: ./ quickstart/ quickstart/src/main/resources/archetype-resources/ tapestry-annotations/ tapestry-component-report/ tapestry-core/ tapestry-core/src/
Author: hlship Date: Mon Apr 27 16:00:00 2009 New Revision: 769037 URL: http://svn.apache.org/viewvc?rev=769037view=rev Log: TAP5-665: IE 6 on a tapestry SSL page complains about non-secure items (caused by blackbird js-logging component) Added: tapestry/tapestry5/trunk/tapestry-core/src/main/resources/org/apache/tapestry5/blackbird_1_0/spacer.gif - copied unchanged from r767954, tapestry/tapestry5/trunk/tapestry-core/src/main/resources/org/apache/tapestry5/spacer.gif Modified: tapestry/tapestry5/trunk/pom.xml tapestry/tapestry5/trunk/quickstart/pom.xml tapestry/tapestry5/trunk/quickstart/src/main/resources/archetype-resources/pom.xml tapestry/tapestry5/trunk/tapestry-annotations/pom.xml tapestry/tapestry5/trunk/tapestry-component-report/pom.xml tapestry/tapestry5/trunk/tapestry-core/pom.xml tapestry/tapestry5/trunk/tapestry-core/src/main/resources/org/apache/tapestry5/blackbird_1_0/blackbird.css tapestry/tapestry5/trunk/tapestry-core/src/main/resources/org/apache/tapestry5/blackbird_1_0/blackbird.js tapestry/tapestry5/trunk/tapestry-hibernate-core/pom.xml tapestry/tapestry5/trunk/tapestry-hibernate/pom.xml tapestry/tapestry5/trunk/tapestry-ioc/pom.xml tapestry/tapestry5/trunk/tapestry-spring/pom.xml tapestry/tapestry5/trunk/tapestry-test/pom.xml tapestry/tapestry5/trunk/tapestry-tutorial1/pom.xml tapestry/tapestry5/trunk/tapestry-upload/pom.xml Modified: tapestry/tapestry5/trunk/pom.xml URL: http://svn.apache.org/viewvc/tapestry/tapestry5/trunk/pom.xml?rev=769037r1=769036r2=769037view=diff == --- tapestry/tapestry5/trunk/pom.xml (original) +++ tapestry/tapestry5/trunk/pom.xml Mon Apr 27 16:00:00 2009 @@ -4,7 +4,7 @@ groupIdorg.apache.tapestry/groupId artifactIdtapestry-project/artifactId packagingpom/packaging -version5.1.0.4/version +version5.1.0.5-SNAPSHOT/version nameTapestry 5 Project/name descriptionMaster project for the modules of Tapestry 5./description inceptionYear2006/inceptionYear Modified: tapestry/tapestry5/trunk/quickstart/pom.xml URL: http://svn.apache.org/viewvc/tapestry/tapestry5/trunk/quickstart/pom.xml?rev=769037r1=769036r2=769037view=diff == --- tapestry/tapestry5/trunk/quickstart/pom.xml (original) +++ tapestry/tapestry5/trunk/quickstart/pom.xml Mon Apr 27 16:00:00 2009 @@ -14,7 +14,7 @@ parent groupIdorg.apache.tapestry/groupId artifactIdtapestry-project/artifactId -version5.1.0.4/version +version5.1.0.5-SNAPSHOT/version /parent nameTapestry 5 Quickstart Archetype/name inceptionYear2007/inceptionYear Modified: tapestry/tapestry5/trunk/quickstart/src/main/resources/archetype-resources/pom.xml URL: http://svn.apache.org/viewvc/tapestry/tapestry5/trunk/quickstart/src/main/resources/archetype-resources/pom.xml?rev=769037r1=769036r2=769037view=diff == --- tapestry/tapestry5/trunk/quickstart/src/main/resources/archetype-resources/pom.xml (original) +++ tapestry/tapestry5/trunk/quickstart/src/main/resources/archetype-resources/pom.xml Mon Apr 27 16:00:00 2009 @@ -135,6 +135,6 @@ /pluginRepositories properties -tapestry-release-version5.1.0.4/tapestry-release-version +tapestry-release-version5.1.0.5-SNAPSHOT/tapestry-release-version /properties /project Modified: tapestry/tapestry5/trunk/tapestry-annotations/pom.xml URL: http://svn.apache.org/viewvc/tapestry/tapestry5/trunk/tapestry-annotations/pom.xml?rev=769037r1=769036r2=769037view=diff == --- tapestry/tapestry5/trunk/tapestry-annotations/pom.xml (original) +++ tapestry/tapestry5/trunk/tapestry-annotations/pom.xml Mon Apr 27 16:00:00 2009 @@ -9,7 +9,7 @@ parent groupIdorg.apache.tapestry/groupId artifactIdtapestry-project/artifactId -version5.1.0.4/version +version5.1.0.5-SNAPSHOT/version /parent nameTapestry Annotations/name description Modified: tapestry/tapestry5/trunk/tapestry-component-report/pom.xml URL: http://svn.apache.org/viewvc/tapestry/tapestry5/trunk/tapestry-component-report/pom.xml?rev=769037r1=769036r2=769037view=diff == --- tapestry/tapestry5/trunk/tapestry-component-report/pom.xml (original) +++ tapestry/tapestry5/trunk/tapestry-component-report/pom.xml Mon Apr 27 16:00:00 2009 @@ -12,7 +12,7 @@ parent groupIdorg.apache.tapestry/groupId artifactIdtapestry-project/artifactId -version5.1.0.4/version +version5.1.0.5-SNAPSHOT/version /parent inceptionYear2007/inceptionYear Modified: tapestry/tapestry5/trunk/tapestry-core/pom.xml
[jira] Closed: (TAP5-665) IE 6 on a tapestry SSL page complains about non-secure items (caused by blackbird js-logging component)
[
https://issues.apache.org/jira/browse/TAP5-665?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Howard M. Lewis Ship closed TAP5-665.
-
Resolution: Fixed
Fix Version/s: 5.1.0.5
IE 6 on a tapestry SSL page complains about non-secure items (caused by
blackbird js-logging component)
---
Key: TAP5-665
URL: https://issues.apache.org/jira/browse/TAP5-665
Project: Tapestry 5
Issue Type: Bug
Components: tapestry-core
Affects Versions: 5.1.0.3, 5.1.0.4
Reporter: Felix Gonschorek
Assignee: Howard M. Lewis Ship
Priority: Minor
Fix For: 5.1.0.5
Attachments: ssl-warning.jpeg
What steps will reproduce the problem?
1. Use Internetexplorer 6
2. Use a fixed CSS page layout without body background-image
3. Upload your webapp to an SSL secured Webspace
What is the expected output? What do you see instead?
I expect the site to load without problems. Instead, on every pageload i
get a warning, that the SSL-secured site contains insecure items.
I figured out, that blackbird is causing this behaviour. If i remove the
blackbird code in the /assets/virtual/XX==.js file, everything is okay. I
assume, that this lines of code ar causing the message:
snip
function backgroundImage()
{
//(IE6 only) change BODY tag's background to resolve
// {position:fixed} support
var bodyTag = $(document.body);
if (bodyTag.currentStyle IE6_POSITION_FIXED)
{
if (bodyTag.currentStyle.backgroundImage == 'none')
{
bodyTag.style.backgroundImage = 'url(about:blank)';
}
if (bodyTag.currentStyle.backgroundAttachment == 'scroll')
{
bodyTag.style.backgroundAttachment = 'fixed';
}
}
}
/snip
I believe, that the background Image 'about:blank' is treated as non-secured
content.
I could fix this, with using a space gif in my css layout as body
background-image
I filed a bug at the googlecode blackbird project site:
http://code.google.com/p/blackbirdjs/issues/detail?id=20
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
svn commit: r769045 - /tapestry/tapestry5/trunk/src/site/apt/guide/templates.apt
Author: hlship Date: Mon Apr 27 16:16:03 2009 New Revision: 769045 URL: http://svn.apache.org/viewvc?rev=769045view=rev Log: TAP5-664: Incorrect legacy URI specified in the templates documentation Modified: tapestry/tapestry5/trunk/src/site/apt/guide/templates.apt Modified: tapestry/tapestry5/trunk/src/site/apt/guide/templates.apt URL: http://svn.apache.org/viewvc/tapestry/tapestry5/trunk/src/site/apt/guide/templates.apt?rev=769045r1=769044r2=769045view=diff == --- tapestry/tapestry5/trunk/src/site/apt/guide/templates.apt (original) +++ tapestry/tapestry5/trunk/src/site/apt/guide/templates.apt Mon Apr 27 16:16:03 2009 @@ -105,7 +105,7 @@ prefix. For backwards compatibility, you may continue to use the old namespace URI: - http://tapestry.apache.org/schema/tapestry_5_1_0.xsd. However, + http://tapestry.apache.org/schema/tapestry_5_0_0.xsd. However, the following elements added, as part of Tapestry 5.1, will not work: * \t:remove\
[jira] Created: (TAP5-666) Property expression can not pass a boolean value to a method
Property expression can not pass a boolean value to a method
Key: TAP5-666
URL: https://issues.apache.org/jira/browse/TAP5-666
Project: Tapestry 5
Issue Type: Bug
Components: tapestry-core
Affects Versions: 5.1.0.4
Reporter: Howard M. Lewis Ship
From the mailing list:
I just tried out the new T5.1 property expressions for the first time and got
an error. I'm trying to replace this:
${linkTitle}
public String getLinkTitle() {
return getTitle(false);
}
With this:
${getTitle(false)}
Which I should be able to do according to the Grammar as far as I can see,
since but I get this error when I try it:
Caused by:
org.apache.tapestry5.internal.services.PropertyExpressionException: Node
false (within expression 'getTitle(false)') was type FALSE, but was expected
to be (one of) DECIMAL, DEREF, IDENTIFIER, INTEGER, INVOKE, LIST, SAFEDEREF,
STRING.
at
org.apache.tapestry5.internal.services.PropertyConduitSourceImpl$PropertyConduitBuilder.unexpectedNodeType(PropertyConduitSourceImpl.java:925)
at
org.apache.tapestry5.internal.services.PropertyConduitSourceImpl$PropertyConduitBuilder.subexpression(PropertyConduitSourceImpl.java:637)
at
org.apache.tapestry5.internal.services.PropertyConduitSourceImpl$PropertyConduitBuilder.createMethodInvocation(PropertyConduitSourceImpl.java:756)
at
org.apache.tapestry5.internal.services.PropertyConduitSourceImpl$PropertyConduitBuilder.createMethodInvocation(PropertyConduitSourceImpl.java:730)
at
org.apache.tapestry5.internal.services.PropertyConduitSourceImpl$PropertyConduitBuilder.createGetter(PropertyConduitSourceImpl.java:711)
at
org.apache.tapestry5.internal.services.PropertyConduitSourceImpl$PropertyConduitBuilder.createGetterAndSetter(PropertyConduitSourceImpl.java:436)
at
org.apache.tapestry5.internal.services.PropertyConduitSourceImpl$PropertyConduitBuilder.createAccessors(PropertyConduitSourceImpl.java:419)
at
org.apache.tapestry5.internal.services.PropertyConduitSourceImpl$PropertyConduitBuilder.createInstance(PropertyConduitSourceImpl.java:272)
at
org.apache.tapestry5.internal.services.PropertyConduitSourceImpl.build(PropertyConduitSourceImpl.java:1206)
at
org.apache.tapestry5.internal.services.PropertyConduitSourceImpl.create(PropertyConduitSourceImpl.java:1081)
at
$PropertyConduitSource_120d3f0182d.create($PropertyConduitSource_120d3f0182d.java)
at
org.apache.tapestry5.internal.bindings.PropBindingFactory.newBinding(PropBindingFactory.java:49)
at
$BindingFactory_120d3f0182e.newBinding($BindingFactory_120d3f0182e.java)
at
$BindingFactory_120d3f01826.newBinding($BindingFactory_120d3f01826.java)
at
org.apache.tapestry5.internal.services.BindingSourceImpl.newBinding(BindingSourceImpl.java:81)
... 107 more
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (TAP5-666) Property expression can not pass a boolean constant into a method
[
https://issues.apache.org/jira/browse/TAP5-666?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Howard M. Lewis Ship updated TAP5-666:
--
Summary: Property expression can not pass a boolean constant into a method
(was: Property expression can not pass a boolean value to a method)
It looks like the grammar for top-level expressions (i.e., arguments to
methods) doesn't include boolean.
Property expression can not pass a boolean constant into a method
-
Key: TAP5-666
URL: https://issues.apache.org/jira/browse/TAP5-666
Project: Tapestry 5
Issue Type: Bug
Components: tapestry-core
Affects Versions: 5.1.0.4
Reporter: Howard M. Lewis Ship
Assignee: Howard M. Lewis Ship
From the mailing list:
I just tried out the new T5.1 property expressions for the first time and got
an error. I'm trying to replace this:
${linkTitle}
public String getLinkTitle() {
return getTitle(false);
}
With this:
${getTitle(false)}
Which I should be able to do according to the Grammar as far as I can see,
since but I get this error when I try it:
Caused by:
org.apache.tapestry5.internal.services.PropertyExpressionException: Node
false (within expression 'getTitle(false)') was type FALSE, but was expected
to be (one of) DECIMAL, DEREF, IDENTIFIER, INTEGER, INVOKE, LIST, SAFEDEREF,
STRING.
at
org.apache.tapestry5.internal.services.PropertyConduitSourceImpl$PropertyConduitBuilder.unexpectedNodeType(PropertyConduitSourceImpl.java:925)
at
org.apache.tapestry5.internal.services.PropertyConduitSourceImpl$PropertyConduitBuilder.subexpression(PropertyConduitSourceImpl.java:637)
at
org.apache.tapestry5.internal.services.PropertyConduitSourceImpl$PropertyConduitBuilder.createMethodInvocation(PropertyConduitSourceImpl.java:756)
at
org.apache.tapestry5.internal.services.PropertyConduitSourceImpl$PropertyConduitBuilder.createMethodInvocation(PropertyConduitSourceImpl.java:730)
at
org.apache.tapestry5.internal.services.PropertyConduitSourceImpl$PropertyConduitBuilder.createGetter(PropertyConduitSourceImpl.java:711)
at
org.apache.tapestry5.internal.services.PropertyConduitSourceImpl$PropertyConduitBuilder.createGetterAndSetter(PropertyConduitSourceImpl.java:436)
at
org.apache.tapestry5.internal.services.PropertyConduitSourceImpl$PropertyConduitBuilder.createAccessors(PropertyConduitSourceImpl.java:419)
at
org.apache.tapestry5.internal.services.PropertyConduitSourceImpl$PropertyConduitBuilder.createInstance(PropertyConduitSourceImpl.java:272)
at
org.apache.tapestry5.internal.services.PropertyConduitSourceImpl.build(PropertyConduitSourceImpl.java:1206)
at
org.apache.tapestry5.internal.services.PropertyConduitSourceImpl.create(PropertyConduitSourceImpl.java:1081)
at
$PropertyConduitSource_120d3f0182d.create($PropertyConduitSource_120d3f0182d.java)
at
org.apache.tapestry5.internal.bindings.PropBindingFactory.newBinding(PropBindingFactory.java:49)
at
$BindingFactory_120d3f0182e.newBinding($BindingFactory_120d3f0182e.java)
at
$BindingFactory_120d3f01826.newBinding($BindingFactory_120d3f01826.java)
at
org.apache.tapestry5.internal.services.BindingSourceImpl.newBinding(BindingSourceImpl.java:81)
... 107 more
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (TAP5-666) Property expression can not pass a boolean value to a method
[
https://issues.apache.org/jira/browse/TAP5-666?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Howard M. Lewis Ship reassigned TAP5-666:
-
Assignee: Howard M. Lewis Ship
Property expression can not pass a boolean value to a method
Key: TAP5-666
URL: https://issues.apache.org/jira/browse/TAP5-666
Project: Tapestry 5
Issue Type: Bug
Components: tapestry-core
Affects Versions: 5.1.0.4
Reporter: Howard M. Lewis Ship
Assignee: Howard M. Lewis Ship
From the mailing list:
I just tried out the new T5.1 property expressions for the first time and got
an error. I'm trying to replace this:
${linkTitle}
public String getLinkTitle() {
return getTitle(false);
}
With this:
${getTitle(false)}
Which I should be able to do according to the Grammar as far as I can see,
since but I get this error when I try it:
Caused by:
org.apache.tapestry5.internal.services.PropertyExpressionException: Node
false (within expression 'getTitle(false)') was type FALSE, but was expected
to be (one of) DECIMAL, DEREF, IDENTIFIER, INTEGER, INVOKE, LIST, SAFEDEREF,
STRING.
at
org.apache.tapestry5.internal.services.PropertyConduitSourceImpl$PropertyConduitBuilder.unexpectedNodeType(PropertyConduitSourceImpl.java:925)
at
org.apache.tapestry5.internal.services.PropertyConduitSourceImpl$PropertyConduitBuilder.subexpression(PropertyConduitSourceImpl.java:637)
at
org.apache.tapestry5.internal.services.PropertyConduitSourceImpl$PropertyConduitBuilder.createMethodInvocation(PropertyConduitSourceImpl.java:756)
at
org.apache.tapestry5.internal.services.PropertyConduitSourceImpl$PropertyConduitBuilder.createMethodInvocation(PropertyConduitSourceImpl.java:730)
at
org.apache.tapestry5.internal.services.PropertyConduitSourceImpl$PropertyConduitBuilder.createGetter(PropertyConduitSourceImpl.java:711)
at
org.apache.tapestry5.internal.services.PropertyConduitSourceImpl$PropertyConduitBuilder.createGetterAndSetter(PropertyConduitSourceImpl.java:436)
at
org.apache.tapestry5.internal.services.PropertyConduitSourceImpl$PropertyConduitBuilder.createAccessors(PropertyConduitSourceImpl.java:419)
at
org.apache.tapestry5.internal.services.PropertyConduitSourceImpl$PropertyConduitBuilder.createInstance(PropertyConduitSourceImpl.java:272)
at
org.apache.tapestry5.internal.services.PropertyConduitSourceImpl.build(PropertyConduitSourceImpl.java:1206)
at
org.apache.tapestry5.internal.services.PropertyConduitSourceImpl.create(PropertyConduitSourceImpl.java:1081)
at
$PropertyConduitSource_120d3f0182d.create($PropertyConduitSource_120d3f0182d.java)
at
org.apache.tapestry5.internal.bindings.PropBindingFactory.newBinding(PropBindingFactory.java:49)
at
$BindingFactory_120d3f0182e.newBinding($BindingFactory_120d3f0182e.java)
at
$BindingFactory_120d3f01826.newBinding($BindingFactory_120d3f01826.java)
at
org.apache.tapestry5.internal.services.BindingSourceImpl.newBinding(BindingSourceImpl.java:81)
... 107 more
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
svn commit: r769063 - in /tapestry/tapestry5/trunk: src/site/apt/guide/ tapestry-core/src/main/java/org/apache/tapestry5/annotations/ tapestry-core/src/main/java/org/apache/tapestry5/internal/services
Author: hlship
Date: Mon Apr 27 17:26:26 2009
New Revision: 769063
URL: http://svn.apache.org/viewvc?rev=769063view=rev
Log:
TAP5-666: Property expression can not pass a boolean constant into a method
Added:
tapestry/tapestry5/trunk/tapestry-core/src/test/java/org/apache/tapestry5/internal/services/Bedrock.java
(with props)
Modified:
tapestry/tapestry5/trunk/src/site/apt/guide/propexp.apt
tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/annotations/SessionState.java
tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/internal/services/BasePropertyConduit.java
tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/internal/services/PropertyConduitSourceImpl.java
tapestry/tapestry5/trunk/tapestry-core/src/test/java/org/apache/tapestry5/internal/services/PropertyConduitSourceImplTest.java
Modified: tapestry/tapestry5/trunk/src/site/apt/guide/propexp.apt
URL:
http://svn.apache.org/viewvc/tapestry/tapestry5/trunk/src/site/apt/guide/propexp.apt?rev=769063r1=769062r2=769063view=diff
==
--- tapestry/tapestry5/trunk/src/site/apt/guide/propexp.apt (original)
+++ tapestry/tapestry5/trunk/src/site/apt/guide/propexp.apt Mon Apr 27 17:26:26
2009
@@ -49,9 +49,9 @@
---
expression : keyword | rangeOp | constant | propertyChain | list | notOp;
-keyword : 'null' | 'true' | 'false' | 'this';
+keyword : 'null' | 'this';
-constant : integer | decimal | string;
+constant : 'true' | 'false' | integer | decimal | string;
rangeOp : rangeOpArg '..' rangeOpArg;
Modified:
tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/annotations/SessionState.java
URL:
http://svn.apache.org/viewvc/tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/annotations/SessionState.java?rev=769063r1=769062r2=769063view=diff
==
---
tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/annotations/SessionState.java
(original)
+++
tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/annotations/SessionState.java
Mon Apr 27 17:26:26 2009
@@ -1,4 +1,4 @@
-// Copyright 2009 ${ORG}
+// Copyright 2009 The Apache Software Foundation
//
// Licensed under the Apache License, Version 2.0 (the License);
// you may not use this file except in compliance with the License.
Modified:
tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/internal/services/BasePropertyConduit.java
URL:
http://svn.apache.org/viewvc/tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/internal/services/BasePropertyConduit.java?rev=769063r1=769062r2=769063view=diff
==
---
tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/internal/services/BasePropertyConduit.java
(original)
+++
tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/internal/services/BasePropertyConduit.java
Mon Apr 27 17:26:26 2009
@@ -1,4 +1,4 @@
-// Copyright 2007, 2008 The Apache Software Foundation
+// Copyright 2007, 2008, 2009 The Apache Software Foundation
//
// Licensed under the Apache License, Version 2.0 (the License);
// you may not use this file except in compliance with the License.
@@ -76,7 +76,7 @@
return typeCoercer.coerce(value, type);
}
-public final Boolean invert(Object value)
+public final boolean invert(Object value)
{
return coerce(value, Boolean.class).equals(Boolean.FALSE);
}
Modified:
tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/internal/services/PropertyConduitSourceImpl.java
URL:
http://svn.apache.org/viewvc/tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/internal/services/PropertyConduitSourceImpl.java?rev=769063r1=769062r2=769063view=diff
==
---
tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/internal/services/PropertyConduitSourceImpl.java
(original)
+++
tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/internal/services/PropertyConduitSourceImpl.java
Mon Apr 27 17:26:26 2009
@@ -159,31 +159,19 @@
private class GeneratedTerm
{
-private final Class type;
+final Class type;
-private final String variableName;
+final String variableName;
+/**
+ * @param type type of variable
+ * @param variableName name of variable
+ */
private GeneratedTerm(Class type, String variableName)
{
this.type = type;
this.variableName = variableName;
}
-
-/**
- * The name of the variable that contains the evaluation of
svn commit: r769065 - /tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/internal/services/PropertyConduitSourceImpl.java
Author: hlship
Date: Mon Apr 27 17:38:34 2009
New Revision: 769065
URL: http://svn.apache.org/viewvc?rev=769065view=rev
Log:
TAP5-666: Property expression can not pass a boolean constant into a method
Modified:
tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/internal/services/PropertyConduitSourceImpl.java
Modified:
tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/internal/services/PropertyConduitSourceImpl.java
URL:
http://svn.apache.org/viewvc/tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/internal/services/PropertyConduitSourceImpl.java?rev=769065r1=769064r2=769065view=diff
==
---
tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/internal/services/PropertyConduitSourceImpl.java
(original)
+++
tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/internal/services/PropertyConduitSourceImpl.java
Mon Apr 27 17:38:34 2009
@@ -161,16 +161,16 @@
{
final Class type;
-final String variableName;
+final String termReference;
/**
- * @param type type of variable
- * @param variableName name of variable
+ * @param type type of variable
+ * @param termReference name of variable, or a constant value
*/
-private GeneratedTerm(Class type, String variableName)
+private GeneratedTerm(Class type, String termReference)
{
this.type = type;
-this.variableName = variableName;
+this.termReference = termReference;
}
}
@@ -378,24 +378,24 @@
navBuilder.begin();
-String previousVariableName = $1;
+String previousReference = $1;
Class activeType = rootType;
Tree node = tree;
while (!isLeaf(node))
{
-GeneratedTerm term = processDerefNode(navBuilder, activeType,
node, previousVariableName);
+GeneratedTerm term = processDerefNode(navBuilder, activeType,
node, previousReference);
activeType = term.type;
-previousVariableName = term.variableName;
+previousReference = term.termReference;
// Second term is the continuation, possibly another chained
DEREF, etc.
node = node.getChild(1);
}
-navBuilder.addln(return %s;, previousVariableName);
+navBuilder.addln(return %s;, previousReference);
navBuilder.end();
@@ -514,7 +514,7 @@
{
GeneratedTerm generatedTerm = subexpression(builder,
node.getChild(i));
-builder.addln(%s.add(($w) %s);, listName,
generatedTerm.variableName);
+builder.addln(%s.add(($w) %s);, listName,
generatedTerm.termReference);
}
return listName;
@@ -525,7 +525,7 @@
String flagName = nextVariableName(Boolean.class);
GeneratedTerm term = subexpression(builder, node.getChild(0));
-builder.addln(boolean %s = invert(($w) %s);, flagName,
term.variableName);
+builder.addln(boolean %s = invert(($w) %s);, flagName,
term.termReference);
return flagName;
}
@@ -539,7 +539,7 @@
*/
private GeneratedTerm subexpression(BodyBuilder builder, Tree node)
{
-String previousVariableName = root;
+String previousReference = root;
Class activeType = rootType;
while (node != null)
@@ -549,7 +549,7 @@
case TRUE:
case FALSE:
-previousVariableName = node.getType() == TRUE ? true
: false;
+previousReference = node.getType() == TRUE ? true :
false;
activeType = boolean.class;
node = null;
@@ -559,7 +559,7 @@
long integerValue = Long.parseLong(node.getText());
-previousVariableName = String.format(%dL,
integerValue);
+previousReference = String.format(%dL, integerValue);
activeType = long.class;
node = null;
@@ -570,7 +570,7 @@
double decimalValue =
Double.parseDouble(node.getText());
-previousVariableName = String.format(%fd,
decimalValue);
+previousReference = String.format(%fd, decimalValue);
activeType = double.class;
node = null;
@@ -581,7 +581,7 @@
String stringValue = node.getText();
// Injecting is easier; don't have to fuss with
escaping quotes or such.
-
[jira] Closed: (TAP5-666) Property expression can not pass a boolean constant into a method
[
https://issues.apache.org/jira/browse/TAP5-666?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Howard M. Lewis Ship closed TAP5-666.
-
Resolution: Fixed
Fix Version/s: 5.1.0.5
Was also able to improve the efficiency of the code generated not constantly
switch between primitive types and wrapper types.
Property expression can not pass a boolean constant into a method
-
Key: TAP5-666
URL: https://issues.apache.org/jira/browse/TAP5-666
Project: Tapestry 5
Issue Type: Bug
Components: tapestry-core
Affects Versions: 5.1.0.4
Reporter: Howard M. Lewis Ship
Assignee: Howard M. Lewis Ship
Fix For: 5.1.0.5
From the mailing list:
I just tried out the new T5.1 property expressions for the first time and got
an error. I'm trying to replace this:
${linkTitle}
public String getLinkTitle() {
return getTitle(false);
}
With this:
${getTitle(false)}
Which I should be able to do according to the Grammar as far as I can see,
since but I get this error when I try it:
Caused by:
org.apache.tapestry5.internal.services.PropertyExpressionException: Node
false (within expression 'getTitle(false)') was type FALSE, but was expected
to be (one of) DECIMAL, DEREF, IDENTIFIER, INTEGER, INVOKE, LIST, SAFEDEREF,
STRING.
at
org.apache.tapestry5.internal.services.PropertyConduitSourceImpl$PropertyConduitBuilder.unexpectedNodeType(PropertyConduitSourceImpl.java:925)
at
org.apache.tapestry5.internal.services.PropertyConduitSourceImpl$PropertyConduitBuilder.subexpression(PropertyConduitSourceImpl.java:637)
at
org.apache.tapestry5.internal.services.PropertyConduitSourceImpl$PropertyConduitBuilder.createMethodInvocation(PropertyConduitSourceImpl.java:756)
at
org.apache.tapestry5.internal.services.PropertyConduitSourceImpl$PropertyConduitBuilder.createMethodInvocation(PropertyConduitSourceImpl.java:730)
at
org.apache.tapestry5.internal.services.PropertyConduitSourceImpl$PropertyConduitBuilder.createGetter(PropertyConduitSourceImpl.java:711)
at
org.apache.tapestry5.internal.services.PropertyConduitSourceImpl$PropertyConduitBuilder.createGetterAndSetter(PropertyConduitSourceImpl.java:436)
at
org.apache.tapestry5.internal.services.PropertyConduitSourceImpl$PropertyConduitBuilder.createAccessors(PropertyConduitSourceImpl.java:419)
at
org.apache.tapestry5.internal.services.PropertyConduitSourceImpl$PropertyConduitBuilder.createInstance(PropertyConduitSourceImpl.java:272)
at
org.apache.tapestry5.internal.services.PropertyConduitSourceImpl.build(PropertyConduitSourceImpl.java:1206)
at
org.apache.tapestry5.internal.services.PropertyConduitSourceImpl.create(PropertyConduitSourceImpl.java:1081)
at
$PropertyConduitSource_120d3f0182d.create($PropertyConduitSource_120d3f0182d.java)
at
org.apache.tapestry5.internal.bindings.PropBindingFactory.newBinding(PropBindingFactory.java:49)
at
$BindingFactory_120d3f0182e.newBinding($BindingFactory_120d3f0182e.java)
at
$BindingFactory_120d3f01826.newBinding($BindingFactory_120d3f01826.java)
at
org.apache.tapestry5.internal.services.BindingSourceImpl.newBinding(BindingSourceImpl.java:81)
... 107 more
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (TAP5-663) Error with passing false in property expressions
[
https://issues.apache.org/jira/browse/TAP5-663?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Howard M. Lewis Ship closed TAP5-663.
-
Resolution: Duplicate
TAP5-666
Error with passing false in property expressions
Key: TAP5-663
URL: https://issues.apache.org/jira/browse/TAP5-663
Project: Tapestry 5
Issue Type: Bug
Components: tapestry-core
Affects Versions: 5.1.0.3, 5.1.0.4
Reporter: Andy Blower
Priority: Minor
I just tried out the new T5.1 property expressions for the first time and got
an error. I'm trying to replace this:
${linkTitle}
public String getLinkTitle() {
return getTitle(false);
}
With this:
${getTitle(false)}
Which I should be able to do according to the Grammar as far as I can see,
since but I get this error when I try it:
Caused by:
org.apache.tapestry5.internal.services.PropertyExpressionException: Node
false (within expression 'getTitle(false)') was type FALSE, but was expected
to be (one of) DECIMAL, DEREF, IDENTIFIER, INTEGER, INVOKE, LIST, SAFEDEREF,
STRING.
at
org.apache.tapestry5.internal.services.PropertyConduitSourceImpl$PropertyConduitBuilder.unexpectedNodeType(PropertyConduitSourceImpl.java:925)
at
org.apache.tapestry5.internal.services.PropertyConduitSourceImpl$PropertyConduitBuilder.subexpression(PropertyConduitSourceImpl.java:637)
at
org.apache.tapestry5.internal.services.PropertyConduitSourceImpl$PropertyConduitBuilder.createMethodInvocation(PropertyConduitSourceImpl.java:756)
at
org.apache.tapestry5.internal.services.PropertyConduitSourceImpl$PropertyConduitBuilder.createMethodInvocation(PropertyConduitSourceImpl.java:730)
at
org.apache.tapestry5.internal.services.PropertyConduitSourceImpl$PropertyConduitBuilder.createGetter(PropertyConduitSourceImpl.java:711)
at
org.apache.tapestry5.internal.services.PropertyConduitSourceImpl$PropertyConduitBuilder.createGetterAndSetter(PropertyConduitSourceImpl.java:436)
at
org.apache.tapestry5.internal.services.PropertyConduitSourceImpl$PropertyConduitBuilder.createAccessors(PropertyConduitSourceImpl.java:419)
at
org.apache.tapestry5.internal.services.PropertyConduitSourceImpl$PropertyConduitBuilder.createInstance(PropertyConduitSourceImpl.java:272)
at
org.apache.tapestry5.internal.services.PropertyConduitSourceImpl.build(PropertyConduitSourceImpl.java:1206)
at
org.apache.tapestry5.internal.services.PropertyConduitSourceImpl.create(PropertyConduitSourceImpl.java:1081)
at
$PropertyConduitSource_120d3f0182d.create($PropertyConduitSource_120d3f0182d.java)
at
org.apache.tapestry5.internal.bindings.PropBindingFactory.newBinding(PropBindingFactory.java:49)
at
$BindingFactory_120d3f0182e.newBinding($BindingFactory_120d3f0182e.java)
at
$BindingFactory_120d3f01826.newBinding($BindingFactory_120d3f01826.java)
at
org.apache.tapestry5.internal.services.BindingSourceImpl.newBinding(BindingSourceImpl.java:81)
... 107 more
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Created: (TAP5-667) Site build fails inside tapestry-hibernate-core
Site build fails inside tapestry-hibernate-core --- Key: TAP5-667 URL: https://issues.apache.org/jira/browse/TAP5-667 Project: Tapestry 5 Issue Type: Bug Components: tapestry-hibernate Affects Versions: 5.1.0.4 Reporter: Howard M. Lewis Ship Not sure why this happens on my Mac when I do a release build, but not on the Bamboo server for nightly builds! [INFO] [INFO] Building Tapestry Hibernate Support [INFO]task-segment: [site, site:deploy] [INFO] [INFO] Preparing cobertura:cobertura [INFO] [resources:resources] [INFO] Using 'UTF-8' encoding to copy filtered resources. [INFO] Copying 1 resource [INFO] [compiler:compile] [INFO] Nothing to compile - all classes are up to date [INFO] [cobertura:instrument] [INFO] Cobertura 1.9 - GNU GPL License (NO WARRANTY) - See COPYRIGHT file Instrumenting 22 files to /Users/Howard/work/tapestry5/tapestry-hibernate-core/target/generated-classes/cobertura Cobertura: Saved information on 22 classes. Instrument time: 193ms [INFO] Instrumentation was successful. [INFO] [resources:testResources] [INFO] Using 'UTF-8' encoding to copy filtered resources. [INFO] Copying 2 resources [INFO] [compiler:testCompile] [INFO] Compiling 4 source files to /Users/Howard/work/tapestry5/tapestry-hibernate-core/target/test-classes [INFO] [ERROR] BUILD FAILURE [INFO] [INFO] Compilation failure /Users/Howard/work/tapestry5/tapestry-hibernate-core/src/test/java/org/apache/tapestry5/internal/hibernate/HibernateSessionSourceImplTest.java:[52,57] incompatible types found : java.util.Listjava.lang.Objectorg.apache.tapestry5.hibernate.HibernateConfigurernet.sourceforge.cobertura.coveragedata.HasBeenInstrumented required: java.util.Listorg.apache.tapestry5.hibernate.HibernateConfigurer [INFO] [INFO] For more information, run Maven with the -e switch [INFO] [INFO] Total time: 20 minutes 56 seconds [INFO] Finished at: Mon Apr 27 11:43:15 PDT 2009 [INFO] Final Memory: 51M/98M [INFO] ~/work/tapestry5 -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (TAP5-667) Site build fails inside tapestry-hibernate-core
[ https://issues.apache.org/jira/browse/TAP5-667?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12703285#action_12703285 ] Howard M. Lewis Ship commented on TAP5-667: --- $ java -version java version 1.5.0_16 Java(TM) 2 Runtime Environment, Standard Edition (build 1.5.0_16-b06-284) Java HotSpot(TM) Client VM (build 1.5.0_16-133, mixed mode, sharing) Site build fails inside tapestry-hibernate-core --- Key: TAP5-667 URL: https://issues.apache.org/jira/browse/TAP5-667 Project: Tapestry 5 Issue Type: Bug Components: tapestry-hibernate Affects Versions: 5.1.0.4 Reporter: Howard M. Lewis Ship Not sure why this happens on my Mac when I do a release build, but not on the Bamboo server for nightly builds! [INFO] [INFO] Building Tapestry Hibernate Support [INFO]task-segment: [site, site:deploy] [INFO] [INFO] Preparing cobertura:cobertura [INFO] [resources:resources] [INFO] Using 'UTF-8' encoding to copy filtered resources. [INFO] Copying 1 resource [INFO] [compiler:compile] [INFO] Nothing to compile - all classes are up to date [INFO] [cobertura:instrument] [INFO] Cobertura 1.9 - GNU GPL License (NO WARRANTY) - See COPYRIGHT file Instrumenting 22 files to /Users/Howard/work/tapestry5/tapestry-hibernate-core/target/generated-classes/cobertura Cobertura: Saved information on 22 classes. Instrument time: 193ms [INFO] Instrumentation was successful. [INFO] [resources:testResources] [INFO] Using 'UTF-8' encoding to copy filtered resources. [INFO] Copying 2 resources [INFO] [compiler:testCompile] [INFO] Compiling 4 source files to /Users/Howard/work/tapestry5/tapestry-hibernate-core/target/test-classes [INFO] [ERROR] BUILD FAILURE [INFO] [INFO] Compilation failure /Users/Howard/work/tapestry5/tapestry-hibernate-core/src/test/java/org/apache/tapestry5/internal/hibernate/HibernateSessionSourceImplTest.java:[52,57] incompatible types found : java.util.Listjava.lang.Objectorg.apache.tapestry5.hibernate.HibernateConfigurernet.sourceforge.cobertura.coveragedata.HasBeenInstrumented required: java.util.Listorg.apache.tapestry5.hibernate.HibernateConfigurer [INFO] [INFO] For more information, run Maven with the -e switch [INFO] [INFO] Total time: 20 minutes 56 seconds [INFO] Finished at: Mon Apr 27 11:43:15 PDT 2009 [INFO] Final Memory: 51M/98M [INFO] ~/work/tapestry5 -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
svn commit: r769153 - in /tapestry/tapestry-site/trunk/src/site: apt/download.apt site.xml xdoc/index.xml xdoc/news.xml
/tapestry/tapestry-src-5.1.0.4.tar.gz}
Download}} |
{{{http://www.apache.org/dist/tapestry/tapestry-src-5.1.0.4.tar.gz.md5} MD5}} |
{{{http://www.apache.org/dist/tapestry/tapestry-src-5.1.0.4.tar.gz.asc} ASC}}
*-+-+--+---+
-| tapestry-src 5.1.0.3 binary (zip) |
{{{http://www.apache.org/dyn/closer.cgi/tapestry/tapestry-src-5.1.0.3.zip}
Download}} |
{{{http://www.apache.org/dist/tapestry/tapestry-src-5.1.0.3.zip.md5} MD5}} |
{{{http://www.apache.org/dist/tapestry/tapestry-src-5.1.0.3.zip.asc} ASC}}
+| tapestry-src 5.1.0.4 binary (zip) |
{{{http://www.apache.org/dyn/closer.cgi/tapestry/tapestry-src-5.1.0.4.zip}
Download}} |
{{{http://www.apache.org/dist/tapestry/tapestry-src-5.1.0.4.zip.md5} MD5}} |
{{{http://www.apache.org/dist/tapestry/tapestry-src-5.1.0.4.zip.asc} ASC}}
*-+-+--+---+
Modified: tapestry/tapestry-site/trunk/src/site/site.xml
URL:
http://svn.apache.org/viewvc/tapestry/tapestry-site/trunk/src/site/site.xml?rev=769153r1=769152r2=769153view=diff
==
--- tapestry/tapestry-site/trunk/src/site/site.xml (original)
+++ tapestry/tapestry-site/trunk/src/site/site.xml Mon Apr 27 20:40:24 2009
@@ -52,7 +52,7 @@
href=http://tapestry.apache.org/tapestry4.1/
item name=Tapestry 5.0 (stable)
href=http://tapestry.apache.org/tapestry5/
-item name=Tapestry 5.1 (alpha)
+item name=Tapestry 5.1 (beta)
href=http://tapestry.apache.org/tapestry5.1/
item name=Tapestry 4
href=http://tapestry.apache.org/tapestry4/
Modified: tapestry/tapestry-site/trunk/src/site/xdoc/index.xml
URL:
http://svn.apache.org/viewvc/tapestry/tapestry-site/trunk/src/site/xdoc/index.xml?rev=769153r1=769152r2=769153view=diff
==
--- tapestry/tapestry-site/trunk/src/site/xdoc/index.xml (original)
+++ tapestry/tapestry-site/trunk/src/site/xdoc/index.xml Mon Apr 27 20:40:24
2009
@@ -30,7 +30,10 @@
ul style=list-style:none
li
-a href=news.html#20090414Tapestry 5.1.0.3 - Alpha
Release/a
+a href=news.html#20090427Tapestry 5.1.0.4 - Beta
Release/a
+/li
+li
+a href=news.html#20090420Tapestry 5.1 is Beta!/a
/li
li
a href=news.html#20090215New committers: Thiago
and Robert/a
Modified: tapestry/tapestry-site/trunk/src/site/xdoc/news.xml
URL:
http://svn.apache.org/viewvc/tapestry/tapestry-site/trunk/src/site/xdoc/news.xml?rev=769153r1=769152r2=769153view=diff
==
--- tapestry/tapestry-site/trunk/src/site/xdoc/news.xml (original)
+++ tapestry/tapestry-site/trunk/src/site/xdoc/news.xml Mon Apr 27 20:40:24 2009
@@ -12,11 +12,50 @@
Keep up to date with the latest events in the Tapestry world.
/p
+a name=20090427/
+subsection name=Tapestry 5.1.0.4 (Beta Release)
+strongApr 27 2009/strong
+
+pThe first second release of Tapestry 5.1 is now available:
+a href=http://tapestry.apache.org/tapestry5.1/;Tapestry
5.1.0.4/a
+/p
+
+pThis is a bug fix release; many of the improvements were to
+the Maven Quickstart Archetype, and to the Maven Component
Report.
+/p
+
+p
+See the
+a
href=http://tapestry.apache.org/tapestry5.1/release-notes.html;
+release notes
+/a
+for more details.
+/p
+
+p
+a href=download.htmlDownload Tapestry 5.1.0.4/a
+/p
+
+/subsection
+
+
+a name=20090420/
+subsection name=Tapestry 5.1 is Beta!
+strongApr 20 2009/strong
+
+
+p
+Following a recent vote, Tapestry 5.1 is now a beta
release. Tapestry tends to have pretty
+short beta periods, so a final release of 5.1 is just
around the corner!
+/p
+
+/subsection
+
a name=20090414/
-subsection name=Tapestry 5.1.0.3 (Alpha Release)
+subsection name=Tapestry 5.1.0.3 (Beta Release)
strongApr 14 2009/strong
-pAn updated alpha release of Tapestry 5.1 is now available:
+pThe first beta release of Tapestry 5.1 is now available:
a href=http://tapestry.apache.org/tapestry5.1/;Tapestry
5.1.0.3/a
/p
[jira] Commented: (TAP5-577) TAP5-422 changes break persistent locale backwards compatibility.
[ https://issues.apache.org/jira/browse/TAP5-577?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12703460#action_12703460 ] Ferdy Nagy commented on TAP5-577: - You're not the only one bothered by this, and I think there are reasonable expectations that locale could passed around by cookie. We use a central SSO that allows people to change their preferred language and they can move from application to application within the domain with each application displaying in their language choice. The process outlined by Andy doesn't really work because the ComponentEventLinkEncoder always calls the LocalizationSetter which in turn always sets the ThreadLocale; thus overriding the set made by the filter. To make it work I had to override the LocalizationSetter service to always return false, and change the filter to set the ThreadLocale directly. This just doesn't feel right. It seems like there should be a simple way for a single concern to deal with the localization setting that can handle a choice of either the URL containing the locale, or a cookie, or from the request. I shouldn't have to deal with a filter and a localization setter and a persistence layer just to say here is the locale - and I certainly shouldn't have to look at the internals of LocalizationSetter and CELE to understand how this works (but I'm very happy I can, and also grok the process easily). TAP5-422 changes break persistent locale backwards compatibility. - Key: TAP5-577 URL: https://issues.apache.org/jira/browse/TAP5-577 Project: Tapestry 5 Issue Type: Bug Components: tapestry-core Affects Versions: 5.1.0.0, 5.1.0.1 Reporter: Andy Blower Priority: Critical Attachments: T5.1persistentLocale.txt I think that the changes made in T5.1 for TAP5-422 break backwards compatibility with T5.0's locale persistence. In T5.0 it was a simple matter to override the default cookie persistence by creating a custom implementation of the PersistentLocale service and contributing it to be used instead of the standard internal T5 implementation. The TAP5-422 changes broke backwards compatibility because anyone who's created their own implementation of PersistentLocale, or just wants the 5.0 cookie persistence behaviour, would have found that it's a lot more work and involves some heavy changes to Tapestry internals. Now with the recent changes for TAP5-418 (committed yesterday), the situation had been alleviated somewhat by allowing the the hard-wired URl locale persistence to be switched off using a new symbol. However, I still think that this breaks backwards compatibility in two ways: 1) By changing the default behaviour of locale persistence so that anyone relying on the locale persistence behaviour of 5.0 will have to make non-trivial changes when they upgrade to 5.1 to keep the same operation. 2) By requiring so much work for anyone wanting to keep the 5.0 cookie persistence behaviour or define their own custom locale persistence. (In 5.0 it was easy to figure out and implement a custom locale persistence method) From my analysis of the changes made by TAP5-422 TAP5-418, I think anyone wanting non-URL based locale persistence will need to do the following when upgrading from 5.0 to 5.1: 1) Set the ENCODE_LOCALE_INTO_PATH symbol to false. 2) Create an implementation of PersistentLocale and contribute it to the IOC. (copied from the standard 5.0 code if the old default cookie persistence is desired) 3) Create a custom filter written and created to do the same job as the 5.0 LocalizationFilter and contribute it to the IOC RequestHandler. This filter will need to call the LocalizationSetter setLocaleFromLocaleName() method instead of the old setThreadLocale() method. My suggested resolution would be to re-instate the 5.0 cookie persistence (LocalizationFilter PersistentLocaleImpl) and have the new ENCODE_LOCALE_INTO_PATH symbol default to false allowing 5.1 to work the same way as 5.0 out of the box. If the symbol is set to true, then the LocalizationFilter is disabled (not contributed to RequestHandler) and the PersistentLocale service will need to just store the locale (not set it in a cookie) for later use by LinkSourceImpl. LocalizationSetterImpl.setLocaleFromLocaleName(String localeName) would also need changing back to overriding the passed localeName if a persistent one had been set into the PersistentLocale service. There may by a much better solution than this as I've not spent much time on it, but I though I should try to be helpful as possible. (It should be noted that this is purely a product of my analysis of the 5.1 code, I have not found the time to actually run T5.1 and test this out - I
