[jira] Updated: (TAP5-672) Translation for Vietnamese
[ https://issues.apache.org/jira/browse/TAP5-672?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tam Du updated TAP5-672: Attachment: org.zip > Translation for Vietnamese > -- > > Key: TAP5-672 > URL: https://issues.apache.org/jira/browse/TAP5-672 > Project: Tapestry 5 > Issue Type: Improvement > Components: tapestry-core >Reporter: Tam Du > Attachments: org.zip > > > Files for translation of components in Vietnamese -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Created: (TAP5-672) Translation for Vietnamese
Translation for Vietnamese -- Key: TAP5-672 URL: https://issues.apache.org/jira/browse/TAP5-672 Project: Tapestry 5 Issue Type: Improvement Components: tapestry-core Reporter: Tam Du Files for translation of components in Vietnamese -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Closed: (TAP5-223) Allow properties files (on classpath or in the context) to be used as SymbolProviders
[ https://issues.apache.org/jira/browse/TAP5-223?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Howard M. Lewis Ship closed TAP5-223. - Resolution: Fixed Fix Version/s: 5.1.0.5 > Allow properties files (on classpath or in the context) to be used as > SymbolProviders > - > > Key: TAP5-223 > URL: https://issues.apache.org/jira/browse/TAP5-223 > Project: Tapestry 5 > Issue Type: New Feature > Components: tapestry-ioc >Affects Versions: 5.0.15 >Reporter: Neeme Praks >Assignee: Howard M. Lewis Ship >Priority: Minor > Fix For: 5.1.0.5 > > Attachments: PropertiesFileSymbolProvider.patch.txt, TAP5-223.txt > > > add a possibility to resolve symbols from properties file > (PropertiesFileSymbolProvider). > For reference, see: > http://thread.gmane.org/gmane.comp.java.tapestry.user/65656 -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
svn commit: r769554 - in /tapestry/tapestry5/trunk: tapestry-core/src/main/java/org/apache/tapestry5/internal/ tapestry-core/src/test/java/org/apache/tapestry5/internal/ tapestry-ioc/src/main/java/org
Author: hlship
Date: Tue Apr 28 21:39:40 2009
New Revision: 769554
URL: http://svn.apache.org/viewvc?rev=769554&view=rev
Log:
TAP5-223: Allow properties files (on classpath or in the context) to be used as
SymbolProviders
Added:
tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/internal/ContextResourceSymbolProvider.java
(with props)
tapestry/tapestry5/trunk/tapestry-core/src/test/java/org/apache/tapestry5/internal/ContextResourceSymbolProviderTest.java
(with props)
tapestry/tapestry5/trunk/tapestry-ioc/src/main/java/org/apache/tapestry5/ioc/internal/services/ClasspathResourceSymbolProvider.java
(with props)
tapestry/tapestry5/trunk/tapestry-ioc/src/main/java/org/apache/tapestry5/ioc/internal/services/ResourceSymbolProvider.java
(with props)
tapestry/tapestry5/trunk/tapestry-ioc/src/test/java/org/apache/tapestry5/ioc/internal/services/ClasspathResourceSymbolProviderTest.java
(with props)
tapestry/tapestry5/trunk/tapestry-ioc/src/test/java/org/apache/tapestry5/ioc/internal/services/ResourceSymbolProviderTest.java
(with props)
tapestry/tapestry5/trunk/tapestry-ioc/src/test/resources/org/apache/tapestry5/ioc/internal/services/
tapestry/tapestry5/trunk/tapestry-ioc/src/test/resources/org/apache/tapestry5/ioc/internal/services/foo.properties
(with props)
Added:
tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/internal/ContextResourceSymbolProvider.java
URL:
http://svn.apache.org/viewvc/tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/internal/ContextResourceSymbolProvider.java?rev=769554&view=auto
==
---
tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/internal/ContextResourceSymbolProvider.java
(added)
+++
tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/internal/ContextResourceSymbolProvider.java
Tue Apr 28 21:39:40 2009
@@ -0,0 +1,33 @@
+// Copyright 2009 The Apache Software Foundation
+//
+// Licensed under the Apache License, Version 2.0 (the "License");
+// you may not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
+package org.apache.tapestry5.internal;
+
+import org.apache.tapestry5.internal.services.ContextResource;
+import org.apache.tapestry5.ioc.internal.services.ResourceSymbolProvider;
+import org.apache.tapestry5.services.Context;
+
+/**
+ * Makes a {...@link org.apache.tapestry5.ioc.Resource} in the {...@link
org.apache.tapestry5.services.Context} available as a
+ * {...@link org.apache.tapestry5.ioc.services.SymbolProvider}
+ *
+ * @since 5.1.0.5
+ */
+public class ContextResourceSymbolProvider extends ResourceSymbolProvider
+{
+public ContextResourceSymbolProvider(Context context, String path)
+{
+super(new ContextResource(context, path));
+}
+}
Propchange:
tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/internal/ContextResourceSymbolProvider.java
--
svn:eol-style = native
Added:
tapestry/tapestry5/trunk/tapestry-core/src/test/java/org/apache/tapestry5/internal/ContextResourceSymbolProviderTest.java
URL:
http://svn.apache.org/viewvc/tapestry/tapestry5/trunk/tapestry-core/src/test/java/org/apache/tapestry5/internal/ContextResourceSymbolProviderTest.java?rev=769554&view=auto
==
---
tapestry/tapestry5/trunk/tapestry-core/src/test/java/org/apache/tapestry5/internal/ContextResourceSymbolProviderTest.java
(added)
+++
tapestry/tapestry5/trunk/tapestry-core/src/test/java/org/apache/tapestry5/internal/ContextResourceSymbolProviderTest.java
Tue Apr 28 21:39:40 2009
@@ -0,0 +1,70 @@
+// Copyright 2009 The Apache Software Foundation
+//
+// Licensed under the Apache License, Version 2.0 (the "License");
+// you may not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
+package org.apache.tapestry5.internal;
+
+import org.apache.tapestry5.internal.test.InternalBaseTestCase;
+impo
[jira] Updated: (TAP5-223) Allow properties files (on classpath or in the context) to be used as SymbolProviders
[ https://issues.apache.org/jira/browse/TAP5-223?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Howard M. Lewis Ship updated TAP5-223: -- Priority: Minor (was: Major) Assignee: Howard M. Lewis Ship Summary: Allow properties files (on classpath or in the context) to be used as SymbolProviders (was: add PropertiesFileSymbolProvider) I'm glad these are going into the internal package because I have some issues with them, primarily with the ContextResourceSymbolProvider ... that is, the order of operations for starting up a Tapestry web application means (to me) that it is highly likely that you will not have a Context available when it is necessary to contribute to the SymbolSource. Perhaps I'm missing something. I'm much more comfortable with the ResourceSymbolProvider. > Allow properties files (on classpath or in the context) to be used as > SymbolProviders > - > > Key: TAP5-223 > URL: https://issues.apache.org/jira/browse/TAP5-223 > Project: Tapestry 5 > Issue Type: New Feature > Components: tapestry-ioc >Affects Versions: 5.0.15 >Reporter: Neeme Praks >Assignee: Howard M. Lewis Ship >Priority: Minor > Attachments: PropertiesFileSymbolProvider.patch.txt, TAP5-223.txt > > > add a possibility to resolve symbols from properties file > (PropertiesFileSymbolProvider). > For reference, see: > http://thread.gmane.org/gmane.comp.java.tapestry.user/65656 -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Closed: (TAP5-531) Add cookbook documentation to show how to use the delegate component for switch-like behaviour
[ https://issues.apache.org/jira/browse/TAP5-531?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Howard M. Lewis Ship closed TAP5-531. - Resolution: Fixed Fix Version/s: 5.1.0.5 Assignee: Howard M. Lewis Ship > Add cookbook documentation to show how to use the delegate component for > switch-like behaviour > -- > > Key: TAP5-531 > URL: https://issues.apache.org/jira/browse/TAP5-531 > Project: Tapestry 5 > Issue Type: Improvement > Components: documentation >Affects Versions: 5.0.18 >Reporter: Ulrich Stärk >Assignee: Howard M. Lewis Ship >Priority: Minor > Fix For: 5.1.0.5 > > Attachments: TAP5-531.txt > > > Right now, the only documentation on how to have switch-like behaviour with > the Delegate component is on the Delegate component's reference documentation > page itself. People just don't look there when they want a solution to a > specific use case like having switch behaviour. This has come up several > times on the mailing list and on the IRC channel. > There should be a page in the cookbook explaining how to use the delegate > component to have switch-like behaviour. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
svn commit: r769546 - in /tapestry/tapestry5/trunk/src/site: apt/cookbook/switch.apt site.xml
Author: hlship
Date: Tue Apr 28 21:20:24 2009
New Revision: 769546
URL: http://svn.apache.org/viewvc?rev=769546&view=rev
Log:
TAP5-531: Add cookbook documentation to show how to use the delegate component
for switch-like behaviour
Added:
tapestry/tapestry5/trunk/src/site/apt/cookbook/switch.apt (with props)
Modified:
tapestry/tapestry5/trunk/src/site/site.xml
Added: tapestry/tapestry5/trunk/src/site/apt/cookbook/switch.apt
URL:
http://svn.apache.org/viewvc/tapestry/tapestry5/trunk/src/site/apt/cookbook/switch.apt?rev=769546&view=auto
==
--- tapestry/tapestry5/trunk/src/site/apt/cookbook/switch.apt (added)
+++ tapestry/tapestry5/trunk/src/site/apt/cookbook/switch.apt Tue Apr 28
21:20:24 2009
@@ -0,0 +1,79 @@
+ ---
+ Switching Cases
+ ---
+
+Switching Cases
+
+ With Tapestry's <<>> component you can only test one condition at a
time. In order to distinguish multiple cases,
+ you'd have to write complex nested if/else constructs in your page template
and have a checker method for each
+ test inside your page class.
+
+ In cases where you have to distinguish multiple cases, the <<>>
component comes in. It delegates rendering
+ to some other component, for example a <<>>. For each case you have,
you basically wrap the content inside a
+ <<>> that doesn't get rendered by default. You then place a Delegate
component on your page and point it to
+ a method inside your page class that will decide which of your Blocks should
be rendered.
+
+ Imagine for example a use case, where you want to distinguish between 4
cases and you have an int property called
+ <<>> that should be tested against. Your page template would look
as follows:
+
+
+http://tapestry.apache.org/schema/tapestry_5_1_0.xsd";>
+
+Switch
+
+
+
+
+Here is the content for case1.
+
+
+
+Here is the content for case2.
+
+
+
+Here is the content for case3.
+
+
+
+Here is the content for case4.
+
+
+
+
+
+ You can see, that the <<>> component's <<>> parameter is bound
to the case property of your page class. In your
+ page class you therefore have a <<>> method that is responsible
for telling the <<>> component which
+ component should be rendered. For that we are injecting references to the
<<>>s defined in your page template
+ into the page class and return the according <<>> in the
<<>> method.
+
+
+public class SwitchMe
+{
+@Persist
+private int whichCase;
+
+@Inject
+private Block case1, case2, case3, case4;
+
+public Object getCase()
+{
+switch (whichCase)
+{
+case 1:
+return case1;
+case 2:
+return case2;
+case 3:
+return case3;
+case 4:
+return case4;
+default:
+return null;
+}
+}
+}
+
+
+ Happy switching!
+
Propchange: tapestry/tapestry5/trunk/src/site/apt/cookbook/switch.apt
--
svn:eol-style = native
Modified: tapestry/tapestry5/trunk/src/site/site.xml
URL:
http://svn.apache.org/viewvc/tapestry/tapestry5/trunk/src/site/site.xml?rev=769546&r1=769545&r2=769546&view=diff
==
--- tapestry/tapestry5/trunk/src/site/site.xml (original)
+++ tapestry/tapestry5/trunk/src/site/site.xml Tue Apr 28 21:20:24 2009
@@ -119,6 +119,7 @@
+
[jira] Closed: (TAP5-601) Add German translation for client-side JavaScript messages
[ https://issues.apache.org/jira/browse/TAP5-601?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Howard M. Lewis Ship closed TAP5-601. - Resolution: Fixed Fix Version/s: 5.1.0.5 Assignee: Howard M. Lewis Ship > Add German translation for client-side JavaScript messages > -- > > Key: TAP5-601 > URL: https://issues.apache.org/jira/browse/TAP5-601 > Project: Tapestry 5 > Issue Type: New Feature > Components: tapestry-core >Affects Versions: 5.0.18 >Reporter: Ulrich Stärk >Assignee: Howard M. Lewis Ship >Priority: Minor > Fix For: 5.1.0.5 > > Attachments: TAP5-601.txt > > -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (TAP5-601) Add German translation for client-side JavaScript messages
[ https://issues.apache.org/jira/browse/TAP5-601?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Howard M. Lewis Ship updated TAP5-601: -- Summary: Add German translation for client-side JavaScript messages (was: Add german translation for javscript messages) > Add German translation for client-side JavaScript messages > -- > > Key: TAP5-601 > URL: https://issues.apache.org/jira/browse/TAP5-601 > Project: Tapestry 5 > Issue Type: New Feature > Components: tapestry-core >Affects Versions: 5.0.18 >Reporter: Ulrich Stärk >Priority: Minor > Fix For: 5.1.0.5 > > Attachments: TAP5-601.txt > > -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
svn commit: r769539 - in /tapestry/tapestry5/trunk/tapestry-core/src/main/resources/org/apache/tapestry5: tapestry-messages.js tapestry-messages_de.js tapestry.js
Author: hlship
Date: Tue Apr 28 21:14:51 2009
New Revision: 769539
URL: http://svn.apache.org/viewvc?rev=769539&view=rev
Log:
TAP5-601: Add German translation for client-side JavaScript messages
Added:
tapestry/tapestry5/trunk/tapestry-core/src/main/resources/org/apache/tapestry5/tapestry-messages_de.js
(with props)
Modified:
tapestry/tapestry5/trunk/tapestry-core/src/main/resources/org/apache/tapestry5/tapestry-messages.js
tapestry/tapestry5/trunk/tapestry-core/src/main/resources/org/apache/tapestry5/tapestry.js
Modified:
tapestry/tapestry5/trunk/tapestry-core/src/main/resources/org/apache/tapestry5/tapestry-messages.js
URL:
http://svn.apache.org/viewvc/tapestry/tapestry5/trunk/tapestry-core/src/main/resources/org/apache/tapestry5/tapestry-messages.js?rev=769539&r1=769538&r2=769539&view=diff
==
---
tapestry/tapestry5/trunk/tapestry-core/src/main/resources/org/apache/tapestry5/tapestry-messages.js
(original)
+++
tapestry/tapestry5/trunk/tapestry-core/src/main/resources/org/apache/tapestry5/tapestry-messages.js
Tue Apr 28 21:14:51 2009
@@ -34,5 +34,7 @@
notAnInteger : "Not an integer",
-invalidCharacter : "Invalid character"
+invalidCharacter : "Invalid character",
+
+communicationFailed : "Communication with the server failed: "
};
\ No newline at end of file
Added:
tapestry/tapestry5/trunk/tapestry-core/src/main/resources/org/apache/tapestry5/tapestry-messages_de.js
URL:
http://svn.apache.org/viewvc/tapestry/tapestry5/trunk/tapestry-core/src/main/resources/org/apache/tapestry5/tapestry-messages_de.js?rev=769539&view=auto
==
---
tapestry/tapestry5/trunk/tapestry-core/src/main/resources/org/apache/tapestry5/tapestry-messages_de.js
(added)
+++
tapestry/tapestry5/trunk/tapestry-core/src/main/resources/org/apache/tapestry5/tapestry-messages_de.js
Tue Apr 28 21:14:51 2009
@@ -0,0 +1,40 @@
+// Copyright 2009 The Apache Software Foundation
+//
+// Licensed under the Apache License, Version 2.0 (the "License");
+// you may not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
+Tapestry.Messages = {
+
+pageIsLoading : "Bitte warten während die Seite zu Ende lädt ...",
+
+missingInitializer : "Die Funktion Tapestry.Initializer.#{name}()
existiert nicht.",
+
+missingValidator : "Die Funktion Tapestry.Validator.#{name}()
existiert nicht für das Feld '#{fieldName}'.",
+
+ajaxFailure : "Ajax Fehler: Status #{status} für #{request.url}: ",
+
+ajaxRequestUnsuccessful : "Die Serveranfrage schlug fehl. Es gibt
womöglich ein Problem beim Zugriff auf den Server.",
+
+clientException : "Client exception beim Verarbeiten der Antwort: ",
+
+missingZone : "Ajax Zone '#{id}' konnte für ein dynamisches Update
nicht gefunden werden.",
+
+noZoneManager : "Ajax Zone '#{id}' ist nicht mit einem
Tapestry.ZoneManager Objekt verknüpft." ,
+
+pathDoesNotStartWithSlash : "Der externe Pfad #{path} beginnt nicht mit
einem führenden '/'.",
+
+notAnInteger : "Kein ganzzahliger Wert",
+
+invalidCharacter : "Ungültiges Zeichen",
+
+communicationFailed : "Kommunikation mit dem Server ist fehlgeschlagen: "
+};
Propchange:
tapestry/tapestry5/trunk/tapestry-core/src/main/resources/org/apache/tapestry5/tapestry-messages_de.js
--
svn:eol-style = native
Modified:
tapestry/tapestry5/trunk/tapestry-core/src/main/resources/org/apache/tapestry5/tapestry.js
URL:
http://svn.apache.org/viewvc/tapestry/tapestry5/trunk/tapestry-core/src/main/resources/org/apache/tapestry5/tapestry.js?rev=769539&r1=769538&r2=769539&view=diff
==
---
tapestry/tapestry5/trunk/tapestry-core/src/main/resources/org/apache/tapestry5/tapestry.js
(original)
+++
tapestry/tapestry5/trunk/tapestry-core/src/main/resources/org/apache/tapestry5/tapestry.js
Tue Apr 28 21:14:51 2009
@@ -312,7 +312,7 @@
{
var message = response.getHeader("X-Tapestry-ErrorMessage");
-Tapestry.error("Communication with the server failed: " + message);
+Tapestry.error(Tapestry.Messages.communicationFailed + message);
Tapestry.debug(Tapestry.Messages.ajaxFailure + message, response);
},
[jira] Closed: (TAP5-91) Reference component documentation should provide clearer event description
[ https://issues.apache.org/jira/browse/TAP5-91?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Howard M. Lewis Ship closed TAP5-91. Resolution: Duplicate Assignee: Howard M. Lewis Ship Fixed as TAP5-662. > Reference component documentation should provide clearer event description > -- > > Key: TAP5-91 > URL: https://issues.apache.org/jira/browse/TAP5-91 > Project: Tapestry 5 > Issue Type: New Feature >Affects Versions: 5.0.15 >Reporter: Francois Armand >Assignee: Howard M. Lewis Ship > > The reference documentation does not clearly provides the events throws by > the component as it is done for parameter. > For example, in the TextField documentation, not a single events are > described, and even if we look up in the parent's description, I believe some > events are missing (for example, Validate event). > > It would be quite nice to have an array for each component with the list of > all events and their description. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Closed: (TAP5-97) Pluggable strategy for mapping URLs to classes (and back)
[ https://issues.apache.org/jira/browse/TAP5-97?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Howard M. Lewis Ship closed TAP5-97. Resolution: Duplicate Robert has added a URLRewriting service that should address your needs. > Pluggable strategy for mapping URLs to classes (and back) > - > > Key: TAP5-97 > URL: https://issues.apache.org/jira/browse/TAP5-97 > Project: Tapestry 5 > Issue Type: New Feature >Affects Versions: 5.0.15 > Environment: N/A >Reporter: David Peterson >Priority: Minor > > It would be useful to be able to customise the URLs generated by and handled > by Tapestry. > For example, I would like to be able to map the URL "/article" to the > ArticleViewer class, rather than having to create a page class called Article > (which overlaps with the name of my model class). > An alternative is to create a class in the package .../pages/view/ViewArticle > and use the URL "/view/article". But this introduces an extra word into the > URL which is ugly and also the number of slashes in a URL can affect the > page's ranking in some search engines. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (TAP5-143) Add client-side column resizing to grid.
[ https://issues.apache.org/jira/browse/TAP5-143?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12703771#action_12703771 ] Howard M. Lewis Ship commented on TAP5-143: --- The big issue is where to store details about the size of each column and the column ordering so that when the page is refreshed, the grid is back the way it was set. > Add client-side column resizing to grid. > > > Key: TAP5-143 > URL: https://issues.apache.org/jira/browse/TAP5-143 > Project: Tapestry 5 > Issue Type: New Feature >Affects Versions: 5.0.15 > Environment: Any. >Reporter: Daniel >Priority: Minor > > Many applications provide a means of resizing UI columns by > double-clicking/clicking and dragging the border between columns. > Typically a double-click will resize the column to the width of the column's > widest cell, which depends on the content of the cell. Otherwise, clicking > and dragging the border is the means of growing/shrinking the column > depending on where the mouse is released. > Although this can be done through JavaScript, it is common enough > functionality that it seems it should be provided by default. That said, > there should probably also be a way to turn the default resizing off so it > doesn't conflict with any custom resizing functionality, existing or planned > for in Tapestry applications. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Closed: (TAP5-118) Improve debugging "experience" in IDE (java assist)
[ https://issues.apache.org/jira/browse/TAP5-118?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Howard M. Lewis Ship closed TAP5-118. - Resolution: Won't Fix This would require significant changes to Javassist that they seem unwilling or unable to implement. > Improve debugging "experience" in IDE (java assist) > --- > > Key: TAP5-118 > URL: https://issues.apache.org/jira/browse/TAP5-118 > Project: Tapestry 5 > Issue Type: New Feature >Affects Versions: 5.0.15 >Reporter: Ognen Ivanovski >Priority: Minor > > If possible, improve step-into debug info in proxies and bindings. Typical > usage scenarios are: > - trying to step into a binding (the debugger should jump directly into the > getter method) > - trying to step into a call to an injected service or component > - trying to step into a call to a service through a tapestry-ioc proxy > In the last two cases the debugger would > - directly go to the service method implementation > - if the service is not already created it would jump to the service > creation method (or constructor if bind() is used) >- upon return from the creation method / constructor it would directly go > to the service call > The general idea is not to allow the developer to step into java assist code. > This would greatly improve the ease-of-development as well as the > learnability of tapestry (as newbies often resort to the debugger to see > "what's going on inside"). -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (TAP5-159) TapestryFilter should support HTTP 1.1 byte ranges
[ https://issues.apache.org/jira/browse/TAP5-159?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12703769#action_12703769 ] Howard M. Lewis Ship commented on TAP5-159: --- At best, this would be useful for static resources, that is assets, only. > TapestryFilter should support HTTP 1.1 byte ranges > -- > > Key: TAP5-159 > URL: https://issues.apache.org/jira/browse/TAP5-159 > Project: Tapestry 5 > Issue Type: New Feature >Affects Versions: 5.0.15 >Reporter: Hugo Palma > > More and more clients (iPhone and others) are using range requests in order > to optimize bandwidth consumption. > Right now it's not possible to stream content from Tapestry to such a device > because the TapestryFilter doesn't support range requests. The only way to > bypass the filter and serve the stream as static content (from Apache or > whatever). -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Closed: (TAP5-214) Document use of asset: and context: to reference assets directly from a template file
[ https://issues.apache.org/jira/browse/TAP5-214?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Howard M. Lewis Ship closed TAP5-214. - Resolution: Fixed Fix Version/s: 5.1.0.5 > Document use of asset: and context: to reference assets directly from a > template file > - > > Key: TAP5-214 > URL: https://issues.apache.org/jira/browse/TAP5-214 > Project: Tapestry 5 > Issue Type: Improvement >Affects Versions: 5.0.15 >Reporter: Davor Hrg >Assignee: Howard M. Lewis Ship >Priority: Minor > Fix For: 5.1.0.5 > > > tapestry docs' on Assets should have this example along with the one that > explains @Inject @Path.. > binding prefix can be used in templates > > I had to look arround, and try out ... to get this right, > if stated in doc's it would be simple and obvious. > Davor Hrg -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
svn commit: r769481 - /tapestry/tapestry5/trunk/src/site/apt/guide/assets.apt
Author: hlship
Date: Tue Apr 28 17:56:59 2009
New Revision: 769481
URL: http://svn.apache.org/viewvc?rev=769481&view=rev
Log:
TAP5-214: Document use of asset: and context: to reference assets directly from
a template file
Modified:
tapestry/tapestry5/trunk/src/site/apt/guide/assets.apt
Modified: tapestry/tapestry5/trunk/src/site/apt/guide/assets.apt
URL:
http://svn.apache.org/viewvc/tapestry/tapestry5/trunk/src/site/apt/guide/assets.apt?rev=769481&r1=769480&r2=769481&view=diff
==
--- tapestry/tapestry5/trunk/src/site/apt/guide/assets.apt (original)
+++ tapestry/tapestry5/trunk/src/site/apt/guide/assets.apt Tue Apr 28 17:56:59
2009
@@ -27,7 +27,7 @@
private Asset banner;
++
- Assets are located within ; these domains are identified by the
prefix on the Inject annotation's value.
+ Assets are located within ; these domains are identified by the
prefix on the Path annotation's value.
If the prefix is omitted, the value will be interpreted as a path relative
to the Java class file itself, within
the "classpath:" domain. This is often used when creating component
libraries, where the assets used by the components
@@ -37,7 +37,25 @@
to access the underlying files, and those APIs, unlike Tapestry, are case
sensitive. Be aware that some (such as Windows)
are case insenitive, which may mask errors that will be revealed at
deployment (if the deployment operating system is case sensitive,
such as Linux).
-
+
+Assets in Templates
+
+ Assets can also be referenced directly in templates. Two binding prefixes
exist for this: "asset:" and "context:".
+ The "asset:" prefix can obtain assets from the classpath (the default) or
from the web context (by specifying
+ the "context:" domain explicitly):
+
+
+
+
+
+ Because accessing context assets is so common, the "context:" binding prefix
was introduced:
+
+
+
+
+
+
+
Relative Assets
You can use relative paths with domains (if you omit the prefix):
@@ -117,5 +135,15 @@
and therefore will be aggresively cached in the client browser. Changing the
version number changes the path the browser
sees, which forces the browser to load the new and changed version of the
asset.
+ In addition, context assets will use the URL prefix
<<>><<>>.
+
+
+Performance Notes
+
+ Assets are expected to be entirely static (not changing while the
application is deployed). When Tapestry generates a URL
+ for an asset, either on the classpath or from the context, the URL includes
a version number (as discussed in the previous section).
+ Further, the asset will get a , which will
encourage the client browser to cache the
+ asset.
-
\ No newline at end of file
+ In addition, Tapestry will {{{compress.html}GZIP compress}} the content of
assets (if the asset
+ is compressable, and the client supports it).
\ No newline at end of file
[jira] Assigned: (TAP5-214) tapestry docs' on Assets extra examples
[ https://issues.apache.org/jira/browse/TAP5-214?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Howard M. Lewis Ship reassigned TAP5-214: - Assignee: Howard M. Lewis Ship > tapestry docs' on Assets extra examples > --- > > Key: TAP5-214 > URL: https://issues.apache.org/jira/browse/TAP5-214 > Project: Tapestry 5 > Issue Type: Wish >Affects Versions: 5.0.15 >Reporter: Davor Hrg >Assignee: Howard M. Lewis Ship >Priority: Minor > > tapestry docs' on Assets should have this example along with the one that > explains @Inject @Path.. > binding prefix can be used in templates > > I had to look arround, and try out ... to get this right, > if stated in doc's it would be simple and obvious. > Davor Hrg -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (TAP5-214) Document use of asset: and context: to reference assets directly from a template file
[ https://issues.apache.org/jira/browse/TAP5-214?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Howard M. Lewis Ship updated TAP5-214: -- Issue Type: Improvement (was: Wish) Summary: Document use of asset: and context: to reference assets directly from a template file (was: tapestry docs' on Assets extra examples) > Document use of asset: and context: to reference assets directly from a > template file > - > > Key: TAP5-214 > URL: https://issues.apache.org/jira/browse/TAP5-214 > Project: Tapestry 5 > Issue Type: Improvement >Affects Versions: 5.0.15 >Reporter: Davor Hrg >Assignee: Howard M. Lewis Ship >Priority: Minor > > tapestry docs' on Assets should have this example along with the one that > explains @Inject @Path.. > binding prefix can be used in templates > > I had to look arround, and try out ... to get this right, > if stated in doc's it would be simple and obvious. > Davor Hrg -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (TAP5-244) Let Grid show column headings when no data
[ https://issues.apache.org/jira/browse/TAP5-244?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12703767#action_12703767 ] Howard M. Lewis Ship commented on TAP5-244: --- One issue here is that you will need to specify a model explicitly. Currently the Grid component looks at the first object in the source list to identify the bean class and, from that the BeanModel. > Let Grid show column headings when no data > -- > > Key: TAP5-244 > URL: https://issues.apache.org/jira/browse/TAP5-244 > Project: Tapestry 5 > Issue Type: Improvement >Reporter: Geoff Callender >Priority: Minor > > I would like my Grid to show its column headings even when it is empty (and > display the "empty" message below them). I can't see how to do this now. > I've tried null lists and empty lists but the result is the same. > Can this feature be added and made optional? -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (TAP5-266) When component render phase annotation is used the method name should be ignored
[
https://issues.apache.org/jira/browse/TAP5-266?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12703765#action_12703765
]
Howard M. Lewis Ship commented on TAP5-266:
---
A side benefit is that all render phase methods would be handled by a single
worker which might boost performance some minute amount.
> When component render phase annotation is used the method name should be
> ignored
>
>
> Key: TAP5-266
> URL: https://issues.apache.org/jira/browse/TAP5-266
> Project: Tapestry 5
> Issue Type: Bug
> Components: tapestry-core
>Affects Versions: 5.0.15
>Reporter: Hugo Palma
>Priority: Minor
>
> If i have a method like this:
> @AfterRender
> void beginRender()
> {
> }
> it actually gets executed twice. Once during AfterRender and once during
> BeginRender. Although i agree that is bad coding it can cause some confusion
> and make it hard to diagnose.
> In my opinion there should be either an error thrown by Tapestry in this
> situation or it should just ignore the method name when a render phase
> annotation is present.
> Also, i didn't try if this also happens for component events.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (TAP5-286) Add the possibility (as an option) for all generated URL to include the domain and context
[ https://issues.apache.org/jira/browse/TAP5-286?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12703762#action_12703762 ] Howard M. Lewis Ship commented on TAP5-286: --- I don't think this will make it for 5.1 but it's still a good idea. You can kind of cobble together a solution today, but it would be nice if it was a switch. At issue is the fact that, when behind a proxy server, Tapestry will not be able to determine the base URL on its own. > Add the possibility (as an option) for all generated URL to include the > domain and context > -- > > Key: TAP5-286 > URL: https://issues.apache.org/jira/browse/TAP5-286 > Project: Tapestry 5 > Issue Type: New Feature >Affects Versions: 5.0.16 >Reporter: Martin Papy > > Now that we have the possibility to access the Dom and manipulate it easily, > we can use Tapestry to generate email based on Page Rendering... But Tapestry > generate only absolute URL ( without http://mydomain.com/context/ ). > For the moment I do this in the cleanupRender phase : > String mailBody = writer.getDocument().getRootElement.toString(); > And I send the result by mail. > It would be very useful if we could tell Tapestry -maybe with a special > Annotation- that we want for a particular Page/Component all URL / Link to > pages / Link to Assets (and so on) to be fully qualified ( ie not > /assets//yyy.jpg but http(s)://domain.com/context/assets//yyy.jpg ) -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Closed: (TAP5-310) DateField error message "Date is not parsable" should be localizable
[
https://issues.apache.org/jira/browse/TAP5-310?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Howard M. Lewis Ship closed TAP5-310.
-
Resolution: Duplicate
Assignee: Howard M. Lewis Ship
TAP5-310
> DateField error message "Date is not parsable" should be localizable
>
>
> Key: TAP5-310
> URL: https://issues.apache.org/jira/browse/TAP5-310
> Project: Tapestry 5
> Issue Type: Bug
> Components: tapestry-core
>Affects Versions: 5.0.15
>Reporter: Konstantin Miklevskiy
>Assignee: Howard M. Lewis Ship
>Priority: Minor
>
> DateField component localization problem
> catch (ParseException ex)
> {
> tracker.recordError(this, "Date value is not parseable.");
> return;
> }
> "Date value is not parseable" message should be read from properties file.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (TAP5-311) NPE in BeanDisplay if used in a form with a default model
[ https://issues.apache.org/jira/browse/TAP5-311?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Howard M. Lewis Ship closed TAP5-311. - Resolution: Invalid Insufficient detail. > NPE in BeanDisplay if used in a form with a default model > - > > Key: TAP5-311 > URL: https://issues.apache.org/jira/browse/TAP5-311 > Project: Tapestry 5 > Issue Type: Bug > Components: tapestry-core >Affects Versions: 5.0.15 >Reporter: Dan Adams >Priority: Minor > > Create something like this: > > > > and submit the form. You get a NPE in beandisplay. The workaround is to > create the model yourself. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Closed: (TAP5-506) Italian localization for DateField component
[ https://issues.apache.org/jira/browse/TAP5-506?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Howard M. Lewis Ship closed TAP5-506. - Resolution: Fixed Fix Version/s: 5.1.0.5 > Italian localization for DateField component > > > Key: TAP5-506 > URL: https://issues.apache.org/jira/browse/TAP5-506 > Project: Tapestry 5 > Issue Type: Improvement > Components: tapestry-core >Affects Versions: 5.1.0.0, 5.1 >Reporter: Massimo Lusetti >Assignee: Howard M. Lewis Ship > Fix For: 5.1.0.5 > > Attachments: DateField_it.properties > > > Italian localization file for DateField component -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (TAP5-506) Italian localization for DateField component
[ https://issues.apache.org/jira/browse/TAP5-506?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Howard M. Lewis Ship updated TAP5-506: -- Assignee: Howard M. Lewis Ship Summary: Italian localization for DateField component (was: Italian localization for DateFile component) > Italian localization for DateField component > > > Key: TAP5-506 > URL: https://issues.apache.org/jira/browse/TAP5-506 > Project: Tapestry 5 > Issue Type: Improvement > Components: tapestry-core >Affects Versions: 5.1.0.0, 5.1 >Reporter: Massimo Lusetti >Assignee: Howard M. Lewis Ship > Fix For: 5.1.0.5 > > Attachments: DateField_it.properties > > > Italian localization file for DateField component -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
svn commit: r769473 - /tapestry/tapestry5/trunk/tapestry-core/src/main/resources/org/apache/tapestry5/corelib/components/DateField_it.properties
Author: hlship Date: Tue Apr 28 17:18:17 2009 New Revision: 769473 URL: http://svn.apache.org/viewvc?rev=769473&view=rev Log: TAP5-506: Italian localization for DateField component Added: tapestry/tapestry5/trunk/tapestry-core/src/main/resources/org/apache/tapestry5/corelib/components/DateField_it.properties (with props) Added: tapestry/tapestry5/trunk/tapestry-core/src/main/resources/org/apache/tapestry5/corelib/components/DateField_it.properties URL: http://svn.apache.org/viewvc/tapestry/tapestry5/trunk/tapestry-core/src/main/resources/org/apache/tapestry5/corelib/components/DateField_it.properties?rev=769473&view=auto == --- tapestry/tapestry5/trunk/tapestry-core/src/main/resources/org/apache/tapestry5/corelib/components/DateField_it.properties (added) +++ tapestry/tapestry5/trunk/tapestry-core/src/main/resources/org/apache/tapestry5/corelib/components/DateField_it.properties Tue Apr 28 17:18:17 2009 @@ -0,0 +1,15 @@ +# Copyright 2009 The Apache Software Foundation +# +# Licensed under the Apache License, Version 2.0 (the "License"); +# you may not use this file except in compliance with the License. +# You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. + +date-value-not-parseable=Il valore '%s' non è una data accettabile. Propchange: tapestry/tapestry5/trunk/tapestry-core/src/main/resources/org/apache/tapestry5/corelib/components/DateField_it.properties -- svn:eol-style = native
[jira] Closed: (TAP5-579) Finnish internationalization is missing some of the keys in 5.1
[ https://issues.apache.org/jira/browse/TAP5-579?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Howard M. Lewis Ship closed TAP5-579. - Resolution: Fixed Fix Version/s: 5.1.0.5 Assignee: Howard M. Lewis Ship We don't just hand out commit access left and right. Read up on the Apache process. > Finnish internationalization is missing some of the keys in 5.1 > --- > > Key: TAP5-579 > URL: https://issues.apache.org/jira/browse/TAP5-579 > Project: Tapestry 5 > Issue Type: Improvement > Components: tapestry-core >Affects Versions: 5.1.0.1 >Reporter: Ville Virtanen >Assignee: Howard M. Lewis Ship > Fix For: 5.1.0.5 > > > ValidationMessages_fi_FI.properties is missing keys > integer-format-exception= \"%s\" -kentän syötteen pitää olla kokonaisluku. > number-format-exception=\"%s\" -kentän syötteen pitää olla numero. > Ps. Commit rights would be nice so I could do minor changes like this > directly to svn... ;) Also I'm interested in fixin various bugs. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Closed: (TAP5-580) Add get() method to TestBase to allow read access to private fields of objects via reflection
[ https://issues.apache.org/jira/browse/TAP5-580?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Howard M. Lewis Ship closed TAP5-580. - Resolution: Fixed Fix Version/s: 5.1.0.5 > Add get() method to TestBase to allow read access to private fields of > objects via reflection > - > > Key: TAP5-580 > URL: https://issues.apache.org/jira/browse/TAP5-580 > Project: Tapestry 5 > Issue Type: New Feature > Components: tapestry-ioc >Affects Versions: 5.1.0.2 >Reporter: Igor Drobiazko >Assignee: Howard M. Lewis Ship >Priority: Minor > Fix For: 5.1.0.5 > > > Similar to TAP5-275 but for read acces -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
svn commit: r769469 - /tapestry/tapestry5/trunk/tapestry-core/src/main/resources/org/apache/tapestry5/internal/ValidationMessages_fi_FI.properties
Author: hlship Date: Tue Apr 28 17:13:20 2009 New Revision: 769469 URL: http://svn.apache.org/viewvc?rev=769469&view=rev Log: TAP5-579: Finnish internationalization is missing some of the keys in 5.1 Modified: tapestry/tapestry5/trunk/tapestry-core/src/main/resources/org/apache/tapestry5/internal/ValidationMessages_fi_FI.properties Modified: tapestry/tapestry5/trunk/tapestry-core/src/main/resources/org/apache/tapestry5/internal/ValidationMessages_fi_FI.properties URL: http://svn.apache.org/viewvc/tapestry/tapestry5/trunk/tapestry-core/src/main/resources/org/apache/tapestry5/internal/ValidationMessages_fi_FI.properties?rev=769469&r1=769468&r2=769469&view=diff == --- tapestry/tapestry5/trunk/tapestry-core/src/main/resources/org/apache/tapestry5/internal/ValidationMessages_fi_FI.properties (original) +++ tapestry/tapestry5/trunk/tapestry-core/src/main/resources/org/apache/tapestry5/internal/ValidationMessages_fi_FI.properties Tue Apr 28 17:13:20 2009 @@ -1,4 +1,4 @@ -# Copyright 2006, 2007 The Apache Software Foundation +# Copyright 2006, 2007, 2009 The Apache Software Foundation # # Licensed under the Apache License, Version 2.0 (the "License"); # you may not use this file except in compliance with the License. @@ -26,4 +26,7 @@ regexp=%2$s ei vastaa merkkijonoa '%1$s'. invalid-email='%s' ei ole s\u00E4hk\u00F6postiosoite. +integer-format-exception= \"%s\" -kentn sytteen pit olla kokonaisluku. +number-format-exception=\"%s\" -kentn sytteen pit olla numero. + # This is where the translator messages go.
svn commit: r769468 - in /tapestry/tapestry5/trunk/tapestry-ioc/src: main/java/org/apache/tapestry5/ioc/test/TestBase.java test/java/org/apache/tapestry5/ioc/test/TestBaseTest.java
Author: hlship
Date: Tue Apr 28 17:11:34 2009
New Revision: 769468
URL: http://svn.apache.org/viewvc?rev=769468&view=rev
Log:
TAP5-580: Add get() method to TestBase to allow read access to private fields
of objects via reflection
Modified:
tapestry/tapestry5/trunk/tapestry-ioc/src/main/java/org/apache/tapestry5/ioc/test/TestBase.java
tapestry/tapestry5/trunk/tapestry-ioc/src/test/java/org/apache/tapestry5/ioc/test/TestBaseTest.java
Modified:
tapestry/tapestry5/trunk/tapestry-ioc/src/main/java/org/apache/tapestry5/ioc/test/TestBase.java
URL:
http://svn.apache.org/viewvc/tapestry/tapestry5/trunk/tapestry-ioc/src/main/java/org/apache/tapestry5/ioc/test/TestBase.java?rev=769468&r1=769467&r2=769468&view=diff
==
---
tapestry/tapestry5/trunk/tapestry-ioc/src/main/java/org/apache/tapestry5/ioc/test/TestBase.java
(original)
+++
tapestry/tapestry5/trunk/tapestry-ioc/src/main/java/org/apache/tapestry5/ioc/test/TestBase.java
Tue Apr 28 17:11:34 2009
@@ -277,6 +277,35 @@
return object;
}
+/**
+ * Reads the content of a private field.
+ *
+ * @param objectto read the private field from
+ * @param fieldName name of field to read
+ * @return value stored in the field
+ * @since 5.1.0.5
+ */
+protected static Object get(Object object, String fieldName)
+{
+Defense.notNull(object, "object");
+Defense.notBlank(fieldName, "fieldName");
+
+try
+{
+Field field = findField(object.getClass(), fieldName);
+
+field.setAccessible(true);
+
+return field.get(object);
+}
+catch (Exception ex)
+{
+throw new RuntimeException(String.format("Unable to read field
'%s' of %s: %s",
+ fieldName, object,
+
InternalUtils.toMessage(ex)), ex);
+}
+}
+
private static Field findField(Class objectClass, String fieldName)
{
Modified:
tapestry/tapestry5/trunk/tapestry-ioc/src/test/java/org/apache/tapestry5/ioc/test/TestBaseTest.java
URL:
http://svn.apache.org/viewvc/tapestry/tapestry5/trunk/tapestry-ioc/src/test/java/org/apache/tapestry5/ioc/test/TestBaseTest.java?rev=769468&r1=769467&r2=769468&view=diff
==
---
tapestry/tapestry5/trunk/tapestry-ioc/src/test/java/org/apache/tapestry5/ioc/test/TestBaseTest.java
(original)
+++
tapestry/tapestry5/trunk/tapestry-ioc/src/test/java/org/apache/tapestry5/ioc/test/TestBaseTest.java
Tue Apr 28 17:11:34 2009
@@ -77,4 +77,36 @@
assertEquals(b.isFlag(), true);
assertEquals(b.getValue(), "magic");
}
+
+@Test
+public void get_field()
+{
+Bean b = new Bean();
+
+String expectedValue = "fred";
+
+set(b, "value", expectedValue);
+
+assertSame(b.getValue(), expectedValue);
+assertSame(get(b, "value"), expectedValue);
+}
+
+@Test
+public void error_getting_field()
+{
+Bean b = new Bean();
+
+try
+{
+get(b, "missingField");
+unreachable();
+}
+catch (RuntimeException ex)
+{
+assertMessageContains(ex,
+ "Unable to read field 'missingField' of
org.apache.tapestry5.ioc.test.Bean",
+ "Class org.apache.tapestry5.ioc.test.Bean
does not contain a field named 'missingField'.");
+
+}
+}
}
[jira] Updated: (TAP5-580) Add get() method to TestBase to allow read access to private fields of objects via reflection
[ https://issues.apache.org/jira/browse/TAP5-580?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Howard M. Lewis Ship updated TAP5-580: -- Summary: Add get() method to TestBase to allow read access to private fields of objects via reflection (was: Add get() method to TestBase to allow the read access to private fields of objects via reflection) > Add get() method to TestBase to allow read access to private fields of > objects via reflection > - > > Key: TAP5-580 > URL: https://issues.apache.org/jira/browse/TAP5-580 > Project: Tapestry 5 > Issue Type: New Feature > Components: tapestry-ioc >Affects Versions: 5.1.0.2 >Reporter: Igor Drobiazko >Assignee: Howard M. Lewis Ship >Priority: Minor > > Similar to TAP5-275 but for read acces -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (TAP5-580) Add get() method to TestBase to allow the read access to private fields of objects via reflection
[ https://issues.apache.org/jira/browse/TAP5-580?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Howard M. Lewis Ship updated TAP5-580: -- Summary: Add get() method to TestBase to allow the read access to private fields of objects via reflection (was: Add get() method to TestBase to allow the read acces to private fields of objects via reflection) > Add get() method to TestBase to allow the read access to private fields of > objects via reflection > - > > Key: TAP5-580 > URL: https://issues.apache.org/jira/browse/TAP5-580 > Project: Tapestry 5 > Issue Type: New Feature > Components: tapestry-ioc >Affects Versions: 5.1.0.2 >Reporter: Igor Drobiazko >Assignee: Howard M. Lewis Ship >Priority: Minor > > Similar to TAP5-275 but for read acces -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Assigned: (TAP5-580) Add get() method to TestBase to allow the read acces to private fields of objects via reflection
[ https://issues.apache.org/jira/browse/TAP5-580?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Howard M. Lewis Ship reassigned TAP5-580: - Assignee: Howard M. Lewis Ship (was: Igor Drobiazko) > Add get() method to TestBase to allow the read acces to private fields of > objects via reflection > > > Key: TAP5-580 > URL: https://issues.apache.org/jira/browse/TAP5-580 > Project: Tapestry 5 > Issue Type: New Feature > Components: tapestry-ioc >Affects Versions: 5.1.0.2 >Reporter: Igor Drobiazko >Assignee: Howard M. Lewis Ship >Priority: Minor > > Similar to TAP5-275 but for read acces -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Assigned: (TAP5-604) ValidationMessages_da.properties contains invalid format strings
[ https://issues.apache.org/jira/browse/TAP5-604?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Howard M. Lewis Ship reassigned TAP5-604: - Assignee: Howard M. Lewis Ship > ValidationMessages_da.properties contains invalid format strings > > > Key: TAP5-604 > URL: https://issues.apache.org/jira/browse/TAP5-604 > Project: Tapestry 5 > Issue Type: Bug > Components: tapestry-core >Affects Versions: 5.0.18 >Reporter: Hannes Heijkenskjöld >Assignee: Howard M. Lewis Ship >Priority: Trivial > Fix For: 5.1.0.5 > > > The ValidationMessages_da.properties contains two invalid formatter strings: > minimum-string-length=%$2s skal mindst være på %1$d tegn. > maximum-string-length=%$2s må højst være på %1$d tegn. > Note the %$2s . It should be %2$s like the other format strings. This gave me > the following root cause message: > Caused by: java.util.UnknownFormatConversionException: Conversion = '$' > at java.util.Formatter.checkText(Formatter.java:2502) > at java.util.Formatter.parse(Formatter.java:2466) > at java.util.Formatter.format(Formatter.java:2413) > at java.util.Formatter.format(Formatter.java:2366) > at java.lang.String.format(String.java:2814) > at > org.apache.tapestry5.ioc.internal.util.MessageFormatterImpl.format(MessageFormatterImpl.java:49) > at > org.apache.tapestry5.validator.MinLength.buildMessage(MinLength.java:42) > at org.apache.tapestry5.validator.MinLength.render(MinLength.java:48) > at org.apache.tapestry5.validator.MinLength.render(MinLength.java:26) > at > org.apache.tapestry5.internal.services.FieldValidatorImpl.render(FieldValidatorImpl.java:56) > at > org.apache.tapestry5.internal.services.CompositeFieldValidator.render(CompositeFieldValidator.java:45) > at > org.apache.tapestry5.corelib.base.AbstractTextField.begin(AbstractTextField.java:172) > at > org.apache.tapestry5.corelib.base.AbstractTextField.beginRender(AbstractTextField.java) > at > org.apache.tapestry5.internal.structure.ComponentPageElementImpl$11$1.run(ComponentPageElementImpl.java:352) > at > org.apache.tapestry5.internal.structure.ComponentPageElementImpl.invoke(ComponentPageElementImpl.java:925) > ... 123 more -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Closed: (TAP5-604) ValidationMessages_da.properties contains invalid format strings
[ https://issues.apache.org/jira/browse/TAP5-604?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Howard M. Lewis Ship closed TAP5-604. - Resolution: Fixed Fix Version/s: 5.1.0.5 > ValidationMessages_da.properties contains invalid format strings > > > Key: TAP5-604 > URL: https://issues.apache.org/jira/browse/TAP5-604 > Project: Tapestry 5 > Issue Type: Bug > Components: tapestry-core >Affects Versions: 5.0.18 >Reporter: Hannes Heijkenskjöld >Assignee: Howard M. Lewis Ship >Priority: Trivial > Fix For: 5.1.0.5 > > > The ValidationMessages_da.properties contains two invalid formatter strings: > minimum-string-length=%$2s skal mindst være på %1$d tegn. > maximum-string-length=%$2s må højst være på %1$d tegn. > Note the %$2s . It should be %2$s like the other format strings. This gave me > the following root cause message: > Caused by: java.util.UnknownFormatConversionException: Conversion = '$' > at java.util.Formatter.checkText(Formatter.java:2502) > at java.util.Formatter.parse(Formatter.java:2466) > at java.util.Formatter.format(Formatter.java:2413) > at java.util.Formatter.format(Formatter.java:2366) > at java.lang.String.format(String.java:2814) > at > org.apache.tapestry5.ioc.internal.util.MessageFormatterImpl.format(MessageFormatterImpl.java:49) > at > org.apache.tapestry5.validator.MinLength.buildMessage(MinLength.java:42) > at org.apache.tapestry5.validator.MinLength.render(MinLength.java:48) > at org.apache.tapestry5.validator.MinLength.render(MinLength.java:26) > at > org.apache.tapestry5.internal.services.FieldValidatorImpl.render(FieldValidatorImpl.java:56) > at > org.apache.tapestry5.internal.services.CompositeFieldValidator.render(CompositeFieldValidator.java:45) > at > org.apache.tapestry5.corelib.base.AbstractTextField.begin(AbstractTextField.java:172) > at > org.apache.tapestry5.corelib.base.AbstractTextField.beginRender(AbstractTextField.java) > at > org.apache.tapestry5.internal.structure.ComponentPageElementImpl$11$1.run(ComponentPageElementImpl.java:352) > at > org.apache.tapestry5.internal.structure.ComponentPageElementImpl.invoke(ComponentPageElementImpl.java:925) > ... 123 more -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
svn commit: r769464 - /tapestry/tapestry5/trunk/tapestry-core/src/main/resources/org/apache/tapestry5/internal/ValidationMessages_da.properties
Author: hlship Date: Tue Apr 28 17:02:43 2009 New Revision: 769464 URL: http://svn.apache.org/viewvc?rev=769464&view=rev Log: TAP5-604: ValidationMessages_da.properties contains invalid format strings Modified: tapestry/tapestry5/trunk/tapestry-core/src/main/resources/org/apache/tapestry5/internal/ValidationMessages_da.properties Modified: tapestry/tapestry5/trunk/tapestry-core/src/main/resources/org/apache/tapestry5/internal/ValidationMessages_da.properties URL: http://svn.apache.org/viewvc/tapestry/tapestry5/trunk/tapestry-core/src/main/resources/org/apache/tapestry5/internal/ValidationMessages_da.properties?rev=769464&r1=769463&r2=769464&view=diff == --- tapestry/tapestry5/trunk/tapestry-core/src/main/resources/org/apache/tapestry5/internal/ValidationMessages_da.properties (original) +++ tapestry/tapestry5/trunk/tapestry-core/src/main/resources/org/apache/tapestry5/internal/ValidationMessages_da.properties Tue Apr 28 17:02:43 2009 @@ -17,8 +17,8 @@ # we must use specific indexing when that's not the best order. required=%s skal udfyldes. -minimum-string-length=%$2s skal mindst være på %1$d tegn. -maximum-string-length=%$2s må højst være på %1$d tegn. +minimum-string-length=%2$s skal mindst være på %1$d tegn. +maximum-string-length=%2$s må højst være på %1$d tegn. min-integer=%2$s skal være mindst %1$d. max-integer=%2$s må højst være %1$d. # This is lousy as a default, since the pattern string is meaningless to the user. You should always override
[jira] Commented: (TAP5-637) There should be a javascript counterpart for the URLEncoder service
[ https://issues.apache.org/jira/browse/TAP5-637?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12703738#action_12703738 ] Howard M. Lewis Ship commented on TAP5-637: --- A comment in the JS won't really help when the application stops working. I don't see me using this as is. The client shouldn't be building URLs ... at most, it should be tacking query parameters onto framework-generated URLs. In extereme cases, you should provide your own Dispatcher and build a URL to the Dispatcher, not to a page or component. > There should be a javascript counterpart for the URLEncoder service > --- > > Key: TAP5-637 > URL: https://issues.apache.org/jira/browse/TAP5-637 > Project: Tapestry 5 > Issue Type: New Feature > Components: tapestry-core >Reporter: Hugo Palma >Priority: Minor > Attachments: url-encoder.js > > > This is very useful if you want to build event urls in javascript. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (TAP5-651) If component documentation: identify the use of the p: namespace
[ https://issues.apache.org/jira/browse/TAP5-651?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Howard M. Lewis Ship updated TAP5-651: -- Summary: If component documentation: identify the use of the p: namespace (was: Documentation for if component needs expanding) A slippery slope ... should we add such a note everywhere? Well, If is a "workhorse" component: used early and often, so if we catch people's attention there, we probably won't have to repeat ourselves everywhere else in the documentation. > If component documentation: identify the use of the p: namespace > > > Key: TAP5-651 > URL: https://issues.apache.org/jira/browse/TAP5-651 > Project: Tapestry 5 > Issue Type: Improvement > Components: documentation >Affects Versions: 5.1.0.4 >Reporter: Andy Blower >Priority: Minor > Fix For: 5.1.0.5 > > > Use of new block in the example for the if component is confusing > because there's nothing to draw an ex-5.0 developer to the addition in the > container tag attributes for the parameter namespace definition. It would > also be nice to explain the syntax for an else block without the new > container tag attribute, if there actually is a way of course. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Closed: (TAP5-651) If component documentation: identify the use of the p: namespace
[ https://issues.apache.org/jira/browse/TAP5-651?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Howard M. Lewis Ship closed TAP5-651. - Resolution: Fixed Fix Version/s: 5.1.0.5 > If component documentation: identify the use of the p: namespace > > > Key: TAP5-651 > URL: https://issues.apache.org/jira/browse/TAP5-651 > Project: Tapestry 5 > Issue Type: Improvement > Components: documentation >Affects Versions: 5.1.0.4 >Reporter: Andy Blower >Priority: Minor > Fix For: 5.1.0.5 > > > Use of new block in the example for the if component is confusing > because there's nothing to draw an ex-5.0 developer to the addition in the > container tag attributes for the parameter namespace definition. It would > also be nice to explain the syntax for an else block without the new > container tag attribute, if there actually is a way of course. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Closed: (TAP5-645) Regexp Validator missbehaviour with comma in regular expression
[
https://issues.apache.org/jira/browse/TAP5-645?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Howard M. Lewis Ship closed TAP5-645.
-
Resolution: Duplicate
> Regexp Validator missbehaviour with comma in regular expression
> ---
>
> Key: TAP5-645
> URL: https://issues.apache.org/jira/browse/TAP5-645
> Project: Tapestry 5
> Issue Type: Bug
> Components: tapestry-core
>Affects Versions: 5.0.18
>Reporter: Stefan Esterer
>Priority: Minor
>
> The Regexp Validator has problems with expressions containg a comma.
> e.g.
> @Validate("required,regexp=\\d{1\\,3}(\\.\\d{1\\,2})?")
> String getFoo();
> This regular expression does not work with the regexp validator, because the
> ValidateAnnotationConstraintGenerator splits the annotation value with ",".
> "return Arrays.asList(annotation.value().split(","));"
> Concequence is a uncomplete input string ( from index 0 to the first
> occurence of the ",") for the coercer from String.class to Pattern.class.
> This causes a java.util.regex.PatternSyntaxException.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
svn commit: r769461 - /tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/corelib/components/If.xdoc
Author: hlship Date: Tue Apr 28 16:57:47 2009 New Revision: 769461 URL: http://svn.apache.org/viewvc?rev=769461&view=rev Log: TAP5-651: If component documentation: identify the use of the p: namespace Modified: tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/corelib/components/If.xdoc Modified: tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/corelib/components/If.xdoc URL: http://svn.apache.org/viewvc/tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/corelib/components/If.xdoc?rev=769461&r1=769460&r2=769461&view=diff == --- tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/corelib/components/If.xdoc (original) +++ tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/corelib/components/If.xdoc Tue Apr 28 16:57:47 2009 @@ -5,7 +5,7 @@
[jira] Commented: (TAP5-667) Site build fails inside tapestry-hibernate-core
[ https://issues.apache.org/jira/browse/TAP5-667?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12703728#action_12703728 ] Howard M. Lewis Ship commented on TAP5-667: --- Temporarily disabled Cobetura report, but I'd rather find a real solution. > Site build fails inside tapestry-hibernate-core > --- > > Key: TAP5-667 > URL: https://issues.apache.org/jira/browse/TAP5-667 > Project: Tapestry 5 > Issue Type: Bug > Components: tapestry-hibernate >Affects Versions: 5.1.0.4 >Reporter: Howard M. Lewis Ship > > Not sure why this happens on my Mac when I do a release build, but not on the > Bamboo server for nightly builds! > [INFO] > > [INFO] Building Tapestry Hibernate Support > [INFO]task-segment: [site, site:deploy] > [INFO] > > [INFO] Preparing cobertura:cobertura > [INFO] [resources:resources] > [INFO] Using 'UTF-8' encoding to copy filtered resources. > [INFO] Copying 1 resource > [INFO] [compiler:compile] > [INFO] Nothing to compile - all classes are up to date > [INFO] [cobertura:instrument] > [INFO] Cobertura 1.9 - GNU GPL License (NO WARRANTY) - See COPYRIGHT file > Instrumenting 22 files to > /Users/Howard/work/tapestry5/tapestry-hibernate-core/target/generated-classes/cobertura > Cobertura: Saved information on 22 classes. > Instrument time: 193ms > [INFO] Instrumentation was successful. > [INFO] [resources:testResources] > [INFO] Using 'UTF-8' encoding to copy filtered resources. > [INFO] Copying 2 resources > [INFO] [compiler:testCompile] > [INFO] Compiling 4 source files to > /Users/Howard/work/tapestry5/tapestry-hibernate-core/target/test-classes > [INFO] > > [ERROR] BUILD FAILURE > [INFO] > > [INFO] Compilation failure > /Users/Howard/work/tapestry5/tapestry-hibernate-core/src/test/java/org/apache/tapestry5/internal/hibernate/HibernateSessionSourceImplTest.java:[52,57] > incompatible types > found : > java.util.List > required: java.util.List > [INFO] > > [INFO] For more information, run Maven with the -e switch > [INFO] > > [INFO] Total time: 20 minutes 56 seconds > [INFO] Finished at: Mon Apr 27 11:43:15 PDT 2009 > [INFO] Final Memory: 51M/98M > [INFO] > > ~/work/tapestry5 -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Closed: (TAP5-668) BeanModel documentation should be more clear that a property must exist when using add(String).
[
https://issues.apache.org/jira/browse/TAP5-668?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Howard M. Lewis Ship closed TAP5-668.
-
Resolution: Fixed
Fix Version/s: 5.1.0.5
Added a test (to ensure that you get a valid, useful exception -- not a NPE)
and updated the JavaDoc on BeanModel to better identify what the methods do.
> BeanModel documentation should be more clear that a property must exist when
> using add(String).
> ---
>
> Key: TAP5-668
> URL: https://issues.apache.org/jira/browse/TAP5-668
> Project: Tapestry 5
> Issue Type: Bug
> Components: tapestry-core
>Affects Versions: 5.0.18
>Reporter: Charles Fineman
>Assignee: Howard M. Lewis Ship
>Priority: Minor
> Fix For: 5.1.0.5
>
>
> Following examples I've found on the web I created the following method in a
> Page class so I could have additional columns appear in the grid component:
> public BeanModel getModel()
> {
> BeanModel model =
> beanModelSource.createDisplayModel(Experiment.class, resources.getMessages());
> model.add("edit");
> model.add("delete");
> return model;
> }
> A RuntimeException is throw within the call to model.add("edit"). It
> complains that the "edit" property does not exist. If I pass 'null' as the
> conduit (i.e. model.add("edit", null) ) It works fine.
> The JavaDoc seems to indicate that I can just add a new property to the model
> using the original form of the call but it seems to not working that way in
> 5.0.18.
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (TAP5-668) BeanModel documentation should be more clear that a property must exist when using add(String).
[
https://issues.apache.org/jira/browse/TAP5-668?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Howard M. Lewis Ship updated TAP5-668:
--
Summary: BeanModel documentation should be more clear that a property must
exist when using add(String). (was: BeanModel throws exception when adding new
field to model)
> BeanModel documentation should be more clear that a property must exist when
> using add(String).
> ---
>
> Key: TAP5-668
> URL: https://issues.apache.org/jira/browse/TAP5-668
> Project: Tapestry 5
> Issue Type: Bug
> Components: tapestry-core
>Affects Versions: 5.0.18
>Reporter: Charles Fineman
>Assignee: Howard M. Lewis Ship
>Priority: Minor
>
> Following examples I've found on the web I created the following method in a
> Page class so I could have additional columns appear in the grid component:
> public BeanModel getModel()
> {
> BeanModel model =
> beanModelSource.createDisplayModel(Experiment.class, resources.getMessages());
> model.add("edit");
> model.add("delete");
> return model;
> }
> A RuntimeException is throw within the call to model.add("edit"). It
> complains that the "edit" property does not exist. If I pass 'null' as the
> conduit (i.e. model.add("edit", null) ) It works fine.
> The JavaDoc seems to indicate that I can just add a new property to the model
> using the original form of the call but it seems to not working that way in
> 5.0.18.
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
svn commit: r769459 - in /tapestry/tapestry5/trunk/tapestry-core/src: main/java/org/apache/tapestry5/beaneditor/BeanModel.java test/java/org/apache/tapestry5/internal/services/BeanModelSourceImplTest.
Author: hlship
Date: Tue Apr 28 16:53:27 2009
New Revision: 769459
URL: http://svn.apache.org/viewvc?rev=769459&view=rev
Log:
TAP5-668: BeanModel documentation should be more clear that a property must
exist when using add(String).
Modified:
tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/beaneditor/BeanModel.java
tapestry/tapestry5/trunk/tapestry-core/src/test/java/org/apache/tapestry5/internal/services/BeanModelSourceImplTest.java
Modified:
tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/beaneditor/BeanModel.java
URL:
http://svn.apache.org/viewvc/tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/beaneditor/BeanModel.java?rev=769459&r1=769458&r2=769459&view=diff
==
---
tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/beaneditor/BeanModel.java
(original)
+++
tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/beaneditor/BeanModel.java
Tue Apr 28 16:53:27 2009
@@ -1,4 +1,4 @@
-// Copyright 2007, 2008 The Apache Software Foundation
+// Copyright 2007, 2008, 2009 The Apache Software Foundation
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
@@ -70,7 +70,9 @@
/**
* Adds a new property to the model, returning its mutable model for
further refinement. The property is added to
- * the end of the list of properties.
+ * the end of the list of properties. The property must be real
(but may have been excluded if there was no
+ * {...@linkplain org.apache.tapestry5.beaneditor.DataType datatype}
associated with the property). To add a synthetic
+ * property, use {...@link #add(String,
org.apache.tapestry5.PropertyConduit)}
*
* @param propertyName name of property to add
* @return the new property model (for further configuration)
@@ -79,7 +81,7 @@
PropertyModel add(String propertyName);
/**
- * Adds a new property to the model, ordered before or after an existing
property.
+ * Adds a new property to the model (as with {...@link #add(String)}),
ordered before or after an existing property.
*
* @param position controls whether the new property is
ordered before or after the existing property
* @param existingPropertyName the name of an existing property (this must
exist)
@@ -104,7 +106,7 @@
PropertyConduit conduit);
/**
- * Adds a new property to the model, returning its mutable model for
further refinement.
+ * Adds a new, synthetic property to the model, returning its mutable
model for further refinement.
*
* @param propertyName name of property to add
* @param conduit the conduit used to read or update the property;
this may be null for a synthetic or
Modified:
tapestry/tapestry5/trunk/tapestry-core/src/test/java/org/apache/tapestry5/internal/services/BeanModelSourceImplTest.java
URL:
http://svn.apache.org/viewvc/tapestry/tapestry5/trunk/tapestry-core/src/test/java/org/apache/tapestry5/internal/services/BeanModelSourceImplTest.java?rev=769459&r1=769458&r2=769459&view=diff
==
---
tapestry/tapestry5/trunk/tapestry-core/src/test/java/org/apache/tapestry5/internal/services/BeanModelSourceImplTest.java
(original)
+++
tapestry/tapestry5/trunk/tapestry-core/src/test/java/org/apache/tapestry5/internal/services/BeanModelSourceImplTest.java
Tue Apr 28 16:53:27 2009
@@ -1,4 +1,4 @@
-// Copyright 2007, 2008 The Apache Software Foundation
+// Copyright 2007, 2008, 2009 The Apache Software Foundation
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
@@ -460,7 +460,7 @@
assertSame(propertyModel.getPropertyType(), String[].class);
-String[] value = {"foo", "bar"};
+String[] value = { "foo", "bar" };
StringArrayBean bean = new StringArrayBean();
@@ -554,6 +554,30 @@
}
@Test
+public void add_missing_property_is_failure()
+{
+Messages messages = mockMessages();
+
+stub_contains(messages, false);
+
+replay();
+
+BeanModel model = source.create(SimpleBean.class, true, messages);
+
+try
+{
+model.add("doesNotExist");
+unreachable();
+}
+catch (PropertyExpressionException ex)
+{
+assertMessageContains(ex, "does not contain a property named
'doesNotExist'");
+}
+
+verify();
+}
+
+@Test
public void exclude_property()
{
Messages messages = mockMessages();
[jira] Assigned: (TAP5-668) BeanModel throws exception when adding new field to model
[
https://issues.apache.org/jira/browse/TAP5-668?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Howard M. Lewis Ship reassigned TAP5-668:
-
Assignee: Howard M. Lewis Ship
> BeanModel throws exception when adding new field to model
> -
>
> Key: TAP5-668
> URL: https://issues.apache.org/jira/browse/TAP5-668
> Project: Tapestry 5
> Issue Type: Bug
> Components: tapestry-core
>Affects Versions: 5.0.18
>Reporter: Charles Fineman
>Assignee: Howard M. Lewis Ship
>Priority: Minor
>
> Following examples I've found on the web I created the following method in a
> Page class so I could have additional columns appear in the grid component:
> public BeanModel getModel()
> {
> BeanModel model =
> beanModelSource.createDisplayModel(Experiment.class, resources.getMessages());
> model.add("edit");
> model.add("delete");
> return model;
> }
> A RuntimeException is throw within the call to model.add("edit"). It
> complains that the "edit" property does not exist. If I pass 'null' as the
> conduit (i.e. model.add("edit", null) ) It works fine.
> The JavaDoc seems to indicate that I can just add a new property to the model
> using the original form of the call but it seems to not working that way in
> 5.0.18.
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (TAP5-669) All services related to the old ApplicationState concept should be renamed to use the new SessionState naming
[ https://issues.apache.org/jira/browse/TAP5-669?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Howard M. Lewis Ship updated TAP5-669: -- Description: 5.1.0.4 introduced the renaming of ApplicationState to SessionState. But there are some services that use the same naming and that were not renamed leaving the concept and the service names in an inconsistent state. >From a quick search i could find the following: - ApplicationStateAdapter - ApplicationStateContribution - ApplicationStateCreator - ApplicationStateManager - ApplicationStatePersistenceStrategy - ApplicationStatePersistenceStrategySource - ApplicationStateWorker was: 5.1.0.4 introduced the renaming of ApplicationState to SessionState. But there are some services that use the same naming and that were not renamed leaving the concept and the service names in an inconsistence state. >From a quick search i could find the following: - ApplicationStateAdapter - ApplicationStateContribution - ApplicationStateCreator - ApplicationStateManager - ApplicationStatePersistenceStrategy - ApplicationStatePersistenceStrategySource - ApplicationStateWorker Those are all public APIs and changing them is difficult, especially when we bring service contributions into play. I think we'll need some IoC changes before we can support renaming services in this way ... alternately, we need a complex way of keeping the existing classes and services, and merging them into the new ones. > All services related to the old ApplicationState concept should be renamed to > use the new SessionState naming > - > > Key: TAP5-669 > URL: https://issues.apache.org/jira/browse/TAP5-669 > Project: Tapestry 5 > Issue Type: Improvement > Components: tapestry-core >Affects Versions: 5.1.0.4 >Reporter: Hugo Palma > > 5.1.0.4 introduced the renaming of ApplicationState to SessionState. But > there are some services that use the same naming and that were not renamed > leaving the concept and the service names in an inconsistent state. > From a quick search i could find the following: > - ApplicationStateAdapter > - ApplicationStateContribution > - ApplicationStateCreator > - ApplicationStateManager > - ApplicationStatePersistenceStrategy > - ApplicationStatePersistenceStrategySource > - ApplicationStateWorker -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (TAP5-669) All services related to the old ApplicationState concept should be renamed to use the new SessionState naming
[ https://issues.apache.org/jira/browse/TAP5-669?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Howard M. Lewis Ship updated TAP5-669: -- Priority: Minor (was: Major) > All services related to the old ApplicationState concept should be renamed to > use the new SessionState naming > - > > Key: TAP5-669 > URL: https://issues.apache.org/jira/browse/TAP5-669 > Project: Tapestry 5 > Issue Type: Improvement > Components: tapestry-core >Affects Versions: 5.1.0.4 >Reporter: Hugo Palma >Priority: Minor > > 5.1.0.4 introduced the renaming of ApplicationState to SessionState. But > there are some services that use the same naming and that were not renamed > leaving the concept and the service names in an inconsistent state. > From a quick search i could find the following: > - ApplicationStateAdapter > - ApplicationStateContribution > - ApplicationStateCreator > - ApplicationStateManager > - ApplicationStatePersistenceStrategy > - ApplicationStatePersistenceStrategySource > - ApplicationStateWorker -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Closed: (TAP5-670) ParallelExecutorTest can't be compiled due to cast errors
[ https://issues.apache.org/jira/browse/TAP5-670?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Howard M. Lewis Ship closed TAP5-670. - Resolution: Fixed Fix Version/s: 5.1.0.5 > ParallelExecutorTest can't be compiled due to cast errors > - > > Key: TAP5-670 > URL: https://issues.apache.org/jira/browse/TAP5-670 > Project: Tapestry 5 > Issue Type: Bug > Components: tapestry-ioc >Affects Versions: 5.1.0.5 >Reporter: Ulrich Stärk >Assignee: Howard M. Lewis Ship >Priority: Minor > Fix For: 5.1.0.5 > > Attachments: patch.txt > > > As already stated in http://markmail.org/thread/sybprqs5yeuzobyr > ParallelExecutorTest won't compile due to cast errors. That's because the > Invokable isn't being given a type argument of type StringHolder and > therefore it tries to add an Object to the thunks list were it should add a > StringHolder. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (TAP5-670) ParallelExecutorTest can't be compiled due to cast errors
[ https://issues.apache.org/jira/browse/TAP5-670?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Howard M. Lewis Ship updated TAP5-670: -- Priority: Minor (was: Major) > ParallelExecutorTest can't be compiled due to cast errors > - > > Key: TAP5-670 > URL: https://issues.apache.org/jira/browse/TAP5-670 > Project: Tapestry 5 > Issue Type: Bug > Components: tapestry-ioc >Affects Versions: 5.1.0.5 >Reporter: Ulrich Stärk >Assignee: Howard M. Lewis Ship >Priority: Minor > Fix For: 5.1.0.5 > > Attachments: patch.txt > > > As already stated in http://markmail.org/thread/sybprqs5yeuzobyr > ParallelExecutorTest won't compile due to cast errors. That's because the > Invokable isn't being given a type argument of type StringHolder and > therefore it tries to add an Object to the thunks list were it should add a > StringHolder. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
svn commit: r769454 - in /tapestry/tapestry5/trunk: tapestry-hibernate-core/pom.xml tapestry-ioc/src/test/java/org/apache/tapestry5/ioc/internal/services/ParallelExecutorTest.java
Author: hlship
Date: Tue Apr 28 16:39:54 2009
New Revision: 769454
URL: http://svn.apache.org/viewvc?rev=769454&view=rev
Log:
TAP5-670: ParallelExecutorTest can't be compiled due to cast errors
Modified:
tapestry/tapestry5/trunk/tapestry-hibernate-core/pom.xml
tapestry/tapestry5/trunk/tapestry-ioc/src/test/java/org/apache/tapestry5/ioc/internal/services/ParallelExecutorTest.java
Modified: tapestry/tapestry5/trunk/tapestry-hibernate-core/pom.xml
URL:
http://svn.apache.org/viewvc/tapestry/tapestry5/trunk/tapestry-hibernate-core/pom.xml?rev=769454&r1=769453&r2=769454&view=diff
==
--- tapestry/tapestry5/trunk/tapestry-hibernate-core/pom.xml (original)
+++ tapestry/tapestry5/trunk/tapestry-hibernate-core/pom.xml Tue Apr 28
16:39:54 2009
@@ -155,11 +155,11 @@
-
-org.codehaus.mojo
-cobertura-maven-plugin
-${cobertura-plugin-version}
-
+
org.apache.maven.plugins
Modified:
tapestry/tapestry5/trunk/tapestry-ioc/src/test/java/org/apache/tapestry5/ioc/internal/services/ParallelExecutorTest.java
URL:
http://svn.apache.org/viewvc/tapestry/tapestry5/trunk/tapestry-ioc/src/test/java/org/apache/tapestry5/ioc/internal/services/ParallelExecutorTest.java?rev=769454&r1=769453&r2=769454&view=diff
==
---
tapestry/tapestry5/trunk/tapestry-ioc/src/test/java/org/apache/tapestry5/ioc/internal/services/ParallelExecutorTest.java
(original)
+++
tapestry/tapestry5/trunk/tapestry-ioc/src/test/java/org/apache/tapestry5/ioc/internal/services/ParallelExecutorTest.java
Tue Apr 28 16:39:54 2009
@@ -39,9 +39,9 @@
{
final String value = String.format("Value[%d]", i);
-Invokable inv = new Invokable()
+Invokable inv = new Invokable()
{
-public Object invoke()
+public StringHolder invoke()
{
StringHolder holder = new StringHolderImpl();
holder.setValue(value);
@@ -67,9 +67,9 @@
{
ParallelExecutor parallelExecutor = getService(ParallelExecutor.class);
-Invokable inv = new Invokable()
+Invokable inv = new Invokable()
{
-public Object invoke()
+public StringHolder invoke()
{
throw new RuntimeException("Future failure!");
}
[jira] Assigned: (TAP5-670) ParallelExecutorTest can't be compiled due to cast errors
[ https://issues.apache.org/jira/browse/TAP5-670?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Howard M. Lewis Ship reassigned TAP5-670: - Assignee: Howard M. Lewis Ship > ParallelExecutorTest can't be compiled due to cast errors > - > > Key: TAP5-670 > URL: https://issues.apache.org/jira/browse/TAP5-670 > Project: Tapestry 5 > Issue Type: Bug > Components: tapestry-ioc >Affects Versions: 5.1.0.5 >Reporter: Ulrich Stärk >Assignee: Howard M. Lewis Ship > Attachments: patch.txt > > > As already stated in http://markmail.org/thread/sybprqs5yeuzobyr > ParallelExecutorTest won't compile due to cast errors. That's because the > Invokable isn't being given a type argument of type StringHolder and > therefore it tries to add an Object to the thunks list were it should add a > StringHolder. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (TAP5-670) ParallelExecutorTest can't be compiled due to cast errors
[ https://issues.apache.org/jira/browse/TAP5-670?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12703710#action_12703710 ] Howard M. Lewis Ship commented on TAP5-670: --- Probably a JDK 1.5 vs. JDK 1.6 issue. 1.6 seemed to have changed some of the rules for generics in subtle ways. > ParallelExecutorTest can't be compiled due to cast errors > - > > Key: TAP5-670 > URL: https://issues.apache.org/jira/browse/TAP5-670 > Project: Tapestry 5 > Issue Type: Bug > Components: tapestry-ioc >Affects Versions: 5.1.0.5 >Reporter: Ulrich Stärk >Assignee: Howard M. Lewis Ship > Attachments: patch.txt > > > As already stated in http://markmail.org/thread/sybprqs5yeuzobyr > ParallelExecutorTest won't compile due to cast errors. That's because the > Invokable isn't being given a type argument of type StringHolder and > therefore it tries to add an Object to the thunks list were it should add a > StringHolder. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Closed: (TAP5-671) Zone component does not identify which events it emits (with the @Events annotation)
[ https://issues.apache.org/jira/browse/TAP5-671?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Howard M. Lewis Ship closed TAP5-671. - Resolution: Invalid Got my components confused! > Zone component does not identify which events it emits (with the @Events > annotation) > > > Key: TAP5-671 > URL: https://issues.apache.org/jira/browse/TAP5-671 > Project: Tapestry 5 > Issue Type: Bug > Components: documentation >Affects Versions: 5.1.0.4 >Reporter: Howard M. Lewis Ship > -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Created: (TAP5-671) Zone component does not identify which events it emits (with the @Events annotation)
Zone component does not identify which events it emits (with the @Events annotation) Key: TAP5-671 URL: https://issues.apache.org/jira/browse/TAP5-671 Project: Tapestry 5 Issue Type: Bug Components: documentation Affects Versions: 5.1.0.4 Reporter: Howard M. Lewis Ship -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (TAP5-670) ParallelExecutorTest can't be compiled due to cast errors
[ https://issues.apache.org/jira/browse/TAP5-670?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ulrich Stärk updated TAP5-670: -- Attachment: patch.txt patch against trunk > ParallelExecutorTest can't be compiled due to cast errors > - > > Key: TAP5-670 > URL: https://issues.apache.org/jira/browse/TAP5-670 > Project: Tapestry 5 > Issue Type: Bug > Components: tapestry-ioc >Affects Versions: 5.1.0.5 >Reporter: Ulrich Stärk > Attachments: patch.txt > > > As already stated in http://markmail.org/thread/sybprqs5yeuzobyr > ParallelExecutorTest won't compile due to cast errors. That's because the > Invokable isn't being given a type argument of type StringHolder and > therefore it tries to add an Object to the thunks list were it should add a > StringHolder. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Created: (TAP5-670) ParallelExecutorTest can't be compiled due to cast errors
ParallelExecutorTest can't be compiled due to cast errors - Key: TAP5-670 URL: https://issues.apache.org/jira/browse/TAP5-670 Project: Tapestry 5 Issue Type: Bug Components: tapestry-ioc Affects Versions: 5.1.0.5 Reporter: Ulrich Stärk Attachments: patch.txt As already stated in http://markmail.org/thread/sybprqs5yeuzobyr ParallelExecutorTest won't compile due to cast errors. That's because the Invokable isn't being given a type argument of type StringHolder and therefore it tries to add an Object to the thunks list were it should add a StringHolder. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (TAP5-274) Application State Object is a misleading term; rename @ApplicationState to @SessionState
[ https://issues.apache.org/jira/browse/TAP5-274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12703599#action_12703599 ] Hugo Palma commented on TAP5-274: - All the services that relate to the old ApplicationState concept weren't renamed accordingly. I've created a new issue for that: TAP5-669 > Application State Object is a misleading term; rename @ApplicationState to > @SessionState > > > Key: TAP5-274 > URL: https://issues.apache.org/jira/browse/TAP5-274 > Project: Tapestry 5 > Issue Type: Improvement >Reporter: Geoff Callender >Assignee: Howard M. Lewis Ship > Fix For: 5.1.0.4 > > > This is a record of a discussion that went on in the mailing list on 16-18 > Sep 2008. I proposed that the term ApplicationStateObject caused confusion. > Some agreed but not all. Regardless, the discussion threw up some > interesting food for thought, so I've captured it here for further > consideration. > Here's the e-mail that kicked it off. > From: geoff.callender.jumpst...@gmail.com > Subject:T5: ApplicationStateObject is misleading > Date: 16 September 2008 9:06:12 PM > To: us...@tapestry.apache.org > We want Tapestry to be as natural as possible for newcomers, so it's > important to have terminology that is not misleading. Right now might be the > last chance to tidy some of these up before T5.0 goes final. > One term that I believe many people find misleading is ApplicationState. The > problem is that it implies it will make an object available across the whole > application, ie. application-scoped; which is not its purpose. > The doco says that ASOs "are unique to an individual user, not shared between > users", which is not quite right, either. > The standard usage is to tie an object's scope to that of a web session, so > maybe we should put "session" in the name? Eg. > @SessionScoped > @SessionShared > @ShareAcrossSession > It is important to understand that the term "session" here is NOT a reference > to the persistence mechanism, but a reference to the scope. > Alternatively, let's keep it really obvious with this: > @StateObject > with the understanding that the default persistence strategy is "session". > What do others think? Are you happy with ApplicationState? > Geoff > The discussion continued on these 2 threads: > * http://thread.gmane.org/gmane.comp.java.tapestry.user/65601/focus=65601 > * http://thread.gmane.org/gmane.comp.java.tapestry.user/65638/focus=65638 -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Created: (TAP5-669) All services related to the old ApplicationState concept should be renamed to use the new SessionState naming
All services related to the old ApplicationState concept should be renamed to use the new SessionState naming - Key: TAP5-669 URL: https://issues.apache.org/jira/browse/TAP5-669 Project: Tapestry 5 Issue Type: Improvement Components: tapestry-core Affects Versions: 5.1.0.4 Reporter: Hugo Palma 5.1.0.4 introduced the renaming of ApplicationState to SessionState. But there are some services that use the same naming and that were not renamed leaving the concept and the service names in an inconsistence state. >From a quick search i could find the following: - ApplicationStateAdapter - ApplicationStateContribution - ApplicationStateCreator - ApplicationStateManager - ApplicationStatePersistenceStrategy - ApplicationStatePersistenceStrategySource - ApplicationStateWorker -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (TAP5-577) TAP5-422 changes break persistent locale backwards compatibility.
[ https://issues.apache.org/jira/browse/TAP5-577?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12703567#action_12703567 ] Andy Blower commented on TAP5-577: -- "The process outlined by Andy doesn't really work because the ComponentEventLinkEncoder always calls the LocalizationSetter which in turn always sets the ThreadLocale; thus overriding the set made by the filter. To make it work I had to override the LocalizationSetter service to always return false, and change the filter to set the ThreadLocale directly. " Nice to hear I'm not the only one bothered by this Ferdy, and you're quite correct on this - I just traced though to double check! The weird thing is what I've done at least half works... when the filter sets the locale, the messages displayed on my page are correctly localised even though the thread locale is subsequently set back to the browser default rather than our persistent locale. I have no idea why this is and I honestly haven't the time or inclination any more to look into this problem more so I'm not going to be finding out. I must have spent 20+ hours on this one issue, looking at code & writing emails/issues, with absolutely no result. So I have better things to do with my time, but I definitely think that localisation has become a mess in T5.1 which is a shame since it was so nice to simply contribute a service implementation of a public interface in 5.0 and the job was done. I will be following the method you outlined, which will also mean I'll be following Howards advice from TAP5-658. (you might find that issue interesting to read also) My filter will also need the fall back to browser request locale copied from the setter, but that's no biggie. Thanks for the catch as this probably would have bitten me in the ass in a few months. > TAP5-422 changes break persistent locale backwards compatibility. > - > > Key: TAP5-577 > URL: https://issues.apache.org/jira/browse/TAP5-577 > Project: Tapestry 5 > Issue Type: Bug > Components: tapestry-core >Affects Versions: 5.1.0.0, 5.1.0.1 >Reporter: Andy Blower >Priority: Critical > Attachments: T5.1persistentLocale.txt > > > I think that the changes made in T5.1 for TAP5-422 break backwards > compatibility with T5.0's locale persistence. In T5.0 it was a simple matter > to override the default cookie persistence by creating a custom > implementation of the PersistentLocale service and contributing it to be used > instead of the standard internal T5 implementation. > The TAP5-422 changes broke backwards compatibility because anyone who's > created their own implementation of PersistentLocale, or just wants the 5.0 > cookie persistence behaviour, would have found that it's a lot more work and > involves some heavy changes to Tapestry internals. Now with the recent > changes for TAP5-418 (committed yesterday), the situation had been alleviated > somewhat by allowing the the hard-wired URl locale persistence to be switched > off using a new symbol. > However, I still think that this breaks backwards compatibility in two ways: > 1) By changing the default behaviour of locale persistence so that anyone > relying on the locale persistence behaviour of 5.0 will have to make > non-trivial changes when they upgrade to 5.1 to keep the same operation. > 2) By requiring so much work for anyone wanting to keep the 5.0 cookie > persistence behaviour or define their own custom locale persistence. (In 5.0 > it was easy to figure out and implement a custom locale persistence method) > From my analysis of the changes made by TAP5-422 & TAP5-418, I think anyone > wanting non-URL based locale persistence will need to do the following when > upgrading from 5.0 to 5.1: > 1) Set the ENCODE_LOCALE_INTO_PATH symbol to false. > 2) Create an implementation of PersistentLocale and contribute it to the IOC. > (copied from the standard 5.0 code if the old default cookie persistence is > desired) > 3) Create a custom filter written and created to do the same job as the 5.0 > LocalizationFilter and contribute it to the IOC RequestHandler. This filter > will need to call the LocalizationSetter setLocaleFromLocaleName() method > instead of the old setThreadLocale() method. > My suggested resolution would be to re-instate the 5.0 cookie persistence > (LocalizationFilter & PersistentLocaleImpl) and have the new > ENCODE_LOCALE_INTO_PATH symbol default to false allowing 5.1 to work the same > way as 5.0 out of the box. If the symbol is set to true, then the > LocalizationFilter is disabled (not contributed to RequestHandler) and the > PersistentLocale service will need to just store the locale (not set it in a > cookie) for later use by LinkSourceImpl. > LocalizationSetterImpl.setLocaleFr
