[jira] Created: (TAP5-1416) Combine scripts does not work
Combine scripts does not work
-
Key: TAP5-1416
URL: https://issues.apache.org/jira/browse/TAP5-1416
Project: Tapestry 5
Issue Type: Bug
Components: tapestry-core
Affects Versions: 5.2.4
Reporter: Donny Nadolny
In any Tapestry 5.2.4 in production mode, multiple javascript files are
supposed to be combined in to one virtual file to reduce the number of HTTP
requests on the page. This bug (regression from 5.1.0.5) is that this doesn't
happen, even if combine scripts is explicitly enabled.
To reproduce, take any application (eg the maven quickstart one) and add the
following line to the page:
@IncludeJavaScriptLibrary({context:test.js, context:test2.js})
public class Index {
//rest of page
}
In src/main/webapp added two files, test.js and test2.js
In AppModule, make sure that production mode is not set to false.
In 5.1.0.5, going to that page would result in one virtual asset for the
javascript files. In 5.2.4, they are all served separately.
Additional details:
This happens even if SymbolConstants.COMBINE_SCRIPTS is explicitly set to true
in the AppModule (according to the docs, it should default to true if
production mode is true).
This also happens using the new @Import annotation instead of
@IncludeJavaScriptLibrary
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[CONF] Apache Tapestry Download
Download
Page edited by Bob Harner
Changes (1)
...
h2. Tapestry 5.2.4
Tapestry 5.2.4 is the stable and recommended version Tapestry 5.2, released Nov 15, 2010. Largely a drop-in replacement for 5.1, it adds new features and extends Tapestrys scalability. See the [release notes|Release Notes] for 5.2|Release Notes 5.2] for more details about features and upgrade information.
{section}
...
Full Content
Tapestry can be downloaded in either binary or source format.
The easiest way to download Tapestry and its dependencies is using Maven, as described in Getting Started.
See the Release Notes for differences between versions and how to upgrade.
Stable Releases
Stable releases should be relatively free of critical bugs and are considered the safest option if stability is a requirement.
Tapestry 5.2.4
Tapestry 5.2.4 is the stable and recommended version Tapestry 5.2, released Nov 15, 2010. Largely a drop-in replacement for 5.1, it adds new features and extends Tapestry's scalability. See the release notes for 5.2 for more details about features and upgrade information.
Mirrors
Checksum
Signature
tapestry-bin 5.2.4 binary (tar.bz2)
Download
MD5
ASC
tapestry-bin 5.2.4 binary (tar.gz)
Download
MD5
ASC
tapestry-bin 5.2.4 binary (zip)
Download
MD5
ASC
tapestry-src 5.2.4 binary (tar.bz2)
Download
MD5
ASC
tapestry-src 5.2.4 binary (tar.gz)
Download
MD5
ASC
tapestry-src 5.2.4 binary (zip)
Download
MD5
ASC
Maven Dependency
dependency
groupIdorg.apache.tapestry/groupId
artifactIdtapestry-project/artifactId
version5.2.4/version
/dependency
Tapestry 5.1.0.5
Tapestry 5.1.0.5 is the stable release for Tapestry 5.1. Released Apr 23, 2009, Tapestry 5.1 addresses some limitations in 5.0 and improves performance and scalability.
Mirrors
Checksum
Signature
tapestry-bin 5.1.0.5 binary (tar.bz2)
Download
MD5
ASC
tapestry-bin 5.1.0.5 binary (tar.gz)
Download
MD5
ASC
tapestry-bin 5.1.0.5 binary (zip)
Download
MD5
ASC
tapestry-src 5.1.0.5 binary (tar.bz2)
Download
MD5
ASC
tapestry-src 5.1.0.5 binary (tar.gz)
Download
MD5
ASC
tapestry-src 5.1.0.5 binary (zip)
Download
MD5
ASC
Maven Dependency
dependency
groupIdorg.apache.tapestry/groupId
artifactIdtapestry-project/artifactId
version5.1.0.5/version
/dependency
Tapestry 4.1.6
Tapestry 4.1.6 is the final version of Tapestry 4. Released Sep 7, 2008, it improved upon early Tapestry 4 releases with bug fixes, AJAX support and performance enhancements. See Tapestry 4 release notes
Mirrors
Checksum
Signature
4.1.6 binary (tar.bz2)
Download
MD5
ASC
4.1.6 binary (tar.gz)
Download
MD5
ASC
4.1.6 binary (zip)
Download
MD5
ASC
4.1.6 source/docs (tar.bz2)
Download
MD5
ASC
4.1.6 source/docs (tar.gz)
Download
MD5
ASC
4.1.6 source/docs (zip)
Download
MD5
ASC
Archives
Looking for an older version of Tapestry? Try the archives.
Download sources
Anonymous access
The source can be checked out anonymously from SVN with this command:
$ svn checkout https://svn.apache.org/repos/asf/tapestry/tapestry5/trunk/ tapestry-project
Access from behind a firewall
Refer to the documentation of the SCM used for more information about access behind a firewall.
Access through a proxy
The Subversion client can go through a proxy, if you configure it to do so. First, edit your "servers" configuration file to indicate which proxy to use. The file's location depends on your operating system. On Linux or Unix it is located in the directory "~/.subversion". On Windows it is in "%APPDATA%\Subversion". (Try "echo %APPDATA%", note this is a hidden directory.)
There are comments in the file explaining what to do. If you don't have that file, get the latest Subversion client and run any command; this will cause the configuration directory and template files to be created.
Example: Edit the 'servers' file and add something like:
[global]
http-proxy-host = your.proxy.name
http-proxy-port = 3128
Change Notification Preferences
View Online
|
View Changes
[jira] Commented: (TAP5-711) Submit component: using image parameter prevents selected event from being fired
[ https://issues.apache.org/jira/browse/TAP5-711?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12982654#action_12982654 ] Stephan Windmüller commented on TAP5-711: - It seems like there is a new problem with this component regarding event handlers. Disabled submit events (with javaScript return false) are queued and executed when a submit button with an image on the same page is selected. I know, it sounds confusing, I can submit a demo page if needed. Submit component: using image parameter prevents selected event from being fired Key: TAP5-711 URL: https://issues.apache.org/jira/browse/TAP5-711 Project: Tapestry 5 Issue Type: Bug Components: tapestry-core Affects Versions: 5.1.0.5 Reporter: Sergey Didenko Assignee: Igor Drobiazko Fix For: 5.2.0, 5.1.0.6, 5.1.0.7 Attachments: TAP5-711-5.1.txt, TAP5-711.txt, VoteForm3.java, VoteForm3.tml When I change t:submit... to t:submit t:image=. onSelectedX() handlers stop working. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[CONF] Apache Tapestry Page And Component Classes FAQ
Page And Component Classes FAQ
Page edited by Bob Harner
Comment:
Renamed so it's name makes sense as a stand-alone page, e.g. when appearing in "Related Articles" boxes
Changes (0)
...
Full Content
Page And Component Classes
Main article: Component Classes
What's the difference between a page and a component?
There's very little difference between the two. Pages classes must be in the root-package.pages package; components must be in the root-package.components. Pages may provide event handlers for certain page-specific events (such as activate and passivate). Components may have parameters.
Other than that, they are more equal than they are different. They may have templates or may render themselves in code (pages usually have a template, components are more likely to render only in code).
The major difference is that Tapestry page templates may be stored in the web context directory, as if they were static files (they can't be accessed from the client however; a specific rule prevents access to files with the .tml extension).
It is possible that this feature may be removed in a later release. It is preferred that page templates be stored on the classpath, like component templates.
How do I store my page classes in a different package?
Tapestry is very rigid here; you can't. Page classes must go in root-package.pages, component classes in root-package.components, etc.
You are allowed to create sub-packages, to help organize your code better and more logically. For example, you might have _root-package.pages.account.ViewAccount, which would have the page name "account/viewaccount"
1
In addition, it is possible to define additional root packages for the application:
public static void contributeComponentClassResolver(ConfigurationLibraryMapping configuration) {
configuration.add(new LibraryMapping("", "com.example.app.tasks"));
configuration.add(new LibraryMapping("", "com.example.app.chat"));
}
LibraryMappings are used to resolve a library prefix to one or more package names. The empty string represents the application itself; the above example adds two additional root packages; you might see additional pages under com.example.app.tasks.pages, for example.
Tapestry doesn't check for name collisions, and the order the packages are searched for pages and components is not defined. In general, if you can get by with a single root package for your application, that is better.
Why do my instance variables have to be private?
Tapestry does a large amount of transformation to your simple POJO classes as it loads them into memory. In many cases, it must locate every read or write of an instance variable and change its behavior; for example, reading a field that is a component parameter will cause a property of the containing page or component to be read.
Limiting fields to private means that Tapestry can do the necessary processing one class at a time, as needed, at runtime. More complex Aspect Orient Programming systems such as AspectJ can perform similar transformations (and much more complex ones), but requires a dedicated build step (or the introduction of a JVM agent).
Why don't my informal parameters show up in the rendered markup?
Getting informal parameters to work is in two steps. First, you must make a call to the ComponentResources.renderInformalParameters() method, but just as importantly, you must tell Tapestry that you want the component to support informal parameters, using the SupportsInformalParameters annotation. Here's a hypothetical component that displays an image based on the value of a Image object (presumably, a database entity):
@SupportsInformalParameters
public class DBImage
{
@Parameter(required=true)
private Image image;
@Inject
private ComponentResources resources;
boolean beginRender(MarkupWriter writer)
{
writer.element("img", "src", image.toClientURL(), "class", "db-image");
resources.renderInformalParameters(writer);
writer.end();
return false;
}
}
Why do I get java.lang.LinkageError when I invoke public methods of my page classes?
In Tapestry, there are always two versions of page (or component) classes. The first version is the version loaded by standard class loader: the simple POJO version that you wrote.
The second version is much more complicated; it's the transformed version of your code, with lots of extra hooks and changes to allow the class to operate inside Tapestry. This includes implementing new interfaces and methods, adding new constructors, and changing access to existing fields and methods.
Although these two classes have the same fully qualified class name, they are distinct classes because they are
[CONF] Apache Tapestry Page And Component Classes
Page And Component Classes Page added by Bob Harner This page has moved to Page And Component Classes FAQ Change Notification Preferences View Online
[CONF] Apache Tapestry Since and Deprecated User Macros
Since and Deprecated User Macros Page moved by Bob Harner From: Apache Tapestry Sandbox To: Apache Tapestry Confluence Site Setup Children moved Change Notification Preferences View Online
[CONF] Apache Tapestry Ajax JavaScript
Ajax _javascript_
Page edited by Bob Harner
Comment:
Added a section on @Import, noted deprecation of @IncludeJavaScriptLibrary
Changes (9)
...
h2. Injecting RenderSupport
Main Article: [Environmental Services]
RenderSupport is an _environmental_ object, so you will normally inject it via the @[Environmental|http://tapestry.apache.org/current/apidocs/org/apache/tapestry5/annotations/Environmental.html] annotation:
...
{code}
Inside a component, you should use @Environmental, to highlight the fact that RenderSupport (like most environmental objects) is only available during rendering, not during action requests.
h1. IncludeJavaScriptLibrary @Import Annotation
The @[IncludeJavaScriptLibrary|http://tapestry.apache.org/current/apidocs/org/apache/tapestry5/annotations/IncludeJavaScriptLibrary.html] annotation is the easy way to include one or more _javascript_ libraries.
{since:since=5.2.0}
The previous example could be re-written as:
In Tapestry 5.2.0 and later, use the @[Import|http://tapestry.apache.org/current/apidocs/org/apache/tapestry5/annotations/Import.html] annotation to include links to _javascript_ (and CSS) files in your page. Tapestry ensures that each such file is only referenced once in your page.
{code:java}
@Import(library=${tapestry.scriptaculous}/dragdrop.js) public class MyComponent { . . . } {code} @Import may also be applied to individual methods, in which case the import operation only occurs when the method is invoked. Note: When specifying a file to import, youll often use the prefix context: to indicate that the file is stored in the web application context, and not on the classpath. Relative paths will be on the classpath, relative to the Java class. h1. @IncludeJavaScriptLibrary Annotation {deprecated:since=5.2 (use @Import instead)} In Tapestry 5.0 and 5.1, use the @[IncludeJavaScriptLibrary|http://tapestry.apache.org/current/apidocs/org/apache/tapestry5/annotations/IncludeJavaScriptLibrary.html] annotation to _javascript_ libraries in your page. {code:java}
@IncludeJavaScriptLibrary(${tapestry.scriptaculous}/dragdrop.js) public class MyComponent
...
This saves you the effort of injecting the asset and making the call to RenderSupport. Chances are you will _still_ inject RenderSupport so as to add some initialization _javascript_.
{deprecated}
h1. Combining Scripts
...
Full Content
Related Articles
Page:
Ajax _javascript_
Page:
_javascript_ FAQ
Page:
Ajax Components FAQ
Page:
Assets
Page:
Component Cheat Sheet
Tapestry includes sophisticated _javascript_ and Ajax support, based on the Prototype and Scriptaculous libraries. These libraries are all packaged with Tapestry itself ... no extra download is required.
Tapestry has many basic and useful components available within the application itself, and it's easy to create new ones.
Ajax support takes the form of new components and, occasionally, component mixins.
Tapestry will automatically link in prototype.js, scriptaculous.js, effects.js and the Tapestry library, tapestry.js. You can add additional libraries as needed.
Prototype and Scriptaculous Versions
Alternatives to Prototype
There are both immediate and long-term efforts underway to allow Tapestry to work better with other _javascript_ libraries, such as JQuery and ExtJS:
Tapestry5HowToIntegrateJQuery Using JQuery in addition to Prototype
Tapestry-Jquery module Using JQuery in addition to Prototype
Tapestry5-Jquery module Using JQuery instead of Prototype
TAP5-999 proposes an agnostic tapestry.js layer to allow switching from Prototype to JQuery
TAPS-1364 lists some starting points for ExtJS integration
Tapestry 5.2
Prototype 1.6.1
[jira] Assigned: (TAP5-1418) Image submits do not set the javascript submitting element value.
[ https://issues.apache.org/jira/browse/TAP5-1418?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Josh Canfield reassigned TAP5-1418: --- Assignee: Josh Canfield Image submits do not set the javascript submitting element value. - Key: TAP5-1418 URL: https://issues.apache.org/jira/browse/TAP5-1418 Project: Tapestry 5 Issue Type: Bug Components: tapestry-core Reporter: Josh Canfield Assignee: Josh Canfield Tracking for submit buttons only works for input type=submit. When an image is attached the type is changed to image. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Created: (TAP5-1418) Image submits do not set the javascript submitting element value.
Image submits do not set the javascript submitting element value. - Key: TAP5-1418 URL: https://issues.apache.org/jira/browse/TAP5-1418 Project: Tapestry 5 Issue Type: Bug Components: tapestry-core Reporter: Josh Canfield Tracking for submit buttons only works for input type=submit. When an image is attached the type is changed to image. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
svn commit: r1060151 - /tapestry/tapestry5/trunk/tapestry-core/src/main/resources/org/apache/tapestry5/tapestry.js
Author: joshcanfield
Date: Tue Jan 18 00:48:38 2011
New Revision: 1060151
URL: http://svn.apache.org/viewvc?rev=1060151view=rev
Log:
Fixed TAP5-1418 - added type=images support to the submitting element
functionality.
Modified:
tapestry/tapestry5/trunk/tapestry-core/src/main/resources/org/apache/tapestry5/tapestry.js
Modified:
tapestry/tapestry5/trunk/tapestry-core/src/main/resources/org/apache/tapestry5/tapestry.js
URL:
http://svn.apache.org/viewvc/tapestry/tapestry5/trunk/tapestry-core/src/main/resources/org/apache/tapestry5/tapestry.js?rev=1060151r1=1060150r2=1060151view=diff
==
---
tapestry/tapestry5/trunk/tapestry-core/src/main/resources/org/apache/tapestry5/tapestry.js
(original)
+++
tapestry/tapestry5/trunk/tapestry-core/src/main/resources/org/apache/tapestry5/tapestry.js
Tue Jan 18 00:48:38 2011
@@ -220,8 +220,10 @@ var Tapestry = {
* When a submit element is clicked, record the name of the
element into
* the associated form. This is necessary for some Ajax
processing, see
* TAPESTRY-2324.
+*
+* TAP5-1418: Added type=image so that they set the
submitting element correctly.
*/
- $$(INPUT[type=submit]).each(function(element) {
+
$$(INPUT[type=submit],INPUT[type=image]).each(function(element) {
var t = $T(element);
if (!t.trackingClicks) {
[jira] Commented: (TAP5-1418) Image submits do not set the javascript submitting element value.
[ https://issues.apache.org/jira/browse/TAP5-1418?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12982941#action_12982941 ] Josh Canfield commented on TAP5-1418: - See email thread: http://tapestry.1045711.n5.nabble.com/Disabled-button-events-are-queued-and-executed-td3341300.html Image submits do not set the javascript submitting element value. - Key: TAP5-1418 URL: https://issues.apache.org/jira/browse/TAP5-1418 Project: Tapestry 5 Issue Type: Bug Components: tapestry-core Reporter: Josh Canfield Assignee: Josh Canfield Fix For: 5.3.0 Tracking for submit buttons only works for input type=submit. When an image is attached the type is changed to image. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Closed: (TAP5-1418) Image submits do not set the javascript submitting element value.
[ https://issues.apache.org/jira/browse/TAP5-1418?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Josh Canfield closed TAP5-1418. --- Resolution: Fixed Fix Version/s: 5.3.0 Image submits do not set the javascript submitting element value. - Key: TAP5-1418 URL: https://issues.apache.org/jira/browse/TAP5-1418 Project: Tapestry 5 Issue Type: Bug Components: tapestry-core Reporter: Josh Canfield Assignee: Josh Canfield Fix For: 5.3.0 Tracking for submit buttons only works for input type=submit. When an image is attached the type is changed to image. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[CONF] Apache Tapestry Search
Search Comment edited by Bob Harner : Changes (2) ... ** Hosting Option: Search Element ** Layout: Full width ** Style: Minimalist ** Style: Default (customized as follows) *** Text: Verdana *** Snippet color: 454545 *** URL text color: 539126 I think its pretty cool that the search includes Tapestry Central and other Tapestry-focused blogs as well as JIRA issues. Full Content This is a "Google Custom Search Engine" search using an HTML/_javascript_ snippet I produced at http://www.google.com/cse in about 3 minutes. If anyone wants changes made to the underlying search model, I can do that via my Google account, or you can go to the Google CSE site and produce your own set of HTML/_javascript_ and replace what is pasted here. Here are the CSE settings: Basics Search engine keywords: tapestry5 apache Sites Included https://issues.apache.org/jira/browse/TAP5 http://spreadthesource.com/category/tapestry/ http://blog.andyhot.gr/tag/tapestry/ http://blog.tapestry5.de/ http://tapestryjava.blogspot.com/ http://wiki.apache.org/tapestry/ http://tapestry.apache.org/ Excluded http://tapestry.apache.org/tapestry3 http://tapestry.apache.org/tapestry4 http://tapestry.apache.org/tapestry5 Synonyms tap5 = tapestry5 Autocompletions: enabled Look and feel Hosting Option: Search Element Layout: Full width Style: Default (customized as follows) Text: Verdana Snippet color: 454545 URL text color: 539126 I think it's pretty cool that the search includes Tapestry Central and other Tapestry-focused blogs as well as JIRA issues. Change Notification Preferences View Online
[jira] Commented: (TAP5-1397) Remove Tutorial source from SVN
[ https://issues.apache.org/jira/browse/TAP5-1397?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12983005#action_12983005 ] Hudson commented on TAP5-1397: -- Integrated in tapestry-5.2-freestyle #252 (See [https://hudson.apache.org/hudson/job/tapestry-5.2-freestyle/252/]) Remove Tutorial source from SVN --- Key: TAP5-1397 URL: https://issues.apache.org/jira/browse/TAP5-1397 Project: Tapestry 5 Issue Type: Task Affects Versions: 5.3.0 Reporter: Howard M. Lewis Ship Assignee: Howard M. Lewis Ship Priority: Minor The new tutorial is stored at https://github.com/hlship/tapestry5-tutorial -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (TAP5-1418) Image submits do not set the javascript submitting element value.
[ https://issues.apache.org/jira/browse/TAP5-1418?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12983003#action_12983003 ] Hudson commented on TAP5-1418: -- Integrated in tapestry-5.2-freestyle #252 (See [https://hudson.apache.org/hudson/job/tapestry-5.2-freestyle/252/]) Fixed TAP5-1418 - added type=images support to the submitting element functionality. Image submits do not set the javascript submitting element value. - Key: TAP5-1418 URL: https://issues.apache.org/jira/browse/TAP5-1418 Project: Tapestry 5 Issue Type: Bug Components: tapestry-core Reporter: Josh Canfield Assignee: Josh Canfield Fix For: 5.3.0 Tracking for submit buttons only works for input type=submit. When an image is attached the type is changed to image. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (TAP5-1402) Remove deprecated Alias service (which was replaced in 5.1 with the simpler ServiceOverride service)
[ https://issues.apache.org/jira/browse/TAP5-1402?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12983006#action_12983006 ] Hudson commented on TAP5-1402: -- Integrated in tapestry-5.2-freestyle #252 (See [https://hudson.apache.org/hudson/job/tapestry-5.2-freestyle/252/]) Remove deprecated Alias service (which was replaced in 5.1 with the simpler ServiceOverride service) Key: TAP5-1402 URL: https://issues.apache.org/jira/browse/TAP5-1402 Project: Tapestry 5 Issue Type: Task Components: tapestry-core Affects Versions: 5.3.0 Reporter: Howard M. Lewis Ship Assignee: Howard M. Lewis Ship Fix For: 5.3.0 -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (TAP5-1372) BaseURLSource uses getLocalPort() rather than getServerPort()
[ https://issues.apache.org/jira/browse/TAP5-1372?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12983008#action_12983008 ] Hudson commented on TAP5-1372: -- Integrated in tapestry-5.2-freestyle #252 (See [https://hudson.apache.org/hudson/job/tapestry-5.2-freestyle/252/]) BaseURLSource uses getLocalPort() rather than getServerPort() - Key: TAP5-1372 URL: https://issues.apache.org/jira/browse/TAP5-1372 Project: Tapestry 5 Issue Type: Bug Components: tapestry-core Affects Versions: 5.2.4 Reporter: Andy Blower Assignee: Howard M. Lewis Ship Priority: Critical Fix For: 5.3.0, 5.2.5 Line 31 of BaseURLSourceImpl: int port = request.getLocalPort(); Which calls same method in the underlying ServletRequest. getLocalPort javadoc: Returns the Internet Protocol (IP) port number of the interface on which the request was received. getServerPort javadoc: Returns the port number to which the request was sent. It is the value of the part after : in the codeHost/code header, if any, or the server port where the client connection was accepted on. I think that the second is the one that should be used and since this port number is paired with the host returned from getServerName() rather than getLocalName(), this seems like a bug to me. Admittedly one that only causes problems in clustered load balanced environments, but it's just affected our site so it would be great if it could be fixed for 5.2 final release. A final release of Tapestry should not have a bug like this in it! Unless anyone has a convincing argument why it should be this way, of course... -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (TAP5-1385) Provide support for JSR-330
[ https://issues.apache.org/jira/browse/TAP5-1385?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12983007#action_12983007 ] Hudson commented on TAP5-1385: -- Integrated in tapestry-5.2-freestyle #252 (See [https://hudson.apache.org/hudson/job/tapestry-5.2-freestyle/252/]) Provide support for JSR-330 --- Key: TAP5-1385 URL: https://issues.apache.org/jira/browse/TAP5-1385 Project: Tapestry 5 Issue Type: New Feature Components: tapestry-ioc Affects Versions: 5.2.4 Reporter: Igor Drobiazko Assignee: Igor Drobiazko It should be possible to use JSR-330 annotations for the injection points. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (TAP5-1390) Functional programming improvements
[ https://issues.apache.org/jira/browse/TAP5-1390?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12983010#action_12983010 ] Hudson commented on TAP5-1390: -- Integrated in tapestry-5.2-freestyle #252 (See [https://hudson.apache.org/hudson/job/tapestry-5.2-freestyle/252/]) Functional programming improvements --- Key: TAP5-1390 URL: https://issues.apache.org/jira/browse/TAP5-1390 Project: Tapestry 5 Issue Type: Improvement Components: tapestry-func Affects Versions: 5.3.0 Reporter: Howard M. Lewis Ship Assignee: Howard M. Lewis Ship Add support for Tuples to the tapestry-func library -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (TAP5-891) RequestImpl.getSession(true) is broken
[ https://issues.apache.org/jira/browse/TAP5-891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12983009#action_12983009 ] Hudson commented on TAP5-891: - Integrated in tapestry-5.2-freestyle #252 (See [https://hudson.apache.org/hudson/job/tapestry-5.2-freestyle/252/]) RequestImpl.getSession(true) is broken -- Key: TAP5-891 URL: https://issues.apache.org/jira/browse/TAP5-891 Project: Tapestry 5 Issue Type: Bug Components: tapestry-core Affects Versions: 5.1.0.5 Reporter: Olle Hallin Attachments: RequestImpl.java, RequestImplTest.java I think that the implementation of org.apache.tapestry5.internal.services.RequestImpl.getSession(true) is broken. It returns an old invalidated session instead of creating a new. IMO this is a bug since it behaves differently than HttpServletRequest.getSession(true). This is the expected behaviour: 1. Session s1 = request.getSession(true); 2. s1.invalidate(); 3. Session s2 = request.getSession(true); 4. assertNotNull(s2); 5. assertNotSame(s1, s2); 6. assertFalse(s2.isInvalidated()); -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (TAP5-1393) Form component shoould push the BeanValidationContext into the Environment only after onPrepare()
[ https://issues.apache.org/jira/browse/TAP5-1393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12983011#action_12983011 ] Hudson commented on TAP5-1393: -- Integrated in tapestry-5.2-freestyle #252 (See [https://hudson.apache.org/hudson/job/tapestry-5.2-freestyle/252/]) Form component shoould push the BeanValidationContext into the Environment only after onPrepare() - Key: TAP5-1393 URL: https://issues.apache.org/jira/browse/TAP5-1393 Project: Tapestry 5 Issue Type: Bug Components: tapestry-beanvalidator Affects Versions: 5.2.4 Reporter: Matheus Eduardo Machado Moreira Assignee: Igor Drobiazko Fix For: 5.3.0 Attachments: EditarPermissao.java, EditarPermissao.tml, Permissao.java, stacktrace.txt An exception is throw when trying to render a Form whose validate parameter is bound to a bean that is null after onActivate(): ERROR tapestry.render.br.com.eteg.cromoup.pages.acesso.EditarPermissao - Render queue error in BeginRender[acesso/EditarPermissao:nome]: Class cannot be null The attached files show a scenario where the bug occur. Basically it shows an edit page that initialize a bean (that is bound to the validate parameter of the Form) at onValidate() if a not-null id is passed as the initialization context. If the id is null the bean is initialized at onPrepare(), just after the Form starts to render itself. The problem seems to happen because the prepare (and prepare_to_render) event are triggered *after* the Form component pushes a BeanValidationContextImpl into the Environment. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
