[jira] [Commented] (TAP5-1697) Datepicker color/style problem only on WebKit/Mac browsers
[ https://issues.apache.org/jira/browse/TAP5-1697?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13127176#comment-13127176 ] Lenny Primak commented on TAP5-1697: Workaround: oIn one of the CSS files, put the following: DIV.datePicker .header { background: Window; } > Datepicker color/style problem only on WebKit/Mac browsers > -- > > Key: TAP5-1697 > URL: https://issues.apache.org/jira/browse/TAP5-1697 > Project: Tapestry 5 > Issue Type: Bug > Components: tapestry-core >Affects Versions: 5.3, 5.2.5, 5.2.6 >Reporter: Lenny Primak >Priority: Minor > > As you can see, on Safari & Crome (Webkit) on a Mac, the datepicker top bar > is black, thus the month/year is missing: > Screenshots are posted... > http://hope.nyc.ny.us/~lprimak/images/PastedGraphic-1.tiff > On all other browsers (Firefox in this example), it's properly displayed: > http://hope.nyc.ny.us/~lprimak/images/PastedGraphic-2.tiff > Also, weirdly enough it works properly on the iPhone/iPad. > I am using T5.3beta18 -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (TAP5-1696) Tapestry should include a @WhitelistOnly page that only allows access to the page when it is accessed from a local (or otherwise acceptable) host
[ https://issues.apache.org/jira/browse/TAP5-1696?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13127145#comment-13127145 ] Hudson commented on TAP5-1696: -- Integrated in tapestry-trunk-freestyle #576 (See [https://builds.apache.org/job/tapestry-trunk-freestyle/576/]) TAP5-1696: Add in support for @WhitelistAccessOnly TAP5-1696: Change MetaWorker to no longer extend CCTW2, but expose a property that does hlship : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1183162 Files : * /tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/MetaDataConstants.java * /tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/annotations/WhitelistAccessOnly.java * /tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/annotations/package-info.java * /tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/corelib/pages/PageCatalog.java * /tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/corelib/pages/ServiceStatus.java * /tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/internal/services/ComponentEventLinkEncoderImpl.java * /tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/internal/services/RequestImpl.java * /tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/internal/services/security * /tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/internal/services/security/ClientWhitelistImpl.java * /tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/internal/services/security/LocalhostOnly.java * /tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/internal/test/TestableRequestImpl.java * /tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/services/DelegatingRequest.java * /tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/services/Request.java * /tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/services/TapestryModule.java * /tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/services/security * /tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/services/security/ClientWhitelist.java * /tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/services/security/WhitelistAnalyzer.java * /tapestry/tapestry5/trunk/tapestry-core/src/test/java/org/apache/tapestry5/internal/services/ComponentEventDispatcherTest.java * /tapestry/tapestry5/trunk/tapestry-core/src/test/java/org/apache/tapestry5/internal/services/ComponentEventLinkEncoderImplTest.java * /tapestry/tapestry5/trunk/tapestry-core/src/test/java/org/apache/tapestry5/internal/test/InternalBaseTestCase.java * /tapestry/tapestry5/trunk/tapestry-hibernate/src/main/java/org/apache/tapestry5/hibernate/pages/Statistics.java hlship : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1183161 Files : * /tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/internal/services/meta/MetaWorkerImpl.java * /tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/services/TapestryModule.java * /tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/services/meta/MetaWorker.java > Tapestry should include a @WhitelistOnly page that only allows access to the > page when it is accessed from a local (or otherwise acceptable) host > - > > Key: TAP5-1696 > URL: https://issues.apache.org/jira/browse/TAP5-1696 > Project: Tapestry 5 > Issue Type: New Feature > Components: tapestry-core >Affects Versions: 5.3 >Reporter: Howard M. Lewis Ship >Assignee: Howard M. Lewis Ship > Labels: security > Fix For: 5.3 > > > PageCatalog and ServiceStatus should be protected with this page. A service > should be used to determine if the page should be accessible. The default > rule should be "localhost only". -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Closed] (TAP5-1696) Tapestry should include a @WhitelistOnly page that only allows access to the page when it is accessed from a local (or otherwise acceptable) host
[ https://issues.apache.org/jira/browse/TAP5-1696?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Howard M. Lewis Ship closed TAP5-1696. -- Resolution: Fixed Fix Version/s: 5.3 Assignee: Howard M. Lewis Ship > Tapestry should include a @WhitelistOnly page that only allows access to the > page when it is accessed from a local (or otherwise acceptable) host > - > > Key: TAP5-1696 > URL: https://issues.apache.org/jira/browse/TAP5-1696 > Project: Tapestry 5 > Issue Type: New Feature > Components: tapestry-core >Affects Versions: 5.3 >Reporter: Howard M. Lewis Ship >Assignee: Howard M. Lewis Ship > Labels: security > Fix For: 5.3 > > > PageCatalog and ServiceStatus should be protected with this page. A service > should be used to determine if the page should be accessible. The default > rule should be "localhost only". -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
svn commit: r1183161 - in /tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5: internal/services/meta/MetaWorkerImpl.java services/TapestryModule.java services/meta/MetaWorker.j
Author: hlship Date: Thu Oct 13 23:16:58 2011 New Revision: 1183161 URL: http://svn.apache.org/viewvc?rev=1183161&view=rev Log: TAP5-1696: Change MetaWorker to no longer extend CCTW2, but expose a property that does Modified: tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/internal/services/meta/MetaWorkerImpl.java tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/services/TapestryModule.java tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/services/meta/MetaWorker.java Modified: tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/internal/services/meta/MetaWorkerImpl.java URL: http://svn.apache.org/viewvc/tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/internal/services/meta/MetaWorkerImpl.java?rev=1183161&r1=1183160&r2=1183161&view=diff == --- tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/internal/services/meta/MetaWorkerImpl.java (original) +++ tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/internal/services/meta/MetaWorkerImpl.java Thu Oct 13 23:16:58 2011 @@ -16,16 +16,16 @@ package org.apache.tapestry5.internal.se import org.apache.tapestry5.model.MutableComponentModel; import org.apache.tapestry5.plastic.PlasticClass; -import org.apache.tapestry5.services.ClassTransformation; import org.apache.tapestry5.services.meta.MetaDataExtractor; import org.apache.tapestry5.services.meta.MetaWorker; +import org.apache.tapestry5.services.transform.ComponentClassTransformWorker2; import org.apache.tapestry5.services.transform.TransformationSupport; import java.lang.annotation.Annotation; import java.util.Map; @SuppressWarnings("unchecked") -public class MetaWorkerImpl implements MetaWorker +public class MetaWorkerImpl implements MetaWorker, ComponentClassTransformWorker2 { private final Map configuration; @@ -34,6 +34,11 @@ public class MetaWorkerImpl implements M this.configuration = configuration; } +public ComponentClassTransformWorker2 getWorker() +{ +return this; +} + public void transform(PlasticClass plasticClass, TransformationSupport support, MutableComponentModel model) { for (Class c : configuration.keySet()) Modified: tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/services/TapestryModule.java URL: http://svn.apache.org/viewvc/tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/services/TapestryModule.java?rev=1183161&r1=1183160&r2=1183161&view=diff == --- tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/services/TapestryModule.java (original) +++ tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/services/TapestryModule.java Thu Oct 13 23:16:58 2011 @@ -598,7 +598,7 @@ public final class TapestryModule configuration.addInstance("Import", ImportWorker.class); -configuration.add("Meta", metaWorker); +configuration.add("Meta", metaWorker.getWorker()); configuration.add("Retain", new RetainWorker()); Modified: tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/services/meta/MetaWorker.java URL: http://svn.apache.org/viewvc/tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/services/meta/MetaWorker.java?rev=1183161&r1=1183160&r2=1183161&view=diff == --- tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/services/meta/MetaWorker.java (original) +++ tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/services/meta/MetaWorker.java Thu Oct 13 23:16:58 2011 @@ -26,7 +26,12 @@ import org.apache.tapestry5.services.tra * @since 5.2.0 */ @UsesMappedConfiguration(key = Class.class, value = MetaDataExtractor.class) -public interface MetaWorker extends ComponentClassTransformWorker2 +public interface MetaWorker { - +/** + * Returns the worker that performs transformations (in 5.2, MetaWorker implemented ComponentClassTransformWorker). + * + * @return worker that implements the meta data analysis + */ +ComponentClassTransformWorker2 getWorker(); }
[jira] [Commented] (TAP5-1697) Datepicker color/style problem only on WebKit/Mac browsers
[ https://issues.apache.org/jira/browse/TAP5-1697?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13127100#comment-13127100 ] Lenny Primak commented on TAP5-1697: Looks like these are deprecated now. Should I look for a workaround or would Tapestry fix this at some point? > Datepicker color/style problem only on WebKit/Mac browsers > -- > > Key: TAP5-1697 > URL: https://issues.apache.org/jira/browse/TAP5-1697 > Project: Tapestry 5 > Issue Type: Bug > Components: tapestry-core >Affects Versions: 5.3, 5.2.5, 5.2.6 >Reporter: Lenny Primak >Priority: Minor > > As you can see, on Safari & Crome (Webkit) on a Mac, the datepicker top bar > is black, thus the month/year is missing: > Screenshots are posted... > http://hope.nyc.ny.us/~lprimak/images/PastedGraphic-1.tiff > On all other browsers (Firefox in this example), it's properly displayed: > http://hope.nyc.ny.us/~lprimak/images/PastedGraphic-2.tiff > Also, weirdly enough it works properly on the iPhone/iPad. > I am using T5.3beta18 -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (TAP5-1696) Tapestry should include a @WhitelistOnly page that only allows access to the page when it is accessed from a local (or otherwise acceptable) host
[ https://issues.apache.org/jira/browse/TAP5-1696?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Howard M. Lewis Ship updated TAP5-1696: --- Summary: Tapestry should include a @WhitelistOnly page that only allows access to the page when it is accessed from a local (or otherwise acceptable) host (was: Tapestry should include a @WhitelistOnly page that only allows access to the page when it is ) > Tapestry should include a @WhitelistOnly page that only allows access to the > page when it is accessed from a local (or otherwise acceptable) host > - > > Key: TAP5-1696 > URL: https://issues.apache.org/jira/browse/TAP5-1696 > Project: Tapestry 5 > Issue Type: New Feature > Components: tapestry-core >Affects Versions: 5.3 >Reporter: Howard M. Lewis Ship > Labels: security > > PageCatalog and ServiceStatus should be protected with this page. A service > should be used to determine if the page should be accessible. The default > rule should be "localhost only". -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (TAP5-1697) Datepicker color/style problem only on WebKit/Mac browsers
[ https://issues.apache.org/jira/browse/TAP5-1697?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13127075#comment-13127075 ] Josh Canfield commented on TAP5-1697: - The problem is the datapicker.css uses system colors which for some reason result as black on black. http://www.w3.org/TR/CSS2/ui.html#system-colors It's supposed to make the datepicker match your system colors. http://www.iangraham.org/books/xhtml1/appd/update-23feb2000.html The two classes that are used in the header are: ActiveCaption for the background CaptionText for the text Both of these are Black on webkit on the Mac. > Datepicker color/style problem only on WebKit/Mac browsers > -- > > Key: TAP5-1697 > URL: https://issues.apache.org/jira/browse/TAP5-1697 > Project: Tapestry 5 > Issue Type: Bug > Components: tapestry-core >Affects Versions: 5.3, 5.2.5, 5.2.6 >Reporter: Lenny Primak >Priority: Minor > > As you can see, on Safari & Crome (Webkit) on a Mac, the datepicker top bar > is black, thus the month/year is missing: > Screenshots are posted... > http://hope.nyc.ny.us/~lprimak/images/PastedGraphic-1.tiff > On all other browsers (Firefox in this example), it's properly displayed: > http://hope.nyc.ny.us/~lprimak/images/PastedGraphic-2.tiff > Also, weirdly enough it works properly on the iPhone/iPad. > I am using T5.3beta18 -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (TAP5-1634) Grid, inPlace Update and expired Sessions - Redirect to Login
[ https://issues.apache.org/jira/browse/TAP5-1634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13127022#comment-13127022 ] Lenny Primak commented on TAP5-1634: Introduced a workaround for this. Created an @AJAX(requireSession = true) annotation. In case there is no session, the annotation processing logic redirects to the same page. The code is in FlowLogix module at http://code.google.com/p/flowlogix/ > Grid, inPlace Update and expired Sessions - Redirect to Login > - > > Key: TAP5-1634 > URL: https://issues.apache.org/jira/browse/TAP5-1634 > Project: Tapestry 5 > Issue Type: Improvement > Components: tapestry-core >Affects Versions: 5.3, 5.4 >Reporter: Lenny Primak >Priority: Minor > > I have a basic Grid pulling data from an Entity bean. inPlace = true. > Obviously, when session expires, I get the "there is no data to display" > message. > What I really want to do is to redirect to the current page, so the user gets > to relogin and session > gets re-established. > Here's what I tried: >@SuppressWarnings("unused") >@OnEvent(value="inplaceUpdate", component="usersGrid") >private Object ajaxPageChanged() >{ >if(request.getSession(false) != null) >{ >return null; >} >else >{ > return ps.createPageRenderLink(LoginPage.class).; >} >} > I get an exception: > Caused by: java.lang.IllegalArgumentException: Event 'inplaceupdate' from > test/TapPage:usersgrid.pager received an event handler method return value of > /com.bettaway_baw-website_war_1.2/loginpage. This type of event does not > support return values from event handler methods. > at > org.apache.tapestry5.internal.util.NotificationEventCallback.handleResult(NotificationEventCallback.java:39) -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (TAP5-1661) Grid inPlace=true - Gracedul degradation with JavaScript disabled
[ https://issues.apache.org/jira/browse/TAP5-1661?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13127017#comment-13127017 ] Lenny Primak commented on TAP5-1661: My workaround for this is to detect JavaScript on the app's login page via AJAX event handlier on startup. > Grid inPlace=true - Gracedul degradation with JavaScript disabled > - > > Key: TAP5-1661 > URL: https://issues.apache.org/jira/browse/TAP5-1661 > Project: Tapestry 5 > Issue Type: Improvement > Components: tapestry-core >Affects Versions: 5.3, 5.4, 5.2 >Reporter: Lenny Primak >Priority: Minor > > When JavaScript is disabled on the browser, > Grid inPlace="true" pager will not function. > It should gracefully degrade and still function with JavaScript disabled, > as if inPlace was set to false. > I realize this is difficult to do because its really not detectable if JS is > enabled on the server side. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Created] (TAP5-1697) Datepicker color/style problem only on WebKit/Mac browsers
Datepicker color/style problem only on WebKit/Mac browsers -- Key: TAP5-1697 URL: https://issues.apache.org/jira/browse/TAP5-1697 Project: Tapestry 5 Issue Type: Bug Components: tapestry-core Affects Versions: 5.2.5, 5.3, 5.2.6 Reporter: Lenny Primak Priority: Minor As you can see, on Safari & Crome (Webkit) on a Mac, the datepicker top bar is black, thus the month/year is missing: Screenshots are posted... http://hope.nyc.ny.us/~lprimak/images/PastedGraphic-1.tiff On all other browsers (Firefox in this example), it's properly displayed: http://hope.nyc.ny.us/~lprimak/images/PastedGraphic-2.tiff Also, weirdly enough it works properly on the iPhone/iPad. I am using T5.3beta18 -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[CONF] Apache Tapestry > Home
Home Page edited by Howard M. Lewis Ship Changes (1) ... * [TAPESTRY:Download] -- Needs to be updated for each new stable or preview release * [TAPESTRY:downloadBoxes] -- part of the main Index, lists the current stable version number h2. TODO List A quick place to jot down notes on work needed to be done. * Use of symbols to define (some) component parameter defaults * Update examples r.e. use of Maven Archetype * Document ResourceTranslators * Discuss OperationTracker * Discuss PageCatalog page * Document that public static fields are also treated as properties * Document AlertManager Full Content This is the home page of the Apache Tapestry wiki. From here you can go to Index – the entry page for the auto-generated website Documentation – the documentation main page Sandbox – a sandbox for developing new ideas and testing things out Board Reports – Quarterly reports to the Apache Board After posting a new blog entry, you should update the following pages, to force the new content to be included: Index News Things to update on a new release: Release Notes – Release notes Download – Needs to be updated for each new stable or preview release downloadBoxes – part of the main Index, lists the current stable version number TODO List A quick place to jot down notes on work needed to be done. Use of symbols to define (some) component parameter defaults Update examples r.e. use of Maven Archetype Document ResourceTranslators Discuss OperationTracker Discuss PageCatalog page Document that public static fields are also treated as properties Document AlertManager Change Notification Preferences View Online | View Changes
[jira] [Created] (TAP5-1696) Tapestry should include a @WhitelistOnly page that only allows access to the page when it is
Tapestry should include a @WhitelistOnly page that only allows access to the page when it is - Key: TAP5-1696 URL: https://issues.apache.org/jira/browse/TAP5-1696 Project: Tapestry 5 Issue Type: New Feature Components: tapestry-core Affects Versions: 5.3 Reporter: Howard M. Lewis Ship PageCatalog and ServiceStatus should be protected with this page. A service should be used to determine if the page should be accessible. The default rule should be "localhost only". -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (TAP5-1695) Firefox on Linux can not dismiss the Ajax exception report iframe
[ https://issues.apache.org/jira/browse/TAP5-1695?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13126872#comment-13126872 ] Massimo Lusetti commented on TAP5-1695: --- Here FF on Linux and it works correctly... I cannot reproduce this > Firefox on Linux can not dismiss the Ajax exception report iframe > - > > Key: TAP5-1695 > URL: https://issues.apache.org/jira/browse/TAP5-1695 > Project: Tapestry 5 > Issue Type: Bug > Components: tapestry-core >Affects Versions: 5.3 >Reporter: Howard M. Lewis Ship >Priority: Critical > Labels: ajax, exception-reporting, linux > Attachments: close-exception-report.png > > > Using Firefox on Linux, when the exception report came up, the close button > didn't work, but wrote an exception into the console. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (TAP5-1695) Firefox on Linux can not dismiss the Ajax exception report iframe
[ https://issues.apache.org/jira/browse/TAP5-1695?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13126833#comment-13126833 ] Howard M. Lewis Ship commented on TAP5-1695: Doesn't reproduce on FF 5.0.1 for Mac OS X Lion. That's a data point, I guess. > Firefox on Linux can not dismiss the Ajax exception report iframe > - > > Key: TAP5-1695 > URL: https://issues.apache.org/jira/browse/TAP5-1695 > Project: Tapestry 5 > Issue Type: Bug > Components: tapestry-core >Affects Versions: 5.3 >Reporter: Howard M. Lewis Ship >Priority: Critical > Labels: ajax, exception-reporting, linux > Attachments: close-exception-report.png > > > Using Firefox on Linux, when the exception report came up, the close button > didn't work, but wrote an exception into the console. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
svn commit: r1183041 - in /tapestry/tapestry5/trunk/tapestry-core/src/main: java/org/apache/tapestry5/corelib/pages/ resources/org/apache/tapestry5/corelib/pages/
Author: hlship Date: Thu Oct 13 19:18:09 2011 New Revision: 1183041 URL: http://svn.apache.org/viewvc?rev=1183041&view=rev Log: Display some total information on the PageCatalog page Added: tapestry/tapestry5/trunk/tapestry-core/src/main/resources/org/apache/tapestry5/corelib/pages/PageCatalog.properties Modified: tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/corelib/pages/PageCatalog.java tapestry/tapestry5/trunk/tapestry-core/src/main/resources/org/apache/tapestry5/corelib/pages/PageCatalog.tml Modified: tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/corelib/pages/PageCatalog.java URL: http://svn.apache.org/viewvc/tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/corelib/pages/PageCatalog.java?rev=1183041&r1=1183040&r2=1183041&view=diff == --- tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/corelib/pages/PageCatalog.java (original) +++ tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/corelib/pages/PageCatalog.java Thu Oct 13 19:18:09 2011 @@ -16,14 +16,11 @@ package org.apache.tapestry5.corelib.pag import org.apache.tapestry5.SymbolConstants; import org.apache.tapestry5.alerts.AlertManager; -import org.apache.tapestry5.annotations.ContentType; -import org.apache.tapestry5.annotations.InjectComponent; -import org.apache.tapestry5.annotations.Persist; -import org.apache.tapestry5.annotations.Property; +import org.apache.tapestry5.annotations.*; +import org.apache.tapestry5.beaneditor.ReorderProperties; import org.apache.tapestry5.beaneditor.Validate; import org.apache.tapestry5.corelib.components.Zone; -import org.apache.tapestry5.func.F; -import org.apache.tapestry5.func.Predicate; +import org.apache.tapestry5.func.*; import org.apache.tapestry5.internal.services.ComponentInstantiatorSource; import org.apache.tapestry5.internal.services.PageSource; import org.apache.tapestry5.internal.structure.Page; @@ -31,6 +28,7 @@ import org.apache.tapestry5.ioc.Operatio import org.apache.tapestry5.ioc.annotations.Inject; import org.apache.tapestry5.ioc.annotations.Symbol; import org.apache.tapestry5.ioc.internal.util.CollectionFactory; +import org.apache.tapestry5.ioc.internal.util.InternalUtils; import org.apache.tapestry5.services.ComponentClassResolver; import org.apache.tapestry5.services.pageload.ComponentResourceSelector; @@ -45,6 +43,33 @@ import java.util.Set; @ContentType("text/html") public class PageCatalog { + @ReorderProperties("definedPages,loadedPages,uniquePageNames,selectors,components") +public class Totals +{ +/** + * Total number of pages loaded. + */ +public int loadedPages; + +/** + * Number of total page names. + */ +public int definedPages; +/** + * Number of unique page names (remember, same page may appear for multiple selectors). + */ +public int uniquePageNames; +/** + * Total number of components. + */ +public int components; + +/** + * All selectors represented in the pool, often just 'en'. + */ +public String selectors; +} + @Property @Inject @Symbol(SymbolConstants.PRODUCTION_MODE) @@ -82,6 +107,46 @@ public class PageCatalog @Inject private ComponentInstantiatorSource componentInstantiatorSource; +@Cached +public Totals getTotals() +{ + +Totals result = new Totals(); + +Flow pages = F.flow(getPages()); + +result.loadedPages = pages.count(); +result.definedPages = getPageNames().size(); +result.uniquePageNames = pages.map(new Mapper() +{ +public String map(Page element) +{ +return element.getName(); +} +}).toSet().size(); + +result.components = pages.reduce(new Reducer() +{ +public Integer reduce(Integer accumulator, Page element) +{ +return accumulator + element.getComponentCount(); +} +}, 0); + +Set selectorIds = pages.map(new Mapper() +{ +public String map(Page element) +{ +return element.getSelector().toShortString(); +} +}).toSet(); + +result.selectors = InternalUtils.joinSorted(selectorIds); + +return result; + +} + public List getPageNames() { return resolver.getPageNames(); Added: tapestry/tapestry5/trunk/tapestry-core/src/main/resources/org/apache/tapestry5/corelib/pages/PageCatalog.properties URL: http://svn.apache.org/viewvc/tapestry/tapestry5/trunk/tapestry-core/src/main/resources/org/apache/tapestry5/corelib/pages/PageCatalog.properties?rev=1183041&view=auto ===
svn commit: r1183040 - /tapestry/tapestry5/trunk/tapestry-func/src/main/java/org/apache/tapestry5/func/Reducer.java
Author: hlship Date: Thu Oct 13 19:18:05 2011 New Revision: 1183040 URL: http://svn.apache.org/viewvc?rev=1183040&view=rev Log: Rename parameter "value" to "element" for consistency Modified: tapestry/tapestry5/trunk/tapestry-func/src/main/java/org/apache/tapestry5/func/Reducer.java Modified: tapestry/tapestry5/trunk/tapestry-func/src/main/java/org/apache/tapestry5/func/Reducer.java URL: http://svn.apache.org/viewvc/tapestry/tapestry5/trunk/tapestry-func/src/main/java/org/apache/tapestry5/func/Reducer.java?rev=1183040&r1=1183039&r2=1183040&view=diff == --- tapestry/tapestry5/trunk/tapestry-func/src/main/java/org/apache/tapestry5/func/Reducer.java (original) +++ tapestry/tapestry5/trunk/tapestry-func/src/main/java/org/apache/tapestry5/func/Reducer.java Thu Oct 13 19:18:05 2011 @@ -25,8 +25,8 @@ package org.apache.tapestry5.func; public interface Reducer { /** - * Run a computation using the current value of the accumulator and a value (from a Flow), + * Run a computation using the current value of the accumulator and an element (from a Flow), * and return the new accumulator. */ -A reduce(A accumulator, T value); +A reduce(A accumulator, T element); }
svn commit: r1183039 - /tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/corelib/internal/WrappedComponentAction.java
Author: hlship Date: Thu Oct 13 19:17:58 2011 New Revision: 1183039 URL: http://svn.apache.org/viewvc?rev=1183039&view=rev Log: Delete unused class WrappedComponentAction Removed: tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/corelib/internal/WrappedComponentAction.java
[jira] [Updated] (TAP5-1695) Firefox on Linux can not dismiss the Ajax exception report iframe
[ https://issues.apache.org/jira/browse/TAP5-1695?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Howard M. Lewis Ship updated TAP5-1695: --- Attachment: close-exception-report.png > Firefox on Linux can not dismiss the Ajax exception report iframe > - > > Key: TAP5-1695 > URL: https://issues.apache.org/jira/browse/TAP5-1695 > Project: Tapestry 5 > Issue Type: Bug > Components: tapestry-core >Affects Versions: 5.3 >Reporter: Howard M. Lewis Ship >Priority: Critical > Labels: ajax, exception-reporting, linux > Attachments: close-exception-report.png > > > Using Firefox on Linux, when the exception report came up, the close button > didn't work, but wrote an exception into the console. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Created] (TAP5-1695) Firefox on Linux can not dismiss the Ajax exception report iframe
Firefox on Linux can not dismiss the Ajax exception report iframe - Key: TAP5-1695 URL: https://issues.apache.org/jira/browse/TAP5-1695 Project: Tapestry 5 Issue Type: Bug Components: tapestry-core Affects Versions: 5.3 Reporter: Howard M. Lewis Ship Priority: Critical Attachments: close-exception-report.png Using Firefox on Linux, when the exception report came up, the close button didn't work, but wrote an exception into the console. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (TAP5-1694) Ability to override the default NullFieldStrategy
[ https://issues.apache.org/jira/browse/TAP5-1694?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13126624#comment-13126624 ] Massimo Lusetti commented on TAP5-1694: --- Not directly. Using a Symbol would be nice since it will let you have on easy place where to store your choice but it needs some changes which are discussed here: http://mail-archives.apache.org/mod_mbox/tapestry-dev/201110.mbox/browser Basically we need a way to specify a binding in a Symbol value. > Ability to override the default NullFieldStrategy > - > > Key: TAP5-1694 > URL: https://issues.apache.org/jira/browse/TAP5-1694 > Project: Tapestry 5 > Issue Type: Wish > Components: tapestry-core >Affects Versions: 5.3 >Reporter: David Sundsskard > > My use-case is that I want empty textfields to post an empty String instead > of null. > I have implemented a nullfieldstrategy and it can be set on the textfield, > but components that create textfields on the fly (eg. Grid) use the default > NullFieldStrategy defined in AbstractTextField. > I can't contribute a new "defaults" as that conflicts. > It would be nice to be able to override the strategy defined in > AbstractTextField. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (TAP5-1694) Ability to override the default NullFieldStrategy
[ https://issues.apache.org/jira/browse/TAP5-1694?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13126585#comment-13126585 ] David Sundsskard commented on TAP5-1694: The symbol feature in TAP5-1677 might be an option? > Ability to override the default NullFieldStrategy > - > > Key: TAP5-1694 > URL: https://issues.apache.org/jira/browse/TAP5-1694 > Project: Tapestry 5 > Issue Type: Wish > Components: tapestry-core >Affects Versions: 5.3 >Reporter: David Sundsskard > > My use-case is that I want empty textfields to post an empty String instead > of null. > I have implemented a nullfieldstrategy and it can be set on the textfield, > but components that create textfields on the fly (eg. Grid) use the default > NullFieldStrategy defined in AbstractTextField. > I can't contribute a new "defaults" as that conflicts. > It would be nice to be able to override the strategy defined in > AbstractTextField. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (TAP5-1677) Use Symbols for Default Component Parameter Values
[ https://issues.apache.org/jira/browse/TAP5-1677?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Massimo Lusetti resolved TAP5-1677. --- Resolution: Fixed Fix Version/s: 5.3 For now the components which could be defaulted to Symbol values are in others need some changes in the framework which are being discussed at the moment. > Use Symbols for Default Component Parameter Values > -- > > Key: TAP5-1677 > URL: https://issues.apache.org/jira/browse/TAP5-1677 > Project: Tapestry 5 > Issue Type: Improvement > Components: tapestry-core >Affects Versions: 5.3 >Reporter: Steve Eynon >Assignee: Massimo Lusetti >Priority: Minor > Fix For: 5.3 > > > For example, the Grid component has the following: > @Parameter("25") > private int rowsPerPage; > meaning if I wish for a pagination of 50 rows, I have to find all instances > of the Grid component in my application and manually add a "rowsPerPage" > parameter. > But if the parameter was defined as: > @Parameter("symbol:tapestry.grid.rowsPerPage") > private int rowsPerPage; > then all I would need to do is override the symbol contribution and voilà, it > changes throughout the whole application. > Other specific component defaults that would be nice are, the "update" > parameter for Zone et al (because the classic "yellow fade" doesn't work for > everyone!) and a date format for DateField. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
svn commit: r1182843 - in /tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5: ComponentsParametersConstants.java corelib/components/Zone.java services/TapestryModule.java
Author: mlusetti Date: Thu Oct 13 13:26:09 2011 New Revision: 1182843 URL: http://svn.apache.org/viewvc?rev=1182843&view=rev Log: TAP5-1677 Zone show and update defaults Modified: tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/ComponentsParametersConstants.java tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/corelib/components/Zone.java tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/services/TapestryModule.java Modified: tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/ComponentsParametersConstants.java URL: http://svn.apache.org/viewvc/tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/ComponentsParametersConstants.java?rev=1182843&r1=1182842&r2=1182843&view=diff == --- tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/ComponentsParametersConstants.java (original) +++ tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/ComponentsParametersConstants.java Thu Oct 13 13:26:09 2011 @@ -89,4 +89,18 @@ public class ComponentsParametersConstan */ public static final String PALETTE_ROWS_SIZE = "tapestry.components.palette_rows_size"; +/** + * The default name of a JS function attached to Tapestry.ElementEffect object to use for the initial + * visualization of a {@link org.apache.tapestry5.corelib.components.Zone}. + * Defaults to "show" + */ +public static final String ZONE_SHOW_METHOD = "tapestry.components.zone_show_method"; + +/** + * The default name of a JS function attached to Tapestry.ElementEffect object to point out an + * update on a {@link org.apache.tapestry5.corelib.components.Zone}. + * Defaults to "highlight" + */ +public static final String ZONE_UPDATE_METHOD = "tapestry.components.zone_update_method"; + } Modified: tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/corelib/components/Zone.java URL: http://svn.apache.org/viewvc/tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/corelib/components/Zone.java?rev=1182843&r1=1182842&r2=1182843&view=diff == --- tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/corelib/components/Zone.java (original) +++ tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/corelib/components/Zone.java Thu Oct 13 13:26:09 2011 @@ -20,6 +20,7 @@ import org.apache.tapestry5.CSSClassCons import org.apache.tapestry5.ClientBodyElement; import org.apache.tapestry5.ComponentAction; import org.apache.tapestry5.ComponentResources; +import org.apache.tapestry5.ComponentsParametersConstants; import org.apache.tapestry5.MarkupWriter; import org.apache.tapestry5.QueryParameterConstants; import org.apache.tapestry5.annotations.BeginRender; @@ -90,7 +91,8 @@ public class Zone implements ClientBodyE * Name of a function on the client-side Tapestry.ElementEffect object that is invoked to make the Zone's *visible before being updated. If not specified, then the basic "show" method is used. */ -@Parameter(defaultPrefix = BindingConstants.LITERAL) +@Parameter(defaultPrefix = BindingConstants.LITERAL, +value = BindingConstants.SYMBOL + ":" + ComponentsParametersConstants.ZONE_SHOW_METHOD) private String show; /** @@ -98,7 +100,8 @@ public class Zone implements ClientBodyE * been updated. If not specified, then the basic "highlight" method is used, which performs a classic "yellow fade" * to indicate to the user that and update has taken place. */ -@Parameter(defaultPrefix = BindingConstants.LITERAL) +@Parameter(defaultPrefix = BindingConstants.LITERAL, +value = BindingConstants.SYMBOL + ":" + ComponentsParametersConstants.ZONE_UPDATE_METHOD) private String update; /** Modified: tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/services/TapestryModule.java URL: http://svn.apache.org/viewvc/tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/services/TapestryModule.java?rev=1182843&r1=1182842&r2=1182843&view=diff == --- tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/services/TapestryModule.java (original) +++ tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/services/TapestryModule.java Thu Oct 13 13:26:09 2011 @@ -2373,6 +2373,10 @@ public final class TapestryModule // Palette component parameters defaults configuration.add(ComponentsParametersConstants.PALETTE_ROWS_SIZE, 10); + +// Zone component parameters defaults +configuration.add(ComponentsParametersConstants.Z
svn commit: r1182842 - in /tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5: ComponentsParametersConstants.java services/TapestryModule.java
Author: mlusetti Date: Thu Oct 13 13:24:33 2011 New Revision: 1182842 URL: http://svn.apache.org/viewvc?rev=1182842&view=rev Log: javadocs and typos Modified: tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/ComponentsParametersConstants.java tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/services/TapestryModule.java Modified: tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/ComponentsParametersConstants.java URL: http://svn.apache.org/viewvc/tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/ComponentsParametersConstants.java?rev=1182842&r1=1182841&r2=1182842&view=diff == --- tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/ComponentsParametersConstants.java (original) +++ tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/ComponentsParametersConstants.java Thu Oct 13 13:24:33 2011 @@ -84,10 +84,9 @@ public class ComponentsParametersConstan public static final String FORMINJECTOR_SHOW_FUNCTION = "tapestry.components.forminjector_show_function"; /** - * The default size of rows + * The default size of rows to display in a {@link org.apache.tapestry5.corelib.components.Palette} + * component. Default to 10. */ public static final String PALETTE_ROWS_SIZE = "tapestry.components.palette_rows_size"; - - } Modified: tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/services/TapestryModule.java URL: http://svn.apache.org/viewvc/tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/services/TapestryModule.java?rev=1182842&r1=1182841&r2=1182842&view=diff == --- tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/services/TapestryModule.java (original) +++ tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/services/TapestryModule.java Thu Oct 13 13:24:33 2011 @@ -2357,7 +2357,7 @@ public final class TapestryModule configuration.add(SymbolConstants.APPLICATION_FOLDER, ""); -// Grid components parameters defaults +// Grid component parameters defaults configuration.add(ComponentsParametersConstants.GRID_ROWS_PER_PAGE, GridConstants.ROWS_PER_PAGE); configuration.add(ComponentsParametersConstants.GRID_PAGER_POSITION, GridConstants.PAGER_POSITION); configuration.add(ComponentsParametersConstants.GRID_EMPTY_BLOCK, GridConstants.EMPTY_BLOCK); @@ -2367,11 +2367,11 @@ public final class TapestryModule configuration.add(ComponentsParametersConstants.GRIDCOLUMNS_ASCENDING_ASSET, GridConstants.COLUMNS_ASCENDING); configuration.add(ComponentsParametersConstants.GRIDCOLUMNS_DESCENDING_ASSET, GridConstants.COLUMNS_DESCENDING); -// FormInjector components parameters defaults +// FormInjector component parameters defaults configuration.add(ComponentsParametersConstants.FORMINJECTOR_INSERT_POSITION, "above"); configuration.add(ComponentsParametersConstants.FORMINJECTOR_SHOW_FUNCTION, "highlight"); -// Palette components parameters defaults +// Palette component parameters defaults configuration.add(ComponentsParametersConstants.PALETTE_ROWS_SIZE, 10); }
svn commit: r1182841 - in /tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5: ComponentsParametersConstants.java corelib/components/Palette.java services/TapestryModule.java
Author: mlusetti Date: Thu Oct 13 13:23:54 2011 New Revision: 1182841 URL: http://svn.apache.org/viewvc?rev=1182841&view=rev Log: TAP5-1677 Palette rows size Modified: tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/ComponentsParametersConstants.java tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/corelib/components/Palette.java tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/services/TapestryModule.java Modified: tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/ComponentsParametersConstants.java URL: http://svn.apache.org/viewvc/tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/ComponentsParametersConstants.java?rev=1182841&r1=1182840&r2=1182841&view=diff == --- tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/ComponentsParametersConstants.java (original) +++ tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/ComponentsParametersConstants.java Thu Oct 13 13:23:54 2011 @@ -83,6 +83,11 @@ public class ComponentsParametersConstan */ public static final String FORMINJECTOR_SHOW_FUNCTION = "tapestry.components.forminjector_show_function"; +/** + * The default size of rows + */ +public static final String PALETTE_ROWS_SIZE = "tapestry.components.palette_rows_size"; + } Modified: tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/corelib/components/Palette.java URL: http://svn.apache.org/viewvc/tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/corelib/components/Palette.java?rev=1182841&r1=1182840&r2=1182841&view=diff == --- tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/corelib/components/Palette.java (original) +++ tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/corelib/components/Palette.java Thu Oct 13 13:23:54 2011 @@ -285,7 +285,7 @@ public class Palette extends AbstractFie /** * Number of rows to display. */ -@Parameter(value = "10") +@Parameter(value = BindingConstants.SYMBOL + ":" + ComponentsParametersConstants.PALETTE_ROWS_SIZE) private int size; /** Modified: tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/services/TapestryModule.java URL: http://svn.apache.org/viewvc/tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/services/TapestryModule.java?rev=1182841&r1=1182840&r2=1182841&view=diff == --- tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/services/TapestryModule.java (original) +++ tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/services/TapestryModule.java Thu Oct 13 13:23:54 2011 @@ -2370,6 +2370,9 @@ public final class TapestryModule // FormInjector components parameters defaults configuration.add(ComponentsParametersConstants.FORMINJECTOR_INSERT_POSITION, "above"); configuration.add(ComponentsParametersConstants.FORMINJECTOR_SHOW_FUNCTION, "highlight"); + +// Palette components parameters defaults +configuration.add(ComponentsParametersConstants.PALETTE_ROWS_SIZE, 10); } /**
svn commit: r1182840 - in /tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5: ComponentsParametersConstants.java corelib/components/FormInjector.java services/TapestryModule.ja
Author: mlusetti Date: Thu Oct 13 13:23:28 2011 New Revision: 1182840 URL: http://svn.apache.org/viewvc?rev=1182840&view=rev Log: TAP5-1677 FormInjector show method Modified: tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/ComponentsParametersConstants.java tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/corelib/components/FormInjector.java tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/services/TapestryModule.java Modified: tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/ComponentsParametersConstants.java URL: http://svn.apache.org/viewvc/tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/ComponentsParametersConstants.java?rev=1182840&r1=1182839&r2=1182840&view=diff == --- tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/ComponentsParametersConstants.java (original) +++ tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/ComponentsParametersConstants.java Thu Oct 13 13:23:28 2011 @@ -76,6 +76,13 @@ public class ComponentsParametersConstan */ public static final String FORMINJECTOR_INSERT_POSITION = "tapestry.components.forminjector_insert_position"; +/** + * The default name for a JS function to use to show the injected content by + * {@link org.apache.tapestry5.corelib.components.FormInjector}. + * Default to "highlight". + */ +public static final String FORMINJECTOR_SHOW_FUNCTION = "tapestry.components.forminjector_show_function"; + } Modified: tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/corelib/components/FormInjector.java URL: http://svn.apache.org/viewvc/tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/corelib/components/FormInjector.java?rev=1182840&r1=1182839&r2=1182840&view=diff == --- tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/corelib/components/FormInjector.java (original) +++ tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/corelib/components/FormInjector.java Thu Oct 13 13:23:28 2011 @@ -64,9 +64,10 @@ public class FormInjector implements Cli /** * Name of a function on the client-side Tapestry.ElementEffect object that is invoked to make added content - * visible. Leaving as null uses the default function, "highlight". + * visible. The default value is "highlight". */ -@Parameter(defaultPrefix = BindingConstants.LITERAL) +@Parameter(defaultPrefix = BindingConstants.LITERAL, +value = BindingConstants.SYMBOL + ":" + ComponentsParametersConstants.FORMINJECTOR_SHOW_FUNCTION) private String show; /** Modified: tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/services/TapestryModule.java URL: http://svn.apache.org/viewvc/tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/services/TapestryModule.java?rev=1182840&r1=1182839&r2=1182840&view=diff == --- tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/services/TapestryModule.java (original) +++ tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/services/TapestryModule.java Thu Oct 13 13:23:28 2011 @@ -2369,6 +2369,7 @@ public final class TapestryModule // FormInjector components parameters defaults configuration.add(ComponentsParametersConstants.FORMINJECTOR_INSERT_POSITION, "above"); + configuration.add(ComponentsParametersConstants.FORMINJECTOR_SHOW_FUNCTION, "highlight"); } /**
svn commit: r1182838 - in /tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5: ComponentsParametersConstants.java corelib/components/FormInjector.java services/TapestryModule.ja
Author: mlusetti Date: Thu Oct 13 13:20:48 2011 New Revision: 1182838 URL: http://svn.apache.org/viewvc?rev=1182838&view=rev Log: TAP5-16777 Fix a typo in injector name Modified: tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/ComponentsParametersConstants.java tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/corelib/components/FormInjector.java tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/services/TapestryModule.java Modified: tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/ComponentsParametersConstants.java URL: http://svn.apache.org/viewvc/tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/ComponentsParametersConstants.java?rev=1182838&r1=1182837&r2=1182838&view=diff == --- tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/ComponentsParametersConstants.java (original) +++ tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/ComponentsParametersConstants.java Thu Oct 13 13:20:48 2011 @@ -74,6 +74,8 @@ public class ComponentsParametersConstan * The default position where to insert content into {@link org.apache.tapestry5.corelib.components.Form}. * Default to "above". */ -public static final String FORMINJECOTR_INSERT_POSITION= "tapestry.components.forminjector_insert_position"; +public static final String FORMINJECTOR_INSERT_POSITION = "tapestry.components.forminjector_insert_position"; + + } Modified: tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/corelib/components/FormInjector.java URL: http://svn.apache.org/viewvc/tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/corelib/components/FormInjector.java?rev=1182838&r1=1182837&r2=1182838&view=diff == --- tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/corelib/components/FormInjector.java (original) +++ tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/corelib/components/FormInjector.java Thu Oct 13 13:20:48 2011 @@ -20,29 +20,18 @@ import org.apache.tapestry5.*; import org.apache.tapestry5.annotations.Environmental; import org.apache.tapestry5.annotations.Events; import org.apache.tapestry5.annotations.Parameter; -import org.apache.tapestry5.annotations.RequestParameter; import org.apache.tapestry5.annotations.SupportsInformalParameters; import org.apache.tapestry5.corelib.data.InsertPosition; -import org.apache.tapestry5.corelib.internal.ComponentActionSink; -import org.apache.tapestry5.corelib.internal.HiddenFieldPositioner; -import org.apache.tapestry5.corelib.internal.InternalFormSupport; import org.apache.tapestry5.dom.Element; import org.apache.tapestry5.internal.services.PageRenderQueue; import org.apache.tapestry5.internal.services.RequestConstants; import org.apache.tapestry5.ioc.annotations.Inject; -import org.apache.tapestry5.ioc.util.IdAllocator; import org.apache.tapestry5.json.JSONObject; import org.apache.tapestry5.services.ClientBehaviorSupport; -import org.apache.tapestry5.services.ClientDataEncoder; -import org.apache.tapestry5.services.ComponentSource; -import org.apache.tapestry5.services.Environment; import org.apache.tapestry5.services.FormSupport; -import org.apache.tapestry5.services.Heartbeat; -import org.apache.tapestry5.services.HiddenFieldLocationRules; import org.apache.tapestry5.services.PartialMarkupRenderer; import org.apache.tapestry5.services.PartialMarkupRendererFilter; import org.apache.tapestry5.services.javascript.JavaScriptSupport; -import org.slf4j.Logger; /** * A way to add new content to an existing Form. The FormInjector emulates its tag from the template (or uses a @@ -70,7 +59,7 @@ public class FormInjector implements Cli private Object[] context; @Parameter(defaultPrefix = BindingConstants.LITERAL, -value = BindingConstants.SYMBOL + ":" + ComponentsParametersConstants.FORMINJECOTR_INSERT_POSITION) +value = BindingConstants.SYMBOL + ":" + ComponentsParametersConstants.FORMINJECTOR_INSERT_POSITION) private InsertPosition position; /** Modified: tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/services/TapestryModule.java URL: http://svn.apache.org/viewvc/tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/services/TapestryModule.java?rev=1182838&r1=1182837&r2=1182838&view=diff == --- tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/services/TapestryModule.java (original) +++ tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/services/TapestryModule.java Thu Oct 13 13:20:48 2011 @@ -2368,
svn commit: r1182837 - in /tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5: ComponentsParametersConstants.java corelib/components/FormInjector.java services/TapestryModule.ja
Author: mlusetti Date: Thu Oct 13 13:20:21 2011 New Revision: 1182837 URL: http://svn.apache.org/viewvc?rev=1182837&view=rev Log: TAP5-16777 FromInjector position parameter Modified: tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/ComponentsParametersConstants.java tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/corelib/components/FormInjector.java tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/services/TapestryModule.java Modified: tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/ComponentsParametersConstants.java URL: http://svn.apache.org/viewvc/tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/ComponentsParametersConstants.java?rev=1182837&r1=1182836&r2=1182837&view=diff == --- tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/ComponentsParametersConstants.java (original) +++ tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/ComponentsParametersConstants.java Thu Oct 13 13:20:21 2011 @@ -71,9 +71,9 @@ public class ComponentsParametersConstan public static final String GRIDCOLUMNS_SORTABLE_ASSET = "tapestry.components.gridcolumns_sortable_asset"; /** - * The default {@link org.apache.tapestry5.Asset} to display for - * {@link org.apache.tapestry5.corelib.components.Palette} deselect action. + * The default position where to insert content into {@link org.apache.tapestry5.corelib.components.Form}. + * Default to "above". */ -public static final String PALETTE_DESELECT_ASSET = "tapestry.components.palette_deselect_asset"; +public static final String FORMINJECOTR_INSERT_POSITION= "tapestry.components.forminjector_insert_position"; } Modified: tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/corelib/components/FormInjector.java URL: http://svn.apache.org/viewvc/tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/corelib/components/FormInjector.java?rev=1182837&r1=1182836&r2=1182837&view=diff == --- tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/corelib/components/FormInjector.java (original) +++ tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/corelib/components/FormInjector.java Thu Oct 13 13:20:21 2011 @@ -69,7 +69,8 @@ public class FormInjector implements Cli @Parameter private Object[] context; -@Parameter(defaultPrefix = BindingConstants.LITERAL, value = "above") +@Parameter(defaultPrefix = BindingConstants.LITERAL, +value = BindingConstants.SYMBOL + ":" + ComponentsParametersConstants.FORMINJECOTR_INSERT_POSITION) private InsertPosition position; /** Modified: tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/services/TapestryModule.java URL: http://svn.apache.org/viewvc/tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/services/TapestryModule.java?rev=1182837&r1=1182836&r2=1182837&view=diff == --- tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/services/TapestryModule.java (original) +++ tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/services/TapestryModule.java Thu Oct 13 13:20:21 2011 @@ -2357,7 +2357,7 @@ public final class TapestryModule configuration.add(SymbolConstants.APPLICATION_FOLDER, ""); -// Components parameters default +// Grid components parameters defaults configuration.add(ComponentsParametersConstants.GRID_ROWS_PER_PAGE, GridConstants.ROWS_PER_PAGE); configuration.add(ComponentsParametersConstants.GRID_PAGER_POSITION, GridConstants.PAGER_POSITION); configuration.add(ComponentsParametersConstants.GRID_EMPTY_BLOCK, GridConstants.EMPTY_BLOCK); @@ -2366,6 +2366,9 @@ public final class TapestryModule configuration.add(ComponentsParametersConstants.GRIDCOLUMNS_SORTABLE_ASSET, GridConstants.COLUMNS_SORTABLE); configuration.add(ComponentsParametersConstants.GRIDCOLUMNS_ASCENDING_ASSET, GridConstants.COLUMNS_ASCENDING); configuration.add(ComponentsParametersConstants.GRIDCOLUMNS_DESCENDING_ASSET, GridConstants.COLUMNS_DESCENDING); + +// FormInjector components parameters defaults + configuration.add(ComponentsParametersConstants.FORMINJECOTR_INSERT_POSITION, "above"); } /**
svn commit: r1182836 - /tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/PaletteConstants.java
Author: mlusetti Date: Thu Oct 13 13:19:38 2011 New Revision: 1182836 URL: http://svn.apache.org/viewvc?rev=1182836&view=rev Log: TAP5-1677 Unneeded now Removed: tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/PaletteConstants.java
[jira] [Created] (TAP5-1694) Ability to override the default NullFieldStrategy
Ability to override the default NullFieldStrategy - Key: TAP5-1694 URL: https://issues.apache.org/jira/browse/TAP5-1694 Project: Tapestry 5 Issue Type: Wish Components: tapestry-core Affects Versions: 5.3 Reporter: David Sundsskard My use-case is that I want empty textfields to post an empty String instead of null. I have implemented a nullfieldstrategy and it can be set on the textfield, but components that create textfields on the fly (eg. Grid) use the default NullFieldStrategy defined in AbstractTextField. I can't contribute a new "defaults" as that conflicts. It would be nice to be able to override the strategy defined in AbstractTextField. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (TAP5-1693) Improper Detection of "String" Beans in Symbol Injection
[ https://issues.apache.org/jira/browse/TAP5-1693?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Martin Papy updated TAP5-1693: -- Attachment: screenshot-1.jpg Eclipse Debug Mode We can clearly see : - the Spring "core-context.xml" file that defined the String Bean ( and in comment the JNDI lookup equivalent that is usually used ) - the TapestryModule class filewith the Debug pointbreak when trying to create a HttpServletRequestHandler - the wrong injected value "applicationCharset" (should display UTF-8) > Improper Detection of "String" Beans in Symbol Injection > > > Key: TAP5-1693 > URL: https://issues.apache.org/jira/browse/TAP5-1693 > Project: Tapestry 5 > Issue Type: Bug > Components: tapestry-ioc, tapestry-spring >Affects Versions: 5.3 >Reporter: Martin Papy >Priority: Blocker > Attachments: screenshot-1.jpg > > > I found a pretty confusing issue that seems Blocker to me. > In my project I am using a JNDI name to configure a piece of my application. > Basically in this case Spring creates of Bean of type "java.lang.String". > That was perfectly working under Tapestry 5.2.6. > Since I updated to 5.3-beta-19 1 time out of 3 the whole application if > failling because Tapestry cannot resolve Page Name anymore. > After digging it turns out that Tapestry is Injecting the value of this Bean > in several places where it should not : example applicationCharset or > startPageName. > Please see attached screenshots for better understanding. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Created] (TAP5-1693) Improper Detection of "String" Beans in Symbol Injection
Improper Detection of "String" Beans in Symbol Injection Key: TAP5-1693 URL: https://issues.apache.org/jira/browse/TAP5-1693 Project: Tapestry 5 Issue Type: Bug Components: tapestry-ioc, tapestry-spring Affects Versions: 5.3 Reporter: Martin Papy Priority: Blocker I found a pretty confusing issue that seems Blocker to me. In my project I am using a JNDI name to configure a piece of my application. Basically in this case Spring creates of Bean of type "java.lang.String". That was perfectly working under Tapestry 5.2.6. Since I updated to 5.3-beta-19 1 time out of 3 the whole application if failling because Tapestry cannot resolve Page Name anymore. After digging it turns out that Tapestry is Injecting the value of this Bean in several places where it should not : example applicationCharset or startPageName. Please see attached screenshots for better understanding. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Created] (TAP5-1692) Underscore.js should be used in no-conflict mude
Underscore.js should be used in no-conflict mude Key: TAP5-1692 URL: https://issues.apache.org/jira/browse/TAP5-1692 Project: Tapestry 5 Issue Type: Improvement Components: tapestry-core Affects Versions: 5.3 Reporter: Jochen Kemnade The userscore.js library shipped with Tapestry 5.3 is bound to window._. I suggest to use it in no-conflict mode and bind it for example to T5._ to avoid conflicts with third-party Javascript. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Created] (TAP5-1691) AssetPathConstructorImpl should URL-encode the application version
AssetPathConstructorImpl should URL-encode the application version -- Key: TAP5-1691 URL: https://issues.apache.org/jira/browse/TAP5-1691 Project: Tapestry 5 Issue Type: Bug Components: tapestry-core Affects Versions: 5.2.6 Reporter: Jochen Kemnade Priority: Minor When I deploy snapshot versions of T5 webapps, I usually extend the maven/gradle version number by an ISO timestamp. Therefore, my version number always contains a '+', ("...+0[12]00"). The asset urls generated by AssetPathConstructorImpl don't encode that plus using URLEncoder but ContextPathEncoderImpl.decodePath tries to decode the version string via URLEncoder.decode() which fails: java.lang.IllegalArgumentException: Input string '3.10.0-SNAPSHOT20111010T153002+0200' is not valid; the character '+' at position 31 is not valid. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
svn commit: r1182714 - /tapestry/tapestry5/trunk/settings.gradle
Author: mlusetti Date: Thu Oct 13 08:29:31 2011 New Revision: 1182714 URL: http://svn.apache.org/viewvc?rev=1182714&view=rev Log: small clean Modified: tapestry/tapestry5/trunk/settings.gradle Modified: tapestry/tapestry5/trunk/settings.gradle URL: http://svn.apache.org/viewvc/tapestry/tapestry5/trunk/settings.gradle?rev=1182714&r1=1182713&r2=1182714&view=diff == --- tapestry/tapestry5/trunk/settings.gradle (original) +++ tapestry/tapestry5/trunk/settings.gradle Thu Oct 13 08:29:31 2011 @@ -2,5 +2,5 @@ include "plastic", "tapestry5-annotation include "tapestry-hibernate-core", "tapestry-hibernate", "tapestry-jmx", "tapestry-upload", "tapestry-spring" include "tapestry-beanvalidator", "tapestry-yuicompressor", "tapestry-jpa", "tapestry-kaptcha" include "tapestry-javadoc", "quickstart" -// TODO (LATER): tapestry-component-report, quickstart +// TODO (LATER): tapestry-component-report