[jira] [Created] (TAP5-1703) Remove need for @Persist with AjaxFormLoop
Remove need for @Persist with AjaxFormLoop -- Key: TAP5-1703 URL: https://issues.apache.org/jira/browse/TAP5-1703 Project: Tapestry 5 Issue Type: Improvement Components: tapestry-core Affects Versions: 5.2.6 Reporter: Geoff Callender Regarding use of a submitted AjaxFormLoop, ie. no database changes until submitted; I have almost succeeded in avoiding the need to use @Persist, but I still need it to track the removal of original rows. You can see in this example that @Persist IS NOT needed to track added rows, nor removal of the added rows, but it IS needed to track removal of existing rows: http://jumpstart.doublenegative.com.au/jumpstart/examples/ajax/formloop1 (true as of JumpStart 5.4.21) Perhaps AjaxFormLoop could keep a list of the removed rows in their encoded form and return it through a parameter on submit? -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (TAP5-1703) Remove need for @Persist with AjaxFormLoop
[ https://issues.apache.org/jira/browse/TAP5-1703?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Geoff Callender updated TAP5-1703: -- Description: Regarding use of a submitted AjaxFormLoop, ie. no database changes until submitted; I have almost succeeded in avoiding the need to use @Persist, but I still need @Persist to track the removal of original rows. You can see in this example that @Persist IS NOT needed to track added rows, nor removal of the added rows, but it IS needed to track removal of original rows: http://jumpstart.doublenegative.com.au/jumpstart/examples/ajax/formloop1 (true as of JumpStart 5.4.21) Perhaps AjaxFormLoop could keep a list of the removed original rows in their encoded form and return it through a parameter on submit? was: Regarding use of a submitted AjaxFormLoop, ie. no database changes until submitted; I have almost succeeded in avoiding the need to use @Persist, but I still need it to track the removal of original rows. You can see in this example that @Persist IS NOT needed to track added rows, nor removal of the added rows, but it IS needed to track removal of existing rows: http://jumpstart.doublenegative.com.au/jumpstart/examples/ajax/formloop1 (true as of JumpStart 5.4.21) Perhaps AjaxFormLoop could keep a list of the removed rows in their encoded form and return it through a parameter on submit? Remove need for @Persist with AjaxFormLoop -- Key: TAP5-1703 URL: https://issues.apache.org/jira/browse/TAP5-1703 Project: Tapestry 5 Issue Type: Improvement Components: tapestry-core Affects Versions: 5.2.6 Reporter: Geoff Callender Regarding use of a submitted AjaxFormLoop, ie. no database changes until submitted; I have almost succeeded in avoiding the need to use @Persist, but I still need @Persist to track the removal of original rows. You can see in this example that @Persist IS NOT needed to track added rows, nor removal of the added rows, but it IS needed to track removal of original rows: http://jumpstart.doublenegative.com.au/jumpstart/examples/ajax/formloop1 (true as of JumpStart 5.4.21) Perhaps AjaxFormLoop could keep a list of the removed original rows in their encoded form and return it through a parameter on submit? -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
svn commit: r1185726 - /tapestry/tapestry5/trunk/tapestry-ioc/src/main/java/org/apache/tapestry5/ioc/internal/util/InternalUtils.java
Author: hlship
Date: Tue Oct 18 15:45:07 2011
New Revision: 1185726
URL: http://svn.apache.org/viewvc?rev=1185726view=rev
Log:
Delegate toString() methods when upgrading ServiceDef to ServiceDef2 (etc.)
Modified:
tapestry/tapestry5/trunk/tapestry-ioc/src/main/java/org/apache/tapestry5/ioc/internal/util/InternalUtils.java
Modified:
tapestry/tapestry5/trunk/tapestry-ioc/src/main/java/org/apache/tapestry5/ioc/internal/util/InternalUtils.java
URL:
http://svn.apache.org/viewvc/tapestry/tapestry5/trunk/tapestry-ioc/src/main/java/org/apache/tapestry5/ioc/internal/util/InternalUtils.java?rev=1185726r1=1185725r2=1185726view=diff
==
---
tapestry/tapestry5/trunk/tapestry-ioc/src/main/java/org/apache/tapestry5/ioc/internal/util/InternalUtils.java
(original)
+++
tapestry/tapestry5/trunk/tapestry-ioc/src/main/java/org/apache/tapestry5/ioc/internal/util/InternalUtils.java
Tue Oct 18 15:45:07 2011
@@ -16,11 +16,11 @@ package org.apache.tapestry5.ioc.interna
import org.apache.tapestry5.func.Mapper;
import org.apache.tapestry5.func.Predicate;
+import org.apache.tapestry5.internal.plastic.PlasticInternalUtils;
import org.apache.tapestry5.ioc.*;
import org.apache.tapestry5.ioc.annotations.*;
import org.apache.tapestry5.ioc.def.*;
import org.apache.tapestry5.ioc.internal.NullAnnotationProvider;
-import org.apache.tapestry5.ioc.services.ClassFabUtils;
import org.apache.tapestry5.ioc.services.Coercion;
import org.apache.tapestry5.ioc.services.PlasticProxyFactory;
import org.apache.tapestry5.plastic.MethodAdvice;
@@ -143,14 +143,6 @@ public class InternalUtils
}
/**
- * Strips leading characters defined by {@link InternalUtils#NAME_PREFIX},
then adds the prefix back in.
- */
-public static String createMemberName(String memberName)
-{
-return NAME_PREFIX + stripMemberName(memberName);
-}
-
-/**
* Converts an enumeration (of Strings) into a sorted list of Strings.
*/
public static ListString toList(Enumeration e)
@@ -258,7 +250,7 @@ public class InternalUtils
final Annotation[] annotations = parameterAnnotations[i];
String description = String.format(Determining injection value
for parameter #%d (%s), i + 1,
-ClassFabUtils.toJavaClassName(type));
+PlasticUtils.toTypeName(type));
final InvokableObject operation = new InvokableObject()
{
@@ -943,6 +935,12 @@ public class InternalUtils
{
return sd.isEagerLoad();
}
+
+@Override
+public String toString()
+{
+return sd.toString();
+}
};
}
@@ -1082,6 +1080,11 @@ public class InternalUtils
return contribution.getServiceId();
}
+@Override
+public String toString()
+{
+return contribution.toString();
+}
};
}
@@ -1131,6 +1134,12 @@ public class InternalUtils
{
return cd2.getServiceInterface();
}
+
+@Override
+public String toString()
+{
+return cd2.toString();
+}
};
}
@@ -1241,7 +1250,7 @@ public class InternalUtils
*/
public static boolean isLocalFile(Class clazz)
{
-String path = ClassFabUtils.getPathForClass(clazz);
+String path = PlasticInternalUtils.toClassPath(clazz.getName());
ClassLoader loader = clazz.getClassLoader();
@@ -1266,7 +1275,6 @@ public class InternalUtils
return new MapperS, T()
{
-
public T map(S value)
{
return coercion.coerce(value);
svn commit: r1185727 - in /tapestry/tapestry5/trunk/tapestry-core/src: main/java/org/apache/tapestry5/internal/services/ main/java/org/apache/tapestry5/services/ test/java/org/apache/tapestry5/interna
Author: hlship
Date: Tue Oct 18 15:45:13 2011
New Revision: 1185727
URL: http://svn.apache.org/viewvc?rev=1185727view=rev
Log:
Rename Tapestry's internal SessionFactory to TapestrySessionFactory (to avoid
name conflicts on this common service id)
Added:
tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/internal/services/TapestrySessionFactory.java
- copied, changed from r1185726,
tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/internal/services/SessionFactory.java
tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/internal/services/TapestrySessionFactoryImpl.java
- copied, changed from r1185726,
tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/internal/services/SessionFactoryImpl.java
Removed:
tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/internal/services/SessionFactory.java
tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/internal/services/SessionFactoryImpl.java
Modified:
tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/internal/services/RequestImpl.java
tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/services/TapestryModule.java
tapestry/tapestry5/trunk/tapestry-core/src/test/java/org/apache/tapestry5/internal/services/RequestImplTest.java
Modified:
tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/internal/services/RequestImpl.java
URL:
http://svn.apache.org/viewvc/tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/internal/services/RequestImpl.java?rev=1185727r1=1185726r2=1185727view=diff
==
---
tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/internal/services/RequestImpl.java
(original)
+++
tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/internal/services/RequestImpl.java
Tue Oct 18 15:45:13 2011
@@ -37,7 +37,7 @@ public class RequestImpl implements Requ
private final String requestEncoding;
-private final SessionFactory sessionFactory;
+private final TapestrySessionFactory sessionFactory;
private boolean encodingSet;
@@ -46,7 +46,7 @@ public class RequestImpl implements Requ
public RequestImpl(
HttpServletRequest request,
String requestEncoding,
-SessionFactory sessionFactory)
+TapestrySessionFactory sessionFactory)
{
this.request = request;
this.requestEncoding = requestEncoding;
Copied:
tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/internal/services/TapestrySessionFactory.java
(from r1185726,
tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/internal/services/SessionFactory.java)
URL:
http://svn.apache.org/viewvc/tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/internal/services/TapestrySessionFactory.java?p2=tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/internal/services/TapestrySessionFactory.javap1=tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/internal/services/SessionFactory.javar1=1185726r2=1185727rev=1185727view=diff
==
---
tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/internal/services/SessionFactory.java
(original)
+++
tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/internal/services/TapestrySessionFactory.java
Tue Oct 18 15:45:13 2011
@@ -17,13 +17,13 @@ package org.apache.tapestry5.internal.se
import org.apache.tapestry5.services.Session;
/**
- * Encapsulates logic for accessing the {@link Session} (a wrapper around the
{@link javax.servlet.http.HttpSession}).
+ * Encapsulates logic for accessing the Tapestry {@link Session} (a wrapper
around the {@link javax.servlet.http.HttpSession}).
*
- * @since 5.3
* @see SessionImpl
* @see ClusteredSessionImpl
+ * @since 5.3
*/
-public interface SessionFactory
+public interface TapestrySessionFactory
{
Session getSession(boolean create);
}
Copied:
tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/internal/services/TapestrySessionFactoryImpl.java
(from r1185726,
tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/internal/services/SessionFactoryImpl.java)
URL:
svn commit: r1185728 - in /tapestry/tapestry5/trunk/quickstart/prototypes/archetype-resources/src/main/webapp/layout: ./ images/
Author: hlship Date: Tue Oct 18 15:45:20 2011 New Revision: 1185728 URL: http://svn.apache.org/viewvc?rev=1185728view=rev Log: Fix broken images and CSS in the Quickstart layout Removed: tapestry/tapestry5/trunk/quickstart/prototypes/archetype-resources/src/main/webapp/layout/images/img02.jpg tapestry/tapestry5/trunk/quickstart/prototypes/archetype-resources/src/main/webapp/layout/images/img05.gif tapestry/tapestry5/trunk/quickstart/prototypes/archetype-resources/src/main/webapp/layout/images/img06.gif tapestry/tapestry5/trunk/quickstart/prototypes/archetype-resources/src/main/webapp/layout/images/img07.gif tapestry/tapestry5/trunk/quickstart/prototypes/archetype-resources/src/main/webapp/layout/images/img15.gif tapestry/tapestry5/trunk/quickstart/prototypes/archetype-resources/src/main/webapp/layout/images/img16.gif tapestry/tapestry5/trunk/quickstart/prototypes/archetype-resources/src/main/webapp/layout/images/img17.gif tapestry/tapestry5/trunk/quickstart/prototypes/archetype-resources/src/main/webapp/layout/images/spacer.gif Modified: tapestry/tapestry5/trunk/quickstart/prototypes/archetype-resources/src/main/webapp/layout/images/img01.jpg (contents, props changed) tapestry/tapestry5/trunk/quickstart/prototypes/archetype-resources/src/main/webapp/layout/images/img03.jpg (contents, props changed) tapestry/tapestry5/trunk/quickstart/prototypes/archetype-resources/src/main/webapp/layout/images/img04.jpg (contents, props changed) tapestry/tapestry5/trunk/quickstart/prototypes/archetype-resources/src/main/webapp/layout/images/img08.gif (contents, props changed) tapestry/tapestry5/trunk/quickstart/prototypes/archetype-resources/src/main/webapp/layout/images/img09.gif (contents, props changed) tapestry/tapestry5/trunk/quickstart/prototypes/archetype-resources/src/main/webapp/layout/images/img10.gif (contents, props changed) tapestry/tapestry5/trunk/quickstart/prototypes/archetype-resources/src/main/webapp/layout/images/img11.gif (contents, props changed) tapestry/tapestry5/trunk/quickstart/prototypes/archetype-resources/src/main/webapp/layout/images/img12.gif (contents, props changed) tapestry/tapestry5/trunk/quickstart/prototypes/archetype-resources/src/main/webapp/layout/images/img13.gif (contents, props changed) tapestry/tapestry5/trunk/quickstart/prototypes/archetype-resources/src/main/webapp/layout/images/img14.gif (contents, props changed) tapestry/tapestry5/trunk/quickstart/prototypes/archetype-resources/src/main/webapp/layout/images/img18.gif (contents, props changed) tapestry/tapestry5/trunk/quickstart/prototypes/archetype-resources/src/main/webapp/layout/images/img19.gif (contents, props changed) tapestry/tapestry5/trunk/quickstart/prototypes/archetype-resources/src/main/webapp/layout/images/img20.gif (contents, props changed) tapestry/tapestry5/trunk/quickstart/prototypes/archetype-resources/src/main/webapp/layout/layout.css tapestry/tapestry5/trunk/quickstart/prototypes/archetype-resources/src/main/webapp/layout/license.txt Modified: tapestry/tapestry5/trunk/quickstart/prototypes/archetype-resources/src/main/webapp/layout/images/img01.jpg URL: http://svn.apache.org/viewvc/tapestry/tapestry5/trunk/quickstart/prototypes/archetype-resources/src/main/webapp/layout/images/img01.jpg?rev=1185728r1=1185727r2=1185728view=diff == Binary files - no diff available. Propchange: tapestry/tapestry5/trunk/quickstart/prototypes/archetype-resources/src/main/webapp/layout/images/img01.jpg -- svn:executable = * Modified: tapestry/tapestry5/trunk/quickstart/prototypes/archetype-resources/src/main/webapp/layout/images/img03.jpg URL: http://svn.apache.org/viewvc/tapestry/tapestry5/trunk/quickstart/prototypes/archetype-resources/src/main/webapp/layout/images/img03.jpg?rev=1185728r1=1185727r2=1185728view=diff == Binary files - no diff available. Propchange: tapestry/tapestry5/trunk/quickstart/prototypes/archetype-resources/src/main/webapp/layout/images/img03.jpg -- svn:executable = * Modified: tapestry/tapestry5/trunk/quickstart/prototypes/archetype-resources/src/main/webapp/layout/images/img04.jpg URL: http://svn.apache.org/viewvc/tapestry/tapestry5/trunk/quickstart/prototypes/archetype-resources/src/main/webapp/layout/images/img04.jpg?rev=1185728r1=1185727r2=1185728view=diff == Binary files - no diff available. Propchange: tapestry/tapestry5/trunk/quickstart/prototypes/archetype-resources/src/main/webapp/layout/images/img04.jpg
svn commit: r1185729 - /tapestry/tapestry5/trunk/build.gradle
Author: hlship Date: Tue Oct 18 15:45:23 2011 New Revision: 1185729 URL: http://svn.apache.org/viewvc?rev=1185729view=rev Log: Advance version number to 5.3-beta-23 Modified: tapestry/tapestry5/trunk/build.gradle Modified: tapestry/tapestry5/trunk/build.gradle URL: http://svn.apache.org/viewvc/tapestry/tapestry5/trunk/build.gradle?rev=1185729r1=1185728r2=1185729view=diff == --- tapestry/tapestry5/trunk/build.gradle (original) +++ tapestry/tapestry5/trunk/build.gradle Tue Oct 18 15:45:23 2011 @@ -2,7 +2,7 @@ description = Apache Tapestry 5 Project // Remember that when generating a release, this should be incremented. Also don't forget to // tag the release in Subversion. -tapestryVersion = 5.3-beta-22 +tapestryVersion = 5.3-beta-23 jettyVersion = '7.0.0.v20091005' tomcatVersion = '6.0.30'
svn commit: r1185890 - in /tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5: Asset2.java alerts/AlertManager.java
Author: hlship
Date: Tue Oct 18 21:48:01 2011
New Revision: 1185890
URL: http://svn.apache.org/viewvc?rev=1185890view=rev
Log:
Minor JavaDoc fixes
Modified:
tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/Asset2.java
tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/alerts/AlertManager.java
Modified:
tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/Asset2.java
URL:
http://svn.apache.org/viewvc/tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/Asset2.java?rev=1185890r1=1185889r2=1185890view=diff
==
---
tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/Asset2.java
(original)
+++
tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/Asset2.java
Tue Oct 18 21:48:01 2011
@@ -27,7 +27,7 @@ public interface Asset2 extends Asset
{
/**
* Returns true if the Asset is invariant (meaning that it returns the
same value from {@link Asset#toClientURL()}
- * at all times}. Assets that are used as binding values will be cached
more aggresively by Tapestry as they are
+ * at all times). Most Assets are invariant. Assets that are used as
binding values will be cached more aggressively by Tapestry if they are
* invariant.
*
* @return true if invariant
Modified:
tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/alerts/AlertManager.java
URL:
http://svn.apache.org/viewvc/tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/alerts/AlertManager.java?rev=1185890r1=1185889r2=1185890view=diff
==
---
tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/alerts/AlertManager.java
(original)
+++
tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/alerts/AlertManager.java
Tue Oct 18 21:48:01 2011
@@ -30,14 +30,14 @@ public interface AlertManager
void info(String message);
/**
- * Adds an {@link Severity#INFO} alert with the default duration, {@link
Duration#SINGLE}.
+ * Adds an {@link Severity#WARN} alert with the default duration, {@link
Duration#SINGLE}.
*
* @param message to present to the user
*/
void warn(String message);
/**
- * Adds an {@link Severity#INFO} alert with the default duration, {@link
Duration#SINGLE}.
+ * Adds an {@link Severity#ERROR} alert with the default duration, {@link
Duration#SINGLE}.
*
* @param message to present to the user
*/
[jira] [Reopened] (TAP5-724) Tapestry generates invalid HTML (for strict and transitional doctypes)
[ https://issues.apache.org/jira/browse/TAP5-724?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Howard M. Lewis Ship reopened TAP5-724: --- Tapestry generates invalid HTML (for strict and transitional doctypes) -- Key: TAP5-724 URL: https://issues.apache.org/jira/browse/TAP5-724 Project: Tapestry 5 Issue Type: Bug Affects Versions: 5.1.0.5 Reporter: Sergey Didenko Assignee: Howard M. Lewis Ship Priority: Minor Fix For: 5.3 As http://validator.w3.org/check tells, HTML documents generated from Tapestry are invalid. xHTMLs are valid. I.e. using !DOCTYPE HTML PUBLIC -//W3C//DTD HTML 4.01//EN http://www.w3.org/TR/html4/strict.dtd; or !DOCTYPE HTML PUBLIC -//W3C//DTD HTML 4.01 Transitional//EN http://www.w3.org/TR/html4/loose.dtd; leads to invalid documents. The errors are: - Attribute XMLNS is not a valid attribute. ...html xmlns=http://www.w3.org/1999/xhtml; - end tag for element LINK which is not open ...tapestry/5.1.0.5/default.css/linklink type=text/css rel=stylesheet h - end tag for element META which is not open ...on 5.1.0.5) name=generator/meta/head -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
svn commit: r1185893 - /tapestry/tapestry5/trunk/build.gradle
Author: hlship Date: Tue Oct 18 21:50:33 2011 New Revision: 1185893 URL: http://svn.apache.org/viewvc?rev=1185893view=rev Log: Advance version number to 5.3-beta-24 Modified: tapestry/tapestry5/trunk/build.gradle Modified: tapestry/tapestry5/trunk/build.gradle URL: http://svn.apache.org/viewvc/tapestry/tapestry5/trunk/build.gradle?rev=1185893r1=1185892r2=1185893view=diff == --- tapestry/tapestry5/trunk/build.gradle (original) +++ tapestry/tapestry5/trunk/build.gradle Tue Oct 18 21:50:33 2011 @@ -2,7 +2,7 @@ description = Apache Tapestry 5 Project // Remember that when generating a release, this should be incremented. Also don't forget to // tag the release in Subversion. -tapestryVersion = 5.3-beta-23 +tapestryVersion = 5.3-beta-24 jettyVersion = '7.0.0.v20091005' tomcatVersion = '6.0.30'
[jira] [Closed] (TAP5-724) Tapestry generates invalid HTML (for strict and transitional doctypes)
[ https://issues.apache.org/jira/browse/TAP5-724?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Howard M. Lewis Ship closed TAP5-724. - Resolution: Won't Fix Fix Version/s: (was: 5.3) I've reverted this fix and will close the issue without fixing. Basically, as soon as I put this into use on an existing app, the page layout got completely screwed. Apparently, browsers prefer their markup broken. You can use meta-data to force Tapestry to use the XML (not HTML) renderer, by setting the page content type. Tapestry generates invalid HTML (for strict and transitional doctypes) -- Key: TAP5-724 URL: https://issues.apache.org/jira/browse/TAP5-724 Project: Tapestry 5 Issue Type: Bug Affects Versions: 5.1.0.5 Reporter: Sergey Didenko Assignee: Howard M. Lewis Ship Priority: Minor As http://validator.w3.org/check tells, HTML documents generated from Tapestry are invalid. xHTMLs are valid. I.e. using !DOCTYPE HTML PUBLIC -//W3C//DTD HTML 4.01//EN http://www.w3.org/TR/html4/strict.dtd; or !DOCTYPE HTML PUBLIC -//W3C//DTD HTML 4.01 Transitional//EN http://www.w3.org/TR/html4/loose.dtd; leads to invalid documents. The errors are: - Attribute XMLNS is not a valid attribute. ...html xmlns=http://www.w3.org/1999/xhtml; - end tag for element LINK which is not open ...tapestry/5.1.0.5/default.css/linklink type=text/css rel=stylesheet h - end tag for element META which is not open ...on 5.1.0.5) name=generator/meta/head -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (TAP5-724) Tapestry generates invalid HTML (for strict and transitional doctypes)
[ https://issues.apache.org/jira/browse/TAP5-724?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13130095#comment-13130095 ] Hudson commented on TAP5-724: - Integrated in tapestry-trunk-freestyle #583 (See [https://builds.apache.org/job/tapestry-trunk-freestyle/583/]) Revert TAP5-724: Tapestry generates invalid HTML (for strict and transitional doctypes) This reverts commit 53ed2911464dafe16b26e7776883091cebf27430. hlship : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVNview=revrev=1185891 Files : * /tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/dom/DefaultMarkupModel.java * /tapestry/tapestry5/trunk/tapestry-core/src/test/resources/org/apache/tapestry5/internal/services/added_scripts_go_before_existing_script.txt * /tapestry/tapestry5/trunk/tapestry-core/src/test/resources/org/apache/tapestry5/internal/services/ie_conditional_stylesheet.txt * /tapestry/tapestry5/trunk/tapestry-core/src/test/resources/org/apache/tapestry5/internal/services/immediate_initialization.txt * /tapestry/tapestry5/trunk/tapestry-core/src/test/resources/org/apache/tapestry5/internal/services/other_initialization.txt * /tapestry/tapestry5/trunk/tapestry-core/src/test/resources/org/apache/tapestry5/internal/services/pretty_print_initialization.txt Tapestry generates invalid HTML (for strict and transitional doctypes) -- Key: TAP5-724 URL: https://issues.apache.org/jira/browse/TAP5-724 Project: Tapestry 5 Issue Type: Bug Affects Versions: 5.1.0.5 Reporter: Sergey Didenko Assignee: Howard M. Lewis Ship Priority: Minor As http://validator.w3.org/check tells, HTML documents generated from Tapestry are invalid. xHTMLs are valid. I.e. using !DOCTYPE HTML PUBLIC -//W3C//DTD HTML 4.01//EN http://www.w3.org/TR/html4/strict.dtd; or !DOCTYPE HTML PUBLIC -//W3C//DTD HTML 4.01 Transitional//EN http://www.w3.org/TR/html4/loose.dtd; leads to invalid documents. The errors are: - Attribute XMLNS is not a valid attribute. ...html xmlns=http://www.w3.org/1999/xhtml; - end tag for element LINK which is not open ...tapestry/5.1.0.5/default.css/linklink type=text/css rel=stylesheet h - end tag for element META which is not open ...on 5.1.0.5) name=generator/meta/head -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
svn commit: r1185914 - /tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/corelib/components/Form.java
Author: hlship
Date: Tue Oct 18 22:56:47 2011
New Revision: 1185914
URL: http://svn.apache.org/viewvc?rev=1185914view=rev
Log:
TAP5-724: Restore informal parameters support to Form component
Modified:
tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/corelib/components/Form.java
Modified:
tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/corelib/components/Form.java
URL:
http://svn.apache.org/viewvc/tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/corelib/components/Form.java?rev=1185914r1=1185913r2=1185914view=diff
==
---
tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/corelib/components/Form.java
(original)
+++
tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/corelib/components/Form.java
Tue Oct 18 22:56:47 2011
@@ -88,6 +88,7 @@ import java.io.ObjectInputStream;
@Events(
{EventConstants.PREPARE_FOR_RENDER, EventConstants.PREPARE,
EventConstants.PREPARE_FOR_SUBMIT,
EventConstants.VALIDATE, EventConstants.SUBMIT,
EventConstants.FAILURE, EventConstants.SUCCESS, EventConstants.CANCELED})
+@SupportsInformalParameters
public class Form implements ClientElement, FormValidationControl
{
/**
[jira] [Reopened] (TAP5-724) Tapestry generates invalid HTML (for strict and transitional doctypes)
[ https://issues.apache.org/jira/browse/TAP5-724?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Howard M. Lewis Ship reopened TAP5-724: --- Tapestry generates invalid HTML (for strict and transitional doctypes) -- Key: TAP5-724 URL: https://issues.apache.org/jira/browse/TAP5-724 Project: Tapestry 5 Issue Type: Bug Affects Versions: 5.1.0.5 Reporter: Sergey Didenko Assignee: Howard M. Lewis Ship Priority: Minor As http://validator.w3.org/check tells, HTML documents generated from Tapestry are invalid. xHTMLs are valid. I.e. using !DOCTYPE HTML PUBLIC -//W3C//DTD HTML 4.01//EN http://www.w3.org/TR/html4/strict.dtd; or !DOCTYPE HTML PUBLIC -//W3C//DTD HTML 4.01 Transitional//EN http://www.w3.org/TR/html4/loose.dtd; leads to invalid documents. The errors are: - Attribute XMLNS is not a valid attribute. ...html xmlns=http://www.w3.org/1999/xhtml; - end tag for element LINK which is not open ...tapestry/5.1.0.5/default.css/linklink type=text/css rel=stylesheet h - end tag for element META which is not open ...on 5.1.0.5) name=generator/meta/head -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Closed] (TAP5-724) Tapestry generates invalid HTML (for strict and transitional doctypes)
[ https://issues.apache.org/jira/browse/TAP5-724?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Howard M. Lewis Ship closed TAP5-724. - Resolution: Fixed Fix Version/s: 5.3 Sorry for the thrashing ... the actual bug was caused by Form no longer supporting informal parameters. That's fixed and the corrected HTML markup output is revealed to not be the cause of the layout problems I was seeing. Jumped the gun ... this is fixed in 5.3-beta-24. Tapestry generates invalid HTML (for strict and transitional doctypes) -- Key: TAP5-724 URL: https://issues.apache.org/jira/browse/TAP5-724 Project: Tapestry 5 Issue Type: Bug Affects Versions: 5.1.0.5 Reporter: Sergey Didenko Assignee: Howard M. Lewis Ship Priority: Minor Fix For: 5.3 As http://validator.w3.org/check tells, HTML documents generated from Tapestry are invalid. xHTMLs are valid. I.e. using !DOCTYPE HTML PUBLIC -//W3C//DTD HTML 4.01//EN http://www.w3.org/TR/html4/strict.dtd; or !DOCTYPE HTML PUBLIC -//W3C//DTD HTML 4.01 Transitional//EN http://www.w3.org/TR/html4/loose.dtd; leads to invalid documents. The errors are: - Attribute XMLNS is not a valid attribute. ...html xmlns=http://www.w3.org/1999/xhtml; - end tag for element LINK which is not open ...tapestry/5.1.0.5/default.css/linklink type=text/css rel=stylesheet h - end tag for element META which is not open ...on 5.1.0.5) name=generator/meta/head -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (TAP5-724) Tapestry generates invalid HTML (for strict and transitional doctypes)
[ https://issues.apache.org/jira/browse/TAP5-724?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13130123#comment-13130123 ] Hudson commented on TAP5-724: - Integrated in tapestry-trunk-freestyle #584 (See [https://builds.apache.org/job/tapestry-trunk-freestyle/584/]) TAP5-724: Restore informal parameters support to Form component TAP5-724: Tapestry generates invalid HTML (for strict and transitional doctypes) hlship : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVNview=revrev=1185914 Files : * /tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/corelib/components/Form.java hlship : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVNview=revrev=1185913 Files : * /tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/dom/DefaultMarkupModel.java * /tapestry/tapestry5/trunk/tapestry-core/src/test/resources/org/apache/tapestry5/internal/services/added_scripts_go_before_existing_script.txt * /tapestry/tapestry5/trunk/tapestry-core/src/test/resources/org/apache/tapestry5/internal/services/ie_conditional_stylesheet.txt * /tapestry/tapestry5/trunk/tapestry-core/src/test/resources/org/apache/tapestry5/internal/services/immediate_initialization.txt * /tapestry/tapestry5/trunk/tapestry-core/src/test/resources/org/apache/tapestry5/internal/services/other_initialization.txt * /tapestry/tapestry5/trunk/tapestry-core/src/test/resources/org/apache/tapestry5/internal/services/pretty_print_initialization.txt Tapestry generates invalid HTML (for strict and transitional doctypes) -- Key: TAP5-724 URL: https://issues.apache.org/jira/browse/TAP5-724 Project: Tapestry 5 Issue Type: Bug Affects Versions: 5.1.0.5 Reporter: Sergey Didenko Assignee: Howard M. Lewis Ship Priority: Minor Fix For: 5.3 As http://validator.w3.org/check tells, HTML documents generated from Tapestry are invalid. xHTMLs are valid. I.e. using !DOCTYPE HTML PUBLIC -//W3C//DTD HTML 4.01//EN http://www.w3.org/TR/html4/strict.dtd; or !DOCTYPE HTML PUBLIC -//W3C//DTD HTML 4.01 Transitional//EN http://www.w3.org/TR/html4/loose.dtd; leads to invalid documents. The errors are: - Attribute XMLNS is not a valid attribute. ...html xmlns=http://www.w3.org/1999/xhtml; - end tag for element LINK which is not open ...tapestry/5.1.0.5/default.css/linklink type=text/css rel=stylesheet h - end tag for element META which is not open ...on 5.1.0.5) name=generator/meta/head -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (TAP5-1695) Firefox on Linux can not dismiss the Ajax exception report iframe
[ https://issues.apache.org/jira/browse/TAP5-1695?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Howard M. Lewis Ship resolved TAP5-1695. Resolution: Cannot Reproduce Assignee: Howard M. Lewis Ship I can't reproduce this either. It may be something specific about my client's application. Firefox on Linux can not dismiss the Ajax exception report iframe - Key: TAP5-1695 URL: https://issues.apache.org/jira/browse/TAP5-1695 Project: Tapestry 5 Issue Type: Bug Components: tapestry-core Affects Versions: 5.3 Reporter: Howard M. Lewis Ship Assignee: Howard M. Lewis Ship Priority: Critical Labels: ajax, exception-reporting, linux Attachments: close-exception-report.png Using Firefox on Linux, when the exception report came up, the close button didn't work, but wrote an exception into the console. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (TAP5-1424) IOC class loading issue in OSGi
[
https://issues.apache.org/jira/browse/TAP5-1424?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13130133#comment-13130133
]
Howard M. Lewis Ship commented on TAP5-1424:
This may work correctly under 5.3; the new PlasticClassLoader (part of plastic,
replacing Javassist with ASM) does not have all the characteristics your
describe as causing problems.
I'm going to close the issue; you can retest with a recent beta (say
5.3-beta-24) and re-open if the issue is still present.
IOC class loading issue in OSGi
---
Key: TAP5-1424
URL: https://issues.apache.org/jira/browse/TAP5-1424
Project: Tapestry 5
Issue Type: Bug
Components: tapestry-ioc
Affects Versions: 5.2.4, 5.1.0.5
Reporter: Richard Schurig
Priority: Critical
Attachments: bundle.a-1.0.0-SNAPSHOT.jar, bundle.a.zip,
bundle.b-1.0.0-SNAPSHOT.jar, bundle.b.zip
we're using Tapestry IOC in an OSGi environment (Equinox 3.4) and recently
discovered some serious class loading issues when installing multiple
versions of the Tapestry Jars (5.1.0.5 and 5.2.4).
the problem itself lies in the class ClassFactoryClassPool, which picks up
every class loader from every class it ever sees. this completely bypasses
the OSGi way of class loading!
see the 2 attached bundles for an example: bundle A is using T5.1 and bundle
B is using T5.2. but B is also using imports from A for implementing a
service, an every day scenario in OSGi. now what happens: the IOC registry
starting in bundle B is proxying some class in its bundle, which has
references to a class in A. this results in ClassFactoryClassPool picking up
the class loader of bundle A also and therefore seeing all T5.1 classes. so
you end up with two Tap versions in allLoaders, and it's just a matter of
timing, if you have a working sequence in the chain.
i managed to produce a non working sequence that raises an exception:
Caused by: compile error: getCoercion(java.lang.Class,java.lang.Class) not
found in org.apache.tapestry5.ioc.services.TypeCoercer
this happens because the T5.1 classes are picked instead of T5.2 in bundle B
and getCoercion did not exist in that version. but T5.1 should not be visible
to bundle B since it neither includes nor imports its classes.
the solution seems to be just using the thread context class loader, which
(properly set) provides all the classes needed by IOC, at least in OSGi. i
tested the solution by modifying ClassFactoryClassPool like that:
public ClassFactoryClassPool(ClassLoader contextClassLoader)
{
super(null);
ClassPath path = new LoaderClassPath(contextClassLoader);
insertClassPath(path);
}
public synchronized void addClassLoaderIfNeeded(ClassLoader loader)
{
// Just do nothing
}
This worked for me: in the first place a lot of ClassNotFoundExceptions
occurred, revealing all the classes that we're accessible by bypassing the
OSGi bundle class Loader, but after adding them to the imports of my bundle,
everything was fine.
as i did not understand the purpose of the sophisticated class loader
handling, i assume that the above is not a fix option. but maybe some kind of
switch can be implemented, that turns off class loader collecting on demand.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (TAP5-1351) Multiple Grids with pagination on one page interfer with each oter
[ https://issues.apache.org/jira/browse/TAP5-1351?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Howard M. Lewis Ship updated TAP5-1351: --- Priority: Major (was: Critical) Apparently there's a workaround, so it's annoying but not critical. Multiple Grids with pagination on one page interfer with each oter -- Key: TAP5-1351 URL: https://issues.apache.org/jira/browse/TAP5-1351 Project: Tapestry 5 Issue Type: Bug Components: tapestry-core Affects Versions: 5.0.15 Reporter: Oliver Pelz If more than one grid with pagination will be created on a single tapestry page, the pagination interfer each other. This seems because the multiple grids/paginations do not have unique ids. I issued this in tapestry-users a while back where I enclosed the grids into components but this also happens if you put more them unenclosed on the same page (http://tapestry-users.832.n2.nabble.com/Grids-embedded-in-custom-component-interfer-with-each-other-td5376183.html). If you then click on a pagination from one grid the others will be changed as well. You can find a testcode on the tapestry-users page here http://tapestry-users.832.n2.nabble.com/Grids-embedded-in-custom-component-interfer-with-each-other-td5376183.html which capsulates the grids into components but this interefers as well as putting multiple grids without components on the same page. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (TAP5-1424) IOC class loading issue in OSGi
[
https://issues.apache.org/jira/browse/TAP5-1424?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Howard M. Lewis Ship resolved TAP5-1424.
Resolution: Incomplete
Assignee: Howard M. Lewis Ship
Incomplete: don't know if it is still a problem in 5.3.
IOC class loading issue in OSGi
---
Key: TAP5-1424
URL: https://issues.apache.org/jira/browse/TAP5-1424
Project: Tapestry 5
Issue Type: Bug
Components: tapestry-ioc
Affects Versions: 5.2.4, 5.1.0.5
Reporter: Richard Schurig
Assignee: Howard M. Lewis Ship
Priority: Critical
Attachments: bundle.a-1.0.0-SNAPSHOT.jar, bundle.a.zip,
bundle.b-1.0.0-SNAPSHOT.jar, bundle.b.zip
we're using Tapestry IOC in an OSGi environment (Equinox 3.4) and recently
discovered some serious class loading issues when installing multiple
versions of the Tapestry Jars (5.1.0.5 and 5.2.4).
the problem itself lies in the class ClassFactoryClassPool, which picks up
every class loader from every class it ever sees. this completely bypasses
the OSGi way of class loading!
see the 2 attached bundles for an example: bundle A is using T5.1 and bundle
B is using T5.2. but B is also using imports from A for implementing a
service, an every day scenario in OSGi. now what happens: the IOC registry
starting in bundle B is proxying some class in its bundle, which has
references to a class in A. this results in ClassFactoryClassPool picking up
the class loader of bundle A also and therefore seeing all T5.1 classes. so
you end up with two Tap versions in allLoaders, and it's just a matter of
timing, if you have a working sequence in the chain.
i managed to produce a non working sequence that raises an exception:
Caused by: compile error: getCoercion(java.lang.Class,java.lang.Class) not
found in org.apache.tapestry5.ioc.services.TypeCoercer
this happens because the T5.1 classes are picked instead of T5.2 in bundle B
and getCoercion did not exist in that version. but T5.1 should not be visible
to bundle B since it neither includes nor imports its classes.
the solution seems to be just using the thread context class loader, which
(properly set) provides all the classes needed by IOC, at least in OSGi. i
tested the solution by modifying ClassFactoryClassPool like that:
public ClassFactoryClassPool(ClassLoader contextClassLoader)
{
super(null);
ClassPath path = new LoaderClassPath(contextClassLoader);
insertClassPath(path);
}
public synchronized void addClassLoaderIfNeeded(ClassLoader loader)
{
// Just do nothing
}
This worked for me: in the first place a lot of ClassNotFoundExceptions
occurred, revealing all the classes that we're accessible by bypassing the
OSGi bundle class Loader, but after adding them to the imports of my bundle,
everything was fine.
as i did not understand the purpose of the sophisticated class loader
handling, i assume that the above is not a fix option. but maybe some kind of
switch can be implemented, that turns off class loader collecting on demand.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (TAP5-1284) When using @PageActivationContext and override a no-args activate event handler of parent page, the handler called too soon
[
https://issues.apache.org/jira/browse/TAP5-1284?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Howard M. Lewis Ship resolved TAP5-1284.
Resolution: Invalid
Assignee: Howard M. Lewis Ship
Sometimes Tapestry is what it is. Perhaps the activate event should be
followed by an additional event, used to verify the page. That would eliminate
some of the problems related to order of operations between base-classes and
sub-classes.
Or you could simply avoid using base classes. Old habits die hard.
When using @PageActivationContext and override a no-args activate event
handler of parent page, the handler called too soon
---
Key: TAP5-1284
URL: https://issues.apache.org/jira/browse/TAP5-1284
Project: Tapestry 5
Issue Type: Bug
Components: tapestry-core
Affects Versions: 5.2.0
Reporter: Alexander Gavrilov
Assignee: Howard M. Lewis Ship
Priority: Critical
It appears that the overrided onActivate() method is called before the
@PageActivationContext logic, which means the following can fail:
public class BasePage {
private MyEntity entity;
protected void setEntity(MyEntity entity) {
this.entity = entity;
}
protected void onActivate() {
if (entity == null) throw new RuntimeException(Entity not found.);
}
}
public class ConcreteClass {
@PageActivationContext
private MyEntity entity;
protected void onActivate() {
setEntity(entity);
super.onActivate();
}
}
Workaround is do not use methods overriding.
The problem is the consecuence of Howard's approach: if the child class
*overrides* a method of the parent, then the overridden method will be
invoked only by the parent class. When Tapestry performs transformation it
skips OnEventWorker advice, which invoke event handler method of subclass and
add it only for parent class. And required for @PageActivationContext chain
of invocation breaks. My approach is that if some class override some event
handler method of some class then Tapestry should stop advaicing parent class
method invocation and should rely on subclass method definition and is the
subclass implementor responibility to invoke parent class method.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Closed] (TAP5-1302) tapestry-component-report fails due to doxia dependency error
[ https://issues.apache.org/jira/browse/TAP5-1302?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Howard M. Lewis Ship closed TAP5-1302. -- Resolution: Won't Fix Assignee: Howard M. Lewis Ship The tapestry-component-report is gone in 5.3, replaced with a JavaDoc plugin. tapestry-component-report fails due to doxia dependency error - Key: TAP5-1302 URL: https://issues.apache.org/jira/browse/TAP5-1302 Project: Tapestry 5 Issue Type: Bug Components: tapestry-component-report Affects Versions: 5.2.0, 5.1.0.5 Reporter: Inge Assignee: Howard M. Lewis Ship Priority: Critical First of all, I encountered this bug, which prevents component report to run on Windows 7: https://issues.apache.org/jira/browse/TAP5-871 After applying the patch found in that issue, I ran into the next one: java.lang.NoSuchMethodError: org.apache.maven.doxia.module.xhtml.XhtmlSink.writeEndTagWithoutEOL(Ljavax/swing/text/html/HTML$Tag;)V at org.apache.maven.doxia.module.xhtml.XhtmlSink.link_(XhtmlSink.java:1066) at org.apache.tapestry.mojo.ComponentReport.executeReport(ComponentReport.java:240) at org.apache.maven.reporting.AbstractMavenReport.generate(AbstractMavenReport.java:90) at org.apache.maven.reporting.AbstractMavenReport.execute(AbstractMavenReport.java:65) at org.apache.maven.plugin.DefaultPluginManager.executeMojo(DefaultPluginManager.java:454) at org.apache.maven.lifecycle.DefaultLifecycleExecutor.executeGoals(DefaultLifecycleExecutor.java:559) at org.apache.maven.lifecycle.DefaultLifecycleExecutor.executeStandaloneGoal(DefaultLifecycleExecutor.java:513) at org.apache.maven.lifecycle.DefaultLifecycleExecutor.executeGoal(DefaultLifecycleExecutor.java:483) at org.apache.maven.lifecycle.DefaultLifecycleExecutor.executeGoalAndHandleFailures(DefaultLifecycleExecutor.java:331) at org.apache.maven.lifecycle.DefaultLifecycleExecutor.executeTaskSegments(DefaultLifecycleExecutor.java:292) at org.apache.maven.lifecycle.DefaultLifecycleExecutor.execute(DefaultLifecycleExecutor.java:142) at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:345) at org.apache.maven.DefaultMaven.execute(DefaultMaven.java:132) at org.apache.maven.cli.MavenCli.main(MavenCli.java:290) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25) at java.lang.reflect.Method.invoke(Method.java:592) at org.codehaus.classworlds.Launcher.launchEnhanced(Launcher.java:315) at org.codehaus.classworlds.Launcher.launch(Launcher.java:255) at org.codehaus.classworlds.Launcher.mainWithExitCode(Launcher.java:430) at org.codehaus.classworlds.Launcher.main(Launcher.java:375) -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Closed] (TAP5-1646) When a subclass defines a parameter with a given name that conflicts with a parameter of the superclass, Tapestry should throw an exception at page construction time; inste
[ https://issues.apache.org/jira/browse/TAP5-1646?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Howard M. Lewis Ship closed TAP5-1646. -- Resolution: Duplicate Assignee: Howard M. Lewis Ship Fixed as TAP5-1675. When a subclass defines a parameter with a given name that conflicts with a parameter of the superclass, Tapestry should throw an exception at page construction time; instead the field in the subclass seems to be null (a change in behavior from 5.2) - Key: TAP5-1646 URL: https://issues.apache.org/jira/browse/TAP5-1646 Project: Tapestry 5 Issue Type: Bug Components: tapestry-core Affects Versions: 5.3 Reporter: Howard M. Lewis Ship Assignee: Howard M. Lewis Ship To reiterate: Base class defines a @Parameter field Sub class defines another field, same name, also @Parameter In the subclass, the value for the field is null I believe 5.2 handled this better, though I'm not sure. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Closed] (TAP5-1642) Mixins parameters with required=true and default value provided
[ https://issues.apache.org/jira/browse/TAP5-1642?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Howard M. Lewis Ship closed TAP5-1642. -- Resolution: Invalid Assignee: Howard M. Lewis Ship This has been discussed to death on the mailing list. required means it must be bound, but the binding may be a default binding ... it doesn't mean that the parameter must be bound each time (when an appropriate default is possible). Mixins parameters with required=true and default value provided --- Key: TAP5-1642 URL: https://issues.apache.org/jira/browse/TAP5-1642 Project: Tapestry 5 Issue Type: Bug Components: tapestry-core Affects Versions: 5.3 Reporter: Laurent Guerin Assignee: Howard M. Lewis Ship Attachments: test-mixin.zip In our Tapestry 5 library (exanpe-t5-lib), we provide some mixins containing some parameters declared as required=true AND with a default value. These parameters are required for the operation of the mixin. For example, in a Dialog mixin, we have : @Parameter(value = confirm, required = true, allowNull = false, defaultPrefix = BindingConstants.LITERAL) private DialogRenderModeEnum renderMode; If this required parameter is not explicity bound in the TML : - In 5.2.6, everything is ok : the default value is used - In 5.3-beta-5, we get the following Exception : Parameter(s) 'Dialog.renderMode' are required for org.apache.tapestry5.corelib.components.ActionLink, but have not been bound. The TML example looks like this : t:actionlink t:id=link1 t:mixins=exanpe/dialoglink1/t:actionlink With a simple type for mixin parameter (Integer or String), the same error occurs. This behavior is only for mixins, not for components. A simplified project that duplicates the issue has been attached : the mixin Emphasis used into Index.tml is ok in 5.2.6 and ko in 5.3. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Closed] (TAP5-1443) Can't upgrade from Tapestry Spring 5.0.18 to 5.2.4
[ https://issues.apache.org/jira/browse/TAP5-1443?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Howard M. Lewis Ship closed TAP5-1443. -- Resolution: Invalid Assignee: Howard M. Lewis Ship There's been a lot of work on many things related to this bug; please retest and reopen the issue if the problem is still present. Can't upgrade from Tapestry Spring 5.0.18 to 5.2.4 -- Key: TAP5-1443 URL: https://issues.apache.org/jira/browse/TAP5-1443 Project: Tapestry 5 Issue Type: Bug Components: tapestry-spring Affects Versions: 5.2.4 Reporter: Matt Raible Assignee: Howard M. Lewis Ship The constructor of SpringModuleDef changed from using an ApplicationContext to using a ServletContext. However, when I try to mock out the ServletContext, it doesn't work. More info at: http://tapestry.1045711.n5.nabble.com/Compiler-error-when-upgrading-from-tapestry-spring-5-0-18-to-5-2-4-td3368139.html ERROR [main] RequestExceptionHandler.handleRequestException(63) | Processing of request failed with uncaught exception: java.lang.ClassNotFoundException: caught an exception while obtaining a class file for org.appfuse.webapp.pages.admin.UserList java.lang.RuntimeException: java.lang.ClassNotFoundException: caught an exception while obtaining a class file for org.appfuse.webapp.pages.admin.UserList at org.apache.tapestry5.internal.services.ComponentInstantiatorSourceImpl.findClass(ComponentInstantiatorSourceImpl.java:309) at org.apache.tapestry5.internal.services.ComponentInstantiatorSourceImpl.getInstantiator(ComponentInstantiatorSourceImpl.java:285) at $ComponentInstantiatorSource_12dec96c460.getInstantiator($ComponentInstantiatorSource_12dec96c460.java) at org.apache.tapestry5.internal.pageload.PageLoaderImpl$4.invoke(PageLoaderImpl.java:222) at org.apache.tapestry5.internal.pageload.PageLoaderImpl$4.invoke(PageLoaderImpl.java:219) at org.apache.tapestry5.ioc.internal.OperationTrackerImpl.invoke(OperationTrackerImpl.java:65) at org.apache.tapestry5.ioc.internal.PerThreadOperationTracker.invoke(PerThreadOperationTracker.java:68) at org.apache.tapestry5.ioc.internal.RegistryImpl.invoke(RegistryImpl.java:1063) at org.apache.tapestry5.internal.pageload.PageLoaderImpl.createAssembler(PageLoaderImpl.java:218) at org.apache.tapestry5.internal.pageload.PageLoaderImpl.getAssembler(PageLoaderImpl.java:208) at org.apache.tapestry5.internal.pageload.PageLoaderImpl$3.invoke(PageLoaderImpl.java:180) at org.apache.tapestry5.internal.pageload.PageLoaderImpl$3.invoke(PageLoaderImpl.java:174) at org.apache.tapestry5.ioc.internal.OperationTrackerImpl.invoke(OperationTrackerImpl.java:65) at org.apache.tapestry5.ioc.internal.PerThreadOperationTracker.invoke(PerThreadOperationTracker.java:68) at org.apache.tapestry5.ioc.internal.RegistryImpl.invoke(RegistryImpl.java:1063) at org.apache.tapestry5.internal.pageload.PageLoaderImpl.loadPage(PageLoaderImpl.java:173) at $PageLoader_12dec96c47b.loadPage($PageLoader_12dec96c47b.java) at org.apache.tapestry5.internal.services.PageSourceImpl.getPage(PageSourceImpl.java:81) at $PageSource_12dec96c47a.getPage($PageSource_12dec96c47a.java) at org.apache.tapestry5.internal.services.NonPoolingRequestPageCacheImpl.get(NonPoolingRequestPageCacheImpl.java:74) at $RequestPageCache_12dec96c479.get($RequestPageCache_12dec96c479.java) at $RequestPageCache_12dec96c473.get($RequestPageCache_12dec96c473.java) at org.apache.tapestry5.internal.services.PageRenderRequestHandlerImpl.handle(PageRenderRequestHandlerImpl.java:55) at org.apache.tapestry5.services.TapestryModule$36.handle(TapestryModule.java:2326) at $PageRenderRequestHandler_12dec96c477.handle($PageRenderRequestHandler_12dec96c477.java) at $PageRenderRequestHandler_12dec96c471.handle($PageRenderRequestHandler_12dec96c471.java) at org.apache.tapestry5.internal.services.ComponentRequestHandlerTerminator.handlePageRender(ComponentRequestHandlerTerminator.java:48) at org.apache.tapestry5.services.InitializeActivePageName.handlePageRender(InitializeActivePageName.java:47) at $ComponentRequestHandler_12dec96c472.handlePageRender($ComponentRequestHandler_12dec96c472.java) at $ComponentRequestHandler_12dec96c451.handlePageRender($ComponentRequestHandler_12dec96c451.java) at org.apache.tapestry5.internal.services.PageRenderDispatcher.dispatch(PageRenderDispatcher.java:45) at
svn commit: r1185926 - /tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/test/PageTester.java
Author: hlship
Date: Wed Oct 19 00:02:48 2011
New Revision: 1185926
URL: http://svn.apache.org/viewvc?rev=1185926view=rev
Log:
TAP5-698: PageTester's setupRequestFromURI incorrectly uses substring twice on
same string
Modified:
tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/test/PageTester.java
Modified:
tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/test/PageTester.java
URL:
http://svn.apache.org/viewvc/tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/test/PageTester.java?rev=1185926r1=1185925r2=1185926view=diff
==
---
tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/test/PageTester.java
(original)
+++
tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/test/PageTester.java
Wed Oct 19 00:02:48 2011
@@ -14,10 +14,6 @@
package org.apache.tapestry5.test;
-import java.io.IOException;
-import java.util.Locale;
-import java.util.Map;
-
import org.apache.tapestry5.Link;
import org.apache.tapestry5.dom.Document;
import org.apache.tapestry5.dom.Element;
@@ -38,6 +34,10 @@ import org.apache.tapestry5.services.Req
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
+import java.io.IOException;
+import java.util.Locale;
+import java.util.Map;
+
/**
* This class is used to run a Tapestry app in a single-threaded, in-process
testing environment.
* You can ask it to
@@ -68,7 +68,7 @@ public class PageTester
* Initializes a PageTester without overriding any services and assuming
that the context root
* is in
* src/main/webapp.
- *
+ *
* @see #PageTester(String, String, String, Class[])
*/
public PageTester(String appPackage, String appName)
@@ -79,21 +79,17 @@ public class PageTester
/**
* Initializes a PageTester that acts as a browser and a servlet container
to test drive your
* Tapestry pages.
- *
- * @param appPackage
- *The same value you would specify using the
tapestry.app-package context parameter.
- *As this
- *testing environment is not run in a servlet container, you
need to specify it.
- * @param appName
- *The same value you would specify as the filter name. It is
used to form the name
- *of the
- *module class for your app. If you don't have one, pass an
empty string.
- * @param contextPath
- *The path to the context root so that Tapestry can find the
templates (if they're
- *put
- *there).
- * @param moduleClasses
- *Classes of additional modules to load
+ *
+ * @param appPackageThe same value you would specify using the
tapestry.app-package context parameter.
+ * As this
+ * testing environment is not run in a servlet
container, you need to specify it.
+ * @param appName The same value you would specify as the filter
name. It is used to form the name
+ * of the
+ * module class for your app. If you don't have one,
pass an empty string.
+ * @param contextPath The path to the context root so that Tapestry can
find the templates (if they're
+ * put
+ * there).
+ * @param moduleClasses Classes of additional modules to load
*/
public PageTester(String appPackage, String appName, String contextPath,
Class... moduleClasses)
{
@@ -160,9 +156,8 @@ public class PageTester
* Allows a service to be retrieved via its service interface. Use {@link
#getRegistry()} for
* more complicated
* queries.
- *
- * @param serviceInterface
- *used to select the service
+ *
+ * @param serviceInterface used to select the service
*/
public T T getService(ClassT serviceInterface)
{
@@ -171,33 +166,31 @@ public class PageTester
/**
* Renders a page specified by its name.
- *
- * @param pageName
- *The name of the page to be rendered.
+ *
+ * @param pageName The name of the page to be rendered.
* @return The DOM created. Typically you will assert against it.
*/
public Document renderPage(String pageName)
{
-
+
renderPageAndReturnResponse(pageName);
-
+
Document result = response.getRenderedDocument();
if (result == null)
throw new RuntimeException(String.format(Render of page '%s' did
not result in a Document.,
pageName));
-
+
return result;
}
-
+
/**
* Renders a page specified by its name and returns the response.
- *
- * @since 5.2.3
- *
+ *
* @param pageName The name of the page
[jira] [Closed] (TAP5-698) PageTester's setupRequestFromURI incorrectly uses substring twice on same string
[ https://issues.apache.org/jira/browse/TAP5-698?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Howard M. Lewis Ship closed TAP5-698. - Resolution: Fixed Fix Version/s: 5.3 Assignee: Howard M. Lewis Ship PageTester's setupRequestFromURI incorrectly uses substring twice on same string Key: TAP5-698 URL: https://issues.apache.org/jira/browse/TAP5-698 Project: Tapestry 5 Issue Type: Bug Components: tapestry-test Affects Versions: 5.1.0.5 Reporter: Chris Wilkes Assignee: Howard M. Lewis Ship Fix For: 5.3 Incoming linkPath: /filelist.delete/c$002ftest2-2510777506787452085.txt?t:ac=c int comma is set to 52 path: /filelist.delete/c$002ftest2-2510777506787452085.txt then trying to do a path.substring(comma+1) Fix: use linkPath instead of path at line 304: if (comma 0) decodeParametersIntoRequest(path.substring(comma + 1)); -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (TAP5-698) PageTester's setupRequestFromURI incorrectly uses substring twice on same string
[ https://issues.apache.org/jira/browse/TAP5-698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13130294#comment-13130294 ] Hudson commented on TAP5-698: - Integrated in tapestry-trunk-freestyle #585 (See [https://builds.apache.org/job/tapestry-trunk-freestyle/585/]) TAP5-698: PageTester's setupRequestFromURI incorrectly uses substring twice on same string hlship : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVNview=revrev=1185926 Files : * /tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/test/PageTester.java PageTester's setupRequestFromURI incorrectly uses substring twice on same string Key: TAP5-698 URL: https://issues.apache.org/jira/browse/TAP5-698 Project: Tapestry 5 Issue Type: Bug Components: tapestry-test Affects Versions: 5.1.0.5 Reporter: Chris Wilkes Assignee: Howard M. Lewis Ship Fix For: 5.3 Incoming linkPath: /filelist.delete/c$002ftest2-2510777506787452085.txt?t:ac=c int comma is set to 52 path: /filelist.delete/c$002ftest2-2510777506787452085.txt then trying to do a path.substring(comma+1) Fix: use linkPath instead of path at line 304: if (comma 0) decodeParametersIntoRequest(path.substring(comma + 1)); -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Reopened] (TAP5-1642) Mixins parameters with required=true and default value provided
[ https://issues.apache.org/jira/browse/TAP5-1642?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Zeigler reopened TAP5-1642: -- Assignee: Robert Zeigler (was: Howard M. Lewis Ship) That's the poster's point; the parameter is required, but a sensible default is provided and Tapestry is complaining that the parameter isn't bound, despite a sensible default being provided. I've verified that this behavior is still present in T5.3-beta-24 Mixins parameters with required=true and default value provided --- Key: TAP5-1642 URL: https://issues.apache.org/jira/browse/TAP5-1642 Project: Tapestry 5 Issue Type: Bug Components: tapestry-core Affects Versions: 5.3 Reporter: Laurent Guerin Assignee: Robert Zeigler Attachments: test-mixin.zip In our Tapestry 5 library (exanpe-t5-lib), we provide some mixins containing some parameters declared as required=true AND with a default value. These parameters are required for the operation of the mixin. For example, in a Dialog mixin, we have : @Parameter(value = confirm, required = true, allowNull = false, defaultPrefix = BindingConstants.LITERAL) private DialogRenderModeEnum renderMode; If this required parameter is not explicity bound in the TML : - In 5.2.6, everything is ok : the default value is used - In 5.3-beta-5, we get the following Exception : Parameter(s) 'Dialog.renderMode' are required for org.apache.tapestry5.corelib.components.ActionLink, but have not been bound. The TML example looks like this : t:actionlink t:id=link1 t:mixins=exanpe/dialoglink1/t:actionlink With a simple type for mixin parameter (Integer or String), the same error occurs. This behavior is only for mixins, not for components. A simplified project that duplicates the issue has been attached : the mixin Emphasis used into Index.tml is ok in 5.2.6 and ko in 5.3. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
