[1/5] git commit: Fix broken tests
Updated Branches:
refs/heads/5.4-js-rewrite 8c95676fc -> aa4ccaad9
Fix broken tests
Project: http://git-wip-us.apache.org/repos/asf/tapestry-5/repo
Commit: http://git-wip-us.apache.org/repos/asf/tapestry-5/commit/aa4ccaad
Tree: http://git-wip-us.apache.org/repos/asf/tapestry-5/tree/aa4ccaad
Diff: http://git-wip-us.apache.org/repos/asf/tapestry-5/diff/aa4ccaad
Branch: refs/heads/5.4-js-rewrite
Commit: aa4ccaad93d7404d4c7693a4baba3ec48e5ed6d9
Parents: 20a1391
Author: Howard M. Lewis Ship
Authored: Fri Nov 30 10:21:59 2012 -0800
Committer: Howard M. Lewis Ship
Committed: Fri Nov 30 10:21:59 2012 -0800
--
.../tapestry5/integration/app1/TreeTests.groovy| 24 --
.../tapestry5/integration/app1/pages/TreeDemo.tml | 16 -
.../integration/app1/pages/TreeSelectionDemo.tml | 14 +++-
3 files changed, 26 insertions(+), 28 deletions(-)
--
http://git-wip-us.apache.org/repos/asf/tapestry-5/blob/aa4ccaad/tapestry-core/src/test/groovy/org/apache/tapestry5/integration/app1/TreeTests.groovy
--
diff --git
a/tapestry-core/src/test/groovy/org/apache/tapestry5/integration/app1/TreeTests.groovy
b/tapestry-core/src/test/groovy/org/apache/tapestry5/integration/app1/TreeTests.groovy
index a7c84e2..0704f76 100644
---
a/tapestry-core/src/test/groovy/org/apache/tapestry5/integration/app1/TreeTests.groovy
+++
b/tapestry-core/src/test/groovy/org/apache/tapestry5/integration/app1/TreeTests.groovy
@@ -1,4 +1,4 @@
-// Copyright 2011 The Apache Software Foundation
+// Copyright 2011, 2012 The Apache Software Foundation
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
@@ -14,20 +14,21 @@
package org.apache.tapestry5.integration.app1
-import org.apache.tapestry5.test.SeleniumTestCase
+import org.apache.tapestry5.integration.TapestryCoreTestCase
import org.testng.annotations.Test
-class TreeTests extends SeleniumTestCase
+class TreeTests extends TapestryCoreTestCase
{
@Test
void basics()
{
-
openBaseURL()
clickAndWait "link=Tree Component Demo"
-clickAndWait "link=clear expansions"
+clickAndWait "link=Clear Expansions"
+
+waitForPageLoaded()
//Click on Games
click "//div[@class='t-tree-container
test-hook']/ul/li[2]/span[@class='t-tree-icon']"
@@ -57,23 +58,26 @@ class TreeTests extends SeleniumTestCase
clickAndWait "link=Tree Component Selection Demo"
-clickAndWait "link=clear all"
+clickAndWait "link=Clear All"
+
+waitForPageLoaded()
click "//span[@class='t-tree-icon']"
-waitForCSSSelectedElementToAppear "span.t-leaf-node"
+waitForCSSSelectedElementToAppear "li.t-leaf-node > span"
assertTextPresent "Oscar", "Gromit", "Max", "Roger", "Cooper"
// Click the first selectable node, probably Oscar
-click "css=span.t-selectable"
-waitForCSSSelectedElementToAppear "span.t-selected-leaf-node-label"
+click "css=[data-tree-node-selection-enabled] li.t-leaf-node >
span.t-tree-label"
+
+waitForCSSSelectedElementToAppear "span.t-selected-leaf-node"
clickAndWait "link=Redraw"
// Make sure it is still there after a redraw
-waitForCSSSelectedElementToAppear "span.t-selected-leaf-node-label"
+waitForCSSSelectedElementToAppear "span.t-selected-leaf-node"
}
}
http://git-wip-us.apache.org/repos/asf/tapestry-5/blob/aa4ccaad/tapestry-core/src/test/resources/org/apache/tapestry5/integration/app1/pages/TreeDemo.tml
--
diff --git
a/tapestry-core/src/test/resources/org/apache/tapestry5/integration/app1/pages/TreeDemo.tml
b/tapestry-core/src/test/resources/org/apache/tapestry5/integration/app1/pages/TreeDemo.tml
index 67b7661..450be3f 100644
---
a/tapestry-core/src/test/resources/org/apache/tapestry5/integration/app1/pages/TreeDemo.tml
+++
b/tapestry-core/src/test/resources/org/apache/tapestry5/integration/app1/pages/TreeDemo.tml
@@ -1,15 +1,13 @@
-http://tapestry.apache.org/schema/tapestry_5_3.xsd";
xmlns:p="tapestry:parameter">
+http://tapestry.apache.org/schema/tapestry_5_3.xsd";>
Tree Demo
-
-[
-Redraw
-]
-[
-clear expansions
-]
-
+
+
+ Redraw
+ Clear Expansions
+
+
\ No newline at end of file
http://git-wip-us.apache.org/repos/asf/tapestry-5/blob/aa4ccaad/tapestry-core/src/test/resources/org/apache/tapestry5/integration/app1/pages/TreeSelectionDemo.tml
--
diff --git
a/tapestry-core/src/test/resources/org/apache/tapestry5/integration/app1/pages/TreeSelectionDemo.tml
b
[5/5] git commit: Fix test broken by use of @MixinAfter on RenderNotification mixin
Fix test broken by use of @MixinAfter on RenderNotification mixin Project: http://git-wip-us.apache.org/repos/asf/tapestry-5/repo Commit: http://git-wip-us.apache.org/repos/asf/tapestry-5/commit/4da3d9bf Tree: http://git-wip-us.apache.org/repos/asf/tapestry-5/tree/4da3d9bf Diff: http://git-wip-us.apache.org/repos/asf/tapestry-5/diff/4da3d9bf Branch: refs/heads/5.4-js-rewrite Commit: 4da3d9bfe64591cad399da76a85338f8178ba6dc Parents: 8c95676 Author: Howard M. Lewis Ship Authored: Thu Nov 29 17:28:46 2012 -0800 Committer: Howard M. Lewis Ship Committed: Thu Nov 29 17:28:46 2012 -0800 -- 54_RELEASE_NOTES.txt |8 +++- .../src/test/app1/RenderNotificationDemo.tml |6 +++--- 2 files changed, 10 insertions(+), 4 deletions(-) -- http://git-wip-us.apache.org/repos/asf/tapestry-5/blob/4da3d9bf/54_RELEASE_NOTES.txt -- diff --git a/54_RELEASE_NOTES.txt b/54_RELEASE_NOTES.txt index 785c1b1..cd773b2 100644 --- a/54_RELEASE_NOTES.txt +++ b/54_RELEASE_NOTES.txt @@ -152,4 +152,10 @@ The selected property is now type `Collection`, not specifically type `List`. It The Autocomplete mixin has been rewritten to use Bootstrap; this implies it will also force jQuery onto the page, to support the Bootstrap JavaScript library. In addition, Bootstrap's typeahead component does not support multiple -tokens, so this behavior has been removed. \ No newline at end of file +tokens, so this behavior has been removed. + +## RenderNotification Mixin + +The timing of this mixin has changed, it now has the @MixinAfter annotation, so it triggers its events *after* +the component to which it attaches has executed its @BeginRender phase, and *before* the component executes +its @AfterRender phase. \ No newline at end of file http://git-wip-us.apache.org/repos/asf/tapestry-5/blob/4da3d9bf/tapestry-core/src/test/app1/RenderNotificationDemo.tml -- diff --git a/tapestry-core/src/test/app1/RenderNotificationDemo.tml b/tapestry-core/src/test/app1/RenderNotificationDemo.tml index 7f10fa6..249b3d4 100644 --- a/tapestry-core/src/test/app1/RenderNotificationDemo.tml +++ b/tapestry-core/src/test/app1/RenderNotificationDemo.tml @@ -1,9 +1,9 @@ -http://tapestry.apache.org/schema/tapestry_5_0_0.xsd";> +http://tapestry.apache.org/schema/tapestry_5_3.xsd";> RenderNotification Mixin Demo - -item body in template + +item body in template
[4/5] git commit: Fix broken tests
Fix broken tests
Project: http://git-wip-us.apache.org/repos/asf/tapestry-5/repo
Commit: http://git-wip-us.apache.org/repos/asf/tapestry-5/commit/d8120f39
Tree: http://git-wip-us.apache.org/repos/asf/tapestry-5/tree/d8120f39
Diff: http://git-wip-us.apache.org/repos/asf/tapestry-5/diff/d8120f39
Branch: refs/heads/5.4-js-rewrite
Commit: d8120f396b55fe7a64283cfbc06e3e01d6d87c95
Parents: 4da3d9b
Author: Howard M. Lewis Ship
Authored: Thu Nov 29 17:36:21 2012 -0800
Committer: Howard M. Lewis Ship
Committed: Thu Nov 29 17:36:21 2012 -0800
--
.../integration/app3/PageCatalogTests.groovy |7 ---
1 files changed, 4 insertions(+), 3 deletions(-)
--
http://git-wip-us.apache.org/repos/asf/tapestry-5/blob/d8120f39/tapestry-core/src/test/groovy/org/apache/tapestry5/integration/app3/PageCatalogTests.groovy
--
diff --git
a/tapestry-core/src/test/groovy/org/apache/tapestry5/integration/app3/PageCatalogTests.groovy
b/tapestry-core/src/test/groovy/org/apache/tapestry5/integration/app3/PageCatalogTests.groovy
index 3d58dcb..7d1dbb5 100644
---
a/tapestry-core/src/test/groovy/org/apache/tapestry5/integration/app3/PageCatalogTests.groovy
+++
b/tapestry-core/src/test/groovy/org/apache/tapestry5/integration/app3/PageCatalogTests.groovy
@@ -5,6 +5,7 @@ import org.testng.annotations.Test
class PageCatalogTests extends TapestryCoreTestCase
{
+/** There's not a lot we can do, because some of the pages in the test
application have deliberate errors. */
@Test
void load_page_catalog_page()
{
@@ -14,6 +15,8 @@ class PageCatalogTests extends TapestryCoreTestCase
assertTitle title
+waitForPageLoaded()
+
click "link=clear the cache"
sleep 1000
@@ -28,8 +31,6 @@ class PageCatalogTests extends TapestryCoreTestCase
click "link=load all pages"
-sleep 1000
-
-assertTextPresent "new pages for selector"
+// Ignore any errors that occur.
}
}
[3/5] git commit: Fix more broken tests
Fix more broken tests
Project: http://git-wip-us.apache.org/repos/asf/tapestry-5/repo
Commit: http://git-wip-us.apache.org/repos/asf/tapestry-5/commit/d48f199e
Tree: http://git-wip-us.apache.org/repos/asf/tapestry-5/tree/d48f199e
Diff: http://git-wip-us.apache.org/repos/asf/tapestry-5/diff/d48f199e
Branch: refs/heads/5.4-js-rewrite
Commit: d48f199eeadcac2a87de0e17b00b41f96f607959
Parents: d8120f3
Author: Howard M. Lewis Ship
Authored: Fri Nov 30 09:36:38 2012 -0800
Committer: Howard M. Lewis Ship
Committed: Fri Nov 30 09:36:38 2012 -0800
--
.../integration/app3/PageCatalogTests.groovy |2 +-
.../integration/app1/ZoneRefreshTest.java | 67 ---
2 files changed, 37 insertions(+), 32 deletions(-)
--
http://git-wip-us.apache.org/repos/asf/tapestry-5/blob/d48f199e/tapestry-core/src/test/groovy/org/apache/tapestry5/integration/app3/PageCatalogTests.groovy
--
diff --git
a/tapestry-core/src/test/groovy/org/apache/tapestry5/integration/app3/PageCatalogTests.groovy
b/tapestry-core/src/test/groovy/org/apache/tapestry5/integration/app3/PageCatalogTests.groovy
index 7d1dbb5..3ca3efd 100644
---
a/tapestry-core/src/test/groovy/org/apache/tapestry5/integration/app3/PageCatalogTests.groovy
+++
b/tapestry-core/src/test/groovy/org/apache/tapestry5/integration/app3/PageCatalogTests.groovy
@@ -21,7 +21,7 @@ class PageCatalogTests extends TapestryCoreTestCase
sleep 1000
-assertTextPresent "Page cache cleared"
+assertTextPresent "Page cache cleared"
bzonref
click "link=Run the GC"
http://git-wip-us.apache.org/repos/asf/tapestry-5/blob/d48f199e/tapestry-core/src/test/java/org/apache/tapestry5/integration/app1/ZoneRefreshTest.java
--
diff --git
a/tapestry-core/src/test/java/org/apache/tapestry5/integration/app1/ZoneRefreshTest.java
b/tapestry-core/src/test/java/org/apache/tapestry5/integration/app1/ZoneRefreshTest.java
index e44b7b7..f105000 100644
---
a/tapestry-core/src/test/java/org/apache/tapestry5/integration/app1/ZoneRefreshTest.java
+++
b/tapestry-core/src/test/java/org/apache/tapestry5/integration/app1/ZoneRefreshTest.java
@@ -1,4 +1,4 @@
-// Copyright 2011 The Apache Software Foundation
+// Copyright 2011, 2012 The Apache Software Foundation
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
@@ -19,35 +19,40 @@ import org.testng.annotations.Test;
public class ZoneRefreshTest extends SeleniumTestCase
{
- @Test
- public void test_if_zone_with_event_handler_returning_void_works() throws
Exception
- {
- openBaseURL();
- clickAndWait("link=Zone Refresh With Event Handler Returning Void");
- checkZoneValues("zone", 3);
- }
-
- @Test
- public void test_if_zone_with_event_handler_returning_zone_works() throws
Exception
- {
- openBaseURL();
- clickAndWait("link=Zone Refresh With Event Handler Returning Zone");
- checkZoneValues("zone", 3);
- }
-
- private void checkZoneValues(String zone, int times) throws Exception
- {
- for(int i = 1; i <= times; ++i)
- {
- //Wait for ajax call to begin
-
waitForCondition("selenium.browserbot.getCurrentWindow().Ajax.activeRequestCount
!= 0", "2");
-
- //Wait for ajax call from end
-
waitForCondition("selenium.browserbot.getCurrentWindow().Ajax.activeRequestCount
== 0", "2");
-
- //Check the value changed
- assertText(zone, String.valueOf(i));
- }
- }
+@Test
+public void test_if_zone_with_event_handler_returning_void_works() throws
Exception
+{
+openBaseURL();
+
+clickAndWait("link=Zone Refresh With Event Handler Returning Void");
+
+checkZoneValues("zone", 3);
+}
+
+@Test
+public void test_if_zone_with_event_handler_returning_zone_works() throws
Exception
+{
+openBaseURL();
+clickAndWait("link=Zone Refresh With Event Handler Returning Zone");
+checkZoneValues("zone", 3);
+}
+
+private void checkZoneValues(String zone, int times) throws Exception
+{
+// Wait until Prototype is loaded ...
+waitForCondition("selenium.browserbot.getCurrentWindow().Ajax",
"2");
+
+for (int i = 1; i <= times; ++i)
+{
+// Wait for ajax call to begin
+
waitForCondition("selenium.browserbot.getCurrentWindow().Ajax.activeRequestCount
!= 0", "2");
+
+// Wait for ajax call from end
+
waitForCondition("selenium.browserbot.getCurrentWindow().Ajax.activeRequestCount
== 0", "2");
+
+
[2/5] git commit: Show the XHR flag in upper case
Show the XHR flag in upper case
Project: http://git-wip-us.apache.org/repos/asf/tapestry-5/repo
Commit: http://git-wip-us.apache.org/repos/asf/tapestry-5/commit/20a13911
Tree: http://git-wip-us.apache.org/repos/asf/tapestry-5/tree/20a13911
Diff: http://git-wip-us.apache.org/repos/asf/tapestry-5/diff/20a13911
Branch: refs/heads/5.4-js-rewrite
Commit: 20a13911919f64c7b47be6ea52d59c91a35d9ab9
Parents: d48f199
Author: Howard M. Lewis Ship
Authored: Fri Nov 30 09:56:49 2012 -0800
Committer: Howard M. Lewis Ship
Committed: Fri Nov 30 09:56:49 2012 -0800
--
.../internal/renderers/RequestRenderer.java|2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
--
http://git-wip-us.apache.org/repos/asf/tapestry-5/blob/20a13911/tapestry-core/src/main/java/org/apache/tapestry5/internal/renderers/RequestRenderer.java
--
diff --git
a/tapestry-core/src/main/java/org/apache/tapestry5/internal/renderers/RequestRenderer.java
b/tapestry-core/src/main/java/org/apache/tapestry5/internal/renderers/RequestRenderer.java
index 1d660b7..b7b441d 100644
---
a/tapestry-core/src/main/java/org/apache/tapestry5/internal/renderers/RequestRenderer.java
+++
b/tapestry-core/src/main/java/org/apache/tapestry5/internal/renderers/RequestRenderer.java
@@ -85,7 +85,7 @@ public class RequestRenderer implements
ObjectRenderer
if (request.isXHR())
{
-flags.add("xhr");
+flags.add("XHR");
}
if (request.isRequestedSessionIdValid())
[CONF] Apache Tapestry > Page Navigation
Page Navigation
Page edited by DEMEY Emmanuel
Changes (1)
...
An event handler method may return a [HttpError|http://tapestry.apache.org/current/apidocs/org/apache/tapestry5/services/HttpError.html] instance to send an error response to the client.
{code}@InjectPage
public Object onAction(){ return new HttpError(302, "The Error message);
...
Full Content
Page Navigation
Related Articles
Page:
Component Events FAQ
Page:
Page Life Cycle
Page:
Request Processing
Page:
Component Rendering
Page:
Component Events
Page:
Page Navigation
In essence, a Tapestry application is a number of related pages, working together. To some degree, each page is like an application unto itself.
Any individual request will be targeted at a single page. Requests come in two forms:
component event requests target a specific component on a specific page, triggering an event within that component
render requests target a specific page, and stream the HTML markup for that page back to the client
This dichotomy between component event requests and render requests is new in Tapestry 5. It is in some ways based on ideas from the Portlet specification and differentiating the two types of requests alleviates a number of problems in traditional web applications related to the browser back button, or to the user hitting the refresh button in their browser.
Component Event Requests
Main Article: Component Events
Component event requests may take the form of hyperlinks (EventLink or ActionLink) or form submissions (Form).
The value returned from an event handler method controls the response sent to the client web browser.
The URL for a component event request identifies the name of the page, the nested id of the component, and the name of the event to trigger on the component (this is usually "action"). Further, a component event request may contain additional context information, which will be provided to the event handler method.
These URLs expose a bit of the internal structure of the application. Over time, as an application grows and is maintained, the ids of components may change. This means that component event request URLs should not be bookmarked. Fortunately, users will rarely have the chance to do so (see below).
Null response
If the event handler method returns no value, or returns null, then the current page (the page containing the component) will render the response.
A page render link for the current page is created and sent to the client as a client side redirect. The client browser will automatically submit a new request to generate the page.
The user will see the newly generated content in their browser. In addition, the URL in the browser's address bar will be a render request URL. Render request URLs are shorter and contain less application structure (for instance, they don't include component ids or event types). Render requests URLs are what your users will bookmark. The component event request URLs are transitory, meaningful only while the application is actively engaged, and not meant to be used in later sessions.
public Object onAction(){
return null;
}
String response
When a string is returned, it is expected to be the logical name of a page (as opposed to the page's fully qualified class name). As elsewhere, the name of the page is case insensitive.
Again, a render request URL will be constructed and sent to the client as a redirect.
public String onAction(){
return "Index";
}
Class response
When a class is returned, it is expected to be a page class. Returning a page class from an event handler is safer for refactoring than returning a page name.
As with other response types, a render request URL will be constructed and sent to the client as a redirect.
public Object onAction(){
return
[CONF] Apache Tapestry > Page Navigation
Page Navigation
Page edited by DEMEY Emmanuel
Changes (1)
...
}{code}
h2. HttpError An event handler method may return a [HttpError|http://tapestry.apache.org/current/apidocs/org/apache/tapestry5/services/HttpError.html] instance to send an error response to the client. {code}@InjectPage public Object onAction(){ return new HttpError(302, "The Error message); }{code}
h2. Link response
...
Full Content
Page Navigation
Related Articles
Page:
Component Events FAQ
Page:
Page Life Cycle
Page:
Request Processing
Page:
Component Rendering
Page:
Component Events
Page:
Page Navigation
In essence, a Tapestry application is a number of related pages, working together. To some degree, each page is like an application unto itself.
Any individual request will be targeted at a single page. Requests come in two forms:
component event requests target a specific component on a specific page, triggering an event within that component
render requests target a specific page, and stream the HTML markup for that page back to the client
This dichotomy between component event requests and render requests is new in Tapestry 5. It is in some ways based on ideas from the Portlet specification and differentiating the two types of requests alleviates a number of problems in traditional web applications related to the browser back button, or to the user hitting the refresh button in their browser.
Component Event Requests
Main Article: Component Events
Component event requests may take the form of hyperlinks (EventLink or ActionLink) or form submissions (Form).
The value returned from an event handler method controls the response sent to the client web browser.
The URL for a component event request identifies the name of the page, the nested id of the component, and the name of the event to trigger on the component (this is usually "action"). Further, a component event request may contain additional context information, which will be provided to the event handler method.
These URLs expose a bit of the internal structure of the application. Over time, as an application grows and is maintained, the ids of components may change. This means that component event request URLs should not be bookmarked. Fortunately, users will rarely have the chance to do so (see below).
Null response
If the event handler method returns no value, or returns null, then the current page (the page containing the component) will render the response.
A page render link for the current page is created and sent to the client as a client side redirect. The client browser will automatically submit a new request to generate the page.
The user will see the newly generated content in their browser. In addition, the URL in the browser's address bar will be a render request URL. Render request URLs are shorter and contain less application structure (for instance, they don't include component ids or event types). Render requests URLs are what your users will bookmark. The component event request URLs are transitory, meaningful only while the application is actively engaged, and not meant to be used in later sessions.
public Object onAction(){
return null;
}
String response
When a string is returned, it is expected to be the logical name of a page (as opposed to the page's fully qualified class name). As elsewhere, the name of the page is case insensitive.
Again, a render request URL will be constructed and sent to the client as a redirect.
public String onAction(){
return "Index";
}
Class response
When a class is returned, it is expected to be a page class. Returning a page class from an event handler is safer for refactoring than returning a page name.
As with other response types, a render request URL will be constructed and sent to the client
[CONF] Apache Tapestry > Page Navigation
Page Navigation
Page edited by DEMEY Emmanuel
Changes (3)
...
You can also return a component within the page, but this will generate a runtime warning (unless you are doing a partial-page update via [Ajax|Ajax and Zones]).
@InjectPage
{code}@InjectPage
private Index index;
{code}public Object onAction(){
return index; }{code}
...
Full Content
Page Navigation
Related Articles
Page:
Component Events FAQ
Page:
Page Life Cycle
Page:
Request Processing
Page:
Component Rendering
Page:
Component Events
Page:
Page Navigation
In essence, a Tapestry application is a number of related pages, working together. To some degree, each page is like an application unto itself.
Any individual request will be targeted at a single page. Requests come in two forms:
component event requests target a specific component on a specific page, triggering an event within that component
render requests target a specific page, and stream the HTML markup for that page back to the client
This dichotomy between component event requests and render requests is new in Tapestry 5. It is in some ways based on ideas from the Portlet specification and differentiating the two types of requests alleviates a number of problems in traditional web applications related to the browser back button, or to the user hitting the refresh button in their browser.
Component Event Requests
Main Article: Component Events
Component event requests may take the form of hyperlinks (EventLink or ActionLink) or form submissions (Form).
The value returned from an event handler method controls the response sent to the client web browser.
The URL for a component event request identifies the name of the page, the nested id of the component, and the name of the event to trigger on the component (this is usually "action"). Further, a component event request may contain additional context information, which will be provided to the event handler method.
These URLs expose a bit of the internal structure of the application. Over time, as an application grows and is maintained, the ids of components may change. This means that component event request URLs should not be bookmarked. Fortunately, users will rarely have the chance to do so (see below).
Null response
If the event handler method returns no value, or returns null, then the current page (the page containing the component) will render the response.
A page render link for the current page is created and sent to the client as a client side redirect. The client browser will automatically submit a new request to generate the page.
The user will see the newly generated content in their browser. In addition, the URL in the browser's address bar will be a render request URL. Render request URLs are shorter and contain less application structure (for instance, they don't include component ids or event types). Render requests URLs are what your users will bookmark. The component event request URLs are transitory, meaningful only while the application is actively engaged, and not meant to be used in later sessions.
public Object onAction(){
return null;
}
String response
When a string is returned, it is expected to be the logical name of a page (as opposed to the page's fully qualified class name). As elsewhere, the name of the page is case insensitive.
Again, a render request URL will be constructed and sent to the client as a redirect.
public String onAction(){
return "Index";
}
Class response
When a class is returned, it is expected to be a page class. Returning a page class from an event handler is safer for refactoring than returning a page name.
As with other response types, a render request URL will be constructed and sent to the client as a redirect.
pub
[CONF] Apache Tapestry > Page Navigation
Page Navigation
Page edited by DEMEY Emmanuel
Changes (5)
...
The user will see the newly generated content in their browser. In addition, the URL in the browser's address bar will be a render request URL. Render request URLs are shorter and contain less application structure (for instance, they don't include component ids or event types). Render requests URLs are what your users will bookmark. The component event request URLs are transitory, meaningful only while the application is actively engaged, and not meant to be used in later sessions.
{code}public Object onAction(){ return null; }{code}
h2. String response
...
Again, a render request URL will be constructed and sent to the client as a redirect.
{code}public String onAction(){ return "Index"; }{code}
h2. Class response
...
As with other response types, a render request URL will be constructed and sent to the client as a redirect.
{code}public Object onAction(){ return Index.class }{code}
h2. Page response
...
You can also return a component within the page, but this will generate a runtime warning (unless you are doing a partial-page update via [Ajax|Ajax and Zones]).
@InjectPage private Index index;
{code}public Object onAction(){ return index; }{code}
h2. Link response
...
{ private Product product;
. . .
long onPassivate() { return product.getId(); } }
...
{code:java} . . .
void onActivate(long productId) { product = productDAO.getById(productId); }
. . . {code}
...
@InjectPage private ProductDetails details;
Object onActionFromSelect(long productId) { details.setProductId(productId);
return details; }
...
@Inject private ProductDAO dao;
private Product product;
@Persist private long productId;
public void setProductId(long productId) { this.productId = productId; }
void onActivate() {
...
@Inject private ProductDAO dao;
private Product product;
private long productId;
public void setProductId(long productId) { productId = productId; }
void onActivate(long productId) { this.productId = productId;
product = dao.getById(productId); }
long onPassivate() { return productId; } {code}
...
@Inject private ProductDAO dao;
private Product product;
private long productId;
void onActivate(long productId) { this.productId = productId;
product = dao.getById(productId); }
long onPassivate() { return productId; } {code}
...
Full Content
Page Navigation
Related Articles
Page:
Component Events FAQ
Page:
Page Life Cycle
Page:
Page Navigation
Page:
Request Processing
Page:
Component Rendering
Page:
Component Events
In essence, a Tapestry application is a number of related pages, working together. To some degree, each page is like an application unto itself.
Any individual request will be targeted at a single page. Requests come in two forms:
component event requests t
[jira] [Updated] (TAP5-2031) BaseURLSourceImpl added default secure port to absolute url
[
https://issues.apache.org/jira/browse/TAP5-2031?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andrei Markov updated TAP5-2031:
Description:
BaseURLSourceImpl.getBaseURL(boolean secure) shoudn't add port 443 for secure
url.
if (port <= 0) {
port = request.getServerPort();
int schemeDefaultPort = request.isSecure() ? 443 : 80;
portSuffix = port == schemeDefaultPort ? "" : ":" + port;
}
else if (secure && port != 443) portSuffix = ":" + port;
else if (port != 80) portSuffix = ":" + port;
The last line doesn't check secure flag, but it should be.
was:
BaseURLSourceImpl.getBaseURL(boolean secure) shoudn't add port 443 for url with
secure scheme.
if (port <= 0) {
port = request.getServerPort();
int schemeDefaultPort = request.isSecure() ? 443 : 80;
portSuffix = port == schemeDefaultPort ? "" : ":" + port;
}
else if (secure && port != 443) portSuffix = ":" + port;
else if (port != 80) portSuffix = ":" + port;
The last line doesn't check secure flag, but it should be.
> BaseURLSourceImpl added default secure port to absolute url
> ---
>
> Key: TAP5-2031
> URL: https://issues.apache.org/jira/browse/TAP5-2031
> Project: Tapestry 5
> Issue Type: Bug
> Components: tapestry-core
>Affects Versions: 5.3.1
>Reporter: Andrei Markov
>Priority: Trivial
>
> BaseURLSourceImpl.getBaseURL(boolean secure) shoudn't add port 443 for secure
> url.
> if (port <= 0) {
> port = request.getServerPort();
> int schemeDefaultPort = request.isSecure() ? 443 : 80;
> portSuffix = port == schemeDefaultPort ? "" : ":" + port;
> }
> else if (secure && port != 443) portSuffix = ":" + port;
> else if (port != 80) portSuffix = ":" + port;
> The last line doesn't check secure flag, but it should be.
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (TAP5-2031) BaseURLSourceImpl added default secure port to absolute url
[
https://issues.apache.org/jira/browse/TAP5-2031?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andrei Markov updated TAP5-2031:
Description:
BaseURLSourceImpl.getBaseURL(boolean secure) shoudn't add port 443 for url with
secure scheme.
if (port <= 0) {
port = request.getServerPort();
int schemeDefaultPort = request.isSecure() ? 443 : 80;
portSuffix = port == schemeDefaultPort ? "" : ":" + port;
}
else if (secure && port != 443) portSuffix = ":" + port;
else if (port != 80) portSuffix = ":" + port;
In last line doesn't check secure flag, but it should be.
was:
BaseURLSourceImpl.getBaseURL(boolean secure) shoudn't add port 443 for url with
secure scheme.
> BaseURLSourceImpl added default secure port to absolute url
> ---
>
> Key: TAP5-2031
> URL: https://issues.apache.org/jira/browse/TAP5-2031
> Project: Tapestry 5
> Issue Type: Bug
> Components: tapestry-core
>Affects Versions: 5.3.1
>Reporter: Andrei Markov
>Priority: Trivial
>
> BaseURLSourceImpl.getBaseURL(boolean secure) shoudn't add port 443 for url
> with secure scheme.
> if (port <= 0) {
> port = request.getServerPort();
> int schemeDefaultPort = request.isSecure() ? 443 : 80;
> portSuffix = port == schemeDefaultPort ? "" : ":" + port;
> }
> else if (secure && port != 443) portSuffix = ":" + port;
> else if (port != 80) portSuffix = ":" + port;
> In last line doesn't check secure flag, but it should be.
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (TAP5-2031) BaseURLSourceImpl added default secure port to absolute url
[
https://issues.apache.org/jira/browse/TAP5-2031?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andrei Markov updated TAP5-2031:
Description:
BaseURLSourceImpl.getBaseURL(boolean secure) shoudn't add port 443 for url with
secure scheme.
if (port <= 0) {
port = request.getServerPort();
int schemeDefaultPort = request.isSecure() ? 443 : 80;
portSuffix = port == schemeDefaultPort ? "" : ":" + port;
}
else if (secure && port != 443) portSuffix = ":" + port;
else if (port != 80) portSuffix = ":" + port;
The last line doesn't check secure flag, but it should be.
was:
BaseURLSourceImpl.getBaseURL(boolean secure) shoudn't add port 443 for url with
secure scheme.
if (port <= 0) {
port = request.getServerPort();
int schemeDefaultPort = request.isSecure() ? 443 : 80;
portSuffix = port == schemeDefaultPort ? "" : ":" + port;
}
else if (secure && port != 443) portSuffix = ":" + port;
else if (port != 80) portSuffix = ":" + port;
In last line doesn't check secure flag, but it should be.
> BaseURLSourceImpl added default secure port to absolute url
> ---
>
> Key: TAP5-2031
> URL: https://issues.apache.org/jira/browse/TAP5-2031
> Project: Tapestry 5
> Issue Type: Bug
> Components: tapestry-core
>Affects Versions: 5.3.1
>Reporter: Andrei Markov
>Priority: Trivial
>
> BaseURLSourceImpl.getBaseURL(boolean secure) shoudn't add port 443 for url
> with secure scheme.
> if (port <= 0) {
> port = request.getServerPort();
> int schemeDefaultPort = request.isSecure() ? 443 : 80;
> portSuffix = port == schemeDefaultPort ? "" : ":" + port;
> }
> else if (secure && port != 443) portSuffix = ":" + port;
> else if (port != 80) portSuffix = ":" + port;
> The last line doesn't check secure flag, but it should be.
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Created] (TAP5-2031) BaseURLSourceImpl added default secure port to absolute url
Andrei Markov created TAP5-2031: --- Summary: BaseURLSourceImpl added default secure port to absolute url Key: TAP5-2031 URL: https://issues.apache.org/jira/browse/TAP5-2031 Project: Tapestry 5 Issue Type: Bug Components: tapestry-core Affects Versions: 5.3.1 Reporter: Andrei Markov Priority: Trivial BaseURLSourceImpl.getBaseURL(boolean secure) shoudn't add port 443 for url with secure scheme. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
