[jira] [Updated] (TAP5-2267) Contributing ExceptionHandlerAssistant instances to RequestExceptionHandler is broken
[ https://issues.apache.org/jira/browse/TAP5-2267?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dragan Sahpaski updated TAP5-2267: -- Attachment: TAP5-2267.patch > Contributing ExceptionHandlerAssistant instances to RequestExceptionHandler > is broken > - > > Key: TAP5-2267 > URL: https://issues.apache.org/jira/browse/TAP5-2267 > Project: Tapestry 5 > Issue Type: Bug > Components: tapestry-core >Affects Versions: 5.4 >Reporter: Dragan Sahpaski >Priority: Minor > Attachments: TAP5-2267.patch > > > DefaultRequestExceptionHandler fails with ClassCastException when an instance > of ExceptionHandlerAssistant is contributed to RequestExceptionHandler. > This had been broken accidentally in commit > cb3d4c853f47cccf9193c33cfd085d6ca27c8706 when implementing contributions of > assistant classes that are autobuilt. > Although DefaultRequestExceptionHandlerTest covers contributions of > ExceptionHandlerAssistant instances, it didn't fail because of an oversight > in the test. > The patch resolves the bug (trivially) and improves existing tests in > DefaultRequestExceptionHandlerTest which now fail without patching > DefaultRequestExceptionHandler. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Created] (TAP5-2267) Contributing ExceptionHandlerAssistant instances to RequestExceptionHandler is broken
Dragan Sahpaski created TAP5-2267: - Summary: Contributing ExceptionHandlerAssistant instances to RequestExceptionHandler is broken Key: TAP5-2267 URL: https://issues.apache.org/jira/browse/TAP5-2267 Project: Tapestry 5 Issue Type: Bug Components: tapestry-core Affects Versions: 5.4 Reporter: Dragan Sahpaski Priority: Minor DefaultRequestExceptionHandler fails with ClassCastException when an instance of ExceptionHandlerAssistant is contributed to RequestExceptionHandler. This had been broken accidentally in commit cb3d4c853f47cccf9193c33cfd085d6ca27c8706 when implementing contributions of assistant classes that are autobuilt. Although DefaultRequestExceptionHandlerTest covers contributions of ExceptionHandlerAssistant instances, it didn't fail because of an oversight in the test. The patch resolves the bug (trivially) and improves existing tests in DefaultRequestExceptionHandlerTest which now fail without patching DefaultRequestExceptionHandler. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
