[jira] [Closed] (TAP5-2309) Hungarian localization for tapestry 5.4
[ https://issues.apache.org/jira/browse/TAP5-2309?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jochen Kemnade closed TAP5-2309. Resolution: Fixed Fix Version/s: 5.4 > Hungarian localization for tapestry 5.4 > --- > > Key: TAP5-2309 > URL: https://issues.apache.org/jira/browse/TAP5-2309 > Project: Tapestry 5 > Issue Type: Improvement > Components: tapestry-core, tapestry-kaptcha >Affects Versions: 5.4 >Reporter: Balázs Palcsó >Assignee: Jochen Kemnade > Labels: patch > Fix For: 5.4 > > Attachments: HungarianTranslation.patch > > -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (TAP5-2309) Hungarian localization for tapestry 5.4
[ https://issues.apache.org/jira/browse/TAP5-2309?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13982784#comment-13982784 ] ASF subversion and git services commented on TAP5-2309: --- Commit 133374e92c41bde99825cd2d5f6a8dcd706cc530 in tapestry-5's branch refs/heads/master from [~jkemnade] [ https://git-wip-us.apache.org/repos/asf?p=tapestry-5.git;h=133374e ] TAP5-2309: #close Add Hungarian translation contributed by Balázs Palcsó > Hungarian localization for tapestry 5.4 > --- > > Key: TAP5-2309 > URL: https://issues.apache.org/jira/browse/TAP5-2309 > Project: Tapestry 5 > Issue Type: Improvement > Components: tapestry-core, tapestry-kaptcha >Affects Versions: 5.4 >Reporter: Balázs Palcsó >Assignee: Jochen Kemnade > Labels: patch > Fix For: 5.4 > > Attachments: HungarianTranslation.patch > > -- This message was sent by Atlassian JIRA (v6.2#6252)
git commit: TAP5-2309: #close Add Hungarian translation contributed by Balázs Palcsó
Repository: tapestry-5 Updated Branches: refs/heads/master 1a37c6abd -> 133374e92 TAP5-2309: #close Add Hungarian translation contributed by Balázs Palcsó Project: http://git-wip-us.apache.org/repos/asf/tapestry-5/repo Commit: http://git-wip-us.apache.org/repos/asf/tapestry-5/commit/133374e9 Tree: http://git-wip-us.apache.org/repos/asf/tapestry-5/tree/133374e9 Diff: http://git-wip-us.apache.org/repos/asf/tapestry-5/diff/133374e9 Branch: refs/heads/master Commit: 133374e92c41bde99825cd2d5f6a8dcd706cc530 Parents: 1a37c6a Author: Jochen Kemnade Authored: Mon Apr 28 08:44:24 2014 +0200 Committer: Jochen Kemnade Committed: Mon Apr 28 08:44:24 2014 +0200 -- .../org/apache/tapestry5/core_hu.properties | 114 +++ .../kaptcha/tapestry-kaptcha_hu.properties | 17 +++ 2 files changed, 131 insertions(+) -- http://git-wip-us.apache.org/repos/asf/tapestry-5/blob/133374e9/tapestry-core/src/main/resources/org/apache/tapestry5/core_hu.properties -- diff --git a/tapestry-core/src/main/resources/org/apache/tapestry5/core_hu.properties b/tapestry-core/src/main/resources/org/apache/tapestry5/core_hu.properties new file mode 100644 index 000..5711e98 --- /dev/null +++ b/tapestry-core/src/main/resources/org/apache/tapestry5/core_hu.properties @@ -0,0 +1,114 @@ +# Copyright 2013 The Apache Software Foundation +# +# Licensed under the Apache License, Version 2.0 (the "License"); +# you may not use this file except in compliance with the License. +# You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. + +# We try to keep the validation messages consistent, with the constraint +# value (if applicable) as the first parameter, and the field's label as the +# second parameter. Occasionally we must use specific indexing when that's +# not the best order. + +# PropertyEditor "Unable to locate block" error: +core-block-error=Nem található szerkesztÅ block defÃnició a(z) %3$s tÃpusú %4$s értékű objektum '%1$s' mezÅjéhez (adattÃpus (data type) '%2$s') + +# BeanEditForm "Cancel" button label: +core-cancel-label=Mégse + +# DateField validation error: +core-date-value-not-parseable='%s' dátum nem értelmezhetÅ. + +# Validation error summary instructions: +core-default-error-banner=A folytatáshoz az alábbi hibákat javÃtania kell. + +# Alerts "Dismiss" label: +core-dismiss-label=Ãsszes figyelmen kÃvül hagyása + +# Form nesting error: +core-form-nesting-not-allowed=Form komponensek nem ágyazhatóak egymásba/másik Form komponensbe. + +# Grid pager link title: +core-goto-page=Ugrás a(z) %d oldalra + +# Form missing POST or t:formdata error: +core-invalid-form-request=Form-okat POST módon kell a szerver felé elküldeni. A kérésnek tartalmaznia kell a következÅ mezÅket: %s + +# Grid "no data" message: +core-no-grid-data-to-display=Nincs megjelenÃthetÅ adat. + +# Palette Available list label: +core-palette-available-label=ElérhetÅ + +# Palette Deselect button: +core-palette-deselect-label=< Kijelölés megszűntetése + +# Palette Move Down button: +core-palette-down-label=Le + +# Palette Select button: +core-palette-select-label=Kijelölés > + +# Palette Selected list label: +core-palette-selected-label=Kijelölt + +# Palette Move Up button: +core-palette-up-label=Fel + +# ProgressiveDisplay "loading" label: +core-progressive-display-loading=Betöltés ... + +# BeanEditForm "Submit" button: +core-submit-label=Létrehoz/Ment + +# String-to-integer translation error: +integer-format-exception=%s egész szám kell legyen. + +# "email" validator error: +invalid-email=Ãrvénytelen e-mail cÃm. + +# Integer "max" validator error: +max-integer=%2$s nem lehet nagyobb, mint %1$d. + +# String "maxLength" validation error: +maximum-string-length=%2$s legfeljebb %1$d karakter hosszú lehet. + +# Integer "min" validator error: +min-integer=%2$s nem lehet kisebb, mint %1$d. + +# String "minLength" validator error: +minimum-string-length=%2$s legalább %1$d karakter hosszú kell legyen. + +# String-to-number translation error: +number-format-exception=%s szám kell legyen. + +# "regexp" validator error: +regexp=%2$s nem felel meg az elvárt '%1$s' formátumnak. + +# "required" validator error: +required=%s megadása kötelezÅ. + +# Client-side numeric validation error: +core-input-not-numeric=A megadott érték nem szám. + +# Client-side integer validation error: +core-input-not-integer=A megadott érték nem egÃ
[jira] [Assigned] (TAP5-2309) Hungarian localization for tapestry 5.4
[ https://issues.apache.org/jira/browse/TAP5-2309?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jochen Kemnade reassigned TAP5-2309: Assignee: Jochen Kemnade > Hungarian localization for tapestry 5.4 > --- > > Key: TAP5-2309 > URL: https://issues.apache.org/jira/browse/TAP5-2309 > Project: Tapestry 5 > Issue Type: Improvement > Components: tapestry-core, tapestry-kaptcha >Affects Versions: 5.4 >Reporter: Balázs Palcsó >Assignee: Jochen Kemnade > Labels: patch > Attachments: HungarianTranslation.patch > > -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Updated] (TAP5-2318) Module responses uses paranoid max-age: 0, should be more liberal in production
[ https://issues.apache.org/jira/browse/TAP5-2318?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jochen Kemnade updated TAP5-2318: - Issue Type: Improvement (was: Bug) > Module responses uses paranoid max-age: 0, should be more liberal in > production > --- > > Key: TAP5-2318 > URL: https://issues.apache.org/jira/browse/TAP5-2318 > Project: Tapestry 5 > Issue Type: Improvement > Components: tapestry-core >Affects Versions: 5.4 >Reporter: Howard M. Lewis Ship > Labels: cache > > Since module requests can-not contain a content checksum in the URL, they > must be validated by the client frequently. > In development, a max-age of 0 makes sense; there is no cost to checking the > module's current status (modules include E-Tag headers) and a stiff cost to > having the wrong code running in the browser during development. > In production, the max-age of 0 causes a significant load on the origin > server as even intermediate caches must pass a constant stream of requests > through to the origin server for validation ... even for a user navigating > from page to page within the application (rather than returning to the > application hours or days later). > Having max-age (and the other values) be configurable in production would be > ideal; a max-age of several minutes to an hour would likely result in > virtually no client-side failures. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Closed] (TAP5-2091) Idea generates Java-6-style @Override annotations
[ https://issues.apache.org/jira/browse/TAP5-2091?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jochen Kemnade closed TAP5-2091. Resolution: Fixed Seems to be fixed now > Idea generates Java-6-style @Override annotations > - > > Key: TAP5-2091 > URL: https://issues.apache.org/jira/browse/TAP5-2091 > Project: Tapestry 5 > Issue Type: Bug >Affects Versions: 5.4 >Reporter: Jochen Kemnade > Attachments: 0001-remove-some-Java-6-style-Override-annotations.patch > > > From time to time, there are @Override annotations creeping into the > codebase. This seems to be an Idea-issue that has already been addressed in > 629fa5a4, but apparently that didn't have the desired effect. > http://issues.gradle.org/browse/GRADLE-2668 might be related. > The attached patch only removes the annotations but does not address the > cause. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Updated] (TAP5-1975) Tapestry should recognize explicit ids in the template, automatically prevent id collisions
[ https://issues.apache.org/jira/browse/TAP5-1975?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jochen Kemnade updated TAP5-1975: - Issue Type: Improvement (was: Bug) > Tapestry should recognize explicit ids in the template, automatically prevent > id collisions > --- > > Key: TAP5-1975 > URL: https://issues.apache.org/jira/browse/TAP5-1975 > Project: Tapestry 5 > Issue Type: Improvement > Components: tapestry-core >Affects Versions: 5.4 >Reporter: Howard M. Lewis Ship >Priority: Minor > > If a template contains markup with a literal id, say , and a > component exists with the same component id (think: t:id="link"/>), then the component may render itself using the same id. > Tapestry should recognize the set of ids defined explicitly be components in > the template. During a full-page render, those ids should be pre-allocated to > prevent collisions; thus the component would render itself with id="link_0". -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Updated] (TAP5-2203) Popup Calendar used by DateField does not have an option to cancel changes
[ https://issues.apache.org/jira/browse/TAP5-2203?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jochen Kemnade updated TAP5-2203: - Issue Type: Improvement (was: Bug) > Popup Calendar used by DateField does not have an option to cancel changes > -- > > Key: TAP5-2203 > URL: https://issues.apache.org/jira/browse/TAP5-2203 > Project: Tapestry 5 > Issue Type: Improvement > Components: tapestry-core >Affects Versions: 5.4 >Reporter: Paul Stanton > Labels: client, javascript > > using the datefield component, if a user changes their mind there seems to be > no way for them to close the popup without changing the value in some way. > once the icon has been clicked, there's no option to close the popup > explicitly and selecting the current value is disabled so the user has to > select another date to close the popup. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Updated] (TAP5-2292) Autocomplete Mixin shows only 5 suggestions
[
https://issues.apache.org/jira/browse/TAP5-2292?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jochen Kemnade updated TAP5-2292:
-
Issue Type: Wish (was: Bug)
> Autocomplete Mixin shows only 5 suggestions
> ---
>
> Key: TAP5-2292
> URL: https://issues.apache.org/jira/browse/TAP5-2292
> Project: Tapestry 5
> Issue Type: Wish
>Affects Versions: 5.4
>Reporter: yiannis pericleous
> Labels: autocomplete, typeahead
>
> Typeahead, which is used by the autocomplete mixin by default limits the
> results shown to 5.
> The mixin provides no way of setting the limit parameter in typeahead.
> The fix is simple, introduce a 'limit' parameter in the mixin, and in
> autocomplete.js do something like:
> return $field.typeahead({
> minLength: spec.minChars,
> limit: spec.limit,
> remote: {
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (TAP5-1741) Parsing template which contains Chinese (Maybe other double bytes) words throws MalformedByteSequenceException: Invalid byte 3 of 3-byte UTF-8 sequence.
[ https://issues.apache.org/jira/browse/TAP5-1741?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13982328#comment-13982328 ] Jochen Kemnade commented on TAP5-1741: -- This should be fixed in master now (see TAP5-2219). > Parsing template which contains Chinese (Maybe other double bytes) words > throws MalformedByteSequenceException: Invalid byte 3 of 3-byte UTF-8 > sequence. > > > Key: TAP5-1741 > URL: https://issues.apache.org/jira/browse/TAP5-1741 > Project: Tapestry 5 > Issue Type: Bug > Components: tapestry-core >Affects Versions: 5.3 >Reporter: DH >Assignee: Igor Drobiazko >Priority: Blocker > Attachments: Index.tml, charset.diff > > > After upgrading to 5.3-rc-1, all my templates are not parsed successfully. > The error message points to the line where there are Chinese words. > Stack Trace below: > Caused by: > com.sun.org.apache.xerces.internal.impl.io.MalformedByteSequenceException: > Invalid byte 3 of 3-byte UTF-8 sequence. > at > com.sun.org.apache.xerces.internal.impl.io.UTF8Reader.invalidByte(UTF8Reader.java:684) > at > com.sun.org.apache.xerces.internal.impl.io.UTF8Reader.read(UTF8Reader.java:432) > at > com.sun.org.apache.xerces.internal.impl.XMLEntityScanner.load(XMLEntityScanner.java:1742) > at > com.sun.org.apache.xerces.internal.impl.XMLEntityScanner.skipChar(XMLEntityScanner.java:1416) > at > com.sun.org.apache.xerces.internal.impl.XMLDocumentFragmentScannerImpl$FragmentContentDriver.next(XMLDocumentFragmentScannerImpl.java:2792) > at > com.sun.org.apache.xerces.internal.impl.XMLDocumentScannerImpl.next(XMLDocumentScannerImpl.java:648) > at > com.sun.org.apache.xerces.internal.impl.XMLNSDocumentScannerImpl.next(XMLNSDocumentScannerImpl.java:140) > at > com.sun.org.apache.xerces.internal.impl.XMLDocumentFragmentScannerImpl.scanDocument(XMLDocumentFragmentScannerImpl.java:511) > at > com.sun.org.apache.xerces.internal.parsers.XML11Configuration.parse(XML11Configuration.java:808) > at > com.sun.org.apache.xerces.internal.parsers.XML11Configuration.parse(XML11Configuration.java:737) > at > com.sun.org.apache.xerces.internal.parsers.XMLParser.parse(XMLParser.java:119) > at > com.sun.org.apache.xerces.internal.parsers.AbstractSAXParser.parse(AbstractSAXParser.java:1205) > at > org.apache.tapestry5.internal.services.XMLTokenStream.parse(XMLTokenStream.java:306) > at > org.apache.tapestry5.internal.services.SaxTemplateParser.parse(SaxTemplateParser.java:163) > ... 85 more -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Closed] (TAP5-2183) 5.4 Linksubmit does not generate events with Bootstrap glyphicon
[ https://issues.apache.org/jira/browse/TAP5-2183?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jochen Kemnade closed TAP5-2183. Resolution: Fixed Fix Version/s: 5.4 > 5.4 Linksubmit does not generate events with Bootstrap glyphicon > > > Key: TAP5-2183 > URL: https://issues.apache.org/jira/browse/TAP5-2183 > Project: Tapestry 5 > Issue Type: Bug > Components: tapestry-core >Affects Versions: 5.4 >Reporter: Barry Books >Assignee: Jochen Kemnade > Fix For: 5.4 > > > It appears for some reason the link submit component does not work > correctly if the only thing it contains is a Bootstrap glyphicon. > For example: > Change > calls the changeCart event handler > > does not -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Closed] (TAP5-2229) Make the DatePicker script an AMD module
[ https://issues.apache.org/jira/browse/TAP5-2229?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jochen Kemnade closed TAP5-2229. Resolution: Fixed Fix Version/s: 5.4 > Make the DatePicker script an AMD module > > > Key: TAP5-2229 > URL: https://issues.apache.org/jira/browse/TAP5-2229 > Project: Tapestry 5 > Issue Type: Improvement > Components: tapestry-core >Affects Versions: 5.4 >Reporter: Jochen Kemnade >Assignee: Jochen Kemnade >Priority: Minor > Labels: amd, datepicker, javascript, patch > Fix For: 5.4 > > Attachments: 0001-Wrap-the-DatePicker-script-into-an-AMD-module.patch > > > The DatePicker JavaScript should be an AMD module. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (TAP5-1778) Template parsing dependent on JVM default charset
[ https://issues.apache.org/jira/browse/TAP5-1778?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13982323#comment-13982323 ] ASF subversion and git services commented on TAP5-1778: --- Commit 1a37c6abd59254d3e9e6ce676cd7b300d704ecac in tapestry-5's branch refs/heads/master from [~jkemnade] [ https://git-wip-us.apache.org/repos/asf?p=tapestry-5.git;h=1a37c6a ] TAP5-2219, TAP5-1778, TAP5-1714: when transforming the template stream, use the same encoding for the input and the output > Template parsing dependent on JVM default charset > - > > Key: TAP5-1778 > URL: https://issues.apache.org/jira/browse/TAP5-1778 > Project: Tapestry 5 > Issue Type: Bug > Components: tapestry-core >Affects Versions: 5.3 >Reporter: Robert Coie >Assignee: Jochen Kemnade >Priority: Minor > Attachments: charset_5_3_5.patch > > > This is my first experience with JIRA, so apologies if it is not formatted > properly. I raised this topic on the tapestry-users mailing list and was > asked by a couple of people there to create an issue here. > internal.services.XMLTokenStream's openStream method contains the following > lines: > InputStreamReader rawReader = new InputStreamReader(rawStream); > ... > PrintWriter writer = new PrintWriter(bos); > Both of these implicitly rely on the default JVM charset. This poses a > significant problem for non-ASCII text in templates on Google App Engine, > where the default is "US-ASCII". In the interests of robustness, I think it > would be nice if Tapestry was able to eliminate any reliance on default > charsets. I am not confident enough in my understanding of Tapestry internals > to know how to appropriately retrieve symbol properties (such as > "tapestry.charset") via the IoC system in internal service implementations, > but I have verified that explicitly specifying "UTF-8" as follows resolved my > problem: > InputStreamReader rawReader = new InputStreamReader(rawStream, "UTF-8"); > ... > PrintWriter writer = new PrintWriter( new OutputStreamWriter(bos, "UTF-8") ); -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (TAP5-2229) Make the DatePicker script an AMD module
[ https://issues.apache.org/jira/browse/TAP5-2229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13982321#comment-13982321 ] ASF subversion and git services commented on TAP5-2229: --- Commit 70d4efbce0b90dd34b20b7872e5fbe6572a248d1 in tapestry-5's branch refs/heads/master from [~jkemnade] [ https://git-wip-us.apache.org/repos/asf?p=tapestry-5.git;h=70d4efb ] TAP5-2229: make the DatePicker JavaScript an AMD module > Make the DatePicker script an AMD module > > > Key: TAP5-2229 > URL: https://issues.apache.org/jira/browse/TAP5-2229 > Project: Tapestry 5 > Issue Type: Improvement > Components: tapestry-core >Affects Versions: 5.4 >Reporter: Jochen Kemnade >Assignee: Jochen Kemnade >Priority: Minor > Labels: amd, datepicker, javascript, patch > Attachments: 0001-Wrap-the-DatePicker-script-into-an-AMD-module.patch > > > The DatePicker JavaScript should be an AMD module. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (TAP5-2219) XML-Parsing broken if system encoding is not UTF-8
[ https://issues.apache.org/jira/browse/TAP5-2219?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13982322#comment-13982322 ] ASF subversion and git services commented on TAP5-2219: --- Commit 1a37c6abd59254d3e9e6ce676cd7b300d704ecac in tapestry-5's branch refs/heads/master from [~jkemnade] [ https://git-wip-us.apache.org/repos/asf?p=tapestry-5.git;h=1a37c6a ] TAP5-2219, TAP5-1778, TAP5-1714: when transforming the template stream, use the same encoding for the input and the output > XML-Parsing broken if system encoding is not UTF-8 > -- > > Key: TAP5-2219 > URL: https://issues.apache.org/jira/browse/TAP5-2219 > Project: Tapestry 5 > Issue Type: Bug > Components: tapestry-core >Affects Versions: 5.4 > Environment: Windows (probably linux too but most systems run with > utf-8) >Reporter: Michael Wyraz >Assignee: Jochen Kemnade > Attachments: XMLTokenStreamTests.java > > Original Estimate: 0.5h > Remaining Estimate: 0.5h > > Tapestry reads tml files in XMLTokenStream.openStream(), does some doctype > "magic" and writes all the file content's into a ByteOutputStream. On T5.3 > reading/writing was done using the system's caracter encoding. With T5.4 that > was changed for the reader but not for the writer. This messes up all > non-ascii characters if system encoding is not utf-8. > Solution: Change > PrintWriter writer = new PrintWriter(bos); > To > PrintWriter writer = new PrintWriter(new OutputStreamWriter(bos, > "UTF8")); > in XMLTokenStream.openStream(). > TODO: Unit test for XMLTokenStream (follows soon) -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Closed] (TAP5-2219) XML-Parsing broken if system encoding is not UTF-8
[ https://issues.apache.org/jira/browse/TAP5-2219?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jochen Kemnade closed TAP5-2219. Resolution: Fixed Fix Version/s: 5.4 > XML-Parsing broken if system encoding is not UTF-8 > -- > > Key: TAP5-2219 > URL: https://issues.apache.org/jira/browse/TAP5-2219 > Project: Tapestry 5 > Issue Type: Bug > Components: tapestry-core >Affects Versions: 5.4 > Environment: Windows (probably linux too but most systems run with > utf-8) >Reporter: Michael Wyraz >Assignee: Jochen Kemnade > Fix For: 5.4 > > Attachments: XMLTokenStreamTests.java > > Original Estimate: 0.5h > Remaining Estimate: 0.5h > > Tapestry reads tml files in XMLTokenStream.openStream(), does some doctype > "magic" and writes all the file content's into a ByteOutputStream. On T5.3 > reading/writing was done using the system's caracter encoding. With T5.4 that > was changed for the reader but not for the writer. This messes up all > non-ascii characters if system encoding is not utf-8. > Solution: Change > PrintWriter writer = new PrintWriter(bos); > To > PrintWriter writer = new PrintWriter(new OutputStreamWriter(bos, > "UTF8")); > in XMLTokenStream.openStream(). > TODO: Unit test for XMLTokenStream (follows soon) -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (TAP5-1714) Allow to specify name for the threads created by ParallelExecutorImpl
[ https://issues.apache.org/jira/browse/TAP5-1714?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13982324#comment-13982324 ] ASF subversion and git services commented on TAP5-1714: --- Commit 1a37c6abd59254d3e9e6ce676cd7b300d704ecac in tapestry-5's branch refs/heads/master from [~jkemnade] [ https://git-wip-us.apache.org/repos/asf?p=tapestry-5.git;h=1a37c6a ] TAP5-2219, TAP5-1778, TAP5-1714: when transforming the template stream, use the same encoding for the input and the output > Allow to specify name for the threads created by ParallelExecutorImpl > - > > Key: TAP5-1714 > URL: https://issues.apache.org/jira/browse/TAP5-1714 > Project: Tapestry 5 > Issue Type: Wish > Components: tapestry-core >Affects Versions: 5.3, 5.4, 5.2 >Reporter: Jochen Kemnade >Priority: Minor > > It would be great if the ParallelExecutorImpl used a custom ThreadFactory > that used names like "parallelexecutor-thread-n" for the created threads. > "parallelexecutor" could be made an overrideable symbol, e.g. > tapestry.thread-pool.thread-name-prefix. That would allow different > Tapestry-based web applications running in the same container to use > different prefixes for the threads making them more distinguishable when > monitoring the container with visualvm or the like. > I could come up with a patch if you want me to. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (TAP5-2183) 5.4 Linksubmit does not generate events with Bootstrap glyphicon
[ https://issues.apache.org/jira/browse/TAP5-2183?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13982320#comment-13982320 ] ASF subversion and git services commented on TAP5-2183: --- Commit f65adf64c9311c8246a36fdd1a4ccbc692f7765c in tapestry-5's branch refs/heads/master from [~jkemnade] [ https://git-wip-us.apache.org/repos/asf?p=tapestry-5.git;h=f65adf6 ] TAP5-2183: correctly set the submitting element for LinkSumbit component with nested elements > 5.4 Linksubmit does not generate events with Bootstrap glyphicon > > > Key: TAP5-2183 > URL: https://issues.apache.org/jira/browse/TAP5-2183 > Project: Tapestry 5 > Issue Type: Bug > Components: tapestry-core >Affects Versions: 5.4 >Reporter: Barry Books >Assignee: Jochen Kemnade > > It appears for some reason the link submit component does not work > correctly if the only thing it contains is a Bootstrap glyphicon. > For example: > Change > calls the changeCart event handler > > does not -- This message was sent by Atlassian JIRA (v6.2#6252)
[1/3] git commit: TAP5-2183: correctly set the submitting element for LinkSumbit component with nested elements
Repository: tapestry-5
Updated Branches:
refs/heads/master 36375f07c -> 1a37c6abd
TAP5-2183: correctly set the submitting element for LinkSumbit component with
nested elements
Project: http://git-wip-us.apache.org/repos/asf/tapestry-5/repo
Commit: http://git-wip-us.apache.org/repos/asf/tapestry-5/commit/f65adf64
Tree: http://git-wip-us.apache.org/repos/asf/tapestry-5/tree/f65adf64
Diff: http://git-wip-us.apache.org/repos/asf/tapestry-5/diff/f65adf64
Branch: refs/heads/master
Commit: f65adf64c9311c8246a36fdd1a4ccbc692f7765c
Parents: 36375f0
Author: Jochen Kemnade
Authored: Sun Apr 27 12:48:01 2014 +0200
Committer: Jochen Kemnade
Committed: Sun Apr 27 12:48:01 2014 +0200
--
.../META-INF/modules/t5/core/forms.coffee | 2 +-
tapestry-core/src/test/app1/LinkSubmitDemo.tml | 1 +
.../tapestry5/integration/app1/FormTests.java | 16
.../integration/app1/pages/LinkSubmitDemo.java | 2 ++
4 files changed, 20 insertions(+), 1 deletion(-)
--
http://git-wip-us.apache.org/repos/asf/tapestry-5/blob/f65adf64/tapestry-core/src/main/coffeescript/META-INF/modules/t5/core/forms.coffee
--
diff --git
a/tapestry-core/src/main/coffeescript/META-INF/modules/t5/core/forms.coffee
b/tapestry-core/src/main/coffeescript/META-INF/modules/t5/core/forms.coffee
index e148189..c20714a 100644
--- a/tapestry-core/src/main/coffeescript/META-INF/modules/t5/core/forms.coffee
+++ b/tapestry-core/src/main/coffeescript/META-INF/modules/t5/core/forms.coffee
@@ -180,7 +180,7 @@ define ["./events", "./dom", "underscore"],
console.error "Submitting link element not contained inside a form
element."
return false
- setSubmittingHidden form, this
+ setSubmittingHidden form, @closest "a[data-submit-mode]"
# Now the ugly part; if we just invoke submit() on the form, it does not
trigger
# the form's "submit" event, which we need.
http://git-wip-us.apache.org/repos/asf/tapestry-5/blob/f65adf64/tapestry-core/src/test/app1/LinkSubmitDemo.tml
--
diff --git a/tapestry-core/src/test/app1/LinkSubmitDemo.tml
b/tapestry-core/src/test/app1/LinkSubmitDemo.tml
index 6c5a196..7764e30 100644
--- a/tapestry-core/src/test/app1/LinkSubmitDemo.tml
+++ b/tapestry-core/src/test/app1/LinkSubmitDemo.tml
@@ -10,6 +10,7 @@
Fred
Barney
+ Pebbles
http://git-wip-us.apache.org/repos/asf/tapestry-5/blob/f65adf64/tapestry-core/src/test/java/org/apache/tapestry5/integration/app1/FormTests.java
--
diff --git
a/tapestry-core/src/test/java/org/apache/tapestry5/integration/app1/FormTests.java
b/tapestry-core/src/test/java/org/apache/tapestry5/integration/app1/FormTests.java
index 946a0bb..b0bf953 100644
---
a/tapestry-core/src/test/java/org/apache/tapestry5/integration/app1/FormTests.java
+++
b/tapestry-core/src/test/java/org/apache/tapestry5/integration/app1/FormTests.java
@@ -857,6 +857,22 @@ public class FormTests extends App1TestCase
assertText("name-value", "Betty");
assertText("last-clicked", "Barney");
}
+
+/**
+ * TAP5-2183
+ */
+@Test
+public void link_submit_component_with_nested_element()
+{
+openLinks("LinkSubmit Demo");
+
+type("name", "Wilma");
+
+clickAndWait("css=.glyphicon-star");
+
+assertText("name-value", "Wilma");
+assertText("last-clicked", "Pebbles");
+}
@Test
public void calendar_field_inside_bean_editor()
http://git-wip-us.apache.org/repos/asf/tapestry-5/blob/f65adf64/tapestry-core/src/test/java/org/apache/tapestry5/integration/app1/pages/LinkSubmitDemo.java
--
diff --git
a/tapestry-core/src/test/java/org/apache/tapestry5/integration/app1/pages/LinkSubmitDemo.java
b/tapestry-core/src/test/java/org/apache/tapestry5/integration/app1/pages/LinkSubmitDemo.java
index 9299619..4832f63 100644
---
a/tapestry-core/src/test/java/org/apache/tapestry5/integration/app1/pages/LinkSubmitDemo.java
+++
b/tapestry-core/src/test/java/org/apache/tapestry5/integration/app1/pages/LinkSubmitDemo.java
@@ -46,4 +46,6 @@ public class LinkSubmitDemo
}
void onNeighbor() { lastClicked = "Barney"; }
+
+void onDaughter() { lastClicked = "Pebbles"; }
}
[3/3] git commit: TAP5-2219, TAP5-1778, TAP5-1714: when transforming the template stream, use the same encoding for the input and the output
TAP5-2219, TAP5-1778, TAP5-1714: when transforming the template stream, use the
same encoding for the input and the output
Project: http://git-wip-us.apache.org/repos/asf/tapestry-5/repo
Commit: http://git-wip-us.apache.org/repos/asf/tapestry-5/commit/1a37c6ab
Tree: http://git-wip-us.apache.org/repos/asf/tapestry-5/tree/1a37c6ab
Diff: http://git-wip-us.apache.org/repos/asf/tapestry-5/diff/1a37c6ab
Branch: refs/heads/master
Commit: 1a37c6abd59254d3e9e6ce676cd7b300d704ecac
Parents: 70d4efb
Author: Jochen Kemnade
Authored: Sun Apr 27 15:30:30 2014 +0200
Committer: Jochen Kemnade
Committed: Sun Apr 27 15:30:30 2014 +0200
--
.../internal/services/XMLTokenStream.java | 6 +-
.../internal/services/XMLTokenStreamTests.java | 110 +++
2 files changed, 114 insertions(+), 2 deletions(-)
--
http://git-wip-us.apache.org/repos/asf/tapestry-5/blob/1a37c6ab/tapestry-core/src/main/java/org/apache/tapestry5/internal/services/XMLTokenStream.java
--
diff --git
a/tapestry-core/src/main/java/org/apache/tapestry5/internal/services/XMLTokenStream.java
b/tapestry-core/src/main/java/org/apache/tapestry5/internal/services/XMLTokenStream.java
index 1fe5656..b80c6d6 100644
---
a/tapestry-core/src/main/java/org/apache/tapestry5/internal/services/XMLTokenStream.java
+++
b/tapestry-core/src/main/java/org/apache/tapestry5/internal/services/XMLTokenStream.java
@@ -345,12 +345,14 @@ public class XMLTokenStream
private InputStream openStream() throws IOException
{
InputStream rawStream = resource.openStream();
+
+String transformationEncoding = "UTF8";
-InputStreamReader rawReader = new InputStreamReader(rawStream, "UTF8");
+InputStreamReader rawReader = new InputStreamReader(rawStream,
transformationEncoding);
LineNumberReader reader = new LineNumberReader(rawReader);
ByteArrayOutputStream bos = new ByteArrayOutputStream(5000);
-PrintWriter writer = new PrintWriter(bos);
+PrintWriter writer = new PrintWriter(new OutputStreamWriter(bos,
transformationEncoding));
State state = State.MAYBE_XML;
http://git-wip-us.apache.org/repos/asf/tapestry-5/blob/1a37c6ab/tapestry-core/src/test/java/org/apache/tapestry5/internal/services/XMLTokenStreamTests.java
--
diff --git
a/tapestry-core/src/test/java/org/apache/tapestry5/internal/services/XMLTokenStreamTests.java
b/tapestry-core/src/test/java/org/apache/tapestry5/internal/services/XMLTokenStreamTests.java
new file mode 100644
index 000..e80ad06
--- /dev/null
+++
b/tapestry-core/src/test/java/org/apache/tapestry5/internal/services/XMLTokenStreamTests.java
@@ -0,0 +1,110 @@
+package org.apache.tapestry5.internal.services;
+
+import java.io.ByteArrayInputStream;
+import java.io.IOException;
+import java.io.InputStream;
+import java.lang.reflect.Field;
+import java.net.URL;
+import java.nio.charset.Charset;
+import java.util.HashMap;
+
+import org.apache.tapestry5.internal.services.XMLTokenStream;
+import org.apache.tapestry5.internal.services.XMLTokenType;
+import org.apache.tapestry5.ioc.MappedConfiguration;
+import org.apache.tapestry5.ioc.Resource;
+import org.apache.tapestry5.ioc.internal.util.AbstractResource;
+import org.testng.Assert;
+import org.testng.annotations.Test;
+
+
+public class XMLTokenStreamTests
+{
+private static class MappedConfigurationStub extends HashMap
implements MappedConfiguration
+{
+public void add(K key, V value)
+{
+put(key,value);
+}
+public void override(K key, V value)
+{
+put(key,value);
+}
+public void addInstance(K key, Class clazz)
+{
+throw new UnsupportedOperationException();
+}
+public void overrideInstance(K key, Class clazz)
+{
+throw new UnsupportedOperationException();
+}
+}
+
+
+
+private static class ResourceStub extends AbstractResource
+{
+final byte[] content;
+public ResourceStub(byte[] content)
+{
+super("");
+this.content=content;
+}
+public URL toURL()
+{
+return null;
+}
+protected Resource newResource(String path)
+{
+return null;
+}
+@Override
+public InputStream openStream() throws IOException
+{
+return new ByteArrayInputStream(content);
+}
+}
+
+protected void resetDefaultCharset() throws Exception
+{
+// The charset is cached after system start - so we ned to clear that
cache to force a certain file.encoding
+Field field=Charset.class.getDeclaredField("defaultChars
[2/3] git commit: TAP5-2229: make the DatePicker JavaScript an AMD module
TAP5-2229: make the DatePicker JavaScript an AMD module
Project: http://git-wip-us.apache.org/repos/asf/tapestry-5/repo
Commit: http://git-wip-us.apache.org/repos/asf/tapestry-5/commit/70d4efbc
Tree: http://git-wip-us.apache.org/repos/asf/tapestry-5/tree/70d4efbc
Diff: http://git-wip-us.apache.org/repos/asf/tapestry-5/diff/70d4efbc
Branch: refs/heads/master
Commit: 70d4efbce0b90dd34b20b7872e5fbe6572a248d1
Parents: f65adf6
Author: Jochen Kemnade
Authored: Sun Apr 27 13:08:40 2014 +0200
Committer: Jochen Kemnade
Committed: Sun Apr 27 13:08:40 2014 +0200
--
.../META-INF/modules/t5/core/datefield.coffee | 17 +-
.../tapestry5/corelib/components/DateField.java | 3 +-
.../tapestry5/datepicker_106/js/datepicker.js | 744 --
.../META-INF/modules/t5/core/datepicker.js | 766 +++
4 files changed, 777 insertions(+), 753 deletions(-)
--
http://git-wip-us.apache.org/repos/asf/tapestry-5/blob/70d4efbc/tapestry-core/src/main/coffeescript/META-INF/modules/t5/core/datefield.coffee
--
diff --git
a/tapestry-core/src/main/coffeescript/META-INF/modules/t5/core/datefield.coffee
b/tapestry-core/src/main/coffeescript/META-INF/modules/t5/core/datefield.coffee
index bb3a6b5..aca4653 100644
---
a/tapestry-core/src/main/coffeescript/META-INF/modules/t5/core/datefield.coffee
+++
b/tapestry-core/src/main/coffeescript/META-INF/modules/t5/core/datefield.coffee
@@ -15,8 +15,8 @@
# ## t5/core/datefield
#
# Provides support for the `core/DateField` component.
-define ["./dom", "./events", "./messages", "./ajax", "underscore", "./fields"],
- (dom, events, messages, ajax, _) ->
+define ["./dom", "./events", "./messages", "./ajax", "underscore",
"./datepicker", "./fields"],
+ (dom, events, messages, ajax, _, DatePicker) ->
# Translate from the provided order (SUNDAY = 0, MONDAY = 1), to
@@ -24,18 +24,18 @@ define ["./dom", "./events", "./messages", "./ajax",
"underscore", "./fields"],
serverFirstDay = parseInt messages "date-symbols.first-day"
datePickerFirstDay = if serverFirstDay is 0 then 6 else serverFirstDay - 1
-# Loalize a few other things.
-DatePicker.months = (messages "date-symbols.months").split ","
+# Localize a few other things.
days = (messages "date-symbols.days").split ","
# Shuffle sunday to the end, so that monday is first.
days.push days.shift()
-DatePicker.days = _.map days, (name) -> name.substr(0, 1).toLowerCase()
+monthsLabels = (messages "date-symbols.months").split ","
+daysLabels = _.map days, (name) -> name.substr(0, 1).toLowerCase()
+todayLabel = messages "core-datefield-today"
+noneLabel = messages "core-datefield-none"
-DatePicker.TODAY = messages "core-datefield-today"
-DatePicker.NONE = messages "core-datefield-none"
# Track the active popup; only one allowed at a time. May look to rework
this
# later so that there's just one popup and it is moved around the
viewport, or
@@ -114,6 +114,9 @@ define ["./dom", "./events", "./messages", "./ajax",
"underscore", "./fields"],
createPopup: ->
@datePicker = new DatePicker()
@datePicker.setFirstWeekDay datePickerFirstDay
+
+@datePicker.setLocalizations monthsLabels, daysLabels, todayLabel,
noneLabel
+
@popup = dom.create("div", { class: "datefield-popup well"}).append
@datePicker.create()
@container.insertAfter @popup
http://git-wip-us.apache.org/repos/asf/tapestry-5/blob/70d4efbc/tapestry-core/src/main/java/org/apache/tapestry5/corelib/components/DateField.java
--
diff --git
a/tapestry-core/src/main/java/org/apache/tapestry5/corelib/components/DateField.java
b/tapestry-core/src/main/java/org/apache/tapestry5/corelib/components/DateField.java
index 286a845..b55cc7b 100644
---
a/tapestry-core/src/main/java/org/apache/tapestry5/corelib/components/DateField.java
+++
b/tapestry-core/src/main/java/org/apache/tapestry5/corelib/components/DateField.java
@@ -50,8 +50,7 @@ import java.util.Locale;
* @see TextField
*/
// TODO: More testing; see https://issues.apache.org/jira/browse/TAPESTRY-1844
-@Import(library = "${tapestry.datepicker}/js/datepicker.js",
-stylesheet = "${tapestry.datepicker}/css/datepicker.css",
+@Import(stylesheet = "${tapestry.datepicker}/css/datepicker.css",
module = "t5/core/datefield")
@Events(EventConstants.VALIDATE)
public class DateField extends AbstractField
http://git-wip-us.apache.org/repos/asf/tapestry-5/blob/70d4efbc/tapestry-core/src/main/resources/META-INF/assets/tapestry5/datepicker_106/js/datepicker.js
--
diff --git
a/tapestry-core/src/main/resources/
[jira] [Commented] (TAP5-1800) LinkSubmit/Submit should store evet and context in ComponentAction
[
https://issues.apache.org/jira/browse/TAP5-1800?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13982298#comment-13982298
]
Jochen Kemnade commented on TAP5-1800:
--
Have you set the {{defer}} parameter of the LinkSubmit and Submit components to
{{false}}?
> LinkSubmit/Submit should store evet and context in ComponentAction
> --
>
> Key: TAP5-1800
> URL: https://issues.apache.org/jira/browse/TAP5-1800
> Project: Tapestry 5
> Issue Type: Bug
> Components: tapestry-core
>Affects Versions: 5.3, 5.4
>Reporter: Michael Wyraz
>
> When using multiple LinkSubmit (e.g. in a Loop), the event and context from
> the last one is fired, independent of which is clicked.
> The reason is that the parameter "event" and "context" are determined during
> the execution of the ComponentAction by accessing the component's fields. So
> when the acion is defered (which is default), these fields contain the values
> from the last usage of the component. A workaround is to det defer=false.
> To fix it, simply store "event" and "context" to the process submission
> (beside the clientId which is already there).
> The same issue might apply to Submit, it has the same code (untested).
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (TAP5-1866) ZoneRefresh mixin should perform cleanup if the zone is destroyed
[
https://issues.apache.org/jira/browse/TAP5-1866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13982296#comment-13982296
]
Jochen Kemnade commented on TAP5-1866:
--
Do you think there is a way to rewrite the test without using
{{SeleniumTestCase.waitForElementToDisappear(String elementId)}} because that's
deprecated in 5.4?
I'd take care of updating the fix for 5.4 then.
> ZoneRefresh mixin should perform cleanup if the zone is destroyed
> -
>
> Key: TAP5-1866
> URL: https://issues.apache.org/jira/browse/TAP5-1866
> Project: Tapestry 5
> Issue Type: Improvement
> Components: tapestry-core
>Affects Versions: 5.3.2, 5.4
>Reporter: Dragan Sahpaski
>Assignee: Jochen Kemnade
>Priority: Minor
> Labels: patch, zonerefresh
> Attachments: TAP5-1866.patch
>
>
> Consider the following use case:
> A zone with a ZoneRefresh (located in another zone) is updated several times
> and then the outer zone is updated with another block.
> Currently, after the update, exceptions are constantly thrown by the
> javascript PeriodicUpdater in zone-refresh.js on the line
> "zoneRefresh.fire(Tapestry.ZONE_REFRESH_EVENT)" because the div element
> that's linked to the zone with Tapestry.Initializer.updateZoneOnEvent is not
> destroyed and the corresponding timer is also not destroyed.
> The ZoneRefresh mixin should cleanup after itself in scenarios like this.
> A patch with tests is provided.
> Summary:
> 1. [MODIFIED] zone-refresh.js - On a timer update if the zone does
> not exist remove the "div" element on which the updates are triggered and
> stop the timer.
> 2. [MODIFIED] ZoneRefreshTest.java - One test method added
> 3. [ADDED]ZoneRefreshDestroyingZones.tml - Demo page with one outer zone
> with a ZoneRefresh mixin that toggles between two inner zones each a with
> ZoneRefresh mixin.
> 4. [ADDED]ZoneRefreshDestroyingZones.java
> 5. [MODIFIED] Index.tml - Link to ZoneRefreshDestroyingZones added
> The patch does not modify any public API.
> This patch is also blocked by TAP5-1867
> "SeleniumTestCase.waitForElementToDisappear(String elementId) does not seem
> to work",
> because the patch uses SeleniumTestCase.waitForElementToDisappear(String
> elementId).
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (TAP5-1867) SeleniumTestCase.waitForElementToDisappear(String elementId) does not seem to work
[
https://issues.apache.org/jira/browse/TAP5-1867?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13982294#comment-13982294
]
Jochen Kemnade commented on TAP5-1867:
--
SeleniumTestCase.waitForElementToDisappear(String elementId) was deprecated in
5.4, so I'm in favor of removing 5.4 from the affected versions.
> SeleniumTestCase.waitForElementToDisappear(String elementId) does not seem to
> work
> --
>
> Key: TAP5-1867
> URL: https://issues.apache.org/jira/browse/TAP5-1867
> Project: Tapestry 5
> Issue Type: Bug
> Components: tapestry-test
>Affects Versions: 5.3.2, 5.4
>Reporter: Dragan Sahpaski
> Labels: patch
> Attachments: TAP5-1867.patch
>
>
> In TAP5-1492 [1] "New features for SeleniumTestCase" one of the added
> methods to SeleniumTestCase is waitForElementToDisappear.
> The commit [2] is by Howard on 31 Mar 2011.
> The Prototype hide() documentation [3] briefly says "Hides and returns
> element".
> I don't see it used in any of the tapestry projects and don't know if anyone
> has used it before.
> Here is the code:
> protected final void waitForElementToDisappear(String elementId)
> {
> String condition = String.format("window.$(\"%s\").hide()",
> elementId);
> waitForCondition(condition, PAGE_LOAD_TIMEOUT);
> }
> IMO this method does not what it is supposed to do.
> A Patch is provided just with one minor change
> protected final void waitForElementToDisappear(String elementId)
> {
> String condition = String.format("window.$(\"%s\") == undefined",
> elementId);
> waitForCondition(condition, PAGE_LOAD_TIMEOUT);
> }
> If there is a better approach please feel free to comment.
> [1] TAP5-1492 https://issues.apache.org/jira/browse/TAP5-1492
> [2] Commit
> http://svn.apache.org/viewvc/tapestry/tapestry5/trunk/tapestry-test/src/main/java/org/apache/tapestry5/test/SeleniumTestCase.java?p2=%2Ftapestry%2Ftapestry5%2Ftrunk%2Ftapestry-test%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Ftapestry5%2Ftest%2FSeleniumTestCase.java&p1=%2Ftapestry%2Ftapestry5%2Ftrunk%2Ftapestry-test%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Ftapestry5%2Ftest%2FSeleniumTestCase.java&r1=1087494&r2=1087493&view=diff&pathrev=1087494
> [3] Prototype hide() function http://prototypejs.org/api/element/hide
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Assigned] (TAP5-1866) ZoneRefresh mixin should perform cleanup if the zone is destroyed
[ https://issues.apache.org/jira/browse/TAP5-1866?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jochen Kemnade reassigned TAP5-1866: Assignee: Jochen Kemnade > ZoneRefresh mixin should perform cleanup if the zone is destroyed > - > > Key: TAP5-1866 > URL: https://issues.apache.org/jira/browse/TAP5-1866 > Project: Tapestry 5 > Issue Type: Improvement > Components: tapestry-core >Affects Versions: 5.3.2, 5.4 >Reporter: Dragan Sahpaski >Assignee: Jochen Kemnade >Priority: Minor > Labels: patch, zonerefresh > Attachments: TAP5-1866.patch > > > Consider the following use case: > A zone with a ZoneRefresh (located in another zone) is updated several times > and then the outer zone is updated with another block. > Currently, after the update, exceptions are constantly thrown by the > javascript PeriodicUpdater in zone-refresh.js on the line > "zoneRefresh.fire(Tapestry.ZONE_REFRESH_EVENT)" because the div element > that's linked to the zone with Tapestry.Initializer.updateZoneOnEvent is not > destroyed and the corresponding timer is also not destroyed. > The ZoneRefresh mixin should cleanup after itself in scenarios like this. > A patch with tests is provided. > Summary: > 1. [MODIFIED] zone-refresh.js - On a timer update if the zone does > not exist remove the "div" element on which the updates are triggered and > stop the timer. > 2. [MODIFIED] ZoneRefreshTest.java - One test method added > 3. [ADDED]ZoneRefreshDestroyingZones.tml - Demo page with one outer zone > with a ZoneRefresh mixin that toggles between two inner zones each a with > ZoneRefresh mixin. > 4. [ADDED]ZoneRefreshDestroyingZones.java > 5. [MODIFIED] Index.tml - Link to ZoneRefreshDestroyingZones added > The patch does not modify any public API. > This patch is also blocked by TAP5-1867 > "SeleniumTestCase.waitForElementToDisappear(String elementId) does not seem > to work", > because the patch uses SeleniumTestCase.waitForElementToDisappear(String > elementId). -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Assigned] (TAP5-2229) Make the DatePicker script an AMD module
[ https://issues.apache.org/jira/browse/TAP5-2229?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jochen Kemnade reassigned TAP5-2229: Assignee: Jochen Kemnade > Make the DatePicker script an AMD module > > > Key: TAP5-2229 > URL: https://issues.apache.org/jira/browse/TAP5-2229 > Project: Tapestry 5 > Issue Type: Improvement > Components: tapestry-core >Affects Versions: 5.4 >Reporter: Jochen Kemnade >Assignee: Jochen Kemnade >Priority: Minor > Labels: amd, datepicker, javascript, patch > Attachments: 0001-Wrap-the-DatePicker-script-into-an-AMD-module.patch > > > The DatePicker JavaScript should be an AMD module. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (TAP5-2278) ModuleDispatcher returns start page for requests to nonexistent modules
[
https://issues.apache.org/jira/browse/TAP5-2278?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13982287#comment-13982287
]
Jochen Kemnade commented on TAP5-2278:
--
There's even a test that ensures the ModuleDispatcher "returns false if no
module is found". So that actually seems to be the intended behavior. I wonder
why, because AssetDispatcher behaves differently (i.e. sends a 404 status).
> ModuleDispatcher returns start page for requests to nonexistent modules
> ---
>
> Key: TAP5-2278
> URL: https://issues.apache.org/jira/browse/TAP5-2278
> Project: Tapestry 5
> Issue Type: Bug
> Components: tapestry-core
>Affects Versions: 5.4
>Reporter: Jochen Kemnade
>Assignee: Jochen Kemnade
>
> A request to {code}${BASE_URL}/modules.gz/t5/core/xyz.js{code} returns the
> index page, it should return a HTTP 404 instead.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Updated] (TAP5-2278) ModuleDispatcher returns start page for requests to nonexistent modules
[
https://issues.apache.org/jira/browse/TAP5-2278?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jochen Kemnade updated TAP5-2278:
-
Description: A request to {code}${BASE_URL}/modules.gz/t5/core/xyz.js{code}
returns the index page, it should return a HTTP 404 instead. (was: A request
to {{${BASE_URL}/modules.gz/t5/core/xyz.js}} returns the index page, it should
return a HTTP 404 instead.)
> ModuleDispatcher returns start page for requests to nonexistent modules
> ---
>
> Key: TAP5-2278
> URL: https://issues.apache.org/jira/browse/TAP5-2278
> Project: Tapestry 5
> Issue Type: Bug
> Components: tapestry-core
>Affects Versions: 5.4
>Reporter: Jochen Kemnade
>Assignee: Jochen Kemnade
>
> A request to {code}${BASE_URL}/modules.gz/t5/core/xyz.js{code} returns the
> index page, it should return a HTTP 404 instead.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Closed] (TAP5-2233) AjaxFormLoop: rowvalue missing when removeRowLink is not plain text
[ https://issues.apache.org/jira/browse/TAP5-2233?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jochen Kemnade closed TAP5-2233. Resolution: Fixed Fix Version/s: 5.4 > AjaxFormLoop: rowvalue missing when removeRowLink is not plain text > --- > > Key: TAP5-2233 > URL: https://issues.apache.org/jira/browse/TAP5-2233 > Project: Tapestry 5 > Issue Type: Bug > Components: tapestry-core >Affects Versions: 5.4 >Reporter: Felix Gonschorek >Assignee: Jochen Kemnade >Priority: Minor > Fix For: 5.4 > > > Component: RemoveRowLink > Version: 5.4 alpha 25 > Browser: Chrome Win 8 > > > > ajaxformloop.js searches for the "data-afl-row-value" attribute on the > element that has been clicked. the data attribute is rendered on the link. > the element that emits the click event is the image. > result: "rowvalue" is missing => exception. > Intermediate solution: use text only as body for RemoveRowLink component. the > event will be emitted from the element and the data attributes will be > present. > Regression: this bug was introduced in tapestry < 5.4, in 5.3.x it worked for > us. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Closed] (TAP5-2277) Update momentjs
[ https://issues.apache.org/jira/browse/TAP5-2277?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jochen Kemnade closed TAP5-2277. Resolution: Fixed Fix Version/s: 5.4 > Update momentjs > --- > > Key: TAP5-2277 > URL: https://issues.apache.org/jira/browse/TAP5-2277 > Project: Tapestry 5 > Issue Type: Improvement > Components: tapestry-core >Affects Versions: 5.4 >Reporter: Jochen Kemnade >Assignee: Jochen Kemnade > Labels: javascript, library, update > Fix For: 5.4 > > > Update Moment.js from 2.4.0 to 2.6.0 -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (TAP5-2277) Update momentjs
[ https://issues.apache.org/jira/browse/TAP5-2277?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13982259#comment-13982259 ] ASF subversion and git services commented on TAP5-2277: --- Commit 36375f07cb45f6da87434f4c2ba2b010397d0e05 in tapestry-5's branch refs/heads/master from [~jkemnade] [ https://git-wip-us.apache.org/repos/asf?p=tapestry-5.git;h=36375f0 ] TAP5-2277: update Moment.js to latest release > Update momentjs > --- > > Key: TAP5-2277 > URL: https://issues.apache.org/jira/browse/TAP5-2277 > Project: Tapestry 5 > Issue Type: Improvement > Components: tapestry-core >Affects Versions: 5.4 >Reporter: Jochen Kemnade >Assignee: Jochen Kemnade > Labels: javascript, library, update > > Update Moment.js from 2.4.0 to 2.6.0 -- This message was sent by Atlassian JIRA (v6.2#6252)
[4/5] git commit: TAP5-2277: update Moment.js to latest release
TAP5-2277: update Moment.js to latest release
Project: http://git-wip-us.apache.org/repos/asf/tapestry-5/repo
Commit: http://git-wip-us.apache.org/repos/asf/tapestry-5/commit/36375f07
Tree: http://git-wip-us.apache.org/repos/asf/tapestry-5/tree/36375f07
Diff: http://git-wip-us.apache.org/repos/asf/tapestry-5/diff/36375f07
Branch: refs/heads/master
Commit: 36375f07cb45f6da87434f4c2ba2b010397d0e05
Parents: 3e600c7
Author: Jochen Kemnade
Authored: Sat Apr 26 16:36:08 2014 +0200
Committer: Jochen Kemnade
Committed: Sat Apr 26 17:41:20 2014 +0200
--
.../tapestry5/modules/JavaScriptModule.java |2 +-
.../META-INF/assets/tapestry5/moment-2.4.0.js | 7063
.../META-INF/assets/tapestry5/moment-2.6.0.js | 7993 ++
3 files changed, 7994 insertions(+), 7064 deletions(-)
--
http://git-wip-us.apache.org/repos/asf/tapestry-5/blob/36375f07/tapestry-core/src/main/java/org/apache/tapestry5/modules/JavaScriptModule.java
--
diff --git
a/tapestry-core/src/main/java/org/apache/tapestry5/modules/JavaScriptModule.java
b/tapestry-core/src/main/java/org/apache/tapestry5/modules/JavaScriptModule.java
index 0986756..0d08463 100644
---
a/tapestry-core/src/main/java/org/apache/tapestry5/modules/JavaScriptModule.java
+++
b/tapestry-core/src/main/java/org/apache/tapestry5/modules/JavaScriptModule.java
@@ -299,7 +299,7 @@ public class JavaScriptModule
@Path("${tapestry.asset.root}/typeahead-0.9.3.js")
Resource typeahead,
-
@Path("${tapestry.asset.root}/moment-2.4.0.js")
+
@Path("${tapestry.asset.root}/moment-2.6.0.js")
Resource moment,
@Path("${" +
SymbolConstants.BOOTSTRAP_ROOT + "}/js/transition.js")
[1/5] Git Push Summary
Repository: tapestry-5 Updated Branches: refs/heads/master 138414faf -> 36375f07c
[5/5] git commit: TAP5-2233: fix t:rowvalue XHR parameter if the RemoveRowLink contains nested elements
TAP5-2233: fix t:rowvalue XHR parameter if the RemoveRowLink contains nested
elements
Project: http://git-wip-us.apache.org/repos/asf/tapestry-5/repo
Commit: http://git-wip-us.apache.org/repos/asf/tapestry-5/commit/3e600c77
Tree: http://git-wip-us.apache.org/repos/asf/tapestry-5/tree/3e600c77
Diff: http://git-wip-us.apache.org/repos/asf/tapestry-5/diff/3e600c77
Branch: refs/heads/master
Commit: 3e600c774baed0dabb7a19f93b9dba8946a9be45
Parents: 138414f
Author: Jochen Kemnade
Authored: Sat Apr 26 17:40:06 2014 +0200
Committer: Jochen Kemnade
Committed: Sat Apr 26 17:41:20 2014 +0200
--
.../modules/t5/core/ajaxformloop.coffee | 2 +-
.../src/test/app1/FormInjectorDemo.tml | 2 +-
.../tapestry5/integration/app1/AjaxTests.java | 26
3 files changed, 28 insertions(+), 2 deletions(-)
--
http://git-wip-us.apache.org/repos/asf/tapestry-5/blob/3e600c77/tapestry-core/src/main/coffeescript/META-INF/modules/t5/core/ajaxformloop.coffee
--
diff --git
a/tapestry-core/src/main/coffeescript/META-INF/modules/t5/core/ajaxformloop.coffee
b/tapestry-core/src/main/coffeescript/META-INF/modules/t5/core/ajaxformloop.coffee
index 649dd6d..b60cf6c 100644
---
a/tapestry-core/src/main/coffeescript/META-INF/modules/t5/core/ajaxformloop.coffee
+++
b/tapestry-core/src/main/coffeescript/META-INF/modules/t5/core/ajaxformloop.coffee
@@ -35,7 +35,7 @@ define ["./dom", "./events", "./console", "./ajax"],
ajax url,
data:
- "t:rowvalue": @attr "data-afl-row-value"
+ "t:rowvalue": (@closest "[data-afl-row-value]").attr
"data-afl-row-value"
success: =>
# The server has removed the row from persistent storage, lets
# do the same on the UI.
http://git-wip-us.apache.org/repos/asf/tapestry-5/blob/3e600c77/tapestry-core/src/test/app1/FormInjectorDemo.tml
--
diff --git a/tapestry-core/src/test/app1/FormInjectorDemo.tml
b/tapestry-core/src/test/app1/FormInjectorDemo.tml
index 1a23729..68e2508 100644
--- a/tapestry-core/src/test/app1/FormInjectorDemo.tml
+++ b/tapestry-core/src/test/app1/FormInjectorDemo.tml
@@ -12,7 +12,7 @@
-remove
+ remove
http://git-wip-us.apache.org/repos/asf/tapestry-5/blob/3e600c77/tapestry-core/src/test/java/org/apache/tapestry5/integration/app1/AjaxTests.java
--
diff --git
a/tapestry-core/src/test/java/org/apache/tapestry5/integration/app1/AjaxTests.java
b/tapestry-core/src/test/java/org/apache/tapestry5/integration/app1/AjaxTests.java
index 17cb399..528054f 100644
---
a/tapestry-core/src/test/java/org/apache/tapestry5/integration/app1/AjaxTests.java
+++
b/tapestry-core/src/test/java/org/apache/tapestry5/integration/app1/AjaxTests.java
@@ -201,6 +201,32 @@ public class AjaxTests extends App1TestCase
assertText("sum", "0.0");
}
+
+@Test
+public void remove_ajaxformloop_values_using_buttons_with_nested_elements()
+{
+openLinks("FormInjector Demo");
+
+assertText("sum", "0.0");
+
+click("link=Add another value");
+
+sleep(AJAX_WAIT_TIME);
+
+type("//input[@type='text'][1]", "5.1");
+
+clickAndWait(SUBMIT);
+
+assertText("sum", "5.1");
+
+click("css=.glyphicon-trash");
+
+sleep(AJAX_WAIT_TIME);
+
+clickAndWait(SUBMIT);
+
+assertText("sum", "0.0");
+}
/**
* TAP5-240
[jira] [Commented] (TAP5-2233) AjaxFormLoop: rowvalue missing when removeRowLink is not plain text
[ https://issues.apache.org/jira/browse/TAP5-2233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13982258#comment-13982258 ] ASF subversion and git services commented on TAP5-2233: --- Commit 3e600c774baed0dabb7a19f93b9dba8946a9be45 in tapestry-5's branch refs/heads/master from [~jkemnade] [ https://git-wip-us.apache.org/repos/asf?p=tapestry-5.git;h=3e600c7 ] TAP5-2233: fix t:rowvalue XHR parameter if the RemoveRowLink contains nested elements > AjaxFormLoop: rowvalue missing when removeRowLink is not plain text > --- > > Key: TAP5-2233 > URL: https://issues.apache.org/jira/browse/TAP5-2233 > Project: Tapestry 5 > Issue Type: Bug > Components: tapestry-core >Affects Versions: 5.4 >Reporter: Felix Gonschorek >Assignee: Jochen Kemnade >Priority: Minor > > Component: RemoveRowLink > Version: 5.4 alpha 25 > Browser: Chrome Win 8 > > > > ajaxformloop.js searches for the "data-afl-row-value" attribute on the > element that has been clicked. the data attribute is rendered on the link. > the element that emits the click event is the image. > result: "rowvalue" is missing => exception. > Intermediate solution: use text only as body for RemoveRowLink component. the > event will be emitted from the element and the data attributes will be > present. > Regression: this bug was introduced in tapestry < 5.4, in 5.3.x it worked for > us. -- This message was sent by Atlassian JIRA (v6.2#6252)
