[jira] [Commented] (TAP5-2358) OrderedConfiguration should have consistent ordering
[ https://issues.apache.org/jira/browse/TAP5-2358?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14047275#comment-14047275 ] Thiago H. de Paula Figueiredo commented on TAP5-2358: - https://git-wip-us.apache.org/repos/asf?p=tapestry-5.git;a=commit;h=a2fac6be8bed9c9406c601409ea4c063a91a832a OrderedConfiguration should have consistent ordering Key: TAP5-2358 URL: https://issues.apache.org/jira/browse/TAP5-2358 Project: Tapestry 5 Issue Type: Improvement Components: tapestry-ioc Affects Versions: 5.3, 5.4 Reporter: Thiago H. de Paula Figueiredo Assignee: Thiago H. de Paula Figueiredo Labels: month-of-tapestry Depending on the order in which module classes with contributions to the same service with OrderedConfiguration were added to the Registry, which isn't defined, the resulting list passed to the service can have different ordering. Given the same contributions, the resulting list should always be the same. -- This message was sent by Atlassian JIRA (v6.2#6252)
git commit: Fixes an exception caused by the implementation of TAP5-2358.
Repository: tapestry-5
Updated Branches:
refs/heads/master a2fac6be8 - aab59abec
Fixes an exception caused by the implementation of TAP5-2358.
Project: http://git-wip-us.apache.org/repos/asf/tapestry-5/repo
Commit: http://git-wip-us.apache.org/repos/asf/tapestry-5/commit/aab59abe
Tree: http://git-wip-us.apache.org/repos/asf/tapestry-5/tree/aab59abe
Diff: http://git-wip-us.apache.org/repos/asf/tapestry-5/diff/aab59abe
Branch: refs/heads/master
Commit: aab59abec15d6c51321d028cb285da60ad97c2ae
Parents: a2fac6b
Author: Thiago H. de Paula Figueiredo thiag...@apache.org
Authored: Sun Jun 29 19:24:19 2014 -0300
Committer: Thiago H. de Paula Figueiredo thiag...@apache.org
Committed: Sun Jun 29 19:24:19 2014 -0300
--
.../java/org/apache/tapestry5/ioc/internal/RegistryImpl.java| 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
--
http://git-wip-us.apache.org/repos/asf/tapestry-5/blob/aab59abe/tapestry-ioc/src/main/java/org/apache/tapestry5/ioc/internal/RegistryImpl.java
--
diff --git
a/tapestry-ioc/src/main/java/org/apache/tapestry5/ioc/internal/RegistryImpl.java
b/tapestry-ioc/src/main/java/org/apache/tapestry5/ioc/internal/RegistryImpl.java
index 3ef57c6..3709fa8 100644
---
a/tapestry-ioc/src/main/java/org/apache/tapestry5/ioc/internal/RegistryImpl.java
+++
b/tapestry-ioc/src/main/java/org/apache/tapestry5/ioc/internal/RegistryImpl.java
@@ -1216,12 +1216,11 @@ public class RegistryImpl implements Registry,
InternalRegistry, ServiceProxyPro
}
final private static class ModuleComparator implements ComparatorModule {
-
@Override
public int compare(Module m1, Module m2)
{
-return
m1.getModuleBuilder().getClass().getName().compareTo(m2.getModuleBuilder().getClass().getName());
+return m1.getLoggerName().compareTo(m2.getLoggerName());
}
-
}
+
}
[jira] [Updated] (TAP5-2358) OrderedConfiguration should have consistent ordering
[ https://issues.apache.org/jira/browse/TAP5-2358?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Thiago H. de Paula Figueiredo updated TAP5-2358: Fix Version/s: 5.4 This changes the way ordered constraints are handled: modules are processed in alphabetical order of their simple class names. OrderedConfiguration should have consistent ordering Key: TAP5-2358 URL: https://issues.apache.org/jira/browse/TAP5-2358 Project: Tapestry 5 Issue Type: Improvement Components: tapestry-ioc Affects Versions: 5.3, 5.4 Reporter: Thiago H. de Paula Figueiredo Assignee: Thiago H. de Paula Figueiredo Labels: month-of-tapestry Fix For: 5.4 Depending on the order in which module classes with contributions to the same service with OrderedConfiguration were added to the Registry, which isn't defined, the resulting list passed to the service can have different ordering. Given the same contributions, the resulting list should always be the same. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (TAP5-2358) OrderedConfiguration should have consistent ordering
[ https://issues.apache.org/jira/browse/TAP5-2358?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14047277#comment-14047277 ] ASF subversion and git services commented on TAP5-2358: --- Commit aab59abec15d6c51321d028cb285da60ad97c2ae in tapestry-5's branch refs/heads/master from [~thiagohp] [ https://git-wip-us.apache.org/repos/asf?p=tapestry-5.git;h=aab59ab ] Fixes an exception caused by the implementation of TAP5-2358. OrderedConfiguration should have consistent ordering Key: TAP5-2358 URL: https://issues.apache.org/jira/browse/TAP5-2358 Project: Tapestry 5 Issue Type: Improvement Components: tapestry-ioc Affects Versions: 5.3, 5.4 Reporter: Thiago H. de Paula Figueiredo Assignee: Thiago H. de Paula Figueiredo Labels: month-of-tapestry Fix For: 5.4 Depending on the order in which module classes with contributions to the same service with OrderedConfiguration were added to the Registry, which isn't defined, the resulting list passed to the service can have different ordering. Given the same contributions, the resulting list should always be the same. -- This message was sent by Atlassian JIRA (v6.2#6252)
git commit: TAP5-2358 : removing some debbuging code.
Repository: tapestry-5
Updated Branches:
refs/heads/master aab59abec - d2ccbe2df
TAP5-2358 : removing some debbuging code.
Project: http://git-wip-us.apache.org/repos/asf/tapestry-5/repo
Commit: http://git-wip-us.apache.org/repos/asf/tapestry-5/commit/d2ccbe2d
Tree: http://git-wip-us.apache.org/repos/asf/tapestry-5/tree/d2ccbe2d
Diff: http://git-wip-us.apache.org/repos/asf/tapestry-5/diff/d2ccbe2d
Branch: refs/heads/master
Commit: d2ccbe2dfe863ac3d136aa522758de46ff2815e6
Parents: aab59ab
Author: Thiago H. de Paula Figueiredo thiag...@apache.org
Authored: Sun Jun 29 19:33:37 2014 -0300
Committer: Thiago H. de Paula Figueiredo thiag...@apache.org
Committed: Sun Jun 29 19:33:37 2014 -0300
--
.../tapestry5/ioc/internal/services/ClassPropertyAdapterImpl.java | 2 --
1 file changed, 2 deletions(-)
--
http://git-wip-us.apache.org/repos/asf/tapestry-5/blob/d2ccbe2d/tapestry-ioc/src/main/java/org/apache/tapestry5/ioc/internal/services/ClassPropertyAdapterImpl.java
--
diff --git
a/tapestry-ioc/src/main/java/org/apache/tapestry5/ioc/internal/services/ClassPropertyAdapterImpl.java
b/tapestry-ioc/src/main/java/org/apache/tapestry5/ioc/internal/services/ClassPropertyAdapterImpl.java
index c916cd9..af4bd7d 100644
---
a/tapestry-ioc/src/main/java/org/apache/tapestry5/ioc/internal/services/ClassPropertyAdapterImpl.java
+++
b/tapestry-ioc/src/main/java/org/apache/tapestry5/ioc/internal/services/ClassPropertyAdapterImpl.java
@@ -106,12 +106,10 @@ public class ClassPropertyAdapterImpl implements
ClassPropertyAdapter
}
catch (SecurityException e) {
// setter not usable.
-e.printStackTrace();
}
catch (NoSuchMethodException e)
{
// setter doesn't exist.
-e.printStackTrace();
}
}
[jira] [Commented] (TAP5-2358) OrderedConfiguration should have consistent ordering
[ https://issues.apache.org/jira/browse/TAP5-2358?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14047279#comment-14047279 ] ASF subversion and git services commented on TAP5-2358: --- Commit d2ccbe2dfe863ac3d136aa522758de46ff2815e6 in tapestry-5's branch refs/heads/master from [~thiagohp] [ https://git-wip-us.apache.org/repos/asf?p=tapestry-5.git;h=d2ccbe2 ] TAP5-2358 : removing some debbuging code. OrderedConfiguration should have consistent ordering Key: TAP5-2358 URL: https://issues.apache.org/jira/browse/TAP5-2358 Project: Tapestry 5 Issue Type: Improvement Components: tapestry-ioc Affects Versions: 5.3, 5.4 Reporter: Thiago H. de Paula Figueiredo Assignee: Thiago H. de Paula Figueiredo Labels: month-of-tapestry Fix For: 5.4 Depending on the order in which module classes with contributions to the same service with OrderedConfiguration were added to the Registry, which isn't defined, the resulting list passed to the service can have different ordering. Given the same contributions, the resulting list should always be the same. -- This message was sent by Atlassian JIRA (v6.2#6252)
