[jira] [Created] (TAP5-2409) type=number fails when decimal separator isn't .
Geoff Callender created TAP5-2409: - Summary: type=number fails when decimal separator isn't . Key: TAP5-2409 URL: https://issues.apache.org/jira/browse/TAP5-2409 Project: Tapestry 5 Issue Type: Bug Components: tapestry-core Affects Versions: 5.4 Reporter: Geoff Callender This probably affects versions before 5.4 too. I have BigDecimal fields that I'm editing with TextField. On mobile devices I would like a numeric keyboard to pop up, so I added type=number. This all worked just fine in English, but then I switched locale to French and found Tapestry's client-side validation rejecting it as not a number. Digging around, I found that with type=number, the W3C spec requires the browser to translate the field value to a String with a . decimal separator. The problem for Tapestry is that Tapestry's validation always expects the field value to be untouched and in the format of the locale. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
git commit: Add an easier way to perform a partial page render outside of the standard AjaxComponentEventRequestHandler
Repository: tapestry-5
Updated Branches:
refs/heads/master 6f4c5640c - b7f60e28e
Add an easier way to perform a partial page render outside of the standard
AjaxComponentEventRequestHandler
Project: http://git-wip-us.apache.org/repos/asf/tapestry-5/repo
Commit: http://git-wip-us.apache.org/repos/asf/tapestry-5/commit/b7f60e28
Tree: http://git-wip-us.apache.org/repos/asf/tapestry-5/tree/b7f60e28
Diff: http://git-wip-us.apache.org/repos/asf/tapestry-5/diff/b7f60e28
Branch: refs/heads/master
Commit: b7f60e28e959b0250aac056f7e559515e75901d9
Parents: 6f4c564
Author: Howard M. Lewis Ship hls...@apache.org
Authored: Wed Oct 29 16:02:14 2014 -0700
Committer: Howard M. Lewis Ship hls...@apache.org
Committed: Wed Oct 29 16:02:14 2014 -0700
--
.../AjaxPartialResponseRendererImpl.java| 5 +++
.../internal/services/PageRenderQueueImpl.java | 13 ++--
.../services/ajax/AjaxResponseRendererImpl.java | 30 ++
.../services/ajax/AjaxResponseRenderer.java | 32 ++--
4 files changed, 63 insertions(+), 17 deletions(-)
--
http://git-wip-us.apache.org/repos/asf/tapestry-5/blob/b7f60e28/tapestry-core/src/main/java/org/apache/tapestry5/internal/services/AjaxPartialResponseRendererImpl.java
--
diff --git
a/tapestry-core/src/main/java/org/apache/tapestry5/internal/services/AjaxPartialResponseRendererImpl.java
b/tapestry-core/src/main/java/org/apache/tapestry5/internal/services/AjaxPartialResponseRendererImpl.java
index 22ffce9..4b95f37 100644
---
a/tapestry-core/src/main/java/org/apache/tapestry5/internal/services/AjaxPartialResponseRendererImpl.java
+++
b/tapestry-core/src/main/java/org/apache/tapestry5/internal/services/AjaxPartialResponseRendererImpl.java
@@ -81,6 +81,11 @@ public class AjaxPartialResponseRendererImpl implements
AjaxPartialResponseRende
String pageName = (String)
request.getAttribute(InternalConstants.PAGE_NAME_ATTRIBUTE_NAME);
+if (pageName == null)
+{
+throw new IllegalStateException(The active page name has
not been specified.);
+}
+
MarkupWriter writer = factory.newPartialMarkupWriter(pageName);
// ... and here, the pipeline eventually reaches the PRQ to
let it render the root render command.
http://git-wip-us.apache.org/repos/asf/tapestry-5/blob/b7f60e28/tapestry-core/src/main/java/org/apache/tapestry5/internal/services/PageRenderQueueImpl.java
--
diff --git
a/tapestry-core/src/main/java/org/apache/tapestry5/internal/services/PageRenderQueueImpl.java
b/tapestry-core/src/main/java/org/apache/tapestry5/internal/services/PageRenderQueueImpl.java
index 34a997d..a61e15c 100644
---
a/tapestry-core/src/main/java/org/apache/tapestry5/internal/services/PageRenderQueueImpl.java
+++
b/tapestry-core/src/main/java/org/apache/tapestry5/internal/services/PageRenderQueueImpl.java
@@ -1,5 +1,3 @@
-// Copyright 2007, 2008, 2010, 2011 The Apache Software Foundation
-//
// Licensed under the Apache License, Version 2.0 (the License);
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
@@ -97,11 +95,20 @@ public class PageRenderQueueImpl implements PageRenderQueue
{
assert renderer != null;
+checkQueue();
+
partialRenderInitialized = true;
queue.push(renderer);
}
+private void checkQueue()
+{
+if (queue == null) {
+throw new IllegalStateException(The page used as the basis for
partial rendering has not been set.);
+}
+}
+
public Page getRenderingPage()
{
return page;
@@ -125,6 +132,8 @@ public class PageRenderQueueImpl implements PageRenderQueue
public void renderPartial(MarkupWriter writer, JSONObject reply)
{
+checkQueue();
+
PartialMarkupRenderer terminator = new PartialMarkupRenderer()
{
public void renderMarkup(MarkupWriter writer, JSONObject reply)
http://git-wip-us.apache.org/repos/asf/tapestry-5/blob/b7f60e28/tapestry-core/src/main/java/org/apache/tapestry5/internal/services/ajax/AjaxResponseRendererImpl.java
--
diff --git
a/tapestry-core/src/main/java/org/apache/tapestry5/internal/services/ajax/AjaxResponseRendererImpl.java
b/tapestry-core/src/main/java/org/apache/tapestry5/internal/services/ajax/AjaxResponseRendererImpl.java
index b263f7c..6fa41cb 100644
---
a/tapestry-core/src/main/java/org/apache/tapestry5/internal/services/ajax/AjaxResponseRendererImpl.java
+++
svn commit: r6947 - /release/tapestry/
Author: coreyg Date: Thu Oct 30 00:48:47 2014 New Revision: 6947 Log: Initial addition for dist entries for tapestry for svnpubsub Added: release/tapestry/KEYS release/tapestry/Tapestry-3.0.4-bin.tar.gz (with props) release/tapestry/Tapestry-3.0.4-bin.tar.gz.asc (with props) release/tapestry/Tapestry-3.0.4-bin.tar.gz.md5 release/tapestry/Tapestry-3.0.4-bin.zip (with props) release/tapestry/Tapestry-3.0.4-bin.zip.asc (with props) release/tapestry/Tapestry-3.0.4-bin.zip.md5 release/tapestry/Tapestry-3.0.4-src.tar.gz (with props) release/tapestry/Tapestry-3.0.4-src.tar.gz.asc (with props) release/tapestry/Tapestry-3.0.4-src.tar.gz.md5 release/tapestry/Tapestry-3.0.4-src.zip (with props) release/tapestry/Tapestry-3.0.4-src.zip.asc (with props) release/tapestry/Tapestry-3.0.4-src.zip.md5 release/tapestry/Tapestry-Web-3.0.4.tar.gz (with props) release/tapestry/Tapestry-Web-3.0.4.tar.gz.asc (with props) release/tapestry/Tapestry-Web-3.0.4.tar.gz.md5 release/tapestry/apache-tapestry-5.3.7-bin.zip (with props) release/tapestry/apache-tapestry-5.3.7-bin.zip.asc (with props) release/tapestry/apache-tapestry-5.3.7-bin.zip.md5 release/tapestry/apache-tapestry-5.3.7-javadocs.zip (with props) release/tapestry/apache-tapestry-5.3.7-javadocs.zip.asc (with props) release/tapestry/apache-tapestry-5.3.7-javadocs.zip.md5 release/tapestry/apache-tapestry-5.3.7-sources.zip (with props) release/tapestry/apache-tapestry-5.3.7-sources.zip.asc (with props) release/tapestry/apache-tapestry-5.3.7-sources.zip.md5 release/tapestry/apache-tapestry-5.4-beta-22-apidocs.zip (with props) release/tapestry/apache-tapestry-5.4-beta-22-apidocs.zip.asc (with props) release/tapestry/apache-tapestry-5.4-beta-22-apidocs.zip.md5 release/tapestry/apache-tapestry-5.4-beta-22-bin.zip (with props) release/tapestry/apache-tapestry-5.4-beta-22-bin.zip.asc (with props) release/tapestry/apache-tapestry-5.4-beta-22-bin.zip.md5 release/tapestry/apache-tapestry-5.4-beta-22-sources.zip (with props) release/tapestry/apache-tapestry-5.4-beta-22-sources.zip.asc (with props) release/tapestry/apache-tapestry-5.4-beta-22-sources.zip.md5 release/tapestry/apache-tapestry-5.4-beta-3-apidocs.zip (with props) release/tapestry/apache-tapestry-5.4-beta-3-apidocs.zip.asc (with props) release/tapestry/apache-tapestry-5.4-beta-3-apidocs.zip.md5 release/tapestry/apache-tapestry-5.4-beta-3-bin.zip (with props) release/tapestry/apache-tapestry-5.4-beta-3-bin.zip.asc (with props) release/tapestry/apache-tapestry-5.4-beta-3-bin.zip.md5 release/tapestry/apache-tapestry-5.4-beta-3-sources.zip (with props) release/tapestry/apache-tapestry-5.4-beta-3-sources.zip.asc (with props) release/tapestry/apache-tapestry-5.4-beta-3-sources.zip.md5 release/tapestry/apache-tapestry-5.4-beta-6-apidocs.zip (with props) release/tapestry/apache-tapestry-5.4-beta-6-apidocs.zip.asc (with props) release/tapestry/apache-tapestry-5.4-beta-6-apidocs.zip.md5 release/tapestry/apache-tapestry-5.4-beta-6-bin.zip (with props) release/tapestry/apache-tapestry-5.4-beta-6-bin.zip.asc (with props) release/tapestry/apache-tapestry-5.4-beta-6-bin.zip.md5 release/tapestry/apache-tapestry-5.4-beta-6-sources.zip (with props) release/tapestry/apache-tapestry-5.4-beta-6-sources.zip.asc (with props) release/tapestry/apache-tapestry-5.4-beta-6-sources.zip.md5 release/tapestry/tapestry-4.0.2-docs.tar.gz (with props) release/tapestry/tapestry-4.0.2-docs.tar.gz.asc (with props) release/tapestry/tapestry-4.0.2-docs.tar.gz.md5 release/tapestry/tapestry-4.0.2.tar.gz (with props) release/tapestry/tapestry-4.0.2.tar.gz.asc (with props) release/tapestry/tapestry-4.0.2.tar.gz.md5 release/tapestry/tapestry-4.0.2.zip (with props) release/tapestry/tapestry-4.0.2.zip.asc (with props) release/tapestry/tapestry-4.0.2.zip.md5 release/tapestry/tapestry-bin-5.0.19.tar.bz2 (with props) release/tapestry/tapestry-bin-5.0.19.tar.bz2.asc (with props) release/tapestry/tapestry-bin-5.0.19.tar.bz2.md5 release/tapestry/tapestry-bin-5.0.19.tar.gz (with props) release/tapestry/tapestry-bin-5.0.19.tar.gz.asc (with props) release/tapestry/tapestry-bin-5.0.19.tar.gz.md5 release/tapestry/tapestry-bin-5.0.19.zip (with props) release/tapestry/tapestry-bin-5.0.19.zip.asc (with props) release/tapestry/tapestry-bin-5.0.19.zip.md5 release/tapestry/tapestry-bin-5.1.0.5.tar.bz2 (with props) release/tapestry/tapestry-bin-5.1.0.5.tar.bz2.asc (with props) release/tapestry/tapestry-bin-5.1.0.5.tar.bz2.md5 release/tapestry/tapestry-bin-5.1.0.5.tar.gz (with props) release/tapestry/tapestry-bin-5.1.0.5.tar.gz.asc (with props) release/tapestry/tapestry-bin-5.1.0.5.tar.gz.md5
