[jira] [Commented] (TAP5-2453) Generic List not fully supported
[ https://issues.apache.org/jira/browse/TAP5-2453?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16244098#comment-16244098 ] Hudson commented on TAP5-2453: -- ABORTED: Integrated in Jenkins build tapestry-trunk-freestyle #1682 (See [https://builds.apache.org/job/tapestry-trunk-freestyle/1682/]) TAP5-2453: restore test classes (jochen.kemnade: rev 8530a27636f4fdc69ca7bb4877f6e31b87fe5292) * (add) tapestry-ioc/src/test/java/org/apache/tapestry5/ioc/internal/util/Pair.java * (add) tapestry-ioc/src/test/java/org/apache/tapestry5/ioc/internal/util/StringLongPair.java > Generic List not fully supported > --- > > Key: TAP5-2453 > URL: https://issues.apache.org/jira/browse/TAP5-2453 > Project: Tapestry 5 > Issue Type: Bug > Components: tapestry-ioc >Affects Versions: 5.4, 5.3.8 >Reporter: Jan Mynařík > Labels: desired_for_5.5, generics > Attachments: TapestryGenericsTest.java > > > I've created an abstract generic CRUD implementation. When binding > implementations resulting proxies doesn't fully report parametrized type via > reflections. > See attached test. In 5.3.8 it fails in all asserts, in 5.4 only in the last > one. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (TAP5-2453) Generic List not fully supported
[ https://issues.apache.org/jira/browse/TAP5-2453?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16243974#comment-16243974 ] ASF subversion and git services commented on TAP5-2453: --- Commit 8530a27636f4fdc69ca7bb4877f6e31b87fe5292 in tapestry-5's branch refs/heads/master from [~jkemnade] [ https://git-wip-us.apache.org/repos/asf?p=tapestry-5.git;h=8530a27 ] TAP5-2453: restore test classes > Generic List not fully supported > --- > > Key: TAP5-2453 > URL: https://issues.apache.org/jira/browse/TAP5-2453 > Project: Tapestry 5 > Issue Type: Bug > Components: tapestry-ioc >Affects Versions: 5.4, 5.3.8 >Reporter: Jan Mynařík > Labels: desired_for_5.5, generics > Attachments: TapestryGenericsTest.java > > > I've created an abstract generic CRUD implementation. When binding > implementations resulting proxies doesn't fully report parametrized type via > reflections. > See attached test. In 5.3.8 it fails in all asserts, in 5.4 only in the last > one. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
tapestry-5 git commit: TAP5-2453: restore test classes
Repository: tapestry-5
Updated Branches:
refs/heads/master 5c617af6b -> 8530a2763
TAP5-2453: restore test classes
Project: http://git-wip-us.apache.org/repos/asf/tapestry-5/repo
Commit: http://git-wip-us.apache.org/repos/asf/tapestry-5/commit/8530a276
Tree: http://git-wip-us.apache.org/repos/asf/tapestry-5/tree/8530a276
Diff: http://git-wip-us.apache.org/repos/asf/tapestry-5/diff/8530a276
Branch: refs/heads/master
Commit: 8530a27636f4fdc69ca7bb4877f6e31b87fe5292
Parents: 5c617af
Author: Jochen Kemnade
Authored: Wed Nov 8 14:56:07 2017 +0100
Committer: Jochen Kemnade
Committed: Wed Nov 8 14:56:07 2017 +0100
--
.../tapestry5/ioc/internal/util/Pair.java | 42
.../ioc/internal/util/StringLongPair.java | 19 +
2 files changed, 61 insertions(+)
--
http://git-wip-us.apache.org/repos/asf/tapestry-5/blob/8530a276/tapestry-ioc/src/test/java/org/apache/tapestry5/ioc/internal/util/Pair.java
--
diff --git
a/tapestry-ioc/src/test/java/org/apache/tapestry5/ioc/internal/util/Pair.java
b/tapestry-ioc/src/test/java/org/apache/tapestry5/ioc/internal/util/Pair.java
new file mode 100644
index 000..00722f4
--- /dev/null
+++
b/tapestry-ioc/src/test/java/org/apache/tapestry5/ioc/internal/util/Pair.java
@@ -0,0 +1,42 @@
+// Copyright 2008 The Apache Software Foundation
+//
+// Licensed under the Apache License, Version 2.0 (the "License");
+// you may not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
+package org.apache.tapestry5.ioc.internal.util;
+
+public class Pair
+{
+private K key;
+
+private V value;
+
+public K getKey()
+{
+return key;
+}
+
+public void setKey(K key)
+{
+this.key = key;
+}
+
+public V getValue()
+{
+return value;
+}
+
+public void setValue(V value)
+{
+this.value = value;
+}
+}
http://git-wip-us.apache.org/repos/asf/tapestry-5/blob/8530a276/tapestry-ioc/src/test/java/org/apache/tapestry5/ioc/internal/util/StringLongPair.java
--
diff --git
a/tapestry-ioc/src/test/java/org/apache/tapestry5/ioc/internal/util/StringLongPair.java
b/tapestry-ioc/src/test/java/org/apache/tapestry5/ioc/internal/util/StringLongPair.java
new file mode 100644
index 000..0071beb
--- /dev/null
+++
b/tapestry-ioc/src/test/java/org/apache/tapestry5/ioc/internal/util/StringLongPair.java
@@ -0,0 +1,19 @@
+// Copyright 2008 The Apache Software Foundation
+//
+// Licensed under the Apache License, Version 2.0 (the "License");
+// you may not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
+package org.apache.tapestry5.ioc.internal.util;
+
+public class StringLongPair extends Pair
+{
+}
[jira] [Commented] (TAP5-2453) Generic List not fully supported
[ https://issues.apache.org/jira/browse/TAP5-2453?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16243968#comment-16243968 ] Hudson commented on TAP5-2453: -- FAILURE: Integrated in Jenkins build tapestry-trunk-freestyle #1681 (See [https://builds.apache.org/job/tapestry-trunk-freestyle/1681/]) TAP5-2453: move GenericsUtils (and tests) to plastic (jochen.kemnade: rev 5c617af6b3bfef81d79c573aec0acf29e1d0eb8c) * (delete) tapestry-ioc/src/test/groovy/ioc/specs/GenericUtilsSpec.groovy * (delete) tapestry-ioc/src/test/java/org/apache/tapestry5/ioc/internal/util/NonGenericBean.java * (add) plastic/src/test/java/org/apache/tapestry5/ioc/internal/util/NonGenericBean.java * (add) plastic/src/test/java/org/apache/tapestry5/ioc/internal/util/StringBean.java * (delete) tapestry-ioc/src/test/java/org/apache/tapestry5/ioc/internal/util/StringLongPair.java * (delete) commons/src/main/java/org/apache/tapestry5/ioc/internal/util/GenericsUtils.java * (add) plastic/src/test/groovy/ioc/specs/GenericUtilsSpec.groovy * (add) plastic/src/test/java/org/apache/tapestry5/ioc/internal/util/Pair.java * (add) plastic/src/test/java/org/apache/tapestry5/ioc/internal/util/BaseGenericBean.java * (delete) tapestry-ioc/src/test/java/org/apache/tapestry5/ioc/internal/util/Pair.java * (add) plastic/src/main/java/org/apache/tapestry5/ioc/internal/util/GenericsUtils.java * (delete) tapestry-ioc/src/test/java/org/apache/tapestry5/ioc/internal/util/StringBean.java * (add) plastic/src/test/java/org/apache/tapestry5/ioc/internal/util/StringLongPair.java * (delete) tapestry-ioc/src/test/java/org/apache/tapestry5/ioc/internal/util/BaseGenericBean.java > Generic List not fully supported > --- > > Key: TAP5-2453 > URL: https://issues.apache.org/jira/browse/TAP5-2453 > Project: Tapestry 5 > Issue Type: Bug > Components: tapestry-ioc >Affects Versions: 5.4, 5.3.8 >Reporter: Jan Mynařík > Labels: desired_for_5.5, generics > Attachments: TapestryGenericsTest.java > > > I've created an abstract generic CRUD implementation. When binding > implementations resulting proxies doesn't fully report parametrized type via > reflections. > See attached test. In 5.3.8 it fails in all asserts, in 5.4 only in the last > one. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
tapestry-5 git commit: TAP5-2453: move GenericsUtils (and tests) to plastic
Repository: tapestry-5
Updated Branches:
refs/heads/master 91272172c -> 5c617af6b
TAP5-2453: move GenericsUtils (and tests) to plastic
Project: http://git-wip-us.apache.org/repos/asf/tapestry-5/repo
Commit: http://git-wip-us.apache.org/repos/asf/tapestry-5/commit/5c617af6
Tree: http://git-wip-us.apache.org/repos/asf/tapestry-5/tree/5c617af6
Diff: http://git-wip-us.apache.org/repos/asf/tapestry-5/diff/5c617af6
Branch: refs/heads/master
Commit: 5c617af6b3bfef81d79c573aec0acf29e1d0eb8c
Parents: 9127217
Author: Jochen Kemnade
Authored: Wed Nov 8 14:24:48 2017 +0100
Committer: Jochen Kemnade
Committed: Wed Nov 8 14:24:48 2017 +0100
--
.../ioc/internal/util/GenericsUtils.java| 613 ---
.../ioc/internal/util/GenericsUtils.java| 613 +++
.../groovy/ioc/specs/GenericUtilsSpec.groovy| 40 ++
.../ioc/internal/util/BaseGenericBean.java | 30 +
.../ioc/internal/util/NonGenericBean.java | 30 +
.../tapestry5/ioc/internal/util/Pair.java | 42 ++
.../tapestry5/ioc/internal/util/StringBean.java | 20 +
.../ioc/internal/util/StringLongPair.java | 19 +
.../groovy/ioc/specs/GenericUtilsSpec.groovy| 40 --
.../ioc/internal/util/BaseGenericBean.java | 30 -
.../ioc/internal/util/NonGenericBean.java | 30 -
.../tapestry5/ioc/internal/util/Pair.java | 42 --
.../tapestry5/ioc/internal/util/StringBean.java | 20 -
.../ioc/internal/util/StringLongPair.java | 19 -
14 files changed, 794 insertions(+), 794 deletions(-)
--
http://git-wip-us.apache.org/repos/asf/tapestry-5/blob/5c617af6/commons/src/main/java/org/apache/tapestry5/ioc/internal/util/GenericsUtils.java
--
diff --git
a/commons/src/main/java/org/apache/tapestry5/ioc/internal/util/GenericsUtils.java
b/commons/src/main/java/org/apache/tapestry5/ioc/internal/util/GenericsUtils.java
deleted file mode 100644
index 9bf4d00..000
---
a/commons/src/main/java/org/apache/tapestry5/ioc/internal/util/GenericsUtils.java
+++ /dev/null
@@ -1,613 +0,0 @@
-// Licensed under the Apache License, Version 2.0 (the "License");
-// you may not use this file except in compliance with the License.
-// You may obtain a copy of the License at
-//
-// http://www.apache.org/licenses/LICENSE-2.0
-//
-// Unless required by applicable law or agreed to in writing, software
-// distributed under the License is distributed on an "AS IS" BASIS,
-// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
-// See the License for the specific language governing permissions and
-// limitations under the License.
-
-package org.apache.tapestry5.ioc.internal.util;
-
-import java.lang.reflect.*;
-import java.util.LinkedList;
-
-/**
- * Static methods related to the use of JDK 1.5 generics.
- */
-@SuppressWarnings("unchecked")
-public class GenericsUtils
-{
-/**
- * Analyzes the method in the context of containingClass and returns the
Class that is represented by
- * the method's generic return type. Any parameter information in the
generic return type is lost. If you want
- * to preserve the type parameters of the return type consider using
- * {@link #extractActualType(java.lang.reflect.Type,
java.lang.reflect.Method)}.
- *
- * @param containingClass class which either contains or inherited the
method
- * @param method method from which to extract the return type
- * @return the class represented by the methods generic return type,
resolved based on the context .
- * @see #extractActualType(java.lang.reflect.Type,
java.lang.reflect.Method)
- * @see #resolve(java.lang.reflect.Type,java.lang.reflect.Type)
- * @see #asClass(java.lang.reflect.Type)
- */
-public static Class extractGenericReturnType(Class containingClass,
Method method)
-{
-return asClass(resolve(method.getGenericReturnType(),
containingClass));
-}
-
-
-/**
- * Analyzes the field in the context of containingClass and returns the
Class that is represented by
- * the field's generic type. Any parameter information in the generic type
is lost, if you want
- * to preserve the type parameters of the return type consider using
- * {@link #getTypeVariableIndex(java.lang.reflect.TypeVariable)}.
- *
- * @param containingClass class which either contains or inherited the
field
- * @param field field from which to extract the type
- * @return the class represented by the field's generic type, resolved
based on the containingClass.
- * @see #extractActualType(java.lang.reflect.Type, java.lang.reflect.Field)
- * @see #resolve(java.lang.reflect.Type,java.lang.reflect.Type)
- * @see #asClass(java.lang.reflect.Type)
- */
-public static Class extractGenericFieldType
[jira] [Commented] (TAP5-2453) Generic List not fully supported
[ https://issues.apache.org/jira/browse/TAP5-2453?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16243919#comment-16243919 ] ASF subversion and git services commented on TAP5-2453: --- Commit 5c617af6b3bfef81d79c573aec0acf29e1d0eb8c in tapestry-5's branch refs/heads/master from [~jkemnade] [ https://git-wip-us.apache.org/repos/asf?p=tapestry-5.git;h=5c617af ] TAP5-2453: move GenericsUtils (and tests) to plastic > Generic List not fully supported > --- > > Key: TAP5-2453 > URL: https://issues.apache.org/jira/browse/TAP5-2453 > Project: Tapestry 5 > Issue Type: Bug > Components: tapestry-ioc >Affects Versions: 5.4, 5.3.8 >Reporter: Jan Mynařík > Labels: desired_for_5.5, generics > Attachments: TapestryGenericsTest.java > > > I've created an abstract generic CRUD implementation. When binding > implementations resulting proxies doesn't fully report parametrized type via > reflections. > See attached test. In 5.3.8 it fails in all asserts, in 5.4 only in the last > one. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
