[jira] [Comment Edited] (TAP5-2564) Unwanted auto-boxing while annotation visiting
[
https://issues.apache.org/jira/browse/TAP5-2564?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15525557#comment-15525557
]
Eugene Vologzhanin edited comment on TAP5-2564 at 9/27/16 9:11 AM:
---
Bug affect Tapestry 5.3.8, but not Tapestry 5.4.
Other words, Tapestry 5.3.8 have bug, and i write above a fix.
Tapestry 5.4 have no AnnotationVisitor, consequently have noy bug.
was (Author: jackv...@gmail.com):
Bug affect Tapestry 5.3.8, but not Tapestry 5.4
> Unwanted auto-boxing while annotation visiting
> ---
>
> Key: TAP5-2564
> URL: https://issues.apache.org/jira/browse/TAP5-2564
> Project: Tapestry 5
> Issue Type: Bug
> Components: tapestry-ioc
>Affects Versions: 5.3.8
>Reporter: Eugene Vologzhanin
> Fix For: 5.4
>
>
> class org.apache.tapestry5.ioc.internal.services.AnnotationMemberValueVisitor
> Line #64: final Object result = method.invoke(value);
> If method return boolean, result wil be *java.lang.Boolean* not *boolean*.
> In this case in rutime will be Caused by: java.lang.ClassCastException:
> java.lang.Boolean cannot be cast to java.lang.Enum.
> I fix with:
> {code}
> MemberValue memberValue;
> if (method.getReturnType().isPrimitive()) {
> memberValue = Annotation.createMemberValue(this.constPool,
>
> this.classPool.get(method.getReturnType().getName()));
> } else {
> memberValue = Annotation.createMemberValue(this.constPool,
> this.classPool.get(result.getClass().getName()));
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Reopened] (TAP5-2564) Unwanted auto-boxing while annotation visiting
[
https://issues.apache.org/jira/browse/TAP5-2564?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Eugene Vologzhanin reopened TAP5-2564:
--
Bug affect Tapestry 5.3.8, but not Tapestry 5.4
> Unwanted auto-boxing while annotation visiting
> ---
>
> Key: TAP5-2564
> URL: https://issues.apache.org/jira/browse/TAP5-2564
> Project: Tapestry 5
> Issue Type: Bug
> Components: tapestry-ioc
>Affects Versions: 5.3.8
>Reporter: Eugene Vologzhanin
> Fix For: 5.4
>
>
> class org.apache.tapestry5.ioc.internal.services.AnnotationMemberValueVisitor
> Line #64: final Object result = method.invoke(value);
> If method return boolean, result wil be *java.lang.Boolean* not *boolean*.
> In this case in rutime will be Caused by: java.lang.ClassCastException:
> java.lang.Boolean cannot be cast to java.lang.Enum.
> I fix with:
> {code}
> MemberValue memberValue;
> if (method.getReturnType().isPrimitive()) {
> memberValue = Annotation.createMemberValue(this.constPool,
>
> this.classPool.get(method.getReturnType().getName()));
> } else {
> memberValue = Annotation.createMemberValue(this.constPool,
> this.classPool.get(result.getClass().getName()));
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (TAP5-2564) Unwanted auto-boxing while annotation visiting
[
https://issues.apache.org/jira/browse/TAP5-2564?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15525537#comment-15525537
]
Eugene Vologzhanin commented on TAP5-2564:
--
I'm not using tapestry :)
I just copy yours AnnotationMemberValueVisitor in my project, and found bug.
> Unwanted auto-boxing while annotation visiting
> ---
>
> Key: TAP5-2564
> URL: https://issues.apache.org/jira/browse/TAP5-2564
> Project: Tapestry 5
> Issue Type: Bug
> Components: tapestry-ioc
>Affects Versions: 5.3.8
>Reporter: Eugene Vologzhanin
> Fix For: 5.4
>
>
> class org.apache.tapestry5.ioc.internal.services.AnnotationMemberValueVisitor
> Line #64: final Object result = method.invoke(value);
> If method return boolean, result wil be *java.lang.Boolean* not *boolean*.
> In this case in rutime will be Caused by: java.lang.ClassCastException:
> java.lang.Boolean cannot be cast to java.lang.Enum.
> I fix with:
> {code}
> MemberValue memberValue;
> if (method.getReturnType().isPrimitive()) {
> memberValue = Annotation.createMemberValue(this.constPool,
>
> this.classPool.get(method.getReturnType().getName()));
> } else {
> memberValue = Annotation.createMemberValue(this.constPool,
> this.classPool.get(result.getClass().getName()));
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (TAP5-2564) Unwanted auto-boxing while annotation visiting
[
https://issues.apache.org/jira/browse/TAP5-2564?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15525438#comment-15525438
]
Eugene Vologzhanin commented on TAP5-2564:
--
tapestry-ioc-5.4-beta-6 have no this bug :)
> Unwanted auto-boxing while annotation visiting
> ---
>
> Key: TAP5-2564
> URL: https://issues.apache.org/jira/browse/TAP5-2564
> Project: Tapestry 5
> Issue Type: Bug
> Components: tapestry-ioc
>Affects Versions: 5.3.8
>Reporter: Eugene Vologzhanin
>
> class org.apache.tapestry5.ioc.internal.services.AnnotationMemberValueVisitor
> Line #64: final Object result = method.invoke(value);
> If method return boolean, result wil be *java.lang.Boolean* not *boolean*.
> In this case in rutime will be Caused by: java.lang.ClassCastException:
> java.lang.Boolean cannot be cast to java.lang.Enum.
> I fix with:
> {code}
> MemberValue memberValue;
> if (method.getReturnType().isPrimitive()) {
> memberValue = Annotation.createMemberValue(this.constPool,
>
> this.classPool.get(method.getReturnType().getName()));
> } else {
> memberValue = Annotation.createMemberValue(this.constPool,
> this.classPool.get(result.getClass().getName()));
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (TAP5-2564) Unwanted auto-boxing while annotation visiting
[
https://issues.apache.org/jira/browse/TAP5-2564?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Eugene Vologzhanin updated TAP5-2564:
-
Fix Version/s: 5.5.0
> Unwanted auto-boxing while annotation visiting
> ---
>
> Key: TAP5-2564
> URL: https://issues.apache.org/jira/browse/TAP5-2564
> Project: Tapestry 5
> Issue Type: Bug
> Components: tapestry-ioc
>Affects Versions: 5.3.8
>Reporter: Eugene Vologzhanin
> Fix For: 5.5.0
>
>
> class org.apache.tapestry5.ioc.internal.services.AnnotationMemberValueVisitor
> Line #64: final Object result = method.invoke(value);
> If method return boolean, result wil be *java.lang.Boolean* not *boolean*.
> In this case in rutime will be Caused by: java.lang.ClassCastException:
> java.lang.Boolean cannot be cast to java.lang.Enum.
> I fix with:
> {code}
> MemberValue memberValue;
> if (method.getReturnType().isPrimitive()) {
> memberValue = Annotation.createMemberValue(this.constPool,
>
> this.classPool.get(method.getReturnType().getName()));
> } else {
> memberValue = Annotation.createMemberValue(this.constPool,
> this.classPool.get(result.getClass().getName()));
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (TAP5-2564) Unwanted auto-boxing while annotation visiting
[
https://issues.apache.org/jira/browse/TAP5-2564?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Eugene Vologzhanin updated TAP5-2564:
-
Description:
class org.apache.tapestry5.ioc.internal.services.AnnotationMemberValueVisitor
Line #64: final Object result = method.invoke(value);
If method return boolean, result wil be *java.lang.Boolean* not *boolean*.
In this case in rutime will be Caused by: java.lang.ClassCastException:
java.lang.Boolean cannot be cast to java.lang.Enum.
I fix with:
{code}
MemberValue memberValue;
if (method.getReturnType().isPrimitive()) {
memberValue = Annotation.createMemberValue(this.constPool,
this.classPool.get(method.getReturnType().getName()));
} else {
memberValue = Annotation.createMemberValue(this.constPool,
this.classPool.get(result.getClass().getName()));
}
{code}
was:
class org.apache.tapestry5.ioc.internal.services.AnnotationMemberValueVisitor
Line #64: final Object result = method.invoke(value);
If method return boolean, result wil be *strong*java.lang.Boolean*strong* not
*strong*boolean*strong*.
In this case in rutime will be Caused by: java.lang.ClassCastException:
java.lang.Boolean cannot be cast to java.lang.Enum.
I fix with:
{code}
MemberValue memberValue;
if (method.getReturnType().isPrimitive()) {
memberValue = Annotation.createMemberValue(this.constPool,
this.classPool.get(method.getReturnType().getName()));
} else {
memberValue = Annotation.createMemberValue(this.constPool,
this.classPool.get(result.getClass().getName()));
}
{code}
> Unwanted auto-boxing while annotation visiting
> ---
>
> Key: TAP5-2564
> URL: https://issues.apache.org/jira/browse/TAP5-2564
> Project: Tapestry 5
> Issue Type: Bug
> Components: tapestry-ioc
>Affects Versions: 5.3.8
>Reporter: Eugene Vologzhanin
>
> class org.apache.tapestry5.ioc.internal.services.AnnotationMemberValueVisitor
> Line #64: final Object result = method.invoke(value);
> If method return boolean, result wil be *java.lang.Boolean* not *boolean*.
> In this case in rutime will be Caused by: java.lang.ClassCastException:
> java.lang.Boolean cannot be cast to java.lang.Enum.
> I fix with:
> {code}
> MemberValue memberValue;
> if (method.getReturnType().isPrimitive()) {
> memberValue = Annotation.createMemberValue(this.constPool,
>
> this.classPool.get(method.getReturnType().getName()));
> } else {
> memberValue = Annotation.createMemberValue(this.constPool,
> this.classPool.get(result.getClass().getName()));
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (TAP5-2564) Unwanted auto-boxing while annotation visiting
[
https://issues.apache.org/jira/browse/TAP5-2564?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Eugene Vologzhanin updated TAP5-2564:
-
Description:
class org.apache.tapestry5.ioc.internal.services.AnnotationMemberValueVisitor
Line #64: final Object result = method.invoke(value);
If method return boolean, result wil be *strong*java.lang.Boolean*strong* not
*strong*boolean*strong*.
In this case in rutime will be Caused by: java.lang.ClassCastException:
java.lang.Boolean cannot be cast to java.lang.Enum.
I fix with:
{code}
MemberValue memberValue;
if (method.getReturnType().isPrimitive()) {
memberValue = Annotation.createMemberValue(this.constPool,
this.classPool.get(method.getReturnType().getName()));
} else {
memberValue = Annotation.createMemberValue(this.constPool,
this.classPool.get(result.getClass().getName()));
}
{code}
was:
class org.apache.tapestry5.ioc.internal.services.AnnotationMemberValueVisitor
Line #64: final Object result = method.invoke(value);
If method return boolean, result wil be {b}java.lang.Boolean{b} not
{b}boolean{b}.
In this case in rutime will be Caused by: java.lang.ClassCastException:
java.lang.Boolean cannot be cast to java.lang.Enum.
I fix with:
{code}
MemberValue memberValue;
if (method.getReturnType().isPrimitive()) {
memberValue = Annotation.createMemberValue(this.constPool,
this.classPool.get(method.getReturnType().getName()));
} else {
memberValue = Annotation.createMemberValue(this.constPool,
this.classPool.get(result.getClass().getName()));
}
{code}
> Unwanted auto-boxing while annotation visiting
> ---
>
> Key: TAP5-2564
> URL: https://issues.apache.org/jira/browse/TAP5-2564
> Project: Tapestry 5
> Issue Type: Bug
> Components: tapestry-ioc
>Affects Versions: 5.3.8
>Reporter: Eugene Vologzhanin
>
> class org.apache.tapestry5.ioc.internal.services.AnnotationMemberValueVisitor
> Line #64: final Object result = method.invoke(value);
> If method return boolean, result wil be *strong*java.lang.Boolean*strong* not
> *strong*boolean*strong*.
> In this case in rutime will be Caused by: java.lang.ClassCastException:
> java.lang.Boolean cannot be cast to java.lang.Enum.
> I fix with:
> {code}
> MemberValue memberValue;
> if (method.getReturnType().isPrimitive()) {
> memberValue = Annotation.createMemberValue(this.constPool,
>
> this.classPool.get(method.getReturnType().getName()));
> } else {
> memberValue = Annotation.createMemberValue(this.constPool,
> this.classPool.get(result.getClass().getName()));
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (TAP5-2564) Unwanted auto-boxing while annotation visiting
[
https://issues.apache.org/jira/browse/TAP5-2564?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Eugene Vologzhanin updated TAP5-2564:
-
Description:
class org.apache.tapestry5.ioc.internal.services.AnnotationMemberValueVisitor
Line #64: final Object result = method.invoke(value);
If method return boolean, result wil be java.lang.Boolean not
boolean.
In this case in rutime will be Caused by: java.lang.ClassCastException:
java.lang.Boolean cannot be cast to java.lang.Enum.
I fix with:
{code}
MemberValue memberValue;
if (method.getReturnType().isPrimitive()) {
memberValue = Annotation.createMemberValue(this.constPool,
this.classPool.get(method.getReturnType().getName()));
} else {
memberValue = Annotation.createMemberValue(this.constPool,
this.classPool.get(result.getClass().getName()));
}
{code}
was:
class org.apache.tapestry5.ioc.internal.services.AnnotationMemberValueVisitor
Line #64: final Object result = method.invoke(value);
If method return boolean, result wil be java.lang.Boolean not
boolean.
In this case in rutime will be Caused by: java.lang.ClassCastException:
java.lang.Boolean cannot be cast to java.lang.Enum.
I fix with:
MemberValue memberValue;
if (method.getReturnType().isPrimitive()) {
memberValue = Annotation.createMemberValue(this.constPool,
this.classPool.get(method.getReturnType().getName()));
} else {
memberValue = Annotation.createMemberValue(this.constPool,
this.classPool.get(result.getClass().getName()));
}
> Unwanted auto-boxing while annotation visiting
> ---
>
> Key: TAP5-2564
> URL: https://issues.apache.org/jira/browse/TAP5-2564
> Project: Tapestry 5
> Issue Type: Bug
> Components: tapestry-ioc
>Affects Versions: 5.3.8
>Reporter: Eugene Vologzhanin
>
> class org.apache.tapestry5.ioc.internal.services.AnnotationMemberValueVisitor
> Line #64: final Object result = method.invoke(value);
> If method return boolean, result wil be java.lang.Boolean not
> boolean.
> In this case in rutime will be Caused by: java.lang.ClassCastException:
> java.lang.Boolean cannot be cast to java.lang.Enum.
> I fix with:
> {code}
> MemberValue memberValue;
> if (method.getReturnType().isPrimitive()) {
> memberValue = Annotation.createMemberValue(this.constPool,
>
> this.classPool.get(method.getReturnType().getName()));
> } else {
> memberValue = Annotation.createMemberValue(this.constPool,
> this.classPool.get(result.getClass().getName()));
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (TAP5-2564) Unwanted auto-boxing while annotation visiting
[
https://issues.apache.org/jira/browse/TAP5-2564?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Eugene Vologzhanin updated TAP5-2564:
-
Description:
class org.apache.tapestry5.ioc.internal.services.AnnotationMemberValueVisitor
Line #64: final Object result = method.invoke(value);
If method return boolean, result wil be {b}java.lang.Boolean{b} not
{b}boolean{b}.
In this case in rutime will be Caused by: java.lang.ClassCastException:
java.lang.Boolean cannot be cast to java.lang.Enum.
I fix with:
{code}
MemberValue memberValue;
if (method.getReturnType().isPrimitive()) {
memberValue = Annotation.createMemberValue(this.constPool,
this.classPool.get(method.getReturnType().getName()));
} else {
memberValue = Annotation.createMemberValue(this.constPool,
this.classPool.get(result.getClass().getName()));
}
{code}
was:
class org.apache.tapestry5.ioc.internal.services.AnnotationMemberValueVisitor
Line #64: final Object result = method.invoke(value);
If method return boolean, result wil be java.lang.Boolean not
boolean.
In this case in rutime will be Caused by: java.lang.ClassCastException:
java.lang.Boolean cannot be cast to java.lang.Enum.
I fix with:
{code}
MemberValue memberValue;
if (method.getReturnType().isPrimitive()) {
memberValue = Annotation.createMemberValue(this.constPool,
this.classPool.get(method.getReturnType().getName()));
} else {
memberValue = Annotation.createMemberValue(this.constPool,
this.classPool.get(result.getClass().getName()));
}
{code}
> Unwanted auto-boxing while annotation visiting
> ---
>
> Key: TAP5-2564
> URL: https://issues.apache.org/jira/browse/TAP5-2564
> Project: Tapestry 5
> Issue Type: Bug
> Components: tapestry-ioc
>Affects Versions: 5.3.8
>Reporter: Eugene Vologzhanin
>
> class org.apache.tapestry5.ioc.internal.services.AnnotationMemberValueVisitor
> Line #64: final Object result = method.invoke(value);
> If method return boolean, result wil be {b}java.lang.Boolean{b} not
> {b}boolean{b}.
> In this case in rutime will be Caused by: java.lang.ClassCastException:
> java.lang.Boolean cannot be cast to java.lang.Enum.
> I fix with:
> {code}
> MemberValue memberValue;
> if (method.getReturnType().isPrimitive()) {
> memberValue = Annotation.createMemberValue(this.constPool,
>
> this.classPool.get(method.getReturnType().getName()));
> } else {
> memberValue = Annotation.createMemberValue(this.constPool,
> this.classPool.get(result.getClass().getName()));
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Created] (TAP5-2564) Unwanted auto-boxing while annotation visiting
Eugene Vologzhanin created TAP5-2564:
Summary: Unwanted auto-boxing while annotation visiting
Key: TAP5-2564
URL: https://issues.apache.org/jira/browse/TAP5-2564
Project: Tapestry 5
Issue Type: Bug
Components: tapestry-ioc
Affects Versions: 5.3.8
Reporter: Eugene Vologzhanin
class org.apache.tapestry5.ioc.internal.services.AnnotationMemberValueVisitor
Line #64: final Object result = method.invoke(value);
If method return boolean, result wil be java.lang.Boolean not
boolean.
In this case in rutime will be Caused by: java.lang.ClassCastException:
java.lang.Boolean cannot be cast to java.lang.Enum.
I fix with:
MemberValue memberValue;
if (method.getReturnType().isPrimitive()) {
memberValue = Annotation.createMemberValue(this.constPool,
this.classPool.get(method.getReturnType().getName()));
} else {
memberValue = Annotation.createMemberValue(this.constPool,
this.classPool.get(result.getClass().getName()));
}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
