[jira] Closed: (TAP5-439) Add annotation, @ServiceId, that can be placed on a builder method or service class to identify the service id to use
[ https://issues.apache.org/jira/browse/TAP5-439?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Igor Drobiazko closed TAP5-439. --- Resolution: Fixed Fix Version/s: 5.1.0.0 > Add annotation, @ServiceId, that can be placed on a builder method or service > class to identify the service id to use > - > > Key: TAP5-439 > URL: https://issues.apache.org/jira/browse/TAP5-439 > Project: Tapestry 5 > Issue Type: New Feature > Components: tapestry-ioc >Affects Versions: 5.1.0.0 >Reporter: Howard M. Lewis Ship >Assignee: Igor Drobiazko >Priority: Minor > Fix For: 5.1.0.0 > > > As an alternative to bind().withId(). -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Assigned: (TAP5-69) Allow service configurators to be arbitrary named and determine sevice by the configuration parameter
[
https://issues.apache.org/jira/browse/TAP5-69?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Igor Drobiazko reassigned TAP5-69:
--
Assignee: Igor Drobiazko
> Allow service configurators to be arbitrary named and determine sevice by the
> configuration parameter
> -
>
> Key: TAP5-69
> URL: https://issues.apache.org/jira/browse/TAP5-69
> Project: Tapestry 5
> Issue Type: Improvement
>Affects Versions: 5.0.15
>Reporter: Kalin Krustev
>Assignee: Igor Drobiazko
>
> Tapestry used to require this naming convention for configuring services:
> public static Foo buildFoo(...) {...}
> public static void contrubuteFoo(...) {...}
> Then it allowed the first convention to be simplified as:
> public static Foo build(...) {...}
> It would be nice for the "contribute..." methods to allow also simpler naming
> and use the type of the "configuration" parameter to determine the configured
> service, which will also have the same type of parameter.
> For example:
> in Tapestry 5.0.5 TapestryModule.java:
> public ServletApplicationInitializer build(...,
> List configuration, ... )
> in my AppModule.java Tapestry 5.0.5 requires this naming:
> public void
> contributeServletApplicationInitializer(OrderedConfiguration
> configuration)
> Perhaps it could be simplified as:
> public void
> contribute(OrderedConfiguration
> configuration)
> If it will not be simplified, it would be nice to make the documentation
> about Tapestry IoC Configurations more clear that
> the naming of the contribute methods is important, not the type of
> configuration parameter.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (TAP5-69) Add annotation, @Contribute, to allow service contributor methods to be arbitrary named
[
https://issues.apache.org/jira/browse/TAP5-69?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Igor Drobiazko updated TAP5-69:
---
Summary: Add annotation, @Contribute, to allow service contributor methods
to be arbitrary named (was: Allow service configurators to be arbitrary named
and determine sevice by the configuration parameter)
> Add annotation, @Contribute, to allow service contributor methods to be
> arbitrary named
> ---
>
> Key: TAP5-69
> URL: https://issues.apache.org/jira/browse/TAP5-69
> Project: Tapestry 5
> Issue Type: Improvement
>Affects Versions: 5.0.15
>Reporter: Kalin Krustev
>Assignee: Igor Drobiazko
>
> Tapestry used to require this naming convention for configuring services:
> public static Foo buildFoo(...) {...}
> public static void contrubuteFoo(...) {...}
> Then it allowed the first convention to be simplified as:
> public static Foo build(...) {...}
> It would be nice for the "contribute..." methods to allow also simpler naming
> and use the type of the "configuration" parameter to determine the configured
> service, which will also have the same type of parameter.
> For example:
> in Tapestry 5.0.5 TapestryModule.java:
> public ServletApplicationInitializer build(...,
> List configuration, ... )
> in my AppModule.java Tapestry 5.0.5 requires this naming:
> public void
> contributeServletApplicationInitializer(OrderedConfiguration
> configuration)
> Perhaps it could be simplified as:
> public void
> contribute(OrderedConfiguration
> configuration)
> If it will not be simplified, it would be nice to make the documentation
> about Tapestry IoC Configurations more clear that
> the naming of the contribute methods is important, not the type of
> configuration parameter.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (TAP5-69) Add annotation, @Contribute, to allow service contributor methods to be arbitrary named
[
https://issues.apache.org/jira/browse/TAP5-69?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Igor Drobiazko closed TAP5-69.
--
Resolution: Fixed
Fix Version/s: 5.1.0.0
> Add annotation, @Contribute, to allow service contributor methods to be
> arbitrary named
> ---
>
> Key: TAP5-69
> URL: https://issues.apache.org/jira/browse/TAP5-69
> Project: Tapestry 5
> Issue Type: Improvement
>Affects Versions: 5.0.15
>Reporter: Kalin Krustev
>Assignee: Igor Drobiazko
> Fix For: 5.1.0.0
>
>
> Tapestry used to require this naming convention for configuring services:
> public static Foo buildFoo(...) {...}
> public static void contrubuteFoo(...) {...}
> Then it allowed the first convention to be simplified as:
> public static Foo build(...) {...}
> It would be nice for the "contribute..." methods to allow also simpler naming
> and use the type of the "configuration" parameter to determine the configured
> service, which will also have the same type of parameter.
> For example:
> in Tapestry 5.0.5 TapestryModule.java:
> public ServletApplicationInitializer build(...,
> List configuration, ... )
> in my AppModule.java Tapestry 5.0.5 requires this naming:
> public void
> contributeServletApplicationInitializer(OrderedConfiguration
> configuration)
> Perhaps it could be simplified as:
> public void
> contribute(OrderedConfiguration
> configuration)
> If it will not be simplified, it would be nice to make the documentation
> about Tapestry IoC Configurations more clear that
> the naming of the contribute methods is important, not the type of
> configuration parameter.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Reopened: (TAP5-69) Add annotation, @Contribute, to allow service contributor methods to be arbitrary named
[
https://issues.apache.org/jira/browse/TAP5-69?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Igor Drobiazko reopened TAP5-69:
Reopened because fix is invalid
> Add annotation, @Contribute, to allow service contributor methods to be
> arbitrary named
> ---
>
> Key: TAP5-69
> URL: https://issues.apache.org/jira/browse/TAP5-69
> Project: Tapestry 5
> Issue Type: Improvement
>Affects Versions: 5.0.15
>Reporter: Kalin Krustev
>Assignee: Igor Drobiazko
> Fix For: 5.1.0.0
>
>
> Tapestry used to require this naming convention for configuring services:
> public static Foo buildFoo(...) {...}
> public static void contrubuteFoo(...) {...}
> Then it allowed the first convention to be simplified as:
> public static Foo build(...) {...}
> It would be nice for the "contribute..." methods to allow also simpler naming
> and use the type of the "configuration" parameter to determine the configured
> service, which will also have the same type of parameter.
> For example:
> in Tapestry 5.0.5 TapestryModule.java:
> public ServletApplicationInitializer build(...,
> List configuration, ... )
> in my AppModule.java Tapestry 5.0.5 requires this naming:
> public void
> contributeServletApplicationInitializer(OrderedConfiguration
> configuration)
> Perhaps it could be simplified as:
> public void
> contribute(OrderedConfiguration
> configuration)
> If it will not be simplified, it would be nice to make the documentation
> about Tapestry IoC Configurations more clear that
> the naming of the contribute methods is important, not the type of
> configuration parameter.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (TAP5-486) Switch Tapestry's built-in JavaScript support from Prototype to jQuery
[ https://issues.apache.org/jira/browse/TAP5-486?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12669057#action_12669057 ] Igor Drobiazko commented on TAP5-486: - I think the switch from Prototype to jQuery is the worst thing we can do for Tapestry now. I have spoken to a lot of people who are raising concerns about Tapestry's back compatibility. Usually this is the only reason not to use Tapestry. Tapestry has to restore the developers' confidence. Some time ago a decision (for using Prototype) was made, now we have to live with it. > Switch Tapestry's built-in JavaScript support from Prototype to jQuery > -- > > Key: TAP5-486 > URL: https://issues.apache.org/jira/browse/TAP5-486 > Project: Tapestry 5 > Issue Type: Improvement > Components: tapestry-core >Affects Versions: 5.1.0.0 >Reporter: Howard M. Lewis Ship > > Like rats deserting a sinking ship ... > This is not a definitive requirement; I've created this issue to promote > discussion. > It's quite likely that a move like this could be accomplished quite smoothly > for users who are meerly consumers of JavaScript components; authors of > JavaScript components would have to make some changes. > Possibly we should code the jQuery stack from the get-go to NOT use the $() > method, but instead use j$(). That extra character to type could make all the > difference is allowing a smooth upgrade, where jQuery becomes the default, > but prototype/scriptaculous can still be used. > Possibly a new annotation, @PrototypeSupport for components to ensure that > the Prototype libraries are available for compatibility? -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (TAP5-503) Make Live Class and Template Reloading feature work in OSGi
[ https://issues.apache.org/jira/browse/TAP5-503?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Igor Drobiazko updated TAP5-503: Affects Version/s: 5.1.0.0 > Make Live Class and Template Reloading feature work in OSGi > --- > > Key: TAP5-503 > URL: https://issues.apache.org/jira/browse/TAP5-503 > Project: Tapestry 5 > Issue Type: Improvement > Components: tapestry-core >Affects Versions: 5.1.0.0 >Reporter: Igor Drobiazko >Assignee: Igor Drobiazko > > URLChangeTracker should use ClasspathURLConverter in order to track changes > of the OSGi bundle classes and resources. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Assigned: (TAP5-503) Make Live Class and Template Reloading feature work in OSGi
[ https://issues.apache.org/jira/browse/TAP5-503?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Igor Drobiazko reassigned TAP5-503: --- Assignee: Igor Drobiazko > Make Live Class and Template Reloading feature work in OSGi > --- > > Key: TAP5-503 > URL: https://issues.apache.org/jira/browse/TAP5-503 > Project: Tapestry 5 > Issue Type: Improvement > Components: tapestry-core >Affects Versions: 5.1.0.0 >Reporter: Igor Drobiazko >Assignee: Igor Drobiazko > > URLChangeTracker should use ClasspathURLConverter in order to track changes > of the OSGi bundle classes and resources. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Created: (TAP5-503) Make Live Class and Template Reloading feature work in OSGi
Make Live Class and Template Reloading feature work in OSGi --- Key: TAP5-503 URL: https://issues.apache.org/jira/browse/TAP5-503 Project: Tapestry 5 Issue Type: Improvement Components: tapestry-core Reporter: Igor Drobiazko URLChangeTracker should use ClasspathURLConverter in order to track changes of the OSGi bundle classes and resources. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Assigned: (TAP5-505) JettyRunner is not able to start on Windows machine if the web application path is absolute
[ https://issues.apache.org/jira/browse/TAP5-505?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Igor Drobiazko reassigned TAP5-505: --- Assignee: Igor Drobiazko > JettyRunner is not able to start on Windows machine if the web application > path is absolute > --- > > Key: TAP5-505 > URL: https://issues.apache.org/jira/browse/TAP5-505 > Project: Tapestry 5 > Issue Type: Bug > Components: tapestry-test >Affects Versions: 5.0.18 >Reporter: Igor Drobiazko >Assignee: Igor Drobiazko > > JettyRunner detects a web app path as absolute one if the path starts with > "/". This is not valid for a Windows machine. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Created: (TAP5-505) JettyRunner is not able to start on Windows machine if the web application path is absolute
JettyRunner is not able to start on Windows machine if the web application path is absolute --- Key: TAP5-505 URL: https://issues.apache.org/jira/browse/TAP5-505 Project: Tapestry 5 Issue Type: Bug Components: tapestry-test Affects Versions: 5.0.18 Reporter: Igor Drobiazko JettyRunner detects a web app path as absolute one if the path starts with "/". This is not valid for a Windows machine. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Closed: (TAP5-503) Make Live Class and Template Reloading feature work in OSGi
[ https://issues.apache.org/jira/browse/TAP5-503?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Igor Drobiazko closed TAP5-503. --- Resolution: Fixed Fix Version/s: 5.1.0.0 > Make Live Class and Template Reloading feature work in OSGi > --- > > Key: TAP5-503 > URL: https://issues.apache.org/jira/browse/TAP5-503 > Project: Tapestry 5 > Issue Type: Improvement > Components: tapestry-core >Affects Versions: 5.1.0.0 >Reporter: Igor Drobiazko >Assignee: Igor Drobiazko > Fix For: 5.1.0.0 > > > URLChangeTracker should use ClasspathURLConverter in order to track changes > of the OSGi bundle classes and resources. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Closed: (TAP5-505) JettyRunner is not able to start on Windows machine if the web application path is absolute
[ https://issues.apache.org/jira/browse/TAP5-505?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Igor Drobiazko closed TAP5-505. --- Resolution: Fixed Fix Version/s: 5.1.0.0 > JettyRunner is not able to start on Windows machine if the web application > path is absolute > --- > > Key: TAP5-505 > URL: https://issues.apache.org/jira/browse/TAP5-505 > Project: Tapestry 5 > Issue Type: Bug > Components: tapestry-test >Affects Versions: 5.0.18 >Reporter: Igor Drobiazko >Assignee: Igor Drobiazko > Fix For: 5.1.0.0 > > > JettyRunner detects a web app path as absolute one if the path starts with > "/". This is not valid for a Windows machine. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Assigned: (TAP5-194) Submit Button missing context and image support
[ https://issues.apache.org/jira/browse/TAP5-194?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Igor Drobiazko reassigned TAP5-194: --- Assignee: Igor Drobiazko > Submit Button missing context and image support > --- > > Key: TAP5-194 > URL: https://issues.apache.org/jira/browse/TAP5-194 > Project: Tapestry 5 > Issue Type: Improvement >Affects Versions: 5.0.15 >Reporter: Cherry Development >Assignee: Igor Drobiazko > Attachments: SubmitContext.java > > > The Submit component has two major deficiencies: > 1) You cannot use an image submit ( ) > 2) You cannot pass any context into the button's "selected" event handler. > Issue 1 currently requires you to create your own submit button type, though > this is simple if you don't mind copy/pasting the current Submit class and > changing one line. > Issue 2 is a much bigger problem. If you have a submit button in a loop and > need to know (for example) which item was current in the loop when it was > rendered, you have to set "defer" to false, then record the context > information in your onSelected handler. You often can't perform a useful > action directly in your deferred onSelected handler because you shouldn't > change the structure of your bound data in the middle of a form submit, or > because you should not perform your action until you're assured the form has > validated. > So, you now have to record the context that you need to perform the action, > PLUS the action that needs to be performed, and then perform it all inside of > your onSuccess handler! Frankly, this seems so inelegant as to have been an > oversight. > On the Tapestry Wiki, at > http://wiki.apache.org/tapestry/Tapestry5SubmitContextComponent there is a > basic implementation, though it has several weaknesses: > 1) It was written for 5.0.4 and doesn't compile without changing a few minor > things, nor does it support RenderDisabled. > 2) It only supports a single context parameter and it makes no effort to > properly encode it when rendered to the client. > So, based on the concept used on the wiki code (namely, using a > field to store the context) I made a few small modifications to the Tapestry > 5.0.11 Submit.java class that I will attach to this issue. > I grant ownership of the attached code to the Apache Software Foundation. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Created: (TAP5-523) Submit component should be able to render an input field of type image
Submit component should be able to render an input field of type image -- Key: TAP5-523 URL: https://issues.apache.org/jira/browse/TAP5-523 Project: Tapestry 5 Issue Type: Improvement Affects Versions: 5.0.15 Reporter: Igor Drobiazko Assignee: Igor Drobiazko The Submit component has two major deficiencies: 1) You cannot use an image submit ( ) 2) You cannot pass any context into the button's "selected" event handler. Issue 1 currently requires you to create your own submit button type, though this is simple if you don't mind copy/pasting the current Submit class and changing one line. Issue 2 is a much bigger problem. If you have a submit button in a loop and need to know (for example) which item was current in the loop when it was rendered, you have to set "defer" to false, then record the context information in your onSelected handler. You often can't perform a useful action directly in your deferred onSelected handler because you shouldn't change the structure of your bound data in the middle of a form submit, or because you should not perform your action until you're assured the form has validated. So, you now have to record the context that you need to perform the action, PLUS the action that needs to be performed, and then perform it all inside of your onSuccess handler! Frankly, this seems so inelegant as to have been an oversight. On the Tapestry Wiki, at http://wiki.apache.org/tapestry/Tapestry5SubmitContextComponent there is a basic implementation, though it has several weaknesses: 1) It was written for 5.0.4 and doesn't compile without changing a few minor things, nor does it support RenderDisabled. 2) It only supports a single context parameter and it makes no effort to properly encode it when rendered to the client. So, based on the concept used on the wiki code (namely, using a field to store the context) I made a few small modifications to the Tapestry 5.0.11 Submit.java class that I will attach to this issue. I grant ownership of the attached code to the Apache Software Foundation. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (TAP5-194) Handler method of Submit component should accept a context
[ https://issues.apache.org/jira/browse/TAP5-194?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Igor Drobiazko updated TAP5-194: Summary: Handler method of Submit component should accept a context (was: Submit Button missing context and image support) > Handler method of Submit component should accept a context > -- > > Key: TAP5-194 > URL: https://issues.apache.org/jira/browse/TAP5-194 > Project: Tapestry 5 > Issue Type: Improvement >Affects Versions: 5.0.15 >Reporter: Cherry Development >Assignee: Igor Drobiazko > Attachments: SubmitContext.java > > > The Submit component has two major deficiencies: > 1) You cannot use an image submit ( ) > 2) You cannot pass any context into the button's "selected" event handler. > Issue 1 currently requires you to create your own submit button type, though > this is simple if you don't mind copy/pasting the current Submit class and > changing one line. > Issue 2 is a much bigger problem. If you have a submit button in a loop and > need to know (for example) which item was current in the loop when it was > rendered, you have to set "defer" to false, then record the context > information in your onSelected handler. You often can't perform a useful > action directly in your deferred onSelected handler because you shouldn't > change the structure of your bound data in the middle of a form submit, or > because you should not perform your action until you're assured the form has > validated. > So, you now have to record the context that you need to perform the action, > PLUS the action that needs to be performed, and then perform it all inside of > your onSuccess handler! Frankly, this seems so inelegant as to have been an > oversight. > On the Tapestry Wiki, at > http://wiki.apache.org/tapestry/Tapestry5SubmitContextComponent there is a > basic implementation, though it has several weaknesses: > 1) It was written for 5.0.4 and doesn't compile without changing a few minor > things, nor does it support RenderDisabled. > 2) It only supports a single context parameter and it makes no effort to > properly encode it when rendered to the client. > So, based on the concept used on the wiki code (namely, using a > field to store the context) I made a few small modifications to the Tapestry > 5.0.11 Submit.java class that I will attach to this issue. > I grant ownership of the attached code to the Apache Software Foundation. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Closed: (TAP5-194) Handler method of Submit component should accept a context
[ https://issues.apache.org/jira/browse/TAP5-194?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Igor Drobiazko closed TAP5-194. --- Resolution: Fixed Fix Version/s: 5.1.0.0 > Handler method of Submit component should accept a context > -- > > Key: TAP5-194 > URL: https://issues.apache.org/jira/browse/TAP5-194 > Project: Tapestry 5 > Issue Type: Improvement >Affects Versions: 5.0.15 >Reporter: Cherry Development >Assignee: Igor Drobiazko > Fix For: 5.1.0.0 > > Attachments: SubmitContext.java > > > The Submit component has two major deficiencies: > 1) You cannot use an image submit ( ) > 2) You cannot pass any context into the button's "selected" event handler. > Issue 1 currently requires you to create your own submit button type, though > this is simple if you don't mind copy/pasting the current Submit class and > changing one line. > Issue 2 is a much bigger problem. If you have a submit button in a loop and > need to know (for example) which item was current in the loop when it was > rendered, you have to set "defer" to false, then record the context > information in your onSelected handler. You often can't perform a useful > action directly in your deferred onSelected handler because you shouldn't > change the structure of your bound data in the middle of a form submit, or > because you should not perform your action until you're assured the form has > validated. > So, you now have to record the context that you need to perform the action, > PLUS the action that needs to be performed, and then perform it all inside of > your onSuccess handler! Frankly, this seems so inelegant as to have been an > oversight. > On the Tapestry Wiki, at > http://wiki.apache.org/tapestry/Tapestry5SubmitContextComponent there is a > basic implementation, though it has several weaknesses: > 1) It was written for 5.0.4 and doesn't compile without changing a few minor > things, nor does it support RenderDisabled. > 2) It only supports a single context parameter and it makes no effort to > properly encode it when rendered to the client. > So, based on the concept used on the wiki code (namely, using a > field to store the context) I made a few small modifications to the Tapestry > 5.0.11 Submit.java class that I will attach to this issue. > I grant ownership of the attached code to the Apache Software Foundation. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Created: (TAP5-525) The Component Report should provide the Tapestry version the particular parameter was introduced in
The Component Report should provide the Tapestry version the particular parameter was introduced in --- Key: TAP5-525 URL: https://issues.apache.org/jira/browse/TAP5-525 Project: Tapestry 5 Issue Type: Improvement Components: tapestry-component-report Affects Versions: 5.0.18 Reporter: Igor Drobiazko Priority: Minor Add a new column 'since' into the Component Parameters table that contains the value of the javadoc tag @since of the particular field, if provided. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Closed: (TAP5-523) Submit component should be able to render an input field of type image
[ https://issues.apache.org/jira/browse/TAP5-523?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Igor Drobiazko closed TAP5-523. --- Resolution: Fixed Fix Version/s: 5.1.0.0 > Submit component should be able to render an input field of type image > -- > > Key: TAP5-523 > URL: https://issues.apache.org/jira/browse/TAP5-523 > Project: Tapestry 5 > Issue Type: Improvement >Affects Versions: 5.0.15 >Reporter: Igor Drobiazko >Assignee: Igor Drobiazko > Fix For: 5.1.0.0 > > > The Submit component has two major deficiencies: > 1) You cannot use an image submit ( ) > 2) You cannot pass any context into the button's "selected" event handler. > Issue 1 currently requires you to create your own submit button type, though > this is simple if you don't mind copy/pasting the current Submit class and > changing one line. > Issue 2 is a much bigger problem. If you have a submit button in a loop and > need to know (for example) which item was current in the loop when it was > rendered, you have to set "defer" to false, then record the context > information in your onSelected handler. You often can't perform a useful > action directly in your deferred onSelected handler because you shouldn't > change the structure of your bound data in the middle of a form submit, or > because you should not perform your action until you're assured the form has > validated. > So, you now have to record the context that you need to perform the action, > PLUS the action that needs to be performed, and then perform it all inside of > your onSuccess handler! Frankly, this seems so inelegant as to have been an > oversight. > On the Tapestry Wiki, at > http://wiki.apache.org/tapestry/Tapestry5SubmitContextComponent there is a > basic implementation, though it has several weaknesses: > 1) It was written for 5.0.4 and doesn't compile without changing a few minor > things, nor does it support RenderDisabled. > 2) It only supports a single context parameter and it makes no effort to > properly encode it when rendered to the client. > So, based on the concept used on the wiki code (namely, using a > field to store the context) I made a few small modifications to the Tapestry > 5.0.11 Submit.java class that I will attach to this issue. > I grant ownership of the attached code to the Apache Software Foundation. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Assigned: (TAP5-527) Input validation documentation is missing clear list of available validators and their correct notation to use.
[ https://issues.apache.org/jira/browse/TAP5-527?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Igor Drobiazko reassigned TAP5-527: --- Assignee: Igor Drobiazko > Input validation documentation is missing clear list of available validators > and their correct notation to use. > --- > > Key: TAP5-527 > URL: https://issues.apache.org/jira/browse/TAP5-527 > Project: Tapestry 5 > Issue Type: Improvement > Components: documentation >Reporter: Ville Virtanen >Assignee: Igor Drobiazko >Priority: Minor > Attachments: TAP5-527.txt > > > Input validation documentation is missing clear list of available validators > and their correct notation to use. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Closed: (TAP5-527) Input validation documentation is missing clear list of available validators and their correct notation to use.
[ https://issues.apache.org/jira/browse/TAP5-527?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Igor Drobiazko closed TAP5-527. --- Resolution: Fixed Fix Version/s: 5.1.0.1 Thanks! > Input validation documentation is missing clear list of available validators > and their correct notation to use. > --- > > Key: TAP5-527 > URL: https://issues.apache.org/jira/browse/TAP5-527 > Project: Tapestry 5 > Issue Type: Improvement > Components: documentation >Reporter: Ville Virtanen >Assignee: Igor Drobiazko >Priority: Minor > Fix For: 5.1.0.1 > > Attachments: TAP5-527.txt > > > Input validation documentation is missing clear list of available validators > and their correct notation to use. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Assigned: (TAP5-525) The Component Report should provide the Tapestry version the particular parameter was introduced in
[ https://issues.apache.org/jira/browse/TAP5-525?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Igor Drobiazko reassigned TAP5-525: --- Assignee: Igor Drobiazko > The Component Report should provide the Tapestry version the particular > parameter was introduced in > --- > > Key: TAP5-525 > URL: https://issues.apache.org/jira/browse/TAP5-525 > Project: Tapestry 5 > Issue Type: Improvement > Components: tapestry-component-report >Affects Versions: 5.0.18 >Reporter: Igor Drobiazko >Assignee: Igor Drobiazko >Priority: Minor > > Add a new column 'since' into the Component Parameters table that contains > the value of the javadoc tag @since of the particular field, if provided. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (TAP5-525) The Component Report should provide the Tapestry version a parameter or a component was introduced in
[ https://issues.apache.org/jira/browse/TAP5-525?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Igor Drobiazko updated TAP5-525: Summary: The Component Report should provide the Tapestry version a parameter or a component was introduced in (was: The Component Report should provide the Tapestry version the particular parameter was introduced in) > The Component Report should provide the Tapestry version a parameter or a > component was introduced in > - > > Key: TAP5-525 > URL: https://issues.apache.org/jira/browse/TAP5-525 > Project: Tapestry 5 > Issue Type: Improvement > Components: tapestry-component-report >Affects Versions: 5.0.18 >Reporter: Igor Drobiazko >Assignee: Igor Drobiazko >Priority: Minor > > Add a new column 'since' into the Component Parameters table that contains > the value of the javadoc tag @since of the particular field, if provided. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Created: (TAP5-532) Handler method of LinkSubmit component should accept a context
Handler method of LinkSubmit component should accept a context -- Key: TAP5-532 URL: https://issues.apache.org/jira/browse/TAP5-532 Project: Tapestry 5 Issue Type: Improvement Affects Versions: 5.1.0.1 Reporter: Igor Drobiazko Priority: Minor Same issue as TAP5-194 -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Assigned: (TAP5-532) Handler method of LinkSubmit component should accept a context
[ https://issues.apache.org/jira/browse/TAP5-532?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Igor Drobiazko reassigned TAP5-532: --- Assignee: Igor Drobiazko > Handler method of LinkSubmit component should accept a context > -- > > Key: TAP5-532 > URL: https://issues.apache.org/jira/browse/TAP5-532 > Project: Tapestry 5 > Issue Type: Improvement >Affects Versions: 5.1.0.1 >Reporter: Igor Drobiazko >Assignee: Igor Drobiazko >Priority: Minor > > Same issue as TAP5-194 -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Closed: (TAP5-525) The Component Report should provide the Tapestry version a parameter or a component was introduced in
[ https://issues.apache.org/jira/browse/TAP5-525?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Igor Drobiazko closed TAP5-525. --- Resolution: Fixed Fix Version/s: 5.1.0.1 > The Component Report should provide the Tapestry version a parameter or a > component was introduced in > - > > Key: TAP5-525 > URL: https://issues.apache.org/jira/browse/TAP5-525 > Project: Tapestry 5 > Issue Type: Improvement > Components: tapestry-component-report >Affects Versions: 5.0.18 >Reporter: Igor Drobiazko >Assignee: Igor Drobiazko >Priority: Minor > Fix For: 5.1.0.1 > > > Add a new column 'since' into the Component Parameters table that contains > the value of the javadoc tag @since of the particular field, if provided. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Reopened: (TAP5-520) Regexp validator parse error
[
https://issues.apache.org/jira/browse/TAP5-520?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Igor Drobiazko reopened TAP5-520:
-
Assignee: Igor Drobiazko
Reopened. This is still a bug. One should be able to use commas inside
@Validate("regexpr="). I will have a look into this.
> Regexp validator parse error
>
>
> Key: TAP5-520
> URL: https://issues.apache.org/jira/browse/TAP5-520
> Project: Tapestry 5
> Issue Type: Bug
> Components: tapestry-core
>Affects Versions: 5.0.18
>Reporter: Konstantin Miklevskiy
>Assignee: Igor Drobiazko
>
> Try adding this field to your form:
> @Validate("regexp=^([a-zA-Z0-9]{2,4})+$")
> private String somefield;
> Page will fail to render with exception saying:
> Render queue error in BeginRender[mypage.somefield]: Failure reading
> parameter 'validate' of component mypage.somefield: Coercion of
> ^([a-zA-Z0-9]{2 to type java.util.regex.Pattern (via String -->
> java.util.regex.Pattern) failed: Unclosed counted closure near index 15
> ^([a-zA-Z0-9]{2 ^
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (TAP5-520) Using regular expressions with the @Validate annotation causes odd parse errors if the regexp includes common characters (including commas)
[
https://issues.apache.org/jira/browse/TAP5-520?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12678992#action_12678992
]
Igor Drobiazko commented on TAP5-520:
-
Why "invalid" or "won't fix"? This is a bug. I have already a fix using
positive and negative lookahead. Was just thinking about test cases. Shall I
commit the fix?
> Using regular expressions with the @Validate annotation causes odd parse
> errors if the regexp includes common characters (including commas)
> ---
>
> Key: TAP5-520
> URL: https://issues.apache.org/jira/browse/TAP5-520
> Project: Tapestry 5
> Issue Type: Bug
> Components: tapestry-core
>Affects Versions: 5.0.18
>Reporter: Konstantin Miklevskiy
>Assignee: Igor Drobiazko
>Priority: Minor
>
> Try adding this field to your form:
> @Validate("regexp=^([a-zA-Z0-9]{2,4})+$")
> private String somefield;
> Page will fail to render with exception saying:
> Render queue error in BeginRender[mypage.somefield]: Failure reading
> parameter 'validate' of component mypage.somefield: Coercion of
> ^([a-zA-Z0-9]{2 to type java.util.regex.Pattern (via String -->
> java.util.regex.Pattern) failed: Unclosed counted closure near index 15
> ^([a-zA-Z0-9]{2 ^
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (TAP5-520) Using regular expressions with the @Validate annotation causes odd parse errors if the regexp includes common characters (including commas)
[
https://issues.apache.org/jira/browse/TAP5-520?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Igor Drobiazko closed TAP5-520.
---
Resolution: Fixed
Fix Version/s: 5.1.0.1
> Using regular expressions with the @Validate annotation causes odd parse
> errors if the regexp includes common characters (including commas)
> ---
>
> Key: TAP5-520
> URL: https://issues.apache.org/jira/browse/TAP5-520
> Project: Tapestry 5
> Issue Type: Bug
> Components: tapestry-core
>Affects Versions: 5.0.18
>Reporter: Konstantin Miklevskiy
>Assignee: Igor Drobiazko
>Priority: Minor
> Fix For: 5.1.0.1
>
>
> Try adding this field to your form:
> @Validate("regexp=^([a-zA-Z0-9]{2,4})+$")
> private String somefield;
> Page will fail to render with exception saying:
> Render queue error in BeginRender[mypage.somefield]: Failure reading
> parameter 'validate' of component mypage.somefield: Coercion of
> ^([a-zA-Z0-9]{2 to type java.util.regex.Pattern (via String -->
> java.util.regex.Pattern) failed: Unclosed counted closure near index 15
> ^([a-zA-Z0-9]{2 ^
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Created: (TAP5-556) Fix TranslatorSourceImplTest
Fix TranslatorSourceImplTest Key: TAP5-556 URL: https://issues.apache.org/jira/browse/TAP5-556 Project: Tapestry 5 Issue Type: Bug Components: tapestry-core Reporter: Igor Drobiazko SInce TAP5-540 is fixed I can't run TranslatorSourceImplTest. to_client(org.apache.tapestry5.internal.services.TranslatorSourceImplTest) Time elapsed: 0.031 sec <<< FAILURE! java.lang.AssertionError: expected:<3.143> but was:<3,143> at org.testng.Assert.fail(Assert.java:84) at org.testng.Assert.failNotEquals(Assert.java:438) at org.testng.Assert.assertEquals(Assert.java:108) at org.testng.Assert.assertEquals(Assert.java:129) at org.testng.Assert.assertEquals(Assert.java:139) at org.apache.tapestry5.internal.services.TranslatorSourceImplTest.to_client(TranslatorSourceImplTest.java:130) to_client(org.apache.tapestry5.internal.services.TranslatorSourceImplTest) Time elapsed: 0 sec <<< FAILURE! java.lang.AssertionError: expected:<-22.7> but was:<-22,7> at org.testng.Assert.fail(Assert.java:84) at org.testng.Assert.failNotEquals(Assert.java:438) at org.testng.Assert.assertEquals(Assert.java:108) at org.testng.Assert.assertEquals(Assert.java:129) at org.testng.Assert.assertEquals(Assert.java:139) at org.apache.tapestry5.internal.services.TranslatorSourceImplTest.to_client(TranslatorSourceImplTest.java:130) to_client(org.apache.tapestry5.internal.services.TranslatorSourceImplTest) Time elapsed: 0 sec <<< FAILURE! java.lang.AssertionError: expected:<-9876543219876543321987654321.12345123451234512345> but was:<-9876543219876543321987654321,12345123451234512345> at org.testng.Assert.fail(Assert.java:84) at org.testng.Assert.failNotEquals(Assert.java:438) at org.testng.Assert.assertEquals(Assert.java:108) at org.testng.Assert.assertEquals(Assert.java:129) at org.testng.Assert.assertEquals(Assert.java:139) at org.apache.tapestry5.internal.services.TranslatorSourceImplTest.to_client(TranslatorSourceImplTest.java:130) parse_client(org.apache.tapestry5.internal.services.TranslatorSourceImplTest) Time elapsed: 0.016 sec <<< FAILURE! java.lang.AssertionError: expected:<2> but was:<20> at org.testng.Assert.fail(Assert.java:84) at org.testng.Assert.failNotEquals(Assert.java:438) at org.testng.Assert.assertEquals(Assert.java:108) at org.testng.Assert.assertEquals(Assert.java:118) at org.apache.tapestry5.internal.services.TranslatorSourceImplTest.parse_client(TranslatorSourceImplTest.java:169) parse_client(org.apache.tapestry5.internal.services.TranslatorSourceImplTest) Time elapsed: 0 sec <<< FAILURE! java.lang.AssertionError: expected:<3.1428571429> but was:<3.1428571429E10> at org.testng.Assert.fail(Assert.java:84) at org.testng.Assert.failNotEquals(Assert.java:438) at org.testng.Assert.assertEquals(Assert.java:108) at org.testng.Assert.assertEquals(Assert.java:118) at org.apache.tapestry5.internal.services.TranslatorSourceImplTest.parse_client(TranslatorSourceImplTest.java:169) parse_client(org.apache.tapestry5.internal.services.TranslatorSourceImplTest) Time elapsed: 0 sec <<< FAILURE! java.lang.AssertionError: expected:<28.95> but was:<2895.0> at org.testng.Assert.fail(Assert.java:84) at org.testng.Assert.failNotEquals(Assert.java:438) at org.testng.Assert.assertEquals(Assert.java:108) at org.testng.Assert.assertEquals(Assert.java:118) at org.apache.tapestry5.internal.services.TranslatorSourceImplTest.parse_client(TranslatorSourceImplTest.java:169) -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Created: (TAP5-570) tapestry-core should provide a built-in page to show the status of persistent data
tapestry-core should provide a built-in page to show the status of persistent data --- Key: TAP5-570 URL: https://issues.apache.org/jira/browse/TAP5-570 Project: Tapestry 5 Issue Type: New Feature Components: tapestry-core Affects Versions: 5.1.0.1 Reporter: Igor Drobiazko In order to oprimize the amount of data persisted in the session via @Persist or as ASO one should be able to get an overview of it. A page StateStatus should be provided which could loo like: Persistant Fields - Strategy Name | Page Name | Component Id | Field Name - flash |Login | loginform.form | defaultTracker --- state | Foo| | bar Application State Objects -- com.example.model.u...@ba8180[id=1,username=root,...] -- com.example.model.Foo1f6c439[bar=baz] -- -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Assigned: (TAP5-562) tapestry-hibernate should provide a built-in status page to show basic Hibernate statistics inlcuding cache hits, etc.
[ https://issues.apache.org/jira/browse/TAP5-562?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Igor Drobiazko reassigned TAP5-562: --- Assignee: Igor Drobiazko > tapestry-hibernate should provide a built-in status page to show basic > Hibernate statistics inlcuding cache hits, etc. > -- > > Key: TAP5-562 > URL: https://issues.apache.org/jira/browse/TAP5-562 > Project: Tapestry 5 > Issue Type: New Feature > Components: tapestry-hibernate >Affects Versions: 5.1.0.1 >Reporter: Howard M. Lewis Ship >Assignee: Igor Drobiazko > > It would be nice to get some introspection into how Hibernate is operating, > easily. > This is another page that should be disabled (or at least, minimal > functionality) in production. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Assigned: (TAP5-570) tapestry-core should provide a built-in page to show the status of persistent data
[ https://issues.apache.org/jira/browse/TAP5-570?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Igor Drobiazko reassigned TAP5-570: --- Assignee: Igor Drobiazko > tapestry-core should provide a built-in page to show the status of persistent > data > --- > > Key: TAP5-570 > URL: https://issues.apache.org/jira/browse/TAP5-570 > Project: Tapestry 5 > Issue Type: New Feature > Components: tapestry-core >Affects Versions: 5.1.0.1 >Reporter: Igor Drobiazko >Assignee: Igor Drobiazko > > In order to oprimize the amount of data persisted in the session via @Persist > or as ASO one should be able to get an overview of it. A page StateStatus > should be provided which could loo like: > Persistant Fields > - > Strategy Name | Page Name | Component Id | Field Name > - >flash |Login | loginform.form | > defaultTracker > --- >state | Foo| >| bar > > Application State Objects > -- > com.example.model.u...@ba8180[id=1,username=root,...] > -- > com.example.model.Foo1f6c439[bar=baz] > -- -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Created: (TAP5-571) Misplaced results in an inscrutable exception
Misplaced results in an inscrutable exception --- Key: TAP5-571 URL: https://issues.apache.org/jira/browse/TAP5-571 Project: Tapestry 5 Issue Type: Bug Components: tapestry-core Affects Versions: 5.1.0.0 Reporter: Igor Drobiazko If is used not inside a component, a inscrutable exception occurs. The message of the exception doesn't tell at all what the reason was. PageLoaderProcessor should catch the IllegalStateException inside the method parameter(ParameterToken) and throw TapestryException containing the location of the current token. This will provide a reasonable exception report. java.lang.IllegalStateException: Stack is empty. at org.apache.tapestry5.ioc.util.Stack.checkIfEmpty(Stack.java:119) at org.apache.tapestry5.ioc.util.Stack.peek(Stack.java:131) at org.apache.tapestry5.internal.services.PageLoaderProcessor.parameter(PageLoaderProcessor.java:594) at org.apache.tapestry5.internal.services.PageLoaderProcessor.loadTemplateForComponent(PageLoaderProcessor.java:519) at org.apache.tapestry5.internal.services.PageLoaderProcessor.workComponentQueue(PageLoaderProcessor.java:834) at org.apache.tapestry5.internal.services.PageLoaderProcessor.loadPage(PageLoaderProcessor.java:392) at org.apache.tapestry5.internal.services.PageLoaderImpl.loadPage(PageLoaderImpl.java:59) at $PageLoader_11ff4e54e7f.loadPage($PageLoader_11ff4e54e7f.java) at org.apache.tapestry5.internal.services.PagePoolCache.checkout(PagePoolCache.java:210) at org.apache.tapestry5.internal.services.PagePoolImpl.checkout(PagePoolImpl.java:99) To reproduce the problem create the following page: http://tapestry.apache.org/schema/tapestry_5_0_0.xsd";> Foo Bar -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Assigned: (TAP5-571) Misplaced results in an inscrutable exception
[ https://issues.apache.org/jira/browse/TAP5-571?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Igor Drobiazko reassigned TAP5-571: --- Assignee: Igor Drobiazko > Misplaced results in an inscrutable exception > --- > > Key: TAP5-571 > URL: https://issues.apache.org/jira/browse/TAP5-571 > Project: Tapestry 5 > Issue Type: Bug > Components: tapestry-core >Affects Versions: 5.1.0.0 >Reporter: Igor Drobiazko >Assignee: Igor Drobiazko > > If is used not inside a component, a inscrutable exception > occurs. The message of the exception doesn't tell at all what the reason was. > PageLoaderProcessor should catch the IllegalStateException inside the method > parameter(ParameterToken) and throw TapestryException containing the location > of the current token. This will provide a reasonable exception report. > java.lang.IllegalStateException: Stack is empty. > at org.apache.tapestry5.ioc.util.Stack.checkIfEmpty(Stack.java:119) > at org.apache.tapestry5.ioc.util.Stack.peek(Stack.java:131) > at > org.apache.tapestry5.internal.services.PageLoaderProcessor.parameter(PageLoaderProcessor.java:594) > at > org.apache.tapestry5.internal.services.PageLoaderProcessor.loadTemplateForComponent(PageLoaderProcessor.java:519) > at > org.apache.tapestry5.internal.services.PageLoaderProcessor.workComponentQueue(PageLoaderProcessor.java:834) > at > org.apache.tapestry5.internal.services.PageLoaderProcessor.loadPage(PageLoaderProcessor.java:392) > at > org.apache.tapestry5.internal.services.PageLoaderImpl.loadPage(PageLoaderImpl.java:59) > at $PageLoader_11ff4e54e7f.loadPage($PageLoader_11ff4e54e7f.java) > at > org.apache.tapestry5.internal.services.PagePoolCache.checkout(PagePoolCache.java:210) > at > org.apache.tapestry5.internal.services.PagePoolImpl.checkout(PagePoolImpl.java:99) > To reproduce the problem create the following page: > xmlns:t="http://tapestry.apache.org/schema/tapestry_5_0_0.xsd";> > > > Foo > > > Bar > > > -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Closed: (TAP5-562) tapestry-hibernate should provide a built-in status page to show basic Hibernate statistics inlcuding cache hits, etc.
[ https://issues.apache.org/jira/browse/TAP5-562?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Igor Drobiazko closed TAP5-562. --- Resolution: Fixed Fix Version/s: 5.1.0.2 > tapestry-hibernate should provide a built-in status page to show basic > Hibernate statistics inlcuding cache hits, etc. > -- > > Key: TAP5-562 > URL: https://issues.apache.org/jira/browse/TAP5-562 > Project: Tapestry 5 > Issue Type: New Feature > Components: tapestry-hibernate >Affects Versions: 5.1.0.1 >Reporter: Howard M. Lewis Ship >Assignee: Igor Drobiazko > Fix For: 5.1.0.2 > > > It would be nice to get some introspection into how Hibernate is operating, > easily. > This is another page that should be disabled (or at least, minimal > functionality) in production. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Closed: (TAP5-576) Add support for JBoss 5.x
[
https://issues.apache.org/jira/browse/TAP5-576?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Igor Drobiazko closed TAP5-576.
---
Resolution: Won't Fix
Fix Version/s: 5.1.0.2
Sorry, but tapestry-ioc is not the proper place for that code. The service
ClasspathURLConverter was introduced to solve such issues. Just override it in
you application and that's it. I'm also overriding this service in my OSGi apps
because in Equinox all classes have the protocol bundelresource.
> Add support for JBoss 5.x
> -
>
> Key: TAP5-576
> URL: https://issues.apache.org/jira/browse/TAP5-576
> Project: Tapestry 5
> Issue Type: Bug
> Components: tapestry-ioc
>Affects Versions: 5.0.18
>Reporter: Benjamin Bentmann
> Fix For: 5.1.0.2
>
> Attachments: TAP5-576.patch
>
>
> The class loaders of JBoss 5.x use URLs like
> {noformat}
> vfszip:/M:/jboss/jboss-5.0.1.GA/server/default/deploy/tapestry-test.war/WEB-INF/lib/tapestry-core-5.0.18.jar/org/apache/tapestry5/corelib/pages/
> {noformat}
> to point at class path resources. Tapestry is currently not capable of
> parsing these and as a result fails to find its own core components.
> This is related to the mail thread [JBoss5 and T5
> configuration?|http://www.mail-archive.com/us...@tapestry.apache.org/msg31403.html]
> a collegue of mine found. The approach outlined there yields URLs that point
> at non-existent files but served as an inspiration for our patch.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Created: (TAP5-580) Add get() method to TestBase to allow the read acces to private fields of objects via reflection
Add get() method to TestBase to allow the read acces to private fields of objects via reflection Key: TAP5-580 URL: https://issues.apache.org/jira/browse/TAP5-580 Project: Tapestry 5 Issue Type: New Feature Components: tapestry-ioc Affects Versions: 5.1.0.2 Reporter: Igor Drobiazko Similar to TAP5-275 but for read acces -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (TAP5-580) Add get() method to TestBase to allow the read acces to private fields of objects via reflection
[ https://issues.apache.org/jira/browse/TAP5-580?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Igor Drobiazko updated TAP5-580: Assignee: Igor Drobiazko Priority: Minor (was: Major) > Add get() method to TestBase to allow the read acces to private fields of > objects via reflection > > > Key: TAP5-580 > URL: https://issues.apache.org/jira/browse/TAP5-580 > Project: Tapestry 5 > Issue Type: New Feature > Components: tapestry-ioc >Affects Versions: 5.1.0.2 >Reporter: Igor Drobiazko >Assignee: Igor Drobiazko >Priority: Minor > > Similar to TAP5-275 but for read acces -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Created: (TAP5-653) Appending a context to an URL of the Index page results in too many slashes
Appending a context to an URL of the Index page results in too many slashes
---
Key: TAP5-653
URL: https://issues.apache.org/jira/browse/TAP5-653
Project: Tapestry 5
Issue Type: Bug
Components: tapestry-core
Affects Versions: 5.1.0.3
Reporter: Igor Drobiazko
Priority: Critical
When creating a page link to the Index page with a context, Tapestry creates a
link with two slashes after the context path
Example: /app//123
Because LinkImpl uses RequestPathOptimizer.optimizePath() inside the methode
toUri() the url is optimized to 123. So the link to the Index page will work.
But when you write a test for a page Foo (which contains a link to Index page)
with PageTester, the test will fail because RequestPathOptimizer does not cut
the url. The optimizer skips the optimization because in tests you can not use
SymbolConstants.FORCE_ABSOLUTE_URIS = false. PagesTestes throws an exception if
a path does not start with context path.
...
To fix the problem we have to check inside
ComponentEventLinkEncoderImpl.appendContext() if the url ends with a slash.
public void appendContext(EventContext context, StringBuilder builder)
{
String encoded = contextPathEncoder.encodeIntoPath(context);
if (encoded.length() > 0)
{
if(encoded.endsWith("/"))
{
builder.append(SLASH);
}
builder.append(encoded);
}
}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (TAP5-653) Appending a context to an URL of the Index page results in too many slashes
[
https://issues.apache.org/jira/browse/TAP5-653?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Igor Drobiazko updated TAP5-653:
Description:
When creating a page link to the Index page with a context, Tapestry creates a
link with two slashes after the context path
Example: /app//123
Because LinkImpl uses RequestPathOptimizer.optimizePath() inside the methode
toUri() the url is optimized to 123. So the link to the Index page will work.
But when you write a test for a page Foo (which contains a link to Index page)
with PageTester, the test will fail because RequestPathOptimizer does not cut
the url. The optimizer skips the optimization because in tests you can not use
SymbolConstants.FORCE_ABSOLUTE_URIS = false. PagesTestes throws an exception if
a path does not start with context path.
...
To fix the problem we have to check inside
ComponentEventLinkEncoderImpl.appendContext() if the url ends with a slash.
public void appendContext(EventContext context, StringBuilder builder)
{
String encoded = contextPathEncoder.encodeIntoPath(context);
if (encoded.length() > 0)
{
if(!encoded.endsWith(SLASH))
{
builder.append(SLASH);
}
builder.append(encoded);
}
}
was:
When creating a page link to the Index page with a context, Tapestry creates a
link with two slashes after the context path
Example: /app//123
Because LinkImpl uses RequestPathOptimizer.optimizePath() inside the methode
toUri() the url is optimized to 123. So the link to the Index page will work.
But when you write a test for a page Foo (which contains a link to Index page)
with PageTester, the test will fail because RequestPathOptimizer does not cut
the url. The optimizer skips the optimization because in tests you can not use
SymbolConstants.FORCE_ABSOLUTE_URIS = false. PagesTestes throws an exception if
a path does not start with context path.
...
To fix the problem we have to check inside
ComponentEventLinkEncoderImpl.appendContext() if the url ends with a slash.
public void appendContext(EventContext context, StringBuilder builder)
{
String encoded = contextPathEncoder.encodeIntoPath(context);
if (encoded.length() > 0)
{
if(encoded.endsWith("/"))
{
builder.append(SLASH);
}
builder.append(encoded);
}
}
> Appending a context to an URL of the Index page results in too many slashes
> ---
>
> Key: TAP5-653
> URL: https://issues.apache.org/jira/browse/TAP5-653
> Project: Tapestry 5
> Issue Type: Bug
> Components: tapestry-core
>Affects Versions: 5.1.0.3
>Reporter: Igor Drobiazko
>Priority: Critical
>
> When creating a page link to the Index page with a context, Tapestry creates
> a link with two slashes after the context path
> Example: /app//123
> Because LinkImpl uses RequestPathOptimizer.optimizePath() inside the methode
> toUri() the url is optimized to 123. So the link to the Index page will work.
> But when you write a test for a page Foo (which contains a link to Index
> page) with PageTester, the test will fail because RequestPathOptimizer does
> not cut the url. The optimizer skips the optimization because in tests you
> can not use SymbolConstants.FORCE_ABSOLUTE_URIS = false. PagesTestes throws
> an exception if a path does not start with context path.
> ...
> To fix the problem we have to check inside
> ComponentEventLinkEncoderImpl.appendContext() if the url ends with a slash.
> public void appendContext(EventContext context, StringBuilder builder)
> {
> String encoded = contextPathEncoder.encodeIntoPath(context);
> if (encoded.length() > 0)
> {
> if(!encoded.endsWith(SLASH))
> {
> builder.append(SLASH);
> }
> builder.append(encoded);
> }
> }
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (TAP5-713) Change template parser to not use STAX, as it is not (yet) compatible with Google App Engine
[ https://issues.apache.org/jira/browse/TAP5-713?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12711357#action_12711357 ] Igor Drobiazko commented on TAP5-713: - +1 for it. The woodstox's approach to FactoryFinder is a mess. It causes a lot of class loading problems in OSGi. I spent a lot of time migrating 5.0 Tapestry-OSGi bundle to 5.1. We should drop this dependency. > Change template parser to not use STAX, as it is not (yet) compatible with > Google App Engine > > > Key: TAP5-713 > URL: https://issues.apache.org/jira/browse/TAP5-713 > Project: Tapestry 5 > Issue Type: Improvement > Components: tapestry-core >Affects Versions: 5.1.0.5 >Reporter: Howard M. Lewis Ship > > The StAX APIs are not on the GAE "white list". > Should be reasonable ot change the code, by using a SAX parser that parses > the template into a list of tokens, and then iterate down the token list as > we do today using StAX. End result will be fewer dependencies to boot. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (TAP5-725) Last translator in configuration becomes default translator
[
https://issues.apache.org/jira/browse/TAP5-725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12713890#action_12713890
]
Igor Drobiazko commented on TAP5-725:
-
This is an expected behavior because you override the mapping String <->
StringTranslator by String <-> TrimTranslator.
You cannot define tow different translators for a single field type.
Your would your proposal match an appropriate translator for a field? Would you
use the name of the page property to match the translator? This will not work
if you have more than 2 fields of the same type.
You are misusing the translators. You should use Validators instead. I think we
can close the issue.
> Last translator in configuration becomes default translator
> ---
>
> Key: TAP5-725
> URL: https://issues.apache.org/jira/browse/TAP5-725
> Project: Tapestry 5
> Issue Type: Bug
> Components: tapestry-core
>Affects Versions: 5.1.0.5
>Reporter: Lukasz Jazgar
> Attachments: TrimTranslator.java
>
>
> I've created simple translator TrimTranslator, which works on String fields.
> It is same as StringTranslator. Only difference is it removes all white
> spaces at beginning and end of string. I will attach java source file of it.
> When I've contributed this translator to TranslatorSource service, new
> translator became default for type String. Every string value incoming from
> client is now trimmed. It's wrong. I expect new translator will work only
> when I explicitly declare it for form field component.
> As I see, historically (more than 1 year ago) there was 2 distinct services
> TranslatorSource and TranslatorDefaultSource. It was clear.
> Later they was joined to one. Why? Current TranslatorSource works fine only
> if there is one translator for every type or we want to override default
> translator. There is no possibility to create new alternative translators.
> Proposal of resolution:
> Maybe default translators for type should be distinguished by it's name
> property, which is unique, not only type?
> Default translators should have name same as name of type. So, "string" is
> default for java.lang.String, "boolean" is default for java.lang.Boolean, and
> so on. Any other like "trim" or "yesno" (example in jumpstart app) should
> need explicit declaration.
> It boils down to replacing in constructor of TranslatorSourceImpl:
> typeToTranslator.put(t.getType(), t);
> with:
> if (t.getType().getSimpleName().equalsIgnoreCase(t.getName()) {
> typeToTranslator.put(t.getType(), t);
> }
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (TAP5-570) tapestry-core should provide a built-in page to show the status of persistent data
[ https://issues.apache.org/jira/browse/TAP5-570?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12724212#action_12724212 ] Igor Drobiazko commented on TAP5-570: - Nice patch. Thank you. What about an integration test? Can also provide one? Also Strings should be move to a messages catalog. > tapestry-core should provide a built-in page to show the status of persistent > data > --- > > Key: TAP5-570 > URL: https://issues.apache.org/jira/browse/TAP5-570 > Project: Tapestry 5 > Issue Type: New Feature > Components: tapestry-core >Affects Versions: 5.1.0.1 >Reporter: Igor Drobiazko >Assignee: Igor Drobiazko > Attachments: TAP5-570.patch > > > In order to oprimize the amount of data persisted in the session via @Persist > or as ASO one should be able to get an overview of it. A page StateStatus > should be provided which could loo like: > Persistant Fields > - > Strategy Name | Page Name | Component Id | Field Name > - >flash |Login | loginform.form | > defaultTracker > --- >state | Foo| >| bar > > Application State Objects > -- > com.example.model.u...@ba8180[id=1,username=root,...] > -- > com.example.model.Foo1f6c439[bar=baz] > -- -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Assigned: (TAP5-226) Annotation to map a field to a specific session attribute
[
https://issues.apache.org/jira/browse/TAP5-226?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Igor Drobiazko reassigned TAP5-226:
---
Assignee: Igor Drobiazko
> Annotation to map a field to a specific session attribute
> -
>
> Key: TAP5-226
> URL: https://issues.apache.org/jira/browse/TAP5-226
> Project: Tapestry 5
> Issue Type: New Feature
> Components: tapestry-core
>Affects Versions: 5.1.0.0
>Reporter: Howard M. Lewis Ship
>Assignee: Igor Drobiazko
>Priority: Minor
>
> It would be great, for integration with existing T3/T4 or non-Tapestry apps,
> to have an easy way to map a field of a component to a specific session key.
> I.e.
> @SessionAttribute("user")
> private User user;
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (TAP5-226) Annotation to map a field to a specific session attribute
[
https://issues.apache.org/jira/browse/TAP5-226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12724215#action_12724215
]
Igor Drobiazko commented on TAP5-226:
-
I implemented this issue as an example for my book. I'll commit the changes at
the first opportunity.
> Annotation to map a field to a specific session attribute
> -
>
> Key: TAP5-226
> URL: https://issues.apache.org/jira/browse/TAP5-226
> Project: Tapestry 5
> Issue Type: New Feature
> Components: tapestry-core
>Affects Versions: 5.1.0.0
>Reporter: Howard M. Lewis Ship
>Assignee: Igor Drobiazko
>Priority: Minor
>
> It would be great, for integration with existing T3/T4 or non-Tapestry apps,
> to have an easy way to map a field of a component to a specific session key.
> I.e.
> @SessionAttribute("user")
> private User user;
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (TAP5-762) Upgrade Selenium dependencies to version 1.0.1
[ https://issues.apache.org/jira/browse/TAP5-762?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Igor Drobiazko reassigned TAP5-762: --- Assignee: Igor Drobiazko > Upgrade Selenium dependencies to version 1.0.1 > -- > > Key: TAP5-762 > URL: https://issues.apache.org/jira/browse/TAP5-762 > Project: Tapestry 5 > Issue Type: Improvement > Components: tapestry-test >Affects Versions: 5.1.0.5, 5.0.18 >Reporter: Igor Drobiazko >Assignee: Igor Drobiazko > -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Created: (TAP5-762) Upgrade Selenium dependencies to version 1.0.1
Upgrade Selenium dependencies to version 1.0.1 -- Key: TAP5-762 URL: https://issues.apache.org/jira/browse/TAP5-762 Project: Tapestry 5 Issue Type: Improvement Components: tapestry-test Affects Versions: 5.0.18, 5.1.0.5 Reporter: Igor Drobiazko -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Closed: (TAP5-762) Upgrade Selenium dependencies to version 1.0.1
[ https://issues.apache.org/jira/browse/TAP5-762?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Igor Drobiazko closed TAP5-762. --- Resolution: Fixed Fix Version/s: 5.2 > Upgrade Selenium dependencies to version 1.0.1 > -- > > Key: TAP5-762 > URL: https://issues.apache.org/jira/browse/TAP5-762 > Project: Tapestry 5 > Issue Type: Improvement > Components: tapestry-test >Affects Versions: 5.1.0.5, 5.0.18 >Reporter: Igor Drobiazko >Assignee: Igor Drobiazko > Fix For: 5.2 > > -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Assigned: (TAP5-556) Fix TranslatorSourceImplTest
[ https://issues.apache.org/jira/browse/TAP5-556?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Igor Drobiazko reassigned TAP5-556: --- Assignee: Igor Drobiazko > Fix TranslatorSourceImplTest > > > Key: TAP5-556 > URL: https://issues.apache.org/jira/browse/TAP5-556 > Project: Tapestry 5 > Issue Type: Bug > Components: tapestry-core >Reporter: Igor Drobiazko >Assignee: Igor Drobiazko > > SInce TAP5-540 is fixed I can't run TranslatorSourceImplTest. > to_client(org.apache.tapestry5.internal.services.TranslatorSourceImplTest) > Time elapsed: 0.031 sec <<< FAILURE! > java.lang.AssertionError: expected:<3.143> but was:<3,143> > at org.testng.Assert.fail(Assert.java:84) > at org.testng.Assert.failNotEquals(Assert.java:438) > at org.testng.Assert.assertEquals(Assert.java:108) > at org.testng.Assert.assertEquals(Assert.java:129) > at org.testng.Assert.assertEquals(Assert.java:139) > at > org.apache.tapestry5.internal.services.TranslatorSourceImplTest.to_client(TranslatorSourceImplTest.java:130) > to_client(org.apache.tapestry5.internal.services.TranslatorSourceImplTest) > Time elapsed: 0 sec <<< FAILURE! > java.lang.AssertionError: expected:<-22.7> but was:<-22,7> > at org.testng.Assert.fail(Assert.java:84) > at org.testng.Assert.failNotEquals(Assert.java:438) > at org.testng.Assert.assertEquals(Assert.java:108) > at org.testng.Assert.assertEquals(Assert.java:129) > at org.testng.Assert.assertEquals(Assert.java:139) > at > org.apache.tapestry5.internal.services.TranslatorSourceImplTest.to_client(TranslatorSourceImplTest.java:130) > to_client(org.apache.tapestry5.internal.services.TranslatorSourceImplTest) > Time elapsed: 0 sec <<< FAILURE! > java.lang.AssertionError: > expected:<-9876543219876543321987654321.12345123451234512345> but > was:<-9876543219876543321987654321,12345123451234512345> > at org.testng.Assert.fail(Assert.java:84) > at org.testng.Assert.failNotEquals(Assert.java:438) > at org.testng.Assert.assertEquals(Assert.java:108) > at org.testng.Assert.assertEquals(Assert.java:129) > at org.testng.Assert.assertEquals(Assert.java:139) > at > org.apache.tapestry5.internal.services.TranslatorSourceImplTest.to_client(TranslatorSourceImplTest.java:130) > parse_client(org.apache.tapestry5.internal.services.TranslatorSourceImplTest) > Time elapsed: 0.016 sec <<< FAILURE! > java.lang.AssertionError: expected:<2> but was:<20> > at org.testng.Assert.fail(Assert.java:84) > at org.testng.Assert.failNotEquals(Assert.java:438) > at org.testng.Assert.assertEquals(Assert.java:108) > at org.testng.Assert.assertEquals(Assert.java:118) > at > org.apache.tapestry5.internal.services.TranslatorSourceImplTest.parse_client(TranslatorSourceImplTest.java:169) > parse_client(org.apache.tapestry5.internal.services.TranslatorSourceImplTest) > Time elapsed: 0 sec <<< FAILURE! > java.lang.AssertionError: expected:<3.1428571429> but was:<3.1428571429E10> > at org.testng.Assert.fail(Assert.java:84) > at org.testng.Assert.failNotEquals(Assert.java:438) > at org.testng.Assert.assertEquals(Assert.java:108) > at org.testng.Assert.assertEquals(Assert.java:118) > at > org.apache.tapestry5.internal.services.TranslatorSourceImplTest.parse_client(TranslatorSourceImplTest.java:169) > parse_client(org.apache.tapestry5.internal.services.TranslatorSourceImplTest) > Time elapsed: 0 sec <<< FAILURE! > java.lang.AssertionError: expected:<28.95> but was:<2895.0> > at org.testng.Assert.fail(Assert.java:84) > at org.testng.Assert.failNotEquals(Assert.java:438) > at org.testng.Assert.assertEquals(Assert.java:108) > at org.testng.Assert.assertEquals(Assert.java:118) > at > org.apache.tapestry5.internal.services.TranslatorSourceImplTest.parse_client(TranslatorSourceImplTest.java:169) -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Closed: (TAP5-556) Fix TranslatorSourceImplTest
[ https://issues.apache.org/jira/browse/TAP5-556?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Igor Drobiazko closed TAP5-556. --- Resolution: Fixed Fix Version/s: 5.2 > Fix TranslatorSourceImplTest > > > Key: TAP5-556 > URL: https://issues.apache.org/jira/browse/TAP5-556 > Project: Tapestry 5 > Issue Type: Bug > Components: tapestry-core >Reporter: Igor Drobiazko >Assignee: Igor Drobiazko > Fix For: 5.2 > > > SInce TAP5-540 is fixed I can't run TranslatorSourceImplTest. > to_client(org.apache.tapestry5.internal.services.TranslatorSourceImplTest) > Time elapsed: 0.031 sec <<< FAILURE! > java.lang.AssertionError: expected:<3.143> but was:<3,143> > at org.testng.Assert.fail(Assert.java:84) > at org.testng.Assert.failNotEquals(Assert.java:438) > at org.testng.Assert.assertEquals(Assert.java:108) > at org.testng.Assert.assertEquals(Assert.java:129) > at org.testng.Assert.assertEquals(Assert.java:139) > at > org.apache.tapestry5.internal.services.TranslatorSourceImplTest.to_client(TranslatorSourceImplTest.java:130) > to_client(org.apache.tapestry5.internal.services.TranslatorSourceImplTest) > Time elapsed: 0 sec <<< FAILURE! > java.lang.AssertionError: expected:<-22.7> but was:<-22,7> > at org.testng.Assert.fail(Assert.java:84) > at org.testng.Assert.failNotEquals(Assert.java:438) > at org.testng.Assert.assertEquals(Assert.java:108) > at org.testng.Assert.assertEquals(Assert.java:129) > at org.testng.Assert.assertEquals(Assert.java:139) > at > org.apache.tapestry5.internal.services.TranslatorSourceImplTest.to_client(TranslatorSourceImplTest.java:130) > to_client(org.apache.tapestry5.internal.services.TranslatorSourceImplTest) > Time elapsed: 0 sec <<< FAILURE! > java.lang.AssertionError: > expected:<-9876543219876543321987654321.12345123451234512345> but > was:<-9876543219876543321987654321,12345123451234512345> > at org.testng.Assert.fail(Assert.java:84) > at org.testng.Assert.failNotEquals(Assert.java:438) > at org.testng.Assert.assertEquals(Assert.java:108) > at org.testng.Assert.assertEquals(Assert.java:129) > at org.testng.Assert.assertEquals(Assert.java:139) > at > org.apache.tapestry5.internal.services.TranslatorSourceImplTest.to_client(TranslatorSourceImplTest.java:130) > parse_client(org.apache.tapestry5.internal.services.TranslatorSourceImplTest) > Time elapsed: 0.016 sec <<< FAILURE! > java.lang.AssertionError: expected:<2> but was:<20> > at org.testng.Assert.fail(Assert.java:84) > at org.testng.Assert.failNotEquals(Assert.java:438) > at org.testng.Assert.assertEquals(Assert.java:108) > at org.testng.Assert.assertEquals(Assert.java:118) > at > org.apache.tapestry5.internal.services.TranslatorSourceImplTest.parse_client(TranslatorSourceImplTest.java:169) > parse_client(org.apache.tapestry5.internal.services.TranslatorSourceImplTest) > Time elapsed: 0 sec <<< FAILURE! > java.lang.AssertionError: expected:<3.1428571429> but was:<3.1428571429E10> > at org.testng.Assert.fail(Assert.java:84) > at org.testng.Assert.failNotEquals(Assert.java:438) > at org.testng.Assert.assertEquals(Assert.java:108) > at org.testng.Assert.assertEquals(Assert.java:118) > at > org.apache.tapestry5.internal.services.TranslatorSourceImplTest.parse_client(TranslatorSourceImplTest.java:169) > parse_client(org.apache.tapestry5.internal.services.TranslatorSourceImplTest) > Time elapsed: 0 sec <<< FAILURE! > java.lang.AssertionError: expected:<28.95> but was:<2895.0> > at org.testng.Assert.fail(Assert.java:84) > at org.testng.Assert.failNotEquals(Assert.java:438) > at org.testng.Assert.assertEquals(Assert.java:108) > at org.testng.Assert.assertEquals(Assert.java:118) > at > org.apache.tapestry5.internal.services.TranslatorSourceImplTest.parse_client(TranslatorSourceImplTest.java:169) -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Created: (TAP5-767) Fix PropertyConduitSourceImplTest
Fix PropertyConduitSourceImplTest - Key: TAP5-767 URL: https://issues.apache.org/jira/browse/TAP5-767 Project: Tapestry 5 Issue Type: Bug Components: tapestry-core Affects Versions: 5.2 Reporter: Igor Drobiazko --- Test set: TestSuite --- Tests run: 1401, Failures: 3, Errors: 0, Skipped: 0, Time elapsed: 371.469 sec <<< FAILURE! list_as_method_argument(org.apache.tapestry5.internal.services.PropertyConduitSourceImplTest) Time elapsed: 0.031 sec <<< FAILURE! java.lang.RuntimeException: Unable to add method java.lang.Object get(java.lang.Object) to class $PropertyConduit_12257586b97: [source error] ) is missing at org.apache.tapestry5.ioc.internal.services.ClassFabImpl.addMethod(ClassFabImpl.java:216) at org.apache.tapestry5.internal.services.PropertyConduitSourceImpl$PropertyConduitBuilder.createGetter(PropertyConduitSourceImpl.java:714) at org.apache.tapestry5.internal.services.PropertyConduitSourceImpl$PropertyConduitBuilder.createGetterAndSetter(PropertyConduitSourceImpl.java:424) at org.apache.tapestry5.internal.services.PropertyConduitSourceImpl$PropertyConduitBuilder.createAccessors(PropertyConduitSourceImpl.java:407) at org.apache.tapestry5.internal.services.PropertyConduitSourceImpl$PropertyConduitBuilder.createInstance(PropertyConduitSourceImpl.java:260) at org.apache.tapestry5.internal.services.PropertyConduitSourceImpl.build(PropertyConduitSourceImpl.java:1205) at org.apache.tapestry5.internal.services.PropertyConduitSourceImpl.create(PropertyConduitSourceImpl.java:1080) at $PropertyConduitSource_12257586b25.create($PropertyConduitSource_12257586b25.java) at org.apache.tapestry5.internal.services.PropertyConduitSourceImplTest.list_as_method_argument(PropertyConduitSourceImplTest.java:363) Caused by: javassist.CannotCompileException: [source error] ) is missing at javassist.CtBehavior.setBody(CtBehavior.java:368) at javassist.CtBehavior.setBody(CtBehavior.java:334) at org.apache.tapestry5.ioc.internal.services.ClassFabImpl.addMethod(ClassFabImpl.java:209) ... 37 more Caused by: compile error: ) is missing at javassist.compiler.Parser.parseArgumentList(Parser.java:1337) at javassist.compiler.Parser.parseMethodCall(Parser.java:1177) at javassist.compiler.Parser.parsePostfix(Parser.java:1034) at javassist.compiler.Parser.parseUnaryExpr(Parser.java:887) at javassist.compiler.Parser.parseBinaryExpr(Parser.java:774) at javassist.compiler.Parser.parseConditionalExpr(Parser.java:718) at javassist.compiler.Parser.parseExpression(Parser.java:698) at javassist.compiler.Parser.parseDeclarationOrExpression(Parser.java:590) at javassist.compiler.Parser.parseStatement(Parser.java:276) at javassist.compiler.Parser.parseBlock(Parser.java:288) at javassist.compiler.Parser.parseStatement(Parser.java:242) at javassist.compiler.Javac.compileBody(Javac.java:213) at javassist.CtBehavior.setBody(CtBehavior.java:360) ... 39 more method_invocation_with_double_argument(org.apache.tapestry5.internal.services.PropertyConduitSourceImplTest) Time elapsed: 0.015 sec <<< FAILURE! java.lang.RuntimeException: Unable to add method java.lang.Object get(java.lang.Object) to class $PropertyConduit_12257586b9c: [source error] ) is missing at org.apache.tapestry5.ioc.internal.services.ClassFabImpl.addMethod(ClassFabImpl.java:216) at org.apache.tapestry5.internal.services.PropertyConduitSourceImpl$PropertyConduitBuilder.createGetter(PropertyConduitSourceImpl.java:714) at org.apache.tapestry5.internal.services.PropertyConduitSourceImpl$PropertyConduitBuilder.createGetterAndSetter(PropertyConduitSourceImpl.java:424) at org.apache.tapestry5.internal.services.PropertyConduitSourceImpl$PropertyConduitBuilder.createAccessors(PropertyConduitSourceImpl.java:407) at org.apache.tapestry5.internal.services.PropertyConduitSourceImpl$PropertyConduitBuilder.createInstance(PropertyConduitSourceImpl.java:260) at org.apache.tapestry5.internal.services.PropertyConduitSourceImpl.build(PropertyConduitSourceImpl.java:1205) at org.apache.tapestry5.internal.services.PropertyConduitSourceImpl.create(PropertyConduitSourceImpl.java:1080) at $PropertyConduitSource_12257586b25.create($PropertyConduitSource_12257586b25.java) at org.apache.tapestry5.internal.services.PropertyConduitSourceImplTest.method_invocation_with_double_argument(PropertyConduitSourceImplTest.java:299) Caused by: javassist.CannotCompileException: [source error] ) is missing at javassist.CtBehavior.setBody(CtBe
[jira] Assigned: (TAP5-767) Fix PropertyConduitSourceImplTest
[ https://issues.apache.org/jira/browse/TAP5-767?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Igor Drobiazko reassigned TAP5-767: --- Assignee: Igor Drobiazko > Fix PropertyConduitSourceImplTest > - > > Key: TAP5-767 > URL: https://issues.apache.org/jira/browse/TAP5-767 > Project: Tapestry 5 > Issue Type: Bug > Components: tapestry-core >Affects Versions: 5.2 >Reporter: Igor Drobiazko >Assignee: Igor Drobiazko > > --- > Test set: TestSuite > --- > Tests run: 1401, Failures: 3, Errors: 0, Skipped: 0, Time elapsed: 371.469 > sec <<< FAILURE! > list_as_method_argument(org.apache.tapestry5.internal.services.PropertyConduitSourceImplTest) > Time elapsed: 0.031 sec <<< FAILURE! > java.lang.RuntimeException: Unable to add method java.lang.Object > get(java.lang.Object) to class $PropertyConduit_12257586b97: [source error] ) > is missing > at > org.apache.tapestry5.ioc.internal.services.ClassFabImpl.addMethod(ClassFabImpl.java:216) > at > org.apache.tapestry5.internal.services.PropertyConduitSourceImpl$PropertyConduitBuilder.createGetter(PropertyConduitSourceImpl.java:714) > at > org.apache.tapestry5.internal.services.PropertyConduitSourceImpl$PropertyConduitBuilder.createGetterAndSetter(PropertyConduitSourceImpl.java:424) > at > org.apache.tapestry5.internal.services.PropertyConduitSourceImpl$PropertyConduitBuilder.createAccessors(PropertyConduitSourceImpl.java:407) > at > org.apache.tapestry5.internal.services.PropertyConduitSourceImpl$PropertyConduitBuilder.createInstance(PropertyConduitSourceImpl.java:260) > at > org.apache.tapestry5.internal.services.PropertyConduitSourceImpl.build(PropertyConduitSourceImpl.java:1205) > at > org.apache.tapestry5.internal.services.PropertyConduitSourceImpl.create(PropertyConduitSourceImpl.java:1080) > at > $PropertyConduitSource_12257586b25.create($PropertyConduitSource_12257586b25.java) > at > org.apache.tapestry5.internal.services.PropertyConduitSourceImplTest.list_as_method_argument(PropertyConduitSourceImplTest.java:363) > Caused by: javassist.CannotCompileException: [source error] ) is missing > at javassist.CtBehavior.setBody(CtBehavior.java:368) > at javassist.CtBehavior.setBody(CtBehavior.java:334) > at > org.apache.tapestry5.ioc.internal.services.ClassFabImpl.addMethod(ClassFabImpl.java:209) > ... 37 more > Caused by: compile error: ) is missing > at javassist.compiler.Parser.parseArgumentList(Parser.java:1337) > at javassist.compiler.Parser.parseMethodCall(Parser.java:1177) > at javassist.compiler.Parser.parsePostfix(Parser.java:1034) > at javassist.compiler.Parser.parseUnaryExpr(Parser.java:887) > at javassist.compiler.Parser.parseBinaryExpr(Parser.java:774) > at javassist.compiler.Parser.parseConditionalExpr(Parser.java:718) > at javassist.compiler.Parser.parseExpression(Parser.java:698) > at > javassist.compiler.Parser.parseDeclarationOrExpression(Parser.java:590) > at javassist.compiler.Parser.parseStatement(Parser.java:276) > at javassist.compiler.Parser.parseBlock(Parser.java:288) > at javassist.compiler.Parser.parseStatement(Parser.java:242) > at javassist.compiler.Javac.compileBody(Javac.java:213) > at javassist.CtBehavior.setBody(CtBehavior.java:360) > ... 39 more > method_invocation_with_double_argument(org.apache.tapestry5.internal.services.PropertyConduitSourceImplTest) > Time elapsed: 0.015 sec <<< FAILURE! > java.lang.RuntimeException: Unable to add method java.lang.Object > get(java.lang.Object) to class $PropertyConduit_12257586b9c: [source error] ) > is missing > at > org.apache.tapestry5.ioc.internal.services.ClassFabImpl.addMethod(ClassFabImpl.java:216) > at > org.apache.tapestry5.internal.services.PropertyConduitSourceImpl$PropertyConduitBuilder.createGetter(PropertyConduitSourceImpl.java:714) > at > org.apache.tapestry5.internal.services.PropertyConduitSourceImpl$PropertyConduitBuilder.createGetterAndSetter(PropertyConduitSourceImpl.java:424) > at > org.apache.tapestry5.internal.services.PropertyConduitSourceImpl$PropertyConduitBuilder.createAccessors(PropertyConduitSourceImpl.java:407) > at > org.apache.tapestry5.internal.services.PropertyConduitSourceImpl$PropertyConduitBuilder.createInstance(PropertyConduitSourceImpl.java:260) > at > org.apache.tapestry5.internal.services.PropertyConduitSourceImpl.build(PropertyConduitSourceImpl.java:1205) > at > org.apache.tapestry5.internal.services.PropertyConduitSourceImpl.create(PropertyConduitSourceImpl.java:1080) > at > $PropertyC
[jira] Updated: (TAP5-767) PropertyConduitSourceImpl should use english locale (instead of default locale) when evaluating decimals
[ https://issues.apache.org/jira/browse/TAP5-767?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Igor Drobiazko updated TAP5-767: Summary: PropertyConduitSourceImpl should use english locale (instead of default locale) when evaluating decimals (was: Fix PropertyConduitSourceImplTest) > PropertyConduitSourceImpl should use english locale (instead of default > locale) when evaluating decimals > > > Key: TAP5-767 > URL: https://issues.apache.org/jira/browse/TAP5-767 > Project: Tapestry 5 > Issue Type: Bug > Components: tapestry-core >Affects Versions: 5.2 >Reporter: Igor Drobiazko >Assignee: Igor Drobiazko > > --- > Test set: TestSuite > --- > Tests run: 1401, Failures: 3, Errors: 0, Skipped: 0, Time elapsed: 371.469 > sec <<< FAILURE! > list_as_method_argument(org.apache.tapestry5.internal.services.PropertyConduitSourceImplTest) > Time elapsed: 0.031 sec <<< FAILURE! > java.lang.RuntimeException: Unable to add method java.lang.Object > get(java.lang.Object) to class $PropertyConduit_12257586b97: [source error] ) > is missing > at > org.apache.tapestry5.ioc.internal.services.ClassFabImpl.addMethod(ClassFabImpl.java:216) > at > org.apache.tapestry5.internal.services.PropertyConduitSourceImpl$PropertyConduitBuilder.createGetter(PropertyConduitSourceImpl.java:714) > at > org.apache.tapestry5.internal.services.PropertyConduitSourceImpl$PropertyConduitBuilder.createGetterAndSetter(PropertyConduitSourceImpl.java:424) > at > org.apache.tapestry5.internal.services.PropertyConduitSourceImpl$PropertyConduitBuilder.createAccessors(PropertyConduitSourceImpl.java:407) > at > org.apache.tapestry5.internal.services.PropertyConduitSourceImpl$PropertyConduitBuilder.createInstance(PropertyConduitSourceImpl.java:260) > at > org.apache.tapestry5.internal.services.PropertyConduitSourceImpl.build(PropertyConduitSourceImpl.java:1205) > at > org.apache.tapestry5.internal.services.PropertyConduitSourceImpl.create(PropertyConduitSourceImpl.java:1080) > at > $PropertyConduitSource_12257586b25.create($PropertyConduitSource_12257586b25.java) > at > org.apache.tapestry5.internal.services.PropertyConduitSourceImplTest.list_as_method_argument(PropertyConduitSourceImplTest.java:363) > Caused by: javassist.CannotCompileException: [source error] ) is missing > at javassist.CtBehavior.setBody(CtBehavior.java:368) > at javassist.CtBehavior.setBody(CtBehavior.java:334) > at > org.apache.tapestry5.ioc.internal.services.ClassFabImpl.addMethod(ClassFabImpl.java:209) > ... 37 more > Caused by: compile error: ) is missing > at javassist.compiler.Parser.parseArgumentList(Parser.java:1337) > at javassist.compiler.Parser.parseMethodCall(Parser.java:1177) > at javassist.compiler.Parser.parsePostfix(Parser.java:1034) > at javassist.compiler.Parser.parseUnaryExpr(Parser.java:887) > at javassist.compiler.Parser.parseBinaryExpr(Parser.java:774) > at javassist.compiler.Parser.parseConditionalExpr(Parser.java:718) > at javassist.compiler.Parser.parseExpression(Parser.java:698) > at > javassist.compiler.Parser.parseDeclarationOrExpression(Parser.java:590) > at javassist.compiler.Parser.parseStatement(Parser.java:276) > at javassist.compiler.Parser.parseBlock(Parser.java:288) > at javassist.compiler.Parser.parseStatement(Parser.java:242) > at javassist.compiler.Javac.compileBody(Javac.java:213) > at javassist.CtBehavior.setBody(CtBehavior.java:360) > ... 39 more > method_invocation_with_double_argument(org.apache.tapestry5.internal.services.PropertyConduitSourceImplTest) > Time elapsed: 0.015 sec <<< FAILURE! > java.lang.RuntimeException: Unable to add method java.lang.Object > get(java.lang.Object) to class $PropertyConduit_12257586b9c: [source error] ) > is missing > at > org.apache.tapestry5.ioc.internal.services.ClassFabImpl.addMethod(ClassFabImpl.java:216) > at > org.apache.tapestry5.internal.services.PropertyConduitSourceImpl$PropertyConduitBuilder.createGetter(PropertyConduitSourceImpl.java:714) > at > org.apache.tapestry5.internal.services.PropertyConduitSourceImpl$PropertyConduitBuilder.createGetterAndSetter(PropertyConduitSourceImpl.java:424) > at > org.apache.tapestry5.internal.services.PropertyConduitSourceImpl$PropertyConduitBuilder.createAccessors(PropertyConduitSourceImpl.java:407) > at > org.apache.tapestry5.internal.services.PropertyConduitSourceImpl$PropertyConduitBuilder.createInstance(PropertyConduitSourceImpl.java:26
[jira] Closed: (TAP5-767) PropertyConduitSourceImpl should use english locale (instead of default locale) when evaluating decimals
[ https://issues.apache.org/jira/browse/TAP5-767?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Igor Drobiazko closed TAP5-767. --- Resolution: Fixed Fix Version/s: 5.2 > PropertyConduitSourceImpl should use english locale (instead of default > locale) when evaluating decimals > > > Key: TAP5-767 > URL: https://issues.apache.org/jira/browse/TAP5-767 > Project: Tapestry 5 > Issue Type: Bug > Components: tapestry-core >Affects Versions: 5.2 >Reporter: Igor Drobiazko >Assignee: Igor Drobiazko > Fix For: 5.2 > > > --- > Test set: TestSuite > --- > Tests run: 1401, Failures: 3, Errors: 0, Skipped: 0, Time elapsed: 371.469 > sec <<< FAILURE! > list_as_method_argument(org.apache.tapestry5.internal.services.PropertyConduitSourceImplTest) > Time elapsed: 0.031 sec <<< FAILURE! > java.lang.RuntimeException: Unable to add method java.lang.Object > get(java.lang.Object) to class $PropertyConduit_12257586b97: [source error] ) > is missing > at > org.apache.tapestry5.ioc.internal.services.ClassFabImpl.addMethod(ClassFabImpl.java:216) > at > org.apache.tapestry5.internal.services.PropertyConduitSourceImpl$PropertyConduitBuilder.createGetter(PropertyConduitSourceImpl.java:714) > at > org.apache.tapestry5.internal.services.PropertyConduitSourceImpl$PropertyConduitBuilder.createGetterAndSetter(PropertyConduitSourceImpl.java:424) > at > org.apache.tapestry5.internal.services.PropertyConduitSourceImpl$PropertyConduitBuilder.createAccessors(PropertyConduitSourceImpl.java:407) > at > org.apache.tapestry5.internal.services.PropertyConduitSourceImpl$PropertyConduitBuilder.createInstance(PropertyConduitSourceImpl.java:260) > at > org.apache.tapestry5.internal.services.PropertyConduitSourceImpl.build(PropertyConduitSourceImpl.java:1205) > at > org.apache.tapestry5.internal.services.PropertyConduitSourceImpl.create(PropertyConduitSourceImpl.java:1080) > at > $PropertyConduitSource_12257586b25.create($PropertyConduitSource_12257586b25.java) > at > org.apache.tapestry5.internal.services.PropertyConduitSourceImplTest.list_as_method_argument(PropertyConduitSourceImplTest.java:363) > Caused by: javassist.CannotCompileException: [source error] ) is missing > at javassist.CtBehavior.setBody(CtBehavior.java:368) > at javassist.CtBehavior.setBody(CtBehavior.java:334) > at > org.apache.tapestry5.ioc.internal.services.ClassFabImpl.addMethod(ClassFabImpl.java:209) > ... 37 more > Caused by: compile error: ) is missing > at javassist.compiler.Parser.parseArgumentList(Parser.java:1337) > at javassist.compiler.Parser.parseMethodCall(Parser.java:1177) > at javassist.compiler.Parser.parsePostfix(Parser.java:1034) > at javassist.compiler.Parser.parseUnaryExpr(Parser.java:887) > at javassist.compiler.Parser.parseBinaryExpr(Parser.java:774) > at javassist.compiler.Parser.parseConditionalExpr(Parser.java:718) > at javassist.compiler.Parser.parseExpression(Parser.java:698) > at > javassist.compiler.Parser.parseDeclarationOrExpression(Parser.java:590) > at javassist.compiler.Parser.parseStatement(Parser.java:276) > at javassist.compiler.Parser.parseBlock(Parser.java:288) > at javassist.compiler.Parser.parseStatement(Parser.java:242) > at javassist.compiler.Javac.compileBody(Javac.java:213) > at javassist.CtBehavior.setBody(CtBehavior.java:360) > ... 39 more > method_invocation_with_double_argument(org.apache.tapestry5.internal.services.PropertyConduitSourceImplTest) > Time elapsed: 0.015 sec <<< FAILURE! > java.lang.RuntimeException: Unable to add method java.lang.Object > get(java.lang.Object) to class $PropertyConduit_12257586b9c: [source error] ) > is missing > at > org.apache.tapestry5.ioc.internal.services.ClassFabImpl.addMethod(ClassFabImpl.java:216) > at > org.apache.tapestry5.internal.services.PropertyConduitSourceImpl$PropertyConduitBuilder.createGetter(PropertyConduitSourceImpl.java:714) > at > org.apache.tapestry5.internal.services.PropertyConduitSourceImpl$PropertyConduitBuilder.createGetterAndSetter(PropertyConduitSourceImpl.java:424) > at > org.apache.tapestry5.internal.services.PropertyConduitSourceImpl$PropertyConduitBuilder.createAccessors(PropertyConduitSourceImpl.java:407) > at > org.apache.tapestry5.internal.services.PropertyConduitSourceImpl$PropertyConduitBuilder.createInstance(PropertyConduitSourceImpl.java:260) > at > org.apache.tapestry5.internal.services.PropertyConduitSourceImpl.build
[jira] Updated: (TAP5-226) Add annotation @SessionAttribute to map a field to a specific session attribute
[
https://issues.apache.org/jira/browse/TAP5-226?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Igor Drobiazko updated TAP5-226:
Summary: Add annotation @SessionAttribute to map a field to a specific
session attribute (was: Annotation to map a field to a specific session
attribute)
> Add annotation @SessionAttribute to map a field to a specific session
> attribute
> ---
>
> Key: TAP5-226
> URL: https://issues.apache.org/jira/browse/TAP5-226
> Project: Tapestry 5
> Issue Type: New Feature
> Components: tapestry-core
>Affects Versions: 5.1.0.0
>Reporter: Howard M. Lewis Ship
>Assignee: Igor Drobiazko
>Priority: Minor
>
> It would be great, for integration with existing T3/T4 or non-Tapestry apps,
> to have an easy way to map a field of a component to a specific session key.
> I.e.
> @SessionAttribute("user")
> private User user;
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (TAP5-226) Add annotation @SessionAttribute to map a field to a specific session attribute
[
https://issues.apache.org/jira/browse/TAP5-226?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Igor Drobiazko closed TAP5-226.
---
Resolution: Fixed
Fix Version/s: 5.2
> Add annotation @SessionAttribute to map a field to a specific session
> attribute
> ---
>
> Key: TAP5-226
> URL: https://issues.apache.org/jira/browse/TAP5-226
> Project: Tapestry 5
> Issue Type: New Feature
> Components: tapestry-core
>Affects Versions: 5.1.0.0
>Reporter: Howard M. Lewis Ship
>Assignee: Igor Drobiazko
>Priority: Minor
> Fix For: 5.2
>
>
> It would be great, for integration with existing T3/T4 or non-Tapestry apps,
> to have an easy way to map a field of a component to a specific session key.
> I.e.
> @SessionAttribute("user")
> private User user;
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (TAP5-778) BeanDisplay should be able to display properties of type list, map, etc,
[ https://issues.apache.org/jira/browse/TAP5-778?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Igor Drobiazko updated TAP5-778: Priority: Minor (was: Major) > BeanDisplay should be able to display properties of type list, map, etc, > > > Key: TAP5-778 > URL: https://issues.apache.org/jira/browse/TAP5-778 > Project: Tapestry 5 > Issue Type: Improvement > Components: tapestry-core >Affects Versions: 5.1.0.0 >Reporter: Igor Drobiazko >Priority: Minor > > Additional annotation is probably needed to indicate the maximal size of the > collection to display? > @MaxVisualSize(5) > private List foos; -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Created: (TAP5-778) BeanDisplay should be able to display properties of type list, map, etc,
BeanDisplay should be able to display properties of type list, map, etc, Key: TAP5-778 URL: https://issues.apache.org/jira/browse/TAP5-778 Project: Tapestry 5 Issue Type: Improvement Components: tapestry-core Affects Versions: 5.1.0.0 Reporter: Igor Drobiazko Additional annotation is probably needed to indicate the maximal size of the collection to display? @MaxVisualSize(5) private List foos; -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Created: (TAP5-781) ValidationTracker should be able to record the same error message for several fields
ValidationTracker should be able to record the same error message for several fields Key: TAP5-781 URL: https://issues.apache.org/jira/browse/TAP5-781 Project: Tapestry 5 Issue Type: Improvement Components: tapestry-core Affects Versions: 5.1.0.0, 5.2 Reporter: Igor Drobiazko Priority: Minor In registration forms usually two password fields are used to force a user to input the password twice. When the inputs of the both password fields differ, one should record an error message for both of them. Unfortunately it is not possible now. It would be nice to have a method like: ValidationTracker#void recordError(Field field[], String errorMessage) -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Assigned: (TAP5-789) Provide bean and display blocks for java.util.Calendar
[ https://issues.apache.org/jira/browse/TAP5-789?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Igor Drobiazko reassigned TAP5-789: --- Assignee: Igor Drobiazko > Provide bean and display blocks for java.util.Calendar > -- > > Key: TAP5-789 > URL: https://issues.apache.org/jira/browse/TAP5-789 > Project: Tapestry 5 > Issue Type: Improvement > Components: tapestry-core >Affects Versions: 5.2.0.0 >Reporter: Igor Drobiazko >Assignee: Igor Drobiazko >Priority: Minor > > Add new blocks into the pages PropertyEditBlocks and PropertyDisplayBlocks > that delegate to date blocks. > Also a coercion from java.util.Date into java.util.Calendar and vice versa > is needed. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Created: (TAP5-789) Provide bean and display blocks for java.util.Calendar
Provide bean and display blocks for java.util.Calendar -- Key: TAP5-789 URL: https://issues.apache.org/jira/browse/TAP5-789 Project: Tapestry 5 Issue Type: Improvement Components: tapestry-core Affects Versions: 5.2.0.0 Reporter: Igor Drobiazko Priority: Minor Add new blocks into the pages PropertyEditBlocks and PropertyDisplayBlocks that delegate to date blocks. Also a coercion from java.util.Date into java.util.Calendar and vice versa is needed. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Created: (TAP5-790) Provide ApplicationStatePersistenceStrategy for Hibernate entities
Provide ApplicationStatePersistenceStrategy for Hibernate entities --- Key: TAP5-790 URL: https://issues.apache.org/jira/browse/TAP5-790 Project: Tapestry 5 Issue Type: Improvement Components: tapestry-hibernate Affects Versions: 5.2.0.0 Reporter: Igor Drobiazko Persisting a hibernate entity in HttpSession is not good idea because the entity becomes detached from the Hibernate session. It would be nice to have a ApplicationStatePersistenceStrategy which stores only the primary key of the entity into the session. This strategy should make use of the class PersistedEntity like EntityPersistentFieldStrategy does. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Assigned: (TAP5-790) Provide ApplicationStatePersistenceStrategy for Hibernate entities
[ https://issues.apache.org/jira/browse/TAP5-790?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Igor Drobiazko reassigned TAP5-790: --- Assignee: Igor Drobiazko > Provide ApplicationStatePersistenceStrategy for Hibernate entities > --- > > Key: TAP5-790 > URL: https://issues.apache.org/jira/browse/TAP5-790 > Project: Tapestry 5 > Issue Type: Improvement > Components: tapestry-hibernate >Affects Versions: 5.2.0.0 >Reporter: Igor Drobiazko >Assignee: Igor Drobiazko > > Persisting a hibernate entity in HttpSession is not good idea because the > entity becomes detached from the Hibernate session. > It would be nice to have a ApplicationStatePersistenceStrategy which stores > only the primary key of the entity into the session. > This strategy should make use of the class PersistedEntity like > EntityPersistentFieldStrategy does. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Closed: (TAP5-789) Provide bean and display blocks for java.util.Calendar
[ https://issues.apache.org/jira/browse/TAP5-789?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Igor Drobiazko closed TAP5-789. --- Resolution: Fixed Fix Version/s: 5.2.0.0 > Provide bean and display blocks for java.util.Calendar > -- > > Key: TAP5-789 > URL: https://issues.apache.org/jira/browse/TAP5-789 > Project: Tapestry 5 > Issue Type: Improvement > Components: tapestry-core >Affects Versions: 5.2.0.0 >Reporter: Igor Drobiazko >Assignee: Igor Drobiazko >Priority: Minor > Fix For: 5.2.0.0 > > > Add new blocks into the pages PropertyEditBlocks and PropertyDisplayBlocks > that delegate to date blocks. > Also a coercion from java.util.Date into java.util.Calendar and vice versa > is needed. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Assigned: (TAP5-678) Allow blackbird to be disabled in production mode
[ https://issues.apache.org/jira/browse/TAP5-678?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Igor Drobiazko reassigned TAP5-678: --- Assignee: Igor Drobiazko > Allow blackbird to be disabled in production mode > - > > Key: TAP5-678 > URL: https://issues.apache.org/jira/browse/TAP5-678 > Project: Tapestry 5 > Issue Type: Improvement > Components: tapestry-core >Affects Versions: 5.2 >Reporter: Paudi Moriarty >Assignee: Igor Drobiazko > > blackbird's use of F2 to show the console is interfering with our application > which uses F-keys as hotkeys to access various parts of the application. > It should be possible to either completely disable blackbird in production > mode (avoiding unnecessary .css and .js downloads) or at least disable the > console hotkey. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Assigned: (TAP5-801) TriggerEvent component to trigger a component event during rendering
[
https://issues.apache.org/jira/browse/TAP5-801?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Igor Drobiazko reassigned TAP5-801:
---
Assignee: Igor Drobiazko
> TriggerEvent component to trigger a component event during rendering
>
>
> Key: TAP5-801
> URL: https://issues.apache.org/jira/browse/TAP5-801
> Project: Tapestry 5
> Issue Type: New Feature
> Components: tapestry-component-report
>Affects Versions: 5.1.0.5
>Reporter: Howard M. Lewis Ship
>Assignee: Igor Drobiazko
>Priority: Minor
>
> It would be nice if it were possible to trigger an arbitrary component event
> during rendering; this is often useful to add JavaScript to a page (via calls
> to the RenderSupport environmental).
> Currently this can be accomplished using Delegator and providing a Renderable
> object (as an anonymous inner class) ... but that's ugly, i.e.
>
> public Renderable getWireEventHandlers()
> {
> return new Renderable()
> {
> public void render(MarkupWriter writer)
>{
> ...
>}
> };
> }
> I would rather something like:
>
> void onWireEventHandlers()
> {
> ...
> }
> The MarkupWriter could be passed as the event context, for handlers that need
> to write markup as well as perform other functions.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (TAP5-817) When sending muliple page requests very fast (using browser refresh button or pressing a link), for the first time a page is loaded, cause Tapestry to crash and become unr
[ https://issues.apache.org/jira/browse/TAP5-817?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12745362#action_12745362 ] Igor Drobiazko commented on TAP5-817: - I cannot reproduce the described bahaviour. I tried it on 3 sytems: my local mashine, test system and production system. > When sending muliple page requests very fast (using browser refresh button or > pressing a link), for the first time a page is loaded, cause Tapestry to > crash and become unresponsive. > - > > Key: TAP5-817 > URL: https://issues.apache.org/jira/browse/TAP5-817 > Project: Tapestry 5 > Issue Type: Bug > Components: tapestry-core >Affects Versions: 5.1.0.5 >Reporter: Mario Luis Gomes Cavalcanti >Priority: Blocker > > When sending muliple page requests very fast (using browser refresh button or > pressing a link), for the first time a page is loaded, cause Tapestry to > crash and become unresponsive. > Steps to reproduce: > 1: Have a very simple page containing just some text or a slow loading page > to make it easier to reproduce. > 2: Restart the web server so there are no pages in the memory. > 3: Send multiple requests for the page, very fast using the refresh button or > pressing a link multiple times. > Result = Tapestry never returns the page and becomes unresponsive. > The bug is happening to all the pages on my website, but only if the page has > not been previoulsy loaded, e.q, the page is not already in memory. > For simple fast loading pages, you have to press the link/refresh button very > fast and many, many times. For slower loading pages it is easier to reproduce > the bug. > I am running tapestry 5.10.5 on a Sun Web Server 7 on Windows XP. > This is a very serious bug!!! I cant go to production with this bug. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Created: (TAP5-823) Message about incompatible return type of a render phase method is misleading
Message about incompatible return type of a render phase method is misleading - Key: TAP5-823 URL: https://issues.apache.org/jira/browse/TAP5-823 Project: Tapestry 5 Issue Type: Bug Components: tapestry-core Affects Versions: 5.2.0.0 Reporter: Igor Drobiazko Returning an incompatible type in a render phase method results in a following exception: "The return value from a render phase event method was not compatible the expected return type of java.lang.Boolean. You should change the method to return the correct type." The message of the exception is misleading because org.apache.tapestry5.internal.structure.RenderPhaseEventHandler also accepts RenderCommand and Renderable as return types. The message should be fixed. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (TAP5-801) Add Trigger component to trigger a component event during rendering
[
https://issues.apache.org/jira/browse/TAP5-801?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Igor Drobiazko updated TAP5-801:
Summary: Add Trigger component to trigger a component event during
rendering (was: TriggerEvent component to trigger a component event during
rendering)
> Add Trigger component to trigger a component event during rendering
> ---
>
> Key: TAP5-801
> URL: https://issues.apache.org/jira/browse/TAP5-801
> Project: Tapestry 5
> Issue Type: New Feature
> Components: tapestry-component-report
>Affects Versions: 5.1.0.5
>Reporter: Howard M. Lewis Ship
>Assignee: Igor Drobiazko
>Priority: Minor
>
> It would be nice if it were possible to trigger an arbitrary component event
> during rendering; this is often useful to add JavaScript to a page (via calls
> to the RenderSupport environmental).
> Currently this can be accomplished using Delegator and providing a Renderable
> object (as an anonymous inner class) ... but that's ugly, i.e.
>
> public Renderable getWireEventHandlers()
> {
> return new Renderable()
> {
> public void render(MarkupWriter writer)
>{
> ...
>}
> };
> }
> I would rather something like:
>
> void onWireEventHandlers()
> {
> ...
> }
> The MarkupWriter could be passed as the event context, for handlers that need
> to write markup as well as perform other functions.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (TAP5-801) Add Trigger component to trigger a component event during rendering
[
https://issues.apache.org/jira/browse/TAP5-801?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Igor Drobiazko closed TAP5-801.
---
Resolution: Fixed
Fix Version/s: 5.2.0.0
> Add Trigger component to trigger a component event during rendering
> ---
>
> Key: TAP5-801
> URL: https://issues.apache.org/jira/browse/TAP5-801
> Project: Tapestry 5
> Issue Type: New Feature
> Components: tapestry-component-report
>Affects Versions: 5.1.0.5
>Reporter: Howard M. Lewis Ship
>Assignee: Igor Drobiazko
>Priority: Minor
> Fix For: 5.2.0.0
>
>
> It would be nice if it were possible to trigger an arbitrary component event
> during rendering; this is often useful to add JavaScript to a page (via calls
> to the RenderSupport environmental).
> Currently this can be accomplished using Delegator and providing a Renderable
> object (as an anonymous inner class) ... but that's ugly, i.e.
>
> public Renderable getWireEventHandlers()
> {
> return new Renderable()
> {
> public void render(MarkupWriter writer)
>{
> ...
>}
> };
> }
> I would rather something like:
>
> void onWireEventHandlers()
> {
> ...
> }
> The MarkupWriter could be passed as the event context, for handlers that need
> to write markup as well as perform other functions.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (TAP5-814) include a diagram showing how incoming requests pass through the different pipelines, filters and dispatchers
[ https://issues.apache.org/jira/browse/TAP5-814?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Igor Drobiazko reassigned TAP5-814: --- Assignee: Igor Drobiazko > include a diagram showing how incoming requests pass through the different > pipelines, filters and dispatchers > - > > Key: TAP5-814 > URL: https://issues.apache.org/jira/browse/TAP5-814 > Project: Tapestry 5 > Issue Type: Improvement > Components: documentation >Affects Versions: 5.2 >Reporter: Ulrich Stärk >Assignee: Igor Drobiazko >Priority: Minor > Attachments: TAP5-814.txt, tapestry_request_processing_800.png > > -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Assigned: (TAP5-759) The documentation of DefaultNullFieldStrategy#replaceFromClient() is wrong about what gets returned
[ https://issues.apache.org/jira/browse/TAP5-759?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Igor Drobiazko reassigned TAP5-759: --- Assignee: Igor Drobiazko > The documentation of DefaultNullFieldStrategy#replaceFromClient() is wrong > about what gets returned > --- > > Key: TAP5-759 > URL: https://issues.apache.org/jira/browse/TAP5-759 > Project: Tapestry 5 > Issue Type: Bug > Components: documentation >Affects Versions: 5.1.0.5 >Reporter: Ulrich Stärk >Assignee: Igor Drobiazko >Priority: Minor > > In the JavaDocs it says that replaceFromClient() returns the empty string, > i.e. "", while the implementation returns null. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Closed: (TAP5-759) The documentation of DefaultNullFieldStrategy#replaceFromClient() is wrong about what gets returned
[ https://issues.apache.org/jira/browse/TAP5-759?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Igor Drobiazko closed TAP5-759. --- Resolution: Fixed Fix Version/s: 5.2.0.0 > The documentation of DefaultNullFieldStrategy#replaceFromClient() is wrong > about what gets returned > --- > > Key: TAP5-759 > URL: https://issues.apache.org/jira/browse/TAP5-759 > Project: Tapestry 5 > Issue Type: Bug > Components: documentation >Affects Versions: 5.1.0.5 >Reporter: Ulrich Stärk >Assignee: Igor Drobiazko >Priority: Minor > Fix For: 5.2.0.0 > > > In the JavaDocs it says that replaceFromClient() returns the empty string, > i.e. "", while the implementation returns null. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Closed: (TAP5-814) include a diagram showing how incoming requests pass through the different pipelines, filters and dispatchers
[ https://issues.apache.org/jira/browse/TAP5-814?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Igor Drobiazko closed TAP5-814. --- Resolution: Fixed Fix Version/s: 5.2.0.0 Thanks, Ulrich. Great patch. > include a diagram showing how incoming requests pass through the different > pipelines, filters and dispatchers > - > > Key: TAP5-814 > URL: https://issues.apache.org/jira/browse/TAP5-814 > Project: Tapestry 5 > Issue Type: Improvement > Components: documentation >Affects Versions: 5.2 >Reporter: Ulrich Stärk >Assignee: Igor Drobiazko >Priority: Minor > Fix For: 5.2.0.0 > > Attachments: TAP5-814.txt, tapestry_request_processing_800.png > > -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (TAP5-711) Submit component: using image parameter brakes "Selected" events
[ https://issues.apache.org/jira/browse/TAP5-711?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12750366#action_12750366 ] Igor Drobiazko commented on TAP5-711: - Patch review: I think an integration test is a better alternative than an unit test. > Submit component: using image parameter brakes "Selected" events > > > Key: TAP5-711 > URL: https://issues.apache.org/jira/browse/TAP5-711 > Project: Tapestry 5 > Issue Type: Bug > Components: tapestry-core >Affects Versions: 5.1.0.5 >Reporter: Sergey Didenko > Attachments: TAP5-711.txt, VoteForm3.java, VoteForm3.tml > > > When I change to onSelectedX() > handlers stop working. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Assigned: (TAP5-711) Submit component: using image parameter brakes "Selected" events
[ https://issues.apache.org/jira/browse/TAP5-711?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Igor Drobiazko reassigned TAP5-711: --- Assignee: Igor Drobiazko > Submit component: using image parameter brakes "Selected" events > > > Key: TAP5-711 > URL: https://issues.apache.org/jira/browse/TAP5-711 > Project: Tapestry 5 > Issue Type: Bug > Components: tapestry-core >Affects Versions: 5.1.0.5 >Reporter: Sergey Didenko >Assignee: Igor Drobiazko > Attachments: TAP5-711.txt, VoteForm3.java, VoteForm3.tml > > > When I change to onSelectedX() > handlers stop working. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Closed: (TAP5-678) Allow blackbird to be disabled in production mode
[ https://issues.apache.org/jira/browse/TAP5-678?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Igor Drobiazko closed TAP5-678. --- Resolution: Fixed Fix Version/s: 5.2.0.0 > Allow blackbird to be disabled in production mode > - > > Key: TAP5-678 > URL: https://issues.apache.org/jira/browse/TAP5-678 > Project: Tapestry 5 > Issue Type: Improvement > Components: tapestry-core >Affects Versions: 5.2 >Reporter: Paudi Moriarty >Assignee: Igor Drobiazko > Fix For: 5.2.0.0 > > > blackbird's use of F2 to show the console is interfering with our application > which uses F-keys as hotkeys to access various parts of the application. > It should be possible to either completely disable blackbird in production > mode (avoiding unnecessary .css and .js downloads) or at least disable the > console hotkey. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Closed: (TAP5-711) Submit component: using image parameter brakes "Selected" events
[ https://issues.apache.org/jira/browse/TAP5-711?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Igor Drobiazko closed TAP5-711. --- Resolution: Fixed Fix Version/s: 5.2.0.0 Thanks for the patch. > Submit component: using image parameter brakes "Selected" events > > > Key: TAP5-711 > URL: https://issues.apache.org/jira/browse/TAP5-711 > Project: Tapestry 5 > Issue Type: Bug > Components: tapestry-core >Affects Versions: 5.1.0.5 >Reporter: Sergey Didenko >Assignee: Igor Drobiazko > Fix For: 5.2.0.0 > > Attachments: TAP5-711.txt, VoteForm3.java, VoteForm3.tml > > > When I change to onSelectedX() > handlers stop working. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Closed: (TAP5-678) Allow blackbird to be disabled in production mode
[ https://issues.apache.org/jira/browse/TAP5-678?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Igor Drobiazko closed TAP5-678. --- Resolution: Fixed > Allow blackbird to be disabled in production mode > - > > Key: TAP5-678 > URL: https://issues.apache.org/jira/browse/TAP5-678 > Project: Tapestry 5 > Issue Type: Improvement > Components: tapestry-core >Affects Versions: 5.2 >Reporter: Paudi Moriarty >Assignee: Igor Drobiazko > Fix For: 5.2.0.0 > > > blackbird's use of F2 to show the console is interfering with our application > which uses F-keys as hotkeys to access various parts of the application. > It should be possible to either completely disable blackbird in production > mode (avoiding unnecessary .css and .js downloads) or at least disable the > console hotkey. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Closed: (TAP5-790) Provide ApplicationStatePersistenceStrategy for Hibernate entities
[ https://issues.apache.org/jira/browse/TAP5-790?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Igor Drobiazko closed TAP5-790. --- Resolution: Fixed Fix Version/s: 5.2.0.0 > Provide ApplicationStatePersistenceStrategy for Hibernate entities > --- > > Key: TAP5-790 > URL: https://issues.apache.org/jira/browse/TAP5-790 > Project: Tapestry 5 > Issue Type: Improvement > Components: tapestry-hibernate >Affects Versions: 5.2.0.0 >Reporter: Igor Drobiazko >Assignee: Igor Drobiazko > Fix For: 5.2.0.0 > > > Persisting a hibernate entity in HttpSession is not good idea because the > entity becomes detached from the Hibernate session. > It would be nice to have a ApplicationStatePersistenceStrategy which stores > only the primary key of the entity into the session. > This strategy should make use of the class PersistedEntity like > EntityPersistentFieldStrategy does. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Created: (TAP5-884) Introduce a symbol for tapestry.js
Introduce a symbol for tapestry.js -- Key: TAP5-884 URL: https://issues.apache.org/jira/browse/TAP5-884 Project: Tapestry 5 Issue Type: Improvement Components: tapestry-core Reporter: Igor Drobiazko Priority: Minor I was asked several times about how to replace Tapestry's built in tapestry.js by a app specific file. A symbol would help. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Created: (TAP5-885) Introduce constants for special JSONObject keys accepted in Tapestry.loadScriptsInReply
Introduce constants for special JSONObject keys accepted in Tapestry.loadScriptsInReply --- Key: TAP5-885 URL: https://issues.apache.org/jira/browse/TAP5-885 Project: Tapestry 5 Issue Type: Improvement Components: tapestry-core Affects Versions: 5.2.0.0 Reporter: Igor Drobiazko Priority: Minor It would be nice to have those constants. Also documentation about the accepted key is missing (AFAIK). -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Assigned: (TAP5-779) CLONE -Linksubmit doesn't work inside a form with Zone parameter set
[
https://issues.apache.org/jira/browse/TAP5-779?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Igor Drobiazko reassigned TAP5-779:
---
Assignee: Igor Drobiazko (was: Howard M. Lewis Ship)
> CLONE -Linksubmit doesn't work inside a form with Zone parameter set
>
>
> Key: TAP5-779
> URL: https://issues.apache.org/jira/browse/TAP5-779
> Project: Tapestry 5
> Issue Type: Bug
> Components: tapestry-core
>Affects Versions: 5.2
>Reporter: Ulrich Stärk
>Assignee: Igor Drobiazko
> Attachments: TAP5-779.txt
>
>
> This is a clone of TAP5-389 which was closed as CNR. This still IS an issue
> with 5.2-SNAPSHOT. Clicking on the link generated by linksubmit in the
> following example will not trigger linksubmit's selected event. The output is
> always just "form was submitted".
> http://tapestry.apache.org/schema/tapestry_5_1_0.xsd";>
>
>
>
> submit
>
>
>
> public class Test
> {
> public enum Types { TYPE1, TYPE2, TYPE3; }
>
> @Property private Types type;
>
> void onSelectedFromSubmit()
> {
> System.out.println("linksubmit was used");
> }
>
> void onSuccess()
> {
> System.out.println("form was submitted");
> }
> }
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (TAP5-779) CLONE -Linksubmit doesn't work inside a form with Zone parameter set
[
https://issues.apache.org/jira/browse/TAP5-779?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Igor Drobiazko closed TAP5-779.
---
Resolution: Fixed
Fix Version/s: 5.2.0.0
> CLONE -Linksubmit doesn't work inside a form with Zone parameter set
>
>
> Key: TAP5-779
> URL: https://issues.apache.org/jira/browse/TAP5-779
> Project: Tapestry 5
> Issue Type: Bug
> Components: tapestry-core
>Affects Versions: 5.2
>Reporter: Ulrich Stärk
>Assignee: Igor Drobiazko
> Fix For: 5.2.0.0
>
> Attachments: TAP5-779.txt
>
>
> This is a clone of TAP5-389 which was closed as CNR. This still IS an issue
> with 5.2-SNAPSHOT. Clicking on the link generated by linksubmit in the
> following example will not trigger linksubmit's selected event. The output is
> always just "form was submitted".
> http://tapestry.apache.org/schema/tapestry_5_1_0.xsd";>
>
>
>
> submit
>
>
>
> public class Test
> {
> public enum Types { TYPE1, TYPE2, TYPE3; }
>
> @Property private Types type;
>
> void onSelectedFromSubmit()
> {
> System.out.println("linksubmit was used");
> }
>
> void onSuccess()
> {
> System.out.println("form was submitted");
> }
> }
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Created: (TAP5-889) Provide fluent API for order constraints of contributions
Provide fluent API for order constraints of contributions
-
Key: TAP5-889
URL: https://issues.apache.org/jira/browse/TAP5-889
Project: Tapestry 5
Issue Type: Improvement
Components: tapestry-ioc
Affects Versions: 5.2.0.0
Reporter: Igor Drobiazko
Priority: Minor
It is a pain to create order constraint for contributions because of the hard
coded string "before" and "after".
It would be nice to have a fluent API for this.
public static void contributeMasterDispatcher(final
OrderedConfiguration configuration) {
configuration.addInstance("MyDispatcher",
MyDispatcher.class,
before("PageRender").after("ComponentEvent").build());
}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Created: (TAP5-890) Provide constants for ids of most important contributions to OrderedConfiguration and MappedConfiguration
Provide constants for ids of most important contributions to OrderedConfiguration and MappedConfiguration - Key: TAP5-890 URL: https://issues.apache.org/jira/browse/TAP5-890 Project: Tapestry 5 Issue Type: Improvement Components: tapestry-ioc Affects Versions: 5.2.0.0 Reporter: Igor Drobiazko Priority: Minor It is very common use case to contribute to configuration of MasterDispatcher or similar services. In most cases one has to look into the source of TapestryModule. It would be nice to have constants for contributed ids. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (TAP5-138) Add Zone parameter to Select component
[ https://issues.apache.org/jira/browse/TAP5-138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12766185#action_12766185 ] Igor Drobiazko commented on TAP5-138: - What is actually the use case? Is it A) or B) A) B) I think B) is more reasonable because in version A) all input is lost when the zone is updated. It doesn't make sense to update the entire form? Does it? > Add Zone parameter to Select component > -- > > Key: TAP5-138 > URL: https://issues.apache.org/jira/browse/TAP5-138 > Project: Tapestry 5 > Issue Type: New Feature >Affects Versions: 5.0.15 >Reporter: Geoff Callender > > Add AJAX ability to selection in a Select component to allow the classic > chaining of Select components. > Eg. for filtering car advertisements: 3 Select components - Brand, Make, > Model. Choosing a Brand causes the Make to be enabled, showing the possible > makes. Similarly, choosing a Make causes the Model to be enabled, showing > the possible models. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Assigned: (TAP5-895) Tracking issue for Tapestry/JSR-303 integration
[ https://issues.apache.org/jira/browse/TAP5-895?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Igor Drobiazko reassigned TAP5-895: --- Assignee: Igor Drobiazko > Tracking issue for Tapestry/JSR-303 integration > --- > > Key: TAP5-895 > URL: https://issues.apache.org/jira/browse/TAP5-895 > Project: Tapestry 5 > Issue Type: New Feature >Affects Versions: 5.1.0.5 >Reporter: Igor Drobiazko >Assignee: Igor Drobiazko > > The integration should be provided until 5.2.0.0 -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Created: (TAP5-895) Tracking issue for Tapestry/JSR-303 integration
Tracking issue for Tapestry/JSR-303 integration --- Key: TAP5-895 URL: https://issues.apache.org/jira/browse/TAP5-895 Project: Tapestry 5 Issue Type: New Feature Affects Versions: 5.1.0.5 Reporter: Igor Drobiazko The integration should be provided until 5.2.0.0 -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Created: (TAP5-896) Contribute 'properties' file extension to the configuration of ResourceDigestGenerator
Contribute 'properties' file extension to the configuration of ResourceDigestGenerator -- Key: TAP5-896 URL: https://issues.apache.org/jira/browse/TAP5-896 Project: Tapestry 5 Issue Type: Bug Components: tapestry-core Affects Versions: 5.1.0.5 Reporter: Igor Drobiazko Priority: Blocker This is a partly solution for TAP5-815 (only for *.properties files). -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Assigned: (TAP5-896) Contribute 'properties' file extension to the configuration of ResourceDigestGenerator
[ https://issues.apache.org/jira/browse/TAP5-896?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Igor Drobiazko reassigned TAP5-896: --- Assignee: Igor Drobiazko > Contribute 'properties' file extension to the configuration of > ResourceDigestGenerator > -- > > Key: TAP5-896 > URL: https://issues.apache.org/jira/browse/TAP5-896 > Project: Tapestry 5 > Issue Type: Bug > Components: tapestry-core >Affects Versions: 5.1.0.5 >Reporter: Igor Drobiazko >Assignee: Igor Drobiazko >Priority: Blocker > > This is a partly solution for TAP5-815 (only for *.properties files). -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (TAP5-896) Contribute 'properties' file extension to the configuration of ResourceDigestGenerator
[ https://issues.apache.org/jira/browse/TAP5-896?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12766530#action_12766530 ] Igor Drobiazko commented on TAP5-896: - Also for 'jar' and 'xml' a digest should be created. > Contribute 'properties' file extension to the configuration of > ResourceDigestGenerator > -- > > Key: TAP5-896 > URL: https://issues.apache.org/jira/browse/TAP5-896 > Project: Tapestry 5 > Issue Type: Bug > Components: tapestry-core >Affects Versions: 5.1.0.5 >Reporter: Igor Drobiazko >Assignee: Igor Drobiazko >Priority: Blocker > > This is a partly solution for TAP5-815 (only for *.properties files). -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (TAP5-896) Contribute 'properties' file extension to the configuration of ResourceDigestGenerator
[ https://issues.apache.org/jira/browse/TAP5-896?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12766534#action_12766534 ] Igor Drobiazko commented on TAP5-896: - Event if it is not a solution for TAP-815, we should add these extensions. If we add 'class' and 'tml', we also should add 'jar' and 'xml'. > Contribute 'properties' file extension to the configuration of > ResourceDigestGenerator > -- > > Key: TAP5-896 > URL: https://issues.apache.org/jira/browse/TAP5-896 > Project: Tapestry 5 > Issue Type: Bug > Components: tapestry-core >Affects Versions: 5.1.0.5 >Reporter: Igor Drobiazko >Assignee: Igor Drobiazko >Priority: Blocker > > This is a partly solution for TAP5-815 (only for *.properties files). -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (TAP5-138) Add Zone parameter to Select component
[ https://issues.apache.org/jira/browse/TAP5-138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12767573#action_12767573 ] Igor Drobiazko commented on TAP5-138: - Thank you for the comment. Implementing the option A is not a big deal. Since the whole form is updated there will be no exception about the missing FormSupport. But as I mentioned earlier I believe that option A is less often. Implementing option B is more tricky. In order to provide the FormSupport for the newly added select component one should put a PartialMarkupRendererFilter into the PageRenderQueue. This filter would create a FormSupport and push it into the environment. This is actually how FormInjector is working. However we need something similar as a mixin. I think we could live with a pragmatic solution which works for the select component instead of implementing a general solution. If there are more use cases in the feature we can think about a general mixin or what ever. What do you think? > Add Zone parameter to Select component > -- > > Key: TAP5-138 > URL: https://issues.apache.org/jira/browse/TAP5-138 > Project: Tapestry 5 > Issue Type: New Feature >Affects Versions: 5.0.15 >Reporter: Geoff Callender > > Add AJAX ability to selection in a Select component to allow the classic > chaining of Select components. > Eg. for filtering car advertisements: 3 Select components - Brand, Make, > Model. Choosing a Brand causes the Make to be enabled, showing the possible > makes. Similarly, choosing a Make causes the Model to be enabled, showing > the possible models. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Assigned: (TAP5-889) Provide fluent API for order constraints of contributions
[
https://issues.apache.org/jira/browse/TAP5-889?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Igor Drobiazko reassigned TAP5-889:
---
Assignee: Igor Drobiazko
> Provide fluent API for order constraints of contributions
> -
>
> Key: TAP5-889
> URL: https://issues.apache.org/jira/browse/TAP5-889
> Project: Tapestry 5
> Issue Type: Improvement
> Components: tapestry-ioc
>Affects Versions: 5.2.0.0
>Reporter: Igor Drobiazko
>Assignee: Igor Drobiazko
>Priority: Minor
>
> It is a pain to create order constraint for contributions because of the hard
> coded string "before" and "after".
> It would be nice to have a fluent API for this.
> public static void contributeMasterDispatcher(final
> OrderedConfiguration configuration) {
> configuration.addInstance("MyDispatcher",
>
> MyDispatcher.class,
>
> before("PageRender").after("ComponentEvent").build());
> }
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (TAP5-889) Provide fluent API for order constraints of contributions
[
https://issues.apache.org/jira/browse/TAP5-889?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Igor Drobiazko closed TAP5-889.
---
Resolution: Fixed
Fix Version/s: 5.2.0.0
> Provide fluent API for order constraints of contributions
> -
>
> Key: TAP5-889
> URL: https://issues.apache.org/jira/browse/TAP5-889
> Project: Tapestry 5
> Issue Type: Improvement
> Components: tapestry-ioc
>Affects Versions: 5.2.0.0
>Reporter: Igor Drobiazko
>Assignee: Igor Drobiazko
>Priority: Minor
> Fix For: 5.2.0.0
>
>
> It is a pain to create order constraint for contributions because of the hard
> coded string "before" and "after".
> It would be nice to have a fluent API for this.
> public static void contributeMasterDispatcher(final
> OrderedConfiguration configuration) {
> configuration.addInstance("MyDispatcher",
>
> MyDispatcher.class,
>
> before("PageRender").after("ComponentEvent").build());
> }
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (TAPESTRY-2258) Error while autobuilding BeanEditForm's bean
[
https://issues.apache.org/jira/browse/TAPESTRY-2258?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12769786#action_12769786
]
Igor Drobiazko commented on TAPESTRY-2258:
--
The problem is the different strategy for creating entities and services. Your
solution is not acceptable because it will break almost everything in Tapestry
itself and in all Tapestry apps. The constructor of a service with most
parameters is chosen to create an instance of the service.
What do you think about annotating your entities with your annotation? You
would then tell Tapestry which annotation should be searched instead of
@Inject. If this solution is acceptable for you, please fill a new issue for
that.
> Error while autobuilding BeanEditForm's bean
>
>
> Key: TAPESTRY-2258
> URL: https://issues.apache.org/jira/browse/TAPESTRY-2258
> Project: Tapestry
> Issue Type: Bug
> Components: tapestry-core
>Affects Versions: 5.0.11
> Environment: archlinux, sun jdk 1.6.0_03, jetty 6, tapestry 5.0.11
>Reporter: Slava Shushkanov
>Assignee: Howard M. Lewis Ship
> Fix For: 5.0.12
>
>
> The error is consequence of new feauture
> https://issues.apache.org/jira/browse/TAPESTRY-2202.
> The model bean User is typical hibernate entity:
> @Entity
> @Table(name = "user")
> public class User {
> public User() {
> }
> public User(Integer id) {
> ...
> }
> ...
> }
> Exception while autobuild:
> [ERROR] RequestExceptionHandler Processing of request failed with uncaught
> exception: Render queue error in SetupRender[admin/User:beaneditform.editor]:
> Exception instantiating instance of xx.model.User (for component
> 'admin/User:beaneditform.editor'): Error invoking constructor
> xx.model.User(Integer) (at User.java:51) (for service 'BeanModelSource'): No
> service implements the interface java.lang.Integer.
> org.apache.tapestry.internal.services.RenderQueueException: Render queue
> error in SetupRender[admin/User:beaneditform.editor]: Exception instantiating
> instance of xx.model.User (for component 'admin/User:beaneditform.editor'):
> Error invoking constructor xx.model.User(Integer) (at User.java:51) (for
> service 'BeanModelSource'): No service implements the interface
> java.lang.Integer. [at
> classpath:org/apache/tapestry/corelib/components/BeanEditForm.tml, line 8,
> column 81]
> at
> org.apache.tapestry.internal.services.RenderQueueImpl.run(RenderQueueImpl.java:75)
> at
> org.apache.tapestry.internal.services.PageRenderQueueImpl.render(PageRenderQueueImpl.java:84)
> at
> $PageRenderQueue_118ad47de45.render($PageRenderQueue_118ad47de45.java)
> at
> $PageRenderQueue_118ad47de3e.render($PageRenderQueue_118ad47de3e.java)
> at
> org.apache.tapestry.services.TapestryModule$19.renderMarkup(TapestryModule.java:1293)
> at
> org.apache.tapestry.services.TapestryModule$23.renderMarkup(TapestryModule.java:1402)
> at
> $MarkupRenderer_118ad47de46.renderMarkup($MarkupRenderer_118ad47de46.java)
> at
> org.apache.tapestry.services.TapestryModule$22.renderMarkup(TapestryModule.java:1383)
> at
> $MarkupRenderer_118ad47de46.renderMarkup($MarkupRenderer_118ad47de46.java)
> at
> org.apache.tapestry.services.TapestryModule$21.renderMarkup(TapestryModule.java:1365)
> at
> $MarkupRenderer_118ad47de46.renderMarkup($MarkupRenderer_118ad47de46.java)
> at
> org.apache.tapestry.services.TapestryModule$20.renderMarkup(TapestryModule.java:1347)
> at
> $MarkupRenderer_118ad47de46.renderMarkup($MarkupRenderer_118ad47de46.java)
> at
> $MarkupRenderer_118ad47de43.renderMarkup($MarkupRenderer_118ad47de43.java)
> at
> org.apache.tapestry.internal.services.PageMarkupRendererImpl.renderPageMarkup(PageMarkupRendererImpl.java:55)
> at
> $PageMarkupRenderer_118ad47de41.renderPageMarkup($PageMarkupRenderer_118ad47de41.java)
> at
> org.apache.tapestry.internal.services.PageResponseRendererImpl.renderPageResponse(PageResponseRendererImpl.java:57)
> at
> $PageResponseRenderer_118ad47dd7e.renderPageResponse($PageResponseRenderer_118ad47dd7e.java)
> at
> org.apache.tapestry.internal.services.PageRenderRequestHandlerImpl.handle(PageRenderRequestHandlerImpl.java:59)
> at
> org.apache.tapestry.services.TapestryModule$29.handle(TapestryModule.java:1607)
> at
> $PageRenderRequestHandler_118ad47dd7f.handle($PageRenderRequestHandler_118ad47dd7f.java)
> at
> $PageRenderRequestHandler_118ad47dd72.handle($PageRenderRequestHandler_118ad47dd72.java)
> at
> org.apache.tapestry.internal.services.PageRenderDispatcher.process(PageRenderDispatcher.java:97)
> at
> org.apache.tapestry.internal.services.PageRenderDispatcher.dispatch(PageRenderDispatcher.jav
[jira] Commented: (TAP5-907) BeanModelImpl.reorder
[ https://issues.apache.org/jira/browse/TAP5-907?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12769799#action_12769799 ] Igor Drobiazko commented on TAP5-907: - The described behavior is expected. You can't reorder a property which doesn't exist. If there is no setter method for a property the edit model is not aware of this property. The problem is the inconsistency of your edit and display models. These model have different sets of properties but you put a set union into the @ReorderProperties annotation. You should put an intersection of common properties instead or reorder the properties in template. I think we can close this issue. > BeanModelImpl.reorder > - > > Key: TAP5-907 > URL: https://issues.apache.org/jira/browse/TAP5-907 > Project: Tapestry 5 > Issue Type: Bug > Components: tapestry-core >Affects Versions: 5.1.0.5 >Reporter: Alex Lumpov > > I have MyBean with rw and read-only properties. > MyBean have @ReorderProperties annotation (it include read-only properties). > When BeanModelSourceImpl creates display model everything is fine. > When BeanModelSourceImpl creates edit model I saw exception: > org.apache.tapestry5.internal.beaneditor.BeanModelImpl.get(BeanModelImpl.java:152) > org.apache.tapestry5.internal.beaneditor.BeanModelImpl.reorder(BeanModelImpl.java:213) > > because BeanModelImpl.reorder try to get property that not exists. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Closed: (TAP5-906) t:disbled property of input components does not work correctly with property binding
[ https://issues.apache.org/jira/browse/TAP5-906?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Igor Drobiazko closed TAP5-906. --- Resolution: Cannot Reproduce Fix Version/s: 5.1.0.5 I tried to reproduce the described behaviour with Tapestry 5.1.0.5 and was not successful. If the problem still exists please provide a sample page. > t:disbled property of input components does not work correctly with property > binding > > > Key: TAP5-906 > URL: https://issues.apache.org/jira/browse/TAP5-906 > Project: Tapestry 5 > Issue Type: Bug > Components: tapestry-core >Affects Versions: 5.1.0.5 >Reporter: Erich Gormann >Priority: Critical > Fix For: 5.1.0.5 > > > When setting a t:disabled attribut into an input component like t:select or > t:textfield and proving its value as property expression binding, the field > is allways threated as disabled. Even when providing the value "false" for > the expression. > When setting "false" via literal binding t:disabled="literal:false" all works > fine. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
