[jira] [Commented] (TAP5-957) Tapestry's use of the beforeunload event conflicts with how IE operates

2012-09-21 Thread Taylor Mathewson (JIRA)

[ 
https://issues.apache.org/jira/browse/TAP5-957?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13460715#comment-13460715
 ] 

Taylor Mathewson commented on TAP5-957:
---

At the very list this should be logged in dev mode, the silent munching of zone 
updates and ajax responses is frustrating to say the least.

Also, this If you deliberately introduce anti-patterns into your pages, don't 
blame Tapestry for not reacting well. is a cop out.  You're using something 
with known issues in IE.  Simply labeling those as anti-patterns is a dodge.

 Tapestry's use of the beforeunload event conflicts with how IE operates
 ---

 Key: TAP5-957
 URL: https://issues.apache.org/jira/browse/TAP5-957
 Project: Tapestry 5
  Issue Type: Bug
  Components: tapestry-core
Affects Versions: 5.1.0.5
Reporter: mindhawk
Priority: Minor
  Labels: ie, javascript

 IE will generate a beforeunload  event when a link such as a 
 href='javascript:show()'show/a  is clicked. So Tapestry.windowUnloaded is 
 set to true. That means all ajax request have no chance to refresh the page 
 after this event.
 Now, I have to set Tapestry.windowUnloaded=false, every time I want to send a 
 ajax request. I don't think thisis a good practice. 
 I think there will be some more smart approach to replace 
 Tapestry.windowUnloaded, or just remove it. because, the request is sent to 
 the server no matter the value is true or false. This value is only discard 
 the responses from the server.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Comment Edited] (TAP5-957) Tapestry's use of the beforeunload event conflicts with how IE operates

2012-09-21 Thread Taylor Mathewson (JIRA)

[ 
https://issues.apache.org/jira/browse/TAP5-957?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13460715#comment-13460715
 ] 

Taylor Mathewson edited comment on TAP5-957 at 9/22/12 6:05 AM:


At the very least this should be logged in dev mode, the silent munching of 
zone updates and ajax responses is frustrating to say the least.

Also, this If you deliberately introduce anti-patterns into your pages, don't 
blame Tapestry for not reacting well. is a cop out.  You're using something 
with known issues in IE.  Simply labeling those as anti-patterns is a dodge.

  was (Author: trails):
At the very list this should be logged in dev mode, the silent munching of 
zone updates and ajax responses is frustrating to say the least.

Also, this If you deliberately introduce anti-patterns into your pages, don't 
blame Tapestry for not reacting well. is a cop out.  You're using something 
with known issues in IE.  Simply labeling those as anti-patterns is a dodge.
  
 Tapestry's use of the beforeunload event conflicts with how IE operates
 ---

 Key: TAP5-957
 URL: https://issues.apache.org/jira/browse/TAP5-957
 Project: Tapestry 5
  Issue Type: Bug
  Components: tapestry-core
Affects Versions: 5.1.0.5
Reporter: mindhawk
Priority: Minor
  Labels: ie, javascript

 IE will generate a beforeunload  event when a link such as a 
 href='javascript:show()'show/a  is clicked. So Tapestry.windowUnloaded is 
 set to true. That means all ajax request have no chance to refresh the page 
 after this event.
 Now, I have to set Tapestry.windowUnloaded=false, every time I want to send a 
 ajax request. I don't think thisis a good practice. 
 I think there will be some more smart approach to replace 
 Tapestry.windowUnloaded, or just remove it. because, the request is sent to 
 the server no matter the value is true or false. This value is only discard 
 the responses from the server.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] Commented: (TAP5-678) Allow blackbird to be disabled in production mode

2009-10-26 Thread Taylor Mathewson (JIRA)

[ 
https://issues.apache.org/jira/browse/TAP5-678?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12770053#action_12770053
 ] 

Taylor Mathewson commented on TAP5-678:
---

This also affects 5.1.  Any chance of backporting it there?

 Allow blackbird to be disabled in production mode
 -

 Key: TAP5-678
 URL: https://issues.apache.org/jira/browse/TAP5-678
 Project: Tapestry 5
  Issue Type: Improvement
  Components: tapestry-core
Affects Versions: 5.2
Reporter: Paudi Moriarty
Assignee: Igor Drobiazko
 Fix For: 5.2.0.0


 blackbird's use of F2 to show the console is interfering with our application 
 which uses F-keys as hotkeys to access various parts of the application.
 It should be possible to either completely disable blackbird in production 
 mode (avoiding unnecessary .css and .js downloads) or at least disable the 
 console hotkey.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Issue Comment Edited: (TAP5-678) Allow blackbird to be disabled in production mode

2009-10-26 Thread Taylor Mathewson (JIRA)

[ 
https://issues.apache.org/jira/browse/TAP5-678?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12770053#action_12770053
 ] 

Taylor Mathewson edited comment on TAP5-678 at 10/26/09 3:45 PM:
-

This also affects 5.1.  Any chance of backporting the fix there?

  was (Author: trails):
This also affects 5.1.  Any chance of backporting it there?
  
 Allow blackbird to be disabled in production mode
 -

 Key: TAP5-678
 URL: https://issues.apache.org/jira/browse/TAP5-678
 Project: Tapestry 5
  Issue Type: Improvement
  Components: tapestry-core
Affects Versions: 5.2
Reporter: Paudi Moriarty
Assignee: Igor Drobiazko
 Fix For: 5.2.0.0


 blackbird's use of F2 to show the console is interfering with our application 
 which uses F-keys as hotkeys to access various parts of the application.
 It should be possible to either completely disable blackbird in production 
 mode (avoiding unnecessary .css and .js downloads) or at least disable the 
 console hotkey.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Commented: (TAP5-799) Overriden Service Injected Into Page via @Inject Loses Decoration

2009-08-06 Thread Taylor Mathewson (JIRA)

[ 
https://issues.apache.org/jira/browse/TAP5-799?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12740138#action_12740138
 ] 

Taylor Mathewson commented on TAP5-799:
---

So it turns out the workaround above injects the non-overriden but properly 
decorated service.

I'm going to try using decoration as suggested by Mr. de Paula Figueiredo on 
Nabble, but as far as I can tell, service overriding per the new way ignores 
decoration.

 Overriden Service Injected Into Page via @Inject Loses Decoration
 -

 Key: TAP5-799
 URL: https://issues.apache.org/jira/browse/TAP5-799
 Project: Tapestry 5
  Issue Type: Bug
  Components: tapestry-ioc
Affects Versions: 5.1.0.5
Reporter: Taylor Mathewson

 I have a Core Module which binds a service impl to an interface, and 
 decorates it (hibernate transaction decorator, and a couple of custom things)
 I have page beans which reference the service, e.g.:
 @Inject
 private SomeService someService;
 Everything works fine up to this point.
 I add in an Extension Module, which refers to the Core Module as a submodule, 
 and overrides the service impl, e.g.:
 public static void contributeServiceOverride(MappedConfigurationClass, 
 Object configuration, ObjectLocator locator) {
 configuration.add(SomeService.class, locator.proxy(SomeService.class, 
 ExtendedSomeServiceImpl.class));
 }
 My services all get the right stuff, but the pages get the extended service 
 impl without any decoration.
 This can be worked around by the following:
 @InjectService(SomeService)
 private SomeService someService; 
 Workaround is cumbersome and loses the elegance of injection by type.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Commented: (TAP5-799) Overriden Service Injected Into Page via @Inject Loses Decoration

2009-08-06 Thread Taylor Mathewson (JIRA)

[ 
https://issues.apache.org/jira/browse/TAP5-799?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12740359#action_12740359
 ] 

Taylor Mathewson commented on TAP5-799:
---

Ok, so using a non-delegating decorator works, although it's a bit brittle to 
things like ordering.

It turns out that even the services referencing the overriden serivce interface 
get the undecorated override.  At this point it looks like service overrides 
using the ServiceOverride service don't get decorated.

 Overriden Service Injected Into Page via @Inject Loses Decoration
 -

 Key: TAP5-799
 URL: https://issues.apache.org/jira/browse/TAP5-799
 Project: Tapestry 5
  Issue Type: Bug
  Components: tapestry-ioc
Affects Versions: 5.1.0.5
Reporter: Taylor Mathewson

 I have a Core Module which binds a service impl to an interface, and 
 decorates it (hibernate transaction decorator, and a couple of custom things)
 I have page beans which reference the service, e.g.:
 @Inject
 private SomeService someService;
 Everything works fine up to this point.
 I add in an Extension Module, which refers to the Core Module as a submodule, 
 and overrides the service impl, e.g.:
 public static void contributeServiceOverride(MappedConfigurationClass, 
 Object configuration, ObjectLocator locator) {
 configuration.add(SomeService.class, locator.proxy(SomeService.class, 
 ExtendedSomeServiceImpl.class));
 }
 My services all get the right stuff, but the pages get the extended service 
 impl without any decoration.
 This can be worked around by the following:
 @InjectService(SomeService)
 private SomeService someService; 
 Workaround is cumbersome and loses the elegance of injection by type.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Created: (TAP5-799) Overriden Service Injected Into Page via @Inject Loses Decoration

2009-07-29 Thread Taylor Mathewson (JIRA)
Overriden Service Injected Into Page via @Inject Loses Decoration
-

 Key: TAP5-799
 URL: https://issues.apache.org/jira/browse/TAP5-799
 Project: Tapestry 5
  Issue Type: Bug
  Components: tapestry-ioc
Affects Versions: 5.1.0.5
Reporter: Taylor Mathewson


I have a Core Module which binds a service impl to an interface, and decorates 
it (hibernate transaction decorator, and a couple of custom things)

I have page beans which reference the service, e.g.:

@Inject
private SomeService someService;

Everything works fine up to this point.

I add in an Extension Module, which refers to the Core Module as a submodule, 
and overrides the service impl, e.g.:

public static void contributeServiceOverride(MappedConfigurationClass, 
Object configuration, ObjectLocator locator) {
configuration.add(SomeService.class, locator.proxy(SomeService.class, 
ExtendedSomeServiceImpl.class));
}

My services all get the right stuff, but the pages get the extended service 
impl without any decoration.

This can be worked around by the following:
@InjectService(SomeService)
private SomeService someService; 

Workaround is cumbersome and loses the elegance of injection by type.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.