[jira] [Assigned] (TAP5-2771) Upgrade to Spock 2.3
[ https://issues.apache.org/jira/browse/TAP5-2771?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Volker Lamp reassigned TAP5-2771: - Assignee: Volker Lamp > Upgrade to Spock 2.3 > > > Key: TAP5-2771 > URL: https://issues.apache.org/jira/browse/TAP5-2771 > Project: Tapestry 5 > Issue Type: Dependency upgrade > Components: tapestry-spock >Reporter: Volker Lamp >Assignee: Volker Lamp >Priority: Minor > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (TAP5-2771) Upgrade to Spock 2.3
Volker Lamp created TAP5-2771: - Summary: Upgrade to Spock 2.3 Key: TAP5-2771 URL: https://issues.apache.org/jira/browse/TAP5-2771 Project: Tapestry 5 Issue Type: Dependency upgrade Reporter: Volker Lamp -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Assigned] (TAP5-2587) Grid component zero division on rowsPerPage
[
https://issues.apache.org/jira/browse/TAP5-2587?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Volker Lamp reassigned TAP5-2587:
-
Assignee: Volker Lamp
> Grid component zero division on rowsPerPage
> ---
>
> Key: TAP5-2587
> URL: https://issues.apache.org/jira/browse/TAP5-2587
> Project: Tapestry 5
> Issue Type: Bug
> Components: tapestry-core
>Affects Versions: 5.4.1, 5.4.2, 5.4.3
>Reporter: Michail Almyros
>Assignee: Volker Lamp
>Priority: Major
> Labels: easyfix
>
> When the component will try to setup the data source there is a chance that
> the rowsPerPage parameter hasn't been initialised yet and this can lead to
> division by zero.
> Simply adding an additional check for the rowsPerPage parameter will fix the
> issue.
> Change to
> {code:java}
> // Method setupDataSource, line 499
> if (availableRows == 0 || rowsPerPage == 0)
> return;
> {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (TAP5-2737) Add FontAwesomeIcon to Component Reference page
[ https://issues.apache.org/jira/browse/TAP5-2737?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Volker Lamp updated TAP5-2737: -- Fix Version/s: 5.8.3 > Add FontAwesomeIcon to Component Reference page > --- > > Key: TAP5-2737 > URL: https://issues.apache.org/jira/browse/TAP5-2737 > Project: Tapestry 5 > Issue Type: Documentation > Components: documentation >Reporter: Volker Lamp >Assignee: Volker Lamp >Priority: Minor > Fix For: 5.8.3 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (TAP5-2729) Improve javadoc of ServiceBinder.bind(Class)
[ https://issues.apache.org/jira/browse/TAP5-2729?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Volker Lamp resolved TAP5-2729. --- Fix Version/s: 5.8.3 Resolution: Done > Improve javadoc of ServiceBinder.bind(Class) > > > Key: TAP5-2729 > URL: https://issues.apache.org/jira/browse/TAP5-2729 > Project: Tapestry 5 > Issue Type: Documentation > Components: tapestry-ioc >Reporter: Volker Lamp >Assignee: Volker Lamp >Priority: Minor > Fix For: 5.8.3 > > > What‘s missing is a description of how an interface is implicitly bound to an > implementation class if it is named …Impl.java. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (TAP5-2730) Misspelt ‘ComnpressedModules’ object id
[ https://issues.apache.org/jira/browse/TAP5-2730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17715531#comment-17715531 ] Volker Lamp commented on TAP5-2730: --- [~thiagohp], would the (trivial) fix cause any unacceptable backwards incompatibilities? In my opinion, we'll correct the spelling and mention the fix in the release notes. > Misspelt ‘ComnpressedModules’ object id > --- > > Key: TAP5-2730 > URL: https://issues.apache.org/jira/browse/TAP5-2730 > Project: Tapestry 5 > Issue Type: Improvement > Components: tapestry-core >Reporter: Volker Lamp >Priority: Trivial > > in JavaScriptModule.java:289 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (TAP5-2730) Misspelt ‘ComnpressedModules’ object id
[ https://issues.apache.org/jira/browse/TAP5-2730?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Volker Lamp updated TAP5-2730: -- Priority: Trivial (was: Minor) > Misspelt ‘ComnpressedModules’ object id > --- > > Key: TAP5-2730 > URL: https://issues.apache.org/jira/browse/TAP5-2730 > Project: Tapestry 5 > Issue Type: Improvement > Components: tapestry-core >Reporter: Volker Lamp >Priority: Trivial > > in JavaScriptModule.java:289 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (TAP5-2749) Incorrect behavior of getIfExists in EntityApplicationStatePersistenceStrategy
[ https://issues.apache.org/jira/browse/TAP5-2749?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Volker Lamp resolved TAP5-2749. --- Fix Version/s: 5.8.3 Resolution: Fixed > Incorrect behavior of getIfExists in EntityApplicationStatePersistenceStrategy > -- > > Key: TAP5-2749 > URL: https://issues.apache.org/jira/browse/TAP5-2749 > Project: Tapestry 5 > Issue Type: Bug > Components: tapestry-jpa >Affects Versions: 5.5.0, 5.8.2 >Reporter: Vladimir V. Bychkov >Assignee: Volker Lamp >Priority: Major > Fix For: 5.8.3 > > Time Spent: 40m > Remaining Estimate: 0h > > +Error description+ > Test [project > demonstrates|https://github.com/bvfalcon/tapestry-entity-state-test] an error > which was added during optimization TAP5-2478. > Methods > [get|https://github.com/apache/tapestry-5/blob/5.8.2/tapestry-core/src/main/java/org/apache/tapestry5/services/ApplicationStateManager.java#L57] > and > [getIfExists|https://github.com/apache/tapestry-5/blob/5.8.2/tapestry-core/src/main/java/org/apache/tapestry5/services/ApplicationStateManager.java#L67] > in ApplicationStateManager work different for JPA-Entities: first works > correct, second gives ClassCastException. > +Reason+ > By invoking > [ApplicationStateManager.set|https://github.com/apache/tapestry-5/blob/5.8.2/tapestry-core/src/main/java/org/apache/tapestry5/services/ApplicationStateManager.java#L87] > method EntityApplicationStatePersistenceStrategy.set is used, which > [*transforms*|https://github.com/apache/tapestry-5/blob/5.8.2/tapestry-jpa/src/main/java/org/apache/tapestry5/internal/jpa/EntityApplicationStatePersistenceStrategy.java#L70] > instanceof Entity-class to instance of PersistedEntity Class. > By Invoking ApplicationStateManager.get method > EntityApplicationStatePersistenceStrategy.get is used, which > [*transforms*|https://github.com/apache/tapestry-5/blob/5.8.2/tapestry-jpa/src/main/java/org/apache/tapestry5/internal/jpa/EntityApplicationStatePersistenceStrategy.java#L44] > instanceof PersistedEntity Class back to Entity-class. Therefore [this > code|https://github.com/bvfalcon/tapestry-entity-state-test/blob/master/src/main/java/org/apache/tapestry/components/Layout.java#L14] > works correct. > By Invoking ApplicationStateManager.getIfExists method > SessionApplicationStatePersistenceStrategy.getIfExists is used > (SessionApplicationStatePersistenceStrategy is a superclass for > EntityApplicationStatePersistenceStrategy), which > [*casts*|https://github.com/apache/tapestry-5/blob/5.8.2/tapestry-core/src/main/java/org/apache/tapestry5/internal/services/SessionApplicationStatePersistenceStrategy.java#L75] > instanceof PersistedEntity Class to Entity-class. This is incorrect and > gives ClassCastException in [this > code|https://github.com/bvfalcon/tapestry-entity-state-test/blob/master/src/main/java/org/apache/tapestry/components/Layout.java#L15]. > In other words, get makes back transformation, getIfExists - not. This is the > root of problem. > +Fix proposal+ > The best solution IMHO will be [restore > getIfExists|https://github.com/apache/tapestry-5/blob/5.5.0/tapestry-core/src/main/java/org/apache/tapestry5/services/ApplicationStatePersistenceStrategy.java#L57] > in EntityApplicationStatePersistenceStrategy, may be with some optimizations > from TAP5-2478. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Assigned] (TAP5-2749) Incorrect behavior of getIfExists in EntityApplicationStatePersistenceStrategy
[ https://issues.apache.org/jira/browse/TAP5-2749?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Volker Lamp reassigned TAP5-2749: - Assignee: Volker Lamp > Incorrect behavior of getIfExists in EntityApplicationStatePersistenceStrategy > -- > > Key: TAP5-2749 > URL: https://issues.apache.org/jira/browse/TAP5-2749 > Project: Tapestry 5 > Issue Type: Bug > Components: tapestry-jpa >Affects Versions: 5.5.0, 5.8.2 >Reporter: Vladimir V. Bychkov >Assignee: Volker Lamp >Priority: Major > Time Spent: 40m > Remaining Estimate: 0h > > +Error description+ > Test [project > demonstrates|https://github.com/bvfalcon/tapestry-entity-state-test] an error > which was added during optimization TAP5-2478. > Methods > [get|https://github.com/apache/tapestry-5/blob/5.8.2/tapestry-core/src/main/java/org/apache/tapestry5/services/ApplicationStateManager.java#L57] > and > [getIfExists|https://github.com/apache/tapestry-5/blob/5.8.2/tapestry-core/src/main/java/org/apache/tapestry5/services/ApplicationStateManager.java#L67] > in ApplicationStateManager work different for JPA-Entities: first works > correct, second gives ClassCastException. > +Reason+ > By invoking > [ApplicationStateManager.set|https://github.com/apache/tapestry-5/blob/5.8.2/tapestry-core/src/main/java/org/apache/tapestry5/services/ApplicationStateManager.java#L87] > method EntityApplicationStatePersistenceStrategy.set is used, which > [*transforms*|https://github.com/apache/tapestry-5/blob/5.8.2/tapestry-jpa/src/main/java/org/apache/tapestry5/internal/jpa/EntityApplicationStatePersistenceStrategy.java#L70] > instanceof Entity-class to instance of PersistedEntity Class. > By Invoking ApplicationStateManager.get method > EntityApplicationStatePersistenceStrategy.get is used, which > [*transforms*|https://github.com/apache/tapestry-5/blob/5.8.2/tapestry-jpa/src/main/java/org/apache/tapestry5/internal/jpa/EntityApplicationStatePersistenceStrategy.java#L44] > instanceof PersistedEntity Class back to Entity-class. Therefore [this > code|https://github.com/bvfalcon/tapestry-entity-state-test/blob/master/src/main/java/org/apache/tapestry/components/Layout.java#L14] > works correct. > By Invoking ApplicationStateManager.getIfExists method > SessionApplicationStatePersistenceStrategy.getIfExists is used > (SessionApplicationStatePersistenceStrategy is a superclass for > EntityApplicationStatePersistenceStrategy), which > [*casts*|https://github.com/apache/tapestry-5/blob/5.8.2/tapestry-core/src/main/java/org/apache/tapestry5/internal/services/SessionApplicationStatePersistenceStrategy.java#L75] > instanceof PersistedEntity Class to Entity-class. This is incorrect and > gives ClassCastException in [this > code|https://github.com/bvfalcon/tapestry-entity-state-test/blob/master/src/main/java/org/apache/tapestry/components/Layout.java#L15]. > In other words, get makes back transformation, getIfExists - not. This is the > root of problem. > +Fix proposal+ > The best solution IMHO will be [restore > getIfExists|https://github.com/apache/tapestry-5/blob/5.5.0/tapestry-core/src/main/java/org/apache/tapestry5/services/ApplicationStatePersistenceStrategy.java#L57] > in EntityApplicationStatePersistenceStrategy, may be with some optimizations > from TAP5-2478. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (TAP5-2537) ApplicationStateManagerImpl.getIfExists() fails when session is invalid (on Jetty, at least)
[
https://issues.apache.org/jira/browse/TAP5-2537?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Volker Lamp resolved TAP5-2537.
---
Assignee: Volker Lamp (was: Jochen Kemnade)
Resolution: Fixed
Added a test to show all works as expected in the current code base. Didn't go
back in the version history to find out what the actual fix version was though.
> ApplicationStateManagerImpl.getIfExists() fails when session is invalid (on
> Jetty, at least)
>
>
> Key: TAP5-2537
> URL: https://issues.apache.org/jira/browse/TAP5-2537
> Project: Tapestry 5
> Issue Type: Bug
> Components: tapestry-core
>Affects Versions: 5.4
>Reporter: I D
>Assignee: Volker Lamp
>Priority: Major
> Fix For: 5.4.1
>
>
> An IllegalStateException is thrown when calling
> ApplicationStateManagerImpl.getIfExists() on an invalid session. I would
> expect the method to catch the exception and return null in this case.
> Stack trace (top only):
> {code:java}
> -
> org.eclipse.jetty.server.session.AbstractSession.checkValid(AbstractSession.java:106)
> -
> org.eclipse.jetty.server.session.AbstractSession.getAttribute(AbstractSession.java:459)
> -
> org.apache.tapestry5.internal.services.SessionImpl.getAttribute(SessionImpl.java:52)
> -
> org.apache.tapestry5.internal.services.SessionApplicationStatePersistenceStrategy.exists(SessionApplicationStatePersistenceStrategy.java:80)
> - $ApplicationStatePersistenceStrategy_b43cfdb8299.exists(Unknown Source)
> -
> org.apache.tapestry5.internal.services.ApplicationStateManagerImpl$ApplicationStateAdapter.exists(ApplicationStateManagerImpl.java:60)
> -
> org.apache.tapestry5.internal.services.ApplicationStateManagerImpl.getIfExists(ApplicationStateManagerImpl.java:140)
> {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (TAP5-2749) Incorrect behavior of getIfExists in EntityApplicationStatePersistenceStrategy
[ https://issues.apache.org/jira/browse/TAP5-2749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17710318#comment-17710318 ] Volker Lamp commented on TAP5-2749: --- I spent some time today reviewing the PR but got distracted by what I think is a flaw in Tapestry‘s overall test setup. Specifically, Spock tests (specifications) don‘t seem to get executed. That‘s beyond the scope of this issue, of course, but I wanted to keep you informed. I‘ll get back to this issue / PR in due course. > Incorrect behavior of getIfExists in EntityApplicationStatePersistenceStrategy > -- > > Key: TAP5-2749 > URL: https://issues.apache.org/jira/browse/TAP5-2749 > Project: Tapestry 5 > Issue Type: Bug > Components: tapestry-jpa >Affects Versions: 5.5.0, 5.8.2 >Reporter: Vladimir V. Bychkov >Priority: Major > Time Spent: 10m > Remaining Estimate: 0h > > +Error description+ > Test [project > demonstrates|https://github.com/bvfalcon/tapestry-entity-state-test] an error > which was added during optimization TAP5-2478. > Methods > [get|https://github.com/apache/tapestry-5/blob/5.8.2/tapestry-core/src/main/java/org/apache/tapestry5/services/ApplicationStateManager.java#L57] > and > [getIfExists|https://github.com/apache/tapestry-5/blob/5.8.2/tapestry-core/src/main/java/org/apache/tapestry5/services/ApplicationStateManager.java#L67] > in ApplicationStateManager work different for JPA-Entities: first works > correct, second gives ClassCastException. > +Reason+ > By invoking > [ApplicationStateManager.set|https://github.com/apache/tapestry-5/blob/5.8.2/tapestry-core/src/main/java/org/apache/tapestry5/services/ApplicationStateManager.java#L87] > method EntityApplicationStatePersistenceStrategy.set is used, which > [*transforms*|https://github.com/apache/tapestry-5/blob/5.8.2/tapestry-jpa/src/main/java/org/apache/tapestry5/internal/jpa/EntityApplicationStatePersistenceStrategy.java#L70] > instanceof Entity-class to instance of PersistedEntity Class. > By Invoking ApplicationStateManager.get method > EntityApplicationStatePersistenceStrategy.get is used, which > [*transforms*|https://github.com/apache/tapestry-5/blob/5.8.2/tapestry-jpa/src/main/java/org/apache/tapestry5/internal/jpa/EntityApplicationStatePersistenceStrategy.java#L44] > instanceof PersistedEntity Class back to Entity-class. Therefore [this > code|https://github.com/bvfalcon/tapestry-entity-state-test/blob/master/src/main/java/org/apache/tapestry/components/Layout.java#L14] > works correct. > By Invoking ApplicationStateManager.getIfExists method > SessionApplicationStatePersistenceStrategy.getIfExists is used > (SessionApplicationStatePersistenceStrategy is a superclass for > EntityApplicationStatePersistenceStrategy), which > [*casts*|https://github.com/apache/tapestry-5/blob/5.8.2/tapestry-core/src/main/java/org/apache/tapestry5/internal/services/SessionApplicationStatePersistenceStrategy.java#L75] > instanceof PersistedEntity Class to Entity-class. This is incorrect and > gives ClassCastException in [this > code|https://github.com/bvfalcon/tapestry-entity-state-test/blob/master/src/main/java/org/apache/tapestry/components/Layout.java#L15]. > In other words, get makes back transformation, getIfExists - not. This is the > root of problem. > +Fix proposal+ > The best solution IMHO will be [restore > getIfExists|https://github.com/apache/tapestry-5/blob/5.5.0/tapestry-core/src/main/java/org/apache/tapestry5/services/ApplicationStatePersistenceStrategy.java#L57] > in EntityApplicationStatePersistenceStrategy, may be with some optimizations > from TAP5-2478. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (TAP5-2751) Provide German translation of the 'checked' validator message
[ https://issues.apache.org/jira/browse/TAP5-2751?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Volker Lamp resolved TAP5-2751. --- Resolution: Implemented > Provide German translation of the 'checked' validator message > - > > Key: TAP5-2751 > URL: https://issues.apache.org/jira/browse/TAP5-2751 > Project: Tapestry 5 > Issue Type: Improvement > Components: tapestry-core >Affects Versions: 5.8.2 >Reporter: Volker Lamp >Assignee: Volker Lamp >Priority: Trivial > Fix For: 5.8.3 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Reopened] (TAP5-2751) Provide German translation of the 'checked' validator message
[ https://issues.apache.org/jira/browse/TAP5-2751?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Volker Lamp reopened TAP5-2751: --- Forgot to set fix version. > Provide German translation of the 'checked' validator message > - > > Key: TAP5-2751 > URL: https://issues.apache.org/jira/browse/TAP5-2751 > Project: Tapestry 5 > Issue Type: Improvement > Components: tapestry-core >Affects Versions: 5.8.2 >Reporter: Volker Lamp >Assignee: Volker Lamp >Priority: Trivial > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (TAP5-2751) Provide German translation of the 'checked' validator message
[ https://issues.apache.org/jira/browse/TAP5-2751?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Volker Lamp updated TAP5-2751: -- Fix Version/s: 5.8.3 > Provide German translation of the 'checked' validator message > - > > Key: TAP5-2751 > URL: https://issues.apache.org/jira/browse/TAP5-2751 > Project: Tapestry 5 > Issue Type: Improvement > Components: tapestry-core >Affects Versions: 5.8.2 >Reporter: Volker Lamp >Assignee: Volker Lamp >Priority: Trivial > Fix For: 5.8.3 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (TAP5-2750) Kaptcha: support for German locale
[ https://issues.apache.org/jira/browse/TAP5-2750?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Volker Lamp updated TAP5-2750: -- Fix Version/s: 5.8.3 > Kaptcha: support for German locale > -- > > Key: TAP5-2750 > URL: https://issues.apache.org/jira/browse/TAP5-2750 > Project: Tapestry 5 > Issue Type: Improvement > Components: tapestry-kaptcha >Affects Versions: 5.8.2 >Reporter: Volker Lamp >Assignee: Volker Lamp >Priority: Trivial > Fix For: 5.8.3 > > > The German properties file is missing. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Reopened] (TAP5-2750) Kaptcha: support for German locale
[ https://issues.apache.org/jira/browse/TAP5-2750?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Volker Lamp reopened TAP5-2750: --- Forgot to set fix version. > Kaptcha: support for German locale > -- > > Key: TAP5-2750 > URL: https://issues.apache.org/jira/browse/TAP5-2750 > Project: Tapestry 5 > Issue Type: Improvement > Components: tapestry-kaptcha >Affects Versions: 5.8.2 >Reporter: Volker Lamp >Assignee: Volker Lamp >Priority: Trivial > > The German properties file is missing. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (TAP5-2750) Kaptcha: support for German locale
[ https://issues.apache.org/jira/browse/TAP5-2750?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Volker Lamp resolved TAP5-2750. --- Resolution: Implemented > Kaptcha: support for German locale > -- > > Key: TAP5-2750 > URL: https://issues.apache.org/jira/browse/TAP5-2750 > Project: Tapestry 5 > Issue Type: Improvement > Components: tapestry-kaptcha >Affects Versions: 5.8.2 >Reporter: Volker Lamp >Assignee: Volker Lamp >Priority: Trivial > Fix For: 5.8.3 > > > The German properties file is missing. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Reopened] (TAP5-1733) Throw bespoke exceptions so they may be more easily identified by Error Handlers
[
https://issues.apache.org/jira/browse/TAP5-1733?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Volker Lamp reopened TAP5-1733:
---
Assignee: Volker Lamp
This suggestion should be implemented, as others have noted before:
* https://tapestry.apache.org/specific-errors-faq.html
* https://lists.apache.org/thread/cxo6xzhr03kohnvypmt5wdy91fk655dk
> Throw bespoke exceptions so they may be more easily identified by Error
> Handlers
>
>
> Key: TAP5-1733
> URL: https://issues.apache.org/jira/browse/TAP5-1733
> Project: Tapestry 5
> Issue Type: Improvement
> Components: tapestry-core
>Affects Versions: 5.3
>Reporter: Steve Eynon
>Assignee: Volker Lamp
>Priority: Minor
> Labels: bulk-close-candidate
>
> Two exceptions in particular tend to be thrown prolifically by live sites
> when they are crawled by robots. They are:
> - java.lang.RuntimeException: Forms require that the request method be POST
> and that the t:formdata query parameter have values.
> - java.lang.IllegalArgumentException: Input string 'XXX' is not valid; the
> character 'X' at position X is not valid.
> To save needless reporting of benign errors (and to prevent the error logs
> from filling up) these exceptions are usually ignored by implementing Error
> Handlers. But the ErrorHandler has to currently check the exception message:
> if (e.getMessage().contains("Forms require that the request method be POST"))
> {
> doIgnore();
> }
> which is both brittle and nasty. Instead it'd be great if Tapestry could
> throw some bespoke exceptions so the above could be re-written as:
> if (e instanceof FormsRequirePostException) {
> doIngore();
> }
> Email thread below:
> http://tapestry.1045711.n5.nabble.com/Safari-for-example-browser-history-and-form-exception-td4942074.html
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (TAP5-2737) Add FontAwesomeIcon to Component Reference page
[
https://issues.apache.org/jira/browse/TAP5-2737?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17709005#comment-17709005
]
Volker Lamp commented on TAP5-2737:
---
The {{name}} field must indeed be {{private}} or else it won't be picked up by
the tapestrydoc processor.
Here is why:
https://github.com/apache/tapestry-5/blob/0aaa5695956577c8738fae21de06647b4c36c6e8/tapestry-javadoc/src/main/java/org/apache/tapestry5/javadoc/ClassDescription.java#L138
> Add FontAwesomeIcon to Component Reference page
> ---
>
> Key: TAP5-2737
> URL: https://issues.apache.org/jira/browse/TAP5-2737
> Project: Tapestry 5
> Issue Type: Documentation
> Components: documentation
>Reporter: Volker Lamp
>Assignee: Volker Lamp
>Priority: Minor
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Closed] (TAP5-2750) Kaptcha: support for German locale
[ https://issues.apache.org/jira/browse/TAP5-2750?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Volker Lamp closed TAP5-2750. - Resolution: Implemented > Kaptcha: support for German locale > -- > > Key: TAP5-2750 > URL: https://issues.apache.org/jira/browse/TAP5-2750 > Project: Tapestry 5 > Issue Type: Improvement > Components: tapestry-kaptcha >Affects Versions: 5.8.2 >Reporter: Volker Lamp >Assignee: Volker Lamp >Priority: Trivial > > The German properties file is missing. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Closed] (TAP5-2751) Provide German translation of the 'checked' validator message
[ https://issues.apache.org/jira/browse/TAP5-2751?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Volker Lamp closed TAP5-2751. - Resolution: Implemented > Provide German translation of the 'checked' validator message > - > > Key: TAP5-2751 > URL: https://issues.apache.org/jira/browse/TAP5-2751 > Project: Tapestry 5 > Issue Type: Improvement > Components: tapestry-core >Affects Versions: 5.8.2 >Reporter: Volker Lamp >Assignee: Volker Lamp >Priority: Trivial > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (TAP5-2737) Add FontAwesomeIcon to Component Reference page
[ https://issues.apache.org/jira/browse/TAP5-2737?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17708491#comment-17708491 ] Volker Lamp commented on TAP5-2737: --- Inserted link to the Confluence page, and its showing up ok in the generated static html. However, the component parameters are missing. My guess is this has to do with the visibility of the 'name' field, but I'll to to figure out how the whole tapestrydoc stuff works first. > Add FontAwesomeIcon to Component Reference page > --- > > Key: TAP5-2737 > URL: https://issues.apache.org/jira/browse/TAP5-2737 > Project: Tapestry 5 > Issue Type: Documentation > Components: documentation >Reporter: Volker Lamp >Assignee: Volker Lamp >Priority: Minor > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Assigned] (TAP5-2737) Add FontAwesomeIcon to Component Reference page
[ https://issues.apache.org/jira/browse/TAP5-2737?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Volker Lamp reassigned TAP5-2737: - Assignee: Volker Lamp > Add FontAwesomeIcon to Component Reference page > --- > > Key: TAP5-2737 > URL: https://issues.apache.org/jira/browse/TAP5-2737 > Project: Tapestry 5 > Issue Type: Documentation > Components: documentation >Reporter: Volker Lamp >Assignee: Volker Lamp >Priority: Minor > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Assigned] (TAP5-2751) Provide German translation of the 'checked' validator message
[ https://issues.apache.org/jira/browse/TAP5-2751?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Volker Lamp reassigned TAP5-2751: - Assignee: Volker Lamp > Provide German translation of the 'checked' validator message > - > > Key: TAP5-2751 > URL: https://issues.apache.org/jira/browse/TAP5-2751 > Project: Tapestry 5 > Issue Type: Improvement > Components: tapestry-core >Affects Versions: 5.8.2 >Reporter: Volker Lamp >Assignee: Volker Lamp >Priority: Trivial > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (TAP5-2751) Provide German translation of the 'checked' validator message
Volker Lamp created TAP5-2751: - Summary: Provide German translation of the 'checked' validator message Key: TAP5-2751 URL: https://issues.apache.org/jira/browse/TAP5-2751 Project: Tapestry 5 Issue Type: Improvement Components: tapestry-core Affects Versions: 5.8.2 Reporter: Volker Lamp -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Assigned] (TAP5-2750) Kaptcha: support for German locale
[ https://issues.apache.org/jira/browse/TAP5-2750?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Volker Lamp reassigned TAP5-2750: - Assignee: Volker Lamp > Kaptcha: support for German locale > -- > > Key: TAP5-2750 > URL: https://issues.apache.org/jira/browse/TAP5-2750 > Project: Tapestry 5 > Issue Type: Improvement > Components: tapestry-kaptcha >Affects Versions: 5.8.2 >Reporter: Volker Lamp >Assignee: Volker Lamp >Priority: Trivial > > The German properties file is missing. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (TAP5-2750) Kaptcha: support for German locale
Volker Lamp created TAP5-2750: - Summary: Kaptcha: support for German locale Key: TAP5-2750 URL: https://issues.apache.org/jira/browse/TAP5-2750 Project: Tapestry 5 Issue Type: Improvement Components: tapestry-kaptcha Affects Versions: 5.8.2 Reporter: Volker Lamp The German properties file is missing. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (TAP5-2749) Incorrect behavior of getIfExists in EntityApplicationStatePersistenceStrategy
[ https://issues.apache.org/jira/browse/TAP5-2749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17705658#comment-17705658 ] Volker Lamp commented on TAP5-2749: --- Awesome, thank you. Please allow until second half of next week for me to review your PR. > Incorrect behavior of getIfExists in EntityApplicationStatePersistenceStrategy > -- > > Key: TAP5-2749 > URL: https://issues.apache.org/jira/browse/TAP5-2749 > Project: Tapestry 5 > Issue Type: Bug > Components: tapestry-jpa >Affects Versions: 5.5.0, 5.8.2 >Reporter: Vladimir V. Bychkov >Priority: Major > Time Spent: 10m > Remaining Estimate: 0h > > +Error description+ > Test [project > demonstrates|https://github.com/bvfalcon/tapestry-entity-state-test] an error > which was added during optimization TAP5-2478. > Methods > [get|https://github.com/apache/tapestry-5/blob/5.8.2/tapestry-core/src/main/java/org/apache/tapestry5/services/ApplicationStateManager.java#L57] > and > [getIfExists|https://github.com/apache/tapestry-5/blob/5.8.2/tapestry-core/src/main/java/org/apache/tapestry5/services/ApplicationStateManager.java#L67] > in ApplicationStateManager work different for JPA-Entities: first works > correct, second gives ClassCastException. > +Reason+ > By invoking > [ApplicationStateManager.set|https://github.com/apache/tapestry-5/blob/5.8.2/tapestry-core/src/main/java/org/apache/tapestry5/services/ApplicationStateManager.java#L87] > method EntityApplicationStatePersistenceStrategy.set is used, which > [*transforms*|https://github.com/apache/tapestry-5/blob/5.8.2/tapestry-jpa/src/main/java/org/apache/tapestry5/internal/jpa/EntityApplicationStatePersistenceStrategy.java#L70] > instanceof Entity-class to instance of PersistedEntity Class. > By Invoking ApplicationStateManager.get method > EntityApplicationStatePersistenceStrategy.get is used, which > [*transforms*|https://github.com/apache/tapestry-5/blob/5.8.2/tapestry-jpa/src/main/java/org/apache/tapestry5/internal/jpa/EntityApplicationStatePersistenceStrategy.java#L44] > instanceof PersistedEntity Class back to Entity-class. Therefore [this > code|https://github.com/bvfalcon/tapestry-entity-state-test/blob/master/src/main/java/org/apache/tapestry/components/Layout.java#L14] > works correct. > By Invoking ApplicationStateManager.getIfExists method > SessionApplicationStatePersistenceStrategy.getIfExists is used > (SessionApplicationStatePersistenceStrategy is a superclass for > EntityApplicationStatePersistenceStrategy), which > [*casts*|https://github.com/apache/tapestry-5/blob/5.8.2/tapestry-core/src/main/java/org/apache/tapestry5/internal/services/SessionApplicationStatePersistenceStrategy.java#L75] > instanceof PersistedEntity Class to Entity-class. This is incorrect and > gives ClassCastException in [this > code|https://github.com/bvfalcon/tapestry-entity-state-test/blob/master/src/main/java/org/apache/tapestry/components/Layout.java#L15]. > In other words, get makes back transformation, getIfExists - not. This is the > root of problem. > +Fix proposal+ > The best solution IMHO will be [restore > getIfExists|https://github.com/apache/tapestry-5/blob/5.5.0/tapestry-core/src/main/java/org/apache/tapestry5/services/ApplicationStatePersistenceStrategy.java#L57] > in EntityApplicationStatePersistenceStrategy, may be with some optimizations > from TAP5-2478. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (TAP5-2749) Incorrect behavior of getIfExists in EntityApplicationStatePersistenceStrategy
[
https://issues.apache.org/jira/browse/TAP5-2749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17703758#comment-17703758
]
Volker Lamp commented on TAP5-2749:
---
Thank you for the detailed description and analysis, [~vbychkov]. Thank you
also for the working example in your GitHub account.
Is there any chance I can motivate you transform your working example to a test
case in the Tapestry code base? Happy to guide you through it should you get
stuck. That way, we could be sure to never break it again, as we'd have the
test run with every push.
To get started, fork [https://github.com/apache/tapestry-5], and take a look at
the various test apps in {{tapestry-core/src/test}} and the units tests under
{{{}tapestry-core/src/test/java{}}}.
> Incorrect behavior of getIfExists in EntityApplicationStatePersistenceStrategy
> --
>
> Key: TAP5-2749
> URL: https://issues.apache.org/jira/browse/TAP5-2749
> Project: Tapestry 5
> Issue Type: Bug
> Components: tapestry-jpa
>Affects Versions: 5.5.0, 5.8.2
>Reporter: Vladimir V. Bychkov
>Priority: Major
>
> +Error description+
> Test [project
> demonstrates|https://github.com/bvfalcon/tapestry-entity-state-test] an error
> which was added during optimization TAP5-2478.
> Methods
> [get|https://github.com/apache/tapestry-5/blob/5.8.2/tapestry-core/src/main/java/org/apache/tapestry5/services/ApplicationStateManager.java#L57]
> and
> [getIfExists|https://github.com/apache/tapestry-5/blob/5.8.2/tapestry-core/src/main/java/org/apache/tapestry5/services/ApplicationStateManager.java#L67]
> in ApplicationStateManager work different for JPA-Entities: first works
> correct, second gives ClassCastException.
> +Reason+
> By invoking
> [ApplicationStateManager.set|https://github.com/apache/tapestry-5/blob/5.8.2/tapestry-core/src/main/java/org/apache/tapestry5/services/ApplicationStateManager.java#L87]
> method EntityApplicationStatePersistenceStrategy.set is used, which
> [*transforms*|https://github.com/apache/tapestry-5/blob/5.8.2/tapestry-jpa/src/main/java/org/apache/tapestry5/internal/jpa/EntityApplicationStatePersistenceStrategy.java#L70]
> instanceof Entity-class to instance of PersistedEntity Class.
> By Invoking ApplicationStateManager.get method
> EntityApplicationStatePersistenceStrategy.get is used, which
> [*transforms*|https://github.com/apache/tapestry-5/blob/5.8.2/tapestry-jpa/src/main/java/org/apache/tapestry5/internal/jpa/EntityApplicationStatePersistenceStrategy.java#L44]
> instanceof PersistedEntity Class back to Entity-class. Therefore [this
> code|https://github.com/bvfalcon/tapestry-entity-state-test/blob/master/src/main/java/org/apache/tapestry/components/Layout.java#L14]
> works correct.
> By Invoking ApplicationStateManager.getIfExists method
> SessionApplicationStatePersistenceStrategy.getIfExists is used
> (SessionApplicationStatePersistenceStrategy is a superclass for
> EntityApplicationStatePersistenceStrategy), which
> [*casts*|https://github.com/apache/tapestry-5/blob/5.8.2/tapestry-core/src/main/java/org/apache/tapestry5/internal/services/SessionApplicationStatePersistenceStrategy.java#L75]
> instanceof PersistedEntity Class to Entity-class. This is incorrect and
> gives ClassCastException in [this
> code|https://github.com/bvfalcon/tapestry-entity-state-test/blob/master/src/main/java/org/apache/tapestry/components/Layout.java#L15].
> In other words, get makes back transformation, getIfExists - not. This is the
> root of problem.
> +Fix proposal+
> The best solution IMHO will be [restore
> getIfExists|https://github.com/apache/tapestry-5/blob/5.5.0/tapestry-core/src/main/java/org/apache/tapestry5/services/ApplicationStatePersistenceStrategy.java#L57]
> in EntityApplicationStatePersistenceStrategy, may be with some optimizations
> from TAP5-2478.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (TAP5-2731) Update version history on Wikipedia page
[ https://issues.apache.org/jira/browse/TAP5-2731?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17571059#comment-17571059 ] Volker Lamp commented on TAP5-2731: --- That‘s a good effort also, Ben, thank you! What I meant was the Wikipedia page. I added the link to the issue description. I can do it myself, I just created the issue as a note to myself when I noticed the Wikipedia page was outdated. > Update version history on Wikipedia page > > > Key: TAP5-2731 > URL: https://issues.apache.org/jira/browse/TAP5-2731 > Project: Tapestry 5 > Issue Type: Task >Reporter: Volker Lamp >Priority: Minor > > Current page states release 5.5 is the current version. > https://en.m.wikipedia.org/wiki/Apache_Tapestry -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (TAP5-2731) Update version history on Wikipedia page
[ https://issues.apache.org/jira/browse/TAP5-2731?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Volker Lamp updated TAP5-2731: -- Description: Current page states release 5.5 is the current version. https://en.m.wikipedia.org/wiki/Apache_Tapestry was:Current page states release 5.5 is the current version. > Update version history on Wikipedia page > > > Key: TAP5-2731 > URL: https://issues.apache.org/jira/browse/TAP5-2731 > Project: Tapestry 5 > Issue Type: Task >Reporter: Volker Lamp >Priority: Minor > > Current page states release 5.5 is the current version. > https://en.m.wikipedia.org/wiki/Apache_Tapestry -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Assigned] (TAP5-2734) Upgrade to jQuery 3.5.1
[ https://issues.apache.org/jira/browse/TAP5-2734?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Volker Lamp reassigned TAP5-2734: - Assignee: Volker Lamp > Upgrade to jQuery 3.5.1 > --- > > Key: TAP5-2734 > URL: https://issues.apache.org/jira/browse/TAP5-2734 > Project: Tapestry 5 > Issue Type: Dependency upgrade > Components: tapestry-core >Reporter: Volker Lamp >Assignee: Volker Lamp >Priority: Major > Labels: JavaScript, jQuery > > Motivation: > 1. to cancel technial debt > 2. to be consistent with Bootstrap 4.6.1 (see TAP5-2733) -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (TAP5-2737) Add FontAwesomeIcon to Component Reference page
Volker Lamp created TAP5-2737: - Summary: Add FontAwesomeIcon to Component Reference page Key: TAP5-2737 URL: https://issues.apache.org/jira/browse/TAP5-2737 Project: Tapestry 5 Issue Type: Documentation Components: documentation Reporter: Volker Lamp -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Created] (TAP5-2734) Upgrade to jQuery 3.5.1
Volker Lamp created TAP5-2734: - Summary: Upgrade to jQuery 3.5.1 Key: TAP5-2734 URL: https://issues.apache.org/jira/browse/TAP5-2734 Project: Tapestry 5 Issue Type: Dependency upgrade Components: tapestry-core Reporter: Volker Lamp Motivation: 1. to cancel technial debt 2. to be consistent with Bootstrap 4.6.1 (see TAP5-2733) -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Assigned] (TAP5-2733) Upgrade to Bootstrap 4.6.+
[ https://issues.apache.org/jira/browse/TAP5-2733?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Volker Lamp reassigned TAP5-2733: - Assignee: Volker Lamp > Upgrade to Bootstrap 4.6.+ > -- > > Key: TAP5-2733 > URL: https://issues.apache.org/jira/browse/TAP5-2733 > Project: Tapestry 5 > Issue Type: Dependency upgrade > Components: tapestry-core >Reporter: Volker Lamp >Assignee: Volker Lamp >Priority: Major > > Necessary to make popovers work. See TAP5-2686. > Expected to be a drop-in replacement for the currently bundled Bootstrap > 4.3.1. -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Created] (TAP5-2733) Upgrade to Bootstrap 4.6.+
Volker Lamp created TAP5-2733: - Summary: Upgrade to Bootstrap 4.6.+ Key: TAP5-2733 URL: https://issues.apache.org/jira/browse/TAP5-2733 Project: Tapestry 5 Issue Type: Dependency upgrade Components: tapestry-core Reporter: Volker Lamp Necessary to make popovers work. See TAP5-2686. Expected to be a drop-in replacement for the currently bundled Bootstrap 4.3.1. -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Commented] (TAP5-2686) require('bootstrap/popover') fails when using bootstrap 4
[
https://issues.apache.org/jira/browse/TAP5-2686?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17555708#comment-17555708
]
Volker Lamp commented on TAP5-2686:
---
h4. Cause analysis
Even though {{popover.js}} is present (part of Bootstrap, see
{{{}/tapestry-core/src/main/resources/META-INF/assets/tapestry5/bootstrap4/js/popover.js{}}}),
it is not set up as a module (see {{{}JavaScriptModule.java:448{}}}), for no
obvious reason, probably simply forgotten.
h4. Workaround
Users can add the missing module setup by contributing to {{ModuleManager}}
like so:
{{@Contribute(ModuleManager.class)}}
{{public static void addPopover(MappedConfiguration config,}}
{{ @Path("${tapestry.asset.root}/bootstrap4/js/bootstrap-util.js")}}
{{ Resource bootstrapUtil)}}
{{ Resource popover = bootstrapUtil.forFile("popover.js");}}
{{ config.add}}
{{ (}}
{{ "bootstrap/popover", new JavaScriptModuleConfiguration(popover)}}
{{ .dependsOn("bootstrap/bootstrap-util")}}
{{ .dependsOn("bootstrap/popper")}}
{{ );}}
Unfortunately, this doesn't suffice to make popovers work due to a bug in the
dependency definition (see {{popover.js:8:84}} - The '.js' in
{{bootstrap/tooltip.js}} is wrong, it should simply say {{bootstrap/tooltip}}).
The necessary change was made in Bootstrap 4.6.0. Users would have to add
Bootstrap 4.6.+ to their project manually and configure Tapestry to use it (via
the {{tapestry.bootstrap-root}} configuration symbol) instead of the built-in
Bootstrap 4.3.1.
> require('bootstrap/popover') fails when using bootstrap 4
> -
>
> Key: TAP5-2686
> URL: https://issues.apache.org/jira/browse/TAP5-2686
> Project: Tapestry 5
> Issue Type: Bug
> Components: tapestry-core
>Affects Versions: 5.5.0, 5.6.0, 5.6.1, 5.6.2, 5.7.0, 5.6.3, 5.7.1, 5.7.2,
> 5.6.4, 5.7.3, 5.8.0, 5.8.1
>Reporter: Raigo Aljand
>Assignee: Volker Lamp
>Priority: Major
> Labels: bootstrap, javascript
>
> This code fails when using bootstrap 4:
> {code:java}
> require(['bootstrap/popover'], () => {
> console.log('success');
> })
> {code}
> The server returns a 404 error code when the browser requests for the
> bootstrap/popover module.
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
[jira] [Updated] (TAP5-2686) require('bootstrap/popover') fails when using bootstrap 4
[
https://issues.apache.org/jira/browse/TAP5-2686?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Volker Lamp updated TAP5-2686:
--
Affects Version/s: 5.7.3
5.6.4
> require('bootstrap/popover') fails when using bootstrap 4
> -
>
> Key: TAP5-2686
> URL: https://issues.apache.org/jira/browse/TAP5-2686
> Project: Tapestry 5
> Issue Type: Bug
> Components: tapestry-core
>Affects Versions: 5.5.0, 5.6.0, 5.6.1, 5.6.2, 5.7.0, 5.6.3, 5.7.1, 5.7.2,
> 5.6.4, 5.7.3, 5.8.0, 5.8.1
>Reporter: Raigo Aljand
>Assignee: Volker Lamp
>Priority: Major
> Labels: bootstrap, javascript
>
> This code fails when using bootstrap 4:
> {code:java}
> require(['bootstrap/popover'], () => {
> console.log('success');
> })
> {code}
> The server returns a 404 error code when the browser requests for the
> bootstrap/popover module.
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
[jira] [Updated] (TAP5-2686) require('bootstrap/popover') fails when using bootstrap 4
[
https://issues.apache.org/jira/browse/TAP5-2686?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Volker Lamp updated TAP5-2686:
--
Affects Version/s: 5.8.1
5.8.0
5.6.3
5.7.0
5.6.2
5.6.1
5.6.0
5.5.0
> require('bootstrap/popover') fails when using bootstrap 4
> -
>
> Key: TAP5-2686
> URL: https://issues.apache.org/jira/browse/TAP5-2686
> Project: Tapestry 5
> Issue Type: Bug
> Components: tapestry-core
>Affects Versions: 5.5.0, 5.6.0, 5.6.1, 5.6.2, 5.7.0, 5.6.3, 5.7.1, 5.7.2,
> 5.8.0, 5.8.1
>Reporter: Raigo Aljand
>Assignee: Volker Lamp
>Priority: Major
> Labels: bootstrap, javascript
>
> This code fails when using bootstrap 4:
> {code:java}
> require(['bootstrap/popover'], () => {
> console.log('success');
> })
> {code}
> The server returns a 404 error code when the browser requests for the
> bootstrap/popover module.
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
[jira] [Updated] (TAP5-2686) require('bootstrap/popover') fails when using bootstrap 4
[
https://issues.apache.org/jira/browse/TAP5-2686?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Volker Lamp updated TAP5-2686:
--
Affects Version/s: 5.7.1
> require('bootstrap/popover') fails when using bootstrap 4
> -
>
> Key: TAP5-2686
> URL: https://issues.apache.org/jira/browse/TAP5-2686
> Project: Tapestry 5
> Issue Type: Bug
> Components: tapestry-core
>Affects Versions: 5.7.1, 5.7.2
>Reporter: Raigo Aljand
>Assignee: Volker Lamp
>Priority: Major
> Labels: bootstrap, javascript
>
> This code fails when using bootstrap 4:
> {code:java}
> require(['bootstrap/popover'], () => {
> console.log('success');
> })
> {code}
> The server returns a 404 error code when the browser requests for the
> bootstrap/popover module.
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
[jira] [Updated] (TAP5-2732) Change default JavaScript infrastructure provider from Prototype to jQuery
[
https://issues.apache.org/jira/browse/TAP5-2732?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Volker Lamp updated TAP5-2732:
--
Description:
The Prototype JavaScript Framework has been the default JavaScript
infrastructure provider (see
{{SymbolConstants.JAVASCRIPT_INFRASTRUCTURE_PROVIDER}}) since Tapestry 5.4.
This issue is about changing the default to jQuery, mainly for the following
reasons:
# to reflect today's reality that jQuery is by far more popular than Prototype,
and hence Tapestry users are more likely to use jQuery rather than Prototype;
# to align the default js provider with the default css framework (Bootstrap),
which requires jQuery.
NB not to forget to update the Javadoc of
{{SymbolConstants.JAVASCRIPT_INFRASTRUCTURE_PROVIDER}}
was:
The Prototype JavaScript Framework has been the default JavaScript
infrastructure provider (see
{{SymbolConstants.JAVASCRIPT_INFRASTRUCTURE_PROVIDER}}) since Tapestry 5.4.
This issue is about changing the default to jQuery, mainly for the following
reasons:
# to reflect today's reality that jQuery is by far more popular than Prototype,
and hence Tapestry users are more likely to use jQuery rather than Prototype;
# to align the default js provider with the default css framework (Bootstrap),
which requires jQuery.
> Change default JavaScript infrastructure provider from Prototype to jQuery
> --
>
> Key: TAP5-2732
> URL: https://issues.apache.org/jira/browse/TAP5-2732
> Project: Tapestry 5
> Issue Type: Technical Debt
> Components: tapestry-core
>Reporter: Volker Lamp
>Priority: Major
> Labels: JavaScript, jQuery, prototype
>
> The Prototype JavaScript Framework has been the default JavaScript
> infrastructure provider (see
> {{SymbolConstants.JAVASCRIPT_INFRASTRUCTURE_PROVIDER}}) since Tapestry 5.4.
> This issue is about changing the default to jQuery, mainly for the following
> reasons:
> # to reflect today's reality that jQuery is by far more popular than
> Prototype, and hence Tapestry users are more likely to use jQuery rather than
> Prototype;
> # to align the default js provider with the default css framework
> (Bootstrap), which requires jQuery.
> NB not to forget to update the Javadoc of
> {{SymbolConstants.JAVASCRIPT_INFRASTRUCTURE_PROVIDER}}
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
[jira] [Created] (TAP5-2732) Change default JavaScript infrastructure provider from Prototype to jQuery
Volker Lamp created TAP5-2732:
-
Summary: Change default JavaScript infrastructure provider from
Prototype to jQuery
Key: TAP5-2732
URL: https://issues.apache.org/jira/browse/TAP5-2732
Project: Tapestry 5
Issue Type: Technical Debt
Components: tapestry-core
Reporter: Volker Lamp
The Prototype JavaScript Framework has been the default JavaScript
infrastructure provider (see
{{SymbolConstants.JAVASCRIPT_INFRASTRUCTURE_PROVIDER}}) since Tapestry 5.4.
This issue is about changing the default to jQuery, mainly for the following
reasons:
# to reflect today's reality that jQuery is by far more popular than Prototype,
and hence Tapestry users are more likely to use jQuery rather than Prototype;
# to align the default js provider with the default css framework (Bootstrap),
which requires jQuery.
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
[jira] [Closed] (TAP5-2625) Upgrade Prototype.js to the latest one, 1.7.3
[ https://issues.apache.org/jira/browse/TAP5-2625?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Volker Lamp closed TAP5-2625. - Resolution: Done > Upgrade Prototype.js to the latest one, 1.7.3 > - > > Key: TAP5-2625 > URL: https://issues.apache.org/jira/browse/TAP5-2625 > Project: Tapestry 5 > Issue Type: Improvement >Reporter: Thiago Henrique De Paula Figueiredo >Priority: Minor > Fix For: 5.6.0 > > -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Updated] (TAP5-2625) Upgrade Prototype.js to the latest one, 1.7.3
[ https://issues.apache.org/jira/browse/TAP5-2625?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Volker Lamp updated TAP5-2625: -- Fix Version/s: 5.6.0 > Upgrade Prototype.js to the latest one, 1.7.3 > - > > Key: TAP5-2625 > URL: https://issues.apache.org/jira/browse/TAP5-2625 > Project: Tapestry 5 > Issue Type: Improvement >Reporter: Thiago Henrique De Paula Figueiredo >Priority: Minor > Fix For: 5.6.0 > > -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Created] (TAP5-2731) Update version history on Wikipedia page
Volker Lamp created TAP5-2731: - Summary: Update version history on Wikipedia page Key: TAP5-2731 URL: https://issues.apache.org/jira/browse/TAP5-2731 Project: Tapestry 5 Issue Type: Task Reporter: Volker Lamp Current page states release 5.5 is the current version. -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Assigned] (TAP5-2686) require('bootstrap/popover') fails when using bootstrap 4
[
https://issues.apache.org/jira/browse/TAP5-2686?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Volker Lamp reassigned TAP5-2686:
-
Assignee: Volker Lamp
> require('bootstrap/popover') fails when using bootstrap 4
> -
>
> Key: TAP5-2686
> URL: https://issues.apache.org/jira/browse/TAP5-2686
> Project: Tapestry 5
> Issue Type: Bug
> Components: tapestry-core
>Affects Versions: 5.7.2
>Reporter: Raigo Aljand
>Assignee: Volker Lamp
>Priority: Major
> Labels: bootstrap, javascript
>
> This code fails when using bootstrap 4:
> {code:java}
> require(['bootstrap/popover'], () => {
> console.log('success');
> })
> {code}
> The server returns a 404 error code when the browser requests for the
> bootstrap/popover module.
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
[jira] [Created] (TAP5-2730) Misspelt ‘ComnpressedModules’ object id
Volker Lamp created TAP5-2730: - Summary: Misspelt ‘ComnpressedModules’ object id Key: TAP5-2730 URL: https://issues.apache.org/jira/browse/TAP5-2730 Project: Tapestry 5 Issue Type: Improvement Components: tapestry-core Reporter: Volker Lamp in JavaScriptModule.java:289 -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Created] (TAP5-2729) Improve javadoc of ServiceBinder.bind(Class)
Volker Lamp created TAP5-2729: - Summary: Improve javadoc of ServiceBinder.bind(Class) Key: TAP5-2729 URL: https://issues.apache.org/jira/browse/TAP5-2729 Project: Tapestry 5 Issue Type: Documentation Components: tapestry-ioc Reporter: Volker Lamp What‘s missing is a description of how an interface is implicitly bound to an implementation class if it is named …Impl.java. -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Reopened] (TAP5-2725) Lack of HTML escaping in validation error message
[
https://issues.apache.org/jira/browse/TAP5-2725?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Volker Lamp reopened TAP5-2725:
---
This issue was fixed using {{StringEscapeUtils}} from {{commons-lang3}} which
is available in the compile classpath as a transitive dependency via
{{commons-codec}}.
However, to avoid {{ClassNotFoundException}}s for users of {{tapestry-core}} at
runtime, an {{api}} dependency to {{commons-lang3}} should be added.
> Lack of HTML escaping in validation error message
> -
>
> Key: TAP5-2725
> URL: https://issues.apache.org/jira/browse/TAP5-2725
> Project: Tapestry 5
> Issue Type: Improvement
> Components: tapestry-core
>Reporter: Thiago Henrique De Paula Figueiredo
>Assignee: Thiago Henrique De Paula Figueiredo
>Priority: Major
> Fix For: 5.8.2
>
>
> The error messages in form field components are supposed to not have inline
> styles, so HTML should be escaped on them.
> Old description:
> -For almost all, if not all, validation error messages from Tapestry form
> field components, the value isn't shown, just the field name. DateField shows
> the value, so it must be changed to be consistent with the others.-
> -Notice this changes how the {{core-date-value-not-parseable}} message is
> used. The en, es, fr, it and pt_BR localizations were already updated in this
> ticket.-
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
[jira] [Updated] (TAP5-2683) Set MessageFormatter as a service instead of being hardcoded
[ https://issues.apache.org/jira/browse/TAP5-2683?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Volker Lamp updated TAP5-2683: -- Issue Type: Improvement (was: Bug) > Set MessageFormatter as a service instead of being hardcoded > > > Key: TAP5-2683 > URL: https://issues.apache.org/jira/browse/TAP5-2683 > Project: Tapestry 5 > Issue Type: Improvement >Reporter: Numa Schmeder >Priority: Minor > > Currently MessageFormatter is hard coded inside MapMessages. Therefor if you > want to change the type of formatter for example using MessageFormat instead > of StringFormat your need to override a lot of classes, namely: > * MessageSourceImpl > * MapMessages > * ComponentMessageSourceImpl > * MessageFormatterImpl > It should be easier to override the MessageFormatter instance with a custom > one to have specific parsing requirements. -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Reopened] (TAP5-2718) Tapestry Announcement lacks version
[
https://issues.apache.org/jira/browse/TAP5-2718?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Volker Lamp reopened TAP5-2718:
---
That didn't fix it. I'll create and push a test case.
> Tapestry Announcement lacks version
> ---
>
> Key: TAP5-2718
> URL: https://issues.apache.org/jira/browse/TAP5-2718
> Project: Tapestry 5
> Issue Type: Bug
> Components: tapestry-core
>Affects Versions: 5.8.1
>Reporter: Ben Weidig
>Assignee: Thiago Henrique De Paula Figueiredo
>Priority: Minor
> Fix For: 5.8.2
>
>
> The ASCII art announcement of Tapestry lists the version as UNKNOWN.
> See [https://lists.apache.org/thread/kgvo9r5rnltv5510r9l2s3qyjhjfmn78]
> It appears that
> tapestry-core/src/main/filtered-resources/META-INF/gradle/org.apache.tapestry/tapestry-core/project.properties
> is missing since 5.7
> The build.gradle seems to need it:
>
> {code:java}
> jar {
> from("src/main/filtered-resources") {
> filter(ReplaceTokens, tokens: [version: project.version])
> }
> }
> {code}
> The same is present in tapestry-http
>
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
[jira] [Assigned] (TAP5-2723) CronExpression fails handling L-
[ https://issues.apache.org/jira/browse/TAP5-2723?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Volker Lamp reassigned TAP5-2723: - Assignee: Volker Lamp > CronExpression fails handling L- > > > Key: TAP5-2723 > URL: https://issues.apache.org/jira/browse/TAP5-2723 > Project: Tapestry 5 > Issue Type: Bug > Components: tapestry-ioc >Affects Versions: 5.8.1 >Reporter: Ben Weidig >Assignee: Volker Lamp >Priority: Minor > > The org.apache.tapestry5.ioc.internal.services.cron.CronExpression "0 55 8 > L-9 * ? *" is parsed wrongly for "L-9". Most likely, dayOfWeek is affected, > too. > The expression is run in an endless loop because the current date is returned > instead of the next date of the expression. > See [https://lists.apache.org/thread/d8scf7gswxcfh8bokm4wwjpcbzy98n35] -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Resolved] (TAP5-2715) Client-side generated error message renders unstyled with Bootstrap 4
[
https://issues.apache.org/jira/browse/TAP5-2715?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Volker Lamp resolved TAP5-2715.
---
Fix Version/s: 5.8.2
Resolution: Fixed
> Client-side generated error message renders unstyled with Bootstrap 4
> -
>
> Key: TAP5-2715
> URL: https://issues.apache.org/jira/browse/TAP5-2715
> Project: Tapestry 5
> Issue Type: Bug
> Components: tapestry-core
>Affects Versions: 5.5.0, 5.6.0, 5.6.1, 5.6.2, 5.7.0, 5.6.3, 5.7.1, 5.7.2,
> 5.7.3, 5.8.0, 5.8.1
>Reporter: Volker Lamp
>Assignee: Volker Lamp
>Priority: Major
> Fix For: 5.8.2
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> TAP5-2712 delivered the fix for the output of {{}}.
> However, when {{}} is omitted (as is the case with the BeanEditor
> component, for instance), Tapestry uses client-side JavaScript instead.
> Apparently, {{fields.coffee:81}} must account for Bootstrap 4 (if enabled).
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
[jira] [Updated] (TAP5-2724) Resolve split package caused by DisableStrictChecks
[
https://issues.apache.org/jira/browse/TAP5-2724?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Volker Lamp updated TAP5-2724:
--
Description:
Different approaches were discussed on the
[tapestry-dev|https://lists.apache.org/thread/pp45so8j825p396wfozlv58chmo2m862]
mailing list.
* Move all compilation units in {{org.apache.tapestry5.annotations}} from
{{tapestry-core}} to {{tapestry5-annotations}}.
* Add a api dependency on {{tapestry5-annotations}} to {{tapestry-core}}.
was:
Different approaches were discussed on the
[tapestry-dev|https://lists.apache.org/thread/pp45so8j825p396wfozlv58chmo2m862]
mailing list.
* Move all compilation units in org.apache.tapestry5.annotations from
tapestry-core to tapestry5-annotations.
* Add a api dependency on tapestry5-annotations to tapestry-core.
> Resolve split package caused by DisableStrictChecks
> ---
>
> Key: TAP5-2724
> URL: https://issues.apache.org/jira/browse/TAP5-2724
> Project: Tapestry 5
> Issue Type: Improvement
> Components: tapestry-core
>Reporter: Volker Lamp
>Priority: Major
>
> Different approaches were discussed on the
> [tapestry-dev|https://lists.apache.org/thread/pp45so8j825p396wfozlv58chmo2m862]
> mailing list.
>
> * Move all compilation units in {{org.apache.tapestry5.annotations}} from
> {{tapestry-core}} to {{tapestry5-annotations}}.
> * Add a api dependency on {{tapestry5-annotations}} to {{tapestry-core}}.
>
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
[jira] [Updated] (TAP5-2724) Resolve split package caused by DisableStrictChecks
[ https://issues.apache.org/jira/browse/TAP5-2724?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Volker Lamp updated TAP5-2724: -- Description: Different approaches were discussed on the [tapestry-dev|https://lists.apache.org/thread/pp45so8j825p396wfozlv58chmo2m862] mailing list. * Move all compilation units in org.apache.tapestry5.annotations from tapestry-core to tapestry5-annotations. * Add a api dependency on tapestry5-annotations to tapestry-core. > Resolve split package caused by DisableStrictChecks > --- > > Key: TAP5-2724 > URL: https://issues.apache.org/jira/browse/TAP5-2724 > Project: Tapestry 5 > Issue Type: Improvement > Components: tapestry-core >Reporter: Volker Lamp >Priority: Major > > Different approaches were discussed on the > [tapestry-dev|https://lists.apache.org/thread/pp45so8j825p396wfozlv58chmo2m862] > mailing list. > > * Move all compilation units in org.apache.tapestry5.annotations from > tapestry-core to tapestry5-annotations. > * Add a api dependency on tapestry5-annotations to tapestry-core. > -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Created] (TAP5-2724) Resolve split package caused by DisableStrictChecks
Volker Lamp created TAP5-2724: - Summary: Resolve split package caused by DisableStrictChecks Key: TAP5-2724 URL: https://issues.apache.org/jira/browse/TAP5-2724 Project: Tapestry 5 Issue Type: Improvement Components: tapestry-core Reporter: Volker Lamp -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Commented] (TAP5-2655) Create annotation to disable validation in event handler methods
[
https://issues.apache.org/jira/browse/TAP5-2655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17532525#comment-17532525
]
Volker Lamp commented on TAP5-2655:
---
Adding DisableStrictChecks to the {{org.apache.tapestry5.annotations}} package
caused a split package (with {{tapestry-core}}), unfortunately undermining
TAP5-2641 and TAP5-2627.
> Create annotation to disable validation in event handler methods
>
>
> Key: TAP5-2655
> URL: https://issues.apache.org/jira/browse/TAP5-2655
> Project: Tapestry 5
> Issue Type: Improvement
>Reporter: Thiago Henrique De Paula Figueiredo
>Assignee: Thiago Henrique De Paula Figueiredo
>Priority: Minor
> Fix For: 5.6.2, 5.7.0
>
>
> When an event handler method refers to a non-existent component id, Tapestry
> throws an exception. In situations with template inheritance and extension
> points, it's hard or impossible to resolve this problem. A new annotation,
> @DisableStrictChecks, would be created for disabling this validation for
> specific methods.
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
[jira] [Assigned] (TAP5-2715) Client-side generated error message renders unstyled with Bootstrap 4
[
https://issues.apache.org/jira/browse/TAP5-2715?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Volker Lamp reassigned TAP5-2715:
-
Assignee: Volker Lamp
> Client-side generated error message renders unstyled with Bootstrap 4
> -
>
> Key: TAP5-2715
> URL: https://issues.apache.org/jira/browse/TAP5-2715
> Project: Tapestry 5
> Issue Type: Bug
> Components: tapestry-core
>Affects Versions: 5.5.0, 5.6.0, 5.6.1, 5.6.2, 5.7.0, 5.6.3, 5.7.1, 5.7.2,
> 5.7.3, 5.8.0, 5.8.1
>Reporter: Volker Lamp
>Assignee: Volker Lamp
>Priority: Major
>
> TAP5-2712 delivered the fix for the output of {{}}.
> However, when {{}} is omitted (as is the case with the BeanEditor
> component, for instance), Tapestry uses client-side JavaScript instead.
> Apparently, {{fields.coffee:81}} must account for Bootstrap 4 (if enabled).
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
[jira] [Closed] (TAP5-2722) Run tests with jvmArg -Duser.language=en
[
https://issues.apache.org/jira/browse/TAP5-2722?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Volker Lamp closed TAP5-2722.
-
No more complaints from Travis.
> Run tests with jvmArg -Duser.language=en
>
>
> Key: TAP5-2722
> URL: https://issues.apache.org/jira/browse/TAP5-2722
> Project: Tapestry 5
> Issue Type: Improvement
> Components: tapestry-core
>Reporter: Volker Lamp
>Assignee: Volker Lamp
>Priority: Minor
>
> {{CoreBehaviorsTests.exception_report()}} tests for an error message in
> English: _The element type "t:foobar" must be terminated by the matching
> end-tag ""_
> The language the message is displayed in depends on the JVM's user language
> configuration. Test failure can be avoided by explicitly configuring the test
> runner JVM to use English.
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
[jira] [Resolved] (TAP5-2722) Run tests with jvmArg -Duser.language=en
[
https://issues.apache.org/jira/browse/TAP5-2722?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Volker Lamp resolved TAP5-2722.
---
Resolution: Fixed
> Run tests with jvmArg -Duser.language=en
>
>
> Key: TAP5-2722
> URL: https://issues.apache.org/jira/browse/TAP5-2722
> Project: Tapestry 5
> Issue Type: Improvement
> Components: tapestry-core
>Reporter: Volker Lamp
>Assignee: Volker Lamp
>Priority: Minor
>
> {{CoreBehaviorsTests.exception_report()}} tests for an error message in
> English: _The element type "t:foobar" must be terminated by the matching
> end-tag ""_
> The language the message is displayed in depends on the JVM's user language
> configuration. Test failure can be avoided by explicitly configuring the test
> runner JVM to use English.
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
[jira] [Reopened] (TAP5-2722) Run tests with jvmArg -Duser.language=en
[
https://issues.apache.org/jira/browse/TAP5-2722?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Volker Lamp reopened TAP5-2722:
---
My commit 923247f causes LinkTransformerIntegrationTest to fail. I'll revert
that commit until I've figured out what's going on. Apologies for any
inconvenience.
> Run tests with jvmArg -Duser.language=en
>
>
> Key: TAP5-2722
> URL: https://issues.apache.org/jira/browse/TAP5-2722
> Project: Tapestry 5
> Issue Type: Improvement
> Components: tapestry-core
>Reporter: Volker Lamp
>Assignee: Volker Lamp
>Priority: Minor
>
> {{CoreBehaviorsTests.exception_report()}} tests for an error message in
> English: _The element type "t:foobar" must be terminated by the matching
> end-tag ""_
> The language the message is displayed in depends on the JVM's user language
> configuration. Test failure can be avoided by explicitly configuring the test
> runner JVM to use English.
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
[jira] [Resolved] (TAP5-2574) Add core translations for Norwegian Nynorsk (nn)
[
https://issues.apache.org/jira/browse/TAP5-2574?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Volker Lamp resolved TAP5-2574.
---
Fix Version/s: 5.8.2
Resolution: Fixed
> Add core translations for Norwegian Nynorsk (nn)
>
>
> Key: TAP5-2574
> URL: https://issues.apache.org/jira/browse/TAP5-2574
> Project: Tapestry 5
> Issue Type: Bug
> Components: tapestry-core
>Affects Versions: 5.4.1
>Reporter: Svein
>Assignee: Volker Lamp
>Priority: Major
> Labels: desired_for_5.5
> Fix For: 5.8.2
>
> Attachments: core_nn.properties
>
>
> {code}configuration.add(SymbolConstants.SUPPORTED_LOCALES, "no_NB,en");{code}
> {code}org.apache.tapestry5.internal.services.Request.getLocale() for returns
> "nb" for Norwegian{code}
> No *_no_NB.properties or *_no.properties are used. I think A way to alias
> locale is needed. E.g:
> {code}configuration.add(SymbolConstants.SUPPORTED_LOCALES,
> "no_NB{nb},en);{code}
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
[jira] [Resolved] (TAP5-2722) Run tests with jvmArg -Duser.language=en
[
https://issues.apache.org/jira/browse/TAP5-2722?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Volker Lamp resolved TAP5-2722.
---
Resolution: Implemented
> Run tests with jvmArg -Duser.language=en
>
>
> Key: TAP5-2722
> URL: https://issues.apache.org/jira/browse/TAP5-2722
> Project: Tapestry 5
> Issue Type: Improvement
> Components: tapestry-core
>Reporter: Volker Lamp
>Assignee: Volker Lamp
>Priority: Minor
>
> {{CoreBehaviorsTests.exception_report()}} tests for an error message in
> English: _The element type "t:foobar" must be terminated by the matching
> end-tag ""_
> The language the message is displayed in depends on the JVM's user language
> configuration. Test failure can be avoided by explicitly configuring the test
> runner JVM to use English.
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
[jira] [Assigned] (TAP5-2722) Run tests with jvmArg -Duser.language=en
[
https://issues.apache.org/jira/browse/TAP5-2722?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Volker Lamp reassigned TAP5-2722:
-
Assignee: Volker Lamp
> Run tests with jvmArg -Duser.language=en
>
>
> Key: TAP5-2722
> URL: https://issues.apache.org/jira/browse/TAP5-2722
> Project: Tapestry 5
> Issue Type: Improvement
> Components: tapestry-core
>Reporter: Volker Lamp
>Assignee: Volker Lamp
>Priority: Minor
>
> {{CoreBehaviorsTests.exception_report()}} tests for an error message in
> English: _The element type "t:foobar" must be terminated by the matching
> end-tag ""_
> The language the message is displayed in depends on the JVM's user language
> configuration. Test failure can be avoided by explicitly configuring the test
> runner JVM to use English.
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
[jira] [Created] (TAP5-2722) Run tests with jvmArg -Duser.language=en
Volker Lamp created TAP5-2722:
-
Summary: Run tests with jvmArg -Duser.language=en
Key: TAP5-2722
URL: https://issues.apache.org/jira/browse/TAP5-2722
Project: Tapestry 5
Issue Type: Improvement
Components: tapestry-core
Reporter: Volker Lamp
{{CoreBehaviorsTests.exception_report()}} tests for an error message in
English: _The element type "t:foobar" must be terminated by the matching
end-tag ""_
The language the message is displayed in depends on the JVM's user language
configuration. Test failure can be avoided by explicitly configuring the test
runner JVM to use English.
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
[jira] [Updated] (TAP5-2574) Add core translations for Norwegian Nynorsk
[
https://issues.apache.org/jira/browse/TAP5-2574?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Volker Lamp updated TAP5-2574:
--
Summary: Add core translations for Norwegian Nynorsk (was: No match on
Locale nb )
> Add core translations for Norwegian Nynorsk
> ---
>
> Key: TAP5-2574
> URL: https://issues.apache.org/jira/browse/TAP5-2574
> Project: Tapestry 5
> Issue Type: Bug
> Components: tapestry-core
>Affects Versions: 5.4.1
>Reporter: Svein
>Assignee: Volker Lamp
>Priority: Major
> Labels: desired_for_5.5
> Attachments: core_nn.properties
>
>
> {code}configuration.add(SymbolConstants.SUPPORTED_LOCALES, "no_NB,en");{code}
> {code}org.apache.tapestry5.internal.services.Request.getLocale() for returns
> "nb" for Norwegian{code}
> No *_no_NB.properties or *_no.properties are used. I think A way to alias
> locale is needed. E.g:
> {code}configuration.add(SymbolConstants.SUPPORTED_LOCALES,
> "no_NB{nb},en);{code}
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
[jira] [Updated] (TAP5-2574) Add core translations for Norwegian Nynorsk (nn)
[
https://issues.apache.org/jira/browse/TAP5-2574?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Volker Lamp updated TAP5-2574:
--
Summary: Add core translations for Norwegian Nynorsk (nn) (was: Add core
translations for Norwegian Nynorsk)
> Add core translations for Norwegian Nynorsk (nn)
>
>
> Key: TAP5-2574
> URL: https://issues.apache.org/jira/browse/TAP5-2574
> Project: Tapestry 5
> Issue Type: Bug
> Components: tapestry-core
>Affects Versions: 5.4.1
>Reporter: Svein
>Assignee: Volker Lamp
>Priority: Major
> Labels: desired_for_5.5
> Attachments: core_nn.properties
>
>
> {code}configuration.add(SymbolConstants.SUPPORTED_LOCALES, "no_NB,en");{code}
> {code}org.apache.tapestry5.internal.services.Request.getLocale() for returns
> "nb" for Norwegian{code}
> No *_no_NB.properties or *_no.properties are used. I think A way to alias
> locale is needed. E.g:
> {code}configuration.add(SymbolConstants.SUPPORTED_LOCALES,
> "no_NB{nb},en);{code}
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
[jira] [Assigned] (TAP5-2574) No match on Locale nb
[
https://issues.apache.org/jira/browse/TAP5-2574?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Volker Lamp reassigned TAP5-2574:
-
Assignee: Volker Lamp
> No match on Locale nb
> --
>
> Key: TAP5-2574
> URL: https://issues.apache.org/jira/browse/TAP5-2574
> Project: Tapestry 5
> Issue Type: Bug
> Components: tapestry-core
>Affects Versions: 5.4.1
>Reporter: Svein
>Assignee: Volker Lamp
>Priority: Major
> Labels: desired_for_5.5
> Attachments: core_nn.properties
>
>
> {code}configuration.add(SymbolConstants.SUPPORTED_LOCALES, "no_NB,en");{code}
> {code}org.apache.tapestry5.internal.services.Request.getLocale() for returns
> "nb" for Norwegian{code}
> No *_no_NB.properties or *_no.properties are used. I think A way to alias
> locale is needed. E.g:
> {code}configuration.add(SymbolConstants.SUPPORTED_LOCALES,
> "no_NB{nb},en);{code}
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
[jira] [Resolved] (TAP5-2609) Grid component doc: configuration sample code is incorrect
[
https://issues.apache.org/jira/browse/TAP5-2609?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Volker Lamp resolved TAP5-2609.
---
Fix Version/s: 5.8.2
Resolution: Fixed
Thank you, [~andrewfowler], for reporting this and providing the fix.
> Grid component doc: configuration sample code is incorrect
> --
>
> Key: TAP5-2609
> URL: https://issues.apache.org/jira/browse/TAP5-2609
> Project: Tapestry 5
> Issue Type: Bug
> Components: documentation
>Affects Versions: 5.4.4
>Reporter: Andrew Fowler
>Assignee: Volker Lamp
>Priority: Minor
> Fix For: 5.8.2
>
>
> In the "Configuring the Grid Component in the AppModule class" section of the
> [Grid component
> documentation|https://tapestry.apache.org/current/apidocs/org/apache/tapestry5/corelib/components/Grid.html]
> this code is given:
> {code}
> public static void contributeApplicationDefaults(MappedConfiguration String> configuration)
> {
> configuration.add(GridConstants.ROWS_PER_PAGE, "show");
> configuration.add(GridConstants.PAGER_POSITION, "bottom");
> configuration.add(GridConstants.TABLE_CLASS, "t-data-grid");
> }
> {code}
> This should be:
> {code}
> public static void contributeApplicationDefaults(MappedConfiguration String> configuration)
> {
> configuration.add(ComponentParameterConstants.GRID_ROWS_PER_PAGE, "25");
> configuration.add(ComponentParameterConstants.GRID_PAGER_POSITION, "top");
> configuration.add(ComponentParameterConstants.GRID_TABLE_CSS_CLASS, "table
> table-hover table-bordered table-striped");
> }
> {code}
> The relevant documentation source is here in pre-5.5.0:
> [Grid.xdoc:364|https://github.com/apache/tapestry-5/blob/master/tapestry-core/src/main/java/org/apache/tapestry5/corelib/components/Grid.xdoc#L364]
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
[jira] [Assigned] (TAP5-2609) Grid component doc: configuration sample code is incorrect
[
https://issues.apache.org/jira/browse/TAP5-2609?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Volker Lamp reassigned TAP5-2609:
-
Assignee: Volker Lamp
> Grid component doc: configuration sample code is incorrect
> --
>
> Key: TAP5-2609
> URL: https://issues.apache.org/jira/browse/TAP5-2609
> Project: Tapestry 5
> Issue Type: Bug
> Components: documentation
>Affects Versions: 5.4.4
>Reporter: Andrew Fowler
>Assignee: Volker Lamp
>Priority: Minor
>
> In the "Configuring the Grid Component in the AppModule class" section of the
> [Grid component
> documentation|https://tapestry.apache.org/current/apidocs/org/apache/tapestry5/corelib/components/Grid.html]
> this code is given:
> {code}
> public static void contributeApplicationDefaults(MappedConfiguration String> configuration)
> {
> configuration.add(GridConstants.ROWS_PER_PAGE, "show");
> configuration.add(GridConstants.PAGER_POSITION, "bottom");
> configuration.add(GridConstants.TABLE_CLASS, "t-data-grid");
> }
> {code}
> This should be:
> {code}
> public static void contributeApplicationDefaults(MappedConfiguration String> configuration)
> {
> configuration.add(ComponentParameterConstants.GRID_ROWS_PER_PAGE, "25");
> configuration.add(ComponentParameterConstants.GRID_PAGER_POSITION, "top");
> configuration.add(ComponentParameterConstants.GRID_TABLE_CSS_CLASS, "table
> table-hover table-bordered table-striped");
> }
> {code}
> The relevant documentation source is here in pre-5.5.0:
> [Grid.xdoc:364|https://github.com/apache/tapestry-5/blob/master/tapestry-core/src/main/java/org/apache/tapestry5/corelib/components/Grid.xdoc#L364]
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
[jira] [Commented] (TAP5-2721) Broken links to 5.8.1 asc files on download page
[ https://issues.apache.org/jira/browse/TAP5-2721?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17524266#comment-17524266 ] Volker Lamp commented on TAP5-2721: --- Yes, [~sebb], you are right. Thank you for notifying us. Much appreciated. > Broken links to 5.8.1 asc files on download page > > > Key: TAP5-2721 > URL: https://issues.apache.org/jira/browse/TAP5-2721 > Project: Tapestry 5 > Issue Type: Bug >Reporter: Sebb >Priority: Critical > > The 5.8.1 asc file links on the download page do not work. > Looks like the files were not uploaded -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Assigned] (TAP5-2714) Checkbox component with Boostrap4
[
https://issues.apache.org/jira/browse/TAP5-2714?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Volker Lamp reassigned TAP5-2714:
-
Assignee: Volker Lamp
> Checkbox component with Boostrap4
> -
>
> Key: TAP5-2714
> URL: https://issues.apache.org/jira/browse/TAP5-2714
> Project: Tapestry 5
> Issue Type: Bug
> Components: tapestry-core
>Affects Versions: 5.5.0, 5.6.0, 5.6.1, 5.6.2, 5.7.0, 5.6.3, 5.7.1, 5.7.2,
> 5.6.4, 5.7.3, 5.8.0, 5.8.1
>Reporter: Volker Lamp
>Assignee: Volker Lamp
>Priority: Major
>
> With Bootstrap4 enabled, the Checkbox component does not render the Bootstrap
> 4 style {{form-check-input}} css class. Likewise, the Label component renders
> Bootstrap 3 style {{control-label}} whereas it should be rendering Bootstrap
> 4 style {{{}form-check-label{}}}.
> As a workaround, one can use Checkbox and Label directly and specify the
> correct css classes. When those are wrapped by a BeanEditor, one has to
> overwrite the property first like so {{ ...
> }}.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Resolved] (TAP5-2607) Update Spanish (es) translation
[ https://issues.apache.org/jira/browse/TAP5-2607?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Volker Lamp resolved TAP5-2607. --- Fix Version/s: 5.8.2 Resolution: Implemented Thank you for providing a patch, [~picodotdev]. > Update Spanish (es) translation > --- > > Key: TAP5-2607 > URL: https://issues.apache.org/jira/browse/TAP5-2607 > Project: Tapestry 5 > Issue Type: Improvement > Components: tapestry-core, tapestry-kaptcha >Affects Versions: 5.5.0 >Reporter: picodotdev >Assignee: Volker Lamp >Priority: Trivial > Fix For: 5.8.2 > > Attachments: update_spanish_translation.patch > > > Update Spanish(es) translation. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Updated] (TAP5-2607) Update Spanish (es) translation
[ https://issues.apache.org/jira/browse/TAP5-2607?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Volker Lamp updated TAP5-2607: -- Summary: Update Spanish (es) translation (was: Update Spanish(es) translation) > Update Spanish (es) translation > --- > > Key: TAP5-2607 > URL: https://issues.apache.org/jira/browse/TAP5-2607 > Project: Tapestry 5 > Issue Type: Improvement > Components: tapestry-core, tapestry-kaptcha >Affects Versions: 5.5.0 >Reporter: picodotdev >Assignee: Volker Lamp >Priority: Trivial > Attachments: update_spanish_translation.patch > > > Update Spanish(es) translation. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Closed] (TAP5-2648) Broken link to FormInjector
[
https://issues.apache.org/jira/browse/TAP5-2648?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Volker Lamp closed TAP5-2648.
-
Resolution: Done
> Broken link to FormInjector
> ---
>
> Key: TAP5-2648
> URL: https://issues.apache.org/jira/browse/TAP5-2648
> Project: Tapestry 5
> Issue Type: Documentation
> Components: documentation
>Reporter: Volker Lamp
>Assignee: Volker Lamp
>Priority: Trivial
> Labels: easyfix
>
> The [component reference
> page|https://tapestry.apache.org/component-reference.html#ComponentReference-FormComponents]
> includes a [broken
> link|http://tapestry.apache.org/current/apidocs/org/apache/tapestry5/corelib/components/FormInjector.html]
> to the {{FormInjector}} component, which was removed in T 5.4.
> I recommend either re-creating the page (for users of older versions) or
> removing the page from the listing alltogether.
>
>
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Commented] (TAP5-2648) Broken link to FormInjector
[
https://issues.apache.org/jira/browse/TAP5-2648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17522940#comment-17522940
]
Volker Lamp commented on TAP5-2648:
---
Removed the broken link.
> Broken link to FormInjector
> ---
>
> Key: TAP5-2648
> URL: https://issues.apache.org/jira/browse/TAP5-2648
> Project: Tapestry 5
> Issue Type: Documentation
> Components: documentation
>Reporter: Volker Lamp
>Assignee: Volker Lamp
>Priority: Trivial
> Labels: easyfix
>
> The [component reference
> page|https://tapestry.apache.org/component-reference.html#ComponentReference-FormComponents]
> includes a [broken
> link|http://tapestry.apache.org/current/apidocs/org/apache/tapestry5/corelib/components/FormInjector.html]
> to the {{FormInjector}} component, which was removed in T 5.4.
> I recommend either re-creating the page (for users of older versions) or
> removing the page from the listing alltogether.
>
>
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Assigned] (TAP5-2648) Broken link to FormInjector
[
https://issues.apache.org/jira/browse/TAP5-2648?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Volker Lamp reassigned TAP5-2648:
-
Assignee: Volker Lamp
> Broken link to FormInjector
> ---
>
> Key: TAP5-2648
> URL: https://issues.apache.org/jira/browse/TAP5-2648
> Project: Tapestry 5
> Issue Type: Documentation
> Components: documentation
>Reporter: Volker Lamp
>Assignee: Volker Lamp
>Priority: Trivial
> Labels: easyfix
>
> The [component reference
> page|https://tapestry.apache.org/component-reference.html#ComponentReference-FormComponents]
> includes a [broken
> link|http://tapestry.apache.org/current/apidocs/org/apache/tapestry5/corelib/components/FormInjector.html]
> to the {{FormInjector}} component, which was removed in T 5.4.
> I recommend either re-creating the page (for users of older versions) or
> removing the page from the listing alltogether.
>
>
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Assigned] (TAP5-2607) Update Spanish(es) translation
[ https://issues.apache.org/jira/browse/TAP5-2607?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Volker Lamp reassigned TAP5-2607: - Assignee: Volker Lamp > Update Spanish(es) translation > -- > > Key: TAP5-2607 > URL: https://issues.apache.org/jira/browse/TAP5-2607 > Project: Tapestry 5 > Issue Type: Improvement > Components: tapestry-core, tapestry-kaptcha >Affects Versions: 5.5.0 >Reporter: picodotdev >Assignee: Volker Lamp >Priority: Trivial > Attachments: update_spanish_translation.patch > > > Update Spanish(es) translation. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Updated] (TAP5-2719) Missing depenency for commons-fileupload
[
https://issues.apache.org/jira/browse/TAP5-2719?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Volker Lamp updated TAP5-2719:
--
Description:
Similar to TAP5-2716 and TAP5-2717, the dependency for {{commons-fileupload}}
got lost.
The fix is to replace {{implementation}} in {{tapestry-upload/build.gradle:5}}
to {{{}api{}}}.
Users of version 5.8.1 can add {{implementation
'commons-fileupload:commons-fileupload:1.3.2'}} to their own build.gradle (or
similar for pom.xml) as a workaround.
was:
Similar to TAP5-2717 and TAP5-2718, the dependency for {{commons-fileupload}}
got lost.
The fix is to replace {{implementation}} in {{tapestry-upload/build.gradle:5}}
to {{api}}.
Users of version 5.8.1 can add {{implementation
'commons-fileupload:commons-fileupload:1.3.2'}} to their own build.gradle (or
similar for pom.xml) as a workaround.
> Missing depenency for commons-fileupload
>
>
> Key: TAP5-2719
> URL: https://issues.apache.org/jira/browse/TAP5-2719
> Project: Tapestry 5
> Issue Type: Bug
> Components: tapestry-upload
>Affects Versions: 5.8.1
>Reporter: Volker Lamp
>Priority: Major
>
> Similar to TAP5-2716 and TAP5-2717, the dependency for {{commons-fileupload}}
> got lost.
> The fix is to replace {{implementation}} in
> {{tapestry-upload/build.gradle:5}} to {{{}api{}}}.
> Users of version 5.8.1 can add {{implementation
> 'commons-fileupload:commons-fileupload:1.3.2'}} to their own build.gradle (or
> similar for pom.xml) as a workaround.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Created] (TAP5-2719) Missing depenency for commons-fileupload
Volker Lamp created TAP5-2719:
-
Summary: Missing depenency for commons-fileupload
Key: TAP5-2719
URL: https://issues.apache.org/jira/browse/TAP5-2719
Project: Tapestry 5
Issue Type: Bug
Components: tapestry-upload
Affects Versions: 5.8.1
Reporter: Volker Lamp
Similar to TAP5-2717 and TAP5-2718, the dependency for {{commons-fileupload}}
got lost.
The fix is to replace {{implementation}} in {{tapestry-upload/build.gradle:5}}
to {{api}}.
Users of version 5.8.1 can add {{implementation
'commons-fileupload:commons-fileupload:1.3.2'}} to their own build.gradle (or
similar for pom.xml) as a workaround.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Created] (TAP5-2715) Client-side generated error message renders unstyled with Bootstrap 4
Volker Lamp created TAP5-2715:
-
Summary: Client-side generated error message renders unstyled with
Bootstrap 4
Key: TAP5-2715
URL: https://issues.apache.org/jira/browse/TAP5-2715
Project: Tapestry 5
Issue Type: Bug
Components: tapestry-core
Affects Versions: 5.8.1, 5.8.0, 5.7.3, 5.7.2, 5.7.1, 5.6.3, 5.7.0, 5.6.2,
5.6.1, 5.6.0, 5.5.0
Reporter: Volker Lamp
TAP5-2712 delivered the fix for the output of {{}}.
However, when {{}} is omitted (as is the case with the BeanEditor
component, for instance), Tapestry uses client-side JavaScript instead.
Apparently, {{fields.coffee:81}} must account for Bootstrap 4 (if enabled).
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Created] (TAP5-2714) Checkbox component with Boostrap4
Volker Lamp created TAP5-2714:
-
Summary: Checkbox component with Boostrap4
Key: TAP5-2714
URL: https://issues.apache.org/jira/browse/TAP5-2714
Project: Tapestry 5
Issue Type: Bug
Components: tapestry-core
Affects Versions: 5.8.1, 5.8.0, 5.7.3, 5.6.4, 5.7.2, 5.7.1, 5.6.3, 5.7.0,
5.6.2, 5.6.1, 5.6.0, 5.5.0
Reporter: Volker Lamp
With Bootstrap4 enabled, the Checkbox component does not render the Bootstrap 4
style {{form-check-input}} css class. Likewise, the Label component renders
Bootstrap 3 style {{control-label}} whereas it should be rendering Bootstrap 4
style {{{}form-check-label{}}}.
As a workaround, one can use Checkbox and Label directly and specify the
correct css classes. When those are wrapped by a BeanEditor, one has to
overwrite the property first like so {{ ...
}}.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Updated] (TAP5-2648) Broken link to FormInjector
[
https://issues.apache.org/jira/browse/TAP5-2648?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Volker Lamp updated TAP5-2648:
--
Description:
The [component reference
page|https://tapestry.apache.org/component-reference.html#ComponentReference-FormComponents]
includes a [broken
link|http://tapestry.apache.org/current/apidocs/org/apache/tapestry5/corelib/components/FormInjector.html]
to the {{FormInjector}} component, which was removed in T 5.4.
I recommend either re-creating the page (for users of older versions) or
removing the page from the listing alltogether.
was:
The [component reference
page|[https://tapestry.apache.org/component-reference.html#ComponentReference-FormComponents]]
includes a [broken
link|[http://example.com|http://tapestry.apache.org/current/apidocs/org/apache/tapestry5/corelib/components/FormInjector.html]]
to the {{FormInjector}} component, which was removed in T 5.4.
I recommend either re-creating the page (for users of older versions) or
removing the page from the listing alltogether.
> Broken link to FormInjector
> ---
>
> Key: TAP5-2648
> URL: https://issues.apache.org/jira/browse/TAP5-2648
> Project: Tapestry 5
> Issue Type: Documentation
> Components: documentation
>Reporter: Volker Lamp
>Priority: Trivial
> Labels: easyfix
>
> The [component reference
> page|https://tapestry.apache.org/component-reference.html#ComponentReference-FormComponents]
> includes a [broken
> link|http://tapestry.apache.org/current/apidocs/org/apache/tapestry5/corelib/components/FormInjector.html]
> to the {{FormInjector}} component, which was removed in T 5.4.
> I recommend either re-creating the page (for users of older versions) or
> removing the page from the listing alltogether.
>
>
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Commented] (TAP5-2654) Remove Asset2 by merging it into Asset
[ https://issues.apache.org/jira/browse/TAP5-2654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17511239#comment-17511239 ] Volker Lamp commented on TAP5-2654: --- This ticket can be closed as the change made it into release 5.7.0. > Remove Asset2 by merging it into Asset > -- > > Key: TAP5-2654 > URL: https://issues.apache.org/jira/browse/TAP5-2654 > Project: Tapestry 5 > Issue Type: Improvement >Reporter: Thiago Henrique De Paula Figueiredo >Priority: Minor > > Asset2 was introduced as a workaround to include a new method in Asset > without breaking compatibility, since that was done when Tapestry wasn't > built on Java 8+ yet. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Created] (TAP5-2707) GridPager Component with Boostrap4
Volker Lamp created TAP5-2707: - Summary: GridPager Component with Boostrap4 Key: TAP5-2707 URL: https://issues.apache.org/jira/browse/TAP5-2707 Project: Tapestry 5 Issue Type: Bug Components: tapestry-core Affects Versions: 5.8.0, 5.7.3, 5.6.4, 5.7.2, 5.7.1, 5.6.3, 5.7.0, 5.6.2, 5.6.1, 5.6.0, 5.5.0 Reporter: Volker Lamp Creating this issue as a reminder of [~gragaller]'s [https://lists.apache.org/thread/p0vw5yhhvzj703t4pdvh9qhsflfzpxtz|post on the tapestry-users list]). The workarounds described by [~thiagohp] in response to that post are useful. However, the fix should make it into Tapestry's code base. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Commented] (TAP5-2668) Move spock-tapestry extension to tapestry-test
[ https://issues.apache.org/jira/browse/TAP5-2668?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17349825#comment-17349825 ] Volker Lamp commented on TAP5-2668: --- See the attachments section for the patch I've just uploaded. Take this post as my promise to look after tapestry-spock in the future. I hope I got all the Tapestry-style formatting right. Similarly, can you please review if the license information at the head of each of the files is correct. > Move spock-tapestry extension to tapestry-test > -- > > Key: TAP5-2668 > URL: https://issues.apache.org/jira/browse/TAP5-2668 > Project: Tapestry 5 > Issue Type: Wish > Components: tapestry-test >Reporter: Leonard Brünings >Priority: Major > Attachments: TAP5-2668.patch > > > Hi I'm the maintainer of the Spock Framework and I'd like to propose, that > the spock-tapestry extensions is migrated to tapestry-test or tapestry-spock. > The current implementation supports only 5.4.3 and a check with 5.7.1 > revealed some removed classes that would require another layer of reflection > indirection to support different versions. > In my opinion it would make more sense to move the extension to Tapestry, as > this would simplify the code quite a bit. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (TAP5-2668) Move spock-tapestry extension to tapestry-test
[ https://issues.apache.org/jira/browse/TAP5-2668?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Volker Lamp updated TAP5-2668: -- Attachment: TAP5-2668.patch > Move spock-tapestry extension to tapestry-test > -- > > Key: TAP5-2668 > URL: https://issues.apache.org/jira/browse/TAP5-2668 > Project: Tapestry 5 > Issue Type: Wish > Components: tapestry-test >Reporter: Leonard Brünings >Priority: Major > Attachments: TAP5-2668.patch > > > Hi I'm the maintainer of the Spock Framework and I'd like to propose, that > the spock-tapestry extensions is migrated to tapestry-test or tapestry-spock. > The current implementation supports only 5.4.3 and a check with 5.7.1 > revealed some removed classes that would require another layer of reflection > indirection to support different versions. > In my opinion it would make more sense to move the extension to Tapestry, as > this would simplify the code quite a bit. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (TAP5-2647) Tapestry website search function not working
[ https://issues.apache.org/jira/browse/TAP5-2647?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17348806#comment-17348806 ] Volker Lamp commented on TAP5-2647: --- Very good. Thank you for fixing it. Let close the issue Or at least have priority downgraded. The last Tapestry 4 release is some 13 years old now. It doesn't seem to be used much any more. > Tapestry website search function not working > > > Key: TAP5-2647 > URL: https://issues.apache.org/jira/browse/TAP5-2647 > Project: Tapestry 5 > Issue Type: Bug > Components: documentation >Reporter: Volker Lamp >Assignee: Ben Weidig >Priority: Major > Labels: documentation > > Entering a search argument in the search field in the top right corner of the > Tapestry website yields an essentially empty result page. This is > irrespective of the search argument. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (TAP5-2668) Move spock-tapestry extension to tapestry-test
[
https://issues.apache.org/jira/browse/TAP5-2668?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17342867#comment-17342867
]
Volker Lamp commented on TAP5-2668:
---
Unfortunately, the next release of {{spock-tapestry}} is not going to adapt to
the breaking changes introduced by Tapestry 5.7, as [~leonard84] indicated in
the
[discussion|https://github.com/spockframework/spock/pull/1315#discussion_r630230301]
related with my pull request towards {{spock-tapestry}}. Actually, it appears
to me the Spock maintainers wouldn't mind getting rid of {{spock-tapestry}}
altogether.
While sticking with a Tapestry 5.7 compatible {{spock-tapestry}} would be the
most convenient solution with regard to existing Spock specs, migrating to
{{tapestry-spock}} would still be a better option than having to introduce a
third party dependency or rolling one's own Spock extension.
I'm ready to get the adoption work done. It doesn't look very complicated. I'd
also volunteer to take care of maintaining the code, so to address your main
concern, Thiago. You never know what the future holds, but I've been running
and growing a Tapestry 5 based webapp since 2008 and I don't intend to switch
to another framework any time soon.
> Move spock-tapestry extension to tapestry-test
> --
>
> Key: TAP5-2668
> URL: https://issues.apache.org/jira/browse/TAP5-2668
> Project: Tapestry 5
> Issue Type: Wish
> Components: tapestry-test
>Reporter: Leonard Brünings
>Priority: Major
>
> Hi I'm the maintainer of the Spock Framework and I'd like to propose, that
> the spock-tapestry extensions is migrated to tapestry-test or tapestry-spock.
> The current implementation supports only 5.4.3 and a check with 5.7.1
> revealed some removed classes that would require another layer of reflection
> indirection to support different versions.
> In my opinion it would make more sense to move the extension to Tapestry, as
> this would simplify the code quite a bit.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Created] (TAP5-2679) Checklist component: Remove outdated documentation
Volker Lamp created TAP5-2679: - Summary: Checklist component: Remove outdated documentation Key: TAP5-2679 URL: https://issues.apache.org/jira/browse/TAP5-2679 Project: Tapestry 5 Issue Type: Documentation Components: tapestry-core Affects Versions: 5.6.4, 5.7.2, 5.7.1, 5.6.3, 5.7.0, 5.6.2, 5.6.1, 5.6.0, 5.5.0 Reporter: Volker Lamp The documentation for the Checklist components says that "each checkbox and its label is enclosed by a div element whose css attribute is set to t-checklist-row." As of release 5.5.0 that's no longer true. The documentation should be updated accordingly. The fix is easy: in Checklist.xdoc, delete lines 102-113. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (TAP5-2677) @PostConstruct (javax.annotation) is missing with JDK 11 & <5.7
[
https://issues.apache.org/jira/browse/TAP5-2677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17331885#comment-17331885
]
Volker Lamp commented on TAP5-2677:
---
I got the same results - CNF exception with 5.6.4. All good with 5.7.2.
The missing dependency should be added in runtime (not compile) scope though.
> @PostConstruct (javax.annotation) is missing with JDK 11 & <5.7
> ---
>
> Key: TAP5-2677
> URL: https://issues.apache.org/jira/browse/TAP5-2677
> Project: Tapestry 5
> Issue Type: Bug
> Components: tapestry-ioc
>Affects Versions: 5.6.4
>Reporter: Ben Weidig
>Assignee: Ben Weidig
>Priority: Major
>
> It looks like a
> {code:java}
> compile "javax.annotation:javax.annotation-api:1.3.2"
> {code}
> is missing for < 5.7 in ioc build.gradle, but I have to make sure the error
> isn't on my side.
> Usually the dependency (or an equivalent) is pulled by other dependencies,
> but I started a new ioc/core non-web-app with minimal dependencies, and it
> crashes on startup:
> {code:java}
> 2021-04-24 11:49:05,903: ERROR [org.apache.tapestry5.ioc.Registry]:
> javax/annotation/PostConstruct
> 2021-04-24 11:49:05,903: ERROR [org.apache.tapestry5.ioc.Registry]:
> Operations trace:
> 2021-04-24 11:49:05,903: ERROR [org.apache.tapestry5.ioc.Registry]: [ 1]
> Creating non-proxied instance of service ServiceConfigurationListenerHub
> 2021-04-24 11:49:05,903: ERROR [org.apache.tapestry5.ioc.Registry]: [ 2]
> Creating plan to instantiate
> org.apache.tapestry5.ioc.services.ServiceConfigurationListenerHub via public
> org.apache.tapestry5.ioc.services.ServiceConfigurationListenerHub(java.util.List)
> Exception in thread "main" java.lang.NoClassDefFoundError:
> javax/annotation/PostConstruct
> at
> org.apache.tapestry5.ioc.internal.util.InternalUtils.extendPlanForPostInjectionMethods(InternalUtils.java:1502)
> at
> org.apache.tapestry5.ioc.internal.util.InternalUtils.access$300(InternalUtils.java:50)
> at
> org.apache.tapestry5.ioc.internal.util.InternalUtils$20.invoke(InternalUtils.java:1382)
> at
> org.apache.tapestry5.ioc.internal.util.InternalUtils$20.invoke(InternalUtils.java:1366)
> at
> org.apache.tapestry5.ioc.internal.OperationTrackerImpl.invoke(OperationTrackerImpl.java:82)
> at
> org.apache.tapestry5.ioc.internal.PerThreadOperationTracker.invoke(PerThreadOperationTracker.java:72)
> at
> org.apache.tapestry5.ioc.internal.RegistryImpl.invoke(RegistryImpl.java:1265)
> at
> org.apache.tapestry5.ioc.internal.util.InternalUtils.createConstructorConstructionPlan(InternalUtils.java:1363)
> at
> org.apache.tapestry5.ioc.internal.ConstructorServiceCreator.getPlan(ConstructorServiceCreator.java:52)
> at
> org.apache.tapestry5.ioc.internal.ConstructorServiceCreator.createObject(ConstructorServiceCreator.java:62)
> at
> org.apache.tapestry5.ioc.internal.ModuleImpl$4.invoke(ModuleImpl.java:295)
> at
> org.apache.tapestry5.ioc.internal.OperationTrackerImpl.invoke(OperationTrackerImpl.java:82)
> at
> org.apache.tapestry5.ioc.internal.PerThreadOperationTracker.invoke(PerThreadOperationTracker.java:72)
> at
> org.apache.tapestry5.ioc.internal.RegistryImpl.invoke(RegistryImpl.java:1265)
> at
> org.apache.tapestry5.ioc.internal.ModuleImpl.create(ModuleImpl.java:344)
> at
> org.apache.tapestry5.ioc.internal.ModuleImpl.access$100(ModuleImpl.java:40)
> at
> org.apache.tapestry5.ioc.internal.ModuleImpl$1.invoke(ModuleImpl.java:198)
> at
> org.apache.tapestry5.ioc.internal.util.ConcurrentBarrier.withWrite(ConcurrentBarrier.java:139)
> at
> org.apache.tapestry5.ioc.internal.ModuleImpl$2.invoke(ModuleImpl.java:215)
> at
> org.apache.tapestry5.ioc.internal.util.ConcurrentBarrier.withRead(ConcurrentBarrier.java:83)
> at
> org.apache.tapestry5.ioc.internal.ModuleImpl.findOrCreate(ModuleImpl.java:221)
> at
> org.apache.tapestry5.ioc.internal.ModuleImpl.getService(ModuleImpl.java:112)
> at
> org.apache.tapestry5.ioc.internal.RegistryImpl.getService(RegistryImpl.java:497)
> at
> org.apache.tapestry5.ioc.internal.RegistryImpl.getServiceByTypeAlone(RegistryImpl.java:788)
> at
> org.apache.tapestry5.ioc.internal.RegistryImpl.getServiceByTypeAndMarkers(RegistryImpl.java:802)
> at
> org.apache.tapestry5.ioc.internal.RegistryImpl.getService(RegistryImpl.java:760)
> at
> org.apache.tapestry5.ioc.internal.RegistryImpl.(RegistryImpl.java:212)
> at
> org.apache.tapestry5.ioc.RegistryBuilder.build(RegistryBuilder.java:181)
> at
> org.apache.tapestry5.internal.TapestryAppInitializer.createRegistry(TapestryAppInitializer.java:173)
> at
>
[jira] [Updated] (TAP5-2676) Adjust build script for Java 9+
[ https://issues.apache.org/jira/browse/TAP5-2676?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Volker Lamp updated TAP5-2676: -- Attachment: TAP5-2676.patch > Adjust build script for Java 9+ > --- > > Key: TAP5-2676 > URL: https://issues.apache.org/jira/browse/TAP5-2676 > Project: Tapestry 5 > Issue Type: Task >Reporter: Volker Lamp >Priority: Minor > Labels: easyfix, patch > Attachments: TAP5-2676.patch > > > _Note: Component is 'tapestry-javadoc' but wasn't available from the dropdown > menu._ > The Gradle build script (build.gradle) attempts to add tools.jar as a file > dependency. In Java 9, however, tools.jar was removed/renamed. > Proposing to remove the file dependency when compiling with Java 9 or later. > All tests still pass when doing so. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (TAP5-2676) Adjust build script for Java 9+
[ https://issues.apache.org/jira/browse/TAP5-2676?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Volker Lamp updated TAP5-2676: -- Summary: Adjust build script for Java 9+ (was: build script) > Adjust build script for Java 9+ > --- > > Key: TAP5-2676 > URL: https://issues.apache.org/jira/browse/TAP5-2676 > Project: Tapestry 5 > Issue Type: Task >Reporter: Volker Lamp >Priority: Minor > Labels: easyfix, patch > > _Note: Component is 'tapestry-javadoc' but wasn't available from the dropdown > menu._ > The Gradle build script (build.gradle) attempts to add tools.jar as a file > dependency. In Java 9, however, tools.jar was removed/renamed. > Proposing to remove the file dependency when compiling with Java 9 or later. > All tests still pass when doing so. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (TAP5-2676) build script
Volker Lamp created TAP5-2676: - Summary: build script Key: TAP5-2676 URL: https://issues.apache.org/jira/browse/TAP5-2676 Project: Tapestry 5 Issue Type: Task Reporter: Volker Lamp _Note: Component is 'tapestry-javadoc' but wasn't available from the dropdown menu._ The Gradle build script (build.gradle) attempts to add tools.jar as a file dependency. In Java 9, however, tools.jar was removed/renamed. Proposing to remove the file dependency when compiling with Java 9 or later. All tests still pass when doing so. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (TAP5-2675) Avoid multiple Groovy compilers on classpath
[ https://issues.apache.org/jira/browse/TAP5-2675?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Volker Lamp updated TAP5-2675: -- Labels: easyfix patch (was: easyfix) > Avoid multiple Groovy compilers on classpath > > > Key: TAP5-2675 > URL: https://issues.apache.org/jira/browse/TAP5-2675 > Project: Tapestry 5 > Issue Type: Task > Components: tapestry-webresources >Reporter: Volker Lamp >Priority: Minor > Labels: easyfix, patch > Attachments: TAP5-2675.patch > > > Transitive dependencies of (a) spock-tapestry and (b) geb-spock cause two > different Groovy compilers to be included in the testCompile configuration. > Proposing to exclude groovy-all from the geb-spock dependency. All tests > still pass when doing so. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (TAP5-2675) Avoid multiple Groovy compilers on classpath
[ https://issues.apache.org/jira/browse/TAP5-2675?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Volker Lamp updated TAP5-2675: -- Attachment: TAP5-2675.patch > Avoid multiple Groovy compilers on classpath > > > Key: TAP5-2675 > URL: https://issues.apache.org/jira/browse/TAP5-2675 > Project: Tapestry 5 > Issue Type: Task > Components: tapestry-webresources >Reporter: Volker Lamp >Priority: Minor > Labels: easyfix > Attachments: TAP5-2675.patch > > > Transitive dependencies of (a) spock-tapestry and (b) geb-spock cause two > different Groovy compilers to be included in the testCompile configuration. > Proposing to exclude groovy-all from the geb-spock dependency. All tests > still pass when doing so. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (TAP5-2675) Avoid multiple Groovy compilers on classpath
Volker Lamp created TAP5-2675: - Summary: Avoid multiple Groovy compilers on classpath Key: TAP5-2675 URL: https://issues.apache.org/jira/browse/TAP5-2675 Project: Tapestry 5 Issue Type: Task Components: tapestry-webresources Reporter: Volker Lamp Transitive dependencies of (a) spock-tapestry and (b) geb-spock cause two different Groovy compilers to be included in the testCompile configuration. Proposing to exclude groovy-all from the geb-spock dependency. All tests still pass when doing so. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (TAP5-2674) Type coercer contribution - cast exception in equals
[
https://issues.apache.org/jira/browse/TAP5-2674?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17329886#comment-17329886
]
Volker Lamp commented on TAP5-2674:
---
As Cédric had already pointed out the implementation of
CoercionTuple.Key.equals() is what's causing the problem. The inner class Key
can access to other members of the enclosing class CoercionTuple only within
its own instance (this), not another instance. The fix I'm proposing is to add
to the Key class protected getters for the sourceType and targetFields of the
enclosing class.
The attached [^TAP5-2674.patch] contains the test case as well as the test
configuration.
> Type coercer contribution - cast exception in equals
> -
>
> Key: TAP5-2674
> URL: https://issues.apache.org/jira/browse/TAP5-2674
> Project: Tapestry 5
> Issue Type: Bug
> Components: tapestry-core
>Affects Versions: 5.7.2
>Reporter: Cédric BOONE
>Priority: Blocker
> Attachments: TAP5-2674.patch
>
>
> I have multiple Tapestry modules which contribute to type coercer, I can't
> make it work.
>
> I contribute TypeCoercer this way
>
> {code:java}
> public static void
> contributeTypeCoercer(MappedConfiguration
> configuration) {
> Coercion coercion = path -> {
> try {
> return Class.forName(path);
> } catch (ClassNotFoundException e) {
> return null;
> }
> };
> CoercionTuple tuple = new CoercionTuple<>(String.class,
> Class.class, coercion);
> configuration.override(tuple.getKey(), tuple);
>}{code}
>
> When I try to access a Tapestry page I get the following:
>
>
> {code:java}
> Caused by: java.lang.ClassCastException:
> org.apache.tapestry5.commons.services.CoercionTuple$Key cannot be cast to
> org.apache.tapestry5.commons.services.CoercionTuple
> at
> org.apache.tapestry5.commons.services.CoercionTuple$Key.equals(CoercionTuple.java:184)
> at java.util.HashMap.getNode(HashMap.java:572)
> at java.util.HashMap.get(HashMap.java:557)
> at
> org.apache.tapestry5.ioc.internal.ValidatingMappedConfigurationWrapper.override(ValidatingMappedConfigurationWrapper.java:122)
> at
> **.SessionsSubModule.contributeTypeCoercer(SessionsSubModule.java:63)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:498)
> at
> org.apache.tapestry5.ioc.internal.ContributionDefImpl.invokeMethod(ContributionDefImpl.java:133)
> ... 219 more
> {code}
>
> The exception is raised in the equals method of CoercionTuple.Key:
> {code:java}
> @Override
> public boolean equals(Object obj)
> {
> if (this == obj)
> return true;
> if (obj == null)
> return false;
> if (getClass() != obj.getClass())
> return false;
> // Exception is raised here
> CoercionTuple other = (CoercionTuple) obj;
> if (sourceType == null)
> {
> if (other.sourceType != null)
> return false;
> } else if (!sourceType.equals(other.sourceType))
> return false;
> if (targetType == null)
> {
> if (other.targetType != null)
> return false;
> } else if (!targetType.equals(other.targetType))
> return false;
> return true;
> }
> {code}
> The equals is called in the HashMap#get implementation (used in
> ValidatingMappedConfigurationWrapper)
>
> With this part of code:
> {code:java}
> ...
> if (getClass() != obj.getClass())
> return false;
> CoercionTuple other = (CoercionTuple) obj;
> ...
> {code}
> the obj variable can't be a CoercionTuple, it will be a CoercionTuple.Key
> (which is the case in the implementation of HashMap CoercionTuple>#get).
> I might not have understood something, if it is the case, I'm sorry for the
> trouble.
>
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (TAP5-2674) Type coercer contribution - cast exception in equals
[
https://issues.apache.org/jira/browse/TAP5-2674?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Volker Lamp updated TAP5-2674:
--
Attachment: TAP5-2674.patch
> Type coercer contribution - cast exception in equals
> -
>
> Key: TAP5-2674
> URL: https://issues.apache.org/jira/browse/TAP5-2674
> Project: Tapestry 5
> Issue Type: Bug
> Components: tapestry-core
>Affects Versions: 5.7.2
>Reporter: Cédric BOONE
>Priority: Blocker
> Attachments: TAP5-2674.patch
>
>
> I have multiple Tapestry modules which contribute to type coercer, I can't
> make it work.
>
> I contribute TypeCoercer this way
>
> {code:java}
> public static void
> contributeTypeCoercer(MappedConfiguration
> configuration) {
> Coercion coercion = path -> {
> try {
> return Class.forName(path);
> } catch (ClassNotFoundException e) {
> return null;
> }
> };
> CoercionTuple tuple = new CoercionTuple<>(String.class,
> Class.class, coercion);
> configuration.override(tuple.getKey(), tuple);
>}{code}
>
> When I try to access a Tapestry page I get the following:
>
>
> {code:java}
> Caused by: java.lang.ClassCastException:
> org.apache.tapestry5.commons.services.CoercionTuple$Key cannot be cast to
> org.apache.tapestry5.commons.services.CoercionTuple
> at
> org.apache.tapestry5.commons.services.CoercionTuple$Key.equals(CoercionTuple.java:184)
> at java.util.HashMap.getNode(HashMap.java:572)
> at java.util.HashMap.get(HashMap.java:557)
> at
> org.apache.tapestry5.ioc.internal.ValidatingMappedConfigurationWrapper.override(ValidatingMappedConfigurationWrapper.java:122)
> at
> **.SessionsSubModule.contributeTypeCoercer(SessionsSubModule.java:63)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:498)
> at
> org.apache.tapestry5.ioc.internal.ContributionDefImpl.invokeMethod(ContributionDefImpl.java:133)
> ... 219 more
> {code}
>
> The exception is raised in the equals method of CoercionTuple.Key:
> {code:java}
> @Override
> public boolean equals(Object obj)
> {
> if (this == obj)
> return true;
> if (obj == null)
> return false;
> if (getClass() != obj.getClass())
> return false;
> // Exception is raised here
> CoercionTuple other = (CoercionTuple) obj;
> if (sourceType == null)
> {
> if (other.sourceType != null)
> return false;
> } else if (!sourceType.equals(other.sourceType))
> return false;
> if (targetType == null)
> {
> if (other.targetType != null)
> return false;
> } else if (!targetType.equals(other.targetType))
> return false;
> return true;
> }
> {code}
> The equals is called in the HashMap#get implementation (used in
> ValidatingMappedConfigurationWrapper)
>
> With this part of code:
> {code:java}
> ...
> if (getClass() != obj.getClass())
> return false;
> CoercionTuple other = (CoercionTuple) obj;
> ...
> {code}
> the obj variable can't be a CoercionTuple, it will be a CoercionTuple.Key
> (which is the case in the implementation of HashMap CoercionTuple>#get).
> I might not have understood something, if it is the case, I'm sorry for the
> trouble.
>
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (TAP5-2674) Type coercer contribution - cast exception in equals
[
https://issues.apache.org/jira/browse/TAP5-2674?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17327189#comment-17327189
]
Volker Lamp commented on TAP5-2674:
---
I ran into the same problem and agree with Cédric. Here is a test case to
reproduce the problem.
{code:java}
package org.apache.tapestry5.commons.services;
import org.testng.Assert;
import org.testng.annotations.Test;
import java.time.LocalDate;
import java.time.LocalTime;
public class CoercionTupleTest extends Assert
{
@Test
public void key_equals()
{
CoercionTuple tuple =
CoercionTuple.create(String.class, LocalDate.class, new Coercion()
{
@Override
public LocalDate coerce(String input) {
return LocalDate.parse(input);
}
});
CoercionTuple.Key key = tuple.getKey();
assertNotNull(key);
assertFalse(key.equals(null));
assertTrue(key.equals(key));
assertFalse(key.equals(new String()));
CoercionTuple tuple2 =
CoercionTuple.create(String.class, LocalTime.class, new Coercion()
{
@Override
public LocalTime coerce(String input) {
return LocalTime.parse(input);
}
});
CoercionTuple.Key key2 = tuple2.getKey();
assertFalse(key.equals(key2)); // TAP5_2674
}
}
{code}
> Type coercer contribution - cast exception in equals
> -
>
> Key: TAP5-2674
> URL: https://issues.apache.org/jira/browse/TAP5-2674
> Project: Tapestry 5
> Issue Type: Bug
> Components: tapestry-core
>Affects Versions: 5.7.2
>Reporter: Cédric BOONE
>Priority: Blocker
>
> I have multiple Tapestry modules which contribute to type coercer, I can't
> make it work.
>
> I contribute TypeCoercer this way
>
> {code:java}
> public static void
> contributeTypeCoercer(MappedConfiguration
> configuration) {
> Coercion coercion = path -> {
> try {
> return Class.forName(path);
> } catch (ClassNotFoundException e) {
> return null;
> }
> };
> CoercionTuple tuple = new CoercionTuple<>(String.class,
> Class.class, coercion);
> configuration.override(tuple.getKey(), tuple);
>}{code}
>
> When I try to access a Tapestry page I get the following:
>
>
> {code:java}
> Caused by: java.lang.ClassCastException:
> org.apache.tapestry5.commons.services.CoercionTuple$Key cannot be cast to
> org.apache.tapestry5.commons.services.CoercionTuple
> at
> org.apache.tapestry5.commons.services.CoercionTuple$Key.equals(CoercionTuple.java:184)
> at java.util.HashMap.getNode(HashMap.java:572)
> at java.util.HashMap.get(HashMap.java:557)
> at
> org.apache.tapestry5.ioc.internal.ValidatingMappedConfigurationWrapper.override(ValidatingMappedConfigurationWrapper.java:122)
> at
> **.SessionsSubModule.contributeTypeCoercer(SessionsSubModule.java:63)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:498)
> at
> org.apache.tapestry5.ioc.internal.ContributionDefImpl.invokeMethod(ContributionDefImpl.java:133)
> ... 219 more
> {code}
>
> The exception is raised in the equals method of CoercionTuple.Key:
> {code:java}
> @Override
> public boolean equals(Object obj)
> {
> if (this == obj)
> return true;
> if (obj == null)
> return false;
> if (getClass() != obj.getClass())
> return false;
> // Exception is raised here
> CoercionTuple other = (CoercionTuple) obj;
> if (sourceType == null)
> {
> if (other.sourceType != null)
> return false;
> } else if (!sourceType.equals(other.sourceType))
> return false;
> if (targetType == null)
> {
> if (other.targetType != null)
> return false;
> } else if (!targetType.equals(other.targetType))
> return false;
> return true;
> }
> {code}
> The equals is called in the HashMap#get implementation (used in
> ValidatingMappedConfigurationWrapper)
>
> With this part of code:
> {code:java}
> ...
> if (getClass() != obj.getClass())
> return false;
> CoercionTuple other = (CoercionTuple) obj;
> ...
> {code}
> the obj variable can't be a CoercionTuple, it will be a CoercionTuple.Key
> (which is the case in the implementation of HashMap
