[jira] [Commented] (TAP5-1642) A mixin parameter that is required but also provides a default property results in an "unbound parameter" exception, starting in Tapestry 5.3

[Hudson (Commented) (JIRA)]

[ 
https://issues.apache.org/jira/browse/TAP5-1642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13134348#comment-13134348
 ] 

Hudson commented on TAP5-1642:
--

Integrated in tapestry-trunk-freestyle #604 (See 
[https://builds.apache.org/job/tapestry-trunk-freestyle/604/])
TAP5-1642: A mixin parameter that is required but also provides a default 
property results in an "unbound parameter" exception, starting in Tapestry 5.3

hlship : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1188272
Files : 
* 
/tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/internal/structure/ComponentPageElementImpl.java
* 
/tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/internal/structure/Page.java
* 
/tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/internal/structure/PageImpl.java
* 
/tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/internal/transform/ParameterWorker.java
* 
/tapestry/tapestry5/trunk/tapestry-core/src/test/groovy/org/apache/tapestry5/integration/app1/ParameterTests.groovy
* 
/tapestry/tapestry5/trunk/tapestry-core/src/test/java/org/apache/tapestry5/integration/app1/mixins/AltTitleDefault.java
* 
/tapestry/tapestry5/trunk/tapestry-core/src/test/java/org/apache/tapestry5/integration/app1/pages/Index.java
* 
/tapestry/tapestry5/trunk/tapestry-core/src/test/java/org/apache/tapestry5/integration/app1/pages/MixinParameterDefault.java
* 
/tapestry/tapestry5/trunk/tapestry-core/src/test/resources/org/apache/tapestry5/integration/app1/pages/MixinParameterDefault.tml


> A mixin parameter that is required but also provides a default property 
> results in an "unbound parameter" exception, starting in Tapestry 5.3
> -
>
> Key: TAP5-1642
> URL: https://issues.apache.org/jira/browse/TAP5-1642
> Project: Tapestry 5
>  Issue Type: Bug
>  Components: tapestry-core
>Affects Versions: 5.3
>Reporter: Laurent Guerin
>Assignee: Howard M. Lewis Ship
> Fix For: 5.3
>
> Attachments: test-mixin.zip
>
>
> In our Tapestry 5 library (exanpe-t5-lib), we provide some mixins containing 
> some parameters declared as "required=true" AND with a default value.
> These parameters are required for the operation of the mixin.
> For example, in a Dialog mixin, we have :
> @Parameter(value = "confirm", required = true, allowNull = false, 
> defaultPrefix = BindingConstants.LITERAL)
> private DialogRenderModeEnum renderMode;
> If this required parameter is not explicity bound in the TML :
> - In 5.2.6, everything is ok : the default value is used
> - In 5.3-beta-5, we get the following Exception :
>   Parameter(s) 'Dialog.renderMode' are required for 
> org.apache.tapestry5.corelib.components.ActionLink, but have not been bound.
> The TML example looks like this :
> link1
> With a simple type for mixin parameter (Integer or String), the same error 
> occurs.
> This behavior is only for mixins, not for components.
> A simplified project that duplicates the issue has been attached : the mixin 
> Emphasis used into Index.tml is ok in 5.2.6 and ko in 5.3.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (TAP5-1642) A mixin parameter that is required but also provides a default property results in an "unbound parameter" exception, starting in Tapestry 5.3

[Howard M. Lewis Ship (Commented) (JIRA)]

[ 
https://issues.apache.org/jira/browse/TAP5-1642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13134271#comment-13134271
 ] 

Howard M. Lewis Ship commented on TAP5-1642:


Some work with the debugger confirms that its an order-of-operations problem.  
The component is checking to see if mixin parameters have been bound before the 
mixins' containingPageDidLoad() method has had a chance to do the final binding 
to the default value.

> A mixin parameter that is required but also provides a default property 
> results in an "unbound parameter" exception, starting in Tapestry 5.3
> -
>
> Key: TAP5-1642
> URL: https://issues.apache.org/jira/browse/TAP5-1642
> Project: Tapestry 5
>  Issue Type: Bug
>  Components: tapestry-core
>Affects Versions: 5.3
>Reporter: Laurent Guerin
>Assignee: Howard M. Lewis Ship
> Attachments: test-mixin.zip
>
>
> In our Tapestry 5 library (exanpe-t5-lib), we provide some mixins containing 
> some parameters declared as "required=true" AND with a default value.
> These parameters are required for the operation of the mixin.
> For example, in a Dialog mixin, we have :
> @Parameter(value = "confirm", required = true, allowNull = false, 
> defaultPrefix = BindingConstants.LITERAL)
> private DialogRenderModeEnum renderMode;
> If this required parameter is not explicity bound in the TML :
> - In 5.2.6, everything is ok : the default value is used
> - In 5.3-beta-5, we get the following Exception :
>   Parameter(s) 'Dialog.renderMode' are required for 
> org.apache.tapestry5.corelib.components.ActionLink, but have not been bound.
> The TML example looks like this :
> link1
> With a simple type for mixin parameter (Integer or String), the same error 
> occurs.
> This behavior is only for mixins, not for components.
> A simplified project that duplicates the issue has been attached : the mixin 
> Emphasis used into Index.tml is ok in 5.2.6 and ko in 5.3.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira