[jira] [Commented] (TAP5-1726) JavaScript Assets fail to load for already-minified JS assets in Production mode
[ https://issues.apache.org/jira/browse/TAP5-1726?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13138452#comment-13138452 ] Howard M. Lewis Ship commented on TAP5-1726: Any idea how to differentiate minimized JS from normal? I'm changing to code to log the minimization failure, but then stream the unminimized version. JavaScript Assets fail to load for already-minified JS assets in Production mode Key: TAP5-1726 URL: https://issues.apache.org/jira/browse/TAP5-1726 Project: Tapestry 5 Issue Type: Bug Components: tapestry-core, tapestry-yuicompressor Affects Versions: 5.3, 5.4 Reporter: Lenny Primak I have another vendor's minified JavaScript files as assets in my context folder. They are obfuscated and don't pass YUI compressor's syntax checking. In this case, the process should still let the file through, but right now it fails with HTTP 500 error: So right now Tapestry can't load these assets. SEVERE: Operations trace: SEVERE: [ 1] Streaming context:com.baw.website.gwt.table/sc/modules/ISC_Core.js SEVERE: [ 2] Minimizing JavaScript SEVERE: Processing of request failed with uncaught exception: Compilation produced 6 syntax errors. org.apache.tapestry5.ioc.internal.OperationException: Compilation produced 6 syntax errors. at org.apache.tapestry5.ioc.internal.OperationTrackerImpl.logAndRethrow(OperationTrackerImpl.java:121) at org.apache.tapestry5.ioc.internal.OperationTrackerImpl.invoke(OperationTrackerImpl.java:88) at org.apache.tapestry5.ioc.internal.OperationTrackerImpl.run(OperationTrackerImpl.java:47) at org.apache.tapestry5.ioc.internal.PerThreadOperationTracker.run(PerThreadOperationTracker.java:76) at org.apache.tapestry5.ioc.internal.RegistryImpl.run(RegistryImpl.java:1029) at org.apache.tapestry5.internal.TapestryInternalUtils.performIO(TapestryInternalUtils.java:576) at org.apache.tapestry5.internal.yuicompressor.AbstractMinimizer.minimize(AbstractMinimizer.java:62) at org.apache.tapestry5.internal.services.assets.MasterResourceMinimizer.minimize(MasterResourceMinimizer.java:44) at $ResourceMinimizer_125025d36590963b.minimize(Unknown Source) at org.apache.tapestry5.internal.services.assets.SRSMinimizingInterceptor.getStreamableResource(SRSMinimizingInterceptor.java:44) at org.apache.tapestry5.internal.services.assets.SRSCachingInterceptor.getStreamableResource(SRSCachingInterceptor.java:56) at org.apache.tapestry5.internal.services.assets.SRSCompressingInterceptor.getStreamableResource(SRSCompressingInterceptor.java:40) at org.apache.tapestry5.internal.services.assets.SRSCachingInterceptor.getStreamableResource(SRSCachingInterceptor.java:56) at $StreamableResourceSource_125025d365909639.getStreamableResource(Unknown Source) at org.apache.tapestry5.internal.services.ResourceStreamerImpl$1.perform(ResourceStreamerImpl.java:93) at org.apache.tapestry5.internal.TapestryInternalUtils$5.run(TapestryInternalUtils.java:582) at org.apache.tapestry5.ioc.internal.OperationTrackerImpl$1.invoke(OperationTrackerImpl.java:51) at org.apache.tapestry5.ioc.internal.OperationTrackerImpl$1.invoke(OperationTrackerImpl.java:48) at org.apache.tapestry5.ioc.internal.OperationTrackerImpl.invoke(OperationTrackerImpl.java:74) at org.apache.tapestry5.ioc.internal.OperationTrackerImpl.run(OperationTrackerImpl.java:47) at org.apache.tapestry5.ioc.internal.PerThreadOperationTracker.run(PerThreadOperationTracker.java:76) at org.apache.tapestry5.ioc.internal.RegistryImpl.run(RegistryImpl.java:1029) at org.apache.tapestry5.internal.TapestryInternalUtils.performIO(TapestryInternalUtils.java:576) at org.apache.tapestry5.internal.services.ResourceStreamerImpl.streamResource(ResourceStreamerImpl.java:86) at $ResourceStreamer_125025d365909623.streamResource(Unknown Source) at org.apache.tapestry5.internal.services.assets.ContextAssetRequestHandler.handleAssetRequest(ContextAssetRequestHandler.java:53) at org.apache.tapestry5.internal.services.AssetDispatcher.dispatch(AssetDispatcher.java:109) at $Dispatcher_125025d365909634.dispatch(Unknown Source) at $Dispatcher_125025d365909638.dispatch(Unknown Source) at $Dispatcher_125025d365909632.dispatch(Unknown Source) at org.apache.tapestry5.services.TapestryModule$RequestHandlerTerminator.service(TapestryModule.java:302) at com.flowlogix.web.services.SecurityModule$1.service(SecurityModule.java:85) at $RequestHandler_125025d365909633.service(Unknown Source) at
[jira] [Commented] (TAP5-1726) JavaScript Assets fail to load for already-minified JS assets in Production mode
[ https://issues.apache.org/jira/browse/TAP5-1726?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13138517#comment-13138517 ] Hudson commented on TAP5-1726: -- Integrated in tapestry-trunk-freestyle #614 (See [https://builds.apache.org/job/tapestry-trunk-freestyle/614/]) TAP5-1726: JavaScript Assets fail to load for already-minified JS assets in Production mode hlship : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVNview=revrev=1190418 Files : * /tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/internal/services/assets/StackAssetRequestHandler.java * /tapestry/tapestry5/trunk/tapestry-yuicompressor/src/main/java/org/apache/tapestry5/internal/yuicompressor/JavaScriptResourceMinimizer.java * /tapestry/tapestry5/trunk/tapestry-yuicompressor/src/test/groovy/org/apache/tapestry5/yuicompressor/itest/YUICompressorIntegrationTests.groovy * /tapestry/tapestry5/trunk/tapestry-yuicompressor/src/test/java/yuicompressor/testapp/pages/BadJavaScript.java * /tapestry/tapestry5/trunk/tapestry-yuicompressor/src/test/java/yuicompressor/testapp/pages/Index.java * /tapestry/tapestry5/trunk/tapestry-yuicompressor/src/test/resources/yuicompressor/testapp/pages/BadJavaScript.tml * /tapestry/tapestry5/trunk/tapestry-yuicompressor/src/test/resources/yuicompressor/testapp/pages/Index.tml * /tapestry/tapestry5/trunk/tapestry-yuicompressor/src/test/resources/yuicompressor/testapp/pages/bad.js JavaScript Assets fail to load for already-minified JS assets in Production mode Key: TAP5-1726 URL: https://issues.apache.org/jira/browse/TAP5-1726 Project: Tapestry 5 Issue Type: Bug Components: tapestry-core, tapestry-yuicompressor Affects Versions: 5.3, 5.4 Reporter: Lenny Primak Assignee: Howard M. Lewis Ship Fix For: 5.3 I have another vendor's minified JavaScript files as assets in my context folder. They are obfuscated and don't pass YUI compressor's syntax checking. In this case, the process should still let the file through, but right now it fails with HTTP 500 error: So right now Tapestry can't load these assets. SEVERE: Operations trace: SEVERE: [ 1] Streaming context:com.baw.website.gwt.table/sc/modules/ISC_Core.js SEVERE: [ 2] Minimizing JavaScript SEVERE: Processing of request failed with uncaught exception: Compilation produced 6 syntax errors. org.apache.tapestry5.ioc.internal.OperationException: Compilation produced 6 syntax errors. at org.apache.tapestry5.ioc.internal.OperationTrackerImpl.logAndRethrow(OperationTrackerImpl.java:121) at org.apache.tapestry5.ioc.internal.OperationTrackerImpl.invoke(OperationTrackerImpl.java:88) at org.apache.tapestry5.ioc.internal.OperationTrackerImpl.run(OperationTrackerImpl.java:47) at org.apache.tapestry5.ioc.internal.PerThreadOperationTracker.run(PerThreadOperationTracker.java:76) at org.apache.tapestry5.ioc.internal.RegistryImpl.run(RegistryImpl.java:1029) at org.apache.tapestry5.internal.TapestryInternalUtils.performIO(TapestryInternalUtils.java:576) at org.apache.tapestry5.internal.yuicompressor.AbstractMinimizer.minimize(AbstractMinimizer.java:62) at org.apache.tapestry5.internal.services.assets.MasterResourceMinimizer.minimize(MasterResourceMinimizer.java:44) at $ResourceMinimizer_125025d36590963b.minimize(Unknown Source) at org.apache.tapestry5.internal.services.assets.SRSMinimizingInterceptor.getStreamableResource(SRSMinimizingInterceptor.java:44) at org.apache.tapestry5.internal.services.assets.SRSCachingInterceptor.getStreamableResource(SRSCachingInterceptor.java:56) at org.apache.tapestry5.internal.services.assets.SRSCompressingInterceptor.getStreamableResource(SRSCompressingInterceptor.java:40) at org.apache.tapestry5.internal.services.assets.SRSCachingInterceptor.getStreamableResource(SRSCachingInterceptor.java:56) at $StreamableResourceSource_125025d365909639.getStreamableResource(Unknown Source) at org.apache.tapestry5.internal.services.ResourceStreamerImpl$1.perform(ResourceStreamerImpl.java:93) at org.apache.tapestry5.internal.TapestryInternalUtils$5.run(TapestryInternalUtils.java:582) at org.apache.tapestry5.ioc.internal.OperationTrackerImpl$1.invoke(OperationTrackerImpl.java:51) at org.apache.tapestry5.ioc.internal.OperationTrackerImpl$1.invoke(OperationTrackerImpl.java:48) at org.apache.tapestry5.ioc.internal.OperationTrackerImpl.invoke(OperationTrackerImpl.java:74) at org.apache.tapestry5.ioc.internal.OperationTrackerImpl.run(OperationTrackerImpl.java:47) at
