[jira] [Commented] (TAP5-2050) Grid sort icons should be added via CSS instead of rendering an embedded img element

2013-06-21 Thread Hudson (JIRA)

[ 
https://issues.apache.org/jira/browse/TAP5-2050?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13690831#comment-13690831
 ] 

Hudson commented on TAP5-2050:
--

Integrated in tapestry-trunk-freestyle #1095 (See 
[https://builds.apache.org/job/tapestry-trunk-freestyle/1095/])
TAP5-2050: Grid sort icons should be added via CSS instead of rendering an 
embedded img element (Revision b04fb2fd6046a1dacdc3d266024d1ef6b977c1aa)

 Result = FAILURE
hlship : 
Files : 
* tapestry-core/src/main/resources/org/apache/tapestry5/core_mk_MK.properties
* tapestry-core/src/main/resources/org/apache/tapestry5/core_nl.properties
* tapestry-core/src/main/resources/org/apache/tapestry5/core_fi_FI.properties
* tapestry-core/src/main/resources/org/apache/tapestry5/core_vi.properties
* 
tapestry-core/src/test/java/org/apache/tapestry5/integration/app1/GridTests.java
* tapestry-core/src/main/resources/org/apache/tapestry5/core_it.properties
* tapestry-core/src/main/resources/org/apache/tapestry5/core_pt_BR.properties
* tapestry-core/src/main/resources/org/apache/tapestry5/core_zh_CN.properties
* tapestry-core/src/main/resources/org/apache/tapestry5/core_de.properties
* tapestry-core/src/main/resources/org/apache/tapestry5/core_sv_SE.properties
* tapestry-core/src/main/resources/META-INF/assets/tapestry5/tapestry.css
* tapestry-core/src/main/resources/org/apache/tapestry5/core_ja.properties
* tapestry-core/src/main/resources/org/apache/tapestry5/core_da.properties
* 
tapestry-core/src/main/java/org/apache/tapestry5/corelib/components/GridColumns.java
* tapestry-core/src/main/resources/org/apache/tapestry5/core_ru.properties
* tapestry-core/src/main/resources/org/apache/tapestry5/core_fr.properties
* 
tapestry-jpa/src/test/java/org/apache/tapestry5/jpa/integration/app1/JpaIntegrationTest.java
* 
tapestry-hibernate/src/test/java/org/apache/tapestry5/hibernate/integration/TapestryHibernateIntegrationTests.java
* tapestry-core/src/main/resources/org/apache/tapestry5/core_no_NB.properties
* tapestry-core/src/main/resources/org/apache/tapestry5/core.properties
* tapestry-core/src/main/resources/org/apache/tapestry5/core_es.properties
* tapestry-core/src/main/resources/org/apache/tapestry5/core_bg.properties
* tapestry-core/src/main/resources/org/apache/tapestry5/core_pl.properties
* tapestry-core/src/main/resources/org/apache/tapestry5/core_sr_RS.properties
* tapestry-core/src/main/resources/org/apache/tapestry5/core_el.properties
* 
tapestry-core/src/main/resources/org/apache/tapestry5/corelib/components/GridColumns.tml
* tapestry-core/src/main/java/org/apache/tapestry5/grid/GridConstants.java
* tapestry-core/src/main/resources/org/apache/tapestry5/core_hr.properties


 Grid sort icons should be added via CSS instead of rendering an embedded img 
 element
 

 Key: TAP5-2050
 URL: https://issues.apache.org/jira/browse/TAP5-2050
 Project: Tapestry 5
  Issue Type: Improvement
  Components: tapestry-core
Affects Versions: 5.4
Reporter: Jochen Kemnade
Assignee: Howard M. Lewis Ship
Priority: Minor
  Labels: component, grid, patch
 Attachments: 
 0001-instead-of-rendering-a-sort-link-with-the-column-lab.patch


 Currently, each sortable grid column's header's link has its icon rendered 
 via an embedded img element. It would be better to apply the sort icons to 
 the links via CSS.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Commented] (TAP5-2050) Grid sort icons should be added via CSS instead of rendering an embedded img element

2013-06-20 Thread Howard M. Lewis Ship (JIRA)

[ 
https://issues.apache.org/jira/browse/TAP5-2050?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13689616#comment-13689616
 ] 

Howard M. Lewis Ship commented on TAP5-2050:


Looks like a nice patch!

 Grid sort icons should be added via CSS instead of rendering an embedded img 
 element
 

 Key: TAP5-2050
 URL: https://issues.apache.org/jira/browse/TAP5-2050
 Project: Tapestry 5
  Issue Type: Improvement
  Components: tapestry-core
Affects Versions: 5.4
Reporter: Jochen Kemnade
Priority: Minor
  Labels: component, grid, patch
 Attachments: 
 0001-instead-of-rendering-a-sort-link-with-the-column-lab.patch


 Currently, each sortable grid column's header's link has its icon rendered 
 via an embedded img element. It would be better to apply the sort icons to 
 the links via CSS.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira