[jira] [Commented] (TAP5-2330) NullPointerException when updating a Zone with no clientId
[ https://issues.apache.org/jira/browse/TAP5-2330?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14040386#comment-14040386 ] Hudson commented on TAP5-2330: -- FAILURE: Integrated in tapestry-trunk-freestyle #1250 (See [https://builds.apache.org/job/tapestry-trunk-freestyle/1250/]) Some adjustments for TAP5-2330 (thiagohp: rev 5d5b1e787cecb7cedbaa00a88834b7eadfe7e8ae) * tapestry-json/src/main/java/org/apache/tapestry5/json/JSONArray.java > NullPointerException when updating a Zone with no clientId > -- > > Key: TAP5-2330 > URL: https://issues.apache.org/jira/browse/TAP5-2330 > Project: Tapestry 5 > Issue Type: Bug > Components: tapestry-core, tapestry-json >Affects Versions: 5.4 >Reporter: Jochen Kemnade >Assignee: Thiago H. de Paula Figueiredo >Priority: Critical > Labels: month-of-tapestry > Fix For: 5.4 > > Attachments: 0001-add-test-for-TAP5-2330.patch > > > If a Zone update is performed via AjaxResponseRenderer and the Zone has no id > parameter, the RenderCommand creates a JSONArray with null as its first > element. If assertions are disabled for the JVM, this leads to a > NullPointerException in JSONObject.printValue(JSONPrintSession, Object). -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (TAP5-2330) NullPointerException when updating a Zone with no clientId
[ https://issues.apache.org/jira/browse/TAP5-2330?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14040370#comment-14040370 ] ASF subversion and git services commented on TAP5-2330: --- Commit 5d5b1e787cecb7cedbaa00a88834b7eadfe7e8ae in tapestry-5's branch refs/heads/master from [~thiagohp] [ https://git-wip-us.apache.org/repos/asf?p=tapestry-5.git;h=5d5b1e7 ] Some adjustments for TAP5-2330 > NullPointerException when updating a Zone with no clientId > -- > > Key: TAP5-2330 > URL: https://issues.apache.org/jira/browse/TAP5-2330 > Project: Tapestry 5 > Issue Type: Bug > Components: tapestry-core, tapestry-json >Affects Versions: 5.4 >Reporter: Jochen Kemnade >Assignee: Thiago H. de Paula Figueiredo >Priority: Critical > Labels: month-of-tapestry > Fix For: 5.4 > > Attachments: 0001-add-test-for-TAP5-2330.patch > > > If a Zone update is performed via AjaxResponseRenderer and the Zone has no id > parameter, the RenderCommand creates a JSONArray with null as its first > element. If assertions are disabled for the JVM, this leads to a > NullPointerException in JSONObject.printValue(JSONPrintSession, Object). -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (TAP5-2330) NullPointerException when updating a Zone with no clientId
[ https://issues.apache.org/jira/browse/TAP5-2330?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14040252#comment-14040252 ] Thiago H. de Paula Figueiredo commented on TAP5-2330: - https://git-wip-us.apache.org/repos/asf?p=tapestry-5.git;h=fbd7d03 (I misstyped the JIRA number) > NullPointerException when updating a Zone with no clientId > -- > > Key: TAP5-2330 > URL: https://issues.apache.org/jira/browse/TAP5-2330 > Project: Tapestry 5 > Issue Type: Bug > Components: tapestry-core, tapestry-json >Affects Versions: 5.4 >Reporter: Jochen Kemnade >Assignee: Thiago H. de Paula Figueiredo >Priority: Critical > Labels: month-of-tapestry > Fix For: 5.4 > > Attachments: 0001-add-test-for-TAP5-2330.patch > > > If a Zone update is performed via AjaxResponseRenderer and the Zone has no id > parameter, the RenderCommand creates a JSONArray with null as its first > element. If assertions are disabled for the JVM, this leads to a > NullPointerException in JSONObject.printValue(JSONPrintSession, Object). -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (TAP5-2330) NullPointerException when updating a Zone with no clientId
[ https://issues.apache.org/jira/browse/TAP5-2330?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14014644#comment-14014644 ] Thiago H. de Paula Figueiredo commented on TAP5-2330: - Good point, Jochen. I'll change that later today, including a check for null in AjaxResponseRendererImpl. > NullPointerException when updating a Zone with no clientId > -- > > Key: TAP5-2330 > URL: https://issues.apache.org/jira/browse/TAP5-2330 > Project: Tapestry 5 > Issue Type: Bug > Components: tapestry-core, tapestry-json >Affects Versions: 5.4 >Reporter: Jochen Kemnade >Assignee: Thiago H. de Paula Figueiredo >Priority: Critical > Labels: month-of-tapestry > Fix For: 5.4 > > Attachments: 0001-add-test-for-TAP5-2330.patch > > > If a Zone update is performed via AjaxResponseRenderer and the Zone has no id > parameter, the RenderCommand creates a JSONArray with null as its first > element. If assertions are disabled for the JVM, this leads to a > NullPointerException in JSONObject.printValue(JSONPrintSession, Object). -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (TAP5-2330) NullPointerException when updating a Zone with no clientId
[ https://issues.apache.org/jira/browse/TAP5-2330?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14014533#comment-14014533 ] Hudson commented on TAP5-2330: -- SUCCESS: Integrated in tapestry-trunk-freestyle #1228 (See [https://builds.apache.org/job/tapestry-trunk-freestyle/1228/]) TAP5-2330 : NullPointerException when updating a Zone with no clientId (thiagohp: rev 01a1439c4a520cf5425415e0ed6a9fa51d386df1) * tapestry-core/src/test/java/org/apache/tapestry5/integration/app1/ZoneTests.java * tapestry-core/src/test/java/org/apache/tapestry5/integration/app1/pages/nested/ZoneDemo.java * tapestry-json/src/main/java/org/apache/tapestry5/json/JSONObject.java * tapestry-core/src/main/java/org/apache/tapestry5/corelib/components/Zone.java * tapestry-core/src/test/app1/nested/ZoneDemo.tml > NullPointerException when updating a Zone with no clientId > -- > > Key: TAP5-2330 > URL: https://issues.apache.org/jira/browse/TAP5-2330 > Project: Tapestry 5 > Issue Type: Bug > Components: tapestry-core, tapestry-json >Affects Versions: 5.4 >Reporter: Jochen Kemnade >Assignee: Thiago H. de Paula Figueiredo >Priority: Critical > Labels: month-of-tapestry > Fix For: 5.4 > > Attachments: 0001-add-test-for-TAP5-2330.patch > > > If a Zone update is performed via AjaxResponseRenderer and the Zone has no id > parameter, the RenderCommand creates a JSONArray with null as its first > element. If assertions are disabled for the JVM, this leads to a > NullPointerException in JSONObject.printValue(JSONPrintSession, Object). -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (TAP5-2330) NullPointerException when updating a Zone with no clientId
[ https://issues.apache.org/jira/browse/TAP5-2330?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14014489#comment-14014489 ] Thiago H. de Paula Figueiredo commented on TAP5-2330: - Thanks for the test, Jochen! I've used it in this fix. :-) > NullPointerException when updating a Zone with no clientId > -- > > Key: TAP5-2330 > URL: https://issues.apache.org/jira/browse/TAP5-2330 > Project: Tapestry 5 > Issue Type: Bug > Components: tapestry-core, tapestry-json >Affects Versions: 5.4 >Reporter: Jochen Kemnade >Priority: Critical > Attachments: 0001-add-test-for-TAP5-2330.patch > > > If a Zone update is performed via AjaxResponseRenderer and the Zone has no id > parameter, the RenderCommand creates a JSONArray with null as its first > element. If assertions are disabled for the JVM, this leads to a > NullPointerException in JSONObject.printValue(JSONPrintSession, Object). -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (TAP5-2330) NullPointerException when updating a Zone with no clientId
[ https://issues.apache.org/jira/browse/TAP5-2330?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14014486#comment-14014486 ] ASF subversion and git services commented on TAP5-2330: --- Commit 01a1439c4a520cf5425415e0ed6a9fa51d386df1 in tapestry-5's branch refs/heads/master from [~thiagohp] [ https://git-wip-us.apache.org/repos/asf?p=tapestry-5.git;h=01a1439 ] TAP5-2330 : NullPointerException when updating a Zone with no clientId TAP5-2342 : NPE on org.apache.tapestry5.json.JSONObject.printValue(JSONObject.java:950) > NullPointerException when updating a Zone with no clientId > -- > > Key: TAP5-2330 > URL: https://issues.apache.org/jira/browse/TAP5-2330 > Project: Tapestry 5 > Issue Type: Bug > Components: tapestry-core, tapestry-json >Affects Versions: 5.4 >Reporter: Jochen Kemnade >Priority: Critical > Attachments: 0001-add-test-for-TAP5-2330.patch > > > If a Zone update is performed via AjaxResponseRenderer and the Zone has no id > parameter, the RenderCommand creates a JSONArray with null as its first > element. If assertions are disabled for the JVM, this leads to a > NullPointerException in JSONObject.printValue(JSONPrintSession, Object). -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (TAP5-2330) NullPointerException when updating a Zone with no clientId
[
https://issues.apache.org/jira/browse/TAP5-2330?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13993454#comment-13993454
]
Jochen Kemnade commented on TAP5-2330:
--
The problem is that the generated {{clientId}} is lost after the Zone's initial
rendering. During the update request, when {{zone.getClientId()}} is called
from {{AjaxResponseRendererImpl.addRender(ClientBodyElement)}}, the
{{clientId}} field is {{null}}.
I have a test for the issue but no (idea for a) fix yet.
> NullPointerException when updating a Zone with no clientId
> --
>
> Key: TAP5-2330
> URL: https://issues.apache.org/jira/browse/TAP5-2330
> Project: Tapestry 5
> Issue Type: Bug
> Components: tapestry-core, tapestry-json
>Affects Versions: 5.4
>Reporter: Jochen Kemnade
>Priority: Critical
> Attachments: 0001-add-test-for-TAP5-2330.patch
>
>
> If a Zone update is performed via AjaxResponseRenderer and the Zone has no id
> parameter, the RenderCommand creates a JSONArray with null as its first
> element. If assertions are disabled for the JVM, this leads to a
> NullPointerException in JSONObject.printValue(JSONPrintSession, Object).
--
This message was sent by Atlassian JIRA
(v6.2#6252)
