[jira] [Updated] (TAP5-1979) Changing the implementation of a method after adding method advice does not work; the original implementation remains
[ https://issues.apache.org/jira/browse/TAP5-1979?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Howard M. Lewis Ship updated TAP5-1979: --- Fix Version/s: (was: 5.3.5) 5.3.6 Changing the implementation of a method after adding method advice does not work; the original implementation remains - Key: TAP5-1979 URL: https://issues.apache.org/jira/browse/TAP5-1979 Project: Tapestry 5 Issue Type: Bug Components: plastic Affects Versions: 5.3, 5.4 Reporter: Howard M. Lewis Ship Assignee: Howard M. Lewis Ship Labels: fixed-in-5.4-js-rewrite Fix For: 5.3.6 This is too easy to do when you have a chain of PlasticClassTransformers operating on the same classes. Alternately, the advised method, not the main method (that instantiates the Invocation object)n should be the one that is rewritten. The issue here is that Plastic takes a snapshot of the method implementation when the first advice is added, and that snapshot is not updated if the advised method implementation is later changed. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (TAP5-1979) Changing the implementation of a method after adding method advice does not work; the original implementation remains
[ https://issues.apache.org/jira/browse/TAP5-1979?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Howard M. Lewis Ship updated TAP5-1979: --- Fix Version/s: (was: 5.3.6) 5.3.5 Changing the implementation of a method after adding method advice does not work; the original implementation remains - Key: TAP5-1979 URL: https://issues.apache.org/jira/browse/TAP5-1979 Project: Tapestry 5 Issue Type: Bug Components: plastic Affects Versions: 5.3, 5.4 Reporter: Howard M. Lewis Ship Assignee: Howard M. Lewis Ship Labels: fixed-in-5.4-js-rewrite Fix For: 5.3.5 This is too easy to do when you have a chain of PlasticClassTransformers operating on the same classes. Alternately, the advised method, not the main method (that instantiates the Invocation object)n should be the one that is rewritten. The issue here is that Plastic takes a snapshot of the method implementation when the first advice is added, and that snapshot is not updated if the advised method implementation is later changed. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (TAP5-1979) Changing the implementation of a method after adding method advice does not work; the original implementation remains
[ https://issues.apache.org/jira/browse/TAP5-1979?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Howard M. Lewis Ship updated TAP5-1979: --- Labels: fixed-in-5.4-js-rewrite (was: ) Changing the implementation of a method after adding method advice does not work; the original implementation remains - Key: TAP5-1979 URL: https://issues.apache.org/jira/browse/TAP5-1979 Project: Tapestry 5 Issue Type: Bug Components: plastic Affects Versions: 5.3, 5.4 Reporter: Howard M. Lewis Ship Assignee: Howard M. Lewis Ship Labels: fixed-in-5.4-js-rewrite Fix For: 5.3.5 This is too easy to do when you have a chain of PlasticClassTransformers operating on the same classes. Alternately, the advised method, not the main method (that instantiates the Invocation object)n should be the one that is rewritten. The issue here is that Plastic takes a snapshot of the method implementation when the first advice is added, and that snapshot is not updated if the advised method implementation is later changed. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (TAP5-1979) Changing the implementation of a method after adding method advice does not work; the original implementation remains
[ https://issues.apache.org/jira/browse/TAP5-1979?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Howard M. Lewis Ship updated TAP5-1979: --- Description: This is too easy to do when you have a chain of PlasticClassTransformers operating on the same classes. Alternately, the advised method, not the main method (that instantiates the Invocation object)n should be the one that is rewritten. The issue here is that Plastic takes a snapshot of the method implementation when the first advice is added, and that snapshot is not updated if the advised method implementation is later changed. was: This is too easy to do when you have a chain of PlasticClassTransformers operating on the same classes. Alternately, the advised method, not the main method (that instantiates the Invocation object)n should be the one that is rewritten. Summary: Changing the implementation of a method after adding method advice does not work; the original implementation remains (was: Plastic should throw an exception when a method implementation is rewritten AFTER method advice is added) Changing the implementation of a method after adding method advice does not work; the original implementation remains - Key: TAP5-1979 URL: https://issues.apache.org/jira/browse/TAP5-1979 Project: Tapestry 5 Issue Type: Bug Components: plastic Affects Versions: 5.3, 5.4 Reporter: Howard M. Lewis Ship Assignee: Howard M. Lewis Ship This is too easy to do when you have a chain of PlasticClassTransformers operating on the same classes. Alternately, the advised method, not the main method (that instantiates the Invocation object)n should be the one that is rewritten. The issue here is that Plastic takes a snapshot of the method implementation when the first advice is added, and that snapshot is not updated if the advised method implementation is later changed. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
