tapestry-5 git commit: fix test

[jkemnade]

Repository: tapestry-5
Updated Branches:
  refs/heads/master 8ac208194 -> 88aad2673


fix test


Project: http://git-wip-us.apache.org/repos/asf/tapestry-5/repo
Commit: http://git-wip-us.apache.org/repos/asf/tapestry-5/commit/88aad267
Tree: http://git-wip-us.apache.org/repos/asf/tapestry-5/tree/88aad267
Diff: http://git-wip-us.apache.org/repos/asf/tapestry-5/diff/88aad267

Branch: refs/heads/master
Commit: 88aad2673a7e5c85bb4f3d949ecc74978238950c
Parents: 8ac2081
Author: Jochen Kemnade 
Authored: Mon Oct 30 08:43:22 2017 +0100
Committer: Jochen Kemnade 
Committed: Mon Oct 30 08:43:22 2017 +0100

--
 .../src/main/java/org/apache/tapestry5/test/SeleniumTestCase.java | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
--


http://git-wip-us.apache.org/repos/asf/tapestry-5/blob/88aad267/tapestry-test/src/main/java/org/apache/tapestry5/test/SeleniumTestCase.java
--
diff --git 
a/tapestry-test/src/main/java/org/apache/tapestry5/test/SeleniumTestCase.java 
b/tapestry-test/src/main/java/org/apache/tapestry5/test/SeleniumTestCase.java
index 5f4d696..204145a 100644
--- 
a/tapestry-test/src/main/java/org/apache/tapestry5/test/SeleniumTestCase.java
+++ 
b/tapestry-test/src/main/java/org/apache/tapestry5/test/SeleniumTestCase.java
@@ -1312,7 +1312,8 @@ public abstract class SeleniumTestCase extends Assert 
implements Selenium
 @Override
 public void type(String locator, String value)
 {
-selenium.type(locator, value);
+WebElement element = webDriver.findElement(convertLocator(locator));
+element.sendKeys(value);
 }
 
 @Override

tapestry-5 git commit: fix test

[jkemnade]

Repository: tapestry-5
Updated Branches:
  refs/heads/master 0f000e6ab -> b993e79eb


fix test


Project: http://git-wip-us.apache.org/repos/asf/tapestry-5/repo
Commit: http://git-wip-us.apache.org/repos/asf/tapestry-5/commit/b993e79e
Tree: http://git-wip-us.apache.org/repos/asf/tapestry-5/tree/b993e79e
Diff: http://git-wip-us.apache.org/repos/asf/tapestry-5/diff/b993e79e

Branch: refs/heads/master
Commit: b993e79ebe493a97ecc21301a89e13d738cb9d3c
Parents: 0f000e6
Author: Jochen Kemnade 
Authored: Tue Oct 10 07:26:52 2017 +0200
Committer: Jochen Kemnade 
Committed: Tue Oct 10 07:26:52 2017 +0200

--
 .../test/java/org/apache/tapestry5/integration/app1/FormTests.java | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
--


http://git-wip-us.apache.org/repos/asf/tapestry-5/blob/b993e79e/tapestry-core/src/test/java/org/apache/tapestry5/integration/app1/FormTests.java
--
diff --git 
a/tapestry-core/src/test/java/org/apache/tapestry5/integration/app1/FormTests.java
 
b/tapestry-core/src/test/java/org/apache/tapestry5/integration/app1/FormTests.java
index 85a3690..2f6588a 100644
--- 
a/tapestry-core/src/test/java/org/apache/tapestry5/integration/app1/FormTests.java
+++ 
b/tapestry-core/src/test/java/org/apache/tapestry5/integration/app1/FormTests.java
@@ -331,7 +331,7 @@ public class FormTests extends App1TestCase
 
 assertFieldValue("asteroidImpact", "");
 
-click(noneButton);
+click("css=.x-impact .btn");
 
 waitForCSSSelectedElementToAppear("div.datePicker");
 assertFalse(isElementPresent("css=td.selected"));

tapestry-5 git commit: fix test

[jkemnade]

Repository: tapestry-5
Updated Branches:
  refs/heads/master c859076d2 - 4147af5f3


fix test


Project: http://git-wip-us.apache.org/repos/asf/tapestry-5/repo
Commit: http://git-wip-us.apache.org/repos/asf/tapestry-5/commit/4147af5f
Tree: http://git-wip-us.apache.org/repos/asf/tapestry-5/tree/4147af5f
Diff: http://git-wip-us.apache.org/repos/asf/tapestry-5/diff/4147af5f

Branch: refs/heads/master
Commit: 4147af5f33ef272dd63d0686b15bb0094a899f58
Parents: c859076
Author: Jochen Kemnade jkemn...@apache.org
Authored: Fri Jul 24 18:29:32 2015 +0200
Committer: Jochen Kemnade jkemn...@apache.org
Committed: Fri Jul 24 18:29:32 2015 +0200

--
 .../apache/tapestry5/integration/app5/ProductionModeTests.groovy   | 2 ++
 1 file changed, 2 insertions(+)
--


http://git-wip-us.apache.org/repos/asf/tapestry-5/blob/4147af5f/tapestry-core/src/test/groovy/org/apache/tapestry5/integration/app5/ProductionModeTests.groovy
--
diff --git 
a/tapestry-core/src/test/groovy/org/apache/tapestry5/integration/app5/ProductionModeTests.groovy
 
b/tapestry-core/src/test/groovy/org/apache/tapestry5/integration/app5/ProductionModeTests.groovy
index 484a39d..cc811a8 100644
--- 
a/tapestry-core/src/test/groovy/org/apache/tapestry5/integration/app5/ProductionModeTests.groovy
+++ 
b/tapestry-core/src/test/groovy/org/apache/tapestry5/integration/app5/ProductionModeTests.groovy
@@ -12,6 +12,8 @@ class ProductionModeTests extends TapestryCoreTestCase {
 void invalid_component_id_is_404() {
 openBaseURL()
 
+openLinks reset session
+
 assertTitle Default Layout
 
 open ${baseURL}index.missing

[1/5] git commit: Fix test that fails using jQuery as infrastructure

[hlship]

Updated Branches:
  refs/heads/master b6d1bdeba - 09bd34c8b


Fix test that fails using jQuery as infrastructure


Project: http://git-wip-us.apache.org/repos/asf/tapestry-5/repo
Commit: http://git-wip-us.apache.org/repos/asf/tapestry-5/commit/9ce2d4e7
Tree: http://git-wip-us.apache.org/repos/asf/tapestry-5/tree/9ce2d4e7
Diff: http://git-wip-us.apache.org/repos/asf/tapestry-5/diff/9ce2d4e7

Branch: refs/heads/master
Commit: 9ce2d4e7c1a0142c9e351f3f201b2fe8cc5010d6
Parents: b6d1bde
Author: Howard M. Lewis Ship hls...@apache.org
Authored: Mon Nov 25 10:33:05 2013 -0800
Committer: Howard M. Lewis Ship hls...@apache.org
Committed: Mon Nov 25 10:33:05 2013 -0800

--
 .../src/test/app1/NestedFormFragment.tml| 18 
 .../tapestry5/integration/app1/AjaxTests.java   |  9 ++--
 .../app1/pages/NestedFormFragment.java  | 22 +---
 3 files changed, 7 insertions(+), 42 deletions(-)
--


http://git-wip-us.apache.org/repos/asf/tapestry-5/blob/9ce2d4e7/tapestry-core/src/test/app1/NestedFormFragment.tml
--
diff --git a/tapestry-core/src/test/app1/NestedFormFragment.tml 
b/tapestry-core/src/test/app1/NestedFormFragment.tml
index fe41262..2922e14 100644
--- a/tapestry-core/src/test/app1/NestedFormFragment.tml
+++ b/tapestry-core/src/test/app1/NestedFormFragment.tml
@@ -7,25 +7,15 @@
 t:form
 t:formfragment t:id=outerhide visible=true class=well
 div id=outertext1Outer Text -- nested in outerhide/div
+label class=checkbox
+t:checkbox t:id=innertrigger1 value=true 
t:mixins=triggerfragment fragment=innerhide/
+Trigger hide/reveal of innerhide
+/label
 t:formfragment t:id=innerhide visible=true
 div id=innertext1Inner Text -- nested in innerhide/div
-label class=checkbox
-t:checkbox t:id=innertrigger1 value=true 
t:mixins=triggerfragment fragment=innerhide/
-Trigger hide/reveal of innerhide
-/label
 /t:formfragment
 /t:formfragment
 
-t:formfragment t:id=outerremove visible=true class=well
-div id=outertext2Outer Text -- nested in outerremove/div
-t:formfragment t:id=innerremove visible=true
-div id=innertext2Inner Text -- nested in innerremove/div
-label class=checkbox
-t:checkbox t:id=innertrigger2 value=true/
-Does nothing ... looks like this was not fully implemented.
-/label
-/t:formfragment
-/t:formfragment
 
 /t:form
 /t:border

http://git-wip-us.apache.org/repos/asf/tapestry-5/blob/9ce2d4e7/tapestry-core/src/test/java/org/apache/tapestry5/integration/app1/AjaxTests.java
--
diff --git 
a/tapestry-core/src/test/java/org/apache/tapestry5/integration/app1/AjaxTests.java
 
b/tapestry-core/src/test/java/org/apache/tapestry5/integration/app1/AjaxTests.java
index 41f8673..17cb399 100644
--- 
a/tapestry-core/src/test/java/org/apache/tapestry5/integration/app1/AjaxTests.java
+++ 
b/tapestry-core/src/test/java/org/apache/tapestry5/integration/app1/AjaxTests.java
@@ -88,16 +88,11 @@ public class AjaxTests extends App1TestCase
 assertTrue(isVisible(outertext1));
 assertTrue(isVisible(innertext1));
 assertTrue(isChecked(innertrigger1));
+
 click(innertrigger1);
 
 assertTrue(isVisible(outertext1));
-
-//now make sure that hide_and_remove is properly handled, as well...
-assertTrue(isVisible(outertext2));
-assertTrue(isVisible(innertext2));
-
-// Looks like at one time there was work to have a trigger that 
removed the fragment entirely,
-// not just hide/reveal it, but that seems to have been lost.
+assertFalse(isVisible(innertext1));
 }
 
 /**

http://git-wip-us.apache.org/repos/asf/tapestry-5/blob/9ce2d4e7/tapestry-core/src/test/java/org/apache/tapestry5/integration/app1/pages/NestedFormFragment.java
--
diff --git 
a/tapestry-core/src/test/java/org/apache/tapestry5/integration/app1/pages/NestedFormFragment.java
 
b/tapestry-core/src/test/java/org/apache/tapestry5/integration/app1/pages/NestedFormFragment.java
index f5d6f5f..b90f4fe 100644
--- 
a/tapestry-core/src/test/java/org/apache/tapestry5/integration/app1/pages/NestedFormFragment.java
+++ 
b/tapestry-core/src/test/java/org/apache/tapestry5/integration/app1/pages/NestedFormFragment.java
@@ -1,26 +1,6 @@
 package org.apache.tapestry5.integration.app1.pages;
 
-import org.apache.tapestry5.ioc.annotations.Inject;
-import 

git commit: fix test

[uli]

Updated Branches:
  refs/heads/master 629fa5a41 - 6320748ab


fix test


Project: http://git-wip-us.apache.org/repos/asf/tapestry-5/repo
Commit: http://git-wip-us.apache.org/repos/asf/tapestry-5/commit/6320748a
Tree: http://git-wip-us.apache.org/repos/asf/tapestry-5/tree/6320748a
Diff: http://git-wip-us.apache.org/repos/asf/tapestry-5/diff/6320748a

Branch: refs/heads/master
Commit: 6320748ab4f56b64a4bcb69ce49897a5d1a24330
Parents: 629fa5a
Author: Ulrich Staerk u...@apache.org
Authored: Wed Jan 9 02:09:08 2013 +0100
Committer: Ulrich Staerk u...@apache.org
Committed: Wed Jan 9 02:09:08 2013 +0100

--
 tapestry-test/src/test/conf/testng.xml |2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
--


http://git-wip-us.apache.org/repos/asf/tapestry-5/blob/6320748a/tapestry-test/src/test/conf/testng.xml
--
diff --git a/tapestry-test/src/test/conf/testng.xml 
b/tapestry-test/src/test/conf/testng.xml
index b824a45..741c8fc 100644
--- a/tapestry-test/src/test/conf/testng.xml
+++ b/tapestry-test/src/test/conf/testng.xml
@@ -12,7 +12,7 @@
   parameter name=tapestry.web-app-folder value=src/test/webapp/
   test name=SeleniumLauncher and SeleniumTestBase
 classes
-  class name=org.apache.tapestry5.test.SanityCheckTestSuite/
+  class 
name=org.apache.tapestry5.test.integration.SanityCheckTestSuite/
 /classes
 
   /test

[49/50] git commit: Fix test broken by use of @MixinAfter on RenderNotification mixin

[hlship]

Fix test broken by use of @MixinAfter on RenderNotification mixin


Project: http://git-wip-us.apache.org/repos/asf/tapestry-5/repo
Commit: http://git-wip-us.apache.org/repos/asf/tapestry-5/commit/4da3d9bf
Tree: http://git-wip-us.apache.org/repos/asf/tapestry-5/tree/4da3d9bf
Diff: http://git-wip-us.apache.org/repos/asf/tapestry-5/diff/4da3d9bf

Branch: refs/heads/master
Commit: 4da3d9bfe64591cad399da76a85338f8178ba6dc
Parents: 8c95676
Author: Howard M. Lewis Ship hls...@apache.org
Authored: Thu Nov 29 17:28:46 2012 -0800
Committer: Howard M. Lewis Ship hls...@apache.org
Committed: Thu Nov 29 17:28:46 2012 -0800

--
 54_RELEASE_NOTES.txt   |8 +++-
 .../src/test/app1/RenderNotificationDemo.tml   |6 +++---
 2 files changed, 10 insertions(+), 4 deletions(-)
--


http://git-wip-us.apache.org/repos/asf/tapestry-5/blob/4da3d9bf/54_RELEASE_NOTES.txt
--
diff --git a/54_RELEASE_NOTES.txt b/54_RELEASE_NOTES.txt
index 785c1b1..cd773b2 100644
--- a/54_RELEASE_NOTES.txt
+++ b/54_RELEASE_NOTES.txt
@@ -152,4 +152,10 @@ The selected property is now type `Collection`, not 
specifically type `List`. It
 
 The Autocomplete mixin has been rewritten to use Bootstrap; this implies it 
will also force jQuery onto the page,
 to support the Bootstrap JavaScript library. In addition, Bootstrap's 
typeahead component does not support multiple
-tokens, so this behavior has been removed.
\ No newline at end of file
+tokens, so this behavior has been removed.
+
+## RenderNotification Mixin
+
+The timing of this mixin has changed, it now has the @MixinAfter annotation, 
so it triggers its events *after*
+the component to which it attaches has executed its @BeginRender phase, and 
*before* the component executes
+its @AfterRender phase.
\ No newline at end of file

http://git-wip-us.apache.org/repos/asf/tapestry-5/blob/4da3d9bf/tapestry-core/src/test/app1/RenderNotificationDemo.tml
--
diff --git a/tapestry-core/src/test/app1/RenderNotificationDemo.tml 
b/tapestry-core/src/test/app1/RenderNotificationDemo.tml
index 7f10fa6..249b3d4 100644
--- a/tapestry-core/src/test/app1/RenderNotificationDemo.tml
+++ b/tapestry-core/src/test/app1/RenderNotificationDemo.tml
@@ -1,9 +1,9 @@
-html t:type=Border 
xmlns:t=http://tapestry.apache.org/schema/tapestry_5_0_0.xsd;
+html t:type=Border 
xmlns:t=http://tapestry.apache.org/schema/tapestry_5_3.xsd;
 
   h1RenderNotification Mixin Demo/h1
 
-  ul id=list
-li t:type=any t:id=item t:mixins=rendernotificationitem body in 
template/li
+  ul id=list t:type=any t:id=item t:mixins=rendernotification
+liitem body in template/li
   /ul
 
 /html

[5/5] git commit: Fix test broken by use of @MixinAfter on RenderNotification mixin

[hlship]

Fix test broken by use of @MixinAfter on RenderNotification mixin


Project: http://git-wip-us.apache.org/repos/asf/tapestry-5/repo
Commit: http://git-wip-us.apache.org/repos/asf/tapestry-5/commit/4da3d9bf
Tree: http://git-wip-us.apache.org/repos/asf/tapestry-5/tree/4da3d9bf
Diff: http://git-wip-us.apache.org/repos/asf/tapestry-5/diff/4da3d9bf

Branch: refs/heads/5.4-js-rewrite
Commit: 4da3d9bfe64591cad399da76a85338f8178ba6dc
Parents: 8c95676
Author: Howard M. Lewis Ship hls...@apache.org
Authored: Thu Nov 29 17:28:46 2012 -0800
Committer: Howard M. Lewis Ship hls...@apache.org
Committed: Thu Nov 29 17:28:46 2012 -0800

--
 54_RELEASE_NOTES.txt   |8 +++-
 .../src/test/app1/RenderNotificationDemo.tml   |6 +++---
 2 files changed, 10 insertions(+), 4 deletions(-)
--


http://git-wip-us.apache.org/repos/asf/tapestry-5/blob/4da3d9bf/54_RELEASE_NOTES.txt
--
diff --git a/54_RELEASE_NOTES.txt b/54_RELEASE_NOTES.txt
index 785c1b1..cd773b2 100644
--- a/54_RELEASE_NOTES.txt
+++ b/54_RELEASE_NOTES.txt
@@ -152,4 +152,10 @@ The selected property is now type `Collection`, not 
specifically type `List`. It
 
 The Autocomplete mixin has been rewritten to use Bootstrap; this implies it 
will also force jQuery onto the page,
 to support the Bootstrap JavaScript library. In addition, Bootstrap's 
typeahead component does not support multiple
-tokens, so this behavior has been removed.
\ No newline at end of file
+tokens, so this behavior has been removed.
+
+## RenderNotification Mixin
+
+The timing of this mixin has changed, it now has the @MixinAfter annotation, 
so it triggers its events *after*
+the component to which it attaches has executed its @BeginRender phase, and 
*before* the component executes
+its @AfterRender phase.
\ No newline at end of file

http://git-wip-us.apache.org/repos/asf/tapestry-5/blob/4da3d9bf/tapestry-core/src/test/app1/RenderNotificationDemo.tml
--
diff --git a/tapestry-core/src/test/app1/RenderNotificationDemo.tml 
b/tapestry-core/src/test/app1/RenderNotificationDemo.tml
index 7f10fa6..249b3d4 100644
--- a/tapestry-core/src/test/app1/RenderNotificationDemo.tml
+++ b/tapestry-core/src/test/app1/RenderNotificationDemo.tml
@@ -1,9 +1,9 @@
-html t:type=Border 
xmlns:t=http://tapestry.apache.org/schema/tapestry_5_0_0.xsd;
+html t:type=Border 
xmlns:t=http://tapestry.apache.org/schema/tapestry_5_3.xsd;
 
   h1RenderNotification Mixin Demo/h1
 
-  ul id=list
-li t:type=any t:id=item t:mixins=rendernotificationitem body in 
template/li
+  ul id=list t:type=any t:id=item t:mixins=rendernotification
+liitem body in template/li
   /ul
 
 /html

git commit: Fix test broken by TAP5-1933 fix

[hlship]

Updated Branches:
  refs/heads/5.4-js-rewrite 0e2369ba0 - 4407ba9a1


Fix test broken by TAP5-1933 fix


Project: http://git-wip-us.apache.org/repos/asf/tapestry-5/repo
Commit: http://git-wip-us.apache.org/repos/asf/tapestry-5/commit/4407ba9a
Tree: http://git-wip-us.apache.org/repos/asf/tapestry-5/tree/4407ba9a
Diff: http://git-wip-us.apache.org/repos/asf/tapestry-5/diff/4407ba9a

Branch: refs/heads/5.4-js-rewrite
Commit: 4407ba9a12045aeb02973d5243a029ccf86d7ef5
Parents: 0e2369b
Author: Howard M. Lewis Ship hls...@apache.org
Authored: Fri Nov 2 16:47:17 2012 -0700
Committer: Howard M. Lewis Ship hls...@apache.org
Committed: Fri Nov 2 16:47:17 2012 -0700

--
 .../org/apache/tapestry5/validator/EmailTest.java  |   20 ++
 1 files changed, 3 insertions(+), 17 deletions(-)
--


http://git-wip-us.apache.org/repos/asf/tapestry-5/blob/4407ba9a/tapestry-core/src/test/java/org/apache/tapestry5/validator/EmailTest.java
--
diff --git 
a/tapestry-core/src/test/java/org/apache/tapestry5/validator/EmailTest.java 
b/tapestry-core/src/test/java/org/apache/tapestry5/validator/EmailTest.java
index cddeea8..4390637 100644
--- a/tapestry-core/src/test/java/org/apache/tapestry5/validator/EmailTest.java
+++ b/tapestry-core/src/test/java/org/apache/tapestry5/validator/EmailTest.java
@@ -40,12 +40,8 @@ public class EmailTest extends InternalBaseTestCase
 @Test
 public void input_mismatch() throws Exception
 {
-String label = My Field;
-Field field = mockFieldWithLabel(label);
+Field field = mockField();
 MessageFormatter formatter = mockMessageFormatter();
-String message = {message};
-
-train_format(formatter, message, label);
 
 replay();
 
@@ -58,17 +54,8 @@ public class EmailTest extends InternalBaseTestCase
 }
 catch (ValidationException ex)
 {
-assertEquals(ex.getMessage(), message);
-
-verify();
 }
 
-field = mockFieldWithLabel(label);
-
-train_format(formatter, message, label);
-
-replay();
-
 try
 {
 validator.validate(field, null, formatter, @mail.com);
@@ -76,10 +63,9 @@ public class EmailTest extends InternalBaseTestCase
 }
 catch (ValidationException ex)
 {
-assertEquals(ex.getMessage(), message);
-
-verify();
 }
 
+verify();
+
 }
 }