[GitHub] [tinkerpop] jorgebay commented on a change in pull request #1201: TINKERPOP-2293 Improved landing pages for all GLVs

[GitBox]

jorgebay commented on a change in pull request #1201: TINKERPOP-2293 Improved 
landing pages for all GLVs
URL: https://github.com/apache/tinkerpop/pull/1201#discussion_r327983429
 
 

 ##
 File path: gremlin-javascript/src/main/javascript/gremlin-javascript/README.md
 ##
 @@ -32,11 +32,39 @@ Gremlin-Javascript implements Gremlin within the 
JavaScript language and can be
 npm install gremlin
 ```
 
+Gremlin-Javascript is designed to connect to a "server" that is hosting a 
TinkerPop-enabled graph system. That "server" 
+could be [Gremlin Server][gs] or a [remote Gremlin provider][rgp] that exposes 
protocols by which Gremlin-Javascript 
+can connect.
+
+A typical connection to a server running on "localhost" that supports the 
Gremlin Server protocol using websockets 
+looks like this:
+
+```javascript
+const gremlin = require('gremlin');
+const traversal = gremlin.process.AnonymousTraversalSource.traversal;
+const DriverRemoteConnection = gremlin.driver.DriverRemoteConnection;
+
+const g = traversal().withRemote(new 
DriverRemoteConnection('ws://localhost:8182/gremlin'));
+```
+
+Once "g" has been established as a connection, it is then possible to start 
writing Gremlin traversals to query the 
 
 Review comment:
   ```suggestion
   Once "g" has been created using a connection, it is then possible to start 
writing Gremlin traversals to query the 
   ```


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [tinkerpop] jorgebay commented on a change in pull request #1201: TINKERPOP-2293 Improved landing pages for all GLVs

[GitBox]

jorgebay commented on a change in pull request #1201: TINKERPOP-2293 Improved 
landing pages for all GLVs
URL: https://github.com/apache/tinkerpop/pull/1201#discussion_r327983744
 
 

 ##
 File path: gremlin-python/src/main/jython/README
 ##
 @@ -32,6 +32,21 @@ chaining ``(a.b.c)``, round bracket function arguments 
``(a(b,c))```, and suppor
 ``(a(b()) vs a(__.b()))```. As such, anyone familiar with Gremlin-Java will 
immediately be able to work with
 Gremlin-Python. Moreover, there are a few added constructs to Gremlin-Python 
that make traversals a bit more succinct.
 
+Gremlin-Python is designed to connect to a "server" that is hosting a 
TinkerPop-enabled graph system. That "server"
+could be `Gremlin Server 
`_ or a
+`remote Gremlin provider` 
`_ that 
exposes
+protocols by which Gremlin-Python can connect.
+
+A typical connection to a server running on "localhost" that supports the 
Gremlin Server protocol using websockets
+from the Python shell looks like this:
+
+>>> from gremlin_python.process.anonymous_traversal import traversal
+>>> from gremlin_python.driver.driver_remote_connection import 
DriverRemoteConnection
+>>> g = 
traversal().withRemote(DriverRemoteConnection('ws://localhost:8182/gremlin','g'))
+
+Once "g" has been established as a connection, it is then possible to start 
writing Gremlin traversals to query the
 
 Review comment:
   ```suggestion
   Once "g" has been created using a connection, it is then possible to start 
writing Gremlin traversals to query the
   ```


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [tinkerpop] FlorianHockmann commented on a change in pull request #1201: TINKERPOP-2293 Improved landing pages for all GLVs

[GitBox]

FlorianHockmann commented on a change in pull request #1201: TINKERPOP-2293 
Improved landing pages for all GLVs
URL: https://github.com/apache/tinkerpop/pull/1201#discussion_r327984594
 
 

 ##
 File path: gremlin-dotnet/src/Gremlin.Net/Gremlin.Net.csproj
 ##
 @@ -36,8 +36,15 @@ Apache TinkerPop™ is a graph computing framework for both 
graph databases (OLT
 
 Gremlin.Net implements Gremlin within .NET. C# syntax has the same constructs 
as Java including "dot notation" for function chaining (a.b.c), round bracket 
function arguments (a(b,c)), and support for global namespaces (a(b()) vs 
a(__.b())). As such, anyone familiar with Gremlin-Java will immediately be able 
to work with Gremlin.Net. Moreover, there are a few added constructs to 
Gremlin.Net that make traversals a bit more succinct.
 
-Please see the reference documentation of Apache TinkerPop for more 
information on usage and use our Google Group gremlin-users if you have any 
questions:
-https://groups.google.com/forum/#!forum/gremlin-users
+Gremlin.Net is designed to connect to a "server" that is hosting a 
TinkerPop-enabled graph system. That "server" could be Gremlin Server
 
 Review comment:
   You probably want to edit the template instead of this generated file 
directly.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [tinkerpop] spmallette commented on a change in pull request #1201: TINKERPOP-2293 Improved landing pages for all GLVs

[GitBox]

spmallette commented on a change in pull request #1201: TINKERPOP-2293 Improved 
landing pages for all GLVs
URL: https://github.com/apache/tinkerpop/pull/1201#discussion_r328068609
 
 

 ##
 File path: gremlin-dotnet/src/Gremlin.Net/Gremlin.Net.csproj
 ##
 @@ -36,8 +36,15 @@ Apache TinkerPop™ is a graph computing framework for both 
graph databases (OLT
 
 Gremlin.Net implements Gremlin within .NET. C# syntax has the same constructs 
as Java including "dot notation" for function chaining (a.b.c), round bracket 
function arguments (a(b,c)), and support for global namespaces (a(b()) vs 
a(__.b())). As such, anyone familiar with Gremlin-Java will immediately be able 
to work with Gremlin.Net. Moreover, there are a few added constructs to 
Gremlin.Net that make traversals a bit more succinct.
 
-Please see the reference documentation of Apache TinkerPop for more 
information on usage and use our Google Group gremlin-users if you have any 
questions:
-https://groups.google.com/forum/#!forum/gremlin-users
+Gremlin.Net is designed to connect to a "server" that is hosting a 
TinkerPop-enabled graph system. That "server" could be Gremlin Server
 
 Review comment:
   oh wowthanks. i knew there was a reason i asked for review :)


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[tinkerpop] branch TINKERPOP-2293 updated (c05b9de -> e4da5eb)

[spmallette]

This is an automated email from the ASF dual-hosted git repository.

spmallette pushed a change to branch TINKERPOP-2293
in repository https://gitbox.apache.org/repos/asf/tinkerpop.git.


from c05b9de  TINKERPOP-2293 Improved landing pages for all GLVs
 add e4da5eb  Update 
gremlin-javascript/src/main/javascript/gremlin-javascript/README.md

No new revisions were added by this update.

Summary of changes:
 gremlin-javascript/src/main/javascript/gremlin-javascript/README.md | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

[tinkerpop] branch TINKERPOP-2293 updated (e4da5eb -> 268ddda)

[spmallette]

This is an automated email from the ASF dual-hosted git repository.

spmallette pushed a change to branch TINKERPOP-2293
in repository https://gitbox.apache.org/repos/asf/tinkerpop.git.


from e4da5eb  Update 
gremlin-javascript/src/main/javascript/gremlin-javascript/README.md
 add 268ddda  Update gremlin-python/src/main/jython/README

No new revisions were added by this update.

Summary of changes:
 gremlin-python/src/main/jython/README | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

[tinkerpop] branch TINKERPOP-2293 updated (268ddda -> 9176c3b)

[spmallette]

This is an automated email from the ASF dual-hosted git repository.

spmallette pushed a change to branch TINKERPOP-2293
in repository https://gitbox.apache.org/repos/asf/tinkerpop.git.


from 268ddda  Update gremlin-python/src/main/jython/README
 add 9176c3b  Added changes to .NET landing page csproj template.

No new revisions were added by this update.

Summary of changes:
 gremlin-dotnet/glv/Gremlin.Net.csproj.template | 11 +--
 1 file changed, 9 insertions(+), 2 deletions(-)

[GitHub] [tinkerpop] spmallette commented on issue #1201: TINKERPOP-2293 Improved landing pages for all GLVs

[GitBox]

spmallette commented on issue #1201: TINKERPOP-2293 Improved landing pages for 
all GLVs
URL: https://github.com/apache/tinkerpop/pull/1201#issuecomment-534981261
 
 
   Incorporated all suggestions. First time using that "commit suggestion" 
github button - neat. Thanks for the reviews. 


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[tinkerpop] branch TINKERPOP-2279 updated (644a8f1 -> 4a770a7)

[spmallette]

This is an automated email from the ASF dual-hosted git repository.

spmallette pushed a change to branch TINKERPOP-2279
in repository https://gitbox.apache.org/repos/asf/tinkerpop.git.


 discard 644a8f1  Added upgrade docs for python graphbinary
 discard 9d55619  Minor refactoring for graphbinary in python
 discard 93c5093  Fixed bug in python 2.7 support for request message 
serialization
 discard ee9a7ff  change test config back to localhost
 discard 9cc58b5  More use of compiled struct as well as faster methods for 
appending to bytearray
 discard 8040af3  Converted more pack calls to compiled Struct
 discard 836b68a  Moved requestId to header compiled Struct
 discard 5a917f0  Convert RequestMessage header to compiled Struct
 discard 45c1502  Extracted structs to functions to improve performance
 discard 15ca9b1  Imported struct functions more directly
 discard 9171d57  Close the BytesIO stream when done processing it.
 discard 74c5250  Fixed bad graphbinary serialization of TraversalStrategy
 discard 9c75014  Allow serializer to re-use the initialized bytearray avoiding 
creation of new ones
 discard 964fa2e  Prevented more bytearray creation on writes
 discard 228706b  Better reused bytearray in writes to enhance performance
 discard a100519  Create less bytearray() instances - gave a decent performance 
bump
 discard 846a7e3  Factor away varargs in as_bytes in GraphBinary for python
 discard 6aec348  Need to measure the byte length of string after utf-8 
conversion
 discard 51f18a5  Added duration derser to python graphbinary
 discard bddaf4f  Added SingleChar support to python graphbinary
 discard 35d1b21  Rename python function to use underscore
 discard 151d3ce  Factor away non-standard method of reading non-null strings 
for graphbinary in python
 discard 900d7f9  Refactored python graphbinary to stop using special means of 
string conversion
 discard c765da2  Generalized refactoring to python graphbinary.
 discard 9fedc2d  Renamed python graphbinary "IO" to der or ser depending on 
function
 discard 28b92c5  All GLV tests passing for GraphBinary
 discard e16d7ed  Fixed up BulkSet python graphbinary serialization
 discard fe29622  Cleaned up enum derser for python graphbinary a bit further
 discard d5de139  Fixed lambda serialization in python graphbinary
 discard a450bdf  Fixed handling of the null type in python graphbinary
 discard a595417  Fixed a basic integration test runs for python 2.
 discard c958745  Added fqcn to TraversalStrategy in python to allow 
GraphBinary serialization to work properly
 discard 33086df  Major refactoring for nullable writes.
 discard 52b3403  Improved null handling in graphbinary for python
 discard 42ba558  Major refactoring of GraphBinary
 discard 9e37173  Added graphbinary test files in gremlin-io-test for 3.4.3
 discard 58ccd98  Added BulkSet support to python graphbinary
 discard 872792e  Added boolean and textp to python graphbinary
 discard 67cf037  Added traverser, byte, bytearray to python graphbinary
 discard 969ba40  Added P/T/Scope graphbinary serialization for python
 discard 3a90011  Added bytecode graphbinary serialization to python
 discard 3f3888c  Aded Binding and fixed up enum derser in python graphbinary
 discard 5a77da1  Add enum graphbinary support in python
 discard abf64b7  Added Graph/Vertex/VertexProperty to python graphbinary
 discard 50cfcc4  Added property/path to python graphbinary
 discard f7c2396  Added uuid/edge to python graphbinary derser
 discard 93097f7  Added Dict/Set serialization for graphbinary in python
 discard 5b3ec7b  Added double and float graphbinary serialization in python
 discard f06a243  Fixed the graphbinary g;Date serialization - wasn't account 
for timezone stuff properly (still)
 discard dd8fcee  Added timestamp for graphbinary in python
 discard 39fb782  Added date graphbinary type to python
 discard 675ff63  Added Long graphbinary support to python
 discard a174970  Added int graphbinary serialization for python
 discard ccd374b  Add graphbinary support for list in python
 discard 3b1f196  Initial setup for GraphBinary in Python
 add c431828  Added evaluationTimeout as a RequestOptions supported token
 add b6e36d8  Fix javadoc to be less "script" oriented now that 
scriptEvaluationTimeout has been deprecated CTR
 add 2caf136  Merge branch 'tp33' into tp34
 add 79ce819  Return a 597 error code for lambda compilation problems.
 add 2e89be3  Merge branch 'tp33' into tp34
 add 0ac7f3a  TINKERPOP-1810 Support for withSack() that use Lambdas with 
remotes
 add 49bab07  Merge branch 'TINKERPOP-1810' into tp33
 add 9f500ec  Merge branch 'tp33' into tp34
 add 08add20  Initial setup for GraphBinary in Python
 add e5eac6b  Add graphbinary support for list in python
 add eb59c5c  Added int graphbinary serialization for python
 add d28f22e  Added Long graphbinary support to python
 add e319ff3  Added date graphbinary type to python
 add 686d867  Added timestamp 

[tinkerpop] branch master updated (c59714b -> 35da997)

[spmallette]

This is an automated email from the ASF dual-hosted git repository.

spmallette pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/tinkerpop.git.


from c59714b  Minor refactoring on GroovyTranslator changes CTR
 add 2ba3942  Bumped Jena to 3.12.0 CTR
 new 35da997  Merge branch 'tp34'

The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "add" were already present in the repository and have only
been added to this reference.


Summary of changes:
 sparql-gremlin/pom.xml | 18 ++
 1 file changed, 6 insertions(+), 12 deletions(-)

[tinkerpop] 01/01: Merge branch 'tp34'

[spmallette]

This is an automated email from the ASF dual-hosted git repository.

spmallette pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/tinkerpop.git

commit 35da997fe59e4eadf873e18f608667dfd3e21911
Merge: c59714b 2ba3942
Author: Stephen Mallette 
AuthorDate: Wed Sep 25 14:34:43 2019 -0400

Merge branch 'tp34'

 sparql-gremlin/pom.xml | 18 ++
 1 file changed, 6 insertions(+), 12 deletions(-)

[tinkerpop] branch tp34 updated (9f500ec -> 2ba3942)

[spmallette]

This is an automated email from the ASF dual-hosted git repository.

spmallette pushed a change to branch tp34
in repository https://gitbox.apache.org/repos/asf/tinkerpop.git.


from 9f500ec  Merge branch 'tp33' into tp34
 add 2ba3942  Bumped Jena to 3.12.0 CTR

No new revisions were added by this update.

Summary of changes:
 sparql-gremlin/pom.xml | 18 ++
 1 file changed, 6 insertions(+), 12 deletions(-)

[GitHub] [tinkerpop] spmallette commented on a change in pull request #1188: [TINKERPOP-2274] Fixed the issues revealed while compiling and runnin…

[GitBox]

spmallette commented on a change in pull request #1188: [TINKERPOP-2274] Fixed 
the issues revealed while compiling and runnin…
URL: https://github.com/apache/tinkerpop/pull/1188#discussion_r328294652
 
 

 ##
 File path: pom.xml
 ##
 @@ -109,9 +109,6 @@ limitations under the License.
 https://github.com/twilmes
 
 
-
-3.3.9
 
 Review comment:
   any reason you removed 3.3.9? 
   
   it's interesting that we have 3.3.9 at the maven level, but enforcer only 
requires 3.2.5 (and our dev docs also say the minimum is 3.2.5).  I noticed 
that the reason we went to a 3.3.9 minimum was something related to the jacoco 
plugin requiring that version:
   
   
https://github.com/apache/tinkerpop/commit/5c9c8ce1e602c7766f4f7200ba5ec4e66718fbc5
   
   I wonder if we should really be at 3.3.9 rather than 3.2.5...thoughts?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [tinkerpop] spmallette commented on a change in pull request #1188: [TINKERPOP-2274] Fixed the issues revealed while compiling and runnin…

[GitBox]

spmallette commented on a change in pull request #1188: [TINKERPOP-2274] Fixed 
the issues revealed while compiling and runnin…
URL: https://github.com/apache/tinkerpop/pull/1188#discussion_r328295158
 
 

 ##
 File path: 
gremlin-core/src/test/java/org/apache/tinkerpop/gremlin/structure/util/ComparatorsTest.java
 ##
 @@ -18,20 +18,20 @@
  */
 package org.apache.tinkerpop.gremlin.structure.util;
 
+import static org.junit.Assert.assertEquals;
 
 Review comment:
   lgtm - thank you for doing that.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [tinkerpop] spmallette commented on issue #1188: [TINKERPOP-2274] Fixed the issues revealed while compiling and runnin…

[GitBox]

spmallette commented on issue #1188: [TINKERPOP-2274] Fixed the issues revealed 
while compiling and runnin…
URL: https://github.com/apache/tinkerpop/pull/1188#issuecomment-535171555
 
 
   @robertdale did you ever get a chance to return to this one? I see your 
using Java version: 1.8.0_221 so it would be curious for nashorn to be missing. 
anyway, i'm running some final tests on this now around less used build options 
and documentation generation. if all that pans out and we sort out the 
"required maven version" issue I just commented on, i'm inclined to be in favor 
of merging this.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [tinkerpop] robertdale commented on issue #1188: [TINKERPOP-2274] Fixed the issues revealed while compiling and runnin…

[GitBox]

robertdale commented on issue #1188: [TINKERPOP-2274] Fixed the issues revealed 
while compiling and runnin…
URL: https://github.com/apache/tinkerpop/pull/1188#issuecomment-535239325
 
 
   Nashorn is there. Paths, settings look good. `jjs` works.  Also, it doesn't 
explain the other two test failures which don't appear to have anything to do 
with scripting.  I don't know what's special about these three tests.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services