[GitHub] [tinkerpop] spmallette merged pull request #1203: TINKERPOP-2302 add `ElementMapStep#isOnGraphComputer()` (tp34)
spmallette merged pull request #1203: TINKERPOP-2302 add `ElementMapStep#isOnGraphComputer()` (tp34) URL: https://github.com/apache/tinkerpop/pull/1203 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [tinkerpop] spmallette commented on issue #1203: TINKERPOP-2302 add `ElementMapStep#isOnGraphComputer()` (tp34)
spmallette commented on issue #1203: TINKERPOP-2302 add `ElementMapStep#isOnGraphComputer()` (tp34) URL: https://github.com/apache/tinkerpop/pull/1203#issuecomment-536973919 Merging via CTR This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[tinkerpop] branch tp34 updated: TINKERPOP-2302 add `ElementMapStep#isOnGraphComputer()`
This is an automated email from the ASF dual-hosted git repository.
spmallette pushed a commit to branch tp34
in repository https://gitbox.apache.org/repos/asf/tinkerpop.git
The following commit(s) were added to refs/heads/tp34 by this push:
new 757c1f5 TINKERPOP-2302 add `ElementMapStep#isOnGraphComputer()`
new 3e08b63 Merge pull request #1203 from dalaro/TINKERPOP-2303-on-tp34
757c1f5 is described below
commit 757c1f59e7606964ffb0f18f4dc07f8ee408ae78
Author: Dan LaRocque
AuthorDate: Mon Sep 30 00:44:28 2019 -0500
TINKERPOP-2302 add `ElementMapStep#isOnGraphComputer()`
---
.../tinkerpop/gremlin/process/traversal/step/map/ElementMapStep.java | 3 +++
1 file changed, 3 insertions(+)
diff --git
a/gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/step/map/ElementMapStep.java
b/gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/step/map/ElementMapStep.java
index f8143f0..2f1db43 100644
---
a/gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/step/map/ElementMapStep.java
+++
b/gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/step/map/ElementMapStep.java
@@ -97,6 +97,9 @@ public class ElementMapStep extends MapStep> implements
this.onGraphComputer = true;
}
+public boolean isOnGraphComputer() {
+return onGraphComputer;
+}
public String[] getPropertyKeys() {
return propertyKeys;
[GitHub] [tinkerpop] spmallette merged pull request #1204: TINKERPOP-2302 add `ElementMapStep#isOnGraphComputer()` (master)
spmallette merged pull request #1204: TINKERPOP-2302 add `ElementMapStep#isOnGraphComputer()` (master) URL: https://github.com/apache/tinkerpop/pull/1204 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[tinkerpop] branch master updated (7ab458c -> 97f0d4a)
This is an automated email from the ASF dual-hosted git repository. spmallette pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/tinkerpop.git. from 7ab458c Merge branch 'tp34' new 757c1f5 TINKERPOP-2302 add `ElementMapStep#isOnGraphComputer()` new 7f8edee Merge branch 'TINKERPOP-2303-on-tp34' into TINKERPOP-2303-on-master new 97f0d4a Merge pull request #1204 from dalaro/TINKERPOP-2303-on-master The 15826 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: .../tinkerpop/gremlin/process/traversal/step/map/ElementMapStep.java | 3 +++ 1 file changed, 3 insertions(+)
[GitHub] [tinkerpop] spmallette commented on issue #1204: TINKERPOP-2302 add `ElementMapStep#isOnGraphComputer()` (master)
spmallette commented on issue #1204: TINKERPOP-2302 add `ElementMapStep#isOnGraphComputer()` (master) URL: https://github.com/apache/tinkerpop/pull/1204#issuecomment-536974084 merging via CTR This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[tinkerpop] branch master updated (97f0d4a -> 77cbeed)
This is an automated email from the ASF dual-hosted git repository. spmallette pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/tinkerpop.git. from 97f0d4a Merge pull request #1204 from dalaro/TINKERPOP-2303-on-master add 3e08b63 Merge pull request #1203 from dalaro/TINKERPOP-2303-on-tp34 new 77cbeed Merge branch 'tp34' The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes:
[tinkerpop] 01/01: Merge branch 'tp34'
This is an automated email from the ASF dual-hosted git repository. spmallette pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/tinkerpop.git commit 77cbeede986635a2d88e713b69edc533cbb4efc6 Merge: 97f0d4a 3e08b63 Author: Stephen Mallette AuthorDate: Tue Oct 1 06:30:11 2019 -0400 Merge branch 'tp34'
[tinkerpop] branch driver-35 updated: Added upgrade docs/changelog for java driver
This is an automated email from the ASF dual-hosted git repository. spmallette pushed a commit to branch driver-35 in repository https://gitbox.apache.org/repos/asf/tinkerpop.git The following commit(s) were added to refs/heads/driver-35 by this push: new b993a06 Added upgrade docs/changelog for java driver b993a06 is described below commit b993a06afcef63552f0a94f0f2ad66580cf7994d Author: Stephen Mallette AuthorDate: Tue Oct 1 07:01:54 2019 -0400 Added upgrade docs/changelog for java driver --- CHANGELOG.asciidoc | 1 + docs/src/reference/gremlin-variants.asciidoc | 9 +++-- docs/src/upgrade/release-3.5.x.asciidoc | 10 ++ 3 files changed, 18 insertions(+), 2 deletions(-) diff --git a/CHANGELOG.asciidoc b/CHANGELOG.asciidoc index b1b9e80..3645400 100644 --- a/CHANGELOG.asciidoc +++ b/CHANGELOG.asciidoc @@ -25,6 +25,7 @@ image::https://raw.githubusercontent.com/apache/tinkerpop/master/docs/static/ima This release also includes changes from <>. +* Refactored the Java driver to use one connection per request. * Modified `null` handling in mutations to be consistent for a new `Vertex` as well as update to an existing one. * Upgraded to Apache Commons Configuration2. * Renamed `StoreStep` to `AggregateLocalStep`. diff --git a/docs/src/reference/gremlin-variants.asciidoc b/docs/src/reference/gremlin-variants.asciidoc index 5aea700..28798bc 100644 --- a/docs/src/reference/gremlin-variants.asciidoc +++ b/docs/src/reference/gremlin-variants.asciidoc @@ -273,9 +273,14 @@ Please see the link:http://tinkerpop.apache.org/javadocs/x.y.z/core/org/apache/t Choosing a value for ConnectionPool.maxSize -`ConnectionPool.maxSize` represents the maximum number of concurrent requests that the client can make to the server. Each request is made using its own websocket connection, hence, this parameter also controls the maximum number of WebSocket connections that can be concurrently opened to the server. +`ConnectionPool.maxSize` represents the maximum number of concurrent requests that the client can make to the server. +Each request is made using its own websocket connection, hence, this parameter also controls the maximum number of +WebSocket connections that can be concurrently opened to the server. + +While choosing a value for this parameter, determine how many requests you anticipate to run in parallel from your +client. Beyond this number you would start getting timeout exceptions and should handle those timeouts at the +application layer. -While choosing a value for this parameter, determine how many requests you anticipate to run in parallel from your client. Beyond this number you would start getting timeout exceptions and should handle those timeouts at the application layer. === Serialization Remote systems like Gremlin Server and Remote Gremlin Providers respond to requests made in a particular serialization diff --git a/docs/src/upgrade/release-3.5.x.asciidoc b/docs/src/upgrade/release-3.5.x.asciidoc index cd04b4e..e4f6310 100644 --- a/docs/src/upgrade/release-3.5.x.asciidoc +++ b/docs/src/upgrade/release-3.5.x.asciidoc @@ -29,6 +29,16 @@ Please see the link:https://github.com/apache/tinkerpop/blob/3.5.0/CHANGELOG.asc === Upgrading for Users + Java Driver + +The `gremlin-driver` has undergone some significant changes that have improved it's usability and stability. By +modifying its request processing model to utilize a single channel, the logic for configuring the driver becomes less +entangled and easier to reason about as the removal of multiplexing eliminates the need to think about simultaneous +connection usage and requests in process. Instead, users simply need to consider the connection pool size which +represents the maximum number of concurrent requests that the client can make to the server. + +See: link:https://issues.apache.org/jira/browse/TINKERPOP-2205[TINKERPOP-2205] + Gryo Usage Since the first release of TinkerPop 3.x, Gryo has been the default serialization format for Gremlin Server and
[tinkerpop] branch driver-35 updated: Added test to show fix for TINKERPOP-2132 which related to problems with authentication over multiple threads.
This is an automated email from the ASF dual-hosted git repository.
spmallette pushed a commit to branch driver-35
in repository https://gitbox.apache.org/repos/asf/tinkerpop.git
The following commit(s) were added to refs/heads/driver-35 by this push:
new 4232a40 Added test to show fix for TINKERPOP-2132 which related to
problems with authentication over multiple threads.
4232a40 is described below
commit 4232a403a300eaaa534cfca2ee5f29bb1fafaa03
Author: Stephen Mallette
AuthorDate: Tue Oct 1 11:53:15 2019 -0400
Added test to show fix for TINKERPOP-2132 which related to problems with
authentication over multiple threads.
---
...ClientSingleRequestConnectionIntegrateTest.java | 2 --
.../server/GremlinServerAuthKrb5IntegrateTest.java | 23 ++
2 files changed, 23 insertions(+), 2 deletions(-)
diff --git
a/gremlin-server/src/test/java/org/apache/tinkerpop/gremlin/driver/ClientSingleRequestConnectionIntegrateTest.java
b/gremlin-server/src/test/java/org/apache/tinkerpop/gremlin/driver/ClientSingleRequestConnectionIntegrateTest.java
index 89dfdda..49d39a4 100644
---
a/gremlin-server/src/test/java/org/apache/tinkerpop/gremlin/driver/ClientSingleRequestConnectionIntegrateTest.java
+++
b/gremlin-server/src/test/java/org/apache/tinkerpop/gremlin/driver/ClientSingleRequestConnectionIntegrateTest.java
@@ -46,8 +46,6 @@ import java.util.stream.IntStream;
import static org.hamcrest.CoreMatchers.is;
import static org.hamcrest.MatcherAssert.assertThat;
-import static org.hamcrest.Matchers.not;
-import static org.hamcrest.core.IsCollectionContaining.hasItem;
import static org.junit.Assert.assertEquals;
import static org.junit.Assert.fail;
diff --git
a/gremlin-server/src/test/java/org/apache/tinkerpop/gremlin/server/GremlinServerAuthKrb5IntegrateTest.java
b/gremlin-server/src/test/java/org/apache/tinkerpop/gremlin/server/GremlinServerAuthKrb5IntegrateTest.java
index de838e0..7ac1fbd 100644
---
a/gremlin-server/src/test/java/org/apache/tinkerpop/gremlin/server/GremlinServerAuthKrb5IntegrateTest.java
+++
b/gremlin-server/src/test/java/org/apache/tinkerpop/gremlin/server/GremlinServerAuthKrb5IntegrateTest.java
@@ -287,6 +287,29 @@ public class GremlinServerAuthKrb5IntegrateTest extends
AbstractGremlinServerInt
assertAuthViaToStringWithSpecifiedSerializer(new
GraphBinaryMessageSerializerV1());
}
+@Test
+public void shouldAuthenticateWithThreads() throws Exception {
+final Cluster cluster =
TestClientFactory.build().jaasEntry(TESTCONSOLE)
+
.protocol(kdcServer.serverPrincipalName).addContactPoint(kdcServer.hostname).create();
+final GraphTraversalSource g =
traversal().withRemote(DriverRemoteConnection.using(cluster, "gmodern"));
+
+final ExecutorService executor = Executors.newFixedThreadPool(4);
+final Callable countTraversalJob = () ->
g.V().both().both().count().next();
+final List> results =
executor.invokeAll(Collections.nCopies(100, countTraversalJob));
+
+assertEquals(100, results.size());
+for (int ix = 0; ix < results.size(); ix++) {
+try {
+assertEquals(30L, results.get(ix).get(1000,
TimeUnit.MILLISECONDS).longValue());
+} catch (Exception ex) {
+// failure but shouldn't have
+cluster.close();
+fail("Exception halted assertions - " + ex.getMessage());
+}
+}
+cluster.close();
+}
+
public void assertAuthViaToStringWithSpecifiedSerializer(final
MessageSerializer serializer) throws InterruptedException, ExecutionException {
final Map config = new HashMap<>();
config.put("serializeResultToString", true);
