[GitHub] [tinkerpop] github5775 commented on issue #1172: Handle closed connections gracefully instead of bubbling up exceptions
github5775 commented on issue #1172: Handle closed connections gracefully instead of bubbling up exceptions URL: https://github.com/apache/tinkerpop/pull/1172#issuecomment-587310721 @plemanach, have you experienced this timeout? if so, i have a fix that has been working for a heavily used prod app with no errors for over 6 months. you can use it while we figure out the best way to handle this. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [tinkerpop] jorgebay opened a new pull request #1249: TINKERPOP-2339 Bump System.Net.WebSockets.Client dependency
jorgebay opened a new pull request #1249: TINKERPOP-2339 Bump System.Net.WebSockets.Client dependency URL: https://github.com/apache/tinkerpop/pull/1249 Bump `System.Net.WebSockets.Client` dependency to `4.3.2` in Gremlin.Net. https://issues.apache.org/jira/browse/TINKERPOP-2339 VOTE +1 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[tinkerpop] 01/01: TINKERPOP-2339 Bump System.Net.WebSockets.Client dependency
This is an automated email from the ASF dual-hosted git repository. jorgebg pushed a commit to branch TINKERPOP-2339 in repository https://gitbox.apache.org/repos/asf/tinkerpop.git commit 51f3a8f4ac95dda0c489ad7ca52aca3789d71e15 Author: Jorge Bay Gondra AuthorDate: Mon Feb 17 15:23:22 2020 +0100 TINKERPOP-2339 Bump System.Net.WebSockets.Client dependency --- gremlin-dotnet/glv/Gremlin.Net.csproj.template| 2 +- gremlin-dotnet/src/Gremlin.Net/Gremlin.Net.csproj | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/gremlin-dotnet/glv/Gremlin.Net.csproj.template b/gremlin-dotnet/glv/Gremlin.Net.csproj.template index 1a6b949..f66676e 100644 --- a/gremlin-dotnet/glv/Gremlin.Net.csproj.template +++ b/gremlin-dotnet/glv/Gremlin.Net.csproj.template @@ -67,7 +67,7 @@ NOTE that versions suffixed with "-rc" are considered release candidates (i.e. p - + diff --git a/gremlin-dotnet/src/Gremlin.Net/Gremlin.Net.csproj b/gremlin-dotnet/src/Gremlin.Net/Gremlin.Net.csproj index e5d8aee..a1f8146 100644 --- a/gremlin-dotnet/src/Gremlin.Net/Gremlin.Net.csproj +++ b/gremlin-dotnet/src/Gremlin.Net/Gremlin.Net.csproj @@ -67,7 +67,7 @@ NOTE that versions suffixed with "-rc" are considered release candidates (i.e. p - +
[tinkerpop] branch TINKERPOP-2339 created (now 51f3a8f)
This is an automated email from the ASF dual-hosted git repository. jorgebg pushed a change to branch TINKERPOP-2339 in repository https://gitbox.apache.org/repos/asf/tinkerpop.git. at 51f3a8f TINKERPOP-2339 Bump System.Net.WebSockets.Client dependency This branch includes the following new commits: new 51f3a8f TINKERPOP-2339 Bump System.Net.WebSockets.Client dependency The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference.
[GitHub] [tinkerpop] FlorianHockmann commented on issue #1248: Fix to iOS platform
FlorianHockmann commented on issue #1248: Fix to iOS platform URL: https://github.com/apache/tinkerpop/pull/1248#issuecomment-586994980 OK, thanks for the explanation. It's of course unfortunate that this doesn't work on Xamarin for some reason, but it's only a stylistic change in an internal API, so I'm ok with this. VOTE +1 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [tinkerpop] jorgebay commented on a change in pull request #1243: js: add session connection
jorgebay commented on a change in pull request #1243: js: add session connection
URL: https://github.com/apache/tinkerpop/pull/1243#discussion_r380117937
##
File path:
gremlin-javascript/src/main/javascript/gremlin-javascript/lib/driver/connection.js
##
@@ -95,11 +95,15 @@ class Connection extends EventEmitter {
this.isOpen = false;
this.traversalSource = options.traversalSource || 'g';
this._authenticator = options.authenticator;
+this._session = options.session || false;
Review comment:
We should add `options.session` to the `Connection` and to the `Client`
jsdoc.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [tinkerpop] jorgebay commented on a change in pull request #1243: js: add session connection
jorgebay commented on a change in pull request #1243: js: add session connection
URL: https://github.com/apache/tinkerpop/pull/1243#discussion_r380123784
##
File path:
gremlin-javascript/src/main/javascript/gremlin-javascript/lib/driver/connection.js
##
@@ -199,6 +218,22 @@ class Connection extends EventEmitter {
});
}
+ _getSessionRequest(id, op, args) {
+ if (args) {
+ args = this._adaptArgs(args, true);
+ } else {
+ args = {'gremlin': 'session.close()'};
+ }
+ args['session'] = this._sessionId;
+
+ return ({
+ 'requestId': { '@type': 'g:UUID', '@value': id },
+ 'op': op || 'eval',
+ 'processor': 'session',
+ 'args': args
+ });
+ }
Review comment:
Maybe we could extract common functionality between `_getRequest()` and
`_getSessionRequest()`.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [tinkerpop] jorgebay commented on a change in pull request #1243: js: add session connection
jorgebay commented on a change in pull request #1243: js: add session connection
URL: https://github.com/apache/tinkerpop/pull/1243#discussion_r380120136
##
File path:
gremlin-javascript/src/main/javascript/gremlin-javascript/lib/driver/connection.js
##
@@ -165,6 +169,21 @@ class Connection extends EventEmitter {
};
}
+ if (this._session === true && op !== 'authentication') {
+if (bytecode !== null) {
+ reject(new Error('do not support bytecode in session mode'));
+ return;
+}
+if (args === null) {
+ reject(new Error('get nil args in request'));
+ return;
+}
+
+const message = Buffer.from(this._header +
JSON.stringify(this._getSessionRequest(requestId, null, args)))
Review comment:
Missing `;` at the end of the statement.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [tinkerpop] jorgebay commented on a change in pull request #1243: js: add session connection
jorgebay commented on a change in pull request #1243: js: add session connection
URL: https://github.com/apache/tinkerpop/pull/1243#discussion_r380121270
##
File path:
gremlin-javascript/src/main/javascript/gremlin-javascript/lib/driver/connection.js
##
@@ -365,6 +400,11 @@ class Connection extends EventEmitter {
}
if (!this._closePromise) {
this._closePromise = new Promise(resolve => {
+if (this._session === true) {
+ const message = Buffer.from(this._header +
JSON.stringify(this._getSessionRequest(utils.getUuid(), 'close', null)))
Review comment:
Missing `;`
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [tinkerpop] jorgebay commented on a change in pull request #1243: js: add session connection
jorgebay commented on a change in pull request #1243: js: add session connection
URL: https://github.com/apache/tinkerpop/pull/1243#discussion_r380125983
##
File path:
gremlin-javascript/src/main/javascript/gremlin-javascript/lib/driver/connection.js
##
@@ -165,6 +169,21 @@ class Connection extends EventEmitter {
};
}
+ if (this._session === true && op !== 'authentication') {
+if (bytecode !== null) {
+ reject(new Error('do not support bytecode in session mode'));
+ return;
+}
+if (args === null) {
+ reject(new Error('get nil args in request'));
+ return;
+}
Review comment:
This should be extracted at the beginning of the method:
```javascript
submit(bytecode, op, args, requestId, processor) {
if (bytecode !== null) {
return Promise.reject(new Error('Bytecode in session mode is not
supported'));
}
if (args === null) {
return Promise.reject(new Error('args should not be null'));
}
}
```
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [tinkerpop] Haapsaari-Juha commented on issue #1248: Fix to iOS platform
Haapsaari-Juha commented on issue #1248: Fix to iOS platform URL: https://github.com/apache/tinkerpop/pull/1248#issuecomment-586929041 I'm using Xamarin Forms platform and they have limitation on iOS documented here: https://docs.microsoft.com/en-us/xamarin/ios/internals/limitations But this code is not using any dynamic code so when digging a bit deeper in to the problem it might also be caused of this: https://github.com/dotnet/runtime/issues/31075 So issue in dotnet corefx might cause this. I don't know why CreateCustomDelegate method is called when using out IGraphSONSerializer in the code but this might be the source for the exception. But same code without using out parameter works. Could not find any reference that would say this is not allowed in iOS and I'm using out parameters with types like decimal, int, string etc. in iOS without any problems. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [tinkerpop] FlorianHockmann commented on issue #1248: Fix to iOS platform
FlorianHockmann commented on issue #1248: Fix to iOS platform URL: https://github.com/apache/tinkerpop/pull/1248#issuecomment-586915216 Do you have a reference for the iOS platform not being able to handle out parameters? I never heard of this (but I have also never worked on iOS so that doesn't have to say much). It would be good to know in general whether we need to avoid certain C# features because they aren't supported on some platforms. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
