[GitHub] [tinkerpop] simonz-bq commented on pull request #1556: Milestone 1 of the gremlin-go driver
simonz-bq commented on pull request #1556: URL: https://github.com/apache/tinkerpop/pull/1556#issuecomment-1039772844 @divijvaidya thanks for the feedback! I responded to a majority of your comments to keep track of what we have already tackled in milestone 2 as well as additional changes that were made to address your points. Anything that wasn't addressed is tracked and will either require work at a later time, or some investigation on what the best way to approach finding a solution is. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@tinkerpop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [tinkerpop] simonz-bq commented on a change in pull request #1556: Milestone 1 of the gremlin-go driver
simonz-bq commented on a change in pull request #1556:
URL: https://github.com/apache/tinkerpop/pull/1556#discussion_r806384793
##
File path: gremlin-go/driver/gorillaTransporter.go
##
@@ -0,0 +1,91 @@
+/*
+Licensed to the Apache Software Foundation (ASF) under one
+or more contributor license agreements. See the NOTICE file
+distributed with this work for additional information
+regarding copyright ownership. The ASF licenses this file
+to you under the Apache License, Version 2.0 (the
+"License"); you may not use this file except in compliance
+with the License. You may obtain a copy of the License at
+
+http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing,
+software distributed under the License is distributed on an
+"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+KIND, either express or implied. See the License for the
+specific language governing permissions and limitations
+under the License.
+*/
+
+package gremlingo
+
+import (
+ "net/url"
+ "strconv"
+
+ "github.com/gorilla/websocket"
+)
+
+type gorillaTransporter struct {
+ host string
+ port int
+ connection websocketConn
+ isClosed bool
+}
+
+func (transporter *gorillaTransporter) Connect() (err error) {
+ if transporter.connection != nil {
+ return
Review comment:
This part of the logic has been refactored as of MS2 to have a more
intuitive workflow.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [tinkerpop] simonz-bq commented on a change in pull request #1556: Milestone 1 of the gremlin-go driver
simonz-bq commented on a change in pull request #1556: URL: https://github.com/apache/tinkerpop/pull/1556#discussion_r806384527 ## File path: gremlin-go/driver/gorillaTransporter.go ## @@ -0,0 +1,91 @@ +/* +Licensed to the Apache Software Foundation (ASF) under one +or more contributor license agreements. See the NOTICE file +distributed with this work for additional information +regarding copyright ownership. The ASF licenses this file +to you under the Apache License, Version 2.0 (the +"License"); you may not use this file except in compliance +with the License. You may obtain a copy of the License at + +http://www.apache.org/licenses/LICENSE-2.0 + +Unless required by applicable law or agreed to in writing, +software distributed under the License is distributed on an +"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +KIND, either express or implied. See the License for the +specific language governing permissions and limitations +under the License. +*/ + +package gremlingo + +import ( + "net/url" + "strconv" + + "github.com/gorilla/websocket" +) + Review comment: Done. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@tinkerpop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [tinkerpop] simonz-bq commented on a change in pull request #1556: Milestone 1 of the gremlin-go driver
simonz-bq commented on a change in pull request #1556: URL: https://github.com/apache/tinkerpop/pull/1556#discussion_r806384461 ## File path: gremlin-go/driver/transporterFactory.go ## @@ -0,0 +1,37 @@ +/* +Licensed to the Apache Software Foundation (ASF) under one +or more contributor license agreements. See the NOTICE file +distributed with this work for additional information +regarding copyright ownership. The ASF licenses this file +to you under the Apache License, Version 2.0 (the +"License"); you may not use this file except in compliance +with the License. You may obtain a copy of the License at + +http://www.apache.org/licenses/LICENSE-2.0 + +Unless required by applicable law or agreed to in writing, +software distributed under the License is distributed on an +"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +KIND, either express or implied. See the License for the +specific language governing permissions and limitations +under the License. +*/ + +package gremlingo + +// TransporterType is an alias for valid transport protocols. +type TransporterType int + +const ( + // Gorilla transport layer: github.com/gorilla/websocket + Gorilla TransporterType = iota Review comment: Given the way we consume configuration, it wouldn't be an issue in this case. Regardless, this is a good suggestion and has been changed for MS2! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@tinkerpop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [tinkerpop] simonz-bq commented on a change in pull request #1556: Milestone 1 of the gremlin-go driver
simonz-bq commented on a change in pull request #1556:
URL: https://github.com/apache/tinkerpop/pull/1556#discussion_r806384003
##
File path: gremlin-go/driver/client.go
##
@@ -0,0 +1,87 @@
+/*
+Licensed to the Apache Software Foundation (ASF) under one
+or more contributor license agreements. See the NOTICE file
+distributed with this work for additional information
+regarding copyright ownership. The ASF licenses this file
+to you under the Apache License, Version 2.0 (the
+"License"); you may not use this file except in compliance
+with the License. You may obtain a copy of the License at
+
+http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing,
+software distributed under the License is distributed on an
+"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+KIND, either express or implied. See the License for the
+specific language governing permissions and limitations
+under the License.
+*/
+
+package gremlingo
+
+import (
+ "golang.org/x/text/language"
+)
+
+// ClientSettings is used to modify a Client's settings on initialization.
+type ClientSettings struct {
+ TransporterType TransporterType
+ LogVerbosityLogVerbosity
+ Logger Logger
+ Languagelanguage.Tag
+}
+
+// Client is used to connect and interact with a Gremlin-supported server.
+type Client struct {
+ hoststring
+ portint
+ logHandler *logHandler
+ transporterType TransporterType
+ connection *connection
+}
+
+// NewClient creates a Client and configures it with the given parameters.
+func NewClient(host string, port int, configurations ...func(settings
*ClientSettings)) *Client {
+ settings := &ClientSettings{
+ TransporterType: Gorilla,
+ LogVerbosity:Info,
+ Logger: &defaultLogger{},
+ Language:language.English,
+ }
+ for _, configuration := range configurations {
+ configuration(settings)
+ }
+
+ logHandler := newLogHandler(settings.Logger, settings.LogVerbosity,
settings.Language)
+ client := &Client{
+ host:host,
+ port:port,
+ logHandler: logHandler,
+ transporterType: settings.TransporterType,
+ connection: nil,
+ }
+ return client
+}
+
+// Close closes the client via connection
+func (client *Client) Close() error {
+ return client.connection.close()
+}
+
+// Submit submits a Gremlin script to the server and returns a ResultSet
Review comment:
As of MS2, it is no longer a synchronous call!
##
File path: gremlin-go/driver/request.go
##
@@ -0,0 +1,42 @@
+/*
+Licensed to the Apache Software Foundation (ASF) under one
+or more contributor license agreements. See the NOTICE file
+distributed with this work for additional information
+regarding copyright ownership. The ASF licenses this file
+to you under the Apache License, Version 2.0 (the
+"License"); you may not use this file except in compliance
+with the License. You may obtain a copy of the License at
+
+http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing,
+software distributed under the License is distributed on an
+"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+KIND, either express or implied. See the License for the
+specific language governing permissions and limitations
+under the License.
+*/
+
+package gremlingo
+
+import "github.com/google/uuid"
+
+const op = "eval"
+const processor = ""
+
+// request represents a request to the server
+type request struct {
+ requestID uuid.UUID `json:"requestId"`
+ opstring `json:"op"`
+ processor string `json:"processor"`
+ args map[string]interface{} `json:"args"`
+}
+
+func makeStringRequest(requestString string) (req request) {
+ return request{uuid.New(), op, processor, map[string]interface{}{
+ "gremlin": requestString,
+ "aliases": map[string]interface{}{
+ "g": "g",
Review comment:
TODO added and tracked.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [tinkerpop] simonz-bq commented on a change in pull request #1556: Milestone 1 of the gremlin-go driver
simonz-bq commented on a change in pull request #1556:
URL: https://github.com/apache/tinkerpop/pull/1556#discussion_r806383631
##
File path: gremlin-go/driver/protocol.go
##
@@ -0,0 +1,127 @@
+/*
+Licensed to the Apache Software Foundation (ASF) under one
+or more contributor license agreements. See the NOTICE file
+distributed with this work for additional information
+regarding copyright ownership. The ASF licenses this file
+to you under the Apache License, Version 2.0 (the
+"License"); you may not use this file except in compliance
+with the License. You may obtain a copy of the License at
+
+http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing,
+software distributed under the License is distributed on an
+"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+KIND, either express or implied. See the License for the
+specific language governing permissions and limitations
+under the License.
+*/
+
+package gremlingo
+
+import (
+ "errors"
+ "fmt"
+ "net/http"
+)
+
+type protocol interface {
+ connectionMade(transport transporter)
+ read(resultSets map[string]ResultSet) (string, error)
+ write(request *request, results map[string]ResultSet) (string, error)
+}
+
+type protocolBase struct {
+ protocol
+
+ transporter transporter
+}
+
+type gremlinServerWSProtocol struct {
+ *protocolBase
+
+ serializer serializer
+ logHandler *logHandler
+ maxContentLength int
+ username string
+ password string
+}
+
+func (protocol *protocolBase) connectionMade(transporter transporter) {
+ protocol.transporter = transporter
+}
+
+func (protocol *gremlinServerWSProtocol) read(resultSets map[string]ResultSet)
(string, error) {
+ // Read data from transport layer.
+ msg, err := protocol.transporter.Read()
+ if err != nil || msg == nil {
+ if err != nil {
+ return "", err
+ }
+ protocol.logHandler.log(Error, malformedURL)
+ return "", errors.New("malformed ws or wss URL")
+ }
+ // Deserialize message and unpack.
+ response, err := protocol.serializer.deserializeMessage(msg)
+ if err != nil {
+ return "", err
+ }
+
+ responseID, statusCode, metadata, data := response.responseID,
response.responseStatus.code,
+ response.responseResult.meta, response.responseResult.data
+
+ resultSet := resultSets[responseID.String()]
+ if resultSet == nil {
+ resultSet = newChannelResultSet(responseID.String())
+ }
+ resultSets[responseID.String()] = resultSet
+ if aggregateTo, ok := metadata["aggregateTo"]; ok {
+ resultSet.setAggregateTo(aggregateTo.(string))
+ }
+
+ // Handle status codes appropriately. If status code is
http.StatusPartialContent, we need to re-read data.
+ if statusCode == http.StatusProxyAuthRequired {
Review comment:
Done as a part of MS2.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [tinkerpop] simonz-bq commented on a change in pull request #1556: Milestone 1 of the gremlin-go driver
simonz-bq commented on a change in pull request #1556:
URL: https://github.com/apache/tinkerpop/pull/1556#discussion_r806383412
##
File path: gremlin-go/driver/protocol.go
##
@@ -0,0 +1,127 @@
+/*
+Licensed to the Apache Software Foundation (ASF) under one
+or more contributor license agreements. See the NOTICE file
+distributed with this work for additional information
+regarding copyright ownership. The ASF licenses this file
+to you under the Apache License, Version 2.0 (the
+"License"); you may not use this file except in compliance
+with the License. You may obtain a copy of the License at
+
+http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing,
+software distributed under the License is distributed on an
+"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+KIND, either express or implied. See the License for the
+specific language governing permissions and limitations
+under the License.
+*/
+
+package gremlingo
+
+import (
+ "errors"
+ "fmt"
+ "net/http"
+)
+
+type protocol interface {
Review comment:
Documentation added - more detailed explanation cannot live here however.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [tinkerpop] simonz-bq commented on a change in pull request #1556: Milestone 1 of the gremlin-go driver
simonz-bq commented on a change in pull request #1556:
URL: https://github.com/apache/tinkerpop/pull/1556#discussion_r806377167
##
File path: gremlin-go/driver/connection.go
##
@@ -0,0 +1,68 @@
+/*
+Licensed to the Apache Software Foundation (ASF) under one
+or more contributor license agreements. See the NOTICE file
+distributed with this work for additional information
+regarding copyright ownership. The ASF licenses this file
+to you under the Apache License, Version 2.0 (the
+"License"); you may not use this file except in compliance
+with the License. You may obtain a copy of the License at
+
+http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing,
+software distributed under the License is distributed on an
+"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+KIND, either express or implied. See the License for the
+specific language governing permissions and limitations
+under the License.
+*/
+
+package gremlingo
+
+type connection struct {
+ hoststring
+ portint
+ transporterType TransporterType
+ logHandler *logHandler
+ transporter transporter
+ protocolprotocol
+ results map[string]ResultSet
+}
+
+func (connection *connection) close() (err error) {
+ if connection.transporter != nil {
+ err = connection.transporter.Close()
+ }
+ return
+}
+
+func (connection *connection) connect() error {
+ if connection.transporter != nil {
+ closeErr := connection.transporter.Close()
+ connection.logHandler.logf(Warning, transportCloseFailed,
closeErr)
+ }
+ connection.protocol = newGremlinServerWSProtocol(connection.logHandler)
+ connection.transporter = getTransportLayer(connection.transporterType,
connection.host, connection.port)
+ err := connection.transporter.Connect()
+ if err != nil {
+ return err
+ }
+ connection.protocol.connectionMade(connection.transporter)
+ return nil
+}
+
+func (connection *connection) write(request *request) (ResultSet, error) {
+ if connection.transporter == nil || connection.transporter.IsClosed() {
+ err := connection.connect()
Review comment:
The proper logic for this method is updated as a part of MS2.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [tinkerpop] simonz-bq commented on a change in pull request #1556: Milestone 1 of the gremlin-go driver
simonz-bq commented on a change in pull request #1556:
URL: https://github.com/apache/tinkerpop/pull/1556#discussion_r806376918
##
File path: gremlin-go/driver/connection.go
##
@@ -0,0 +1,68 @@
+/*
+Licensed to the Apache Software Foundation (ASF) under one
+or more contributor license agreements. See the NOTICE file
+distributed with this work for additional information
+regarding copyright ownership. The ASF licenses this file
+to you under the Apache License, Version 2.0 (the
+"License"); you may not use this file except in compliance
+with the License. You may obtain a copy of the License at
+
+http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing,
+software distributed under the License is distributed on an
+"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+KIND, either express or implied. See the License for the
+specific language governing permissions and limitations
+under the License.
+*/
+
+package gremlingo
+
+type connection struct {
Review comment:
Added as a part of MS2
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[tinkerpop] 02/02: Fixing links in docs CTR
This is an automated email from the ASF dual-hosted git repository. spmallette pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/tinkerpop.git commit 686ec33d9a710ced95072837ae1414cb8e892cd8 Author: Stephen Mallette AuthorDate: Mon Feb 14 17:23:59 2022 -0500 Fixing links in docs CTR --- docs/src/dev/future/index.asciidoc | 2 +- docs/src/dev/provider/policies.asciidoc | 6 +++--- docs/src/recipes/index.asciidoc | 2 +- 3 files changed, 5 insertions(+), 5 deletions(-) diff --git a/docs/src/dev/future/index.asciidoc b/docs/src/dev/future/index.asciidoc index 7efc06b..60541fe 100644 --- a/docs/src/dev/future/index.asciidoc +++ b/docs/src/dev/future/index.asciidoc @@ -45,7 +45,7 @@ Development has not yet started on the 3.7.x release line with a targeted releas major feature improvements targeted for this release. The scope for many of these items still needs to be defined. * Add support for traversals as parameters for `V()`, `is()`, and `has()` -* Geospatial support for TinkerPop (link:https://lists.apache.org/list?d...@tinkerpop.apache.org:2021-7:DISCUSS%20geo-spatial[DISCUSS Thread]) +* Geospatial support for TinkerPop (link:++https://lists.apache.org/list?d...@tinkerpop.apache.org:2021-7:DISCUSS%20geo-spatial++[DISCUSS Thread]) * Add mid-traversal `E()` support * Add `with()` option for traversal to not return reference vertices * Add subgraph/tree structure in all GLVs diff --git a/docs/src/dev/provider/policies.asciidoc b/docs/src/dev/provider/policies.asciidoc index f1c6f1f..52a38bb 100644 --- a/docs/src/dev/provider/policies.asciidoc +++ b/docs/src/dev/provider/policies.asciidoc @@ -40,7 +40,7 @@ its version compatibility requirements. Note that the Apache Software Foundation's link:https://www.apache.org/foundation/marks/linking[linking policy] supersede those stipulated by Apache TinkerPop. All things considered, if your project meets the requirements, please -email Apache TinkerPop's link:+++https://lists.apache.org/list.html?d...@tinkerpop.apache.org+++[developer mailing list] +email Apache TinkerPop's link:++https://lists.apache.org/list.html?d...@tinkerpop.apache.org++[developer mailing list] requesting that your project be added to a listing. [[policy-graphics]] @@ -48,7 +48,7 @@ requesting that your project be added to a listing. Apache TinkerPop has a plethora of graphics that the community can use. There are four categories of graphics. These categories and their respective policies are presented below. If you are unsure of the category of a particular -graphic, please ask on our link:+++https://lists.apache.org/list.html?d...@tinkerpop.apache.org+++[developer mailing list] +graphic, please ask on our link:++https://lists.apache.org/list.html?d...@tinkerpop.apache.org++[developer mailing list] before using it. Finally, note that the Apache Software Foundation's link:https://www.apache.org/foundation/marks/[trademark policies] supersede those stipulated by Apache TinkerPop. @@ -84,7 +84,7 @@ being used for technical explanatory purposes. === Character Scene Graphics Character scene graphics require permission before being used. Please ask for permission on the Apache TinkerPop -link:+++https://lists.apache.org/list.html?d...@tinkerpop.apache.org+++[developer mailing list]. +link:++https://lists.apache.org/list.html?d...@tinkerpop.apache.org++[developer mailing list]. [width="100%",cols="1,1,1",frame=none] |= diff --git a/docs/src/recipes/index.asciidoc b/docs/src/recipes/index.asciidoc index 6d913c9..5e6556a 100644 --- a/docs/src/recipes/index.asciidoc +++ b/docs/src/recipes/index.asciidoc @@ -92,7 +92,7 @@ link:https://tinkerpop.apache.org/docs/x.y.z/dev/developer/#docker-integration[D changes are complete, submit a pull request for review by TinkerPop committers. NOTE: Please review existing recipes and attempt to conform to their writing and visual style. It may also be a good -idea to discuss ideas for a recipe on the link:+++https://lists.apache.org/list.html?d...@tinkerpop.apache.org+++[developer mailing list] +idea to discuss ideas for a recipe on the link:++https://lists.apache.org/list.html?d...@tinkerpop.apache.org++[developer mailing list] prior to starting work on it, as the community might provide insight on the approach and idea that would be helpful. It is preferable that a link:https://issues.apache.org/jira/browse/TINKERPOP[JIRA issue] be opened that describes the nature of the recipe so that the eventual pull request can be bound to that issue.
[tinkerpop] branch master updated (149c832 -> 686ec33)
This is an automated email from the ASF dual-hosted git repository. spmallette pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/tinkerpop.git. from 149c832 Fixed changelog formatting CTR add 616bc96 docs: Fix GraphBinary Path type spec typo add ad68f12 Merge pull request #1566 from ihoro/fix-graphbinary-path-type-spec new 83c1327 Merge remote-tracking branch 'origin/3.5-dev' new 686ec33 Fixing links in docs CTR The 2 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: docs/src/dev/future/index.asciidoc | 2 +- docs/src/dev/io/graphbinary.asciidoc| 4 ++-- docs/src/dev/provider/policies.asciidoc | 6 +++--- docs/src/recipes/index.asciidoc | 2 +- 4 files changed, 7 insertions(+), 7 deletions(-)
[tinkerpop] 01/02: Merge remote-tracking branch 'origin/3.5-dev'
This is an automated email from the ASF dual-hosted git repository. spmallette pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/tinkerpop.git commit 83c1327f1335503e8ce95a1bd5ef1ce6caf05172 Merge: 149c832 ad68f12 Author: Stephen Mallette AuthorDate: Mon Feb 14 17:23:39 2022 -0500 Merge remote-tracking branch 'origin/3.5-dev' docs/src/dev/io/graphbinary.asciidoc | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
[tinkerpop] branch 3.5-dev updated: docs: Fix GraphBinary Path type spec typo
This is an automated email from the ASF dual-hosted git repository.
jorgebg pushed a commit to branch 3.5-dev
in repository https://gitbox.apache.org/repos/asf/tinkerpop.git
The following commit(s) were added to refs/heads/3.5-dev by this push:
new 616bc96 docs: Fix GraphBinary Path type spec typo
new ad68f12 Merge pull request #1566 from
ihoro/fix-graphbinary-path-type-spec
616bc96 is described below
commit 616bc962f2199f7757ff23876b0ac94b34e2b0c3
Author: Igor Ostapenko
AuthorDate: Fri Feb 11 22:32:19 2022 +0200
docs: Fix GraphBinary Path type spec typo
Mentioned List and Set are expected to be fully qualified according to the
actual behaviour of gremlin-server.
---
docs/src/dev/io/graphbinary.asciidoc | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/docs/src/dev/io/graphbinary.asciidoc
b/docs/src/dev/io/graphbinary.asciidoc
index 9403857..d6669fd 100644
--- a/docs/src/dev/io/graphbinary.asciidoc
+++ b/docs/src/dev/io/graphbinary.asciidoc
@@ -279,8 +279,8 @@ Format: `{labels}{objects}`
Where:
-- `{labels}` is a `List` in which each item is a `Set` of `String`.
-- `{objects}` is a `List` of fully qualified typed values.
+- `{labels}` is a fully qualified `List` in which each item is a fully
qualified `Set` of `String`.
+- `{objects}` is a fully qualified `List` of fully qualified typed values.
Property
[GitHub] [tinkerpop] jorgebay merged pull request #1566: docs: Fix GraphBinary Path type spec typo
jorgebay merged pull request #1566: URL: https://github.com/apache/tinkerpop/pull/1566 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@tinkerpop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
