[GitHub] [tinkerpop] jorgebay merged pull request #1675: Upgrade docs for gremlin-javascript GraphBinary support
jorgebay merged PR #1675: URL: https://github.com/apache/tinkerpop/pull/1675 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@tinkerpop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[tinkerpop] branch 3.5-dev updated: Upgrade docs for gremlin-javascript GraphBinary support (#1675)
This is an automated email from the ASF dual-hosted git repository.
jorgebg pushed a commit to branch 3.5-dev
in repository https://gitbox.apache.org/repos/asf/tinkerpop.git
The following commit(s) were added to refs/heads/3.5-dev by this push:
new 38a3bd76e3 Upgrade docs for gremlin-javascript GraphBinary support
(#1675)
38a3bd76e3 is described below
commit 38a3bd76e35a83fbb56e157f4874633920f436b5
Author: Jorge Bay-Gondra
AuthorDate: Fri Jun 3 09:19:28 2022 +0200
Upgrade docs for gremlin-javascript GraphBinary support (#1675)
---
CHANGELOG.asciidoc | 1 +
docs/src/upgrade/release-3.5.x.asciidoc | 21 +
2 files changed, 22 insertions(+)
diff --git a/CHANGELOG.asciidoc b/CHANGELOG.asciidoc
index d83bd89e00..19cd1c2ad0 100644
--- a/CHANGELOG.asciidoc
+++ b/CHANGELOG.asciidoc
@@ -26,6 +26,7 @@
image::https://raw.githubusercontent.com/apache/tinkerpop/master/docs/static/ima
* Allowed `datetime()` syntax to accept zone offset with colon separators and
seconds.
* Fixed a minor problem in the Gremlin parser where a `GraphTraversalSource`
may not have been initialized.
* Added getters to high and low properties in RangeLocalStep.
+* TINKERPOP-2229 Added GraphBinary serialization support to gremlin-javascript.
[[release-3-5-3]]
=== TinkerPop 3.5.3 (Release Date: April 4, 2022)
diff --git a/docs/src/upgrade/release-3.5.x.asciidoc
b/docs/src/upgrade/release-3.5.x.asciidoc
index 852e59e42a..8ded2be6cd 100644
--- a/docs/src/upgrade/release-3.5.x.asciidoc
+++ b/docs/src/upgrade/release-3.5.x.asciidoc
@@ -21,6 +21,27 @@
image::https://raw.githubusercontent.com/apache/tinkerpop/master/docs/static/ima
*The Sleeping Gremlin: No. 18 Entr'acte Symphonique*
+== TinkerPop 3.5.4
+
+*Release Date: NOT OFFICIALLY RELEASED YET*
+
+Please see the
link:https://github.com/apache/tinkerpop/blob/3.5-dev/CHANGELOG.asciidoc#release-3-5-4[changelog]
for a
+complete list of all the modifications that are part of this release.
+
+=== Upgrading for Users
+
+ GraphBinary support for gremlin-javascript
+
+Gremlin JavaScript now also supports GraphBinary. GraphSON3 still remains the
default serialization format.
+
+To enable GraphBinary support, set the mime type in the connection options.
+
+[source,javascript]
+
+const options = { mimeType: 'application/vnd.graphbinary-v1.0' }
+const g = traversal().withRemote(new
DriverRemoteConnection('ws://localhost:8182/gremlin', options));
+
+
== TinkerPop 3.5.3
*Release Date: April 4, 2022*
[tinkerpop] branch 3.6-dev updated (8e7a798fb5 -> 32d2fda049)
This is an automated email from the ASF dual-hosted git repository. jorgebg pushed a change to branch 3.6-dev in repository https://gitbox.apache.org/repos/asf/tinkerpop.git from 8e7a798fb5 Fixed docker -d option add 38a3bd76e3 Upgrade docs for gremlin-javascript GraphBinary support (#1675) new 32d2fda049 Merge branch '3.5-dev' into 3.6-dev The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: CHANGELOG.asciidoc | 1 + docs/src/upgrade/release-3.5.x.asciidoc | 21 + 2 files changed, 22 insertions(+)
[tinkerpop] 01/01: Merge branch '3.5-dev' into 3.6-dev
This is an automated email from the ASF dual-hosted git repository. jorgebg pushed a commit to branch 3.6-dev in repository https://gitbox.apache.org/repos/asf/tinkerpop.git commit 32d2fda0490d7bffb97542b773fbab6ac96ec585 Merge: 8e7a798fb5 38a3bd76e3 Author: Jorge Bay AuthorDate: Fri Jun 3 09:22:53 2022 +0200 Merge branch '3.5-dev' into 3.6-dev CHANGELOG.asciidoc | 1 + docs/src/upgrade/release-3.5.x.asciidoc | 21 + 2 files changed, 22 insertions(+)
[tinkerpop] 01/01: Merge branch '3.6-dev'
This is an automated email from the ASF dual-hosted git repository. jorgebg pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/tinkerpop.git commit 42cefe106a3375aab497cbfc477178fa83d08325 Merge: 179678ab7d 32d2fda049 Author: Jorge Bay AuthorDate: Fri Jun 3 09:23:30 2022 +0200 Merge branch '3.6-dev' CHANGELOG.asciidoc | 1 + docs/src/upgrade/release-3.5.x.asciidoc | 21 + 2 files changed, 22 insertions(+)
[tinkerpop] branch master updated (179678ab7d -> 42cefe106a)
This is an automated email from the ASF dual-hosted git repository. jorgebg pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/tinkerpop.git from 179678ab7d Merge branch '3.6-dev' add 38a3bd76e3 Upgrade docs for gremlin-javascript GraphBinary support (#1675) add 32d2fda049 Merge branch '3.5-dev' into 3.6-dev new 42cefe106a Merge branch '3.6-dev' The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: CHANGELOG.asciidoc | 1 + docs/src/upgrade/release-3.5.x.asciidoc | 21 + 2 files changed, 22 insertions(+)
[GitHub] [tinkerpop] FlorianHockmann commented on a diff in pull request #1671: TINKERPOP-2749: Gremlin Javascript, Gremlint Windows build error fixes
FlorianHockmann commented on code in PR #1671:
URL: https://github.com/apache/tinkerpop/pull/1671#discussion_r888781587
##
gremlin-javascript/src/main/javascript/gremlin-javascript/.eslintrc.js:
##
@@ -31,9 +31,9 @@ module.exports = {
extends: ['eslint:recommended', 'prettier'],
plugins: ['prettier'],
rules: {
-'prettier/prettier': ['error'],
Review Comment:
The changes in this file allow line endings to be `CRLF`, right? Is that
really necessary? I guess we'd prefer if only Unix style line endings were
committed, but maybe I'm missing something here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [tinkerpop] dependabot[bot] opened a new pull request, #1678: Bump mockito-core from 3.3.3 to 4.6.1
dependabot[bot] opened a new pull request, #1678: URL: https://github.com/apache/tinkerpop/pull/1678 Bumps [mockito-core](https://github.com/mockito/mockito) from 3.3.3 to 4.6.1. Release notes Sourced from https://github.com/mockito/mockito/releases";>mockito-core's releases. v4.6.1 Changelog generated by https://github.com/shipkit/shipkit-changelog";>Shipkit Changelog Gradle Plugin 4.6.1 2022-06-02 - https://github.com/mockito/mockito/compare/v4.6.0...v4.6.1";>6 commit(s) by Andy Coates, Chen Ni, dependabot[bot] Bump material from 1.6.0 to 1.6.1 [(https://github-redirect.dependabot.com/mockito/mockito/issues/2662";>#2662)](https://github-redirect.dependabot.com/mockito/mockito/pull/2662";>mockito/mockito#2662) Bump core-ktx from 1.7.0 to 1.8.0 [(https://github-redirect.dependabot.com/mockito/mockito/issues/2661";>#2661)](https://github-redirect.dependabot.com/mockito/mockito/pull/2661";>mockito/mockito#2661) Bump groovy from 3.0.10 to 3.0.11 [(https://github-redirect.dependabot.com/mockito/mockito/issues/2660";>#2660)](https://github-redirect.dependabot.com/mockito/mockito/pull/2660";>mockito/mockito#2660) Fix for Issue2656 [(https://github-redirect.dependabot.com/mockito/mockito/issues/2659";>#2659)](https://github-redirect.dependabot.com/mockito/mockito/pull/2659";>mockito/mockito#2659) Bump assertj-core from 3.22.0 to 3.23.1 [(https://github-redirect.dependabot.com/mockito/mockito/issues/2658";>#2658)](https://github-redirect.dependabot.com/mockito/mockito/pull/2658";>mockito/mockito#2658) Regression? Strictness set in @MockitoSettings ignored after upgrade from 4.5.1 to 4.6.0 [(https://github-redirect.dependabot.com/mockito/mockito/issues/2656";>#2656)](https://github-redirect.dependabot.com/mockito/mockito/issues/2656";>mockito/mockito#2656) Fix typo [(https://github-redirect.dependabot.com/mockito/mockito/issues/2655";>#2655)](https://github-redirect.dependabot.com/mockito/mockito/pull/2655";>mockito/mockito#2655) v4.6.0 Changelog generated by https://github.com/shipkit/shipkit-changelog";>Shipkit Changelog Gradle Plugin 4.6.0 2022-05-27 - https://github.com/mockito/mockito/compare/v4.5.1...v4.6.0";>14 commit(s) by Hervé Boutemy, K. Siva Prasad Reddy, Rafael Winterhalter, dependabot[bot] Bump shipkit-changelog from 1.1.15 to 1.2.0 [(https://github-redirect.dependabot.com/mockito/mockito/issues/2654";>#2654)](https://github-redirect.dependabot.com/mockito/mockito/pull/2654";>mockito/mockito#2654) Bump versions.errorprone from 2.13.1 to 2.14.0 [(https://github-redirect.dependabot.com/mockito/mockito/issues/2653";>#2653)](https://github-redirect.dependabot.com/mockito/mockito/pull/2653";>mockito/mockito#2653) Bump shipkit-auto-version from 1.1.20 to 1.2.0 [(https://github-redirect.dependabot.com/mockito/mockito/issues/2651";>#2651)](https://github-redirect.dependabot.com/mockito/mockito/pull/2651";>mockito/mockito#2651) Fixes https://github-redirect.dependabot.com/mockito/mockito/issues/2648";>#2648 : Add support for customising strictness via https://github.com/Mock";>@Mock annotation and MockSettings [(https://github-redirect.dependabot.com/mockito/mockito/issues/2650";>#2650)](https://github-redirect.dependabot.com/mockito/mockito/pull/2650";>mockito/mockito#2650) Any way to enable Strict Stubbing when using Mockito.mock() without using https://github.com/Mock";>@Mock? [(https://github-redirect.dependabot.com/mockito/mockito/issues/2648";>#2648)](https://github-redirect.dependabot.com/mockito/mockito/issues/2648";>mockito/mockito#2648) Reintroduce inheriting type annotations from interfaces if only one interface is mocked, including additional interfaces. [(https://github-redirect.dependabot.com/mockito/mockito/issues/2645";>#2645)](https://github-redirect.dependabot.com/mockito/mockito/pull/2645";>mockito/mockito#2645) Bump com.diffplug.spotless from 6.6.0 to 6.6.1 [(https://github-redirect.dependabot.com/mockito/mockito/issues/2643";>#2643)](https://github-redirect.dependabot.com/mockito/mockito/pull/2643";>mockito/mockito#2643) fix Reproducible Build issue [(https://github-redirect.dependabot.com/mockito/mockito/issues/2642";>#2642)](https://github-redirect.dependabot.com/mockito/mockito/pull/2642";>mockito/mockito#2642) Bump com.diffplug.spotless from 6.5.2 to 6.6.0 [(https://github-redirect.dependabot.com/mockito/mockito/issues/2641";>#2641)](https://github-redirect.dependabot.com/mockito/mockito/pull/2641";>mockito/mockito#2641) Mockito mock of interfaces lost annotation information [(https://github-redirect.dependabot.com/mockito/mockito/issues/2640";>#2640)](https://github-redirect.dependabot.com/mockito/mockito/issues/2640";>mockito/mockito#2640) Bump material from 1.5.0 to 1.6.0 [(https://github-redirect.dependabot.com/mockito/mockito/issues/2637";>#2637)](https://github-redirect.dependabot.com/mockito/mockito/pull/2637";>mockito/mockito#2637) Bump com.diffplug.sp
[GitHub] [tinkerpop] dependabot[bot] commented on pull request #1673: Bump mockito-core from 3.3.3 to 4.6.0
dependabot[bot] commented on PR #1673: URL: https://github.com/apache/tinkerpop/pull/1673#issuecomment-1146038686 Superseded by #1678. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@tinkerpop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [tinkerpop] dependabot[bot] closed pull request #1673: Bump mockito-core from 3.3.3 to 4.6.0
dependabot[bot] closed pull request #1673: Bump mockito-core from 3.3.3 to 4.6.0 URL: https://github.com/apache/tinkerpop/pull/1673 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@tinkerpop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[tinkerpop] branch dependabot/maven/3.5-dev/org.mockito-mockito-core-4.6.1 created (now 88091de9ce)
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch dependabot/maven/3.5-dev/org.mockito-mockito-core-4.6.1 in repository https://gitbox.apache.org/repos/asf/tinkerpop.git at 88091de9ce Bump mockito-core from 3.3.3 to 4.6.1 No new revisions were added by this update.
[GitHub] [tinkerpop] L0Lmaker opened a new pull request, #1679: Hadoop Gremlin Windows Build Fixes
L0Lmaker opened a new pull request, #1679: URL: https://github.com/apache/tinkerpop/pull/1679 This change adds to the note of the Windows Build in `development-environment.asciidoc` to include details on making the local build of Hadoop Gremlin work as expected on Windows. Issue: [TINKERPOP-2749](https://issues.apache.org/jira/browse/TINKERPOP-2749) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@tinkerpop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [tinkerpop] lyndonbauto commented on pull request #1677: Finish graphbinary support in gremlin-python
lyndonbauto commented on PR #1677: URL: https://github.com/apache/tinkerpop/pull/1677#issuecomment-1146213418 I am going to hold off reviewing this until #1676 is merged. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@tinkerpop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [tinkerpop] lyndonbauto commented on a diff in pull request #1676: Finish graphbinary support in gremlin-python
lyndonbauto commented on code in PR #1676: URL: https://github.com/apache/tinkerpop/pull/1676#discussion_r889198146 ## gremlin-python/src/main/python/gremlin_python/driver/driver_remote_connection.py: ## @@ -59,7 +59,7 @@ def __init__(self, url, traversal_source="g", protocol_factory=None, # so that they can be closed if this parent session is closed. self.__spawned_sessions = [] -if message_serializer is None: +if message_serializer is None and graphson_reader is not None and graphson_writer is not None: Review Comment: Did you encounter a case where graphson_read/graphson_writer are None? Just wondering why this is required here but not in client.py -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@tinkerpop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [tinkerpop] lyndonbauto commented on a diff in pull request #1676: Finish graphbinary support in gremlin-python
lyndonbauto commented on code in PR #1676:
URL: https://github.com/apache/tinkerpop/pull/1676#discussion_r889201357
##
gremlin-python/src/main/python/gremlin_python/structure/io/graphbinaryV1.py:
##
@@ -255,15 +257,15 @@ class LongIO(_GraphBinaryTypeIO):
@classmethod
def dictify(cls, obj, writer, to_extend, as_value=False, nullable=True):
if obj < -9223372036854775808 or obj > 9223372036854775807:
-raise Exception("TODO: don't forget bigint")
+raise Exception("Value too big, please use bigint Gremlin type")
Review Comment:
Should we just promote the type to bigint here? That way we handle this
implictly and explicitly. Meaning you could do something like:
`g.V().property("bigint_explicit",
bigint(1)).property("bigint_implicit", 9223372036854775807 + 1)`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [tinkerpop] lyndonbauto commented on a diff in pull request #1676: Finish graphbinary support in gremlin-python
lyndonbauto commented on code in PR #1676: URL: https://github.com/apache/tinkerpop/pull/1676#discussion_r889202141 ## gremlin-python/src/main/python/tests/driver/test_client.py: ## @@ -27,10 +27,13 @@ from gremlin_python.process.strategies import OptionsStrategy from gremlin_python.structure.graph import Graph from gremlin_python.driver.aiohttp.transport import AiohttpTransport +from gremlin_python.statics import * Review Comment: best practice is to import specific items ```suggestion from gremlin_python.statics import bigint, long ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@tinkerpop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [tinkerpop] lyndonbauto commented on a diff in pull request #1676: Finish graphbinary support in gremlin-python
lyndonbauto commented on code in PR #1676: URL: https://github.com/apache/tinkerpop/pull/1676#discussion_r889202740 ## gremlin-python/src/main/python/tests/driver/test_client.py: ## @@ -27,10 +27,13 @@ from gremlin_python.process.strategies import OptionsStrategy from gremlin_python.structure.graph import Graph from gremlin_python.driver.aiohttp.transport import AiohttpTransport +from gremlin_python.statics import * Review Comment: I see the other test just imports * already. Perhaps we can ignore this comment since the other tests don't consider that. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@tinkerpop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [tinkerpop] lyndonbauto commented on pull request #1679: TINKERPOP-2749: Hadoop Gremlin Windows Build Note
lyndonbauto commented on PR #1679: URL: https://github.com/apache/tinkerpop/pull/1679#issuecomment-1146223772 VOTE+1 - more and more windows support coming from you @L0Lmaker. Thanks for the excellent work! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@tinkerpop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [tinkerpop] vkagamlyk commented on a diff in pull request #1676: Finish graphbinary support in gremlin-python
vkagamlyk commented on code in PR #1676:
URL: https://github.com/apache/tinkerpop/pull/1676#discussion_r889226039
##
gremlin-python/src/main/python/gremlin_python/structure/io/graphbinaryV1.py:
##
@@ -255,15 +257,15 @@ class LongIO(_GraphBinaryTypeIO):
@classmethod
def dictify(cls, obj, writer, to_extend, as_value=False, nullable=True):
if obj < -9223372036854775808 or obj > 9223372036854775807:
-raise Exception("TODO: don't forget bigint")
+raise Exception("Value too big, please use bigint Gremlin type")
Review Comment:
implicit conversion can introduce new issues, for example
`g.inject(1).repeat(__.addV('person').property('name',
__.loops())).times(9223372036854775807 + 1).count()`
leads to server exception
`[ERROR] TraversalOpProcessor - Could not deserialize the Traversal instance
java.lang.IllegalStateException: null: .times(BigInteger)`
if you think that this is not an issue, then I will add implicit conversion
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [tinkerpop] vkagamlyk commented on a diff in pull request #1676: Finish graphbinary support in gremlin-python
vkagamlyk commented on code in PR #1676: URL: https://github.com/apache/tinkerpop/pull/1676#discussion_r889228829 ## gremlin-python/src/main/python/gremlin_python/driver/driver_remote_connection.py: ## @@ -59,7 +59,7 @@ def __init__(self, url, traversal_source="g", protocol_factory=None, # so that they can be closed if this parent session is closed. self.__spawned_sessions = [] -if message_serializer is None: +if message_serializer is None and graphson_reader is not None and graphson_writer is not None: Review Comment: this code is related to setting default serializer -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@tinkerpop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [tinkerpop] lyndonbauto commented on a diff in pull request #1676: Finish graphbinary support in gremlin-python
lyndonbauto commented on code in PR #1676:
URL: https://github.com/apache/tinkerpop/pull/1676#discussion_r889235996
##
gremlin-python/src/main/python/gremlin_python/structure/io/graphbinaryV1.py:
##
@@ -255,15 +257,15 @@ class LongIO(_GraphBinaryTypeIO):
@classmethod
def dictify(cls, obj, writer, to_extend, as_value=False, nullable=True):
if obj < -9223372036854775808 or obj > 9223372036854775807:
-raise Exception("TODO: don't forget bigint")
+raise Exception("Value too big, please use bigint Gremlin type")
Review Comment:
Fair point. I am not sure myself I will tag some people who might know -
@krlawrence @spmallette any thoughts?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [tinkerpop] vkagamlyk commented on a diff in pull request #1676: Finish graphbinary support in gremlin-python
vkagamlyk commented on code in PR #1676: URL: https://github.com/apache/tinkerpop/pull/1676#discussion_r889240550 ## gremlin-python/src/main/python/gremlin_python/driver/driver_remote_connection.py: ## @@ -59,7 +59,7 @@ def __init__(self, url, traversal_source="g", protocol_factory=None, # so that they can be closed if this parent session is closed. self.__spawned_sessions = [] -if message_serializer is None: +if message_serializer is None and graphson_reader is not None and graphson_writer is not None: Review Comment: reverted in https://github.com/apache/tinkerpop/pull/1676/commits/ff4e16c18236af61491e680cbf810664aba38e56 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@tinkerpop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [tinkerpop] xiazcy opened a new pull request, #1680: TINKERPOP-2708: unhandledRejection upon connection failure
xiazcy opened a new pull request, #1680: URL: https://github.com/apache/tinkerpop/pull/1680 As suggested in https://issues.apache.org/jira/browse/TINKERPOP-2708, deprecated and removed the functionality of the connection option `connectOnStartup`. Since it is generally not good to return promises in constructors, removing the call to `open()` in the `Connection` constructor seemed to be the way to resolve unhandledRejection and any potential race conditions. There is a slight API behaviour change as a result. Setting `connectOnStartup` true now will log a deprecated warning to the user. The `Connection` constructor will no longer initiate connection in the background by default, so users will need to call `open()` explicitly after creating a connection object. However, open() is called anyways when connection submits traversals, removing this shouldn't affect any normal traversal functionality. As this may be considered a breaking change, I added a change-log entry, are there additional docs I should edit? As a side note, this is related to https://issues.apache.org/jira/browse/TINKERPOP-2381. I believe removing connectOnStartup functionality resolves the issues listed. I'm not sure if there is a need to refactor how Client invokes `connection.open()`, since inside `connection.open()`, it does check if it has been called previously. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@tinkerpop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [tinkerpop] L0Lmaker opened a new pull request, #1681: TINKERPOP-2749: Spark Gremlin Windows Build Error Fixes
L0Lmaker opened a new pull request, #1681: URL: https://github.com/apache/tinkerpop/pull/1681 Spark Build on Windows Causes Errors along the lines of: ``` [ERROR] Failures: [ERROR] org.apache.tinkerpop.gremlin.spark.structure.io.SparkIoRegistryCheck.shouldSupportGraphSONIoRegistry(org.apache.tinkerpop.gremlin.spark.structure.io.SparkIoRegistryCheck) [INFO] Run 1: PASS [ERROR] Run 2: SparkIoRegistryCheck.shouldSupportGraphSONIoRegistry:67->AbstractIoRegistryCheck.checkGraphSONIoRegistryCompliance:98 [INFO] [ERROR] org.apache.tinkerpop.gremlin.spark.structure.io.SparkIoRegistryCheck.shouldSupportGryoV1d0IoRegistry(org.apache.tinkerpop.gremlin.spark.structure.io.SparkIoRegistryCheck) [INFO] Run 1: PASS [ERROR] Run 2: SparkIoRegistryCheck.shouldSupportGryoV1d0IoRegistry:57->AbstractIoRegistryCheck.checkGryoV1d0IoRegistryCompliance:75 [INFO] [ERROR] org.apache.tinkerpop.gremlin.spark.structure.io.SparkIoRegistryCheck.shouldSupportGryoV3d0IoRegistry(org.apache.tinkerpop.gremlin.spark.structure.io.SparkIoRegistryCheck) [INFO] Run 1: PASS [ERROR] Run 2: SparkIoRegistryCheck.shouldSupportGryoV3d0IoRegistry:62->AbstractIoRegistryCheck.checkGryoV3d0IoRegistryCompliance:87 ``` These failures are caused by the usage of the `File.delete()` function calls to delete temp files generated during runtime. This operation fails on Windows as the file is still actively open in the process and on Windows, active files cannot be deleted until a all processes stop using it. `File.deleteOnExit()` deletes the file when the virtual machine terminates. Link to Issue: (https://issues.apache.org/jira/browse/TINKERPOP-2749)[TINKERPOP-2749] -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@tinkerpop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [tinkerpop] codecov-commenter commented on pull request #1681: TINKERPOP-2749: Spark Gremlin Windows Build Error Fixes
codecov-commenter commented on PR #1681: URL: https://github.com/apache/tinkerpop/pull/1681#issuecomment-1146381577 # [Codecov](https://codecov.io/gh/apache/tinkerpop/pull/1681?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report > Merging [#1681](https://codecov.io/gh/apache/tinkerpop/pull/1681?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (6689cbc) into [3.5-dev](https://codecov.io/gh/apache/tinkerpop/commit/18a1ed7e046c273f5d3b17aada731ed5619e3848?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (18a1ed7) will **not change** coverage. > The diff coverage is `n/a`. ```diff @@ Coverage Diff@@ ## 3.5-dev#1681 +/- ## Coverage63.35% 63.35% Files 23 23 Lines 3553 3553 Hits 2251 2251 Misses1129 1129 Partials 173 173 ``` -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/tinkerpop/pull/1681?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/tinkerpop/pull/1681?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [18a1ed7...6689cbc](https://codecov.io/gh/apache/tinkerpop/pull/1681?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@tinkerpop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [tinkerpop] L0Lmaker commented on a diff in pull request #1671: TINKERPOP-2749: Gremlin Javascript, Gremlint Windows build error fixes
L0Lmaker commented on code in PR #1671:
URL: https://github.com/apache/tinkerpop/pull/1671#discussion_r889376669
##
gremlin-javascript/src/main/javascript/gremlin-javascript/.eslintrc.js:
##
@@ -31,9 +31,9 @@ module.exports = {
extends: ['eslint:recommended', 'prettier'],
plugins: ['prettier'],
rules: {
-'prettier/prettier': ['error'],
Review Comment:
There are two ways we could resolve this. Either allow for `CRLF` formatted
files or convert the existing javascript files that use the `CRLF` format to
`LF`. The former felt like a simpler fix which is why I disabled the check for
line separators.
If we want to keep it only Unix style, we could go ahead with converting all
the JS files that are affected.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [tinkerpop] simonz-bq opened a new pull request, #1682: Specify ujson version of 2.0.0 or greater
simonz-bq opened a new pull request, #1682: URL: https://github.com/apache/tinkerpop/pull/1682 Fixes https://issues.apache.org/jira/browse/TINKERPOP-2631 Since ujson is an optional dependency, hard enforcing a version may cause problems for users. Instead, a version >= 2.0.0 is specified to be automatically resolved by the Python package manager if someone were to use install gremlin-python with ujson enabled. A warning is also given when using a version below 2.0.0 is detected. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@tinkerpop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
