[tinkerpop] branch TINKERPOP-2982 created (now 8d235ef1fa)
This is an automated email from the ASF dual-hosted git repository. spmallette pushed a change to branch TINKERPOP-2982 in repository https://gitbox.apache.org/repos/asf/tinkerpop.git at 8d235ef1fa TINKERPOP-2982 Allowed gremlin-driver to work over HTTP. This branch includes the following new commits: new 8d235ef1fa TINKERPOP-2982 Allowed gremlin-driver to work over HTTP. The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference.
[tinkerpop] 01/01: TINKERPOP-2982 Allowed gremlin-driver to work over HTTP.
This is an automated email from the ASF dual-hosted git repository.
spmallette pushed a commit to branch TINKERPOP-2982
in repository https://gitbox.apache.org/repos/asf/tinkerpop.git
commit 8d235ef1fada01779ce35ce5f584d3f30b2c5fec
Author: Stephen Mallette
AuthorDate: Tue Aug 15 10:48:32 2023 -0400
TINKERPOP-2982 Allowed gremlin-driver to work over HTTP.
HTTP is just an option. Websockets is still intact. There shouldn't be any
breaking changes here. While there were some server changes, compatibility
should be retained there...just added some extra parameters that were formerly
only needed with TraversalOpProcessor. g.tx() and sessions will not work with
this configuration.
---
CHANGELOG.asciidoc | 3 +-
.../tinkerpop/gremlin/driver/Channelizer.java | 91 +-
.../apache/tinkerpop/gremlin/driver/Cluster.java | 28 +++-
.../gremlin/driver/HandshakeInterceptor.java | 2 +
.../org/apache/tinkerpop/gremlin/driver/Host.java | 14 +-
.../gremlin/driver/MessageSerializer.java | 3 +-
...akeInterceptor.java => RequestInterceptor.java} | 12 +-
.../driver/handler/HttpGremlinRequestEncoder.java | 92 +++
.../driver/handler/HttpGremlinResponseDecoder.java | 51 ++
.../driver/handler/WebSocketClientHandler.java | 5 +-
.../gremlin/driver/message/RequestMessage.java | 8 +
.../driver/ser/GraphBinaryMessageSerializerV1.java | 10 +-
.../binary/GraphBinaryMessageSerializerV1Test.java | 27 +++
.../handler/HttpBasicAuthorizationHandler.java | 16 +-
.../server/handler/HttpGremlinEndpointHandler.java | 78 +
.../gremlin/server/handler/HttpHandlerUtil.java| 46 --
.../gremlin/server/GremlinDriverIntegrateTest.java | 33 +++-
.../gremlin/server/HttpDriverIntegrateTest.java| 183 +
18 files changed, 605 insertions(+), 97 deletions(-)
diff --git a/CHANGELOG.asciidoc b/CHANGELOG.asciidoc
index 54fabe2c3d..1f358e06ee 100644
--- a/CHANGELOG.asciidoc
+++ b/CHANGELOG.asciidoc
@@ -25,7 +25,8 @@
image::https://raw.githubusercontent.com/apache/tinkerpop/master/docs/static/ima
This release also includes changes from <>.
-
+* Allowed `gremlin-driver` to be used over HTTP.
+* Deprecated the `HandshakeInterceptor` in favor of a more generic
`RequestInterceptor`.
[[release-3-6-5]]
=== TinkerPop 3.6.5 (Release Date: July 31, 2023)
diff --git
a/gremlin-driver/src/main/java/org/apache/tinkerpop/gremlin/driver/Channelizer.java
b/gremlin-driver/src/main/java/org/apache/tinkerpop/gremlin/driver/Channelizer.java
index efe47c5977..4c87f7ec78 100644
---
a/gremlin-driver/src/main/java/org/apache/tinkerpop/gremlin/driver/Channelizer.java
+++
b/gremlin-driver/src/main/java/org/apache/tinkerpop/gremlin/driver/Channelizer.java
@@ -19,6 +19,8 @@
package org.apache.tinkerpop.gremlin.driver;
import org.apache.tinkerpop.gremlin.driver.exception.ConnectionException;
+import org.apache.tinkerpop.gremlin.driver.handler.HttpGremlinRequestEncoder;
+import org.apache.tinkerpop.gremlin.driver.handler.HttpGremlinResponseDecoder;
import org.apache.tinkerpop.gremlin.driver.handler.WebSocketClientHandler;
import
org.apache.tinkerpop.gremlin.driver.handler.WebSocketGremlinRequestEncoder;
import
org.apache.tinkerpop.gremlin.driver.handler.WebSocketGremlinResponseDecoder;
@@ -77,6 +79,13 @@ public interface Channelizer extends ChannelHandler {
public default void connected() {
}
+/**
+ * Gets the scheme to use to construct the URL and by default uses HTTP.
+ */
+public default String getScheme(final boolean sslEnabled) {
+return sslEnabled ? "https" : "http";
+}
+
/**
* Base implementation of the client side {@link Channelizer}.
*/
@@ -126,7 +135,7 @@ public interface Channelizer extends ChannelHandler {
}
if (sslCtx.isPresent()) {
-SslHandler sslHandler =
sslCtx.get().newHandler(socketChannel.alloc(), connection.getUri().getHost(),
connection.getUri().getPort());
+final SslHandler sslHandler =
sslCtx.get().newHandler(socketChannel.alloc(), connection.getUri().getHost(),
connection.getUri().getPort());
// TINKERPOP-2814. Remove the SSL handshake timeout so that
handshakes that take longer than 1ms
// (Netty default) but less than connectionSetupTimeoutMillis
can succeed. This means the SSL handshake
// will instead be capped by connectionSetupTimeoutMillis.
@@ -143,18 +152,18 @@ public interface Channelizer extends ChannelHandler {
/**
* WebSocket {@link Channelizer} implementation.
*/
-public final class WebSocketChannelizer extends AbstractChannelizer {
+final class WebSocketChannelizer extends AbstractChannelizer {
private static final Logger logger =
LoggerFactory.getLogger(WebSocketChannelizer.class);
private WebSocketClientHandler handler;
-pr
[GitHub] [tinkerpop] spmallette opened a new pull request, #2206: TINKERPOP-2982 Allowed gremlin-driver to work over HTTP.
spmallette opened a new pull request, #2206: URL: https://github.com/apache/tinkerpop/pull/2206 https://issues.apache.org/jira/browse/TINKERPOP-2982 HTTP is just an option of experimental nature for now. Websockets is still intact. There shouldn't be any breaking changes here. While there were some server changes, compatibility should be retained there...just added some extra parameters that were formerly only needed with TraversalOpProcessor. g.tx() and sessions will not work with this configuration. VOTE +1 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@tinkerpop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [tinkerpop] codecov-commenter commented on pull request #2206: TINKERPOP-2982 Allowed gremlin-driver to work over HTTP.
codecov-commenter commented on PR #2206: URL: https://github.com/apache/tinkerpop/pull/2206#issuecomment-1679164405 ## [Codecov](https://app.codecov.io/gh/apache/tinkerpop/pull/2206?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report > Merging [#2206](https://app.codecov.io/gh/apache/tinkerpop/pull/2206?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (8d235ef) into [3.6-dev](https://app.codecov.io/gh/apache/tinkerpop/commit/ec4e23a63dec508c6f8c810226e0d2a06c5596c9?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (ec4e23a) will **decrease** coverage by `4.93%`. > The diff coverage is `n/a`. ```diff @@ Coverage Diff @@ ## 3.6-dev#2206 +/- ## = - Coverage 75.17% 70.24% -4.93% = Files 1050 24-1026 Lines 62917 3492 -59425 Branches69000-6900 = - Hits 47296 2453 -44843 + Misses 13084 873 -12211 + Partials2537 166-2371 ``` [see 1026 files with indirect coverage changes](https://app.codecov.io/gh/apache/tinkerpop/pull/2206/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) :mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@tinkerpop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [tinkerpop] phanindhra876 commented on a diff in pull request #2206: TINKERPOP-2982 Allowed gremlin-driver to work over HTTP.
phanindhra876 commented on code in PR #2206:
URL: https://github.com/apache/tinkerpop/pull/2206#discussion_r1294927103
##
gremlin-driver/src/main/java/org/apache/tinkerpop/gremlin/driver/handler/HttpGremlinResponseDecoder.java:
##
@@ -0,0 +1,51 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.tinkerpop.gremlin.driver.handler;
+
+import io.netty.channel.ChannelHandler;
+import io.netty.channel.ChannelHandlerContext;
+import io.netty.handler.codec.MessageToMessageDecoder;
+import io.netty.handler.codec.http.FullHttpResponse;
+import io.netty.handler.codec.http.websocketx.BinaryWebSocketFrame;
+import io.netty.handler.codec.http.websocketx.TextWebSocketFrame;
+import io.netty.handler.codec.http.websocketx.WebSocketFrame;
+import io.netty.util.CharsetUtil;
+import org.apache.tinkerpop.gremlin.driver.MessageSerializer;
+import org.apache.tinkerpop.gremlin.driver.message.ResponseMessage;
+import org.apache.tinkerpop.gremlin.driver.ser.MessageTextSerializer;
+
+import java.util.List;
+
+/**
+ * Converts {@code HttpResponse} to a {@link ResponseMessage}.
+ */
+@ChannelHandler.Sharable
+public final class HttpGremlinResponseDecoder extends
MessageToMessageDecoder {
+private final MessageSerializer serializer;
+
+public HttpGremlinResponseDecoder(final MessageSerializer serializer) {
+this.serializer = serializer;
+}
+
+@Override
+protected void decode(final ChannelHandlerContext channelHandlerContext,
final FullHttpResponse httpResponse, final List objects) throws
Exception {
+final String content =
httpResponse.content().toString(CharsetUtil.UTF_8);
+objects.add(((MessageTextSerializer)
serializer).deserializeResponse(content));
Review Comment:
Wont this throw error if serializer is a non-text serializer?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [tinkerpop] phanindhra876 commented on a diff in pull request #2206: TINKERPOP-2982 Allowed gremlin-driver to work over HTTP.
phanindhra876 commented on code in PR #2206:
URL: https://github.com/apache/tinkerpop/pull/2206#discussion_r1294930598
##
gremlin-server/src/main/java/org/apache/tinkerpop/gremlin/server/handler/HttpGremlinEndpointHandler.java:
##
@@ -147,40 +136,43 @@ public void channelRead(final ChannelHandlerContext ctx,
final Object msg) {
return;
}
-final Quartet, String, Map> requestArguments;
+final RequestMessage requestMessage;
try {
-requestArguments = HttpHandlerUtil.getRequestArguments(req);
+requestMessage =
HttpHandlerUtil.getRequestMessageFromHttpRequest(req);
} catch (IllegalArgumentException iae) {
HttpHandlerUtil.sendError(ctx, BAD_REQUEST, iae.getMessage(),
keepAlive);
ReferenceCountUtil.release(msg);
return;
}
-final String acceptString =
Optional.ofNullable(req.headers().get("Accept")).orElse("application/json");
-final Pair> serializer =
chooseSerializer(acceptString);
+final String acceptMime =
Optional.ofNullable(req.headers().get(HttpHeaderNames.ACCEPT)).orElse("application/json");
+final Pair> serializer =
chooseSerializer(acceptMime);
Review Comment:
This is not exactly related to PR. However, shouldn't we need to drop the
assumption that HTTP server can support only `MessageTextSerializer`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [tinkerpop] lvca commented on pull request #2167: Bump io.netty:netty-all from 4.1.86.Final to 4.1.96.Final
lvca commented on PR #2167: URL: https://github.com/apache/tinkerpop/pull/2167#issuecomment-1679420514 How long to get this merged? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@tinkerpop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [tinkerpop] codecov-commenter commented on pull request #2205: Implement asString(), length(), toLower(), and toUpper() String Functions
codecov-commenter commented on PR #2205: URL: https://github.com/apache/tinkerpop/pull/2205#issuecomment-1679430628 ## [Codecov](https://app.codecov.io/gh/apache/tinkerpop/pull/2205?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report > Merging [#2205](https://app.codecov.io/gh/apache/tinkerpop/pull/2205?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (d3577b7) into [master](https://app.codecov.io/gh/apache/tinkerpop/commit/a68b404f93c4b53cb102986b39115fe0ab54d94e?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (a68b404) will **decrease** coverage by `5.47%`. > The diff coverage is `60.00%`. ```diff @@ Coverage Diff @@ ## master#2205 +/- ## - Coverage 75.78% 70.31% -5.47% Files 1039 24-1015 Lines 63502 3561 -59941 Branches 70440-7044 - Hits 48123 2504 -45619 + Misses12763 887 -11876 + Partials 2616 170-2446 ``` | [Files Changed](https://app.codecov.io/gh/apache/tinkerpop/pull/2205?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [gremlin-go/driver/anonymousTraversal.go](https://app.codecov.io/gh/apache/tinkerpop/pull/2205?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Z3JlbWxpbi1nby9kcml2ZXIvYW5vbnltb3VzVHJhdmVyc2FsLmdv) | `44.30% <0.00%> (-1.55%)` | :arrow_down: | | [gremlin-go/driver/graphTraversal.go](https://app.codecov.io/gh/apache/tinkerpop/pull/2205?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Z3JlbWxpbi1nby9kcml2ZXIvZ3JhcGhUcmF2ZXJzYWwuZ28=) | `86.24% <100.00%> (+0.37%)` | :arrow_up: | ... and [1015 files with indirect coverage changes](https://app.codecov.io/gh/apache/tinkerpop/pull/2205/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) :mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@tinkerpop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [tinkerpop] xiazcy merged pull request #2174: TINKERPOP-2802: Add support for custom deserializers
xiazcy merged PR #2174: URL: https://github.com/apache/tinkerpop/pull/2174 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@tinkerpop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [tinkerpop] xiazcy commented on pull request #2174: TINKERPOP-2802: Add support for custom deserializers
xiazcy commented on PR #2174: URL: https://github.com/apache/tinkerpop/pull/2174#issuecomment-1679574964 LGTM, thanks for the contribution! VOTE +1 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@tinkerpop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[tinkerpop] branch master updated (a68b404f93 -> cdb23b24a0)
This is an automated email from the ASF dual-hosted git repository. xiazcy pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/tinkerpop.git from a68b404f93 CTR squashed docs/gremlint dependabots and update dependabot config add 928cf2d806 TINKERPOP-2802: Add support for custom deserializers (#2174) new cdb23b24a0 Merge branch '3.6-dev' The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: CHANGELOG.asciidoc | 1 + gremlin-go/driver/error_codes.go | 17 +++ gremlin-go/driver/graphBinary.go | 32 +++-- gremlin-go/driver/resources/error-messages/en.json | 1 + gremlin-go/driver/serializer.go| 26 ++ gremlin-go/driver/serializer_test.go | 55 +- 6 files changed, 118 insertions(+), 14 deletions(-)
[tinkerpop] 01/01: Merge branch '3.6-dev'
This is an automated email from the ASF dual-hosted git repository. xiazcy pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/tinkerpop.git commit cdb23b24a091e4e64b11556cf1cfcac2269efbc9 Merge: a68b404f93 928cf2d806 Author: Yang Xia <55853655+xia...@users.noreply.github.com> AuthorDate: Tue Aug 15 13:42:47 2023 -0700 Merge branch '3.6-dev' CHANGELOG.asciidoc | 1 + gremlin-go/driver/error_codes.go | 17 +++ gremlin-go/driver/graphBinary.go | 32 +++-- gremlin-go/driver/resources/error-messages/en.json | 1 + gremlin-go/driver/serializer.go| 26 ++ gremlin-go/driver/serializer_test.go | 55 +- 6 files changed, 118 insertions(+), 14 deletions(-)
[tinkerpop] branch 3.6-dev updated (ec4e23a63d -> 928cf2d806)
This is an automated email from the ASF dual-hosted git repository. xiazcy pushed a change to branch 3.6-dev in repository https://gitbox.apache.org/repos/asf/tinkerpop.git from ec4e23a63d Merge branch '3.5-dev' into 3.6-dev add 928cf2d806 TINKERPOP-2802: Add support for custom deserializers (#2174) No new revisions were added by this update. Summary of changes: CHANGELOG.asciidoc | 1 + gremlin-go/driver/error_codes.go | 17 +++ gremlin-go/driver/graphBinary.go | 32 +++-- gremlin-go/driver/resources/error-messages/en.json | 1 + gremlin-go/driver/serializer.go| 26 ++ gremlin-go/driver/serializer_test.go | 55 +- 6 files changed, 118 insertions(+), 14 deletions(-)
[tinkerpop] branch master updated: CTR fix links in reference docs
This is an automated email from the ASF dual-hosted git repository. colegreer pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/tinkerpop.git The following commit(s) were added to refs/heads/master by this push: new 1243d2f02a CTR fix links in reference docs 1243d2f02a is described below commit 1243d2f02a7cc974bab2cceb3bae182a2ff9bec6 Author: Cole-Greer AuthorDate: Tue Aug 15 14:05:06 2023 -0700 CTR fix links in reference docs --- docs/src/reference/intro.asciidoc | 2 +- docs/src/reference/preface.asciidoc | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/docs/src/reference/intro.asciidoc b/docs/src/reference/intro.asciidoc index 4a85ede578..9a8de98fc2 100644 --- a/docs/src/reference/intro.asciidoc +++ b/docs/src/reference/intro.asciidoc @@ -24,7 +24,7 @@ The Reference Documentation makes some general assumptions about the reader: 1. They have a sense of what a graph is - not sure? see link:http://kelvinlawrence.net/book/Gremlin-Graph-Guide.html#whygraph[Practical Gremlin - Why Graph?] 1. They know what it means for a graph system to be TinkerPop-enabled - not sure? see link:https://tinkerpop.apache.org/providers.html[TinkerPop-enabled Providers] -1. They know what the role of Gremlin is - not sure? see link:link:https://tinkerpop.apache.org/gremlin.html[Introduction to Gremlin] +1. They know what the role of Gremlin is - not sure? see link:https://tinkerpop.apache.org/gremlin.html[Introduction to Gremlin] Given those assumptions, it's possible to dive more quickly into the details without spending a lot of time repeating what is written elsewhere. diff --git a/docs/src/reference/preface.asciidoc b/docs/src/reference/preface.asciidoc index 3d306325ff..edc958d8e1 100644 --- a/docs/src/reference/preface.asciidoc +++ b/docs/src/reference/preface.asciidoc @@ -90,4 +90,4 @@ realized realizations are just as real. For that is -- The TinkerPop. image::gremlintron.png[width=400] NOTE: For more information about differences between TinkerPop 3.x and earlier versions, please see the -link:https://tinkerpop.apache.org/docs/x.y.z/upgrade/#appendix +link:https://tinkerpop.apache.org/docs/x.y.z/upgrade/#appendix[upgrade docs].
[tinkerpop] branch 3.5-dev updated (95cf6a6484 -> 0fc0c89e10)
This is an automated email from the ASF dual-hosted git repository. colegreer pushed a change to branch 3.5-dev in repository https://gitbox.apache.org/repos/asf/tinkerpop.git from 95cf6a6484 Merge branch 'dependabot/nuget/gremlin-dotnet/3.5-dev/BenchmarkDotNet-0.13.6' into 3.5-dev add 0fc0c89e10 Bump io.netty:netty-all from 4.1.86.Final to 4.1.96.Final No new revisions were added by this update. Summary of changes: CHANGELOG.asciidoc | 1 + gremlin-console/src/main/static/NOTICE | 2 +- gremlin-driver/src/main/static/NOTICE | 2 +- gremlin-server/src/main/static/NOTICE | 2 +- pom.xml| 2 +- 5 files changed, 5 insertions(+), 4 deletions(-)
[GitHub] [tinkerpop] Cole-Greer commented on pull request #2167: Bump io.netty:netty-all from 4.1.86.Final to 4.1.96.Final
Cole-Greer commented on PR #2167: URL: https://github.com/apache/tinkerpop/pull/2167#issuecomment-1679663670 > How long to get this merged? Just cherry-picked this in with https://github.com/apache/tinkerpop/commit/0fc0c89e107656273450ba7d3890e9df9e169e18 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@tinkerpop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [tinkerpop] dependabot[bot] commented on pull request #2167: Bump io.netty:netty-all from 4.1.86.Final to 4.1.96.Final
dependabot[bot] commented on PR #2167: URL: https://github.com/apache/tinkerpop/pull/2167#issuecomment-1679663709 OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting `@dependabot ignore this major version` or `@dependabot ignore this minor version`. You can also ignore all major, minor, or patch releases for a dependency by adding an [`ignore` condition](https://docs.github.com/en/code-security/supply-chain-security/configuration-options-for-dependency-updates#ignore) with the desired `update_types` to your config file. If you change your mind, just re-open this PR and I'll resolve any conflicts on it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@tinkerpop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [tinkerpop] Cole-Greer closed pull request #2167: Bump io.netty:netty-all from 4.1.86.Final to 4.1.96.Final
Cole-Greer closed pull request #2167: Bump io.netty:netty-all from 4.1.86.Final to 4.1.96.Final URL: https://github.com/apache/tinkerpop/pull/2167 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@tinkerpop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[tinkerpop] branch dependabot/maven/3.5-dev/io.netty-netty-all-4.1.96.Final deleted (was 8997ddc543)
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch dependabot/maven/3.5-dev/io.netty-netty-all-4.1.96.Final in repository https://gitbox.apache.org/repos/asf/tinkerpop.git was 8997ddc543 Bump io.netty:netty-all from 4.1.86.Final to 4.1.96.Final The revisions that were on this branch are still contained in other references; therefore, this change does not discard any commits from the repository.
[tinkerpop] 01/01: Merge branch '3.5-dev' into 3.6-dev
This is an automated email from the ASF dual-hosted git repository. colegreer pushed a commit to branch 3.6-dev in repository https://gitbox.apache.org/repos/asf/tinkerpop.git commit a04a65497763283c5e8ec2fb048eee3d0d5f9b74 Merge: 928cf2d806 0fc0c89e10 Author: Cole-Greer AuthorDate: Tue Aug 15 14:49:04 2023 -0700 Merge branch '3.5-dev' into 3.6-dev CHANGELOG.asciidoc | 1 + gremlin-console/src/main/static/NOTICE | 2 +- gremlin-driver/src/main/static/NOTICE | 2 +- gremlin-server/src/main/static/NOTICE | 2 +- pom.xml| 2 +- 5 files changed, 5 insertions(+), 4 deletions(-) diff --cc pom.xml index a1d4a277d9,afc5b1ef46..2ffa3b7d75 --- a/pom.xml +++ b/pom.xml @@@ -170,13 -167,13 +170,13 @@@ limitations under the License 0.4 4.13.1 2.0.1 -1.2.17 +1.2.11 3.0.2 3.3.3 - 4.1.86.Final + 4.1.96.Final 1.7.25 2.0 -3.0.0 +3.2.1 2.0.9 UTF-8
[tinkerpop] branch 3.6-dev updated (928cf2d806 -> a04a654977)
This is an automated email from the ASF dual-hosted git repository. colegreer pushed a change to branch 3.6-dev in repository https://gitbox.apache.org/repos/asf/tinkerpop.git from 928cf2d806 TINKERPOP-2802: Add support for custom deserializers (#2174) add 0fc0c89e10 Bump io.netty:netty-all from 4.1.86.Final to 4.1.96.Final new a04a654977 Merge branch '3.5-dev' into 3.6-dev The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: CHANGELOG.asciidoc | 1 + gremlin-console/src/main/static/NOTICE | 2 +- gremlin-driver/src/main/static/NOTICE | 2 +- gremlin-server/src/main/static/NOTICE | 2 +- pom.xml| 2 +- 5 files changed, 5 insertions(+), 4 deletions(-)
[tinkerpop] 01/01: Merge branch '3.6-dev'
This is an automated email from the ASF dual-hosted git repository. colegreer pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/tinkerpop.git commit 30c9fd3dbacca01d7b7baf349208c669b13489f7 Merge: 1243d2f02a a04a654977 Author: Cole-Greer AuthorDate: Tue Aug 15 14:50:17 2023 -0700 Merge branch '3.6-dev' CHANGELOG.asciidoc | 1 + gremlin-console/src/main/static/NOTICE | 2 +- gremlin-driver/src/main/static/NOTICE | 2 +- gremlin-server/src/main/static/NOTICE | 2 +- pom.xml| 2 +- 5 files changed, 5 insertions(+), 4 deletions(-) diff --cc pom.xml index 0d41745146,2ffa3b7d75..b1618a03ad --- a/pom.xml +++ b/pom.xml @@@ -173,11 -172,12 +173,11 @@@ limitations under the License 2.0.1 1.2.11 3.0.2 -3.3.3 +4.10.0 - 4.1.86.Final + 4.1.96.Final -1.7.25 +1.7.33 2.0 -3.2.1 -2.0.9 +3.3.2 UTF-8 UTF-8
[tinkerpop] branch master updated (1243d2f02a -> 30c9fd3dba)
This is an automated email from the ASF dual-hosted git repository. colegreer pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/tinkerpop.git from 1243d2f02a CTR fix links in reference docs add 0fc0c89e10 Bump io.netty:netty-all from 4.1.86.Final to 4.1.96.Final add a04a654977 Merge branch '3.5-dev' into 3.6-dev new 30c9fd3dba Merge branch '3.6-dev' The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: CHANGELOG.asciidoc | 1 + gremlin-console/src/main/static/NOTICE | 2 +- gremlin-driver/src/main/static/NOTICE | 2 +- gremlin-server/src/main/static/NOTICE | 2 +- pom.xml| 2 +- 5 files changed, 5 insertions(+), 4 deletions(-)
[GitHub] [tinkerpop] rdtr commented on a diff in pull request #2206: TINKERPOP-2982 Allowed gremlin-driver to work over HTTP.
rdtr commented on code in PR #2206:
URL: https://github.com/apache/tinkerpop/pull/2206#discussion_r1295382250
##
gremlin-driver/src/main/java/org/apache/tinkerpop/gremlin/driver/handler/HttpGremlinRequestEncoder.java:
##
@@ -0,0 +1,92 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.tinkerpop.gremlin.driver.handler;
+
+import io.netty.buffer.ByteBuf;
+import io.netty.channel.ChannelHandler;
+import io.netty.channel.ChannelHandlerContext;
+import io.netty.handler.codec.MessageToMessageEncoder;
+import io.netty.handler.codec.http.DefaultFullHttpRequest;
+import io.netty.handler.codec.http.FullHttpRequest;
+import io.netty.handler.codec.http.HttpHeaderNames;
+import io.netty.handler.codec.http.HttpMethod;
+import io.netty.handler.codec.http.HttpVersion;
+import org.apache.tinkerpop.gremlin.driver.MessageSerializer;
+import org.apache.tinkerpop.gremlin.driver.Tokens;
+import org.apache.tinkerpop.gremlin.driver.exception.ResponseException;
+import org.apache.tinkerpop.gremlin.driver.message.RequestMessage;
+import org.apache.tinkerpop.gremlin.driver.message.ResponseStatusCode;
+import org.apache.tinkerpop.gremlin.process.traversal.Bytecode;
+import
org.apache.tinkerpop.gremlin.process.traversal.translator.GroovyTranslator;
+import org.apache.tinkerpop.shaded.jackson.databind.ObjectMapper;
+
+import java.util.HashMap;
+import java.util.List;
+import java.util.function.UnaryOperator;
+
+/**
+ * Converts {@link RequestMessage} to a {@code HttpRequest}.
+ */
+@ChannelHandler.Sharable
+public final class HttpGremlinRequestEncoder extends
MessageToMessageEncoder {
+private final MessageSerializer serializer;
+
+private final ObjectMapper mapper = new ObjectMapper();
Review Comment:
Do we need to have an instance of ObjectMapper for each handler ? I believe
creating a mapper is relatively expensive operation, thus if we can make it
`static` it'd be better.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
