Re: [PR] [TINKERPOP-3014] Reorder the jcl-over-slf4j dependency to avoid the dependency conflict. [tinkerpop]
HappyHacker123 commented on PR #2335: URL: https://github.com/apache/tinkerpop/pull/2335#issuecomment-1813813219 I raise a pr #2349 that adapt the changes and change the base branch. Close this pr. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@tinkerpop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [TINKERPOP-3014] Reorder the jcl-over-slf4j dependency to avoid the dependency conflict. [tinkerpop]
HappyHacker123 closed pull request #2335: [TINKERPOP-3014] Reorder the jcl-over-slf4j dependency to avoid the dependency conflict. URL: https://github.com/apache/tinkerpop/pull/2335 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@tinkerpop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [TINKERPOP-3014] Reorder the jcl-over-slf4j dependency to avoid the dependency conflict. [tinkerpop]
HappyHacker123 commented on PR #2335: URL: https://github.com/apache/tinkerpop/pull/2335#issuecomment-1813794904 > Would you like to see this changes in 3.5.x, 3.6.x or 3.7.x? I think 3.7.x is fine :), i will rebase to 3.7-dev and open anthoer pr. > I don't have any issues with the reordering, other than I would prefer to move all slf4j dependencies together to maintain organization. Sure, i will add the changes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@tinkerpop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
(tinkerpop) branch master updated: [TINKERPOP-2877] Added integer overflow checks (#2344)
This is an automated email from the ASF dual-hosted git repository.
valentyn pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/tinkerpop.git
The following commit(s) were added to refs/heads/master by this push:
new 846761004e [TINKERPOP-2877] Added integer overflow checks (#2344)
846761004e is described below
commit 846761004eed2b26cb79dcc9aa05f9d0f0f34769
Author: Valentyn Kahamlyk
AuthorDate: Wed Nov 15 16:52:27 2023 -0800
[TINKERPOP-2877] Added integer overflow checks (#2344)
---
CHANGELOG.asciidoc | 2 ++
docs/src/upgrade/release-4.x.x.asciidoc| 4 +++
.../gremlin/process/traversal/Operator.java| 2 +-
.../tinkerpop/gremlin/util/NumberHelper.java | 36 ++---
.../tinkerpop/gremlin/util/NumberHelperTest.java | 37 ++
5 files changed, 68 insertions(+), 13 deletions(-)
diff --git a/CHANGELOG.asciidoc b/CHANGELOG.asciidoc
index 2cb8d714cc..c711560485 100644
--- a/CHANGELOG.asciidoc
+++ b/CHANGELOG.asciidoc
@@ -24,6 +24,7 @@
image::https://raw.githubusercontent.com/apache/tinkerpop/master/docs/static/ima
=== TinkerPop 4.0.0 (NOT OFFICIALLY RELEASED YET)
* Added support for deserialization of `Set` for `gremlin-javascript`.
+* Added integer overflow checks.
== TinkerPop 3.7.0 (Gremfir Master of the Pan Flute)
@@ -471,6 +472,7 @@ This release also includes changes from <>.
* Added `TextP.regex` and `TextP.notRegex`.
* Changed TinkerGraph to allow identifiers to be heterogeneous when filtering.
* Prevented values of `T` to `property()` from being `null`.
+* Added throwing `ArithmeticException` when arithmetic operations overflow for
byte, short, int and long arguments.
* Added `element()` step.
* Added `call()` step.
* Added `fail()` step.
diff --git a/docs/src/upgrade/release-4.x.x.asciidoc
b/docs/src/upgrade/release-4.x.x.asciidoc
index 4a922dbcc9..793c0f28a2 100644
--- a/docs/src/upgrade/release-4.x.x.asciidoc
+++ b/docs/src/upgrade/release-4.x.x.asciidoc
@@ -33,6 +33,10 @@ complete list of all the modifications that are part of this
release.
Starting from this version, `gremlin-javascript` will deserialize `Set` data
into a ECMAScript 2015 Set. Previously,
these were deserialized into arrays.
+ Improved handling of integer overflows
+Integer overflows caused by addition and multiplication operations will throw
an exception instead of being silently
+skipped with incorrect result.
+
=== Upgrading for Providers
Graph System Providers
diff --git
a/gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/Operator.java
b/gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/Operator.java
index b4d3cb23a0..5bb2c85b3a 100644
---
a/gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/Operator.java
+++
b/gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/Operator.java
@@ -202,7 +202,7 @@ public enum Operator implements BinaryOperator {
*/
sumLong {
public Object apply(final Object a, final Object b) {
-return (long) a + (long) b;
+return NumberHelper.add((long) a, (long) b);
}
}
}
diff --git
a/gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/util/NumberHelper.java
b/gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/util/NumberHelper.java
index e4a2da8281..2d1e6154ad 100644
---
a/gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/util/NumberHelper.java
+++
b/gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/util/NumberHelper.java
@@ -28,10 +28,22 @@ import java.util.function.BiFunction;
*/
public final class NumberHelper {
+private static byte asByte(int arg) {
+if (arg > Byte.MAX_VALUE || arg < Byte.MIN_VALUE)
+throw new ArithmeticException("byte overflow");
+return (byte) arg;
+}
+
+private static short asShort(int arg) {
+if (arg > Short.MAX_VALUE || arg < Short.MIN_VALUE)
+throw new ArithmeticException("short overflow");
+return (short) arg;
+}
+
static final NumberHelper BYTE_NUMBER_HELPER = new NumberHelper(
-(a, b) -> (byte) (a.byteValue() + b.byteValue()),
-(a, b) -> (byte) (a.byteValue() - b.byteValue()),
-(a, b) -> (byte) (a.byteValue() * b.byteValue()),
+(a, b) -> asByte(a.byteValue() + b.byteValue()),
+(a, b) -> asByte(a.byteValue() - b.byteValue()),
+(a, b) -> asByte(a.byteValue() * b.byteValue()),
(a, b) -> (byte) (a.byteValue() / b.byteValue()),
(a, b) -> {
if (isNumber(a)) {
@@ -56,9 +68,9 @@ public final class NumberHelper {
(a, b) -> Byte.compare(a.byteValue(), b.byteValue()));
static final NumberHelper SHORT_NUMBER_HELPER = new NumberHelper(
-(a, b) -> (short) (a.shortValue() + b.shortValue()),
-(a, b) -> (sh
Re: [PR] [TINKERPOP-2877] Added integer overflow checks [tinkerpop]
vkagamlyk merged PR #2344: URL: https://github.com/apache/tinkerpop/pull/2344 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@tinkerpop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [TINKERPOP-2877] Added integer overflow checks [tinkerpop]
vkagamlyk commented on PR #2344: URL: https://github.com/apache/tinkerpop/pull/2344#issuecomment-1813533149 VOTE+1 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@tinkerpop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
(tinkerpop) branch master updated (d8320d05c2 -> 15e1c1b22c)
This is an automated email from the ASF dual-hosted git repository. valentyn pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/tinkerpop.git from d8320d05c2 Bump @types/node from 20.8.7 to 20.9.0 in /docs/gremlint (#2333) add ed4dac94af [TINKERPOP-3016] Fix for reading value from different read operation (#2343) add 8365421f25 Bytecode support for HTTP requests (#2336) add 0abb82d87f merge bytecode over HTTP PR new 15e1c1b22c Merge branch '3.7-dev' The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: CHANGELOG.asciidoc | 1 + .../driver/handler/HttpGremlinRequestEncoder.java | 48 +++--- .../driver/handler/HttpGremlinResponseDecoder.java | 8 +- .../gremlin/groovy/engine/GremlinExecutor.java | 86 +-- .../gremlin_python/driver/aiohttp/transport.py | 4 +- .../main/python/gremlin_python/driver/protocol.py | 32 +--- .../driver/test_driver_remote_connection_http.py | 19 +-- .../conf/gremlin-server-rest-modern.yaml | 5 +- .../server/handler/HttpGremlinEndpointHandler.java | 82 +- .../gremlin/server/handler/HttpHandlerUtil.java| 63 +++- .../server/util/TextPlainMessageSerializer.java| 7 +- .../server/GremlinServerHttpIntegrateTest.java | 20 ++- .../gremlin/server/HttpDriverIntegrateTest.java| 30 +++- .../server/handler/HttpHandlerUtilTest.java| 165 + .../util/ser/GraphSONMessageSerializerV3Test.java | 48 +- .../binary/GraphBinaryMessageSerializerV1Test.java | 25 +++- .../structure/TinkerElementContainer.java | 33 +++-- .../tinkergraph/structure/TinkerTransaction.java | 44 -- .../structure/TinkerTransactionGraph.java | 35 ++--- .../structure/TinkerTransactionalIndex.java| 4 +- .../structure/TinkerTransactionGraphTest.java | 45 ++ 21 files changed, 599 insertions(+), 205 deletions(-) create mode 100644 gremlin-server/src/test/java/org/apache/tinkerpop/gremlin/server/handler/HttpHandlerUtilTest.java
(tinkerpop) 01/01: Merge branch '3.7-dev'
This is an automated email from the ASF dual-hosted git repository. valentyn pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/tinkerpop.git commit 15e1c1b22cf4cc7b17fd8ae675ddcafac2eae94c Merge: d8320d05c2 0abb82d87f Author: Valentyn Kahamlyk AuthorDate: Wed Nov 15 16:50:29 2023 -0800 Merge branch '3.7-dev' CHANGELOG.asciidoc | 1 + .../driver/handler/HttpGremlinRequestEncoder.java | 48 +++--- .../driver/handler/HttpGremlinResponseDecoder.java | 8 +- .../gremlin/groovy/engine/GremlinExecutor.java | 86 +-- .../gremlin_python/driver/aiohttp/transport.py | 4 +- .../main/python/gremlin_python/driver/protocol.py | 32 +--- .../driver/test_driver_remote_connection_http.py | 19 +-- .../conf/gremlin-server-rest-modern.yaml | 5 +- .../server/handler/HttpGremlinEndpointHandler.java | 82 +- .../gremlin/server/handler/HttpHandlerUtil.java| 63 +++- .../server/util/TextPlainMessageSerializer.java| 7 +- .../server/GremlinServerHttpIntegrateTest.java | 20 ++- .../gremlin/server/HttpDriverIntegrateTest.java| 30 +++- .../server/handler/HttpHandlerUtilTest.java| 165 + .../util/ser/GraphSONMessageSerializerV3Test.java | 48 +- .../binary/GraphBinaryMessageSerializerV1Test.java | 25 +++- .../structure/TinkerElementContainer.java | 33 +++-- .../tinkergraph/structure/TinkerTransaction.java | 44 -- .../structure/TinkerTransactionGraph.java | 35 ++--- .../structure/TinkerTransactionalIndex.java| 4 +- .../structure/TinkerTransactionGraphTest.java | 45 ++ 21 files changed, 599 insertions(+), 205 deletions(-)
(tinkerpop) 01/01: merge bytecode over HTTP PR
This is an automated email from the ASF dual-hosted git repository.
valentyn pushed a commit to branch 3.7-dev
in repository https://gitbox.apache.org/repos/asf/tinkerpop.git
commit 0abb82d87f155191750f42e5f2a4ffc9f037eaf9
Merge: ed4dac94af 8365421f25
Author: Valentyn Kahamlyk
AuthorDate: Wed Nov 15 16:48:44 2023 -0800
merge bytecode over HTTP PR
.../driver/handler/HttpGremlinRequestEncoder.java | 48 +++---
.../driver/handler/HttpGremlinResponseDecoder.java | 8 +-
.../gremlin/groovy/engine/GremlinExecutor.java | 86 +--
.../gremlin_python/driver/aiohttp/transport.py | 4 +-
.../main/python/gremlin_python/driver/protocol.py | 32 +---
.../driver/test_driver_remote_connection_http.py | 19 +--
.../conf/gremlin-server-rest-modern.yaml | 5 +-
.../server/handler/HttpGremlinEndpointHandler.java | 82 +-
.../gremlin/server/handler/HttpHandlerUtil.java| 63 +++-
.../server/util/TextPlainMessageSerializer.java| 7 +-
.../server/GremlinServerHttpIntegrateTest.java | 20 ++-
.../gremlin/server/HttpDriverIntegrateTest.java| 30 +++-
.../server/handler/HttpHandlerUtilTest.java| 165 +
.../util/ser/GraphSONMessageSerializerV3Test.java | 48 +-
.../binary/GraphBinaryMessageSerializerV1Test.java | 25 +++-
15 files changed, 483 insertions(+), 159 deletions(-)
diff --cc
gremlin-driver/src/main/java/org/apache/tinkerpop/gremlin/driver/handler/HttpGremlinRequestEncoder.java
index 1c15f6162c,bdf0f544af..c29dd1ddaa
---
a/gremlin-driver/src/main/java/org/apache/tinkerpop/gremlin/driver/handler/HttpGremlinRequestEncoder.java
+++
b/gremlin-driver/src/main/java/org/apache/tinkerpop/gremlin/driver/handler/HttpGremlinRequestEncoder.java
@@@ -27,16 -27,13 +27,13 @@@ import io.netty.handler.codec.http.Full
import io.netty.handler.codec.http.HttpHeaderNames;
import io.netty.handler.codec.http.HttpMethod;
import io.netty.handler.codec.http.HttpVersion;
- import org.apache.tinkerpop.gremlin.util.MessageSerializer;
- import org.apache.tinkerpop.gremlin.util.Tokens;
-import org.apache.tinkerpop.gremlin.driver.MessageSerializer;
import org.apache.tinkerpop.gremlin.driver.exception.ResponseException;
-import org.apache.tinkerpop.gremlin.driver.message.RequestMessage;
-import org.apache.tinkerpop.gremlin.driver.message.ResponseStatusCode;
-import org.apache.tinkerpop.gremlin.driver.ser.SerTokens;
+ import org.apache.tinkerpop.gremlin.process.traversal.Bytecode;
++import org.apache.tinkerpop.gremlin.util.MessageSerializer;
+import org.apache.tinkerpop.gremlin.util.message.RequestMessage;
+import org.apache.tinkerpop.gremlin.util.message.ResponseStatusCode;
- import org.apache.tinkerpop.gremlin.process.traversal.Bytecode;
- import
org.apache.tinkerpop.gremlin.process.traversal.translator.GroovyTranslator;
- import org.apache.tinkerpop.shaded.jackson.databind.ObjectMapper;
++import org.apache.tinkerpop.gremlin.util.ser.SerTokens;
- import java.util.HashMap;
import java.util.List;
import java.util.function.UnaryOperator;
@@@ -58,29 -53,22 +53,22 @@@ public final class HttpGremlinRequestEn
@Override
protected void encode(final ChannelHandlerContext channelHandlerContext,
final RequestMessage requestMessage, final List objects) throws
Exception {
- try {
- final String gremlin;
- final Object gremlinStringOrBytecode =
requestMessage.getArg(Tokens.ARGS_GREMLIN);
+ final String mimeType = serializer.mimeTypesSupported()[0];
+ // only GraphSON3 and GraphBinary recommended for serialization of
Bytecode requests
+ if (requestMessage.getArg("gremlin") instanceof Bytecode &&
-!mimeType.equals(SerTokens.MIME_GRAPHSON_V3D0) &&
-!mimeType.equals(SerTokens.MIME_GRAPHBINARY_V1D0)) {
++!mimeType.equals(SerTokens.MIME_GRAPHSON_V3) &&
++!mimeType.equals(SerTokens.MIME_GRAPHBINARY_V1)) {
+ throw new
ResponseException(ResponseStatusCode.REQUEST_ERROR_SERIALIZATION, String.format(
+ "An error occurred during serialization of this request
[%s] - it could not be sent to the server - Reason: only GraphSON3 and
GraphBinary recommended for serialization of Bytecode requests, but used %s",
+ requestMessage, serializer.getClass().getName()));
+ }
- // the gremlin key can contain a Gremlin script or bytecode. if
it's bytecode we can't submit it over
- // http as such. it has to be converted to a script and we can do
that with the Groovy translator.
- final boolean usesBytecode = gremlinStringOrBytecode instanceof
Bytecode;
- if (usesBytecode) {
- gremlin = GroovyTranslator.of("g").translate((Bytecode)
gremlinStringOrBytecode).getScript();
- } else {
- gremlin = gremlinStringOrBytecode.toString();
- }
- fi
(tinkerpop) branch 3.7-dev updated (ed4dac94af -> 0abb82d87f)
This is an automated email from the ASF dual-hosted git repository. valentyn pushed a change to branch 3.7-dev in repository https://gitbox.apache.org/repos/asf/tinkerpop.git from ed4dac94af [TINKERPOP-3016] Fix for reading value from different read operation (#2343) add 8365421f25 Bytecode support for HTTP requests (#2336) new 0abb82d87f merge bytecode over HTTP PR The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: .../driver/handler/HttpGremlinRequestEncoder.java | 48 +++--- .../driver/handler/HttpGremlinResponseDecoder.java | 8 +- .../gremlin/groovy/engine/GremlinExecutor.java | 86 +-- .../gremlin_python/driver/aiohttp/transport.py | 4 +- .../main/python/gremlin_python/driver/protocol.py | 32 +--- .../driver/test_driver_remote_connection_http.py | 19 +-- .../conf/gremlin-server-rest-modern.yaml | 5 +- .../server/handler/HttpGremlinEndpointHandler.java | 82 +- .../gremlin/server/handler/HttpHandlerUtil.java| 63 +++- .../server/util/TextPlainMessageSerializer.java| 7 +- .../server/GremlinServerHttpIntegrateTest.java | 20 ++- .../gremlin/server/HttpDriverIntegrateTest.java| 30 +++- .../server/handler/HttpHandlerUtilTest.java| 165 + .../util/ser/GraphSONMessageSerializerV3Test.java | 48 +- .../binary/GraphBinaryMessageSerializerV1Test.java | 25 +++- 15 files changed, 483 insertions(+), 159 deletions(-) create mode 100644 gremlin-server/src/test/java/org/apache/tinkerpop/gremlin/server/handler/HttpHandlerUtilTest.java
Re: [PR] [TINKERPOP-2877] Added integer overflow checks [tinkerpop]
kenhuuu commented on PR #2344: URL: https://github.com/apache/tinkerpop/pull/2344#issuecomment-1813392617 VOTE +1 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@tinkerpop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [TINKERPOP-2877] Added integer overflow checks [tinkerpop]
kenhuuu commented on PR #2344: URL: https://github.com/apache/tinkerpop/pull/2344#issuecomment-1813392494 > > Does this account for Math Step? exp is a valid function there. > > there is no exp in `NumberHelper`. Math Step evaluation handled by external library `net.objecthunter.exp4j`, it's out of scope. Ok I don't think this needs any changes, but it does introduce inconsistencies if that library doesn't throw the ArithmeticException. Maybe a test case would be good. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@tinkerpop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [TINKERPOP-2877] Added integer overflow checks [tinkerpop]
kenhuuu commented on code in PR #2344:
URL: https://github.com/apache/tinkerpop/pull/2344#discussion_r1394948664
##
gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/util/NumberHelper.java:
##
@@ -28,10 +28,22 @@
*/
public final class NumberHelper {
+private static byte asByte(int arg) {
+if (arg > Byte.MAX_VALUE || arg < Byte.MIN_VALUE)
+throw new ArithmeticException("byte overflow");
Review Comment:
Their usage is different as it's not used for argument checking, it applies
checking to a result. I'm OK with not changing this due to how NumberHelper is
set up as it would add complicated exception handling for little gain.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
(tinkerpop) branch dependabot/npm_and_yarn/docs/gremlint/master/types/node-20.9.0 deleted (was 3d15c002ed)
This is an automated email from the ASF dual-hosted git repository. colegreer pushed a change to branch dependabot/npm_and_yarn/docs/gremlint/master/types/node-20.9.0 in repository https://gitbox.apache.org/repos/asf/tinkerpop.git was 3d15c002ed Bump @types/node from 20.8.7 to 20.9.0 in /docs/gremlint The revisions that were on this branch are still contained in other references; therefore, this change does not discard any commits from the repository.
(tinkerpop) branch master updated: Bump @types/node from 20.8.7 to 20.9.0 in /docs/gremlint (#2333)
This is an automated email from the ASF dual-hosted git repository.
colegreer pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/tinkerpop.git
The following commit(s) were added to refs/heads/master by this push:
new d8320d05c2 Bump @types/node from 20.8.7 to 20.9.0 in /docs/gremlint
(#2333)
d8320d05c2 is described below
commit d8320d05c25fb085109e443fcb6649f1b991693a
Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
AuthorDate: Wed Nov 15 14:39:12 2023 -0800
Bump @types/node from 20.8.7 to 20.9.0 in /docs/gremlint (#2333)
Bumps
[@types/node](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/node)
from 20.8.7 to 20.9.0.
- [Release
notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases)
-
[Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/node)
---
updated-dependencies:
- dependency-name: "@types/node"
dependency-type: direct:development
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot]
Co-authored-by: dependabot[bot]
<49699333+dependabot[bot]@users.noreply.github.com>
---
docs/gremlint/package-lock.json | 30 +++---
docs/gremlint/package.json | 2 +-
2 files changed, 16 insertions(+), 16 deletions(-)
diff --git a/docs/gremlint/package-lock.json b/docs/gremlint/package-lock.json
index 1d1b412fbe..863d6eefa5 100644
--- a/docs/gremlint/package-lock.json
+++ b/docs/gremlint/package-lock.json
@@ -25,7 +25,7 @@
"@testing-library/react": "^12.1.5",
"@testing-library/user-event": "^14.5.1",
"@types/jest": "^29.5.4",
-"@types/node": "^20.8.7",
+"@types/node": "^20.9.0",
"@types/react": "^17.0.38",
"@types/react-dom": "^17.0.11",
"@types/styled-components": "^5.1.26",
@@ -4534,11 +4534,11 @@
"integrity":
"sha512-YATxVxgRqNH6nHEIsvg6k2Boc1JHI9ZbH5iWFFv/MTkchz3b1ieGDa5T0a9RznNdI0KhVbdbWSN+KWWrQZRxTw=="
},
"node_modules/@types/node": {
- "version": "20.8.7",
- "resolved": "https://registry.npmjs.org/@types/node/-/node-20.8.7.tgz";,
- "integrity":
"sha512-21TKHHh3eUHIi2MloeptJWALuCu5H7HQTdTrWIFReA8ad+aggoX+lRes3ex7/FtpC+sVUpFMQ+QTfYr74mruiQ==",
+ "version": "20.9.0",
+ "resolved": "https://registry.npmjs.org/@types/node/-/node-20.9.0.tgz";,
+ "integrity":
"sha512-nekiGu2NDb1BcVofVcEKMIwzlx4NjHlcjhoxxKBNLtz15Y1z7MYf549DFvkHSId02Ax6kGwWntIBPC3l/JZcmw==",
"dependencies": {
-"undici-types": "~5.25.1"
+"undici-types": "~5.26.4"
}
},
"node_modules/@types/parse-json": {
@@ -19028,9 +19028,9 @@
}
},
"node_modules/undici-types": {
- "version": "5.25.3",
- "resolved":
"https://registry.npmjs.org/undici-types/-/undici-types-5.25.3.tgz";,
- "integrity":
"sha512-Ga1jfYwRn7+cP9v8auvEXN1rX3sWqlayd4HP7OKk4mZWylEmu3KzXDUGrQUN6Ol7qo1gPvB2e5gX6udnyEPgdA=="
+ "version": "5.26.5",
+ "resolved":
"https://registry.npmjs.org/undici-types/-/undici-types-5.26.5.tgz";,
+ "integrity":
"sha512-JlCMO+ehdEIKqlFxk6IfVoAUVmgz7cU7zD/h9XZ0qzeosSHmUJVOzSQvvYSYWXkFXC+IfLKSIffhv0sVZup6pA=="
},
"node_modules/unicode-canonical-property-names-ecmascript": {
"version": "2.0.0",
@@ -23341,11 +23341,11 @@
"integrity":
"sha512-YATxVxgRqNH6nHEIsvg6k2Boc1JHI9ZbH5iWFFv/MTkchz3b1ieGDa5T0a9RznNdI0KhVbdbWSN+KWWrQZRxTw=="
},
"@types/node": {
- "version": "20.8.7",
- "resolved": "https://registry.npmjs.org/@types/node/-/node-20.8.7.tgz";,
- "integrity":
"sha512-21TKHHh3eUHIi2MloeptJWALuCu5H7HQTdTrWIFReA8ad+aggoX+lRes3ex7/FtpC+sVUpFMQ+QTfYr74mruiQ==",
+ "version": "20.9.0",
+ "resolved": "https://registry.npmjs.org/@types/node/-/node-20.9.0.tgz";,
+ "integrity":
"sha512-nekiGu2NDb1BcVofVcEKMIwzlx4NjHlcjhoxxKBNLtz15Y1z7MYf549DFvkHSId02Ax6kGwWntIBPC3l/JZcmw==",
"requires": {
-"undici-types": "~5.25.1"
+"undici-types": "~5.26.4"
}
},
"@types/parse-json": {
@@ -34014,9 +34014,9 @@
}
},
"undici-types": {
- "version": "5.25.3",
- "resolved":
"https://registry.npmjs.org/undici-types/-/undici-types-5.25.3.tgz";,
- "integrity":
"sha512-Ga1jfYwRn7+cP9v8auvEXN1rX3sWqlayd4HP7OKk4mZWylEmu3KzXDUGrQUN6Ol7qo1gPvB2e5gX6udnyEPgdA=="
+ "version": "5.26.5",
+ "resolved":
"https://registry.npmjs.org/undici-types/-/undici-types-5.26.5.tgz";,
+ "integrity":
"sha512-JlCMO+ehdEIKqlFxk6IfVoAUVmgz7cU7zD/h9XZ0qzeosSHmUJVOzSQvvYSYWXkFXC+IfLKSIffhv0sVZup6pA=="
},
"unicode-canonical-property-names-ecmascript": {
"version": "2.0.0",
diff --git a/docs/gremlint/package.json b/docs/gremlint/package.json
index 30b2f511ce..b4b5ecf291 100644
--- a/docs/gremlint/package.json
+++ b/docs/gremlint/package.json
@@ -48,7 +48,7 @@
"@testing-library/react": "^12.1.5",
"@testin
Re: [PR] Bump @types/node from 20.8.7 to 20.9.0 in /docs/gremlint [tinkerpop]
Cole-Greer merged PR #2333: URL: https://github.com/apache/tinkerpop/pull/2333 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@tinkerpop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
(tinkerpop) branch dependabot/npm_and_yarn/docs/gremlint/master/prettier-3.1.0 deleted (was b53bc73876)
This is an automated email from the ASF dual-hosted git repository. colegreer pushed a change to branch dependabot/npm_and_yarn/docs/gremlint/master/prettier-3.1.0 in repository https://gitbox.apache.org/repos/asf/tinkerpop.git was b53bc73876 Bump prettier from 3.0.1 to 3.1.0 in /docs/gremlint The revisions that were on this branch are still contained in other references; therefore, this change does not discard any commits from the repository.
(tinkerpop) branch master updated: Bump prettier from 3.0.1 to 3.1.0 in /docs/gremlint (#2340)
This is an automated email from the ASF dual-hosted git repository.
colegreer pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/tinkerpop.git
The following commit(s) were added to refs/heads/master by this push:
new e65dcb9358 Bump prettier from 3.0.1 to 3.1.0 in /docs/gremlint (#2340)
e65dcb9358 is described below
commit e65dcb9358c9d74069394f3798e8ef906167a97e
Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
AuthorDate: Wed Nov 15 14:38:54 2023 -0800
Bump prettier from 3.0.1 to 3.1.0 in /docs/gremlint (#2340)
Bumps [prettier](https://github.com/prettier/prettier) from 3.0.1 to 3.1.0.
- [Release notes](https://github.com/prettier/prettier/releases)
- [Changelog](https://github.com/prettier/prettier/blob/main/CHANGELOG.md)
- [Commits](https://github.com/prettier/prettier/compare/3.0.1...3.1.0)
---
updated-dependencies:
- dependency-name: prettier
dependency-type: direct:development
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot]
Co-authored-by: dependabot[bot]
<49699333+dependabot[bot]@users.noreply.github.com>
---
docs/gremlint/package-lock.json | 14 +++---
docs/gremlint/package.json | 2 +-
2 files changed, 8 insertions(+), 8 deletions(-)
diff --git a/docs/gremlint/package-lock.json b/docs/gremlint/package-lock.json
index e370f9915a..1d1b412fbe 100644
--- a/docs/gremlint/package-lock.json
+++ b/docs/gremlint/package-lock.json
@@ -30,7 +30,7 @@
"@types/react-dom": "^17.0.11",
"@types/styled-components": "^5.1.26",
"gh-pages": "^6.0.0",
-"prettier": "^3.0.1",
+"prettier": "^3.1.0",
"tslint": "^6.1.3",
"tslint-config-prettier": "^1.18.0"
},
@@ -15488,9 +15488,9 @@
}
},
"node_modules/prettier": {
- "version": "3.0.1",
- "resolved": "https://registry.npmjs.org/prettier/-/prettier-3.0.1.tgz";,
- "integrity":
"sha512-fcOWSnnpCrovBsmFZIGIy9UqK2FaI7Hqax+DIO0A9UxeVoY4iweyaFjS5TavZN97Hfehph0nhsZnjlVKzEQSrQ==",
+ "version": "3.1.0",
+ "resolved": "https://registry.npmjs.org/prettier/-/prettier-3.1.0.tgz";,
+ "integrity":
"sha512-TQLvXjq5IAibjh8EpBIkNKxO749UEWABoiIZehEPiY4GNpVdhaFKqSTu+QrlU6D2dPAfubRmtJTi4K4YkQ5eXw==",
"dev": true,
"bin": {
"prettier": "bin/prettier.cjs"
@@ -31368,9 +31368,9 @@
"integrity":
"sha512-vkcDPrRZo1QZLbn5RLGPpg/WmIQ65qoWWhcGKf/b5eplkkarX0m9z8ppCat4mlOqUsWpyNuYgO3VRyrYHSzX5g=="
},
"prettier": {
- "version": "3.0.1",
- "resolved": "https://registry.npmjs.org/prettier/-/prettier-3.0.1.tgz";,
- "integrity":
"sha512-fcOWSnnpCrovBsmFZIGIy9UqK2FaI7Hqax+DIO0A9UxeVoY4iweyaFjS5TavZN97Hfehph0nhsZnjlVKzEQSrQ==",
+ "version": "3.1.0",
+ "resolved": "https://registry.npmjs.org/prettier/-/prettier-3.1.0.tgz";,
+ "integrity":
"sha512-TQLvXjq5IAibjh8EpBIkNKxO749UEWABoiIZehEPiY4GNpVdhaFKqSTu+QrlU6D2dPAfubRmtJTi4K4YkQ5eXw==",
"dev": true
},
"pretty-bytes": {
diff --git a/docs/gremlint/package.json b/docs/gremlint/package.json
index 220e1e4741..30b2f511ce 100644
--- a/docs/gremlint/package.json
+++ b/docs/gremlint/package.json
@@ -53,7 +53,7 @@
"@types/react-dom": "^17.0.11",
"@types/styled-components": "^5.1.26",
"gh-pages": "^6.0.0",
-"prettier": "^3.0.1",
+"prettier": "^3.1.0",
"tslint": "^6.1.3",
"tslint-config-prettier": "^1.18.0"
},
Re: [PR] Bump prettier from 3.0.1 to 3.1.0 in /docs/gremlint [tinkerpop]
Cole-Greer merged PR #2340: URL: https://github.com/apache/tinkerpop/pull/2340 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@tinkerpop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] TINKERPOP-2830 Handle User-Agent from HTTP Requests to server [tinkerpop]
Cole-Greer commented on code in PR #2328:
URL: https://github.com/apache/tinkerpop/pull/2328#discussion_r1394910390
##
gremlin-driver/src/main/java/org/apache/tinkerpop/gremlin/driver/handler/HttpGremlinRequestEncoder.java:
##
@@ -81,7 +90,9 @@ protected void encode(final ChannelHandlerContext
channelHandlerContext, final R
request.headers().add(HttpHeaderNames.CONTENT_TYPE,
"application/json");
request.headers().add(HttpHeaderNames.CONTENT_LENGTH,
payload.length);
request.headers().add(HttpHeaderNames.ACCEPT,
serializer.mimeTypesSupported()[0]);
-
+if (userAgentEnabled) {
+request.headers().add(UserAgent.USER_AGENT_HEADER_NAME,
UserAgent.USER_AGENT);
Review Comment:
`UserAgent.USER_AGENT_HEADER_NAME` (`"User-Agent"`) matches the header used
in websocket requests.
`HttpHeaderNames.USER_AGENT` (`"user-agent"`) may be preferable if we are ok
with the inconsistency.
##
docs/src/upgrade/release-3.6.x.asciidoc:
##
@@ -33,6 +33,9 @@ complete list of all the modifications that are part of this
release.
=== Upgrading for Providers
+The `gremlinRequestEncoder` constructor has been deprecated in favor of one
with an additional parameter `boolean userAgentEnabled`.
Review Comment:
```suggestion
The `HttpGremlinRequestEncoder` constructor has been deprecated in favor of
one with an additional parameter `boolean userAgentEnabled`.
```
##
gremlin-server/src/main/java/org/apache/tinkerpop/gremlin/server/handler/WsAndHttpChannelizerHandler.java:
##
@@ -62,28 +63,35 @@ public void configure(final ChannelPipeline pipeline) {
public void channelRead(final ChannelHandlerContext ctx, final Object obj)
{
final ChannelPipeline pipeline = ctx.pipeline();
if (obj instanceof HttpMessage &&
!WebSocketHandlerUtil.isWebSocket((HttpMessage)obj)) {
-// if the message is for HTTP and not websockets then this handler
injects the endpoint handler in front
-// of the HTTP Aggregator to intercept the HttpMessage. Therefore
the pipeline looks like this at start:
+// If the message is for HTTP and not WS then this handler injects
the HTTP user-agent and endpoint handlers
+// in front of the HTTP aggregator to intercept the HttpMessage.
+// This replaces the WS server protocol handler so that the
pipeline initially looks like this:
//
// IdleStateHandler -> HttpResponseEncoder -> HttpRequestDecoder ->
//WsAndHttpChannelizerHandler -> HttpObjectAggregator ->
+//WebSocketServerProtocolHandler ->
Review Comment:
Was `WebSocketServerProtocolHandler` mistakenly left out of the original
comment?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
(tinkerpop) branch 3.6-dev updated: Bytecode support for HTTP requests (#2336)
This is an automated email from the ASF dual-hosted git repository.
valentyn pushed a commit to branch 3.6-dev
in repository https://gitbox.apache.org/repos/asf/tinkerpop.git
The following commit(s) were added to refs/heads/3.6-dev by this push:
new 8365421f25 Bytecode support for HTTP requests (#2336)
8365421f25 is described below
commit 8365421f2543335b043578096944e2b076e2b867
Author: Valentyn Kahamlyk
AuthorDate: Wed Nov 15 14:35:35 2023 -0800
Bytecode support for HTTP requests (#2336)
Added Gremlin bytecode support for HTTP requests for Java and Python GLV's
without translation to Gremlin script.
Added serialization for entire RequestMessage.
Payload type distinguished by Content-Type header .
---
.../driver/handler/HttpGremlinRequestEncoder.java | 44 ++
.../driver/handler/HttpGremlinResponseDecoder.java | 8 +-
.../ser/GraphSONMessageSerializerV3d0Test.java | 48 +-
.../binary/GraphBinaryMessageSerializerV1Test.java | 27 +++-
.../gremlin/groovy/engine/GremlinExecutor.java | 86 +--
.../gremlin_python/driver/aiohttp/transport.py | 4 +-
.../main/python/gremlin_python/driver/protocol.py | 32 +---
.../driver/test_driver_remote_connection_http.py | 19 +--
.../conf/gremlin-server-rest-modern.yaml | 5 +-
.../server/handler/HttpGremlinEndpointHandler.java | 66 +
.../gremlin/server/handler/HttpHandlerUtil.java| 55 ++-
.../server/util/TextPlainMessageSerializer.java| 7 +-
.../server/GremlinServerHttpIntegrateTest.java | 20 ++-
.../gremlin/server/HttpDriverIntegrateTest.java| 31 +++-
.../server/handler/HttpHandlerUtilTest.java| 165 +
15 files changed, 468 insertions(+), 149 deletions(-)
diff --git
a/gremlin-driver/src/main/java/org/apache/tinkerpop/gremlin/driver/handler/HttpGremlinRequestEncoder.java
b/gremlin-driver/src/main/java/org/apache/tinkerpop/gremlin/driver/handler/HttpGremlinRequestEncoder.java
index 2c271cede8..bdf0f544af 100644
---
a/gremlin-driver/src/main/java/org/apache/tinkerpop/gremlin/driver/handler/HttpGremlinRequestEncoder.java
+++
b/gremlin-driver/src/main/java/org/apache/tinkerpop/gremlin/driver/handler/HttpGremlinRequestEncoder.java
@@ -28,15 +28,12 @@ import io.netty.handler.codec.http.HttpHeaderNames;
import io.netty.handler.codec.http.HttpMethod;
import io.netty.handler.codec.http.HttpVersion;
import org.apache.tinkerpop.gremlin.driver.MessageSerializer;
-import org.apache.tinkerpop.gremlin.driver.Tokens;
import org.apache.tinkerpop.gremlin.driver.exception.ResponseException;
import org.apache.tinkerpop.gremlin.driver.message.RequestMessage;
import org.apache.tinkerpop.gremlin.driver.message.ResponseStatusCode;
+import org.apache.tinkerpop.gremlin.driver.ser.SerTokens;
import org.apache.tinkerpop.gremlin.process.traversal.Bytecode;
-import
org.apache.tinkerpop.gremlin.process.traversal.translator.GroovyTranslator;
-import org.apache.tinkerpop.shaded.jackson.databind.ObjectMapper;
-import java.util.HashMap;
import java.util.List;
import java.util.function.UnaryOperator;
@@ -47,8 +44,6 @@ import java.util.function.UnaryOperator;
public final class HttpGremlinRequestEncoder extends
MessageToMessageEncoder {
private final MessageSerializer serializer;
-private static final ObjectMapper mapper = new ObjectMapper();
-
private final UnaryOperator interceptor;
public HttpGremlinRequestEncoder(final MessageSerializer serializer,
final UnaryOperator interceptor) {
@@ -58,29 +53,22 @@ public final class HttpGremlinRequestEncoder extends
MessageToMessageEncoder objects) throws
Exception {
-try {
-final String gremlin;
-final Object gremlinStringOrBytecode =
requestMessage.getArg(Tokens.ARGS_GREMLIN);
+final String mimeType = serializer.mimeTypesSupported()[0];
+// only GraphSON3 and GraphBinary recommended for serialization of
Bytecode requests
+if (requestMessage.getArg("gremlin") instanceof Bytecode &&
+!mimeType.equals(SerTokens.MIME_GRAPHSON_V3D0) &&
+!mimeType.equals(SerTokens.MIME_GRAPHBINARY_V1D0)) {
+throw new
ResponseException(ResponseStatusCode.REQUEST_ERROR_SERIALIZATION, String.format(
+"An error occurred during serialization of this request
[%s] - it could not be sent to the server - Reason: only GraphSON3 and
GraphBinary recommended for serialization of Bytecode requests, but used %s",
+requestMessage, serializer.getClass().getName()));
+}
-// the gremlin key can contain a Gremlin script or bytecode. if
it's bytecode we can't submit it over
-// http as such. it has to be converted to a script and we can do
that with the Groovy translator.
-final boolean usesBytecode = gremlinStringOrBytecode instanceof
Bytecode;
-if (usesBytecode) {
-gremlin = GroovyTranslator
Re: [PR] Bytecode support for HTTP requests [tinkerpop]
vkagamlyk merged PR #2336: URL: https://github.com/apache/tinkerpop/pull/2336 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@tinkerpop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bytecode support for HTTP requests [tinkerpop]
vkagamlyk commented on PR #2336: URL: https://github.com/apache/tinkerpop/pull/2336#issuecomment-1813373524 VOTE+1 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@tinkerpop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [TINKERPOP-3016] Fix for reading value from different read operation [tinkerpop]
vkagamlyk merged PR #2343: URL: https://github.com/apache/tinkerpop/pull/2343 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@tinkerpop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
(tinkerpop) branch 3.7-dev updated: [TINKERPOP-3016] Fix for reading value from different read operation (#2343)
This is an automated email from the ASF dual-hosted git repository.
valentyn pushed a commit to branch 3.7-dev
in repository https://gitbox.apache.org/repos/asf/tinkerpop.git
The following commit(s) were added to refs/heads/3.7-dev by this push:
new ed4dac94af [TINKERPOP-3016] Fix for reading value from different read
operation (#2343)
ed4dac94af is described below
commit ed4dac94afd8ea4dc1989589b85b98099e9f4b4d
Author: Valentyn Kahamlyk
AuthorDate: Wed Nov 15 14:34:05 2023 -0800
[TINKERPOP-3016] Fix for reading value from different read operation (#2343)
Fix for TinkerTransactionGraph
---
CHANGELOG.asciidoc | 1 +
.../structure/TinkerElementContainer.java | 33 +++-
.../tinkergraph/structure/TinkerTransaction.java | 44 -
.../structure/TinkerTransactionGraph.java | 35 +
.../structure/TinkerTransactionalIndex.java| 4 +-
.../structure/TinkerTransactionGraphTest.java | 45 ++
6 files changed, 116 insertions(+), 46 deletions(-)
diff --git a/CHANGELOG.asciidoc b/CHANGELOG.asciidoc
index 8d21aa7eb0..9f6e0ae6b1 100644
--- a/CHANGELOG.asciidoc
+++ b/CHANGELOG.asciidoc
@@ -49,6 +49,7 @@ This release also includes changes from <> and <
{
/**
* Value of elements updated in current transaction.
*/
-private ThreadLocal transactionUpdatedValue =
ThreadLocal.withInitial(() -> null);
+private final ThreadLocal transactionUpdatedValue =
ThreadLocal.withInitial(() -> null);
/**
* Marker for element deleted in current transaction.
*/
-private ThreadLocal isDeletedInTx = ThreadLocal.withInitial(() ->
false);
+private final ThreadLocal isDeletedInTx =
ThreadLocal.withInitial(() -> false);
/**
* Marker for element modified in current transaction.
*/
-private ThreadLocal isModifiedInTx = ThreadLocal.withInitial(()
-> false);
+private final ThreadLocal isModifiedInTx =
ThreadLocal.withInitial(() -> false);
+
+/**
+ * Marker for element read in current transaction.
+ */
+private final ThreadLocal isReadInTx = ThreadLocal.withInitial(()
-> false);
/**
* Count of usages of container in different transactions.
* Needed to understand whether this element is used in other transactions
or it can be deleted during rollback.
*/
-private AtomicInteger usesInTransactions = new AtomicInteger(0);
+private final AtomicInteger usesInTransactions = new AtomicInteger(0);
/**
* Used to protect container from simultaneous modification in different
transactions.
@@ -82,13 +87,20 @@ final class TinkerElementContainer
{
return element;
}
-public T getWithClone() {
+public T getWithClone(final TinkerTransaction tx) {
if (isDeletedInTx.get()) return null;
if (transactionUpdatedValue.get() != null) return
transactionUpdatedValue.get();
if (isDeleted || null == element) return null;
final T cloned = (T) element.clone();
transactionUpdatedValue.set(cloned);
+
+if (!isReadInTx.get()) {
+isReadInTx.set(true);
+usesInTransactions.incrementAndGet();
+tx.markRead(this);
+}
+
return cloned;
}
@@ -143,7 +155,6 @@ final class TinkerElementContainer
{
* @param tx current transaction
*/
public void touch(final T transactionElement, final TinkerTransaction tx) {
-elementId = transactionElement.id();
if (transactionUpdatedValue.get() == transactionElement &&
isModifiedInTx.get()) return;
setDraft(transactionElement, tx);
@@ -156,10 +167,11 @@ final class TinkerElementContainer {
*/
public void setDraft(final T transactionElement, final TinkerTransaction
tx) {
elementId = transactionElement.id();
-if (!isModifiedInTx.get())
+if (!isModifiedInTx.get()) {
usesInTransactions.incrementAndGet();
+isModifiedInTx.set(true);
+}
transactionUpdatedValue.set(transactionElement);
-isModifiedInTx.set(true);
tx.markChanged(this);
}
@@ -208,6 +220,8 @@ final class TinkerElementContainer
{
usesInTransactions.decrementAndGet();
if (isModifiedInTx.get())
usesInTransactions.decrementAndGet();
+if (isReadInTx.get())
+usesInTransactions.decrementAndGet();
}
/**
@@ -221,10 +235,11 @@ final class TinkerElementContainer {
/**
* Cleanup changes made in the current transaction.
*/
-private void reset() {
+public void reset() {
transactionUpdatedValue.remove();
isDeletedInTx.set(false);
isModifiedInTx.set(false);
+isReadInTx.set(false);
}
/**
diff --git
a/tinkergraph-gremlin/src/main/java/org/apache/tinkerpop/gremlin/tinkergraph/structure/TinkerTransaction.java
Re: [PR] [TINKERPOP-3016] Fix for reading value from different read operation [tinkerpop]
vkagamlyk commented on PR #2343: URL: https://github.com/apache/tinkerpop/pull/2343#issuecomment-1813371071 VOTE+1 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@tinkerpop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
(tinkerpop) 02/02: CTR TINKERPOP-2991 for 4.x
This is an automated email from the ASF dual-hosted git repository.
colegreer pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/tinkerpop.git
commit 5656aff5f8b6e2f9746f05ffc0f2809b2a382c41
Author: Cole-Greer
AuthorDate: Wed Nov 15 14:15:49 2023 -0800
CTR TINKERPOP-2991 for 4.x
Reformat javadoc links to use Java 11 format
---
.../dev/developer/development-environment.asciidoc | 2 +-
docs/src/reference/the-traversal.asciidoc | 434 ++---
2 files changed, 218 insertions(+), 218 deletions(-)
diff --git a/docs/src/dev/developer/development-environment.asciidoc
b/docs/src/dev/developer/development-environment.asciidoc
index 4b653e8dae..d6dbf1836e 100644
--- a/docs/src/dev/developer/development-environment.asciidoc
+++ b/docs/src/dev/developer/development-environment.asciidoc
@@ -121,7 +121,7 @@ an issue when working with SNAPSHOT dependencies.
=== Documentation Environment
The documentation generation process is not Maven-based and uses shell scripts
to process the project's asciidoc. The
-scripts should work on Mac and Linux.
+scripts should work on Mac and Linux. Javadocs should be built using Java 11.
TIP: We recommend performing documentation generation on Linux. For the
scripts to work on Mac, you will need to
install GNU versions of the utility programs via `homebrew`, e.g.`grep`,
`awk`, `sed`, `findutils`, and `diffutils`.
diff --git a/docs/src/reference/the-traversal.asciidoc
b/docs/src/reference/the-traversal.asciidoc
index 5de78ef6ca..c1f3c59dea 100644
--- a/docs/src/reference/the-traversal.asciidoc
+++ b/docs/src/reference/the-traversal.asciidoc
@@ -562,8 +562,8 @@ supports user provided ids.
*Additional References*
-link:++https://tinkerpop.apache.org/javadocs/x.y.z/core/org/apache/tinkerpop/gremlin/process/traversal/dsl/graph/GraphTraversal.html#addE-java.lang.String-++[`addE(String)`],
-link:++https://tinkerpop.apache.org/javadocs/x.y.z/core/org/apache/tinkerpop/gremlin/process/traversal/dsl/graph/GraphTraversal.html#addE-org.apache.tinkerpop.gremlin.process.traversal.Traversal-++[`addE(Traversal)`]
+link:++https://tinkerpop.apache.org/javadocs/x.y.z/core/org/apache/tinkerpop/gremlin/process/traversal/dsl/graph/GraphTraversal.html#addE(java.lang.String)++[`addE(String)`],
+link:++https://tinkerpop.apache.org/javadocs/x.y.z/core/org/apache/tinkerpop/gremlin/process/traversal/dsl/graph/GraphTraversal.html#addE(org.apache.tinkerpop.gremlin.process.traversal.Traversal)++[`addE(Traversal)`]
[[addvertex-step]]
=== AddV Step
@@ -582,9 +582,9 @@ g.V().has('name','nothing').bothE()
*Additional References*
-link:++https://tinkerpop.apache.org/javadocs/x.y.z/core/org/apache/tinkerpop/gremlin/process/traversal/dsl/graph/GraphTraversal.html#addV--++[`addV()`],
-link:++https://tinkerpop.apache.org/javadocs/x.y.z/core/org/apache/tinkerpop/gremlin/process/traversal/dsl/graph/GraphTraversal.html#addV-java.lang.String-++[`addV(String)`],
-link:++https://tinkerpop.apache.org/javadocs/x.y.z/core/org/apache/tinkerpop/gremlin/process/traversal/dsl/graph/GraphTraversal.html#addV-org.apache.tinkerpop.gremlin.process.traversal.Traversal-++[`addV(Traversal)`]
+link:++https://tinkerpop.apache.org/javadocs/x.y.z/core/org/apache/tinkerpop/gremlin/process/traversal/dsl/graph/GraphTraversal.html#addV()++[`addV()`],
+link:++https://tinkerpop.apache.org/javadocs/x.y.z/core/org/apache/tinkerpop/gremlin/process/traversal/dsl/graph/GraphTraversal.html#addV(java.lang.String)++[`addV(String)`],
+link:++https://tinkerpop.apache.org/javadocs/x.y.z/core/org/apache/tinkerpop/gremlin/process/traversal/dsl/graph/GraphTraversal.html#addV(org.apache.tinkerpop.gremlin.process.traversal.Traversal)++[`addV(Traversal)`]
[[aggregate-step]]
=== [[store-step]]Aggregate Step
@@ -654,8 +654,8 @@ g.E().aggregate(local,'x').by('weight').cap('x')
*Additional References*
-link:++https://tinkerpop.apache.org/javadocs/x.y.z/core/org/apache/tinkerpop/gremlin/process/traversal/dsl/graph/GraphTraversal.html#aggregate-java.lang.String-++[`aggregate(String)`],
-link:++https://tinkerpop.apache.org/javadocs/x.y.z/core/org/apache/tinkerpop/gremlin/process/traversal/dsl/graph/GraphTraversal.html#aggregate-org.apache.tinkerpop.gremlin.process.traversal.Scope,java.lang.String-++[`aggregate(Scope,String)`]
+link:++https://tinkerpop.apache.org/javadocs/x.y.z/core/org/apache/tinkerpop/gremlin/process/traversal/dsl/graph/GraphTraversal.html#aggregate(java.lang.String)++[`aggregate(String)`],
+link:++https://tinkerpop.apache.org/javadocs/x.y.z/core/org/apache/tinkerpop/gremlin/process/traversal/dsl/graph/GraphTraversal.html#aggregate(org.apache.tinkerpop.gremlin.process.traversal.Scope,java.lang.String)++[`aggregate(Scope,String)`]
[[all-step]]
=== All Step
@@ -678,7 +678,7 @@ g.V().values('age').fold().all(gt(25)) <1>
*Additional References*
-link:++https://tinkerpop.apache.org/javadocs/x.y.z/core/org/apache/tinkerpop/gremlin/process/traversal/dsl/g
(tinkerpop) 01/02: Merge branch '3.7-dev'
This is an automated email from the ASF dual-hosted git repository. colegreer pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/tinkerpop.git commit a975ec636c13535d85d69323483df4098a462c74 Merge: 5d32698542 a2522432dd Author: Cole-Greer AuthorDate: Wed Nov 15 14:14:36 2023 -0800 Merge branch '3.7-dev'
(tinkerpop) branch master updated (5d32698542 -> 5656aff5f8)
This is an automated email from the ASF dual-hosted git repository. colegreer pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/tinkerpop.git from 5d32698542 Merge branch '3.7-dev' add a5621afc2a CTR TINKERPOP-2991 add 75a75025e1 Merge branch '3.5-dev' into 3.6-dev add 8c95987631 CTR TINKERPOP-2991 for 3.6 add 4bd856a7f2 Merge branch '3.6-dev' into 3.7-dev add a2522432dd CTR TINKERPOP-2991 for 3.7 new a975ec636c Merge branch '3.7-dev' new 5656aff5f8 CTR TINKERPOP-2991 for 4.x The 2 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: .../dev/developer/development-environment.asciidoc | 2 +- docs/src/reference/the-traversal.asciidoc | 434 ++--- 2 files changed, 218 insertions(+), 218 deletions(-)
(tinkerpop) 02/02: CTR TINKERPOP-2991 for 3.7
This is an automated email from the ASF dual-hosted git repository.
colegreer pushed a commit to branch 3.7-dev
in repository https://gitbox.apache.org/repos/asf/tinkerpop.git
commit a2522432ddf2dd0a689d663092113bd7a6e0fd2b
Author: Cole-Greer
AuthorDate: Wed Nov 15 14:11:59 2023 -0800
CTR TINKERPOP-2991 for 3.7
Reformat javadoc links to use Java 11 format
---
.../dev/developer/development-environment.asciidoc | 2 +-
docs/src/reference/the-traversal.asciidoc | 434 ++---
2 files changed, 218 insertions(+), 218 deletions(-)
diff --git a/docs/src/dev/developer/development-environment.asciidoc
b/docs/src/dev/developer/development-environment.asciidoc
index 4b653e8dae..d6dbf1836e 100644
--- a/docs/src/dev/developer/development-environment.asciidoc
+++ b/docs/src/dev/developer/development-environment.asciidoc
@@ -121,7 +121,7 @@ an issue when working with SNAPSHOT dependencies.
=== Documentation Environment
The documentation generation process is not Maven-based and uses shell scripts
to process the project's asciidoc. The
-scripts should work on Mac and Linux.
+scripts should work on Mac and Linux. Javadocs should be built using Java 11.
TIP: We recommend performing documentation generation on Linux. For the
scripts to work on Mac, you will need to
install GNU versions of the utility programs via `homebrew`, e.g.`grep`,
`awk`, `sed`, `findutils`, and `diffutils`.
diff --git a/docs/src/reference/the-traversal.asciidoc
b/docs/src/reference/the-traversal.asciidoc
index 5de78ef6ca..c1f3c59dea 100644
--- a/docs/src/reference/the-traversal.asciidoc
+++ b/docs/src/reference/the-traversal.asciidoc
@@ -562,8 +562,8 @@ supports user provided ids.
*Additional References*
-link:++https://tinkerpop.apache.org/javadocs/x.y.z/core/org/apache/tinkerpop/gremlin/process/traversal/dsl/graph/GraphTraversal.html#addE-java.lang.String-++[`addE(String)`],
-link:++https://tinkerpop.apache.org/javadocs/x.y.z/core/org/apache/tinkerpop/gremlin/process/traversal/dsl/graph/GraphTraversal.html#addE-org.apache.tinkerpop.gremlin.process.traversal.Traversal-++[`addE(Traversal)`]
+link:++https://tinkerpop.apache.org/javadocs/x.y.z/core/org/apache/tinkerpop/gremlin/process/traversal/dsl/graph/GraphTraversal.html#addE(java.lang.String)++[`addE(String)`],
+link:++https://tinkerpop.apache.org/javadocs/x.y.z/core/org/apache/tinkerpop/gremlin/process/traversal/dsl/graph/GraphTraversal.html#addE(org.apache.tinkerpop.gremlin.process.traversal.Traversal)++[`addE(Traversal)`]
[[addvertex-step]]
=== AddV Step
@@ -582,9 +582,9 @@ g.V().has('name','nothing').bothE()
*Additional References*
-link:++https://tinkerpop.apache.org/javadocs/x.y.z/core/org/apache/tinkerpop/gremlin/process/traversal/dsl/graph/GraphTraversal.html#addV--++[`addV()`],
-link:++https://tinkerpop.apache.org/javadocs/x.y.z/core/org/apache/tinkerpop/gremlin/process/traversal/dsl/graph/GraphTraversal.html#addV-java.lang.String-++[`addV(String)`],
-link:++https://tinkerpop.apache.org/javadocs/x.y.z/core/org/apache/tinkerpop/gremlin/process/traversal/dsl/graph/GraphTraversal.html#addV-org.apache.tinkerpop.gremlin.process.traversal.Traversal-++[`addV(Traversal)`]
+link:++https://tinkerpop.apache.org/javadocs/x.y.z/core/org/apache/tinkerpop/gremlin/process/traversal/dsl/graph/GraphTraversal.html#addV()++[`addV()`],
+link:++https://tinkerpop.apache.org/javadocs/x.y.z/core/org/apache/tinkerpop/gremlin/process/traversal/dsl/graph/GraphTraversal.html#addV(java.lang.String)++[`addV(String)`],
+link:++https://tinkerpop.apache.org/javadocs/x.y.z/core/org/apache/tinkerpop/gremlin/process/traversal/dsl/graph/GraphTraversal.html#addV(org.apache.tinkerpop.gremlin.process.traversal.Traversal)++[`addV(Traversal)`]
[[aggregate-step]]
=== [[store-step]]Aggregate Step
@@ -654,8 +654,8 @@ g.E().aggregate(local,'x').by('weight').cap('x')
*Additional References*
-link:++https://tinkerpop.apache.org/javadocs/x.y.z/core/org/apache/tinkerpop/gremlin/process/traversal/dsl/graph/GraphTraversal.html#aggregate-java.lang.String-++[`aggregate(String)`],
-link:++https://tinkerpop.apache.org/javadocs/x.y.z/core/org/apache/tinkerpop/gremlin/process/traversal/dsl/graph/GraphTraversal.html#aggregate-org.apache.tinkerpop.gremlin.process.traversal.Scope,java.lang.String-++[`aggregate(Scope,String)`]
+link:++https://tinkerpop.apache.org/javadocs/x.y.z/core/org/apache/tinkerpop/gremlin/process/traversal/dsl/graph/GraphTraversal.html#aggregate(java.lang.String)++[`aggregate(String)`],
+link:++https://tinkerpop.apache.org/javadocs/x.y.z/core/org/apache/tinkerpop/gremlin/process/traversal/dsl/graph/GraphTraversal.html#aggregate(org.apache.tinkerpop.gremlin.process.traversal.Scope,java.lang.String)++[`aggregate(Scope,String)`]
[[all-step]]
=== All Step
@@ -678,7 +678,7 @@ g.V().values('age').fold().all(gt(25)) <1>
*Additional References*
-link:++https://tinkerpop.apache.org/javadocs/x.y.z/core/org/apache/tinkerpop/gremlin/process/traversal/dsl/
(tinkerpop) 01/02: Merge branch '3.6-dev' into 3.7-dev
This is an automated email from the ASF dual-hosted git repository. colegreer pushed a commit to branch 3.7-dev in repository https://gitbox.apache.org/repos/asf/tinkerpop.git commit 4bd856a7f2ba42839991036a90b053be4337707f Merge: 6dc75c6044 8c95987631 Author: Cole-Greer AuthorDate: Wed Nov 15 14:10:11 2023 -0800 Merge branch '3.6-dev' into 3.7-dev
(tinkerpop) branch 3.7-dev updated (6dc75c6044 -> a2522432dd)
This is an automated email from the ASF dual-hosted git repository. colegreer pushed a change to branch 3.7-dev in repository https://gitbox.apache.org/repos/asf/tinkerpop.git from 6dc75c6044 Update documentation about Groovy any() CTR. add a5621afc2a CTR TINKERPOP-2991 add 75a75025e1 Merge branch '3.5-dev' into 3.6-dev add 8c95987631 CTR TINKERPOP-2991 for 3.6 new 4bd856a7f2 Merge branch '3.6-dev' into 3.7-dev new a2522432dd CTR TINKERPOP-2991 for 3.7 The 2 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: .../dev/developer/development-environment.asciidoc | 2 +- docs/src/reference/the-traversal.asciidoc | 434 ++--- 2 files changed, 218 insertions(+), 218 deletions(-)
(tinkerpop) 02/02: CTR TINKERPOP-2991 for 3.6
This is an automated email from the ASF dual-hosted git repository.
colegreer pushed a commit to branch 3.6-dev
in repository https://gitbox.apache.org/repos/asf/tinkerpop.git
commit 8c959876316129da536aa029b44076213a05e292
Author: Cole-Greer
AuthorDate: Wed Nov 15 14:05:55 2023 -0800
CTR TINKERPOP-2991 for 3.6
Reformat javadoc links to use Java 11 format
---
.../dev/developer/development-environment.asciidoc | 2 +-
docs/src/reference/the-traversal.asciidoc | 378 ++---
2 files changed, 190 insertions(+), 190 deletions(-)
diff --git a/docs/src/dev/developer/development-environment.asciidoc
b/docs/src/dev/developer/development-environment.asciidoc
index 98fdbbd645..251ac7f58a 100644
--- a/docs/src/dev/developer/development-environment.asciidoc
+++ b/docs/src/dev/developer/development-environment.asciidoc
@@ -119,7 +119,7 @@ an issue when working with SNAPSHOT dependencies.
=== Documentation Environment
The documentation generation process is not Maven-based and uses shell scripts
to process the project's asciidoc. The
-scripts should work on Mac and Linux.
+scripts should work on Mac and Linux. Javadocs should be built using Java 11.
TIP: We recommend performing documentation generation on Linux. For the
scripts to work on Mac, you will need to
install GNU versions of the utility programs via `homebrew`, e.g.`grep`,
`awk`, `sed`, `findutils`, and `diffutils`.
diff --git a/docs/src/reference/the-traversal.asciidoc
b/docs/src/reference/the-traversal.asciidoc
index 762f8f47f2..2796f8481d 100644
--- a/docs/src/reference/the-traversal.asciidoc
+++ b/docs/src/reference/the-traversal.asciidoc
@@ -562,8 +562,8 @@ supports user provided ids.
*Additional References*
-link:++https://tinkerpop.apache.org/javadocs/x.y.z/core/org/apache/tinkerpop/gremlin/process/traversal/dsl/graph/GraphTraversal.html#addE-java.lang.String-++[`addE(String)`],
-link:++https://tinkerpop.apache.org/javadocs/x.y.z/core/org/apache/tinkerpop/gremlin/process/traversal/dsl/graph/GraphTraversal.html#addE-org.apache.tinkerpop.gremlin.process.traversal.Traversal-++[`addE(Traversal)`]
+link:++https://tinkerpop.apache.org/javadocs/x.y.z/core/org/apache/tinkerpop/gremlin/process/traversal/dsl/graph/GraphTraversal.html#addE(java.lang.String)++[`addE(String)`],
+link:++https://tinkerpop.apache.org/javadocs/x.y.z/core/org/apache/tinkerpop/gremlin/process/traversal/dsl/graph/GraphTraversal.html#addE(org.apache.tinkerpop.gremlin.process.traversal.Traversal)++[`addE(Traversal)`]
[[addvertex-step]]
=== AddV Step
@@ -582,9 +582,9 @@ g.V().has('name','nothing').bothE()
*Additional References*
-link:++https://tinkerpop.apache.org/javadocs/x.y.z/core/org/apache/tinkerpop/gremlin/process/traversal/dsl/graph/GraphTraversal.html#addV--++[`addV()`],
-link:++https://tinkerpop.apache.org/javadocs/x.y.z/core/org/apache/tinkerpop/gremlin/process/traversal/dsl/graph/GraphTraversal.html#addV-java.lang.String-++[`addV(String)`],
-link:++https://tinkerpop.apache.org/javadocs/x.y.z/core/org/apache/tinkerpop/gremlin/process/traversal/dsl/graph/GraphTraversal.html#addV-org.apache.tinkerpop.gremlin.process.traversal.Traversal-++[`addV(Traversal)`]
+link:++https://tinkerpop.apache.org/javadocs/x.y.z/core/org/apache/tinkerpop/gremlin/process/traversal/dsl/graph/GraphTraversal.html#addV()++[`addV()`],
+link:++https://tinkerpop.apache.org/javadocs/x.y.z/core/org/apache/tinkerpop/gremlin/process/traversal/dsl/graph/GraphTraversal.html#addV(java.lang.String)++[`addV(String)`],
+link:++https://tinkerpop.apache.org/javadocs/x.y.z/core/org/apache/tinkerpop/gremlin/process/traversal/dsl/graph/GraphTraversal.html#addV(org.apache.tinkerpop.gremlin.process.traversal.Traversal)++[`addV(Traversal)`]
[[aggregate-step]]
=== [[store-step]]Aggregate Step
@@ -654,8 +654,8 @@ g.E().aggregate(local,'x').by('weight').cap('x')
*Additional References*
-link:++https://tinkerpop.apache.org/javadocs/x.y.z/core/org/apache/tinkerpop/gremlin/process/traversal/dsl/graph/GraphTraversal.html#aggregate-java.lang.String-++[`aggregate(String)`],
-link:++https://tinkerpop.apache.org/javadocs/x.y.z/core/org/apache/tinkerpop/gremlin/process/traversal/dsl/graph/GraphTraversal.html#aggregate-org.apache.tinkerpop.gremlin.process.traversal.Scope,java.lang.String-++[`aggregate(Scope,String)`]
+link:++https://tinkerpop.apache.org/javadocs/x.y.z/core/org/apache/tinkerpop/gremlin/process/traversal/dsl/graph/GraphTraversal.html#aggregate(java.lang.String)++[`aggregate(String)`],
+link:++https://tinkerpop.apache.org/javadocs/x.y.z/core/org/apache/tinkerpop/gremlin/process/traversal/dsl/graph/GraphTraversal.html#aggregate(org.apache.tinkerpop.gremlin.process.traversal.Scope,java.lang.String)++[`aggregate(Scope,String)`]
[[and-step]]
=== And Step
@@ -687,7 +687,7 @@
g.V().where(outE('created').and().outE('knows')).values('name')
*Additional References*
-link:++https://tinkerpop.apache.org/javadocs/x.y.z/core/org/apache/tinkerpop/gremlin/
(tinkerpop) 01/02: Merge branch '3.5-dev' into 3.6-dev
This is an automated email from the ASF dual-hosted git repository. colegreer pushed a commit to branch 3.6-dev in repository https://gitbox.apache.org/repos/asf/tinkerpop.git commit 75a75025e10584f4577d5c13a8e2e2926640ce25 Merge: d606b0aa3e a5621afc2a Author: Cole-Greer AuthorDate: Wed Nov 15 14:04:02 2023 -0800 Merge branch '3.5-dev' into 3.6-dev
(tinkerpop) branch 3.6-dev updated (d606b0aa3e -> 8c95987631)
This is an automated email from the ASF dual-hosted git repository. colegreer pushed a change to branch 3.6-dev in repository https://gitbox.apache.org/repos/asf/tinkerpop.git from d606b0aa3e Merge branch '3.5-dev' into 3.6-dev add a5621afc2a CTR TINKERPOP-2991 new 75a75025e1 Merge branch '3.5-dev' into 3.6-dev new 8c95987631 CTR TINKERPOP-2991 for 3.6 The 2 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: .../dev/developer/development-environment.asciidoc | 2 +- docs/src/reference/the-traversal.asciidoc | 378 ++--- 2 files changed, 190 insertions(+), 190 deletions(-)
(tinkerpop) branch 3.5-dev updated: CTR TINKERPOP-2991
This is an automated email from the ASF dual-hosted git repository.
colegreer pushed a commit to branch 3.5-dev
in repository https://gitbox.apache.org/repos/asf/tinkerpop.git
The following commit(s) were added to refs/heads/3.5-dev by this push:
new a5621afc2a CTR TINKERPOP-2991
a5621afc2a is described below
commit a5621afc2abd717fffab41c87b68f7b0109ee461
Author: Cole-Greer
AuthorDate: Wed Nov 15 13:59:10 2023 -0800
CTR TINKERPOP-2991
Reformat javadoc links to use Java 11 format
---
.../dev/developer/development-environment.asciidoc | 2 +-
docs/src/reference/the-traversal.asciidoc | 332 ++---
2 files changed, 167 insertions(+), 167 deletions(-)
diff --git a/docs/src/dev/developer/development-environment.asciidoc
b/docs/src/dev/developer/development-environment.asciidoc
index 3c158f20ef..c8f7b00d3f 100644
--- a/docs/src/dev/developer/development-environment.asciidoc
+++ b/docs/src/dev/developer/development-environment.asciidoc
@@ -119,7 +119,7 @@ an issue when working with SNAPSHOT dependencies.
=== Documentation Environment
The documentation generation process is not Maven-based and uses shell scripts
to process the project's asciidoc. The
-scripts should work on Mac and Linux.
+scripts should work on Mac and Linux. Javadocs should be built using Java 11.
TIP: We recommend performing documentation generation on Linux. For the
scripts to work on Mac, you will need to
install GNU versions of the utility programs via `homebrew`, e.g.`grep`,
`awk`, `sed`, `findutils`, and `diffutils`.
diff --git a/docs/src/reference/the-traversal.asciidoc
b/docs/src/reference/the-traversal.asciidoc
index 588a868d82..c81ea7d24f 100644
--- a/docs/src/reference/the-traversal.asciidoc
+++ b/docs/src/reference/the-traversal.asciidoc
@@ -559,8 +559,8 @@ supports user provided ids.
*Additional References*
-link:++https://tinkerpop.apache.org/javadocs/x.y.z/core/org/apache/tinkerpop/gremlin/process/traversal/dsl/graph/GraphTraversal.html#addE-java.lang.String-++[`addE(String)`],
-link:++https://tinkerpop.apache.org/javadocs/x.y.z/core/org/apache/tinkerpop/gremlin/process/traversal/dsl/graph/GraphTraversal.html#addE-org.apache.tinkerpop.gremlin.process.traversal.Traversal-++[`addE(Traversal)`]
+link:++https://tinkerpop.apache.org/javadocs/x.y.z/core/org/apache/tinkerpop/gremlin/process/traversal/dsl/graph/GraphTraversal.html#addE(java.lang.String)++[`addE(String)`],
+link:++https://tinkerpop.apache.org/javadocs/x.y.z/core/org/apache/tinkerpop/gremlin/process/traversal/dsl/graph/GraphTraversal.html#addE(org.apache.tinkerpop.gremlin.process.traversal.Traversal)++[`addE(Traversal)`]
[[addvertex-step]]
=== AddVertex Step
@@ -579,9 +579,9 @@ g.V().has('name','nothing').bothE()
*Additional References*
-link:++https://tinkerpop.apache.org/javadocs/x.y.z/core/org/apache/tinkerpop/gremlin/process/traversal/dsl/graph/GraphTraversal.html#addV--++[`addV()`],
-link:++https://tinkerpop.apache.org/javadocs/x.y.z/core/org/apache/tinkerpop/gremlin/process/traversal/dsl/graph/GraphTraversal.html#addV-java.lang.String-++[`addV(String)`],
-link:++https://tinkerpop.apache.org/javadocs/x.y.z/core/org/apache/tinkerpop/gremlin/process/traversal/dsl/graph/GraphTraversal.html#addV-org.apache.tinkerpop.gremlin.process.traversal.Traversal-++[`addV(Traversal)`]
+link:++https://tinkerpop.apache.org/javadocs/x.y.z/core/org/apache/tinkerpop/gremlin/process/traversal/dsl/graph/GraphTraversal.html#addV()++[`addV()`],
+link:++https://tinkerpop.apache.org/javadocs/x.y.z/core/org/apache/tinkerpop/gremlin/process/traversal/dsl/graph/GraphTraversal.html#addV(java.lang.String)++[`addV(String)`],
+link:++https://tinkerpop.apache.org/javadocs/x.y.z/core/org/apache/tinkerpop/gremlin/process/traversal/dsl/graph/GraphTraversal.html#addV(org.apache.tinkerpop.gremlin.process.traversal.Traversal)++[`addV(Traversal)`]
[[addproperty-step]]
=== AddProperty Step
@@ -607,8 +607,8 @@ g.V(1).properties('friendWeight').valueMap() <3>
*Additional References*
-link:++https://tinkerpop.apache.org/javadocs/x.y.z/core/org/apache/tinkerpop/gremlin/process/traversal/dsl/graph/GraphTraversal.html#property-java.lang.Object-java.lang.Object-java.lang.Object...-++[`property(Object,
Object, Object...)`],
-link:++https://tinkerpop.apache.org/javadocs/x.y.z/core/org/apache/tinkerpop/gremlin/process/traversal/dsl/graph/GraphTraversal.html#property-org.apache.tinkerpop.gremlin.structure.VertexProperty.Cardinality-java.lang.Object-java.lang.Object-java.lang.Object...-++[`property(Cardinality,
Object, Object, Object...)`],
+link:++https://tinkerpop.apache.org/javadocs/x.y.z/core/org/apache/tinkerpop/gremlin/process/traversal/dsl/graph/GraphTraversal.html#property(java.lang.Object,java.lang.Object,java.lang.Object...)++[`property(Object,
Object, Object...)`],
+link:++https://tinkerpop.apache.org/javadocs/x.y.z/core/org/apache/tinkerpop/gremlin/process/traversal/dsl/graph/GraphTraversal.html#property(org.apache.tinke
Re: [PR] [TINKERPOP-2877] Added integer overflow checks [tinkerpop]
vkagamlyk commented on PR #2344: URL: https://github.com/apache/tinkerpop/pull/2344#issuecomment-1813196990 > Does this account for Math Step? exp is a valid function there. there is no exp in `NumberHelper`. Math Step evaluation handled by external library `net.objecthunter.exp4j`, it's out of scope. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@tinkerpop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [TINKERPOP-2877] Added integer overflow checks [tinkerpop]
vkagamlyk commented on code in PR #2344:
URL: https://github.com/apache/tinkerpop/pull/2344#discussion_r1394739829
##
gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/util/NumberHelper.java:
##
@@ -28,10 +28,22 @@
*/
public final class NumberHelper {
+private static byte asByte(int arg) {
+if (arg > Byte.MAX_VALUE || arg < Byte.MIN_VALUE)
+throw new ArithmeticException("byte overflow");
Review Comment:
`Math.addExact` for int and long throw `ArithmeticException`, I do the same
for byte and short
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] [TINKERPOP-3014] Reorder the jcl-over-slf4j dependency to avoid the dependency conflict. [tinkerpop]
Cole-Greer commented on PR #2335: URL: https://github.com/apache/tinkerpop/pull/2335#issuecomment-1813182369 I don't have any issues with the reordering, other than I would prefer to move all slf4j dependencies together to maintain organization. ``` org.slf4j slf4j-api org.slf4j jcl-over-slf4j ``` Other than that I'm fine with the changes, as @vkagamlyk please rebase to an earlier branch to include this fix in an earlier release line. For example, rebase it to 3.6-dev to have this included in both 3.6.6 and 3.7.1. If you only need it in 3.7.1 then it should be targetted to 3.7-dev. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@tinkerpop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [TINKERPOP-2877] Added integer overflow checks [tinkerpop]
kenhuuu commented on code in PR #2344:
URL: https://github.com/apache/tinkerpop/pull/2344#discussion_r1394724371
##
gremlin-core/src/test/java/org/apache/tinkerpop/gremlin/util/NumberHelperTest.java:
##
@@ -96,6 +98,21 @@ public class NumberHelperTest {
new Quartet<>(BigDecimal.ONE, BigDecimal.ONE,
BigDecimal.class, BigDecimal.class)
);
+private final static List> OVERFLOW_CASES
= Arrays.asList(
Review Comment:
Very minor nit: This doesn't need to be done, but ParameterizedTest could
have been used here to split each into individual test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] [TINKERPOP-2877] Added integer overflow checks [tinkerpop]
kenhuuu commented on code in PR #2344:
URL: https://github.com/apache/tinkerpop/pull/2344#discussion_r1394723054
##
gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/util/NumberHelper.java:
##
@@ -28,10 +28,22 @@
*/
public final class NumberHelper {
+private static byte asByte(int arg) {
+if (arg > Byte.MAX_VALUE || arg < Byte.MIN_VALUE)
+throw new ArithmeticException("byte overflow");
Review Comment:
Nit: this technically doesn't qualify for an ArithmeticException but should
probably be an IllegalArgumentException since it is bound checking the incoming
argument.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] [TINKERPOP-2877] Added integer overflow checks [tinkerpop]
kenhuuu commented on PR #2344: URL: https://github.com/apache/tinkerpop/pull/2344#issuecomment-1813169401 Does this account for Math Step? exp is a valid function there. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@tinkerpop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [TINKERPOP-3014] Reorder the jcl-over-slf4j dependency to avoid the dependency conflict. [tinkerpop]
vkagamlyk commented on PR #2335: URL: https://github.com/apache/tinkerpop/pull/2335#issuecomment-1813161130 Hi @HappyHacker123, Would you like to see this changes in 3.5.x, 3.6.x or 3.7.x? You opened PR to `master`, but this branch in not for release now. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@tinkerpop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
(tinkerpop) branch master updated (338b5bde44 -> 5d32698542)
This is an automated email from the ASF dual-hosted git repository. kenhuuu pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/tinkerpop.git from 338b5bde44 Merge branch '3.7-dev' add 6dc75c6044 Update documentation about Groovy any() CTR. new 5d32698542 Merge branch '3.7-dev' The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: docs/src/reference/gremlin-variants.asciidoc | 4 1 file changed, 4 insertions(+)
(tinkerpop) 01/01: Merge branch '3.7-dev'
This is an automated email from the ASF dual-hosted git repository. kenhuuu pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/tinkerpop.git commit 5d3269854216a3c912445c6a68d707040624c979 Merge: 338b5bde44 6dc75c6044 Author: Ken Hu <106191785+kenh...@users.noreply.github.com> AuthorDate: Wed Nov 15 11:35:51 2023 -0800 Merge branch '3.7-dev' docs/src/reference/gremlin-variants.asciidoc | 4 1 file changed, 4 insertions(+)
(tinkerpop) branch 3.7-dev updated: Update documentation about Groovy any() CTR.
This is an automated email from the ASF dual-hosted git repository.
kenhuuu pushed a commit to branch 3.7-dev
in repository https://gitbox.apache.org/repos/asf/tinkerpop.git
The following commit(s) were added to refs/heads/3.7-dev by this push:
new 6dc75c6044 Update documentation about Groovy any() CTR.
6dc75c6044 is described below
commit 6dc75c6044660fc1ee3e25b7b3da7b7eec5eea63
Author: Ken Hu <106191785+kenh...@users.noreply.github.com>
AuthorDate: Wed Nov 15 11:34:57 2023 -0800
Update documentation about Groovy any() CTR.
---
docs/src/reference/gremlin-variants.asciidoc | 4
1 file changed, 4 insertions(+)
diff --git a/docs/src/reference/gremlin-variants.asciidoc
b/docs/src/reference/gremlin-variants.asciidoc
index eacb94c410..fbef16744b 100644
--- a/docs/src/reference/gremlin-variants.asciidoc
+++ b/docs/src/reference/gremlin-variants.asciidoc
@@ -558,6 +558,10 @@ In Groovy, `as`, `in`, and `not` are reserved words.
Gremlin-Groovy does not all
statically from the anonymous traversal `+__+` and therefore, must always be
prefixed with `+__.+` For instance:
`+g.V().as('a').in().as('b').where(__.not(__.as('a').out().as('b')))+`
+Care needs to be taken when using the `any(P)` step as you may accidentally
invoke Groovy's `any(Closure)` method. This
+typically happens when calling `any()` without arguments. You can tell if
Groovy's `any` has been called if the return
+value is a boolean.
+
Since Groovy has access to the full JVM as Java does, it is possible to
construct `Date`-like objects directly, but
the Gremlin language does offer a `datetime()` function that is exposed in the
Gremlin Console and as a function for
Gremlin scripts sent to Gremlin Server. The function accepts the following
forms of dates and times using a default
(tinkerpop) branch master updated (a74410e126 -> 338b5bde44)
This is an automated email from the ASF dual-hosted git repository. colegreer pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/tinkerpop.git from a74410e126 Merge branch '3.7-dev' add 5e46f78edf CTR Fix unresolved merge conflict add 338b5bde44 Merge branch '3.7-dev' No new revisions were added by this update. Summary of changes: gremlin-go/go.mod | 6 -- 1 file changed, 6 deletions(-)
(tinkerpop) branch 3.7-dev updated: CTR Fix unresolved merge conflict
This is an automated email from the ASF dual-hosted git repository. colegreer pushed a commit to branch 3.7-dev in repository https://gitbox.apache.org/repos/asf/tinkerpop.git The following commit(s) were added to refs/heads/3.7-dev by this push: new 5e46f78edf CTR Fix unresolved merge conflict 5e46f78edf is described below commit 5e46f78edfd8594115759ca533ddf095ce15a13a Author: Cole-Greer AuthorDate: Wed Nov 15 10:56:49 2023 -0800 CTR Fix unresolved merge conflict --- gremlin-go/go.mod | 6 -- 1 file changed, 6 deletions(-) diff --git a/gremlin-go/go.mod b/gremlin-go/go.mod index 15993d2875..bc3ad693b9 100644 --- a/gremlin-go/go.mod +++ b/gremlin-go/go.mod @@ -40,12 +40,6 @@ require ( github.com/pmezard/go-difflib v1.0.0 // indirect github.com/spf13/pflag v1.0.5 // indirect github.com/stretchr/objx v0.5.0 // indirect -<<< HEAD -<<< HEAD -=== -=== ->>> 3.6-dev golang.org/x/net v0.17.0 // indirect gopkg.in/yaml.v3 v3.0.1 // indirect ->>> 9e328e36f6 (CTR 8 squashed minor dependabots) )
Re: [PR] [TINKERPOP-3016] Fix for reading value from different read operation [tinkerpop]
Cole-Greer commented on PR #2343: URL: https://github.com/apache/tinkerpop/pull/2343#issuecomment-1813071423 VOTE +1 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@tinkerpop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] TINKERPOP-2830 Handle User-Agent from HTTP Requests to server [tinkerpop]
vkagamlyk commented on code in PR #2328:
URL: https://github.com/apache/tinkerpop/pull/2328#discussion_r1394561929
##
gremlin-server/src/test/java/org/apache/tinkerpop/gremlin/server/GremlinServerIntegrateTest.java:
##
@@ -349,6 +368,28 @@ private void shouldStoreUserAgentInContext() throws
InterruptedException {
}
}
+private void shouldStoreUserAgentInHttpContext() throws
InterruptedException {
+if(server.getChannelizer() instanceof TestChannelizer) {
+TestChannelizer channelizer = (TestChannelizer)
server.getChannelizer();
+channelizer.resetChannelHandlerContext();
+assertNull(getUserAgentIfAvailable());
+final Cluster cluster = TestClientFactory.build()
+
.channelizer(org.apache.tinkerpop.gremlin.driver.Channelizer.HttpChannelizer.class)
+.enableUserAgentOnConnect(true)
+.create();
+final Client client = cluster.connect();
+
+client.submit("g.V()");
+java.lang.Thread.sleep(2000);
+assertEquals(UserAgent.USER_AGENT, getUserAgentIfAvailable());
+client.submit("g.V()");
+java.lang.Thread.sleep(2000);
Review Comment:
Test adds 4 seconds to total test execution time.
Can you replace this condition with checking userAgent every 50-100ms, but
no longer than 2 seconds?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] TINKERPOP-2830 Handle User-Agent from HTTP Requests to server [tinkerpop]
vkagamlyk commented on code in PR #2328:
URL: https://github.com/apache/tinkerpop/pull/2328#discussion_r1394545976
##
gremlin-server/src/main/java/org/apache/tinkerpop/gremlin/server/handler/WsAndHttpChannelizerHandler.java:
##
@@ -62,28 +63,35 @@ public void configure(final ChannelPipeline pipeline) {
public void channelRead(final ChannelHandlerContext ctx, final Object obj)
{
final ChannelPipeline pipeline = ctx.pipeline();
if (obj instanceof HttpMessage &&
!WebSocketHandlerUtil.isWebSocket((HttpMessage)obj)) {
-// if the message is for HTTP and not websockets then this handler
injects the endpoint handler in front
-// of the HTTP Aggregator to intercept the HttpMessage. Therefore
the pipeline looks like this at start:
+// If the message is for HTTP and not WS then this handler injects
the HTTP user-agent and endpoint handlers
+// in front of the HTTP aggregator to intercept the HttpMessage.
+// This replaces the WS server protocol handler so that the
pipeline initially looks like this:
//
// IdleStateHandler -> HttpResponseEncoder -> HttpRequestDecoder ->
//WsAndHttpChannelizerHandler -> HttpObjectAggregator ->
+//WebSocketServerProtocolHandler ->
//WebSocketServerCompressionHandler ->
WebSocketServerProtocolHandshakeHandler -> (more websockets)
//
-// and shifts to (setting aside the authentication condition):
+// and shifts to this (setting aside the authentication condition):
//
// IdleStateHandler -> HttpResponseEncoder -> HttpRequestDecoder ->
//WsAndHttpChannelizerHandler -> HttpObjectAggregator ->
-//HttpGremlinEndpointHandler ->
+//HttpUserAgentHandler -> HttpGremlinEndpointHandler ->
//WebSocketServerCompressionHandler -
WebSocketServerProtocolHandshakeHandler -> (more websockets)
+ChannelHandler test = pipeline.get(PIPELINE_REQUEST_HANDLER);
Review Comment:
nit: remove debug code
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] TINKERPOP-2830 Handle User-Agent from HTTP Requests to server [tinkerpop]
vkagamlyk commented on code in PR #2328:
URL: https://github.com/apache/tinkerpop/pull/2328#discussion_r1394545167
##
gremlin-server/src/main/java/org/apache/tinkerpop/gremlin/server/handler/HttpUserAgentHandler.java:
##
@@ -0,0 +1,71 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.tinkerpop.gremlin.server.handler;
+
+import com.codahale.metrics.MetricRegistry;
+import io.netty.channel.ChannelHandlerContext;
+import io.netty.channel.ChannelInboundHandlerAdapter;
+import io.netty.handler.codec.http.*;
+import io.netty.handler.codec.http.websocketx.WebSocketServerProtocolHandler;
+import io.netty.util.AttributeKey;
+import org.apache.tinkerpop.gremlin.driver.UserAgent;
+import org.apache.tinkerpop.gremlin.server.GremlinServer;
+import org.apache.tinkerpop.gremlin.server.util.MetricManager;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import static
org.apache.tinkerpop.gremlin.server.handler.HttpHandlerUtil.sendError;
+
+public class HttpUserAgentHandler extends ChannelInboundHandlerAdapter {
+/**
+ * This constant caps the number of unique user agents which will be
tracked in the metrics. Any new unique
+ * user agents will be replaced with "other" in the metrics after this cap
has been reached.
+ */
+private static final int MAX_USER_AGENT_METRICS = 1;
+
+private static final Logger logger =
LoggerFactory.getLogger(HttpUserAgentHandler.class);
+public static final AttributeKey USER_AGENT_ATTR_KEY =
AttributeKey.valueOf(UserAgent.USER_AGENT_HEADER_NAME);
+
+@Override
+public void channelRead(final ChannelHandlerContext ctx, Object msg) {
+if (msg instanceof FullHttpMessage) {
+final FullHttpMessage request = (FullHttpMessage) msg;
+if (request.headers().contains(UserAgent.USER_AGENT_HEADER_NAME)) {
Review Comment:
nit: http headers are case-insensitive, so good to double check this code
works with lower-case headers.
https://www.rfc-editor.org/rfc/rfc7540#section-8.1.2
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] TINKERPOP-2830 Handle User-Agent from HTTP Requests to server [tinkerpop]
vkagamlyk commented on code in PR #2328: URL: https://github.com/apache/tinkerpop/pull/2328#discussion_r1394533663 ## gremlin-server/src/main/java/org/apache/tinkerpop/gremlin/server/handler/HttpUserAgentHandler.java: ## @@ -0,0 +1,71 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.tinkerpop.gremlin.server.handler; + +import com.codahale.metrics.MetricRegistry; +import io.netty.channel.ChannelHandlerContext; +import io.netty.channel.ChannelInboundHandlerAdapter; +import io.netty.handler.codec.http.*; Review Comment: nit: wildcard import -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@tinkerpop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] TINKERPOP-2830 Handle User-Agent from HTTP Requests to server [tinkerpop]
vkagamlyk commented on code in PR #2328:
URL: https://github.com/apache/tinkerpop/pull/2328#discussion_r1394533208
##
gremlin-driver/src/main/java/org/apache/tinkerpop/gremlin/driver/handler/HttpGremlinRequestEncoder.java:
##
@@ -81,7 +90,9 @@ protected void encode(final ChannelHandlerContext
channelHandlerContext, final R
request.headers().add(HttpHeaderNames.CONTENT_TYPE,
"application/json");
request.headers().add(HttpHeaderNames.CONTENT_LENGTH,
payload.length);
request.headers().add(HttpHeaderNames.ACCEPT,
serializer.mimeTypesSupported()[0]);
-
+if (userAgentEnabled) {
+request.headers().add(UserAgent.USER_AGENT_HEADER_NAME,
UserAgent.USER_AGENT);
Review Comment:
Is there reason to not use `HttpHeaderNames.USER_AGENT`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] Bump Polly from 7.2.4 to 8.2.0 in /gremlin-dotnet [tinkerpop]
codecov-commenter commented on PR #2346: URL: https://github.com/apache/tinkerpop/pull/2346#issuecomment-1812617645 ## [Codecov](https://app.codecov.io/gh/apache/tinkerpop/pull/2346?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report All modified and coverable lines are covered by tests :white_check_mark: > Comparison is base [(`65ef0ef`)](https://app.codecov.io/gh/apache/tinkerpop/commit/65ef0efb9f6d56f81cadda9e7716d510f0030eaa?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) 69.94% compared to head [(`4f2b513`)](https://app.codecov.io/gh/apache/tinkerpop/pull/2346?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) 69.93%. Additional details and impacted files ```diff @@ Coverage Diff @@ ## 3.5-dev#2346 +/- ## = - Coverage 69.94% 69.93% -0.02% = Files866 24 -842 Lines 41068 3449 -37619 Branches54760-5476 = - Hits 28725 2412 -26313 + Misses 10446 860-9586 + Partials1897 177-1720 ``` [:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/tinkerpop/pull/2346?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). :loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@tinkerpop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump Microsoft.Extensions.Logging.Console from 7.0.0 to 8.0.0 in /gremlin-dotnet [tinkerpop]
codecov-commenter commented on PR #2348: URL: https://github.com/apache/tinkerpop/pull/2348#issuecomment-1812616863 ## [Codecov](https://app.codecov.io/gh/apache/tinkerpop/pull/2348?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report All modified and coverable lines are covered by tests :white_check_mark: > Comparison is base [(`65ef0ef`)](https://app.codecov.io/gh/apache/tinkerpop/commit/65ef0efb9f6d56f81cadda9e7716d510f0030eaa?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) 69.94% compared to head [(`c240246`)](https://app.codecov.io/gh/apache/tinkerpop/pull/2348?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) 69.93%. Additional details and impacted files ```diff @@ Coverage Diff @@ ## 3.5-dev#2348 +/- ## = - Coverage 69.94% 69.93% -0.02% = Files866 24 -842 Lines 41068 3449 -37619 Branches54760-5476 = - Hits 28725 2412 -26313 + Misses 10446 860-9586 + Partials1897 177-1720 ``` [:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/tinkerpop/pull/2348?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). :loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@tinkerpop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump Microsoft.Extensions.Logging.Abstractions from 7.0.1 to 8.0.0 in /gremlin-dotnet [tinkerpop]
codecov-commenter commented on PR #2347: URL: https://github.com/apache/tinkerpop/pull/2347#issuecomment-1812616407 ## [Codecov](https://app.codecov.io/gh/apache/tinkerpop/pull/2347?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report All modified and coverable lines are covered by tests :white_check_mark: > Comparison is base [(`65ef0ef`)](https://app.codecov.io/gh/apache/tinkerpop/commit/65ef0efb9f6d56f81cadda9e7716d510f0030eaa?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) 69.94% compared to head [(`739bb65`)](https://app.codecov.io/gh/apache/tinkerpop/pull/2347?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) 69.93%. Additional details and impacted files ```diff @@ Coverage Diff @@ ## 3.5-dev#2347 +/- ## = - Coverage 69.94% 69.93% -0.02% = Files866 24 -842 Lines 41068 3449 -37619 Branches54760-5476 = - Hits 28725 2412 -26313 + Misses 10446 860-9586 + Partials1897 177-1720 ``` [:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/tinkerpop/pull/2347?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). :loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@tinkerpop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump System.Text.Json from 7.0.3 to 8.0.0 in /gremlin-dotnet [tinkerpop]
codecov-commenter commented on PR #2345: URL: https://github.com/apache/tinkerpop/pull/2345#issuecomment-1812615357 ## [Codecov](https://app.codecov.io/gh/apache/tinkerpop/pull/2345?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report All modified and coverable lines are covered by tests :white_check_mark: > Comparison is base [(`65ef0ef`)](https://app.codecov.io/gh/apache/tinkerpop/commit/65ef0efb9f6d56f81cadda9e7716d510f0030eaa?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) 69.94% compared to head [(`8100465`)](https://app.codecov.io/gh/apache/tinkerpop/pull/2345?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) 69.93%. Additional details and impacted files ```diff @@ Coverage Diff @@ ## 3.5-dev#2345 +/- ## = - Coverage 69.94% 69.93% -0.02% = Files866 24 -842 Lines 41068 3449 -37619 Branches54760-5476 = - Hits 28725 2412 -26313 + Misses 10446 860-9586 + Partials1897 177-1720 ``` [:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/tinkerpop/pull/2345?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). :loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@tinkerpop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
(tinkerpop) branch dependabot/nuget/gremlin-dotnet/3.5-dev/Microsoft.Extensions.Logging.Abstractions-8.0.0 created (now 739bb65959)
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch dependabot/nuget/gremlin-dotnet/3.5-dev/Microsoft.Extensions.Logging.Abstractions-8.0.0 in repository https://gitbox.apache.org/repos/asf/tinkerpop.git at 739bb65959 Bump Microsoft.Extensions.Logging.Abstractions in /gremlin-dotnet No new revisions were added by this update.
(tinkerpop) branch dependabot/nuget/gremlin-dotnet/3.5-dev/Microsoft.Extensions.Logging.Console-8.0.0 created (now c240246440)
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch dependabot/nuget/gremlin-dotnet/3.5-dev/Microsoft.Extensions.Logging.Console-8.0.0 in repository https://gitbox.apache.org/repos/asf/tinkerpop.git at c240246440 Bump Microsoft.Extensions.Logging.Console in /gremlin-dotnet No new revisions were added by this update.
(tinkerpop) branch dependabot/nuget/gremlin-dotnet/3.5-dev/Polly-8.2.0 created (now 4f2b51333b)
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch dependabot/nuget/gremlin-dotnet/3.5-dev/Polly-8.2.0 in repository https://gitbox.apache.org/repos/asf/tinkerpop.git at 4f2b51333b Bump Polly from 7.2.4 to 8.2.0 in /gremlin-dotnet No new revisions were added by this update.
(tinkerpop) branch dependabot/nuget/gremlin-dotnet/3.5-dev/Polly-8.1.0 deleted (was e474213674)
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch dependabot/nuget/gremlin-dotnet/3.5-dev/Polly-8.1.0 in repository https://gitbox.apache.org/repos/asf/tinkerpop.git was e474213674 Bump Polly from 7.2.4 to 8.1.0 in /gremlin-dotnet The revisions that were on this branch are still contained in other references; therefore, this change does not discard any commits from the repository.
[PR] Bump Microsoft.Extensions.Logging.Console from 7.0.0 to 8.0.0 in /gremlin-dotnet [tinkerpop]
dependabot[bot] opened a new pull request, #2348: URL: https://github.com/apache/tinkerpop/pull/2348 Bumps [Microsoft.Extensions.Logging.Console](https://github.com/dotnet/runtime) from 7.0.0 to 8.0.0. Release notes Sourced from https://github.com/dotnet/runtime/releases";>Microsoft.Extensions.Logging.Console's releases. .NET 8.0.0 https://github.com/dotnet/core/releases/tag/v8.0.0";>Release .NET 8.0 RC 2 https://github.com/dotnet/core/releases/tag/v8.0.0-rc.2";>Release .NET 8.0 RC 1 https://github.com/dotnet/core/releases/tag/v8.0.0-rc.1";>Release .NET 8.0 Preview 7 https://github.com/dotnet/core/releases/tag/v8.0.0-preview.7";>Release .NET 8.0 Preview 6 https://github.com/dotnet/core/releases/tag/v8.0.0-preview.6";>Release .NET 8.0 Preview 5 https://github.com/dotnet/core/releases/tag/v8.0.0-preview.5";>Release .NET 8.0 Preview 4 https://github.com/dotnet/core/releases/tag/v8.0.0-preview.4";>Release .NET 8.0 Preview 3 https://github.com/dotnet/core/releases/tag/v8.0.0-preview.3";>Release .NET 8.0 Preview 2 https://github.com/dotnet/core/releases/tag/v8.0.0-preview.2";>Release .NET 8.0 Preview 1 https://github.com/dotnet/core/releases/tag/v8.0.0-preview.1";>Release .NET 7.0.14 https://github.com/dotnet/core/releases/tag/v7.0.14";>Release .NET 7.0.13 https://github.com/dotnet/core/releases/tag/v7.0.13";>Release .NET 7.0.12 https://github.com/dotnet/core/releases/tag/v7.0.12";>Release .NET 7.0.11 https://github.com/dotnet/core/releases/tag/v7.0.11";>Release .NET 7.0.10 https://github.com/dotnet/core/releases/tag/v7.0.10";>Release .NET 7.0.9 https://github.com/dotnet/core/releases/tag/v7.0.9";>Release .NET 7.0.8 https://github.com/dotnet/core/releases/tag/v7.0.8";>Release ... (truncated) Commits https://github.com/dotnet/runtime/commit/5535e31a712343a63f5d7d796cd874e563e5ac14";>5535e31 Merge in 'release/8.0' changes https://github.com/dotnet/runtime/commit/e0bed9410065d5e3554cbfc58e1ea1f1115c13e4";>e0bed94 Update dependencies from https://github.com/dotnet/emsdk";>https://github.com/dotnet/emsdk build 20231030.2 (https://redirect.github.com/dotnet/runtime/issues/9";>#9... https://github.com/dotnet/runtime/commit/0395649aa16820be8a669203b265b0a578e82843";>0395649 Merge in 'release/8.0' changes https://github.com/dotnet/runtime/commit/0a7709af7830b8b6e3e719fcf64f3da56f00e14a";>0a7709a [release/8.0] Bump net7 downlevel version to 7.0.14 (https://redirect.github.com/dotnet/runtime/issues/94192";>#94192) https://github.com/dotnet/runtime/commit/a60d358270ad89a0542d9ec0cb95b7702821a512";>a60d358 Merge in 'release/8.0' changes https://github.com/dotnet/runtime/commit/7331dcb60e0fd7c74a6f7216d61819c9f57a1ade";>7331dcb [8.0] Update MsQuic (https://redirect.github.com/dotnet/runtime/issues/93979";>#93979) https://github.com/dotnet/runtime/commit/17ea9ab3f662320d4ac62d3a2b783b5054ad80bf";>17ea9ab Merged PR 34793: [internal/release/8.0] Merge from public https://github.com/dotnet/runtime/commit/2066e8f214a187fb7d039a519808ca67a11b0368";>2066e8f Apply suggestions from code review https://github.com/dotnet/runtime/commit/59edaad404d1b8e47080015ae8d0787f94c970df";>59edaad [release/8.0] Honor JsonSerializerOptions.PropertyNameCaseInsensitive in prop... https://github.com/dotnet/runtime/commit/488a8a3521610422e8fbe22d5cc66127f3dce3dc";>488a8a3 [release/8.0][wasm] Fix perf pipeline runs (https://redirect.github.com/dotnet/runtime/issues/93888";>#93888) Additional commits viewable in https://github.com/dotnet/runtime/compare/v7.0.0...v8.0.0";>compare view [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it
Re: [PR] Bump Polly from 7.2.4 to 8.1.0 in /gremlin-dotnet [tinkerpop]
dependabot[bot] closed pull request #2320: Bump Polly from 7.2.4 to 8.1.0 in /gremlin-dotnet URL: https://github.com/apache/tinkerpop/pull/2320 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@tinkerpop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] Bump Microsoft.Extensions.Logging.Abstractions from 7.0.1 to 8.0.0 in /gremlin-dotnet [tinkerpop]
dependabot[bot] opened a new pull request, #2347: URL: https://github.com/apache/tinkerpop/pull/2347 Bumps [Microsoft.Extensions.Logging.Abstractions](https://github.com/dotnet/runtime) from 7.0.1 to 8.0.0. Release notes Sourced from https://github.com/dotnet/runtime/releases";>Microsoft.Extensions.Logging.Abstractions's releases. .NET 8.0.0 https://github.com/dotnet/core/releases/tag/v8.0.0";>Release .NET 8.0 RC 2 https://github.com/dotnet/core/releases/tag/v8.0.0-rc.2";>Release .NET 8.0 RC 1 https://github.com/dotnet/core/releases/tag/v8.0.0-rc.1";>Release .NET 8.0 Preview 7 https://github.com/dotnet/core/releases/tag/v8.0.0-preview.7";>Release .NET 8.0 Preview 6 https://github.com/dotnet/core/releases/tag/v8.0.0-preview.6";>Release .NET 8.0 Preview 5 https://github.com/dotnet/core/releases/tag/v8.0.0-preview.5";>Release .NET 8.0 Preview 4 https://github.com/dotnet/core/releases/tag/v8.0.0-preview.4";>Release .NET 8.0 Preview 3 https://github.com/dotnet/core/releases/tag/v8.0.0-preview.3";>Release .NET 8.0 Preview 2 https://github.com/dotnet/core/releases/tag/v8.0.0-preview.2";>Release .NET 8.0 Preview 1 https://github.com/dotnet/core/releases/tag/v8.0.0-preview.1";>Release .NET 7.0.14 https://github.com/dotnet/core/releases/tag/v7.0.14";>Release .NET 7.0.13 https://github.com/dotnet/core/releases/tag/v7.0.13";>Release .NET 7.0.12 https://github.com/dotnet/core/releases/tag/v7.0.12";>Release .NET 7.0.11 https://github.com/dotnet/core/releases/tag/v7.0.11";>Release .NET 7.0.10 https://github.com/dotnet/core/releases/tag/v7.0.10";>Release .NET 7.0.9 https://github.com/dotnet/core/releases/tag/v7.0.9";>Release .NET 7.0.8 https://github.com/dotnet/core/releases/tag/v7.0.8";>Release ... (truncated) Commits https://github.com/dotnet/runtime/commit/5535e31a712343a63f5d7d796cd874e563e5ac14";>5535e31 Merge in 'release/8.0' changes https://github.com/dotnet/runtime/commit/e0bed9410065d5e3554cbfc58e1ea1f1115c13e4";>e0bed94 Update dependencies from https://github.com/dotnet/emsdk";>https://github.com/dotnet/emsdk build 20231030.2 (https://redirect.github.com/dotnet/runtime/issues/9";>#9... https://github.com/dotnet/runtime/commit/0395649aa16820be8a669203b265b0a578e82843";>0395649 Merge in 'release/8.0' changes https://github.com/dotnet/runtime/commit/0a7709af7830b8b6e3e719fcf64f3da56f00e14a";>0a7709a [release/8.0] Bump net7 downlevel version to 7.0.14 (https://redirect.github.com/dotnet/runtime/issues/94192";>#94192) https://github.com/dotnet/runtime/commit/a60d358270ad89a0542d9ec0cb95b7702821a512";>a60d358 Merge in 'release/8.0' changes https://github.com/dotnet/runtime/commit/7331dcb60e0fd7c74a6f7216d61819c9f57a1ade";>7331dcb [8.0] Update MsQuic (https://redirect.github.com/dotnet/runtime/issues/93979";>#93979) https://github.com/dotnet/runtime/commit/17ea9ab3f662320d4ac62d3a2b783b5054ad80bf";>17ea9ab Merged PR 34793: [internal/release/8.0] Merge from public https://github.com/dotnet/runtime/commit/2066e8f214a187fb7d039a519808ca67a11b0368";>2066e8f Apply suggestions from code review https://github.com/dotnet/runtime/commit/59edaad404d1b8e47080015ae8d0787f94c970df";>59edaad [release/8.0] Honor JsonSerializerOptions.PropertyNameCaseInsensitive in prop... https://github.com/dotnet/runtime/commit/488a8a3521610422e8fbe22d5cc66127f3dce3dc";>488a8a3 [release/8.0][wasm] Fix perf pipeline runs (https://redirect.github.com/dotnet/runtime/issues/93888";>#93888) Additional commits viewable in https://github.com/dotnet/runtime/compare/v7.0.1...v8.0.0";>compare view [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabo
Re: [PR] Bump Polly from 7.2.4 to 8.1.0 in /gremlin-dotnet [tinkerpop]
dependabot[bot] commented on PR #2320: URL: https://github.com/apache/tinkerpop/pull/2320#issuecomment-1812597600 Superseded by #2346. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@tinkerpop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] Bump Polly from 7.2.4 to 8.2.0 in /gremlin-dotnet [tinkerpop]
dependabot[bot] opened a new pull request, #2346: URL: https://github.com/apache/tinkerpop/pull/2346 Bumps [Polly](https://github.com/App-vNext/Polly) from 7.2.4 to 8.2.0. Release notes Sourced from https://github.com/App-vNext/Polly/releases";>Polly's releases. 8.2.0 What's Changed Prepare for 8.2.0 release by https://github.com/martincostello";>@martincostello in https://redirect.github.com/App-vNext/Polly/pull/1758";>App-vNext/Polly#1758 [Docs] Add circuit breaker to the migration guide by https://github.com/peter-csala";>@peter-csala in https://redirect.github.com/App-vNext/Polly/pull/1764";>App-vNext/Polly#1764 [Docs] Improve timeout docs by https://github.com/martintmk";>@martintmk in https://redirect.github.com/App-vNext/Polly/pull/1767";>App-vNext/Polly#1767 [Docs] Minor cleanups by https://github.com/peter-csala";>@peter-csala in https://redirect.github.com/App-vNext/Polly/pull/1768";>App-vNext/Polly#1768 [Docs] Revise migration guide 3/3 by https://github.com/peter-csala";>@peter-csala in https://redirect.github.com/App-vNext/Polly/pull/1775";>App-vNext/Polly#1775 Calculated break duration for Circuit breaker by https://github.com/atawLee";>@atawLee in https://redirect.github.com/App-vNext/Polly/pull/1776";>App-vNext/Polly#1776 Disable GitHub publishing by https://github.com/martincostello";>@martincostello in https://redirect.github.com/App-vNext/Polly/pull/1781";>App-vNext/Polly#1781 [Docs] Small cleanup and improvements by https://github.com/martintmk";>@martintmk in https://redirect.github.com/App-vNext/Polly/pull/1782";>App-vNext/Polly#1782 Add test that verifies overriding by using ConfigureTelemetry by https://github.com/martintmk";>@martintmk in https://redirect.github.com/App-vNext/Polly/pull/1787";>App-vNext/Polly#1787 Remove GitHub Packages publishing by https://github.com/martincostello";>@martincostello in https://redirect.github.com/App-vNext/Polly/pull/1789";>App-vNext/Polly#1789 Allow concurrent PR docs builds by https://github.com/martincostello";>@martincostello in https://redirect.github.com/App-vNext/Polly/pull/1795";>App-vNext/Polly#1795 Update to .NET 8 SDK by https://github.com/martincostello";>@martincostello in https://redirect.github.com/App-vNext/Polly/pull/1738";>App-vNext/Polly#1738 Add support for .NET 8 by https://github.com/martintmk";>@martintmk in https://redirect.github.com/App-vNext/Polly/pull/1144";>App-vNext/Polly#1144 New Contributors https://github.com/atawLee";>@atawLee made their first contribution in https://redirect.github.com/App-vNext/Polly/pull/1776";>App-vNext/Polly#1776 Full Changelog: https://github.com/App-vNext/Polly/compare/8.1.0...8.2.0";>https://github.com/App-vNext/Polly/compare/8.1.0...8.2.0 8.1.0 Highlights 🐛 Fix issues that prevented the new Polly assemblies from the v8 release from being used in AoT scenarios - thanks to https://github.com/davidfowl";>@davidfowl for reporting this issue (https://redirect.github.com/App-vNext/Polly/issues/1732";>#1732) 🧰 Added new API to make ResilienceContextPool settable via DI from https://github.com/cmeyertons";>@cmeyertons (https://redirect.github.com/App-vNext/Polly/issues/1693";>#1693) 📖 Lots of great documentation updates from https://github.com/peter-csala";>@peter-csala and https://github.com/IEvangelist";>@IEvangelist What's Changed Only show stable versions in README by https://github.com/martincostello";>@martincostello in https://redirect.github.com/App-vNext/Polly/pull/1649";>App-vNext/Polly#1649 Update samples to stable release by https://github.com/martincostello";>@martincostello in https://redirect.github.com/App-vNext/Polly/pull/1647";>App-vNext/Polly#1647 v8 Release - commit and validate public API by https://github.com/martintmk";>@martintmk in https://redirect.github.com/App-vNext/Polly/pull/1632";>App-vNext/Polly#1632 Fix documentation comment for CB's MinimumThroughput by https://github.com/peter-csala";>@peter-csala in https://redirect.github.com/App-vNext/Polly/pull/1654";>App-vNext/Polly#1654 Bump SonarAnalyzer.CSharp from 9.10.0.77988 to 9.11.0.78383 by https://github.com/dependabot";>@dependabot in https://redirect.github.com/App-vNext/Polly/pull/1658";>App-vNext/Polly#1658 Bump github/codeql-action from 2.21.8 to 2.21.9 by https://github.com/dependabot";>@dependabot in https://redirect.github.com/App-vNext/Polly/pull/1661";>App-vNext/Polly#1661 Bump martincostello/update-dotnet-sdk from 2.5.0 to 3.0.0 by https://github.com/dependabot";>@dependabot in https://redirect.github.com/App-vNext/Polly/pull/1659";>App-vNext/Polly#1659 Bump actions/checkout from 4.0.0 to 4.1.0 by https://github.com/dependabot";>@dependabot in https://redirect.github.com/App-vNext/Polly/pull/1660";>App-vNext/Polly#1660 Docs tweaks by https://github.com/martincostello";>@martincostello in https://redirect.github.com/A
(tinkerpop) branch dependabot/nuget/gremlin-dotnet/3.5-dev/System.Text.Json-8.0.0 created (now 8100465342)
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch dependabot/nuget/gremlin-dotnet/3.5-dev/System.Text.Json-8.0.0 in repository https://gitbox.apache.org/repos/asf/tinkerpop.git at 8100465342 Bump System.Text.Json from 7.0.3 to 8.0.0 in /gremlin-dotnet No new revisions were added by this update.
[PR] Bump System.Text.Json from 7.0.3 to 8.0.0 in /gremlin-dotnet [tinkerpop]
dependabot[bot] opened a new pull request, #2345: URL: https://github.com/apache/tinkerpop/pull/2345 Bumps [System.Text.Json](https://github.com/dotnet/runtime) from 7.0.3 to 8.0.0. Release notes Sourced from https://github.com/dotnet/runtime/releases";>System.Text.Json's releases. .NET 8.0.0 https://github.com/dotnet/core/releases/tag/v8.0.0";>Release .NET 8.0 RC 2 https://github.com/dotnet/core/releases/tag/v8.0.0-rc.2";>Release .NET 8.0 RC 1 https://github.com/dotnet/core/releases/tag/v8.0.0-rc.1";>Release .NET 8.0 Preview 7 https://github.com/dotnet/core/releases/tag/v8.0.0-preview.7";>Release .NET 8.0 Preview 6 https://github.com/dotnet/core/releases/tag/v8.0.0-preview.6";>Release .NET 8.0 Preview 5 https://github.com/dotnet/core/releases/tag/v8.0.0-preview.5";>Release .NET 8.0 Preview 4 https://github.com/dotnet/core/releases/tag/v8.0.0-preview.4";>Release .NET 8.0 Preview 3 https://github.com/dotnet/core/releases/tag/v8.0.0-preview.3";>Release .NET 8.0 Preview 2 https://github.com/dotnet/core/releases/tag/v8.0.0-preview.2";>Release .NET 8.0 Preview 1 https://github.com/dotnet/core/releases/tag/v8.0.0-preview.1";>Release .NET 7.0.14 https://github.com/dotnet/core/releases/tag/v7.0.14";>Release .NET 7.0.13 https://github.com/dotnet/core/releases/tag/v7.0.13";>Release .NET 7.0.12 https://github.com/dotnet/core/releases/tag/v7.0.12";>Release .NET 7.0.11 https://github.com/dotnet/core/releases/tag/v7.0.11";>Release .NET 7.0.10 https://github.com/dotnet/core/releases/tag/v7.0.10";>Release .NET 7.0.9 https://github.com/dotnet/core/releases/tag/v7.0.9";>Release .NET 7.0.8 https://github.com/dotnet/core/releases/tag/v7.0.8";>Release ... (truncated) Commits https://github.com/dotnet/runtime/commit/5535e31a712343a63f5d7d796cd874e563e5ac14";>5535e31 Merge in 'release/8.0' changes https://github.com/dotnet/runtime/commit/e0bed9410065d5e3554cbfc58e1ea1f1115c13e4";>e0bed94 Update dependencies from https://github.com/dotnet/emsdk";>https://github.com/dotnet/emsdk build 20231030.2 (https://redirect.github.com/dotnet/runtime/issues/9";>#9... https://github.com/dotnet/runtime/commit/0395649aa16820be8a669203b265b0a578e82843";>0395649 Merge in 'release/8.0' changes https://github.com/dotnet/runtime/commit/0a7709af7830b8b6e3e719fcf64f3da56f00e14a";>0a7709a [release/8.0] Bump net7 downlevel version to 7.0.14 (https://redirect.github.com/dotnet/runtime/issues/94192";>#94192) https://github.com/dotnet/runtime/commit/a60d358270ad89a0542d9ec0cb95b7702821a512";>a60d358 Merge in 'release/8.0' changes https://github.com/dotnet/runtime/commit/7331dcb60e0fd7c74a6f7216d61819c9f57a1ade";>7331dcb [8.0] Update MsQuic (https://redirect.github.com/dotnet/runtime/issues/93979";>#93979) https://github.com/dotnet/runtime/commit/17ea9ab3f662320d4ac62d3a2b783b5054ad80bf";>17ea9ab Merged PR 34793: [internal/release/8.0] Merge from public https://github.com/dotnet/runtime/commit/2066e8f214a187fb7d039a519808ca67a11b0368";>2066e8f Apply suggestions from code review https://github.com/dotnet/runtime/commit/59edaad404d1b8e47080015ae8d0787f94c970df";>59edaad [release/8.0] Honor JsonSerializerOptions.PropertyNameCaseInsensitive in prop... https://github.com/dotnet/runtime/commit/488a8a3521610422e8fbe22d5cc66127f3dce3dc";>488a8a3 [release/8.0][wasm] Fix perf pipeline runs (https://redirect.github.com/dotnet/runtime/issues/93888";>#93888) Additional commits viewable in https://github.com/dotnet/runtime/compare/v7.0.3...v8.0.0";>compare view [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
(tinkerpop) branch master updated (b19b5b251a -> a74410e126)
This is an automated email from the ASF dual-hosted git repository. florianhockmann pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/tinkerpop.git from b19b5b251a Merge branch '3.7-dev' add 402af11cd6 Increase delay in test as it's flaky on GHA CTR add 4613832ac4 Bump xunit from 2.5.3 to 2.6.1 in /gremlin-dotnet add afd7066d72 Merge branch 'dependabot/nuget/gremlin-dotnet/3.5-dev/xunit-2.6.1' into 3.5-dev add 62d69516c0 Bump Microsoft.Extensions.Configuration.Json in /gremlin-dotnet add 28294bb2ec Remove unnecessary explicit test dependency add 65ef0efb9f Merge branch 'dependabot/nuget/gremlin-dotnet/3.5-dev/Microsoft.Extensions.Configuration.Json-8.0.0' into 3.5-dev add d606b0aa3e Merge branch '3.5-dev' into 3.6-dev add 084457d09b Merge branch '3.6-dev' into 3.7-dev new a74410e126 Merge branch '3.7-dev' The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: .../Gremlin.Net.IntegrationTest/Gremlin.Net.IntegrationTest.csproj | 5 ++--- .../Gremlin.Net.Template.IntegrationTest.csproj | 2 +- .../test/Gremlin.Net.UnitTest/Driver/ConnectionPoolTests.cs | 2 +- gremlin-dotnet/test/Gremlin.Net.UnitTest/Gremlin.Net.UnitTest.csproj | 2 +- .../Structure/IO/GraphBinary/GraphBinaryTests.cs | 2 +- .../Structure/IO/GraphSON/GraphSONReaderTests.cs | 4 ++-- 6 files changed, 8 insertions(+), 9 deletions(-)
(tinkerpop) branch dependabot/nuget/gremlin-dotnet/3.5-dev/xunit-2.6.1 deleted (was 4613832ac4)
This is an automated email from the ASF dual-hosted git repository. florianhockmann pushed a change to branch dependabot/nuget/gremlin-dotnet/3.5-dev/xunit-2.6.1 in repository https://gitbox.apache.org/repos/asf/tinkerpop.git was 4613832ac4 Bump xunit from 2.5.3 to 2.6.1 in /gremlin-dotnet The revisions that were on this branch are still contained in other references; therefore, this change does not discard any commits from the repository.
Re: [PR] Bump xunit from 2.5.3 to 2.6.1 in /gremlin-dotnet [tinkerpop]
FlorianHockmann merged PR #2324: URL: https://github.com/apache/tinkerpop/pull/2324 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@tinkerpop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
(tinkerpop) branch 3.5-dev updated (6c26dfd5a6 -> 65ef0efb9f)
This is an automated email from the ASF dual-hosted git repository. florianhockmann pushed a change to branch 3.5-dev in repository https://gitbox.apache.org/repos/asf/tinkerpop.git from 6c26dfd5a6 Merge branch 'dependabot/nuget/gremlin-dotnet/3.5-dev/BenchmarkDotNet-0.13.10' into 3.5-dev add 402af11cd6 Increase delay in test as it's flaky on GHA CTR add 4613832ac4 Bump xunit from 2.5.3 to 2.6.1 in /gremlin-dotnet add afd7066d72 Merge branch 'dependabot/nuget/gremlin-dotnet/3.5-dev/xunit-2.6.1' into 3.5-dev add 62d69516c0 Bump Microsoft.Extensions.Configuration.Json in /gremlin-dotnet add 28294bb2ec Remove unnecessary explicit test dependency add 65ef0efb9f Merge branch 'dependabot/nuget/gremlin-dotnet/3.5-dev/Microsoft.Extensions.Configuration.Json-8.0.0' into 3.5-dev No new revisions were added by this update. Summary of changes: .../Gremlin.Net.IntegrationTest/Gremlin.Net.IntegrationTest.csproj | 5 ++--- .../Gremlin.Net.Template.IntegrationTest.csproj | 2 +- .../test/Gremlin.Net.UnitTest/Driver/ConnectionPoolTests.cs | 2 +- gremlin-dotnet/test/Gremlin.Net.UnitTest/Gremlin.Net.UnitTest.csproj | 2 +- .../Structure/IO/GraphBinary/GraphBinaryTests.cs | 2 +- .../Structure/IO/GraphSON/GraphSONReaderTests.cs | 4 ++-- 6 files changed, 8 insertions(+), 9 deletions(-)
(tinkerpop) branch dependabot/nuget/gremlin-dotnet/3.5-dev/Microsoft.Extensions.Configuration.Json-8.0.0 deleted (was 28294bb2ec)
This is an automated email from the ASF dual-hosted git repository. florianhockmann pushed a change to branch dependabot/nuget/gremlin-dotnet/3.5-dev/Microsoft.Extensions.Configuration.Json-8.0.0 in repository https://gitbox.apache.org/repos/asf/tinkerpop.git was 28294bb2ec Remove unnecessary explicit test dependency The revisions that were on this branch are still contained in other references; therefore, this change does not discard any commits from the repository.
(tinkerpop) 01/01: Merge branch '3.7-dev'
This is an automated email from the ASF dual-hosted git repository. florianhockmann pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/tinkerpop.git commit a74410e126b401bf585a078e6a87032f7bc069bb Merge: b19b5b251a 084457d09b Author: Florian Hockmann AuthorDate: Wed Nov 15 14:44:45 2023 +0100 Merge branch '3.7-dev' .../Gremlin.Net.IntegrationTest/Gremlin.Net.IntegrationTest.csproj | 5 ++--- .../Gremlin.Net.Template.IntegrationTest.csproj | 2 +- .../test/Gremlin.Net.UnitTest/Driver/ConnectionPoolTests.cs | 2 +- gremlin-dotnet/test/Gremlin.Net.UnitTest/Gremlin.Net.UnitTest.csproj | 2 +- .../Structure/IO/GraphBinary/GraphBinaryTests.cs | 2 +- .../Structure/IO/GraphSON/GraphSONReaderTests.cs | 4 ++-- 6 files changed, 8 insertions(+), 9 deletions(-)
Re: [PR] Bump Microsoft.Extensions.Configuration.Json from 7.0.0 to 8.0.0 in /gremlin-dotnet [tinkerpop]
FlorianHockmann merged PR #2342: URL: https://github.com/apache/tinkerpop/pull/2342 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@tinkerpop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
(tinkerpop) branch 3.6-dev updated (7fc212b6e7 -> d606b0aa3e)
This is an automated email from the ASF dual-hosted git repository. florianhockmann pushed a change to branch 3.6-dev in repository https://gitbox.apache.org/repos/asf/tinkerpop.git from 7fc212b6e7 Merge branch '3.5-dev' into 3.6-dev add 402af11cd6 Increase delay in test as it's flaky on GHA CTR add 4613832ac4 Bump xunit from 2.5.3 to 2.6.1 in /gremlin-dotnet add afd7066d72 Merge branch 'dependabot/nuget/gremlin-dotnet/3.5-dev/xunit-2.6.1' into 3.5-dev add 62d69516c0 Bump Microsoft.Extensions.Configuration.Json in /gremlin-dotnet add 28294bb2ec Remove unnecessary explicit test dependency add 65ef0efb9f Merge branch 'dependabot/nuget/gremlin-dotnet/3.5-dev/Microsoft.Extensions.Configuration.Json-8.0.0' into 3.5-dev add d606b0aa3e Merge branch '3.5-dev' into 3.6-dev No new revisions were added by this update. Summary of changes: .../Gremlin.Net.IntegrationTest/Gremlin.Net.IntegrationTest.csproj | 5 ++--- .../Gremlin.Net.Template.IntegrationTest.csproj | 2 +- .../test/Gremlin.Net.UnitTest/Driver/ConnectionPoolTests.cs | 2 +- gremlin-dotnet/test/Gremlin.Net.UnitTest/Gremlin.Net.UnitTest.csproj | 2 +- .../Structure/IO/GraphBinary/GraphBinaryTests.cs | 2 +- .../Structure/IO/GraphSON/GraphSONReaderTests.cs | 4 ++-- 6 files changed, 8 insertions(+), 9 deletions(-)
(tinkerpop) branch 3.7-dev updated (8cf13fea59 -> 084457d09b)
This is an automated email from the ASF dual-hosted git repository. florianhockmann pushed a change to branch 3.7-dev in repository https://gitbox.apache.org/repos/asf/tinkerpop.git from 8cf13fea59 Merge branch '3.6-dev' into 3.7-dev add 402af11cd6 Increase delay in test as it's flaky on GHA CTR add 4613832ac4 Bump xunit from 2.5.3 to 2.6.1 in /gremlin-dotnet add afd7066d72 Merge branch 'dependabot/nuget/gremlin-dotnet/3.5-dev/xunit-2.6.1' into 3.5-dev add 62d69516c0 Bump Microsoft.Extensions.Configuration.Json in /gremlin-dotnet add 28294bb2ec Remove unnecessary explicit test dependency add 65ef0efb9f Merge branch 'dependabot/nuget/gremlin-dotnet/3.5-dev/Microsoft.Extensions.Configuration.Json-8.0.0' into 3.5-dev add d606b0aa3e Merge branch '3.5-dev' into 3.6-dev add 084457d09b Merge branch '3.6-dev' into 3.7-dev No new revisions were added by this update. Summary of changes: .../Gremlin.Net.IntegrationTest/Gremlin.Net.IntegrationTest.csproj | 5 ++--- .../Gremlin.Net.Template.IntegrationTest.csproj | 2 +- .../test/Gremlin.Net.UnitTest/Driver/ConnectionPoolTests.cs | 2 +- gremlin-dotnet/test/Gremlin.Net.UnitTest/Gremlin.Net.UnitTest.csproj | 2 +- .../Structure/IO/GraphBinary/GraphBinaryTests.cs | 2 +- .../Structure/IO/GraphSON/GraphSONReaderTests.cs | 4 ++-- 6 files changed, 8 insertions(+), 9 deletions(-)
(tinkerpop) branch dependabot/nuget/gremlin-dotnet/3.5-dev/xunit-2.6.1 updated (5a35850614 -> 4613832ac4)
This is an automated email from the ASF dual-hosted git repository. florianhockmann pushed a change to branch dependabot/nuget/gremlin-dotnet/3.5-dev/xunit-2.6.1 in repository https://gitbox.apache.org/repos/asf/tinkerpop.git omit 5a35850614 Bump xunit from 2.5.3 to 2.6.1 in /gremlin-dotnet add 9e328e36f6 CTR 8 squashed minor dependabots add 4b470dc41a Bump Microsoft.NET.Test.Sdk from 17.7.2 to 17.8.0 in /gremlin-dotnet add 53c12e5f86 Merge branch 'dependabot/nuget/gremlin-dotnet/3.5-dev/Microsoft.NET.Test.Sdk-17.8.0' into 3.5-dev add 9b6ca18e91 Bump BenchmarkDotNet from 0.13.9 to 0.13.10 in /gremlin-dotnet add 6c26dfd5a6 Merge branch 'dependabot/nuget/gremlin-dotnet/3.5-dev/BenchmarkDotNet-0.13.10' into 3.5-dev add 4613832ac4 Bump xunit from 2.5.3 to 2.6.1 in /gremlin-dotnet This update added new revisions after undoing existing revisions. That is to say, some revisions that were in the old version of the branch are not in the new version. This situation occurs when a user --force pushes a change and generates a repository containing something like this: * -- * -- B -- O -- O -- O (5a35850614) \ N -- N -- N refs/heads/dependabot/nuget/gremlin-dotnet/3.5-dev/xunit-2.6.1 (4613832ac4) You should already have received notification emails for all of the O revisions, and so the following emails describe only the N revisions from the common base, B. Any revisions marked "omit" are not gone; other references still refer to them. Any revisions marked "discard" are gone forever. No new revisions were added by this update. Summary of changes: .../Gremlin.Net.Benchmarks.csproj | 2 +- .../Gremlin.Net.IntegrationTest.csproj | 2 +- .../Gremlin.Net.Template.IntegrationTest.csproj| 2 +- .../Gremlin.Net.UnitTest.csproj| 2 +- .../Structure/IO/GraphBinary/GraphBinaryTests.cs | 2 +- gremlin-go/go.mod | 9 ++- gremlin-go/go.sum | 18 +++-- .../gremlin-javascript/package-lock.json | 92 +++--- gremlint/package-lock.json | 40 +- 9 files changed, 86 insertions(+), 83 deletions(-)
(tinkerpop) branch dependabot/nuget/gremlin-dotnet/3.5-dev/BenchmarkDotNet-0.13.10 deleted (was 9b6ca18e91)
This is an automated email from the ASF dual-hosted git repository. florianhockmann pushed a change to branch dependabot/nuget/gremlin-dotnet/3.5-dev/BenchmarkDotNet-0.13.10 in repository https://gitbox.apache.org/repos/asf/tinkerpop.git was 9b6ca18e91 Bump BenchmarkDotNet from 0.13.9 to 0.13.10 in /gremlin-dotnet The revisions that were on this branch are still contained in other references; therefore, this change does not discard any commits from the repository.
(tinkerpop) branch 3.5-dev updated (9e328e36f6 -> 6c26dfd5a6)
This is an automated email from the ASF dual-hosted git repository. florianhockmann pushed a change to branch 3.5-dev in repository https://gitbox.apache.org/repos/asf/tinkerpop.git from 9e328e36f6 CTR 8 squashed minor dependabots add 4b470dc41a Bump Microsoft.NET.Test.Sdk from 17.7.2 to 17.8.0 in /gremlin-dotnet add 53c12e5f86 Merge branch 'dependabot/nuget/gremlin-dotnet/3.5-dev/Microsoft.NET.Test.Sdk-17.8.0' into 3.5-dev add 9b6ca18e91 Bump BenchmarkDotNet from 0.13.9 to 0.13.10 in /gremlin-dotnet add 6c26dfd5a6 Merge branch 'dependabot/nuget/gremlin-dotnet/3.5-dev/BenchmarkDotNet-0.13.10' into 3.5-dev No new revisions were added by this update. Summary of changes: .../test/Gremlin.Net.Benchmarks/Gremlin.Net.Benchmarks.csproj | 2 +- .../test/Gremlin.Net.IntegrationTest/Gremlin.Net.IntegrationTest.csproj | 2 +- .../Gremlin.Net.Template.IntegrationTest.csproj | 2 +- gremlin-dotnet/test/Gremlin.Net.UnitTest/Gremlin.Net.UnitTest.csproj| 2 +- 4 files changed, 4 insertions(+), 4 deletions(-)
(tinkerpop) branch 3.7-dev updated (287f60a79e -> 8cf13fea59)
This is an automated email from the ASF dual-hosted git repository. florianhockmann pushed a change to branch 3.7-dev in repository https://gitbox.apache.org/repos/asf/tinkerpop.git from 287f60a79e Merge branch '3.6-dev' into 3.7-dev add 4b470dc41a Bump Microsoft.NET.Test.Sdk from 17.7.2 to 17.8.0 in /gremlin-dotnet add 53c12e5f86 Merge branch 'dependabot/nuget/gremlin-dotnet/3.5-dev/Microsoft.NET.Test.Sdk-17.8.0' into 3.5-dev add 9b6ca18e91 Bump BenchmarkDotNet from 0.13.9 to 0.13.10 in /gremlin-dotnet add 6c26dfd5a6 Merge branch 'dependabot/nuget/gremlin-dotnet/3.5-dev/BenchmarkDotNet-0.13.10' into 3.5-dev add 7fc212b6e7 Merge branch '3.5-dev' into 3.6-dev add 8cf13fea59 Merge branch '3.6-dev' into 3.7-dev No new revisions were added by this update. Summary of changes: .../test/Gremlin.Net.Benchmarks/Gremlin.Net.Benchmarks.csproj | 2 +- .../test/Gremlin.Net.IntegrationTest/Gremlin.Net.IntegrationTest.csproj | 2 +- .../Gremlin.Net.Template.IntegrationTest.csproj | 2 +- gremlin-dotnet/test/Gremlin.Net.UnitTest/Gremlin.Net.UnitTest.csproj| 2 +- 4 files changed, 4 insertions(+), 4 deletions(-)
(tinkerpop) branch 3.6-dev updated (dc01710e09 -> 7fc212b6e7)
This is an automated email from the ASF dual-hosted git repository. florianhockmann pushed a change to branch 3.6-dev in repository https://gitbox.apache.org/repos/asf/tinkerpop.git from dc01710e09 Merge branch '3.5-dev' into 3.6-dev add 4b470dc41a Bump Microsoft.NET.Test.Sdk from 17.7.2 to 17.8.0 in /gremlin-dotnet add 53c12e5f86 Merge branch 'dependabot/nuget/gremlin-dotnet/3.5-dev/Microsoft.NET.Test.Sdk-17.8.0' into 3.5-dev add 9b6ca18e91 Bump BenchmarkDotNet from 0.13.9 to 0.13.10 in /gremlin-dotnet add 6c26dfd5a6 Merge branch 'dependabot/nuget/gremlin-dotnet/3.5-dev/BenchmarkDotNet-0.13.10' into 3.5-dev add 7fc212b6e7 Merge branch '3.5-dev' into 3.6-dev No new revisions were added by this update. Summary of changes: .../test/Gremlin.Net.Benchmarks/Gremlin.Net.Benchmarks.csproj | 2 +- .../test/Gremlin.Net.IntegrationTest/Gremlin.Net.IntegrationTest.csproj | 2 +- .../Gremlin.Net.Template.IntegrationTest.csproj | 2 +- gremlin-dotnet/test/Gremlin.Net.UnitTest/Gremlin.Net.UnitTest.csproj| 2 +- 4 files changed, 4 insertions(+), 4 deletions(-)
Re: [PR] Bump Microsoft.NET.Test.Sdk from 17.7.2 to 17.8.0 in /gremlin-dotnet [tinkerpop]
FlorianHockmann merged PR #2334: URL: https://github.com/apache/tinkerpop/pull/2334 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@tinkerpop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
(tinkerpop) 01/01: Merge branch '3.7-dev'
This is an automated email from the ASF dual-hosted git repository. florianhockmann pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/tinkerpop.git commit b19b5b251aa9e07c3afb238020166cddb81232d1 Merge: f045b92794 8cf13fea59 Author: Florian Hockmann AuthorDate: Wed Nov 15 13:38:10 2023 +0100 Merge branch '3.7-dev' .../test/Gremlin.Net.Benchmarks/Gremlin.Net.Benchmarks.csproj | 2 +- .../test/Gremlin.Net.IntegrationTest/Gremlin.Net.IntegrationTest.csproj | 2 +- .../Gremlin.Net.Template.IntegrationTest.csproj | 2 +- gremlin-dotnet/test/Gremlin.Net.UnitTest/Gremlin.Net.UnitTest.csproj| 2 +- 4 files changed, 4 insertions(+), 4 deletions(-)
(tinkerpop) branch master updated (f045b92794 -> b19b5b251a)
This is an automated email from the ASF dual-hosted git repository. florianhockmann pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/tinkerpop.git from f045b92794 Merge branch '3.7-dev' add 4b470dc41a Bump Microsoft.NET.Test.Sdk from 17.7.2 to 17.8.0 in /gremlin-dotnet add 53c12e5f86 Merge branch 'dependabot/nuget/gremlin-dotnet/3.5-dev/Microsoft.NET.Test.Sdk-17.8.0' into 3.5-dev add 9b6ca18e91 Bump BenchmarkDotNet from 0.13.9 to 0.13.10 in /gremlin-dotnet add 6c26dfd5a6 Merge branch 'dependabot/nuget/gremlin-dotnet/3.5-dev/BenchmarkDotNet-0.13.10' into 3.5-dev add 7fc212b6e7 Merge branch '3.5-dev' into 3.6-dev add 8cf13fea59 Merge branch '3.6-dev' into 3.7-dev new b19b5b251a Merge branch '3.7-dev' The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: .../test/Gremlin.Net.Benchmarks/Gremlin.Net.Benchmarks.csproj | 2 +- .../test/Gremlin.Net.IntegrationTest/Gremlin.Net.IntegrationTest.csproj | 2 +- .../Gremlin.Net.Template.IntegrationTest.csproj | 2 +- gremlin-dotnet/test/Gremlin.Net.UnitTest/Gremlin.Net.UnitTest.csproj| 2 +- 4 files changed, 4 insertions(+), 4 deletions(-)
Re: [PR] Bump BenchmarkDotNet from 0.13.9 to 0.13.10 in /gremlin-dotnet [tinkerpop]
FlorianHockmann merged PR #2323: URL: https://github.com/apache/tinkerpop/pull/2323 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@tinkerpop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
(tinkerpop) branch dependabot/nuget/gremlin-dotnet/3.5-dev/Microsoft.NET.Test.Sdk-17.8.0 deleted (was 4b470dc41a)
This is an automated email from the ASF dual-hosted git repository. florianhockmann pushed a change to branch dependabot/nuget/gremlin-dotnet/3.5-dev/Microsoft.NET.Test.Sdk-17.8.0 in repository https://gitbox.apache.org/repos/asf/tinkerpop.git was 4b470dc41a Bump Microsoft.NET.Test.Sdk from 17.7.2 to 17.8.0 in /gremlin-dotnet The revisions that were on this branch are still contained in other references; therefore, this change does not discard any commits from the repository.
(tinkerpop) branch dependabot/nuget/gremlin-dotnet/3.5-dev/Microsoft.Extensions.Configuration.Json-8.0.0 updated (62d69516c0 -> 28294bb2ec)
This is an automated email from the ASF dual-hosted git repository. florianhockmann pushed a change to branch dependabot/nuget/gremlin-dotnet/3.5-dev/Microsoft.Extensions.Configuration.Json-8.0.0 in repository https://gitbox.apache.org/repos/asf/tinkerpop.git from 62d69516c0 Bump Microsoft.Extensions.Configuration.Json in /gremlin-dotnet add 28294bb2ec Remove unnecessary explicit test dependency No new revisions were added by this update. Summary of changes: .../test/Gremlin.Net.IntegrationTest/Gremlin.Net.IntegrationTest.csproj | 1 - 1 file changed, 1 deletion(-)
(tinkerpop) branch dependabot/nuget/gremlin-dotnet/3.5-dev/xunit-2.6.1 updated (1b4d1ce317 -> 5a35850614)
This is an automated email from the ASF dual-hosted git repository. florianhockmann pushed a change to branch dependabot/nuget/gremlin-dotnet/3.5-dev/xunit-2.6.1 in repository https://gitbox.apache.org/repos/asf/tinkerpop.git omit 1b4d1ce317 Bump xunit from 2.5.3 to 2.6.1 in /gremlin-dotnet new 5a35850614 Bump xunit from 2.5.3 to 2.6.1 in /gremlin-dotnet This update added new revisions after undoing existing revisions. That is to say, some revisions that were in the old version of the branch are not in the new version. This situation occurs when a user --force pushes a change and generates a repository containing something like this: * -- * -- B -- O -- O -- O (1b4d1ce317) \ N -- N -- N refs/heads/dependabot/nuget/gremlin-dotnet/3.5-dev/xunit-2.6.1 (5a35850614) You should already have received notification emails for all of the O revisions, and so the following emails describe only the N revisions from the common base, B. Any revisions marked "omit" are not gone; other references still refer to them. Any revisions marked "discard" are gone forever. The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: .../Gremlin.Net.UnitTest/Structure/IO/GraphSON/GraphSONReaderTests.cs | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
(tinkerpop) 01/01: Bump xunit from 2.5.3 to 2.6.1 in /gremlin-dotnet
This is an automated email from the ASF dual-hosted git repository. florianhockmann pushed a commit to branch dependabot/nuget/gremlin-dotnet/3.5-dev/xunit-2.6.1 in repository https://gitbox.apache.org/repos/asf/tinkerpop.git commit 5a35850614bad95a5e2f93bcb2798831f65b8838 Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> AuthorDate: Mon Nov 13 12:55:18 2023 + Bump xunit from 2.5.3 to 2.6.1 in /gremlin-dotnet Bumps [xunit](https://github.com/xunit/xunit) from 2.5.3 to 2.6.1. - [Commits](https://github.com/xunit/xunit/compare/2.5.3...2.6.1) --- updated-dependencies: - dependency-name: xunit dependency-type: direct:production update-type: version-update:semver-minor ... Had to fix one test due to a type issue related to `dynamic`: ``` Failed Gremlin.Net.UnitTest.Structure.IO.GraphSON.GraphSONReaderTests.ShouldDeserializeEmptyGList(version: 3) [10 ms] gremlin-dotnet-integration-tests| Error Message: gremlin-dotnet-integration-tests| Microsoft.CSharp.RuntimeBinder.RuntimeBinderException : The type 'object' must be a non-nullable value type in order to use it as parameter 'T' in the generic type or method 'Xunit.Assert.Equal(T[], T[])' gremlin-dotnet-integration-tests| Stack Trace: gremlin-dotnet-integration-tests| at CallSite.Target(Closure , CallSite , Type , Object[] , Object ) gremlin-dotnet-integration-tests|at System.Dynamic.UpdateDelegates.UpdateAndExecuteVoid3[T0,T1,T2](CallSite site, T0 arg0, T1 arg1, T2 arg2) gremlin-dotnet-integration-tests|at Gremlin.Net.UnitTest.Structure.IO.GraphSON.GraphSONReaderTests.ShouldDeserializeEmptyGList(Int32 version) in /gremlin-dotnet/test/Gremlin.Net.UnitTest/Structure/IO/GraphSON/GraphSONReaderTests.cs:line 480 ``` --- .../Gremlin.Net.IntegrationTest/Gremlin.Net.IntegrationTest.csproj| 2 +- .../Gremlin.Net.Template.IntegrationTest.csproj | 2 +- gremlin-dotnet/test/Gremlin.Net.UnitTest/Gremlin.Net.UnitTest.csproj | 2 +- .../Gremlin.Net.UnitTest/Structure/IO/GraphSON/GraphSONReaderTests.cs | 4 ++-- 4 files changed, 5 insertions(+), 5 deletions(-) diff --git a/gremlin-dotnet/test/Gremlin.Net.IntegrationTest/Gremlin.Net.IntegrationTest.csproj b/gremlin-dotnet/test/Gremlin.Net.IntegrationTest/Gremlin.Net.IntegrationTest.csproj index cd39a2e32a..984d47dca5 100644 --- a/gremlin-dotnet/test/Gremlin.Net.IntegrationTest/Gremlin.Net.IntegrationTest.csproj +++ b/gremlin-dotnet/test/Gremlin.Net.IntegrationTest/Gremlin.Net.IntegrationTest.csproj @@ -16,7 +16,7 @@ - + diff --git a/gremlin-dotnet/test/Gremlin.Net.Template.IntegrationTest/Gremlin.Net.Template.IntegrationTest.csproj b/gremlin-dotnet/test/Gremlin.Net.Template.IntegrationTest/Gremlin.Net.Template.IntegrationTest.csproj index 3ed4b1f21b..8411e9fdf9 100644 --- a/gremlin-dotnet/test/Gremlin.Net.Template.IntegrationTest/Gremlin.Net.Template.IntegrationTest.csproj +++ b/gremlin-dotnet/test/Gremlin.Net.Template.IntegrationTest/Gremlin.Net.Template.IntegrationTest.csproj @@ -6,7 +6,7 @@ - + diff --git a/gremlin-dotnet/test/Gremlin.Net.UnitTest/Gremlin.Net.UnitTest.csproj b/gremlin-dotnet/test/Gremlin.Net.UnitTest/Gremlin.Net.UnitTest.csproj index b9b008bc08..28bf3aa2d7 100644 --- a/gremlin-dotnet/test/Gremlin.Net.UnitTest/Gremlin.Net.UnitTest.csproj +++ b/gremlin-dotnet/test/Gremlin.Net.UnitTest/Gremlin.Net.UnitTest.csproj @@ -15,7 +15,7 @@ - + diff --git a/gremlin-dotnet/test/Gremlin.Net.UnitTest/Structure/IO/GraphSON/GraphSONReaderTests.cs b/gremlin-dotnet/test/Gremlin.Net.UnitTest/Structure/IO/GraphSON/GraphSONReaderTests.cs index b42f973bd4..d52305767f 100644 --- a/gremlin-dotnet/test/Gremlin.Net.UnitTest/Structure/IO/GraphSON/GraphSONReaderTests.cs +++ b/gremlin-dotnet/test/Gremlin.Net.UnitTest/Structure/IO/GraphSON/GraphSONReaderTests.cs @@ -475,9 +475,9 @@ namespace Gremlin.Net.UnitTest.Structure.IO.GraphSON var reader = CreateStandardGraphSONReader(version); var jsonElement = JsonSerializer.Deserialize(graphSon); -var deserializedValue = reader.ToObject(jsonElement); +object[] deserializedValue = reader.ToObject(jsonElement); -Assert.Equal(new object[0], deserializedValue); +Assert.Equal(Array.Empty(), deserializedValue); } [Theory, MemberData(nameof(VersionsSupportingCollections))]
