Re: [PR] TINKERPOP-3030 Update to .NET 8 [tinkerpop]
FlorianHockmann commented on PR #2468: URL: https://github.com/apache/tinkerpop/pull/2468#issuecomment-1924148227 Just to clarify: This PR doesn't change which frameworks we support with Gremlin.Net. It's only about which frameworks we use to build and test it. Gremlin.Net mainly [targets .NET Standard 2.0](https://github.com/apache/tinkerpop/blob/master/gremlin-dotnet/src/Gremlin.Net/Gremlin.Net.csproj#L21) which is implemented by various .NET frameworks like .NET 5, .NET 6, .NET 7, and .NET 8. It has .NET 6 as an additional explicit target because we optionally use some APIs which were only introduced in .NET 6 to support Websocket compression. This can therefore only be used by users on .NET 6 and higher. Before this PR, we built and tested Gremlin.Net with .NET 6. With this PR, we're using .NET 8 instead. But users can still stay on .NET 6 (or 7 or whatever) and use newer versions of Gremlin.Net with it. Not sure if this was clear to you and you just wanted to propose that we **test** against .NET 6 **and** .NET 8. In that case, I agree with you in general that it would be good to test on both frameworks (or better to say runtimes in this case). The problem with that however is that all contributors then also need both runtimes installed. If you just have .NET 8 installed, then the tests will fail as you also need .NET 6 in that case. That's also why we always use the same version across all release branches. In the end, the question comes down to how many contributors are actually affected by this and how often do we expect to find version specific bugs because of it. I guess many contributors simply don't execute .NET tests on their machines and leave that up to GH Actions or they use the Docker based setup to execute the tests. So, this probably doesn't affect many contributors. On the other hand, [TINKERPOP-3029](https://issues.apache.org/jira/browse/TINKERPOP-3029) is also the only bug that comes to my mind which we could have catched by executing tests on different runtimes. Although I think it wouldn't have helped much as we still would have to be on .NET 8 in the first place to find it. So, the better question is how often a bug occurs that is specific to an **older** framework than the latest LTS version which we want to use by default. I don't have a strong opinion on this. If we are confident that this doesn't really affect contributors negatively, then I'm in favor of executing the tests on multiple runtimes. Otherwise, I'd stay with our current approach. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@tinkerpop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
(tinkerpop) branch dependabot/pip/gremlin-python/src/main/python/3.6-dev/multidict-6.0.5 created (now 5dcfc5e919)
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch dependabot/pip/gremlin-python/src/main/python/3.6-dev/multidict-6.0.5 in repository https://gitbox.apache.org/repos/asf/tinkerpop.git at 5dcfc5e919 Bump multidict from 6.0.4 to 6.0.5 in /gremlin-python/src/main/python No new revisions were added by this update.
[PR] Bump multidict from 6.0.4 to 6.0.5 in /gremlin-python/src/main/python [tinkerpop]
dependabot[bot] opened a new pull request, #2477:
URL: https://github.com/apache/tinkerpop/pull/2477
Bumps [multidict](https://github.com/aio-libs/multidict) from 6.0.4 to 6.0.5.
Release notes
Sourced from https://github.com/aio-libs/multidict/releases";>multidict's
releases.
6.0.5
Bug fixes
Upgraded the C-API macros that have been deprecated in Python 3.9 and
later removed in 3.13 -- by https://github.com/iemelyanov";>@​iemelyanovhttps://github.com/sponsors/iemelyanov";>💰.
Related issues and pull requests on GitHub: https://redirect.github.com/aio-libs/multidict/issues/862";>#862, https://redirect.github.com/aio-libs/multidict/issues/864";>#864, https://redirect.github.com/aio-libs/multidict/issues/868";>#868, https://redirect.github.com/aio-libs/multidict/issues/898";>#898.
Reverted to using the public argument parsing API
PyArg_ParseTupleAndKeywords() under Python 3.12 -- by https://github.com/charles-dyfis-net";>@​charles-dyfis-nethttps://github.com/sponsors/charles-dyfis-net";>💰 and https://github.com/webknjaz";>@​webknjazhttps://github.com/sponsors/webknjaz";>💰.
The effect is that this change prevents build failures with clang 16.9.6
and gcc-14 reported in https://redirect.github.com/aio-libs/multidict/issues/926";>#926. It
also fixes a segmentation fault crash caused by passing keyword arguments to
MultiDict.getall() discovered by https://github.com/jonaslb";>@​jonaslbhttps://github.com/sponsors/jonaslb";>💰 and https://github.com/hroncok";>@​hroncokhttps://github.com/sponsors/hroncok";>💰 while examining the
problem.
Related issues and pull requests on GitHub: https://redirect.github.com/aio-libs/multidict/issues/862";>#862, https://redirect.github.com/aio-libs/multidict/issues/909";>#909, https://redirect.github.com/aio-libs/multidict/issues/926";>#926, https://redirect.github.com/aio-libs/multidict/issues/929";>#929.
Fixed a SystemError: null argument to internal routine error
on a MultiDict.items().isdisjoint() call when using C
Extensions.
Related issues and pull requests on GitHub: https://redirect.github.com/aio-libs/multidict/issues/927";>#927.
Improved documentation
On the https://github.com/aio-libs/multidict/blob/master/CHANGES/#readme";>Contributing
docs age, a link to the Towncrier philosophy has been
fixed.
Related issues and pull requests on GitHub: https://redirect.github.com/aio-libs/multidict/issues/911";>#911.
Packaging updates and notes for downstreams
Stopped marking all files as installable package data -- by https://github.com/webknjaz";>@​webknjazhttps://github.com/sponsors/webknjaz";>💰.
This change helps setuptools understand that C-headers are
not to be installed under lib/python3.{x}/site-packages/.
Related commits on GitHub: 31e1170.
... (truncated)
Changelog
Sourced from https://github.com/aio-libs/multidict/blob/master/CHANGES.rst";>multidict's
changelog.
6.0.5 (2024-02-01)
Bug fixes
Upgraded the C-API macros that have been deprecated in Python 3.9
and later removed in 3.13 -- by :user:iemelyanov.
Related issues and pull requests on GitHub:
:issue:862, :issue:864, :issue:868,
:issue:898.
Reverted to using the public argument parsing API
:c:func:PyArg_ParseTupleAndKeywords under Python 3.12
-- by :user:charles-dyfis-net and
:user:webknjaz.
The effect is that this change prevents build failures with
clang 16.9.6 and gcc-14 reported in :issue:926. It also
fixes a segmentation fault crash caused by passing keyword
arguments to :py:meth:MultiDict.getall()
discovered by
:user:jonaslb
and :user:hroncok while examining the problem.
Related issues and pull requests on GitHub:
:issue:862, :issue:909, :issue:926,
:issue:929.
Fixed a SystemError: null argument to internal routine error
on
a MultiDict.items().isdisjoint() call when using C
Extensions.
Related issues and pull requests on GitHub:
:issue:927.
Improved documentation
On the Contributing docs
;_
page,
a link to the Towncrier philosophy has been fixed.
Related issues and pull requests on GitHub:
... (truncated)
Commits
https://github.com/aio-libs/multidict/commit/a9b281b2ef4ab25d95d6b268aa88c428e75c3696";>a9b281b
⇪ 📦 Release v6.0.5
https://github.com/aio-libs/multidict/commit/ed825c85eaa7d9518e00ad38cdc74c8daec9f09a";>ed825c8
🧪 Download artifacts to dist/ @ release job
https://github.com/aio-libs/multidict/commit/7b04a64337ac0765f0aff6d2afc18480a9738c15";>7b04a64
🧪 Normalize issue refs @ release action
https://github.com/aio-libs/multidict/commit/74840e8fdf84e4617054f3fe6581a5ec5e507554";>74840e8
🧪 Pass Codecov token to reusable linters job
https://github.com/aio-libs/multidict/commit/
Re: [PR] Bump @types/node from 20.10.3 to 20.11.16 in /docs/gremlint [tinkerpop]
codecov-commenter commented on PR #2476: URL: https://github.com/apache/tinkerpop/pull/2476#issuecomment-1923996561 ## [Codecov](https://app.codecov.io/gh/apache/tinkerpop/pull/2476?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report All modified and coverable lines are covered by tests :white_check_mark: > Comparison is base [(`963bece`)](https://app.codecov.io/gh/apache/tinkerpop/commit/963bece33ce0f662ea8e6106b1128e27b587aaed?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) 76.53% compared to head [(`cbdedad`)](https://app.codecov.io/gh/apache/tinkerpop/pull/2476?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) 71.08%. Additional details and impacted files ```diff @@ Coverage Diff @@ ## master#2476 +/- ## - Coverage 76.53% 71.08% -5.45% Files 1059 25-1034 Lines 61119 3949 -57170 Branches 72710-7271 - Hits 46775 2807 -43968 + Misses11839 951 -10888 + Partials 2505 191-2314 ``` [:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/tinkerpop/pull/2476?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). :loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@tinkerpop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
(tinkerpop) branch dependabot/npm_and_yarn/docs/gremlint/master/types/node-20.11.15 deleted (was 06d0d32ee2)
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch dependabot/npm_and_yarn/docs/gremlint/master/types/node-20.11.15 in repository https://gitbox.apache.org/repos/asf/tinkerpop.git was 06d0d32ee2 Bump @types/node from 20.10.3 to 20.11.15 in /docs/gremlint The revisions that were on this branch are still contained in other references; therefore, this change does not discard any commits from the repository.
[PR] Bump @types/node from 20.10.3 to 20.11.16 in /docs/gremlint [tinkerpop]
dependabot[bot] opened a new pull request, #2476: URL: https://github.com/apache/tinkerpop/pull/2476 Bumps [@types/node](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/node) from 20.10.3 to 20.11.16. Commits See full diff in https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/node";>compare view [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@tinkerpop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump @types/node from 20.10.3 to 20.11.15 in /docs/gremlint [tinkerpop]
dependabot[bot] closed pull request #2473: Bump @types/node from 20.10.3 to 20.11.15 in /docs/gremlint URL: https://github.com/apache/tinkerpop/pull/2473 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@tinkerpop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump @types/node from 20.10.3 to 20.11.15 in /docs/gremlint [tinkerpop]
dependabot[bot] commented on PR #2473: URL: https://github.com/apache/tinkerpop/pull/2473#issuecomment-1923960670 Superseded by #2476. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@tinkerpop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
(tinkerpop) branch dependabot/npm_and_yarn/docs/gremlint/master/types/node-20.11.16 created (now cbdedad14d)
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch dependabot/npm_and_yarn/docs/gremlint/master/types/node-20.11.16 in repository https://gitbox.apache.org/repos/asf/tinkerpop.git at cbdedad14d Bump @types/node from 20.10.3 to 20.11.16 in /docs/gremlint No new revisions were added by this update.
Re: [PR] TINKERPOP-3045: EarlyLimitStrategy is too aggresive to promote Limit … [tinkerpop]
spmallette commented on PR #2475: URL: https://github.com/apache/tinkerpop/pull/2475#issuecomment-1923659468 for other committers, i will help backfill some extra tests on this one, deal with CHANGELOG, etc. on merge -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@tinkerpop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] TINKERPOP-3045: EarlyLimitStrategy is too aggresive to promote Limit … [tinkerpop]
spmallette commented on code in PR #2475:
URL: https://github.com/apache/tinkerpop/pull/2475#discussion_r1475959778
##
gremlin-test/src/main/resources/org/apache/tinkerpop/gremlin/test/features/filter/Range.feature:
##
@@ -280,4 +280,16 @@ Feature: Step - range()
When iterated to list
Then the result should be unordered
| result |
- | d[29].i |
\ No newline at end of file
+ | d[29].i |
+
+ Scenario: g_V_mapXinX_limitX2X_valuesXnameX
+Given the modern graph
+And the traversal of
+ """
+ g.V().map(__.in()).limit(2).values('name')
Review Comment:
nit: we prefer double quotes for strings in our feature tests as a
convention.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] TINKERPOP-3045: EarlyLimitStrategy is too aggresive to promote Limit … [tinkerpop]
spmallette commented on code in PR #2475: URL: https://github.com/apache/tinkerpop/pull/2475#discussion_r1475959035 ## gremlin-core/pom.xml: ## @@ -101,6 +101,16 @@ limitations under the License. hamcrest test + Review Comment: it looks like there is relatively minor usage of guava and lombok. could you please adjust the `StepOutputArityPredictor` to not use these libraries so that we don't need to take the dependency? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@tinkerpop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
