Re: [PR] TINKERPOP-3030 Update to .NET 8 [tinkerpop]
Cole-Greer commented on PR #2468: URL: https://github.com/apache/tinkerpop/pull/2468#issuecomment-1939207359 In general I like the idea of testing both .NET 6 and .NET 8 in GHA similar to how Java is currently setup (I don't see a need for contributors to run both locally). In my mind testing both runtimes gives the strongest guarantee against issues which only appear for specific versions. .NET compatibility is not something I know very well however so I will defer to @FlorianHockmann and @vkagamlyk to determine what level of testing is required. VOTE +0 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@tinkerpop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump aiohttp from 3.8.0 to 3.9.3 in /gremlin-python/src/main/python [tinkerpop]
codecov-commenter commented on PR #2466: URL: https://github.com/apache/tinkerpop/pull/2466#issuecomment-1939280603 ## [Codecov](https://app.codecov.io/gh/apache/tinkerpop/pull/2466?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report All modified and coverable lines are covered by tests :white_check_mark: > Comparison is base [(`d2303d5`)](https://app.codecov.io/gh/apache/tinkerpop/commit/d2303d5fad750a2741016babcdba441b57883643?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) 75.16% compared to head [(`df31b30`)](https://app.codecov.io/gh/apache/tinkerpop/pull/2466?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) 75.18%. > Report is 3 commits behind head on 3.6-dev. Additional details and impacted files ```diff @@ Coverage Diff @@ ## 3.6-dev#2466 +/- ## = + Coverage 75.16% 75.18% +0.01% - Complexity 1232712331 +4 = Files 1057 1057 Lines 6349663496 Branches6944 6944 = + Hits 4772947737 +8 + Misses 1319813189 -9 - Partials2569 2570 +1 ``` [:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/tinkerpop/pull/2466?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). :loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@tinkerpop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] Remove gremlin-archetypes [tinkerpop]
ryn5 opened a new pull request, #2486: URL: https://github.com/apache/tinkerpop/pull/2486 Removes the gremlin-archetypes module since newer sample applications have been added to the repo (#2298) as discussed in https://lists.apache.org/thread/qr0f2cwc6bx5v0wdf1oyo4q6k58l1vf0. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@tinkerpop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Remove gremlin-archetypes [tinkerpop]
codecov-commenter commented on PR #2486: URL: https://github.com/apache/tinkerpop/pull/2486#issuecomment-1940237659 ## [Codecov](https://app.codecov.io/gh/apache/tinkerpop/pull/2486?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report All modified and coverable lines are covered by tests :white_check_mark: > Comparison is base [(`d804e4a`)](https://app.codecov.io/gh/apache/tinkerpop/commit/d804e4a3b9d7d12c679e218abc24091453031467?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) 76.14% compared to head [(`0c6f39d`)](https://app.codecov.io/gh/apache/tinkerpop/pull/2486?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) 71.05%. Additional details and impacted files ```diff @@ Coverage Diff @@ ## 3.7-dev#2486 +/- ## = - Coverage 76.14% 71.05% -5.09% = Files 1084 25-1059 Lines 65160 3942 -61218 Branches72850-7285 = - Hits 49613 2801 -46812 + Misses 12842 950 -11892 + Partials2705 191-2514 ``` [:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/tinkerpop/pull/2486?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). :loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@tinkerpop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] TINKERPOP-3030 Update to .NET 8 [tinkerpop]
FlorianHockmann commented on PR #2468: URL: https://github.com/apache/tinkerpop/pull/2468#issuecomment-1938856875 > did you leave src\Gremlin.Net\Gremlin.Net.csproj unchanged on purpose? Yes, we still only target .NET Standard 2.0 and .NET 6. .NET 6 is there also only because we're using Websocket compression which wasn't present in .NET Standard, but was only added in .NET 6. Users on .NET 7 or 8 can of course still use Gremlin.Net. They should get the version built for .NET 6 in that case. We could of course add another target for .NET 7 and/or .NET 8, but I think that doesn't add any benefit if we're not using any APIs specific for these versions. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@tinkerpop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
