Re: [PR] [TINKERPOP-3082] Allow specifying a customized Spark AppName [tinkerpop]
kenhuuu commented on PR #2634: URL: https://github.com/apache/tinkerpop/pull/2634#issuecomment-2148679915 Sorry again for not being clear about where to add the CHANGELOG entry. After you move that line, I will merge this PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@tinkerpop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [TINKERPOP-3082] Allow specifying a customized Spark AppName [tinkerpop]
kenhuuu commented on code in PR #2634: URL: https://github.com/apache/tinkerpop/pull/2634#discussion_r1626800701 ## CHANGELOG.asciidoc: ## @@ -64,6 +64,7 @@ This release also includes changes from <>. * TINKERPOP-3021 Publish ARM64 Gremlin Console Images * TINKERPOP-3030 Update to .NET 8 * TINKERPOP-3068 Make serviceName and mergedParams public for provider usage in CallStep +* TINKERPOP-3082 Allow specifying a customized Spark app name Review Comment: Sorry, I should have been more specific. Please remove this and add something like `Allow specifying a customized Spark app name` to https://github.com/apache/tinkerpop/blob/3.7-dev/CHANGELOG.asciidoc?plain=1#L30 This "Improvements" section is automatically generated during release so it shouldn't be manually modified. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@tinkerpop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [TINKERPOP-3082] Allow specifying a customized Spark AppName [tinkerpop]
Cole-Greer commented on PR #2634: URL: https://github.com/apache/tinkerpop/pull/2634#issuecomment-2148621028 Thanks @ministat, LGTM VOTE +1 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@tinkerpop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [TINKERPOP-3082] Allow specifying a customized Spark AppName [tinkerpop]
vkagamlyk commented on PR #2634: URL: https://github.com/apache/tinkerpop/pull/2634#issuecomment-2148618787 VOTE+1 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@tinkerpop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
(tinkerpop) branch master-http updated: Fix gremlin-util tests CTR.
This is an automated email from the ASF dual-hosted git repository.
kenhuuu pushed a commit to branch master-http
in repository https://gitbox.apache.org/repos/asf/tinkerpop.git
The following commit(s) were added to refs/heads/master-http by this push:
new 999e67310e Fix gremlin-util tests CTR.
999e67310e is described below
commit 999e67310e4db1d77ff6993aacb85433ea0903db
Author: Ken Hu <106191785+kenh...@users.noreply.github.com>
AuthorDate: Tue May 28 23:31:18 2024 -0700
Fix gremlin-util tests CTR.
---
.../gremlin/util/ser/AbstractGraphSONMessageSerializerV4.java| 4
.../tinkerpop/gremlin/util/ser/GraphBinaryMessageSerializerV4.java | 4
.../tinkerpop/gremlin/util/ser/GraphSONMessageSerializerV4Test.java | 3 ++-
.../gremlin/util/ser/binary/GraphBinaryMessageSerializerV4Test.java | 2 +-
.../util/ser/binary/types/sample/SamplePersonSerializerTest.java | 5 +++--
5 files changed, 14 insertions(+), 4 deletions(-)
diff --git
a/gremlin-util/src/main/java/org/apache/tinkerpop/gremlin/util/ser/AbstractGraphSONMessageSerializerV4.java
b/gremlin-util/src/main/java/org/apache/tinkerpop/gremlin/util/ser/AbstractGraphSONMessageSerializerV4.java
index 34febf0b1b..ae5868b4f3 100644
---
a/gremlin-util/src/main/java/org/apache/tinkerpop/gremlin/util/ser/AbstractGraphSONMessageSerializerV4.java
+++
b/gremlin-util/src/main/java/org/apache/tinkerpop/gremlin/util/ser/AbstractGraphSONMessageSerializerV4.java
@@ -97,6 +97,10 @@ public abstract class AbstractGraphSONMessageSerializerV4
extends AbstractMessag
@Override
public ByteBuf serializeResponseAsBinary(final ResponseMessageV4
responseMessage, final ByteBufAllocator allocator) throws
SerializationException {
+if (null == responseMessage.getStatus()) {
+throw new SerializationException("ResponseStatusV4 can't be null
when serializing a full ResponseMessageV4.");
+}
+
return writeHeader(responseMessage, allocator);
}
diff --git
a/gremlin-util/src/main/java/org/apache/tinkerpop/gremlin/util/ser/GraphBinaryMessageSerializerV4.java
b/gremlin-util/src/main/java/org/apache/tinkerpop/gremlin/util/ser/GraphBinaryMessageSerializerV4.java
index f5b6fff101..d98c7cfd85 100644
---
a/gremlin-util/src/main/java/org/apache/tinkerpop/gremlin/util/ser/GraphBinaryMessageSerializerV4.java
+++
b/gremlin-util/src/main/java/org/apache/tinkerpop/gremlin/util/ser/GraphBinaryMessageSerializerV4.java
@@ -186,6 +186,10 @@ public class GraphBinaryMessageSerializerV4 extends
AbstractMessageSerializerV4<
@Override
public ByteBuf serializeResponseAsBinary(final ResponseMessageV4
responseMessage, final ByteBufAllocator allocator) throws
SerializationException {
+if (null == responseMessage.getStatus()) {
+throw new SerializationException("ResponseStatusV4 can't be null
when serializing a full ResponseMessageV4.");
+}
+
return writeHeader(responseMessage, allocator);
}
diff --git
a/gremlin-util/src/test/java/org/apache/tinkerpop/gremlin/util/ser/GraphSONMessageSerializerV4Test.java
b/gremlin-util/src/test/java/org/apache/tinkerpop/gremlin/util/ser/GraphSONMessageSerializerV4Test.java
index 7f56f76265..1fd82dc76d 100644
---
a/gremlin-util/src/test/java/org/apache/tinkerpop/gremlin/util/ser/GraphSONMessageSerializerV4Test.java
+++
b/gremlin-util/src/test/java/org/apache/tinkerpop/gremlin/util/ser/GraphSONMessageSerializerV4Test.java
@@ -270,7 +270,8 @@ public class GraphSONMessageSerializerV4Test {
}
private ResponseMessageV4 convert(final Object toSerialize,
MessageSerializerV4 serializer) throws SerializationException {
-final ByteBuf bb =
serializer.serializeResponseAsBinary(responseMessageBuilder.result(Collections.singletonList(toSerialize)).create(),
allocator);
+final ByteBuf bb = serializer.serializeResponseAsBinary(
+
responseMessageBuilder.result(Collections.singletonList(toSerialize)).code(HttpResponseStatus.OK).create(),
allocator);
return serializer.deserializeBinaryResponse(bb);
}
}
diff --git
a/gremlin-util/src/test/java/org/apache/tinkerpop/gremlin/util/ser/binary/GraphBinaryMessageSerializerV4Test.java
b/gremlin-util/src/test/java/org/apache/tinkerpop/gremlin/util/ser/binary/GraphBinaryMessageSerializerV4Test.java
index 4403e9584b..df95403306 100644
---
a/gremlin-util/src/test/java/org/apache/tinkerpop/gremlin/util/ser/binary/GraphBinaryMessageSerializerV4Test.java
+++
b/gremlin-util/src/test/java/org/apache/tinkerpop/gremlin/util/ser/binary/GraphBinaryMessageSerializerV4Test.java
@@ -42,7 +42,7 @@ public class GraphBinaryMessageSerializerV4Test {
private final ByteBufAllocator allocator = ByteBufAllocator.DEFAULT;
private final GraphBinaryMessageSerializerV4 serializer = new
GraphBinaryMessageSerializerV4();
-private static class SampleTypeSerializerRegistryBuilder extends
TypeSerializerRegistry.Builder {
+public static class
(tinkerpop) branch TINKERPOP-3028 updated (648b1f9270 -> a55e543aec)
This is an automated email from the ASF dual-hosted git repository. spmallette pushed a change to branch TINKERPOP-3028 in repository https://gitbox.apache.org/repos/asf/tinkerpop.git discard 648b1f9270 Get C# tests working by properly ignoring tests that include lambdas that aren't translated discard 546c1534b0 rebase discard 3e91d0dc3c rebased discard 51dd752b36 Refactored after rebase of withoutStrategies addition discard 63eec30106 Removed breaking change on SeedStrategy and tucked in some javadoc discard c21c487c82 update golang translation discard caa0289430 wip for Go discard 09d0e8b4c4 .NET discard 826b945e03 groovy discard b5f1925641 TINKERPOP-3028 Translators using grammar add e0e15679be Adding Getters to make step fields available for vendor implementations. add 04eed23511 Merge branch '3.7-dev' new a55e543aec TINKERPOP-3028 Translators using grammar This update added new revisions after undoing existing revisions. That is to say, some revisions that were in the old version of the branch are not in the new version. This situation occurs when a user --force pushes a change and generates a repository containing something like this: * -- * -- B -- O -- O -- O (648b1f9270) \ N -- N -- N refs/heads/TINKERPOP-3028 (a55e543aec) You should already have received notification emails for all of the O revisions, and so the following emails describe only the N revisions from the common base, B. Any revisions marked "omit" are not gone; other references still refer to them. Any revisions marked "discard" are gone forever. The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: .../tinkerpop/gremlin/process/traversal/step/map/DateAddStep.java | 8 .../gremlin/process/traversal/step/map/DateDiffStep.java | 8 2 files changed, 16 insertions(+)
Re: [PR] [TINKERPOP-3060] Manage the versions of snappy-java and jackson-* centrally to avoid version conflict. [tinkerpop]
xiazcy commented on PR #2546: URL: https://github.com/apache/tinkerpop/pull/2546#issuecomment-2148166240 Hi @HappyHacker123, much apologies for the late reply. I gave it some more thoughts, and while this will be a great improvement, I don't think we are quite ready to centralize these dependencies yet. The complexity is mainly due to the way dependencies are currently managed that’s leading to conflicts and may require module-specific versions, especially in hadoop and spark modules (as you may see some of the code comments in the poms). We are looking to improve this systemically, but before a decision is reached I think we’ll hold off on this PR and close it for now. If you are still interested and have thoughts or recommendations related to dependency management, chime into our discussions for [removing gremlin-shaded](https://lists.apache.org/thread/m7yvvz9zc69nzn0nr6vz0tdo3ggffoy6) and [JPMS](https://lists.apache.org/thread/vkvqcxn6t2lsgpfym7v3g3qvksrh3cwc). We'd love to see more opinions on these topics. Again, thank you for taking the time submitting this PR! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@tinkerpop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
(tinkerpop) branch dependabot/npm_and_yarn/docs/gremlint/master/types/node-20.14.0 deleted (was c93c67e7c9)
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch dependabot/npm_and_yarn/docs/gremlint/master/types/node-20.14.0 in repository https://gitbox.apache.org/repos/asf/tinkerpop.git was c93c67e7c9 Bump @types/node from 20.11.23 to 20.14.0 in /docs/gremlint The revisions that were on this branch are still contained in other references; therefore, this change does not discard any commits from the repository.
[PR] Bump @types/node from 20.11.23 to 20.14.1 in /docs/gremlint [tinkerpop]
dependabot[bot] opened a new pull request, #2636: URL: https://github.com/apache/tinkerpop/pull/2636 Bumps [@types/node](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/node) from 20.11.23 to 20.14.1. Commits See full diff in https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/node;>compare view [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@tinkerpop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
(tinkerpop) branch dependabot/npm_and_yarn/docs/gremlint/master/types/node-20.14.1 created (now 649667ffbb)
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch dependabot/npm_and_yarn/docs/gremlint/master/types/node-20.14.1 in repository https://gitbox.apache.org/repos/asf/tinkerpop.git at 649667ffbb Bump @types/node from 20.11.23 to 20.14.1 in /docs/gremlint No new revisions were added by this update.
Re: [PR] Bump @types/node from 20.11.23 to 20.14.0 in /docs/gremlint [tinkerpop]
dependabot[bot] commented on PR #2631: URL: https://github.com/apache/tinkerpop/pull/2631#issuecomment-2147727245 Superseded by #2636. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@tinkerpop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump @types/node from 20.11.23 to 20.14.0 in /docs/gremlint [tinkerpop]
dependabot[bot] closed pull request #2631: Bump @types/node from 20.11.23 to 20.14.0 in /docs/gremlint URL: https://github.com/apache/tinkerpop/pull/2631 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@tinkerpop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
(tinkerpop) branch dependabot/npm_and_yarn/gremlint/3.6-dev/types/node-20.14.0 deleted (was c5d40d82b5)
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch dependabot/npm_and_yarn/gremlint/3.6-dev/types/node-20.14.0 in repository https://gitbox.apache.org/repos/asf/tinkerpop.git was c5d40d82b5 Bump @types/node from 20.11.10 to 20.14.0 in /gremlint The revisions that were on this branch are still contained in other references; therefore, this change does not discard any commits from the repository.
(tinkerpop) branch dependabot/npm_and_yarn/gremlint/3.6-dev/types/node-20.14.1 created (now 1e4dbab64a)
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch dependabot/npm_and_yarn/gremlint/3.6-dev/types/node-20.14.1 in repository https://gitbox.apache.org/repos/asf/tinkerpop.git at 1e4dbab64a Bump @types/node from 20.11.10 to 20.14.1 in /gremlint No new revisions were added by this update.
Re: [PR] Bump @types/node from 20.11.10 to 20.14.0 in /gremlint [tinkerpop]
dependabot[bot] closed pull request #2628: Bump @types/node from 20.11.10 to 20.14.0 in /gremlint URL: https://github.com/apache/tinkerpop/pull/2628 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@tinkerpop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] Bump @types/node from 20.11.10 to 20.14.1 in /gremlint [tinkerpop]
dependabot[bot] opened a new pull request, #2635: URL: https://github.com/apache/tinkerpop/pull/2635 Bumps [@types/node](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/node) from 20.11.10 to 20.14.1. Commits See full diff in https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/node;>compare view [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@tinkerpop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump @types/node from 20.11.10 to 20.14.0 in /gremlint [tinkerpop]
dependabot[bot] commented on PR #2628: URL: https://github.com/apache/tinkerpop/pull/2628#issuecomment-2147688862 Superseded by #2635. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@tinkerpop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [TINKERPOP-3082] Allow specifying a customized Spark AppName [tinkerpop]
ministat commented on code in PR #2634:
URL: https://github.com/apache/tinkerpop/pull/2634#discussion_r1626069017
##
spark-gremlin/src/test/java/org/apache/tinkerpop/gremlin/spark/structure/SparkTest.java:
##
@@ -51,6 +51,15 @@
* @author Marko A. Rodriguez (http://markorodriguez.com)
*/
public class SparkTest extends AbstractSparkTest {
+@Test
+public void testCustomizedSparkAppName() {
+ final String appName = "SparkAppNameTest";
+ final org.apache.spark.SparkConf sparkConfiguration = new
org.apache.spark.SparkConf();
Review Comment:
No special purpose. My impression is many "import" sometimes brings trouble
and confusion to the current file namespace, like the
org.apache.commons.configuration2.Configuration and
org.apache.commons.configuration.Configuration. So, I tried to avoid that. In
addition, org.apache.spark.SparkConf is not too long and not impact the reading.
##
spark-gremlin/src/test/java/org/apache/tinkerpop/gremlin/spark/structure/SparkTest.java:
##
@@ -51,6 +51,15 @@
* @author Marko A. Rodriguez (http://markorodriguez.com)
*/
public class SparkTest extends AbstractSparkTest {
+@Test
+public void testCustomizedSparkAppName() {
Review Comment:
Good idea. I'll add one.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
(tinkerpop) branch master updated (84d1005fb4 -> 04eed23511)
This is an automated email from the ASF dual-hosted git repository. spmallette pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/tinkerpop.git from 84d1005fb4 Merge branch '3.7-dev' add e0e15679be Adding Getters to make step fields available for vendor implementations. new 04eed23511 Merge branch '3.7-dev' The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: .../tinkerpop/gremlin/process/traversal/step/map/DateAddStep.java | 8 .../gremlin/process/traversal/step/map/DateDiffStep.java | 8 2 files changed, 16 insertions(+)
(tinkerpop) 01/01: Merge branch '3.7-dev'
This is an automated email from the ASF dual-hosted git repository. spmallette pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/tinkerpop.git commit 04eed23511810f5b9fea27fb9f0b28786594265e Merge: 84d1005fb4 e0e15679be Author: Stephen Mallette AuthorDate: Tue Jun 4 07:11:54 2024 -0400 Merge branch '3.7-dev' .../tinkerpop/gremlin/process/traversal/step/map/DateAddStep.java | 8 .../gremlin/process/traversal/step/map/DateDiffStep.java | 8 2 files changed, 16 insertions(+)
(tinkerpop) branch 3.7-dev updated (299bab5544 -> e0e15679be)
This is an automated email from the ASF dual-hosted git repository. spmallette pushed a change to branch 3.7-dev in repository https://gitbox.apache.org/repos/asf/tinkerpop.git from 299bab5544 Merge branch '3.6-dev' into 3.7-dev add e0e15679be Adding Getters to make step fields available for vendor implementations. No new revisions were added by this update. Summary of changes: .../tinkerpop/gremlin/process/traversal/step/map/DateAddStep.java | 8 .../gremlin/process/traversal/step/map/DateDiffStep.java | 8 2 files changed, 16 insertions(+)
Re: [PR] Adding Getters to make step fields available for vendor implementations. [tinkerpop]
spmallette merged PR #2633: URL: https://github.com/apache/tinkerpop/pull/2633 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@tinkerpop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
